GitLab

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2288613004
Cr-Commit-Position: refs/heads/master@{#415174}

Review-Url: https://codereview.chromium.org/2287223003
Cr-Commit-Position: refs/heads/master@{#415173}

When converting arrays to keys, only own properties should be
considered, much like clones. Otherwise, this opens up the behavior to
side effects via getters on the Object/Array prototype even if the
value being converted to a key is a clone.

BUG=641101
R=haraken@chromium.org

Review-Url: https://codereview.chromium.org/2279343002
Cr-Commit-Position: refs/heads/master@{#415172}

The image is converted into an SkBitmap, which has no concept of retina-ness. In
the previous behavior, Chrome would maintain the image size but lose half the
pixels. In the new behavior, Chrome keeps all the pixels and doubles the size of
the SkBitmap.

BUG=355477

Review-Url: https://codereview.chromium.org/2276183002
Cr-Commit-Position: refs/heads/master@{#415171}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- easy_unlock_private
- input_api

Note: input_api had some tests which were incorrectly passing,
even though an error was being thrown. See crbug.com/641425

BUG=634140

Review-Url: https://codereview.chromium.org/2285573002
Cr-Commit-Position: refs/heads/master@{#415170}

Chrome browser compositor sends the primary buffer as a
normal overlay, therefore the optimization to replace the
primary plane can be done earlier in the browser compositor (crrev.com/2281033003).

This CL removes the optimization in Ozone.

BUG=b/29430506

Review-Url: https://codereview.chromium.org/2284893002
Cr-Commit-Position: refs/heads/master@{#415169}

BUG=642057

Review-Url: https://codereview.chromium.org/2285373002
Cr-Commit-Position: refs/heads/master@{#415168}

BUG=641934
TBR=petrcermak@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2293553002
Cr-Commit-Position: refs/heads/master@{#415167}

Revert of Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files. (patchset #1 id:1 of https://codereview.chromium.org/2278093004/ )

Reason for revert:
This causes warning if files are referenced in gyp file. https://codereview.chromium.org/2285703003/ triggered presubmit when it shouln't have.

Original issue's description:
> Reland [Presubmit tests] Warn when new source files are not added to GN/GYPi files.
>
> Add a presubmit check that warns when new source files are
> not added to GN or gypi files. Check is done on upload only before gni includes are fixed.
>
> BUG=112371
>
> Committed: https://crrev.com/1efc2f5f650a355056a98b6c99d4d0260742a750
> Cr-Commit-Position: refs/heads/master@{#414975}

TBR=dpranke@chromium.org,maksim.sisov@intel.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=112371

Review-Url: https://codereview.chromium.org/2293763002
Cr-Commit-Position: refs/heads/master@{#415166}

Use for-range style loops and get rid of the local 'size' variable.
Also move the sort() call down after the early-out when there are no
animations to apply.

BUG=641437

Review-Url: https://codereview.chromium.org/2287973002
Cr-Commit-Position: refs/heads/master@{#415165}

new uses of the flag and thus reduce the cost when it's finally removed.

BUG=516499
R=mmenke@chromium.org
TBR=megjablon@chromium.org
TBR=pkasting@chromium.org
TBR=droger@chromium.org

Review-Url: https://codereview.chromium.org/2278823003
Cr-Commit-Position: refs/heads/master@{#415164}

This will eliminate some wasted cycles during the rename dance for the
majority of installs, thereby leading to a better update experience for
users.

Also included in this change: removed some duplicated code and fixed up
use of the registry. More on the latter: all integration points between
Chrome and Google Update unconditionally take place in the 32-bit view
of the Windows registry. As such, we use KEY_WOW64_32KEY everywhere even
when it isn't strictly needed. It seems that this spot was missed during
the great 64-bit-ification of Chrome. It just so happens that it's
harmless for per-user installs since HKCU\Software is not redirected for
64-bit apps in the way that HKLM\Software is.

BUG=610305
R=brucedawson@chromium.org

Review-Url: https://codereview.chromium.org/2283363005
Cr-Commit-Position: refs/heads/master@{#415163}

https://chromium.googlesource.com/skia.git/+log/839d3ad854c0..6f5df6acb7de

$ git log 839d3ad85..6f5df6acb --date=short --no-merges --format='%ad %ae %s'
2016-08-29 mtklein Disable sktexttopdf when building for mipsel.
2016-08-29 mtklein GN: fontmgr_android
2016-08-29 msarett Skip spinlock overhead on Android
2016-08-29 msarett Add Gray support to SkPNGImageEncoder
2016-08-29 mtklein remove dead code
2016-08-29 jvanverth Fix stroked rrects with batching.
2016-08-29 egdaniel Remove unneeded pipeline barrier in vulkan
2016-08-29 jcgregorio benchmarks: Avoid brackets and commas in test names.
2016-08-29 mtklein GN: ft and fc as optionals
2016-08-29 mtklein add gn_android_flavor
2016-08-29 bsalomon Skip batch iteration in GrDrawTarget::forwardCombine when the max look ahead is 0
2016-08-29 mtklein Add docs for GN/Android
2016-08-29 mtklein GN: release -> -O3, to match GYP
2016-08-29 vjiaoblack Moved ambient lights out of SkLight's light array
2016-08-29 jvanverth Batch all circular rrects together
2016-08-29 halcanary SkPDF: Remove some unused glyphs from fallback fonts
2016-08-29 bsalomon Add support for glDrawRangeElements GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2287003002
2016-08-29 msarett Add width, height, unique ID, alpha to debugger DrawImageCommand
2016-08-29 vjiaoblack Revert of Moved ambient lights out of SkLight's light array (patchset #7 id:120001 of https://codereview.chromium.org/2287553002/ )
2016-08-29 rmistry Add Gerrit API support to Skia's PRESUBMIT.py
2016-08-29 reed dedup images/blobs/pictures by ID in old serialization format
2016-08-29 rmistry Whitespace change to test Gerrit Submit
2016-08-29 jvanverth Use stroked rrects for Android shadow sample
2016-08-29 mtklein Roll GN
2016-08-29 vjiaoblack Moved ambient lights out of SkLight's light array
2016-08-29 reed change readTypeface to return sk_sp
2016-08-29 brianosman Remove FP16 support from ANGLE. Previous workaround was incomplete.
2016-08-29 fmalita [SVGDom] Don't truncate opacity scalars

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bsalomon@google.com

Review-Url: https://codereview.chromium.org/2290013003
Cr-Commit-Position: refs/heads/master@{#415162}

Have the NGConstraintSpace constructors take a NGPhysicalConstraintSpace
and make it mandatory. Also add accessors to NGConstraintSpace and allow
a new NGPhysicalConstraintSpace to be constructed from a NGPhysicalSize.

R=ikilpatrick@chromium.org,cbiesinger@chromium.org
BUG=635619
NOTRY=true

Review-Url: https://codereview.chromium.org/2283233002
Cr-Commit-Position: refs/heads/master@{#415161}

BUG=641597

Review-Url: https://codereview.chromium.org/2284143002
Cr-Commit-Position: refs/heads/master@{#415160}

This way GpuProcessHost::RecordProcessCrash will be called, allowing
Chrome to fall back to SwiftShader or just give up on launching the GPU
after a little while.

Review-Url: https://codereview.chromium.org/2281243002
Cr-Commit-Position: refs/heads/master@{#415159}

Since Chrome can do window reparenting, DisplayMetrics should
be extracted from the Context that is associated with the window.

In this CL we pass the context to RenderCoordinates that obtains
the display density (device scale factor) and wheel scroll factor
from it.

BUG=620929

Review-Url: https://codereview.chromium.org/2268103002
Cr-Commit-Position: refs/heads/master@{#415158}

first sent packet after receiving a packet, even if the sent packet is
not a retransmission. Protected by default enabled
--quic_better_last_send_for_timeout

Merge internal change: 131623416

BUG=642017

Review-Url: https://codereview.chromium.org/2288843002
Cr-Commit-Position: refs/heads/master@{#415157}

Textfield::SetTextEditCommandForNextKeyEvent can be used to schedule a text
editing command to be executed on the next key press. However, Textfield
subclasses like OmniboxViewViews are currently oblivious to the scheduled text
edit command accounting. When a key press event is handled in
OmnboxViewViews::OnKeyPressed itself, the scheduled_text_edit_command_ property
in Textfield is not cleared, leading to a failed DCHECK when
Textfield::SetTextEditCommandForNextKeyEvent is invoked next.

This CL resolves the crash by prohibiting Textfield subclasses from overriding
OnKeyPressed/Released. This allows Textfield to handle the accounting related to
the scheduled text edit command. This necessiates moving all the
OmniboxViewViews::OnKeyPressed and OmniboxViewViews::OnKeyReleased logic to
OmniboxViewViews::HandleKeyEvent. A test is also added which fails on the
current master.

BUG=613948
TEST=Build with mac_views_browser=1. In the browser, go to the omnibox and type
a partial url such that there are atleast 2 autocomplete suggestions. Press
arrow down key twice. Ensure the browser does not crash.

Review-Url: https://codereview.chromium.org/2273263002
Cr-Commit-Position: refs/heads/master@{#415156}

The pin keyboard now hides its input element and passes its data to the user pod password element.

BUG=632383
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2260653002
Cr-Commit-Position: refs/heads/master@{#415155}

Update them so that they return strings instead of calling Node::showNode(),
which uses WTFLogAlways().

- Rename showTreeForThis() to toTreeStringForThis()
- Rename showTreeForThisInFlatTree() to toFlatTreeStringForThis()
- Rename showTreeAndMark() to toMarkedTreeString().
- Rename showTreeAndMarkInFlatTree() to toMarkedFlatTreeString()
- Rename traverseTreeAndMark() to appendMarkedTree()
- Rename traverseTreeAndMarkInFlatTree() to appendMarkedFlatTree()
- Add Node::toString() to help these functions.

We'd like to return a string rather than taking a std::ostream argument because
they are used with LOG macros. For example,
  VLOG(1) << node.toMarkedTreeString().utf8().data() << "...";

If we took a std::ostream argument, the code would be:
  std::stringstream buffer;
  node.printMarkedTreeTo(buffer);
  VLOG(1) << buffer.str() << "...";

The former is simpler.

This CL doesn't affect production.

BUG=638849

Review-Url: https://codereview.chromium.org/2293703002
Cr-Commit-Position: refs/heads/master@{#415154}

Moves the target from //ui/gfx:vector_icons_generate to //ui/gfx/vector_icons/*

Adds the templates to the inputs of the generate script so it re-runs when the templates change (this was a bug in the previous implementation).

Review-Url: https://codereview.chromium.org/2286323004
Cr-Commit-Position: refs/heads/master@{#415153}

BUG=

Review-Url: https://codereview.chromium.org/2286293003
Cr-Commit-Position: refs/heads/master@{#415152}

BUG=630656

Review-Url: https://codereview.chromium.org/2254353002
Cr-Commit-Position: refs/heads/master@{#415151}

These are unused and no longer needed. We can revive them from git history if
we need them again.

BUG=641996
TEST=compiles

Review-Url: https://codereview.chromium.org/2286423002
Cr-Commit-Position: refs/heads/master@{#415150}

GpuWatchdogThread doesn't have any dependency on content. So move it into
the gpu service component, so that it can be used by both content-gpu and
mus-gpu.

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2286063003
Cr-Commit-Position: refs/heads/master@{#415149}

BUG=624187
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2276593004
Cr-Commit-Position: refs/heads/master@{#415148}

BUG=555865

Review-Url: https://codereview.chromium.org/2284283002
Cr-Commit-Position: refs/heads/master@{#415147}

This patch enables using credit card scanner directly from Java, without
jumping to native first. Checking of the "AutofillScanCardholderName"
flag has moved into the Java delegate wrapper, so users of this
functionality in Java are governed by the same flag, regardless of the
implementation.

BUG=640430

Review-Url: https://codereview.chromium.org/2274693004
Cr-Commit-Position: refs/heads/master@{#415146}

Then DevTools will linkify links from error.stack.

BUG=610559
R=lushnikov@chromium.org

Review-Url: https://codereview.chromium.org/2284123002
Cr-Commit-Position: refs/heads/master@{#415145}

By rendering the root view we include the Toolbar in the new_tab_page renders.

BUG=641975

Review-Url: https://codereview.chromium.org/2288363002
Cr-Commit-Position: refs/heads/master@{#415144}

SyncExtensionFunctions, AsyncExtensionFunctions,
ChromeSyncExtensionFunctions, and ChromeAsyncExtensionFunctions are
deprecated.

Remove SyncExtensionFunctions from:
- idltest
- test
- system_display

BUG=634140

Review-Url: https://codereview.chromium.org/2282063002
Cr-Commit-Position: refs/heads/master@{#415143}

TBR=dbeam@chromium.org

Review-Url: https://codereview.chromium.org/2289543004
Cr-Commit-Position: refs/heads/master@{#415142}

When memory coordinator is enabled, HistoryBackend becomes a
client of memory coordinator instead of installing
MemoryPressureListener.

Also MemoryCoordinator becomes a singleton so that any component
can access MemoryCoordinator to listen to memory events.

BUG=639700

Review-Url: https://codereview.chromium.org/2261073002
Cr-Commit-Position: refs/heads/master@{#415141}

We distinguish three cases:
 * Policies that control browser behavior. These implicitly apply to
   Chrome on Chrome OS only. No documentation updates are needed.
 * Policies that affect parts of the system which lie outside the scope
   of ARC, e.g. the login screen and auto-update system. These
   implicitly apply to Chrome OS only. No documentation updates are
   needed.
 * Policies that directly or indirectly influence app behavior. The
   default assumption is that any such policy applies to both Chrome
   and Android apps. This CL adds a note to the generated documentation
   whenever this is not the case.

BUG=b/28039197 b/28109303
TEST=ninja -C out/out policy_templates

Review-Url: https://codereview.chromium.org/2278493004
Cr-Commit-Position: refs/heads/master@{#415140}

It's more convenient for call sites to let ExceptionState
throw by default than to explicitly call to throwIfNeeded().

This prevents a mistake that a call site forgets to throw.
ExceptionState now looks a kind of exception scope.

BUG=

Review-Url: https://codereview.chromium.org/2272613003
Cr-Commit-Position: refs/heads/master@{#415139}

These can come out of user timings on timeline.

Review-Url: https://codereview.chromium.org/2288853002
Cr-Commit-Position: refs/heads/master@{#415138}

- Do not list inspector_protocol files anywhere outside;
- Separate concatenation from compatibility check;
- Improve files layout;
- Pass path to jinja module to CodeGenerator.

BUG=637032

Review-Url: https://codereview.chromium.org/2282283002
Cr-Commit-Position: refs/heads/master@{#415137}

In some cases, Arc window may be destroyed and created again. This
leads to situation when shelf item is closed and there is no longer
item for Arc task. This CL allows Arc window to be recreated. The
situation may go even worse, window may be destroyed and not created
after. In this case we have task without window. In this case, we
send launch request to Android and this put Android task to foreground
and window is created.

BUG=b/31071902
TEST=Manually on device, installed several photo editor apps as
     described in task. Minimize/maximize window. Sometimes window
     get destroyed and created again. Shelf item is not lost in this
     case. Sometimes window destroyed and not recreated. Shelf icon
     still exists and clicking on it gets new window back for task.
TEST=Extended unit_tests

Review-Url: https://codereview.chromium.org/2282023002
Cr-Commit-Position: refs/heads/master@{#415136}

BUG=455496

Review-Url: https://codereview.chromium.org/2294463002
Cr-Commit-Position: refs/heads/master@{#415135}