GitLab

1) This is discouraged because it prevents callers from benefiting from automatic coersion from string/char* types.
2) A follow-up CL (http://codereview.chromium.org/8659047/) will make StringPiece a template, and thus awkward to forward declare. The very small number of places that were appropriately forward declaring it do not justify writing a 'string_piece_forward.h'.

BUG=87634
R=cbentzel@chromium.org


Review URL: http://codereview.chromium.org/8929002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114219 0039d316-1c4b-4281-b951-d872f2087c98

JavaBridgeDispatcherHost must be ref-counted because it is used with
base::Bind. http://codereview.chromium.org/8834013 changed
JavaBridgeDispatcherHost to also inherit from RenderViewHostObserver. The base
implementation of RenderViewHostObserver::RenderViewHostDestroyed() deletes the
object. This is unwanted in this class, so we provide an empy implementation of
the method.


Review URL: http://codereview.chromium.org/8929005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114218 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716


Review URL: http://codereview.chromium.org/8890075

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114217 0039d316-1c4b-4281-b951-d872f2087c98

This change replaces -rpath-link and an -L linking flag with --sysroot, which sets the compiler root directory for all headers and libraries.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8938003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114216 0039d316-1c4b-4281-b951-d872f2087c98

With this option, the current user is always treated as owner and all signed settings are stored in memory without signing.
All CrosSettingProviders now use a callback to notify CrosSettings observers.

BUG=None
TEST=StubCrosSettingsProviderTest.*; manual: see CL description

Review URL: http://codereview.chromium.org/8899002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114214 0039d316-1c4b-4281-b951-d872f2087c98

Reset the kWasRestarted pref upon successful restart. Set it only when restarting. Write
the persistent preferences after setting it.

The preference was introduced in http://codereview.chromium.org/8745015.

BUG=106948
TEST=see bug


Review URL: http://codereview.chromium.org/8937001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114213 0039d316-1c4b-4281-b951-d872f2087c98

The check was trying to verify the current user is the owner when all it
needs to check is if there is an owner already.

This check was also blocking local owner from doing changes to the signed
settings on first login and possibly is the cause preventing the managed
settings from getting applied immediately too.

BUG=chromium-os:24020,chromium-os:24007
TEST=As described in the bugs.

Review URL: http://codereview.chromium.org/8921007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114212 0039d316-1c4b-4281-b951-d872f2087c98

TBR=timsteele@chromium.org
BUG=none


Review URL: http://codereview.chromium.org/8919015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114211 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22035
TEST=Manual.


Review URL: http://codereview.chromium.org/8920003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114210 0039d316-1c4b-4281-b951-d872f2087c98

When running the fake ui, behind the media stream flag, there is a missing check for available devices.


Review URL: http://codereview.chromium.org/8883042

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114205 0039d316-1c4b-4281-b951-d872f2087c98

The implementation was removed by http://codereview.chromium.org/8820009.

BUG=NONE
TEST=NONE


Review URL: http://codereview.chromium.org/8919003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114204 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114203 0039d316-1c4b-4281-b951-d872f2087c98

BUG=NONE
TEST=builds.


Review URL: http://codereview.chromium.org/8873021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114201 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114200 0039d316-1c4b-4281-b951-d872f2087c98

TBR=erik.corry

Review URL: http://codereview.chromium.org/8935003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114199 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105204
TEST=Manual


Review URL: http://codereview.chromium.org/8817018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114198 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114196 0039d316-1c4b-4281-b951-d872f2087c98

BUG=None
TEST=Trybots
TBR=kbr


Review URL: http://codereview.chromium.org/8879054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114195 0039d316-1c4b-4281-b951-d872f2087c98

This change includes "mozzconf.h" in our copy of 'zconf.h' as we did before updating to zlib 1.2.5 to avoid symbol conflicts with sdch happening when we use supalink.

BUG=none
TEST=link Chromium with supalink.

Review URL: http://codereview.chromium.org/8933001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114194 0039d316-1c4b-4281-b951-d872f2087c98

BUG=104579
TEST=built Debug & Release on desktop and verified test passes (after failing in Release on desktop before the change to RemoveFilter).


Review URL: http://codereview.chromium.org/8934002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114193 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106265
TEST=


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=114157

Review URL: http://codereview.chromium.org/8785013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114192 0039d316-1c4b-4281-b951-d872f2087c98

BUG=107294
TEST=none


Review URL: http://codereview.chromium.org/8917027

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114191 0039d316-1c4b-4281-b951-d872f2087c98

(the underlying issues have been resolved).

BUG=None
TEST=None
R=maruel@chromium.org

TBR (will see what the bots do and back out if there are issues).
Review URL: http://codereview.chromium.org/8936003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114190 0039d316-1c4b-4281-b951-d872f2087c98

Currently P224EncryptedKeyExchange uses two pieces of secret: password 
and session-specific key. They are combined and used together as one 
password. It is not really needed and the calling code can do
it when neccessary.

BUG=105214


Review URL: http://codereview.chromium.org/8903001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114189 0039d316-1c4b-4281-b951-d872f2087c98

r=rtenneti
BUG=107051
Review URL: http://codereview.chromium.org/8899016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114188 0039d316-1c4b-4281-b951-d872f2087c98

BUG=105214


Review URL: http://codereview.chromium.org/8774031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114187 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=AsyncHostResolver.*


Review URL: http://codereview.chromium.org/8918029

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114186 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit f0c9c12d.

TBR=thestig@chromium.org
BUG=103497
TEST=none

Review URL: http://codereview.chromium.org/8929004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114185 0039d316-1c4b-4281-b951-d872f2087c98

This'll be revived or deleted shortly.

BUG=104579
TEST=none

Review URL: http://codereview.chromium.org/8936002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114184 0039d316-1c4b-4281-b951-d872f2087c98

This uses the GpuVideoDecodeAccelerator machinery (already written to enable 
ppapi to take advantage of OpenMAX HW where available) to decode <video> data. 
This increases idle CPU from 20% to 45% on one particularly large (internal) 
test video (red0.mp4), on an ARM crosbook. 

HW decode is done on a best-effort basis; if the GPU code doesn't know how to 
deal with a codec/profile we still fall back to ffmpeg for decode. Because the 
vast majority of chrome installs will be on HW with no video decode support 
(yet) we only attempt HW video decode on platforms we know have a shot at it. 

This is a copy of http://codereview.chromium.org/8686010/ PS#13 to work around
rietveld losing the "status" for some files in the patch.

BUG=104579
TEST=manual testing w/ video test matrix, trybots.


Review URL: http://codereview.chromium.org/8922010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114183 0039d316-1c4b-4281-b951-d872f2087c98

Add a proper permission message.
Update the API to be ChromeOS only

BUG=None
TEST=None

Review URL: http://codereview.chromium.org/8757015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114181 0039d316-1c4b-4281-b951-d872f2087c98

R=groby@chromium.org


Review URL: http://codereview.chromium.org/8905028

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114180 0039d316-1c4b-4281-b951-d872f2087c98

Previously JingleSession unit tests were using real authenticators. Here
I changed them to always use FakeAuthenticator and added new tests for channel 
authentication in v1_authenticator_unittest.cc . Also, to make new tests pass,
fixed session-terminate message handling in JingleSession to return correct 
error code.

BUG=105214


Review URL: http://codereview.chromium.org/8743023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114178 0039d316-1c4b-4281-b951-d872f2087c98

BUG=81451
TEST=AutofillTest.*


Review URL: http://codereview.chromium.org/8921026

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114177 0039d316-1c4b-4281-b951-d872f2087c98

This basically a revert of r112435 except that the test
remains active.

   original CL: http://codereview.chromium.org/8735016

BUG=103497
TEST=browser_tests should stay green.


Review URL: http://codereview.chromium.org/8919024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114174 0039d316-1c4b-4281-b951-d872f2087c98

Address comments in 8921029  extract_from_cab script now takes a global lock while extracting from the CAB file.

http://codereview.chromium.org/8921029/

BUG=107291

Review URL: http://codereview.chromium.org/8929001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114173 0039d316-1c4b-4281-b951-d872f2087c98

NO CODE CHANGE.


git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114172 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102685


Review URL: http://codereview.chromium.org/8921008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114171 0039d316-1c4b-4281-b951-d872f2087c98

BUG=106544
TEST=Verify that select file dialog allows selection of pem files.


Review URL: http://codereview.chromium.org/8748021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114170 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none


Review URL: http://codereview.chromium.org/8873007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@114169 0039d316-1c4b-4281-b951-d872f2087c98