- 28 May, 2020 40 commits
-
-
Denis Kuznetsov authored
Bug: 1047840 Change-Id: I261c040d3c8c6abce28686d5687d512bc648f358 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218069Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772631}
-
Hiroki Nakagawa authored
"Navigation" is the term specific to frame loading, but ServiceWorkerNavigationLoader is used for both frame loading and web worker script loading. For avoiding confusion, this CL renames it to ServiceWorkerMainResourceLoader. In addition, this CL renames ServiceWorkerNavigationLoaderInterceptor to ServiceWorkerMainResourceLoaderInterceptor. This CL uses NoPresubmit to suppress warnings for usage of deprecated mojo::DataPipe. This is not derived from this change. Bug: 1083047 NoPresubmit: true Change-Id: I9b66316e6d35c0608094f447919dafc04e7b6d28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210292 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#772630}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a3636ed8883d..f874525de394 2020-05-28 enga@chromium.org OpenGL: Fix rendering to a layer of a depth/stencil texture 2020-05-28 enga@chromium.org Metal: Fix rendering to a layer of a depth/stencil texture 2020-05-28 enga@chromium.org Add tests for using a subresource as output attachment If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I88cfda79baac328e275b352c0ead8cd75126fb18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219739Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772629}
-
Jia authored
The new tokenization method only extracts words delimited by spaces and keep punctuations that appear within a word. Bug: 1085976 Change-Id: I61ef69db6653ecb91bb3945bad7f470bfbf00902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212293 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#772628}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6a184fe947ed..b9529e3a6998 2020-05-28 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Tools from d3d89bb90cbd to 8dfdbeff84f3 (4 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: Id3cc3685c57a6296485ee6e17d2c65e2b5c16c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219731Reviewed-by:
-
Jan Wilken Dörrie authored
TBR=dgozman Bug: 1087320 Change-Id: I15cd33b9338255ea339eca35d49a5d7c694158cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219501Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#772626}
-
Marc Treib authored
This introduces a histogram PasswordManager.StoresUsedInLast[7|28]Days that records which of the two stores (profile-scoped store and/or account-scoped store) were used for filling in the last 7/28 days. Bug: 1063852 Change-Id: I3a2bc108e2b88c960cd78f6fdc1a36fc284dbe28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207323Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Auto-Submit: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#772625}
-
Hazem Ashmawy authored
Make AwNonembeddedUmaRecorder bind once MetricsBridgeService and never unbind, i.e keep the service binding for the app context lifetime. This should save the overhead of binding and then unbinding for each histogram record. Never unbinding the service should be okay, while the non-embedded process is alive, there is expected to be a consistent stream of histogram records that need to be sent to the service. AwNonembeddedUmaRecorder can be accessed concurrently from many threads making it tricky to maintain one instance of ServiceConnection given possible accidental changes in connection status by the system. In order to avoid losing histogram records and not to block the calling thread, we add incoming histogram records to a thread-safe list and when the service connection is ready we send those records to the service. If the connection is ready we send records directly to the service. Fixed: 1081262 Test: bin/run_webview_instrumentation_test_apk -f "*AwNonembeddedUmaRecorderTest*" Change-Id: If61c6cdc25c61dacbbd747179e4625acf8a98a50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207531Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Hazem Ashmawy <hazems@chromium.org> Cr-Commit-Position: refs/heads/master@{#772624}
-
sandromaggi authored
This is a proposal to add a boolean to skip Autofill, entirely relying on the required fields. The purpose of this change is to give our client full, deterministic control over what happens in a |UseAddressAction|. The same change is introduced for |UseCreditCardAction|. Bug: none Change-Id: Iae4ce4fd00fec6038f5394dff7bf7dd88e2a80a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207458Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#772623}
-
Alexandre Courbot authored
Add a new QueueDMABuf() method taking a VideoFrame as argument. This method queues the VideoFrame's DMABufs, but will also keep a reference to the VideoFrame itself, which can be retrieved when the buffer is dequeued using V4L2ReadableBufferRef::GetVideoFrame(). This makes it easier to manage imported DMAbufs with V4L2, since clients don't have to keep that reference themselves (usually using a map of buffer IDs to VideoFrames). BUG=b:149663704 TEST=VDAtest --use_vd passes on Kukui. Change-Id: Id3fd7c5b62b16978553f3c99664ba688ba61451e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143427Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Reviewed-by:
Fritz Koenig <frkoenig@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#772622}
-
Christoph Schwering authored
This CL appends form and field renderer IDs to the autofill-information attribute. For one thing, this helps interpret chrome://autofill-internals output. For another, it will help matching elements across rendered and browser process boundaries in unit tests. Change-Id: I0bc5d50b7aa9922362e3d34a0d786bc741bfa9c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219487Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#772621}
-
Christoph Schwering authored
The duality between FormStructure and FormData is reflected by FormStructure(const FormData&) and FormStructure::toFormData(). The relation extends to FormDataPredictions, which has a FormData member. This CL makes FormStructure:toFormData() and FormStructure::GetFieldTypePredictions() initialize all members shared among FormStructure and FormData and FormDataPredictions. More precisely, before this CL, (1) FormStructure::toFormData() didn't copy several of the members shared by FormStructure and FormData. (2) FormStructure::GetFieldTypePredictions() didn't set several of the members shared by FormStructure and FormDataPredictions's FormData and didn't set FormFieldDataPredictions's FormFieldData. Bug: 1087194 Change-Id: If0b833b52ede4d3ac86aad5c46fefd84c99cba47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218829Reviewed-by: -
Anastasiia Nikolaienko authored
Use browser proxy in account_manager_error and account_manager_welcome dialogs. Bug: 1083147 Change-Id: I4549ced7b860f4a53a6a280463d03382f0e3df0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214523 Commit-Queue: Anastasiia N <anastasiian@chromium.org> Reviewed-by:
Kush Sinha <sinhak@chromium.org> Cr-Commit-Position: refs/heads/master@{#772619}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1590637846-cf66cd399b4c48375ae2ad3d18827b7a5bc0b17a.profdata to chrome-win64-master-1590652675-be69972bb8b130c690a24c0cd0561e6e4a5c40c5.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Idea46c5cc1c7fa545acefb57459da126af1ca585 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219740Reviewed-by:
-
Victor-Gabriel Savu authored
Mark Cryptohome.InstallAttributesValidation and Cryptohome.InstallAttributesUsage as obsolete. Bug: chromium:1021154 Change-Id: I4d646db7a38008cdc6388fb5fca7cb463f11f18d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207194Reviewed-by:
Igor <igorcov@chromium.org> Reviewed-by:
-
arthursonzogni authored
The function NavigationRequest::IsErrorPage() returns true for error pages AFTER the navigation commit. It means it doesn't make sense to call it from: - WebContentsObserver::DidStartNavigation() - WebContentsObserver::DidRedirectNavigation() - WebContentsObserfver::ReadyToCommitNavigation() - NavigationThrottle::WillStartRequest() - NavigationThrottle::WillRedirectRequest() - NavigationThrottle::WillProcessResponse() The only meaningful way to use IsErrorPage() is from: - WebContentsObserver::DidFinishNavigation() This is easy to verify, given its implementation: ~~~ bool NavigationRequest::IsErrorPage() { return state_ == DID_COMMIT_ERROR_PAGE; } ~~~ WebContentsObserverSanityChecker is also enforcing this. The current behavior is a bit misleading. I have been tricked myself recently. This patch: 1. Update the content/public IsErrorPage() documentation. 2. Remove all the callers who are using this incorrectly. 3. Transitively remove code starting from what (2) removed. Bug: None. Change-Id: Ie6a66bf6344fc306ddd27384aab27fd002832116 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216218Reviewed-by:Matt Menke <mmenke@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772616}
-
Vasilii Sukhanov authored
Bug: 716681 Change-Id: I640a2bff687d1a4bdc712cddbb03061587fcf3c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218093Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#772615}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590637846-f24e6c1a243316554d5b0c2334884adcb37c67bd.profdata to chrome-mac-master-1590652675-697ba00b1820dcc0607ade49043105c169de1a33.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I9123b69596be280352752c4fa2cc9203d170aa4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219736Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0c9fa494daad..872a24d0d0f9 2020-05-28 dbarcos@chromium.org Fix word duplication to align with article If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Id9f6f89efa2ecd601a266efc21d586f54673c322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219728Reviewed-by:
-
manuk authored
*Rich autocompletion background* Currently, autocompletion is limited to when the user types a prefix of the URL. E.g. 'wiki' can autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Rich autocompletion will allow autocompletion even when the input is from the suggestion title or middle of the URL. E.g. 'thecoo' and 'recip' will also autocomplete 'wiki.org/thecookinglist - top awesome recipes'. Design doc with further details: go/richomniboxautocompletion Previous CLs: - crrev.com/c/2107796 added chrome://flags flags - crrev.com/c/2108780 supported multiselection in textfield views. - crrev.com/c/2199859 Add complementary omnibox view. *This CL* This is the 4th CL for rich autocompletion. It wires in the omnibox view to textfield's multiselection & location bar's complementary text. This CL has no user facing changes. Followup CLs will wire in rich autocompletion to make use of these changes. Bug: 1062446 Change-Id: I919965049837fd5421fd2b8f0dabc6d3489dabf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204545 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Auto-Submit: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#772612}
-
arthursonzogni authored
Only some of the browser initiated main frame navigation can have no FramePolicy assigned. The renderer-initiated and subframes ones must always have it defined. TODO(arthursonzogni): Consider always defining it in the future. This patch fixes a few cases and adds a DCHECK in the NavigationRequest to enforce this property in the future. Bug: 1086734, 1041376 Change-Id: Id2936a89193322fa609e4135820037fcbf7bd85c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216255 Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#772611}
-
Mansi Awasthi authored
This change adds struct PP_PrivateAccessibilityFormFieldInfo to PP_PrivateAccessibilityPageObjects to transfer accessibility related PDF form field data from the plugin process to the mimehandler process. Made the same changes to the C++ versions of these structs and added the appropriate conversion code. This CL refactors existing PP_PrivateAccessibilityPageObjects to send text field data as part of PP_PrivateAccessibilityFormFieldInfo struct. Going forward, other form fields will also be added in PP_PrivateAccessibilityFormFieldInfo. This change is needed to avoid bloating of PP_PrivateAccessibilityPageObjects structure with multiple objects. Bug: 1030242 Change-Id: Ie55ee36645ff9df9bc57dfaa18fb4cc3f245d60b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215155Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Commit-Queue: Mansi Awasthi <maawas@microsoft.com> Cr-Commit-Position: refs/heads/master@{#772610} -
Takashi Toyoshima authored
This reverts commit 643474d0. Reason for revert: The change was merged to M84, and isn't needed for M85, TOT. Original change's description: > OOR-CORS: Disable kStrictAccessControlAllowListCheck for M84 > > To reduce risks for launching OOR-CORS on WebView 83/84, we temporarily > disable the kStrictAccessControlAllowListCheck for M84. > > Once this patch is merged to the M84 branch, I will quickly revert this > for M85. > > Bug: 1084376 > Change-Id: I2256eed511ea995bad91b611f976d72eb228443b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2206861 > Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> > Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> > Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#770000} Bug: 1084376 Change-Id: I2bd71ae24c331ea9f0b0779b851e48b73ba60127 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210196 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#772609}
-
Anders Hartvoll Ruud authored
Bug: 1057072 Change-Id: I9b50b4f02c7ceb31a406464552d2c02613f6bf5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210420 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#772608}
-
Roman Sorokin authored
Bug: 1073095 Change-Id: I3de4ae351e8d305df649071056a903a935735d0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2196484 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#772607}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a40740375ef..641fcb8099d4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tasak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1024588,chromium:1085525 Tbr: tasak@google.com Change-Id: I905ba3accab22df5cb5083c68e5afee64ed5a1ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219629Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#772606}
-
Mario Sanchez Prada authored
This CL moves this message out of frame_messages.h and adds a new method in content::mojom::Widget to allow asking the renderer to force a redraw, expecting a response when the process is completed. Bug: 1083405 Change-Id: I2ce44e25c8d82f56bc4a8d44572f8e04e60abda0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207209Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#772605}
-
Kent Tamura authored
Font-size restriction for inset amount should be applied only to LayoutRubyText. Bug: 1069817 Change-Id: I82d6ac806e3eca0bc696517678d753e3c1a53d6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217914 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#772604}
-
Jan Wilken Dörrie authored
TBR=oshima Bug: 1087285 Change-Id: I93c8b6cdb057f387ef24a160429a9761e35d50db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219491Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/dc8caee164ef..5762221cb271 2020-05-28 fancl@chromium.org auto-bisect: Fix status update based on issue state If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1087240 Tbr: rmhasan@google.com Change-Id: Ic27860e9f1a041f3a8428efd0cc03d83c75c8c4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219635Reviewed-by:
-
Hugo Benichi authored
Main rational for migration: user UI override settings for marking a network metered or unmetered can only be obtained with the new kMeteredProperty. BUG=b:156302252 TEST=Flashed Chrome, connected the DUT to an Android hotspot with cell tethering and checked that ARC tags the wifi hotspot as metered. Change-Id: I83f4ca01521947edb39785053308cb88b658a69e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217711 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Jorge Lucangeli Obes <jorgelo@chromium.org> Cr-Commit-Position: refs/heads/master@{#772601}
-
Aleks Totic authored
I've copied AddChild code from Legacy, and modified it to work with NG. A lot of this code has to do with anonymous wrapping. I do not fully understand what it does, "just do what Legacy did" was what I was going for. Bug: 958381 Change-Id: I139e04154a03676ecbe5da1d794d0570bcd803d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212459 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#772600}
-
Clemens Arbesser authored
This CL unifies the handling of autofill format strings across all relevant actions (UseCreditCardAction, UseAddressAction, ShowGenericUi). This is a refactoring-only and should have no user-facing changes. Bug: b/145043394 Change-Id: Id533ed9e6faba7f0ec93481bbe7d9c85f24e889e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208989 Commit-Queue: Clemens Arbesser <arbesser@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Sandro Maggi <sandromaggi@google.com> Cr-Commit-Position: refs/heads/master@{#772599}
-
Jan Wilken Dörrie authored
TBR=danakj Bug: 1083585 Change-Id: I21588d8ff2ea2fb7e4cb54cd915b4c984d2621e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219490Reviewed-by:
-
Wolfgang Beyer authored
This CL updates the tests which use SDK.networkLog to use the static instance() function instead. It also re-enables previously disabled tests. DevTools CL: https://crrev.com/c/2213439 CL disabling tests: https://crrev.com/c/2214952 Bug: chromium:1011811 Change-Id: I1843b16447ca480075f8a3e02abd8bf4ab715f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213534Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Wolfgang Beyer <wolfi@chromium.org> Cr-Commit-Position: refs/heads/master@{#772597}
-
Jan Scheffler authored
CL that disables the test: crrev.com/c/2218051 Bug: chromium:1011811, chromium:1079233 Change-Id: Ie14ff7879b9128b7aad00ec02cdb90d2a6698783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2218271Reviewed-by:
-
Rohit Agarwal authored
IncognitoDataTestUtils#launchUrlInTab is called when we want to load a URL in Chrome tabbed activity. This chrome tabbed activity is fired once in the setUp method of the incognito leakage tests and in subsequent calls to the launchUrlInTab method. The reason for firing activity in the launchUrlInTab method is to bring back the ChromeTabbedActivity (which was fired in the setUp method), if the previous activity fired was of type CustomTabActivity. To make the code more readable no checks were introduced and chrome tabbed activity was fired un-conditionally. However due to this we have some instances were the application was killed due to memory pressure. This CL adds the check to fire a ChromeTabbedActivity only if the previous activity which was fired was CustomTabbedActivity. Bug: 1081748, 1084709, 1035770 Change-Id: I1a232c44767821af17de2d7a859b4ecab50dbc91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213525 Commit-Queue: Rohit Agarwal <roagarwal@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Cr-Commit-Position: refs/heads/master@{#772595}
-
Nicholas Verne authored
This will ensure any processes which are holding dpkg locks release them. It is still possible that an init process in the container will grab the locks again before upgrade_container can run, so this doesn't ensure dpkg locks are always available, but it should fix the case of processes lingering and failing to release them. Bug: 1082075 Change-Id: I138d97b3a3f4ae1a1e4ce13232aef39cc75357a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217761 Commit-Queue: Nicholas Verne <nverne@chromium.org> Reviewed-by:
David Munro <davidmunro@google.com> Cr-Commit-Position: refs/heads/master@{#772594}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d4771af96b5e..0c9fa494daad 2020-05-28 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I394d0027a15b17573419aa2b649af2086ff5a92b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219634Reviewed-by:
-
Dominic Mazzoni authored
This reverts commit 41e56b19. Reason for revert: Causes crash - see stack trace in http://crbug.com/1087183 Original change's description: > Consolidated some text helper methods in AXNode > > This patch is a second precursor to a more substantial change that > would move hypertext computation to AXNode from AXPlatformNodeBase which will > in turn open the way for AXNodePosition to be merged with AXPosition and > for Views to be exposed as a tree of AXNodes. > See https://chromium-review.googlesource.com/2150294 > > Currently, we have multiple methods that compute inner text, IsLeaf and IsChildOfLeaf > one set in BrowserAccessibility and another in AXPlatformNodeBase. > We want to centralize all platform independent utility methods in AXNode and AXNodeData. > > There was some confusion in the existing codebase regarding what should be included in inner text. > Some code assumed that the name attribute of a leaf node could not be included, unless it was derived from its contents, > or its placeholder in the case of a text field. > Other parts of the codebase were more relaxed about this requirement. > > This patch adopts this requirement for the whole codebase, because the definition of inner text should only include visible > text that is present inside the node itself, but not text derived from an attribute, e.g. an ARIA label. > This is apparent from the name "inner text" itself, but it also stems out of the need > to support computing bounding boxes for character ranges in inner text. > If the name of an element is derived from an attribute such as an ARIA label, that attribute won't expose any bounding box information. > If the name of an element is derived from a related element, e.g. a figcaption or an HTML label, > the bounding box of that element is unrelated to the original element's inner text. > > APIs to compute bounding boxes are exposed in IAccessibleText, ATKText and ITextRangeProvider. > > See also the definition of IAccessibleText in the IAccessible2 Specification, > the definition of ATKText in the ATK Specification, or > the definition of ITextProvider in the UIA Specification. > 1. https://accessibility.linuxfoundation.org/a11yspecs/ia2/docs/html/interface_i_accessible_text.html > "The IAccessibleText interface should be implemented by all components that present textual information on the display like > buttons, text entry fields, or text portions of the document window." > 2. https://developer.gnome.org/pygtk/stable/class-atktext.html > "... if the text is editable, multi-line, typically longer than three or four words, attributed, selectable, > or if the object already uses the 'name' ATK property for other information, the atk.Text interface should be used" > 3. https://docs.microsoft.com/en-us/windows/win32/api/uiautomationcore/nn-uiautomationcore-itextprovider > "Provides access to controls that contain text." > 4. https://docs.microsoft.com/en-us/windows/win32/winauto/uiauto-implementingtextandtextrange > "If an embedded object spans a range of text, the plain text should include the inner text of the object, but not the alternative text (the name property of the embedded object) > because it might be inconsistent with the descriptive inner text." > > RELNOTES: N/A > > R=dmazzoni@chromium.org, aleventhal@chromium.org > TBR=rsesek@chromium.org > > Bug: 1049261 > Change-Id: Ic39687eb98c3ef7575214de2c659eb28d6633466 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171436 > Commit-Queue: Nektarios Paisios <nektar@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771809} TBR=dmazzoni@chromium.org,nektar@chromium.org,rsesek@chromium.org,aleventhal@chromium.org,virens@microsoft.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049261, 1087183 Change-Id: Ie40cf51e33cbe4595513f0b5e94732650496c3e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219395Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#772592}
-
