- 29 Oct, 2019 40 commits
-
-
Nasko Oskov authored
Unfortunately, the WebUIReuseInSubframe test is running into issues with the memory allocator returning separate instances of WebUI objects at the exact same memory address. This means that even though we have different instances of the object, which is what the test aims to assert it isn't possible to use pointer inequality as the assertion. I've modified the test to use the RenderFrameHost global routing id since one cannot have the same WebUI instance be owned by more than one RenderFrameHost instance. Bug: 713313, 1002276 Change-Id: Iea036b5cd10962c75f86a5b25d9f655012caf686 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886292Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#710440}
-
dpapad authored
CL produced with ESLint --fix and clang-format. This is in preparation for turning on no-var and prefer-const ESLint checks for that folder. Bug: 720034 Change-Id: I6467d1308118f67f076708612247852568fba2bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885652 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#710439}
-
Ken Rockot authored
This provides a new DataDecoder API in the data_decoder client library, allowing for clients to use the service for isolated and batched operations without any dependency on the Service Manager or the cumbersome usage of batch IDs. Only JSON parsing facilities are added to DataDecoder in this CL. The JsonSanitizer API is cleaned up a bit too, as is some test code. Bug: 977637 Change-Id: I5798982a500a403ddb345ab40db35d466dc6b7fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879792Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#710438}
-
Alex Gough authored
This copies policy rule opcodes when snapshotting policies, and serializes them for display in chrome://sandbox's raw view. Example rule: "NtQueryAttributesFile": [ "!(p[1] & 1) && !(prefix(p[0], '\\??\\')) -> askBroker", "!(p[1] & 1) && scan(p[0], '~') -> askBroker", "prefix_i(p[0], '\\??\\pipe\\chrome.') -> askBroker", "prefix_i(p[0], '\\??\\C:\\src\\chromium\\src\\out\\release-x86\\') && ends_i(p[0], '.pdb') -> askBroker" ], Bug: 997273 Change-Id: I54f82b0a9523fa1ed94cecf982f2b25203ae7351 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872304 Commit-Queue: Alex Gough <ajgo@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#710437}
-
Clark DuVall authored
the backing string was getting destroyed too early. base: :FeatureList::SplitFeatureListString takes in a StringPiece, and Change-Id: Id054a40451031bc41cbae3d4caa95f25568d0011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887830Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#710436}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/918853e6112f..0e87f1419824 git log 918853e6112f..0e87f1419824 --date=short --no-merges --format='%ad %ae %s' 2019-10-29 bsheedy@chromium.org Revert "Deduplicate desktop/CrOS minidump code" 2019-10-29 khokhlov@google.com [Telemetry] Update intermediate file format Created with: gclient setdep -r src/third_party/catapult@0e87f1419824 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:994274,chromium:1018248 Change-Id: I5381b039fd4c3cbfe35c44ae135eff41752f4b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1888051Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710435}
-
chromium-autoroll authored
Roll broadwell AFDO profile from 79-3904.41-1571046112-benchmark-79.0.3940.0-r1 to 80-3931.2-1572259441-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-broadwell-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I64047232b0703769b3335b1d3fabe6a473a58f33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887682Reviewed-by:
-
chromium-autoroll authored
Roll silvermont AFDO profile from 79-3928.0-1571049528-benchmark-79.0.3940.0-r1 to 80-3940.0-1572255699-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ie14ea4e9aab90f13b61794582e02eff9c6fd90fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887680Reviewed-by:
-
chromium-autoroll authored
Roll airmont AFDO profile from 79-3931.2-1571054549-benchmark-79.0.3940.0-r1 to 80-3940.0-1572260209-benchmark-80.0.3950.1-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: I2dee2448a6264d052e677b11c0b0730b9068903a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887681Reviewed-by:
-
David Van Cleve authored
This change extends the DNS host cache to store responses to ESNI queries: - adds a new member of type EsniContent and corresponding accessor - adds serialization and deserialization routines R=ericorth Test: expands HostCache's merging and serialization tests Bug: 1003494 Change-Id: I4977d4f12b2253e5895c36e0a86429f6074d9cbd Cq-Do-Not-Cancel-Tryjobs: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1865611Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#710431}
-
Asanka Herath authored
There already existed http_auth_handler_ntlm_{portable,win}.cc. And yet there was platform specific code in http_auth_handler_ntlm.cc along with lots of preprocessor directives. This CL cleans out the rest of http_auth_handler_ntlm.cc so that that file only contains cross platform code. No changes in behavior. This CL just moves code around. R: mmenke@chromium.org Bug: 927182 Change-Id: I25e20a658ad4fa46e1e9929f992bad2dcbb6dd7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881323 Commit-Queue: Asanka Herath <asanka@chromium.org> Reviewed-by:Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#710430}
-
Juan Antonio Navarro Perez authored
Tweak URLs to match their latest form as used by LUCI builders. Also rename "buildbot_url" to the more generic "builder_url", as buildbot is not related to these any more. Bug: 958739 Change-Id: Ie8a8889b78b36962c19698d776fafb6f5c1b18db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886673 Auto-Submit: Juan Antonio Navarro Pérez <perezju@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#710429}
-
Daniel Rubery authored
Add a few metrics to the BinaryFCMService just to detect that it behaves generally as expected when launched. Bug: 1018226 Change-Id: I8ff23455fadbe1808d1bb1dbf3cb8c97c39dd9f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880704 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Bettina Dea <bdea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710428}
-
Xiaohan Wang authored
This reverts commit c1176485 and relands commit 15cb261d with fix. Original change's description: > media: Add ENABLE_CDM_PROXY BUILDFLAG > > CdmProxy is still under development and will not be enabled on all > platforms. Hence, this CL adds a new buildflag so it's not enabled by > default. > Tbr: nasko@chromium.org > Bug: 785563 Tbr: xhwang@chromium.org,nasko@chromium.org,jrummell@chromium.org Bug: 785563 Change-Id: I940da6c83f987cd5027708b7d9ce7b1edc0c6970 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885512 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#710427}
-
Reilly Grant authored
These Javascript resources have Closure type annotations but they have never been checked. This change enables the type checking step and fixes the errors that it found. Bug: 1001198 Change-Id: Icf6d8cef1fb5e7b11a4a80e77ad664f4cbc1dc39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879469 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#710426}
-
Yura Yaroshevich authored
The comment above assert did not match behavior of assert. This comment has been fixed and an explanatory assertion message was added. Bug: None Change-Id: If9ac26c578ac45fb9e6dd50b1605ecff13bf1323 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881161Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Commit-Queue: Yura Yaroshevich <yura.yaroshevich@gmail.com> Cr-Commit-Position: refs/heads/master@{#710425}
-
Chris Mumford authored
Switching from testing::CreateFunctor to a C++ lambda is slightly easier to understand, but allows the deletion of an upcoming CL to delete gmock_mutant.h. Bug: 1007833, 806952 Change-Id: Ib210a0c92090ca330f99b695a3256c981f7f14e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887661Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#710424}
-
kylechar authored
This is a precursor to adding a new scoped_refptr(std::nullptr_t) constructor. The implicit conversion from NULL to scoped_refptr<T> causes a compilation error with the new constructor. Replace NULL with nullptr in any files where this is a problem. This CL was uploaded by git cl split. R=raymes@chromium.org Bug: 1018887 Change-Id: I2b2693e82a1aaf15022a680dda56122b7b09a6ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885013 Auto-Submit: kylechar <kylechar@chromium.org> Reviewed-by:
Bill Budge <bbudge@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#710423}
-
Piotr Bialecki authored
This switches uint32 to uint64 for IDs generated for AR-related entities (plane, anchor, hit test subscription) and changes methods that generate said IDs in ArCoreImpl to CHECK prior to potential overflow & no longer return an optional type. Bug: 1013643 Change-Id: Ic87b60a56b35e74b4b3b9d000741b27bad7dd90b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879671Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Klaus Weidner <klausw@chromium.org> Commit-Queue: Piotr Bialecki <bialpio@chromium.org> Cr-Commit-Position: refs/heads/master@{#710422}
-
Johannes Henkel authored
New revision: d2fc9b958e1eeb1e956f3e2208afa9923bdc9b67 To roll this I need to update some call sites; this is because the Serializable interface is changing. Upstream change / review was here: https://chromium-review.googlesource.com/c/deps/inspector_protocol/+/1879870 Change-Id: I42340da97177ce635d7e2c6c245247dd32f178f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877662Reviewed-by:
Leonard Grey <lgrey@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#710421}
-
Caroline Rising authored
When an animation is triggered while another is already in progress the animation was being stopped then restarted. This led to a 1 frame delay in the animation that was very noticeable when quickly scrubbing the tab strip. This change makes it so that the animation is never stopped and continues from where the interrupted animation left off. A linear animation also seems more fitting for this case since we are never reversing the animation. Bug: 1017134, 1017029 Change-Id: I945f5c180c8758cc5e14d7d45ed792bc7c11ac89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881949Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Ian Vollick <vollick@chromium.org> Commit-Queue: Caroline Rising <corising@chromium.org> Cr-Commit-Position: refs/heads/master@{#710420}
-
Quinten Yearsley authored
Depends on first adding Metrics analyzer definition in service cfg. The Metrics analyzer recipe has been temporarily changed to only run for changes by ltina@, https://crrev.com/c/1881935, so enabling this analyzer is not expected to create comments on regular CLs. TBR=tandrii@chromium.org Bug: 1004564 Change-Id: I008e855b759f97a0e70c400ee7891c7b9fcd2926 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885015 Commit-Queue: Quinten Yearsley <qyearsley@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Reviewed-by:
Andrii Shyshkalov <tandrii@google.com> Cr-Commit-Position: refs/heads/master@{#710419}
-
Ryan Sturm authored
- Adds support to put n high scoring links in a predicted set - Adds support to fetch predicted set in order serially - Removes rate limit of prerenders for NavigationPredictor - Finches the "n" value Bug: 1016213 Change-Id: Ieb343446ff18dd5da248022c65f58eb46a76610d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1877196Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Commit-Queue: Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#710418}
-
chrome://signin-email-confirmationdpapad authored
Bug: 1012533 Change-Id: I9088a9885806832629b9d0b6bea887ea81309784 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885223 Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710417}
-
Etienne Bergeron authored
This CL applying multiple change to fix the way ItemizeTextToRuns split a sequence of codepoints into runs with same/compatible scripts. *) Increase kMaxScripts to support codepoints with large amount of scripts. Some codepoint has much more than the previous maximum 5 scripts (see indic_fraction test u+A830, dev_danda u+0964). *) Only rely on Script extensions to find longest script interval see: http://www.unicode.org/reports/tr24/tr24-29.html (more specifically Table 7. Script_Extensions Examples) Cases where script was 'Common' and Script Extensions has a set of explicit script was not handled properly. Script Script Extensions Results Previously: Common {Hira Kana} -> {Hira Kana Common} Currently: Common {Hira Kana} -> {Hira Kana} This mistake has the consequene to put lot of codepoints from different scripts into the same bucket ('common') and there won't be a font that can renders (too) different scripts. Which is causing expensive fallback fonts lookups. "" U+30FC Scx = {Hira Kana} Script = Common Example 1. Mixed script detection for spoofing. Using the Script property alone, for example, will not detect that the U+30FC KATAKANA-HIRAGANA PROLONGED SOUND MARK (Script=Common) should not be mixed with Latin. "" *) Inherited script should only be applied to the previous codepoint. It was incorrectly intersected with the previous or the next one. [ RUN ] ItemizeTextToRunsScripts/RenderTextTestWithRunListCase.ItemizeTextToRuns/diac_lat ../../ui/gfx/render_text_unittest.cc(930): error: Expected equality of these values: param.expected Which is: "[0][1->2]" GetRunListStructureString() Which is: "[0->2]" That was causing more codepoints to be appended to long sequence of script when type was 'Common'. Bug: 1017194 Change-Id: Ia1339697a44d0d7bbac389997e9fa2878e6eac1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876489Reviewed-by:Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#710416}
-
Mike Wittman authored
This CL extracts the core stack copying parts of tracing::StackUnwinderAndroid into the dedicated base::StackCopierSignal class, and adapts it for direct use by the sampling profiler stack unwinding implementation. This drops some unneeded code; updates the code to run on 32-bit Android, 64-bit Android, and 64-bit Linux platforms; and converts the code to use C++ atomics. The StackUnwinderAndroid implementation will eventually be replaced wholesale by the sampling profiler implementation for Android. This CL does not attempt to reuse the extracted stack copying implementation on its own, in order to avoid introducing bugs in StackUnwinderAndroid due to the differing implementations. The reland enables the StackCopierSignalTest.CopyStackFromOtherThread test on 32-bit Android only. TBR=gab@chromium.org Bug: 988579, 1018615 Change-Id: I96704fe4843994721a0eb37896e11bea99be3fda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884376 Commit-Queue: Mike Wittman <wittman@chromium.org> Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#710415}
-
Tommy Steimel authored
This CL fixes a race where the toolbar icon could be stuck in a disabled state. The issue was that we didn't "unbind" the MediaNotificationItem if we were already frozen and bound, causing the MediaNotificationItem to get out of sync with the MediaToolbarButtonController. Bug: 1015903 Change-Id: I67df3365ecedf019f8edb621b660c9cc97a3bf38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886294Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#710414}
-
Benoît Lizé authored
This adds an error message to ProcessInitException, and in the process converts the error class to @IntDef. Bug: 979638 Change-Id: I1b1c531b0fdb212b70a977e7c84bde3043a00aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876329 Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#710413}
-
Nico Weber authored
This is a late follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1287850 -- since GetChannelName() now depends on GetChannel() being called previously, call it instead of relying on something else having called it. Probably a no-op in practice, but it makes the code more reliable and look less surprising. Bug: none Change-Id: Ie4e2c791db52f590d44d906fb5b0a42f521d427e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887270 Auto-Submit: Nico Weber <thakis@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#710412}
-
Mitsuru Oshima authored
Bug: 996858 Test: manually tested on arm device Change-Id: If24a863284a8f34704137eaef304822dc43bc181 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797653Reviewed-by:
Jun Mukai <mukai@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#710411}
-
Akihiro Ota authored
Currently in ChromeVox, we ignore events that come as a result of ChromeVox actions. However, this is causing us to ignore focus events that fire due to click actions. We do, in fact, want to process these events. This patch changes how events triggered by clicks are populated so that we respond to them on the ChromeVox side. Bug: 955129 Change-Id: Id0e6c0cb8899fef44721b4272eb9a48cb51e0443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872570Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Cr-Commit-Position: refs/heads/master@{#710410}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b6a2156a1346..8f67b33f0e7b Created with: gclient setdep -r src-internal@8f67b33f0e7b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I7762f9d5d3c272153360fd262b2e316090ef8d61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887670Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710409}
-
mark a. foltz authored
Moving documention about Chromium-specific build flags from the main repo. TBR=takumif@chromium.org Change-Id: I65b78cad32762bc882f13b1b5ecb7a2432da08c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872723Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Commit-Queue: mark a. foltz <mfoltz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710408}
-
Evan Stade authored
This function will shortly need to be reused in WebLayer's initial implementation of interstitials. To accomodate this, this CL componentizes this function into a new ssl_error_options_mask.* that also now includes the SSLErrorOptionsMask enum. Code authored by blundell@chromium.org TBR=eugenebut@chromium.org Change-Id: I6fbfce25b705c0a6018fe42c516c6a554b4fc757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879256Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#710407}
-
chrome://discardsdpapad authored
- Renamed graph_tab.js to graph_tab_template.js, otherwise GN complains that two different rules (polymer_modulizer, generate_graph_tab) declare the same output file. - generate_graph_tab now depends on polymer_modulizer, and processes the JS file that holds the HTML contents (in Polymer3 all HTML is hosted in JS files) - Changed substitute() to safe_substitute() in generate_graph_tab, otherwise Python trips over occurrences of "$" in the same file which don't correspond to template strings. - Extracted tests to a separate file so that they can be loaded in a JS module context. - Added missing js_library() dependency for ui/webui/resources/cr:icon.m, to fix a type checking failure. Bug: 1017874 Test: Page still works, no more HTML imports warnings in DevTools Change-Id: I77b9d7e8cb75cf8f9edc0ff91ad9eeb31118e704 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879782Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#710406}
-
David Benjamin authored
The tests which require configuring fine-grained test server behavior or, worse, bugs will be harder to resolve (maybe it's time to implement a barebones MockSSLServer in BoringSSL), but a lot of them can use EmbeddedTestServer easily. Since EmbeddedTestServer now pulls in TLS 1.3 which is vastly different from TLS 1.2, I've made most tests parameterized by version just to be a bit more thorough in testing. Bug: 492672 Change-Id: I87232d82d1c3a6f70099976fe4629457856b9f37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1874247Reviewed-by:
Steven Valdez <svaldez@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#710405}
-
Benjamin Beaudry authored
In changes pdfium:60110, pdfium:60410 and pdfium:59670, we exposed new APIs for text style: fill/stroke color, rendering mode and weight. This change forwards these new available text properties(+ font-family, which was already exposed) to the ppapi::PrivateAccessibilityTextRunInfo struct. We use an object of this type in PdfAccessibilityTree to create the AXNode. The next step is to populate this information on AXNode. Bug: 985604 Change-Id: Ia2e41c5427cfb972c071c2a3608631a4f23e6ff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752165 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Ian Prest <iapres@microsoft.com> Cr-Commit-Position: refs/heads/master@{#710404}
-
Nico Weber authored
Make GetChannelSuffixForDataDir() exist always on linux, to make it independent of GOOGLE_CHROME_BRANDING. On Linux, disentangle the logic in that function from GetChannelImpl() and instead make it call GetChannel(). This makes it automatically do the right thing in unbranded builds (returning an empty suffix). This should be behavior-preserving, but if we ever wanted to do release channels for unbranded builds, this is a tad easier to do now -- and we have less mode-dependent code. Bug: 961769 Change-Id: Id9aec641c3468033f8d676c14874a68016493fea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887152 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Kevin McNee authored
Many of the portal browser tests have the same steps to run at the beginning of the test: inject script to create a portal and to navigate it to a given URL, and then wait for the navigation to finish. We factor this out into a common function. We also perform a few small cleanups. We rename the test ReactivatePredecessor to AdoptPredecessor, since it doesn't actually reactivate. We increase usage of JsReplace instead of StringPrintf. Bug: None Change-Id: Ia1ef41b8138df0189ad3291b76c34be53c291403 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885171Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#710402}
-
Christopher Grant authored
This reverts commit 667d336e. Reason for revert: Breaks downstream Android builds. https://ci.chromium.org/p/chrome/g/internal.client.clank/console Original change's description: > Rename gl_test to gpu_tests > > This is to make the name reflect that there aren't just OpenGL tests in > this executable now, there are WebGPU / Dawn tests too. > > Bug: 1017035 > Change-Id: Id685700c01dfe754fc23220c34d49c96f835cc5a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885470 > Reviewed-by: Zhenyao Mo <zmo@chromium.org> > Reviewed-by: John Budorick <jbudorick@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710382} TBR=zmo@chromium.org,cwallez@chromium.org,jbudorick@chromium.org Change-Id: I7e1ae7d108568a704f4900261b1f4b318d58b26c No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1017035 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1887665Reviewed-by:
Christopher Grant <cjgrant@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#710401}
-
