GitLab

BUG=

Review URL: https://codereview.chromium.org/130183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243845 0039d316-1c4b-4281-b951-d872f2087c98

This goes from 1% to 10% . Over Jan 7-8 we only got 3 jobs total with
no problems.

BUG=317931
R=joi@chromium.org

Review URL: https://codereview.chromium.org/131503002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243844 0039d316-1c4b-4281-b951-d872f2087c98

BUG=297672
TBR=joi@chromium.org

Review URL: https://codereview.chromium.org/130173003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243843 0039d316-1c4b-4281-b951-d872f2087c98

This breaks examples of NaCl SDK.
http://build.chromium.org/p/client.nacl.sdk/builders/mac-sdk-multi/builds/6796

> PPAPI: Add new PPB_FileRef.MakeDirectory to support exclusive operation
> 
> Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
> the given path. This makes it difficult to create POSIX compatible API on
> top of PPAPI.
> 
> This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
> That makes a new directory according to the given PP_MakeDirectoryFlags
> values. The flags provide exclusive operation option. If exclusive flag
> is specified and a directory exists on the given path, the function fails
> and returns PP_ERROR_FILEEXISTS.
> 
> 
> BUG=314879
> TEST=browser_tests
> 
> Review URL: https://codereview.chromium.org/113363004

TBR=nhiroki@chromium.org

Review URL: https://codereview.chromium.org/131473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243842 0039d316-1c4b-4281-b951-d872f2087c98

there already is information in the autofill DB.

BUG=326679

Review URL: https://codereview.chromium.org/120343003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243841 0039d316-1c4b-4281-b951-d872f2087c98

In OSExchangeData, there's a difference between URLs and files. In the
mime type "text/uri-list", there isn't, and Linux usually uses the later
to exchange both data types.

This fixes dragging files onto several sites, like the HTML Five Wow
Terminal, but doesn't fix Dropbox, which seems to be failing somewhere
else.

BUG=317548

Review URL: https://codereview.chromium.org/129113004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243840 0039d316-1c4b-4281-b951-d872f2087c98

BUG=330823
TEST=Regression testing manually
NOTRY=TRUE

Review URL: https://codereview.chromium.org/110853006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243839 0039d316-1c4b-4281-b951-d872f2087c98

Will rebaseline.

> Revert of https://codereview.chromium.org/128443002/
> Reason for revert: a bunch of video* layout tests failed http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/24977
> 
> TBR=reed@google.com,thestig@chromium.org,jochen@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=332271
> 
> Review URL: https://codereview.chromium.org/130963002

TBR=alph@chromium.org

Review URL: https://codereview.chromium.org/131443002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243838 0039d316-1c4b-4281-b951-d872f2087c98

This means that running with --reset-app-list-install-state
--enable-app-list always re-installs the app list, even if it has
already been installed.

BUG=332324

Review URL: https://codereview.chromium.org/127753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243837 0039d316-1c4b-4281-b951-d872f2087c98

BUG=316685

Review URL: https://codereview.chromium.org/110883015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243836 0039d316-1c4b-4281-b951-d872f2087c98

Call WebSocketMsg_NotifyFailure instead of
WebSocketMsg_AddChannelResponse(true, ...) when the opening handshake fails.

BUG=310405
R=ricea@chromium.org

Review URL: https://codereview.chromium.org/105833003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243835 0039d316-1c4b-4281-b951-d872f2087c98

It is no longer used.

BUG=

Review URL: https://codereview.chromium.org/101013004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243834 0039d316-1c4b-4281-b951-d872f2087c98

BUG=329978
TEST=none
R=palmer@chromium.org

Review URL: https://codereview.chromium.org/98753005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243833 0039d316-1c4b-4281-b951-d872f2087c98

BUG=299154
TEST=unit_tests
R=estade@chromium.org

Review URL: https://codereview.chromium.org/127403002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243832 0039d316-1c4b-4281-b951-d872f2087c98

so that rebuilding detail inputs on Autofill popup acceptance doesn't crash.
This also changes the public AutofillDialogView API to accept ServerFieldTypes
intead of DetailInputs in FillSection() and HitTestInput().

NOTE: |input.type| was the only thing used by all callers anyways, so rather than
dance around resetting a potentially dead pointer, I'd rather change to server
types.

BUG=331544
R=estade@chromium.org,groby@chromium.org

Review URL: https://codereview.chromium.org/127153004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243831 0039d316-1c4b-4281-b951-d872f2087c98

adb forward --remove is not available in older adb binaries;
to avoid leaks, maintain a pool of previously forwarded ports.

BUG=None

Review URL: https://codereview.chromium.org/127143003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243830 0039d316-1c4b-4281-b951-d872f2087c98

While Custom Element callbacks were being renamed in Blink, WebView
had to work with either old or new names. The new names are available
post Blink r164213, so it's OK to use the new names exclusively now.

BUG=180965
TEST=WebViewTest.*

Review URL: https://codereview.chromium.org/127133004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243829 0039d316-1c4b-4281-b951-d872f2087c98

This avoids duplicating the default logic for all of its methods.
Previously, every time a method was called, we had to test for NULL and
assume the default value for that method (even though the default method
implementation already exists; it was never used). Now the caller
assumes platform_observer_ is non-NULL (via a DCHECK) and it is the base
class's responsibility to provide default methods.

Review URL: https://codereview.chromium.org/124893002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243819 0039d316-1c4b-4281-b951-d872f2087c98

Packaged apps do not have access to some features of the Web platform
that are deprecated, or that do not make sense in the context of an
app. Currently, accessing most of those features throws an error.

This change makes thse features behave more like missing featurs on the
Web platform. Whenever possible, accessing restricted features returns
undefined and logs an error to the browser console. Features accessible
via non-configurable ES5 properties (e.g. window.alert, document.write)
either become no-ops or throw errors, on a case-by-case basis.

Deprecated events have their "on*" properties return undefined (as
opposed to null, for events with no handlers) to facilitate feature
detection. Using addEventListener for these events used to throw an
error, and now logs an error to the console and turns into a no-op, to
mimic the behavior for undefined events as well as possible.

This change aims to make JavaScript libraries written for browsers work
in packaged apps as seamlessly as possible, while still providing useful
warnings for developers. This creates a couple of warts: (1) properties
are not removed, so the "in" operator will still see them, and (2)
dispatchEvent will never deliver deprecated events, but it normally
delives un-implemented events.

BUG=330487

Review URL: https://codereview.chromium.org/120733003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243817 0039d316-1c4b-4281-b951-d872f2087c98

Previously, sort was not started until all the metadata is fetched. When fetching took a time, the user saw unsorted list for a while. With this patch, sort is happened just after every updates. User can see sorted list every time.

BUG=327479
TEST=manually tested

Review URL: https://codereview.chromium.org/113293007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243816 0039d316-1c4b-4281-b951-d872f2087c98

BUG=331223

Review URL: https://codereview.chromium.org/122803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243814 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243813 0039d316-1c4b-4281-b951-d872f2087c98

This patch removes the last instance of fullPath from the metadata cache, by using volume manager and its getLocationInformation method.

TEST=Tested manually.
BUG=320967

Review URL: https://codereview.chromium.org/130663002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243812 0039d316-1c4b-4281-b951-d872f2087c98

TBR=scottmg@chromium.org

Review URL: https://codereview.chromium.org/131103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243811 0039d316-1c4b-4281-b951-d872f2087c98

$ git log f1632c7d11..def5b803e9 --date=short --format="%ad %ae %s" | sed 's/@chromium\.org//'
2014-01-08 maruel Allow extra argument in run_isolated.py.
2014-01-08 maruel Add date in the temporary name generated by isolate.py run.

BUG=321878

Review URL: https://codereview.chromium.org/130563002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243810 0039d316-1c4b-4281-b951-d872f2087c98

In order to be compatible with the v2 version of the update protocol and
existing update configuration files, the "os" attribute (and fwiw, "arch")
must be serialized as part of the <request> element.

BUG=332551

Review URL: https://codereview.chromium.org/130543002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243809 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243808 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243804 0039d316-1c4b-4281-b951-d872f2087c98

This change is the first pass of restructuring
the exynos vda implementation to a more generic
v4l2 vda to facilitate support for other v4l2
based vda.

BUG=chromium-os-partner:24752
TEST=Run video playback, vda_unittest

Review URL: https://codereview.chromium.org/122233002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243803 0039d316-1c4b-4281-b951-d872f2087c98

Current PPB_FileRef.MakeDirectory returns PP_OK if a directory exists on
the given path. This makes it difficult to create POSIX compatible API on
top of PPAPI.

This change introduces new PPB_FileRef.MakeDirectory as dev channel API.
That makes a new directory according to the given PP_MakeDirectoryFlags
values. The flags provide exclusive operation option. If exclusive flag
is specified and a directory exists on the given path, the function fails
and returns PP_ERROR_FILEEXISTS.


BUG=314879
TEST=browser_tests

Review URL: https://codereview.chromium.org/113363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243802 0039d316-1c4b-4281-b951-d872f2087c98

This brings in Brotli format change and bug fixes.

dfc5a9f2151a Fix -Wconversion compiler warnings in the brotli decoder.
4c8c7fd31c6a Brotli format change: small improvement to the encoding of Huffman codes
efbc1a896593 Small update to brotli specification.
40955ce409e5 Bug fixes for the brotli encoder and decoder.
b89f3be40b69 Brotli format change: improved encoding of Huffman codes
30625ba238fc Use C-style comments in the brotli decoder.

BUG=307828,329547,329258,331253

Review URL: https://codereview.chromium.org/109283009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243801 0039d316-1c4b-4281-b951-d872f2087c98

If the session becomes disconnected, this hides the desktop display
instead of leaving it visible and non-interactive.

BUG=325593
TEST=Disconnect the session by killing the host process.

Review URL: https://codereview.chromium.org/105943010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243800 0039d316-1c4b-4281-b951-d872f2087c98

Public facing APIs should just live in the mojo:: namespace.

R=sky@chromium.org, viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/128803002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243799 0039d316-1c4b-4281-b951-d872f2087c98

This patch allows streamlined hosted apps to use the apple touch icons
for generating hosted apps.

To use the icons, it is necessary to size them to
extension_misc::kExtensionIconSizes to make the manifest handler agree
to use the icons.

Added TabHelper::ConstrainBitmapsToSizes which finds the
closest, not-smaller bitmap for each size and downsizes it. At most each
bitmap is used for 1 size in order to prevent generating resized icons
which would be stored on disk.

BUG=318607

Review URL: https://codereview.chromium.org/105873009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243797 0039d316-1c4b-4281-b951-d872f2087c98

In some cases, the RenderView performs a history navigation in response to a
reload when the WebFrame does not have the page in question committed. Override
the cache policy so the navigation revalidates the cache, rather than skipping
revalidation altogether.

BUG=331386
TEST=CrashRecoveryBrowserTest.ReloadCacheRevalidate

Review URL: https://codereview.chromium.org/101203007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243796 0039d316-1c4b-4281-b951-d872f2087c98

This is supported since JB-MR1, and doesn't subtract
window decorations etc. like other size metrics do.

TBR=yfriedman@chromium.org
BUG=329439

Review URL: https://codereview.chromium.org/93933016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243795 0039d316-1c4b-4281-b951-d872f2087c98

All migration code has already landed. This is the final CL that carries out the switch.
By this CL, Files.app in multi-profile session starts showing each profile's Downloads folder,
not the primary profile's one. This is a transient state for the future fully-multiprofile-aware
Files.app (ETA: M34) that shows all profile's folder in a single window.

The following is the summary/background why the path switch is needed:

We had used /home/chronos/user/Download as the path to the "Downloads" folder for all users.
This does not hold for multi-profile session. The "real" path for multiple users are
/home/chronos/u-unique-hash-userA/Downloads
/home/chronos/u-unique-hash-userB/Downloads
...
and /home/chronos/user is just an alias to the user who first signed into the session.

To make all user's folder available simultaneously in one multi-profile session,
we need to stop using the alias, and differentiate all folders by the real path.

BUG=309556

Review URL: https://codereview.chromium.org/48903012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243794 0039d316-1c4b-4281-b951-d872f2087c98

Recently this started flaking. The problem was that the exit manager (or the shadowing one if it was there) would run before the in-process utility thread shutdown. Since the thread was holding on to g_one_utility_thread_lock, the exit manager would try to destroy that LazyInstance but it would fail because the lock was still owned by a different thread.

The fix is to ensure that the utility thread is gone. This is done by waiting for all UtilityProcessHost objects to get destructed. This wasn't happening before because the tests would just wait for their app-specific IPC from the utility thread, which is dispatched before the OnChannelError in ChildProcessHost ends up killing the UtilityProcessHost.

BUG=316919
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/128993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243793 0039d316-1c4b-4281-b951-d872f2087c98

Reason for revert: a bunch of video* layout tests failed http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/24977

TBR=reed@google.com,thestig@chromium.org,jochen@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=332271

Review URL: https://codereview.chromium.org/130963002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243791 0039d316-1c4b-4281-b951-d872f2087c98

See commit message of r232166 for details.

BUG=none
NOTRY=true
R=scottmg@chromium.org

Review URL: https://codereview.chromium.org/130873002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@243790 0039d316-1c4b-4281-b951-d872f2087c98