GitLab

The size of the frame data from a delegated source will not in general match up
exactly with the delegated layer's bounds. Frame sizes and layer bounds are both
expressed as integers, but frame sizes are in physical pixels and layer bounds
are in device-independent pixels. If the device scale is not an integer, there
may not be an exact mapping between the two spaces. For instance, if the layer
size is 105 x 211 and the device scale is 1.5, the delegated content is
responsible for filling 157.5 x 316.5 physical pixels in the final output. This
isn't really possible so what actually happens is the delegated renderer
produces a frame with a physical size of 158 x 317 pixels and sends that up to
the DRLI. To map this frame into physical space, the DRLI should apply the
inverse of the device scale factor to reflect that the frame covers 105.333 x
211.3333 logical pixels.

Before this patch, DRLI would attempt to scale the frame by (105/158, 211/317)
resulting in the frame being scaled down non-uniformly to try to make 158 x 317
pixels fit into a 157.5 x 316.6 space. This scaling looks bad and ends up
mapping pixels partially outside of the layer's logical bounds into the layer's
logical bounds.

BUG=370074

Review URL: https://codereview.chromium.org/311253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275544 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/320513002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275542 0039d316-1c4b-4281-b951-d872f2087c98

TBR=nduca@chromium.org

BUG=

Review URL: https://codereview.chromium.org/322553003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275541 0039d316-1c4b-4281-b951-d872f2087c98

* Make FixupUserInput() just return the fixed-up input text, since almost every
  caller wanted that (and the one that didn't, the HUP, will change in the
  future)
* Make some functions which took an AutocompleteInput object and then only cared
  about the text() just take a string16
* Eliminated HistoryURLProvider::RunAutocompletePasses(), since it had only one
  caller, and just inline the code into Start().  Also got rid of the
  |fixup_input_and_run_pass_1| variable that was never false.

BUG=none
TEST=none

Review URL: https://codereview.chromium.org/312423003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275540 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275539 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=175623:175677&mode=html

TBR=peter@chromium.org

Review URL: https://codereview.chromium.org/316383003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275538 0039d316-1c4b-4281-b951-d872f2087c98

BUG=381893
TBR=perkj@chromium.org

Review URL: https://codereview.chromium.org/320103002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275537 0039d316-1c4b-4281-b951-d872f2087c98

BUG=322664

Review URL: https://codereview.chromium.org/316373003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275536 0039d316-1c4b-4281-b951-d872f2087c98

Call RenderViewImpl::SetScreenOrientationForTesting from MockScreenOrientationController::UpdateScreenOrientation() to make sure that events are not sent when orientation is locked.

Existing implementation calls SetScreenOrientationForTesting and sends screen
orientation events even when the test screen orientation is locked.

BUG=162827

Review URL: https://codereview.chromium.org/302553007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275535 0039d316-1c4b-4281-b951-d872f2087c98

Fix an easily reproducible crash that happens locally in the PDF plugin.

BUG=375126

Review URL: https://codereview.chromium.org/298803010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275534 0039d316-1c4b-4281-b951-d872f2087c98

Move the functionality we still need into the BluetoothDevice class.

BUG=372495
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/317073011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275532 0039d316-1c4b-4281-b951-d872f2087c98

The methods GetActivePermission() and HasAPIPermission() have been deprecated
for more than a year.  Finally remove them.
Also clean up some includes in extension.h, and fix transitive includes.

BUG=379356
TBR=atwilson@chromium.org (c/b/background)
TBR=yurys@chromium.org (c/b/devtools)
TBR=bauerb@chromium.org (c/b/managed_mode)
TBR=dalecurtis@chromium.org (c/b/media)
TBR=dewittj@chromium.org (c/b/notifications)
TBR=msw@chromium.org (c/b/ui)

All TBRs are for strictly mechanical changes - no functional difference.

Review URL: https://codereview.chromium.org/314113010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275531 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275527 0039d316-1c4b-4281-b951-d872f2087c98

getting the logs. The current fields (os, product, product version) is
populated using chrome_version_info.h.

Review URL: https://codereview.chromium.org/317823008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275526 0039d316-1c4b-4281-b951-d872f2087c98

TBR=miu
BUG=381542

Review URL: https://codereview.chromium.org/319183003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275525 0039d316-1c4b-4281-b951-d872f2087c98

The FeatureUtilities class has been moved upstream. The original class
has been left in place; It will be removed and all package references
changed to the new version once the change has been rolled into
Clankium.

Unit Tests for FeatureUtilities.java have been added. Currently I have
added only tests for the speech recognition feature.


BUG=243060

Review URL: https://codereview.chromium.org/304573002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275524 0039d316-1c4b-4281-b951-d872f2087c98

CanBeEditedByUser indicates if a bookmark can be edited by the user or not.
All of the bookmarks in the bookmark_bar_node, the other_node and the
mobile_node are always editable but some of the extra nodes provided by the
client may be unmodifiable.

Also updated other methods to work only with user-editable nodes, and added
utility helpers to detect nodes that can or can't be edited.

BUG=49598

Review URL: https://codereview.chromium.org/317333004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275523 0039d316-1c4b-4281-b951-d872f2087c98

BUG=376567

Review URL: https://codereview.chromium.org/314133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275522 0039d316-1c4b-4281-b951-d872f2087c98

Revert of suppress uninit error at SkUnPreMultiply::PMColorToColor in content_browsertests (https://codereview.chromium.org/322463004/)

Reason for revert:
Should no longer be needed.

Original issue's description:
> suppress uninit error at SkUnPreMultiply::PMColorToColor in content_browsertests
> 
> BUG=380680
> TBR=reed@google.com
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275306

TBR=reed@google.com,zhaoqin@google.com
NOTREECHECKS=true
NOTRY=true
BUG=380680

Review URL: https://codereview.chromium.org/324513004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275521 0039d316-1c4b-4281-b951-d872f2087c98

With gn, it'll probably be common for folks to generate their out directory
in places other than out/{Debug|Release}. This is technically possible (and
busted) in gyp as well. This avoids the relative path dependency from the
script and simplifies it some more by adding the src/ui/gl and src/gpu
directories in the build files (where they can be relativized properly)
instead of trying to do so in the script.

R=brettw@chromium.org

Review URL: https://codereview.chromium.org/317813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275520 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
TBR=zea@chromium.org

Review URL: https://codereview.chromium.org/321593003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275519 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/311343006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275515 0039d316-1c4b-4281-b951-d872f2087c98

BUG=380827

Review URL: https://codereview.chromium.org/324453003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275514 0039d316-1c4b-4281-b951-d872f2087c98

BUG=

Review URL: https://codereview.chromium.org/314293004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275513 0039d316-1c4b-4281-b951-d872f2087c98

SpdyFramer will accept them, and frame them if present. We may want to leave this for later SPDY versions, but certainly don't emit them in SPDY4.

BUG=345769

Review URL: https://codereview.chromium.org/316983006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275512 0039d316-1c4b-4281-b951-d872f2087c98

not everything in the video frame is opaque.

R=reed@google.com, sievers@chromium.org
BUG=380680

Review URL: https://codereview.chromium.org/319133003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275511 0039d316-1c4b-4281-b951-d872f2087c98

BUG=https://code.google.com/p/nativeclient/issues/detail?id=3114
TEST=compile

Review URL: https://codereview.chromium.org/322443007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275510 0039d316-1c4b-4281-b951-d872f2087c98

The previous code made it possible to try to access tabs prior to the session
restore completing. This should make the benchmark much more deterministic.

BUG=375979

Review URL: https://codereview.chromium.org/313923003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275509 0039d316-1c4b-4281-b951-d872f2087c98

|adb_gdb --su-prefix=su| wasn't working for me, so updating doc and script.

BUG=337423

Review URL: https://codereview.chromium.org/315223005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275508 0039d316-1c4b-4281-b951-d872f2087c98

In the case of the reported crash, we doesn't set the transient
parent, which means we cannot unregister the window observer.

BUG=373522
R=erg@chromium.org
TEST=see the bug

Review URL: https://codereview.chromium.org/317303002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275507 0039d316-1c4b-4281-b951-d872f2087c98

R=phajdan.jr@chromium.org, oshima@chromium.org
BUG=375537
TEST=Trybots

Review URL: https://codereview.chromium.org/314863004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275506 0039d316-1c4b-4281-b951-d872f2087c98

This change makes each platform specific ChannelImpl into
a subclass of Channel: ChannelPosix, ChannelWin, ChannelNacl.
delegated functions are now virtual.

TEST=none
BUG=377980
R=darin@chromium.org, jam@chromium.org

Review URL: https://codereview.chromium.org/310293002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275505 0039d316-1c4b-4281-b951-d872f2087c98

Encoding icons to urls for WebUI is expensive enough that we should
do some basic caching to avoid redundant encoding calls.

BUG=336385

Review URL: https://codereview.chromium.org/314183002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275504 0039d316-1c4b-4281-b951-d872f2087c98

That use is both wrong (request IDs are global) and unnecessary since cert
enrollment is not a multi-step process. There's some stub code and indirections
for prompting to add a cert that's never actually used. Collapse it all to
simplify things. Move other random things out of SSLTabHelper which is also
no longer necessary.

(If anything, this stuff should probably go through the downloads
infrastructure to inherit all the user-gesture and throttling checks.)

Also move the AddCertificate hook from render_view_id to render_frame_id.

BUG=376003
TEST=Visit https://davidben.net/mixed-content-test.html; Click button. Lock
     icon should change to lock icon with warning.

Review URL: https://codereview.chromium.org/302653006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275503 0039d316-1c4b-4281-b951-d872f2087c98

Pending move of CreateWebRtcMediaEngine() to webrtcmediaengine.cc.

BUG=webrtc:1788
R=ronghuawu@chromium.org

Review URL: https://codereview.chromium.org/322433007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275502 0039d316-1c4b-4281-b951-d872f2087c98

FastPaint (which avoids creating a copy of video frames in the native pixel format) was enabled only for software compositing in the case where the render target was opaque (that is to say, wasn't enabled).

This removes calls to our own pixel format conversion code that don't have exact equivalents in libYUV.

BUG=369375

Review URL: https://codereview.chromium.org/314833002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275501 0039d316-1c4b-4281-b951-d872f2087c98

Also fixed bug in ChromeResourceDispatcherHostDelegate where it was using the wrong URL when detecting whether to add a policy header to a redirect (yay for tests).

BUG=378729

Review URL: https://codereview.chromium.org/303993005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275498 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275496 0039d316-1c4b-4281-b951-d872f2087c98

This pulls in the following Native Client changes:

r13282: (hamaji) Non-SFI Mode: Handle args and envp in entry_linux.c
r13283: (hamaji) Remove FUN_TO_VOID_PTR in nc_thread.c
r13284: (jfb) Update revision for PNaCl r13261->r13281
r13285: (dyen) Fix for incorrect indentation causing windows to not update cygwin.
r13286: (mseaborn) Cleanup: Fix dlmalloc/malloc.c to compile with -Wstrict-prototypes
r13287: (mcgrathr) Update x86 and ARM newlib toolchains
r13288: (dyen) When validating git repositories, also check if the repository is empty.
r13289: (bradnelson) Turn annotator tags for toolchain_build back on by default.
r13290: (sehr) Create NaCl Android trybots
r13291: (dyen) Toolchain building now utilizes a git cache to share git objects.
r13292: (mcgrathr) toolchain_build: Add suffix to buildbot test step names
r13293: (binji) Update PNaCl newlib
r13294: (hamaji) Non-SFI Mode: Add thread support to libnacl_sys_private
r13295: (hamaji) Work-around a false alarm from cpplint by defining a typedef

BUG=none
TEST=browser_tests and nacl_integration

Review URL: https://codereview.chromium.org/319113002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275495 0039d316-1c4b-4281-b951-d872f2087c98

Bisect bots creates binaries under build/bisect, where as logcat where
searching for binaries and other related file under build/src.
Now we look for files under build/bisect on bisect bots.

BUG=381377
NOTRY=true

Review URL: https://codereview.chromium.org/317993004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@275494 0039d316-1c4b-4281-b951-d872f2087c98