Skip to content

GitLab

T
tangled
Switch branch/tag
  1. 22 Aug, 2016 12 commits
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 04dff7f2
      ricea authored 
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2254973004
Cr-Commit-Position: refs/heads/master@{#413394}
      04dff7f2
    • horo's avatar
      Keep ServiceWorkerMetrics::Site in ServiceWorkerVersion · 5c7b49db
      horo authored 
      To reduce the string comparison in SiteFromURL().

This CL depends on https://codereview.chromium.org/2251633002/.

https://codereview.chromium.org/2249063004/ depends on this CL.

BUG=561209

Review-Url: https://codereview.chromium.org/2250623003
Cr-Commit-Position: refs/heads/master@{#413393}
      5c7b49db
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 5e27337b
      ricea authored 
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2252373002
Cr-Commit-Position: refs/heads/master@{#413392}
      5e27337b
    • catapult-deps-roller's avatar
      Roll src/third_party/catapult/ cda4e72f8..947506bac (1 commit). · 8c8697b3
      catapult-deps-roller authored 
      https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/cda4e72f8776..947506bacfb5

$ git log cda4e72f8..947506bac --date=short --no-merges --format='%ad %ae %s'

BUG=639632

TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2264903002
Cr-Commit-Position: refs/heads/master@{#413391}
      8c8697b3
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 68860bd0
      ricea authored 
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2253233004
Cr-Commit-Position: refs/heads/master@{#413390}
      68860bd0
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · eb5cdbe2
      ricea authored 
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2259753003
Cr-Commit-Position: refs/heads/master@{#413389}
      eb5cdbe2
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · 799a1fd2
      ricea authored 
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2256813005
Cr-Commit-Position: refs/heads/master@{#413388}
      799a1fd2
    • ricea's avatar
      Re-write many calls to WrapUnique() with MakeUnique() · c9462d4d
      ricea authored 
      A mostly-automated change to convert instances of WrapUnique(new Foo(...)) to
MakeUnique<Foo>(...). See the thread at
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/iQgMedVA8-k
for background.

To avoid requiring too many manual fixups, the change skips some cases that are
frequently problematic. In particular, in methods named Foo::Method() it will
not try to change WrapUnique(new Foo()) to MakeUnique<Foo>(). This is because
Foo::Method() may be accessing an internal constructor of Foo.

Cases where MakeUnique<NestedClass>(...) is called within a method of
OuterClass are common but hard to detect automatically, so have been fixed-up
manually.

The only types of manual fix ups applied are:
1) Revert MakeUnique back to WrapUnique
2) Change NULL to nullptr in argument list (MakeUnique cannot forward NULL
   correctly)
3) Add base:: namespace qualifier where missing.

WrapUnique(new Foo) has not been converted to MakeUnique<Foo>() as this might
change behaviour if Foo does not have a user-defined constructor. For example,
WrapUnique(new int) creates an unitialised integer, but MakeUnique<int>()
creates an integer initialised to 0.

git cl format has been been run over the CL. Spot-checking has uncovered no
cases of mis-formatting.

  BUG=637812

Review-Url: https://codereview.chromium.org/2257763002
Cr-Commit-Position: refs/heads/master@{#413387}
      c9462d4d
    • anthonyhkf's avatar
      [Typed-OM] Add CSSURLImageValue · 15c53e90
      anthonyhkf authored 
      Spec: https://drafts.css-houdini.org/css-typed-om/#cssurlimagevalue

BUG=545318

Review-Url: https://codereview.chromium.org/2208283002
Cr-Commit-Position: refs/heads/master@{#413386}
      15c53e90
    • tkent's avatar
      Rebaseline imported/wpt/dom/nodes/*-getElementsByTagName.html · 565bd2b7
      tkent authored 
      TBR=qyearsley@chromium.org

Review-Url: https://codereview.chromium.org/2268483002
Cr-Commit-Position: refs/heads/master@{#413385}
      565bd2b7
    • iceman's avatar
      Use EphemeralRange instead of Range* in DocumentMarkerController class. · 1ca795d4
      iceman authored 
      No behavior changes.

BUG=388681

Review-Url: https://codereview.chromium.org/2246143004
Cr-Commit-Position: refs/heads/master@{#413384}
      1ca795d4
    • skia-deps-roller's avatar
      Roll src/third_party/skia/ ce2504186..577e012e4 (1 commit). · e17fd235
      skia-deps-roller authored 
      https://chromium.googlesource.com/skia.git/+log/ce25041865e7..577e012e4058

$ git log ce2504186..577e012e4 --date=short --no-merges --format='%ad %ae %s'
2016-08-21 reed add translate to exercise non-identity ctm performance

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel
TBR=bungeman@google.com

Review-Url: https://codereview.chromium.org/2268463002
Cr-Commit-Position: refs/heads/master@{#413383}
      e17fd235
  3. 21 Aug, 2016 28 commits