GitLab

Prior to this change, expand button inherits ToggleImageButton's default
focus behavior which is ACCESSIBLE_ONLY. This button should be focusable
by default as user can navigate/toggle the button using a keyboard.

Bug: 1001103
Change-Id: Ic698f3865ddcb8cc66b962292831c3d5a73fc29f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510729Reviewed-by: Marijn Kruisselbrink <mek@chromium.org>
Commit-Queue: Wei Li <weili@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823662}

Despite this test already being marked as [ Pass Crash ], when the
test crashes on the bots, the Flake Portal registers the crash not as
a crash but as a failure, see https://crbug.com/1094930#c25.

For now, I'm marking this test as [ Pass Crash Failure ].

TBR=hta@chromium.org

Bug: chromium:1094930
Change-Id: Ic6e1b54798ba53302ef1b7ac9dee4b06cba2a08c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517462
Auto-Submit: Henrik Boström <hbos@chromium.org>
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823661}

This reverts commit dbe0ea06.

Reason for revert: New test fails on the following bots:
https://ci.chromium.org/p/chromium/builders/ci/Lollipop%20Phone%20Tester
https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%20Tablet%20Tester
https://ci.chromium.org/p/chromium/builders/ci/Android%20WebView%20N%20%28dbg%29

Original change's description:
> ContentCapture: re-stream onscreen content when the frame show again
>
> Previously ContentCaptureConsumer had no way to know the the frame
> shows again because the visible content didn't change.
>
> This patch resets the task session when the frame was hidden, so
> ContentCapture task will stream on-screen content because they
> aren't streamed from the task point of view when the frame was
> shown.
>
> Adds the test to coverage this scenario.
>
> Bug: 1137463
> Change-Id: I0065ce080101d2149622b0f9f6a3aa196c18d717
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511030
> Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
> Commit-Queue: Michael Bai <michaelbai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823251}

TBR=michaelbai@chromium.org,wangxianzhu@chromium.org

Change-Id: I219bd94c5dfc36b073590d6e604ce951aef3c966
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1137463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518401Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823660}

This config is unsupported. Leave angle_unittests because they're
used with Chrome separate from ANGLE. This removes angle_end2end
and angle_perftests.

Bug: angleproject:5298
Change-Id: Ia7ddca4de7e2989fd7e2d375dec7a9a3bf942f39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517642Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823659}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/655afebfcd13..5bdfcd8f3397

2020-11-03 sokcevic@google.com Add `main` when guessing origin remote

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1143724
Tbr: sokcevic@google.com,ajp@google.com,apolito@google.com,ehmaldonado@google.com
Change-Id: Ib34347e387f75f7d63ba2b9d4cd0eee314f1711e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517887Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823658}

These changes will add a tester for Android Marshmallow which
will run Weblayer skew tests. It also renames the Android 10 builder.

Bug: 1114563
Change-Id: I13b72e50cac7e322bfd8214fae4e08718d7667b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514675Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#823657}

Context:
In order to extract the common part of CPRService#initAndValidate() into
PRService#initAndValidate() and provide extensibility for
WebLayerPRService's counter part, this CL breaks down
CPRService#initAndValidate() into several small methods ready to be
moved into PRService.

Changes:
* Broken initAndValidate() down into these methods:
 - modifyMethodData(): provide a chance to monkey-patch
   methodData if needed.
 - onWhetherGooglePayBridgeEligible(): provides a chance for the caller
   to decide whether skip-to-gpay route would be enabled.
 - onQueryForQuotaCreated(): provides a chance to monkey-patch
   mQueryForQuota if needed.
 - disconnectIfExtraValidationFails(): provides a chance to do
   extra validation.
 - onSpecValidated(): provides a chance for the valid
   PaymentRequestSpec to be saved by ChromeLayerPRService and
   WebLayerPRService, initialize the UI service and do journey logging.
 - addPaymentAppServiceFactories(): provides a chance to add different
   payment app factories in Chrome and WebLayer.

* Refactored getValidatedMethodData(): extract the Skip-to-GPay
  monkey-patching of the methodData out of the method, calling it
  modifyMethodData() which going forwards will be called only in
  Chrome (not WebLayer).

Bug: 1144527

Change-Id: I3635e8450a847d989cb0bc1c86c8d7bb7d1dc014
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514699
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823656}

Since cl/337200290, the Nearby Share server returns both Google contacts
and device contacts in the ListContactPeople RPC response. That update
labels every contact with a Google-, device-, or unknown-contact type.
The burden is on the client to filter by type if desired.

In this CL, we add an enabled-by-default flag to allow use of device
contacts returned in the ListContactPeople RPC response. When the flag
is disabled, we filter out device contacts. Server-side support for
device contacts is fairly new, and there is a risk for returning
duplicate contacts: one Google contact and one device contact that
are essentially the same. We want a kill switch in case things go awry.

Fixed: 1143680
Change-Id: I239f50593188910ba00773bc878a41bc77126f51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510351
Commit-Queue: Josh Nohle <nohle@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Cr-Commit-Position: refs/heads/master@{#823655}

Adds comments explaining the meaning of each ExclusionReason value.

Bug: None
Change-Id: Ia3ae82d2ce552ec783be635092f301c408abfc31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508554
Commit-Queue: Lily Chen <chlily@chromium.org>
Reviewed-by: Steven Bingler <bingler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823654}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC chrome-fuchsia-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-deterministic-dbg;luci.chromium.try:fuchsia-x64-cast
Tbr: chrome-fuchsia-gardener@grotations.appspotmail.com
Change-Id: I77fb9d627875410fd5f3160137377bd62d7ccdc9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517661Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823653}

BUG=1142989
TEST=twoFragmentsDifferentIncognitoProfiles twoFragmentsSameIncognitoProfile testMultipleIncognitoProfiles

Change-Id: I50ab97c20036466b697b88ca9e78e5d2cf5fed39
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510731
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823652}

This reverts commit 85773e52.

Reason for reland:
 * Fixed data deps
 * _BuildWithChromium() handles missing key

Original change's description:
> Revert "Reland "Android: Use locally-build devil deps only when build_with_chromium=true""
>
> This reverts commit f8b7ec28.
>
> Reason for revert: Causing all builds to fail on android-pixel2-perf failing
>
> Original change's description:
> > Reland "Android: Use locally-build devil deps only when build_with_chromium=true"
> >
> > This reverts commit b47e9c83.
> >
> > Reason for reland: Updated more .pydeps files.
> >
> > Original change's description:
> > > Revert "Android: Use locally-build devil deps only when build_with_chromium=true"
> > >
> > > This reverts commit 49fdeca1.
> > >
> > > Reason for revert: Breaking presubmit due to stale .pydeps file:
> > > android_webview/tools/run_cts.pydeps
> > >
> > > Original change's description:
> > > > Android: Use locally-build devil deps only when build_with_chromium=true
> > > >
> > > > Bug: 1120190
> > > > Change-Id: I763e42a7ae69d14eb61caebd220844b756d6d171
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2480842
> > > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > > Reviewed-by: Ben Pastene <bpastene@chromium.org>
> > > > Cr-Commit-Position: refs/heads/master@{#819489}
> > >
> > > TBR=agrieve@chromium.org,bpastene@chromium.org
> > >
> > > Change-Id: I960ad355283c66951e5931f61e25421c5a5dfdf7
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 1120190
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490857
> > > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#819668}
> >
> > TBR=agrieve # reland
> >
> > Bug: 1120190
> > Change-Id: I8f3e21182e83a3e88da52331d56a8bef76507939
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490558
> > Commit-Queue: Andrew Grieve <agrieve@chromium.org>
> > Reviewed-by: Andrew Grieve <agrieve@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#819810}
>
> TBR=agrieve@chromium.org,bpastene@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug: 1120190, 1141891
> Change-Id: I490f2e8a972b260a81b942e248c0f920af11db46
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2495335
> Reviewed-by: John Chen <johnchen@chromium.org>
> Commit-Queue: John Chen <johnchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#820355}

Bug: 1120190
Bug: 1141891
Change-Id: Ic7a398fcd8cb5f45a03c20acbd4e9c7300442f38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2497153Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823651}

We are still using all CryptAuth histograms to evaluate the migration
to CryptAuth v2 Enrollment and DeviceSync. The migration is complete
on the GmsCore side but still rolling out on Chrome OS and server sides.

Fixed: 1144788
Change-Id: Iaf9cf46686fe1b3298ec6145fdcd2a3c9a5e4224
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517901
Commit-Queue: Josh Nohle <nohle@chromium.org>
Commit-Queue: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Josh Nohle <nohle@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823650}

Add all of the missing filetype icons in nearby-preview. Rework the
existing elements so that the sizing/spacing/colors fit the spec. Add
additional ShareTypes for the new icons.

Bug: 1123942
Change-Id: I49b64014ec22e30386e4438650c3ed8fefe9a1d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2499069Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Commit-Queue: Curt Clemens <cclem@google.com>
Cr-Commit-Position: refs/heads/master@{#823649}

This CL was uploaded by git cl split.

R=mlamouri@chromium.org

Bug: 1142671
Change-Id: I14e20b732dd574ce2bdaba4ce2d885fa40795f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2500703
Auto-Submit: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823648}

No change to logic. This disables some AwSettingsTest test cases which
I've confirmed flake locally. This test suite should now pass on API 28
(Android P).

Bug: 1144352
Bug: 1144935
Bug: 1144938
Bug: 1144945
Test: run_webview_instrumentation_test_apk -f AwSettingsTest.*
Change-Id: If1d9695ff1ceb632019ded16e2fc975e1cd90e01
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515162
Auto-Submit: Nate Fischer <ntfschr@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823647}

This test suite seems to be randomly flaky. The retry mechanism
should let the tests pass even if they have up to 2 failures. Even
though they should be 99% deflaked with one retry, give them two
attempts to be 100% sure of not getting a flaky failure. De-flakying
is more important than any other concern.

Also leaves the 'linux_args' setting in the new test spec in case
we end up using it on Linux as well.

Bug: angleproject:5273
Change-Id: Id3deb84b1c5533f37f3b55b9d9659ddc66358544
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517042Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823646}

This CL adds the following functionality

- Don't proceed to capture if the device is experiencing memory
  pressure (moderate or critical).
- If under memory pressure and playing back
  - Moderate Pressure: release any out-of-viewport bitmaps
  - Critical Pressure: stop showing the preview

Bug: 1144768
Change-Id: I988f84053462807ba9956f26626aa556dca61c2e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514365
Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org>
Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823645}

Empty alias name has been parsable and allowed since the update to
draft-ietf-dnsop-svcb-https-01.

Fixed: 1145098
Bug: 1138620
Change-Id: I980365204c1b997335c781567e62c7fcdf3094e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517627
Commit-Queue: Eric Orth <ericorth@chromium.org>
Commit-Queue: Dan McArdle <dmcardle@chromium.org>
Auto-Submit: Eric Orth <ericorth@chromium.org>
Reviewed-by: Dan McArdle <dmcardle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823644}

This reverts commit fffc75e9.

Reason for revert: New test consistently fails Marshmallow 64-bit Tester bot.
See: https://ci.chromium.org/p/chromium/builders/ci/Marshmallow%2064%20bit%20Tester

Original change's description:
> Suppress TabStrip IPH when bottom sheet shows
>
> This CL hides TabStrip IPH when bottom sheet shows and reshows IPH
> right after bottom sheet hides. This CL is gated by Finch parameter
> "enable_launch_bug_fix" under flag "enable-tab-grid-layout", with gate
> function TabUiFeatureUtilities#isLaunchBugFixEnabled.
>
> Bug: 1135926
> Change-Id: I97c80177b3fabf82aab751c6bf95a1c9b1e27432
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506618
> Reviewed-by: Matthew Jones <mdjones@chromium.org>
> Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#823416}

TBR=mdjones@chromium.org,wychen@chromium.org,yuezhanggg@chromium.org

Change-Id: I942224058529eb3e2eda72ca531f30d61d984724
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1135926
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2518083Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823643}

On Q+ we disabled audio capture as we have no way to selectively disable
it for incognito tabs, but this was missed when upstreaming Q.

Chrome needs QUERY_ALL_PACKAGES permission on R+ to check for any
possible intent handler for URLs. This was added downstream but missed
while upstreaming R support; add it now.

Bug: 948282, 1042023
Change-Id: I4136beddcba0227ef6cfc2073f90d645151ce6bb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507575Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823642}

PlayerIdentifier::operator<() was defined through operator<() on
PlayerIdentifier hashes.  This almost always gives correct results, but
not in general.  Hash collisions are possible (collisions of sums of
hashes are a bit "more possible", see old PlayerIdentifier::Hash()), so
operator<() could return false for two PlayerIdentifier instances that
are actually in a less-than relationship.

The hash function is not really needed anyway, because base::flat_set is
better suited here than std::unordered_set.

Change-Id: I12eec1aa27774d0bd6e10232c35968832fed1ff7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2492440Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Wojciech Dzierżanowski <wdzierzanowski@opera.com>
Cr-Commit-Position: refs/heads/master@{#823641}

Move the Nearby Share feature flags out of //c/b/browser_features and
into the feature-specific location //c/b/nearby_sharing/common/. This
was recommended by fgorski@ in crrev/c/2510351.

Note: Nearby Share is currently only being built for Chrome OS. We
clean up locations that did not reflect this.

Fixed: 1144259
Change-Id: I5c5483e35a040f244df4b88c29e992106f869c55
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515045Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Commit-Queue: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823640}

Adds getter methods to MetricsServiceClient that specify limits on local
log storage. An embedder can override these new methods to configure
limits based on their use case, rather than relying on the defaults
previously hardcoded into MetricsLogStore. The default values returned
by the new methods match the old hardcoded values to maintain original
functionality.

Bug: None
Test: metrics_unittests
Change-Id: I86f61d2cd1a0b41ae6e64866dcf0921b9a1ff930
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2505741
Commit-Queue: Akira Baruah <akirabaruah@google.com>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823639}

UpdatePriority was exposed in v8-platform. This CL
override the method to delegate to base implementation.

Change-Id: I87c30acc7f692d2d9eb9cfb6339a26077cc4c876
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517701Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Andreas Haas <ahaas@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823638}

Bug: b/156258540
Change-Id: I7fef896b35c3141f4377b90eda34c8925c008c9e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506242
Commit-Queue: Yicheng Li <yichengli@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823637}

Bug: 1115463
Change-Id: I29b0658596cd5c9c10ea2832435cca7a873f6ee4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510914Reviewed-by: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Justin DeWitt <dewittj@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823636}

https://chromium.googlesource.com/angle/angle.git/+log/6a4c9bbd5185..ed90c9917b1b

2020-11-03 stuartmorgan@google.com Fix copyright line format

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC courtneygo@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: courtneygo@google.com
Change-Id: Ic09e5a5b23fd730ee7c8f4f1f705a349584ed073
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517662Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823635}

This adds a suite of new tests that verify capture on hide and display
on startup. These tests don't override any test only behavior and fully
rely on the prod behavior.

Bug: 1143722
Change-Id: Iccde9b097b8cd0217bd74588599c66063c7cec21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514725
Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org>
Reviewed-by: Calder Kitagawa <ckitagawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823634}

Bug: 1014639
Change-Id: I44ca1a9b79bcb9adf079ca5a7c270dbeb0657001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2515041Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823633}

Bug: 1122182, 1144538
Change-Id: Ie7e293ba1eeeeeb41d694050c419878cf3420a0c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517700Reviewed-by: Peter Wen <wnwen@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823632}

WebViewImpl and WebFrameWidgetImpl have typically implemented very
similar things. The goal is to remove WebViewFrameWidget and have
a single frame widget class move more implementation into the base
class.

BUG=1097816

Change-Id: I8bc5c5a2b869cd99b693c8431e81eb127848596e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517704Reviewed-by: danakj <danakj@chromium.org>
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823631}

rmhasan@ will be the sole reviewer for CL's uploaded by the
create-weblayer-skew-tests builder until we finalize the frequency
of CL's being uploaded.

Bug: 1041619
Change-Id: I47c3e0b7d99ded6ffca639decf143b0f1711201a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512520Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Rakib Hasan <rmhasan@google.com>
Cr-Commit-Position: refs/heads/master@{#823630}

The ASAN+LSAN config was using 10 shards, each of which was taking
about 15 seconds. This seems unnecessary.

Bug: angleproject:5124
Change-Id: I968c3b31cb0464096052fbd4614b2f7efde2c36a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517043Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823629}

This will make the template logic reusable by other components in PM.

Bug: 1144025
Change-Id: I378d5626b5f1487dc792e6db14668fc6588448f2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2462376Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Reviewed-by: Patrick Monette <pmonette@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823628}

The downstream iOS bots import a gn file from $root_build_dir/args.gn
that contains nested scopes. Support to parse the file has been added
to //build/gn_helpers.py with https://crrev.com/c/2513217.

The next step on the bot is pretty printing the data parsed, which
fails as nested scopes are converted to nested dictionaries. This
CL adds support to pretty print those.

Bug: 1144711
Change-Id: I3130d493c6385f2016d91245e8a5f12e710495cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2517679
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Auto-Submit: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823627}

The cl in devtools-frontend: https://crrev.com/c/2514438

Bug: chromium:1143648
Change-Id: Ia56777df183bd9ba3cecbe41285b4c274595d7d6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513219Reviewed-by: Mathias Bynens <mathias@chromium.org>
Commit-Queue: Jan Scheffler <janscheffler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823626}

This patch re-uses the existing SmsVerificationReceiver backend but
replaces its logic to use the new browser code API [1].


Summary of changes:
 - Use the new SmsCodeBrowserClient
 - Connect both timeout/cancel to caller
 - Properly handle cases where browser code may not be available
    1. Need user permission grant          -> ask for permission
    2. User has previously denied to grant -> cancel request
    3. API not available                   -> TODO in follow up
 - Add tests to check for permission logic and new bindings

This patch depends on a new GMS phone auth library which was added as a
dependency in [2].

[1] https://developers.google.com/android/reference/com/google/android/gms/auth/api/phone/SmsCodeBrowserClient
[2] https://chromium-review.googlesource.com/c/chromium/src/+/2485192

Test: content_unittests --gtest_filter=SmsProviderGmsVerificationTest.*
Bug:1141022

Change-Id: I56c59c92e6e368c906ed7151558de72ad3892253
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2490248Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Majid Valipour <majidvp@chromium.org>
Reviewed-by: Yi Gu <yigu@chromium.org>
Commit-Queue: Majid Valipour <majidvp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823625}

The switch no longer exists.

Bug: b:172071699
Change-Id: Ic6bcf63de7acb1847d40fa5d5caab932e2d90ae5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514761Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Matthew Wang <matthewmwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823624}

When multiples displays are removed at the same time, commit a disable
modeset of all them together instead of each separately.
This should prevent unplugged MST connectors from being in zombie mode.

BUG=b/172069469, b/169386252
TEST=unplug and replug 2 connectors on MST hub, ScreenManagerTest.CheckMultipleControllersAfterBeingRemoved

Change-Id: If24f9016462b9c69633148202641f7ba6bae9114
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512550
Commit-Queue: Mark Yacoub <markyacoub@google.com>
Reviewed-by: Daniel Nicoara <dnicoara@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823623}