- 26 Sep, 2020 8 commits
-
-
nuwanda authored
The script runs TBMv3 metric and the corresponding TBMv2 metric on given traces and compare the results. If the metrics are equal than the newly added TBMv3 metric is the same as the old TBMv2 metric. If the results are different the script will output trace files and json files (results of run_metric) so the user is able to debug analyse them. Example usage: tools/perf/validate_tbmv3_metric --tbmv3-name=uma_metrics --tbmv3-histogram=graphics_smoothness_percent_dropped_frames_compositor_thread_universal --tbmv2-name umaMetric --tbmv2-histogram=Graphics.Smoothness.PercentDroppedFrames.CompositorThread.Universal Now a path to a file with trace link is required. We plan to automate the process of getting trace links in the future. Metric units are also ignored in this change. We plan to integrate units support later along with other fancy statistics about metric values. For more information, see https://docs.google.com/document/d/1wI1gk5X2-eQk9-NLHSK_EgmVs-doyyodz0XtP7Pd15M/edit?usp=sharing Change-Id: I4ca068357a9a0c0f9a5cd5267c64aa53acfe8513 Bug: 1128919 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413492Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
Deep Roy <dproy@chromium.org> Reviewed-by:
Mikhail Khokhlov <khokhlov@google.com> Commit-Queue: Julia Semavina <nuwanda@google.com> Cr-Commit-Position: refs/heads/master@{#810851}
-
Ben Pastene authored
Bug: 1132373 Change-Id: I2490fcea413a338cd8ecebc19c4ab25680a53e7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432127Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#810850}
-
Brian Malcolm authored
This is the UI name of the entity that manages device's domain, which caneither be a domain name (foo.com), or the admin's email address (user@foo.com) BUG=chromium:1081272 Change-Id: I5d1adcf4182bf3beb3dfc05980106efbc88af53b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431457Reviewed-by:
Sergey Poromov <poromov@chromium.org> Commit-Queue: Brian Malcolm <bmalcolm@chromium.org> Cr-Commit-Position: refs/heads/master@{#810849}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/faa49d773432..76b5fbb58db7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jam@google.com,fdoray@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1084659,chromium:1093383,chromium:1099917,chromium:1099982,chromium:1105096,chromium:1116130,chromium:1128599,chromium:1128653,chromium:1128747,chromium:1130677,chromium:1130962,chromium:1131230,chromium:912681 Tbr: jam@google.com,fdoray@google.com Change-Id: I4fe3ba9beff57593fa125e390802a546b97e8819 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432786Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810848}
-
Garrett Beaty authored
Change-Id: I9a01eb868ece2231f3219903ae6201b9c3b6b924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432307 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Erik Staab <estaab@chromium.org> Cr-Commit-Position: refs/heads/master@{#810847}
-
Gayane Petrosyan authored
Bug: 1102382 Change-Id: Idd1d928eb8c2885f3610d68a771798fd3b22e00e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432807Reviewed-by:
Kyle Milka <kmilka@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#810846}
-
Alex Moshchuk authored
Bug: 1125658, 621724 Change-Id: If32ea623620989e40fc9a814d0a97813a2067f56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424347 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Auto-Submit: Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#810845}
-
Yusuke Sato authored
The latest arcvm-adbd.conf requires ARCVM_CID environment variable, but the variable can be set only after ARCVM is started. This CL changes the timing of the arcvm-adbd job startup. BUG=chromium:1126289 TEST=components_unittests Change-Id: If53bec0394626cc0f2d585635a3b45348bc49113 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429847Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Willie Koomson <wvk@google.com> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#810844}
-
- 25 Sep, 2020 32 commits
-
-
Tommy Li authored
The dot menu was supposed to be invisible for enterprise policy injected search engines. This was regressed in this CL: https://chromium-review.googlesource.com/c/chromium/src/+/564204/ This CL restores it and adds a test. Bug: 1123909 Change-Id: Id38a2194764b3c1fa7ffc1bec9d4ef2c8d890037 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427290Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#810843}
-
cfredric authored
Bug: 1129506 Change-Id: I108aa17dc23fa407c4f3b9d6b0ed6a7ef18ce7ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416881 Commit-Queue: Chris Fredrickson <cfredric@google.com> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Jonathan Metzman <metzman@chromium.org> Reviewed-by:
Dan McArdle <dmcardle@chromium.org> Reviewed-by:
Steven Bingler <bingler@chromium.org> Cr-Commit-Position: refs/heads/master@{#810842}
-
Curt Clemens authored
Add a new pod button to the ash system tray for toggling the high visibility mode of Nearby Share. l10n strings in a followup CL. Bug: b/154866703 Test: unit_tests, ash_unittests Change-Id: I2c3be0bcf5b593c58f030e63b69d499de211f3c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405441 Commit-Queue: Curt Clemens <cclem@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#810841}
-
wutao authored
Current implementation will not return callback until succeed. This patch adds a limit to the max number of retries. This patch also changes the backoff logic to use backoff entry. Bug: b/169250512 Test: added new tests. Change-Id: Id421a152dc7fe6ce3f365086d16c6e611b4fc001 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427082 Commit-Queue: Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#810840}
-
Kimiyuki Onaka authored
ArcCrashCollector calls DumpNativeCrash with file names and FDs when a new crash dump appears. DumpNativeCrash is responsible to call crash_reporter. FDs are used for passing the file contents. BUG=b:136697350 TEST=tast run my_crbook arc.NativeCrash.\* arc.AppCrash.\* Change-Id: I5017d388eb3182454023b354c3714bbecc664354 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379331 Commit-Queue: Kimiyuki Onaka <kimiyuki@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Miriam Zimmerman <mutexlox@chromium.org> Cr-Commit-Position: refs/heads/master@{#810839}
-
Mehran Mahmoudi authored
This CL introduces the new PaintPreviewWindowAndroidHelper class. This class stores activity-specific variables in PaintPreviewHelper. Using the BrowserControlsManager class, it makes the top toolbar persistent when a Paint Preview is shown. This CL also fixes a bug where TabbedPaintPreviewPlayer#onDismiss was never called. Bug: 1131497 Change-Id: I3caf7017f601536ba03c1e1c60c9b024917f6063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425433 Commit-Queue: Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#810838}
-
Evan Stade authored
ApplicationStatus doesn't work outside of //chrome (crbug.com/470582), so this code must be deferred to the embedder. A WebContents parameter is included because it's necessary for WebLayer, even though Chrome doesn't use it. The MediaRouteDialogManager interface is also removed as it only has a single implementor, BaseMediaRouteDialogManager. Bug: 1057100 Change-Id: Ifab92742162cf64e42c75eacfdac6b014940b3df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430586 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#810837}
-
Michael Checo authored
- Encapsulates a data point in a diagnostics card. Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I0cb465fdd62ac2fafa5d17436e6486f5f0a2bf5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427075 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810836}
-
Mike Wittman authored
First in a series factoring the ThreadProfiler platform specific configuration state from the code that takes action on the state. Defines an IsSupported function that is true if the profiler is supported on the chrome branding and channel for the platform. The end goal is to reduce the configuration complexity, to support enabling per-thread on Android. Bug: 1129939 Change-Id: Ibbd6f4725804b40ac77e15aaa3bd15ad76a0e7b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425165Reviewed-by:
ssid <ssid@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#810835}
-
Chris Palmer authored
On x86 as well as on ARM. It breaks Java test `JavaBridgeCoercionTest.testPassNull`. There is probably an underlying bug that we need to fix. Bug: 1131993, 977230 Change-Id: Ie579516a06d13577fcb4a61fa515a2d873bfcd15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429233Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
-
Dominique Fauteux-Chapleau authored
This should not change deep scanning behaviour with Connectors. Bug: 1103390 Change-Id: I8f45972d7649eae31d7c3e9024f925c059ad68d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427427Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#810833}
-
Michael Chang authored
Rsync was failling with permission denied (13) when trying to send_file for some tests. The belief is that it's happening because the file that was trying to be sent is lacking read permissions for all. Bug: 1126533 Change-Id: Iaf02d8bb71c8a571230cab6fc5f873d8227d7f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431781 Commit-Queue: Michael Chang <donchan@microsoft.com> Reviewed-by:
-
Jeffrey Cohen authored
Bug: 1024586 Change-Id: I1b3e2e7adce8d36a818e9619b4f28eb4b0fcd88c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427134Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810831}
-
Meilin Wang authored
This CL moves the existing |PhoneStatusView| out of the |PhoneHubView| and adds it as a separate child view of the bubble, so that it can always show on top of UIs and display available phone information and the settings icon. Misc: remove unnecessary header files. Screenshot: https://screenshot.googleplex.com/6DXqin6MZPcTVVj.png BUG=1106937,1126208 Change-Id: I321d0511874cfa95dcbb8276fedf41b14e0f684b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429390Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Meilin Wang <meilinw@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#810830}
-
ssid authored
pthread_getattr_np implementation in bionic throws sigabrt on failure to read proc/ file. Implement this function to avoid crashes. BUG=1129941 Change-Id: I54b94a609201a998924aaa8c8e77051f85acf377 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425744 Commit-Queue: ssid <ssid@chromium.org> Reviewed-by:
Mike Wittman <wittman@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#810829}
-
Koji Ishii authored
This patch invalidates ink overflow cache for text when |NeedsRecomputeVisualOverflow|. Computing text ink overflow is expensive, especially for i18n fonts on Windows. Bug: 1130856 Change-Id: I73e14af84e1c261fd95acf5ceb1bade1c46d0095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424365Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#810828}
-
Samuel Huang authored
When creating symbol diffs, mismatches in alias counts and summing fractional padding PSS values can lead to DiffSymbols with non-integer padding values. However, numeric values in .sizediff files should be integers. This CL implements a simple fix: Round paddings to integer when creating DiffSymbols. The resulting inaccuracy would be in the order of bytes, and therefore negligible. Bug: 1132394 Change-Id: Iba9acb0a94de6890aec01ac6c9ee450fb9d69dd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432668 Commit-Queue: Samuel Huang <huangs@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#810827}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/fe40be6924e2..df3ae5e6f975 2020-09-25 treehugger-gerrit@google.com Merge "flamegraph: Compress text if it almost fits" 2020-09-25 hjd@google.com Merge "flamegraph: Reduce font size and improve rollover rendering" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Id218baa5862af6d7010a0bb7bfe3ae4073434078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432273Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810826}
-
Alex Newcomer authored
Speculative fix. We now observe a folders item list on creation, but it seems we forgot to stop observing in one case. When the scoped observer list destructs, it tries to stop observing things that no longer exist. This should fix the crash we are seeing in M-86. Bug: 1130901 Change-Id: I078e570a9beb67fda7efd48ba40ec52bda47aab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429524Reviewed-by:
-
rbpotter authored
- Remove ampersand symbol (&) from IDS_EDIT string before adding to the PDF viewer UI. - Don't toggle annotation mode if dialog is not confirmed - Strings - remove ending '.' per UX feedback Bug: 1048876 Change-Id: Ie8afacd21b10595e6c1ef8878ca5091027042224 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429976 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#810824}
-
Justin Cohen authored
Webkit indirectly forces a user gesture on the final restore navigations because _crFinishSessionRestoration is called from native code via ExecuteJavaScript. This has unintended consequences (such as triggering universal app links). Instead, use setInterval() to discard the gesture after the first interval callback. NOTRY=True # The chromium_presubmit bot seems to not be running atm, skipping. NOPRESUBMIT=True Bug: 1129875, 1132099 Change-Id: I4ee26947ac383d35b7c2175c8cc60ee48dd11cf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432053 Commit-Queue: Justin Cohen <justincohen@chromium.org> Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#810823}
-
Chris Thompson authored
This adds metrics for the SCT auditing cache and SCT auditing reports: - Whether a new report is deduplicated against an existing report in the cache, to track efficiency gains of deduplication and for tweaking the cache size. - Whether a report is sampled for sending or not, to track how many reports we discard due to sampling. - The size of a report before it is sent (in bytes), to track how much bandwidth is consumed by reports. - Whether sending a report to the reporting URI succeeded or not, to track error rates. - The high-water mark of the cache size over each browser session (in # of reports stored), used to track if max cache size is reasonable. This also adds unit tests covering these histograms. Bug: 1107897 Change-Id: If8aa73848fcf5ef7aceca27b4e1ce3e04d75851a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421870 Commit-Queue: Emily Stark <estark@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810822}
-
Findit authored
This reverts commit 63eccefc. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 810784 as the culprit for failures in the build cycles as shown on: https://analysis.chromium.org/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzYzZWNjZWZjNzk5YmNjNTI0NDRjNzgxMjdkYWQzZGI0ZGU2NjdjMTQM Sample Failed Build: https://ci.chromium.org/b/8868150038637383760 Sample Failed Step: compile Original change's description: > Dynamically load libwayland-client and libwayland-egl on Linux > > This is needed since some distros do not have libwayland-client > available. If systems don't have libwayland-client, they definitely > won't have a wayland server either, so it doesn't make sense to > statically link libwayland-client, which won't make wayland work and > will only waste binary size. Instead, this CL dynamically loads > libwayland-client if available. > > Also, this CL includes some misc fixes to fix the 'ninja all' build > for Linux/ozone. > > R=msisov > > Bug: 1126894 > Change-Id: Ice0fd0b113f5d804cd05089bfad54168d94c53e4 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416941 > Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com> > Cr-Commit-Position: refs/heads/master@{#810784} Change-Id: Ib8d9f5bdb0091800595af28d15f9d0dc529dc8d8 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1126894 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432924 Cr-Commit-Position: refs/heads/master@{#810821}
-
Sonny Sasaka authored
To improve user experience, this sorts the Bluetooth device list in settings page so that the connected devices are shown on top followed by non-connected devices. BUG=b:168257187 Change-Id: I60fcb820d6a6409460970273aefb1824c7354ebf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419379 Commit-Queue: Sonny Sasaka <sonnysasaka@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
-
Gang Wu authored
Add chip view to downloads/bookmarks menu items. This CL introduces ChipViewMenuItemViewBinder as a new CustomViewBinder, it will have a chip view at the end if the feature is enabled. This CL also moved AppMenuAdapter#OnClickHandler out of AppMenuAdapter, and renamed to AppMenuClickHandler, because ChipViewMenuItemViewBinder is the first CustomViewBinder has two items to be clicked, and the click handler needs to handle clicking items individually. Bug:1130663 Change-Id: Ia9c0a0350c6e912ee6519d30a07cba2f74a1f72a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2420256Reviewed-by:
Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#810819}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1748c6a3b8c8..aeae3a58e3da 2020-09-25 johnstiles@google.com Add golden outputs for the Metal backend. 2020-09-25 robertphillips@google.com Fix creation of gpu resources in GrThreadSafeViewCache tests 2020-09-25 johnstiles@google.com Migrate most SkSL tests currently in /glsl/ to /shared/. 2020-09-25 csmartdalton@google.com Add a "_volatile" suffix to AllPathsVolatile configs 2020-09-25 johnstiles@google.com Clean up SkSL test compilation in preparation for Metal support. 2020-09-25 egdaniel@google.com Fix checks of GR_TEST_UTILS. 2020-09-25 johnstiles@google.com Traverse FieldAccess' base expression in visitExpression. 2020-09-25 jsimmons@google.com Handle surrogates in SkUTF::UTF16ToUTF8 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC csmartdalton@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: chromium:1108408 Tbr: csmartdalton@google.com Change-Id: I349a6ac1af18390c911dcde5a957fb8ed201a20e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432585Reviewed-by:
-
Austin Eng authored
Bug: 1130440 Change-Id: Ia34251245d22c444cacd767fb0d0c0165d1f0221 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432274Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#810817}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 17915b1a. With Chromium commits locally applied on WPT: 8f02a380 "Use allow attribute for delegation in web serial WPT" c1a7d15a "[LayoutNG] Multicol baseline propagation support." f30daabb "[COOP] access reporting: test with redirects." 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: If6ec54879c69e8abe466f21785d259dc9f2e248b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431588Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810816}
-
Tibor Goldschwendt authored
This CL * Adds ShoppingTasksHandler mojo interface that provides the current shopping tasks and is exposed to the NTP. * Adds JS boilerplate that will later become the shopping tasks module. As a first step this JS code queries the current shopping task from the new mojo interface above. * Removes ShoppingTasksData and uses the new ShoppingTask mojo struct instead. # For //chrome/browser/resources/BUILD.gn deps change. TBR=aee@chromium.org Bug: 1130855 Change-Id: Id2103d9418c09787de5f8c98f5949b6c7b1eb4ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429968Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810815}
-
Sebastien Lalancette authored
WKWebView was returning a blank PDF when requesting a PDF to get generated for a loaded PDF (during full page screenshot scenario). Fix: Disable PDF generation on non-HTML Web states. Bug: 1131566 Change-Id: Ia5ac045b8ec1335266e98ef8cf7eb00a8c62f0d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431553 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
-
https://crbug.com/skia/10744Fredrik Söderqvist authored
A change fixes/improves the behavior of SkPictureImageFilter, that will require some adjustments/updates to test results. Change: https://skia-review.googlesource.com/c/skia/+/319616 Bug: skia:10744 Change-Id: Id5f9376edd3c74360c1a915a624752a98554c742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431432 Auto-Submit: Fredrik Söderquist <fs@opera.com> Reviewed-by:
vmpstr <vmpstr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#810813}
-
Gavin Williams authored
In guest mode print jobs did not appear in print management app. This prevented users being able to cancel in-progress jobs. Overriding GetBrowserContextToUse allows using an OTR profile so that jobs appear in the app. Added function BuildInstanceFor for creating PrintManagement service in tests. Bug: 1128690 Change-Id: I837afd57711505e7bf8ab93f9aa38ed16dc5d3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2412222 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
-
