GitLab

A DOMWindowProperty object should not be kept alive if it is only
referenced from a LocalDOMWindow's set of registered DOMWindowProperty
objects. Adjust LocalDOMWindow's DOMObjectProperty references to be 
weak for Oilpan also.

In most cases, DOMWindowProperty objects will remain alive for at least
as long as their associated LocalDOMWindow, but this cannot be assumed.
The added test checks for that wrt DOMSelection objects created from
shadow roots.

Along with adjusting the weakness of these references, simplify
how LocalDOMWindow unregisters its DOMWindowProperty objects. That is,
no longer have the instances unregister themselves, but let the
LocalDOMWindow remove them all after having notified them of impending
destruction.

R=haraken,ager
BUG=413316

Review URL: https://codereview.chromium.org/569643002

git-svn-id: svn://svn.chromium.org/blink/trunk@181970 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/572623002

git-svn-id: svn://svn.chromium.org/blink/trunk@181969 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=414163
TBR=loislo, amikhaylova@google.com

Review URL: https://codereview.chromium.org/568363003

git-svn-id: svn://svn.chromium.org/blink/trunk@181968 bbb929c8-8fbe-4397-9dbb-9b2b20218538

* Get rid of unused methods
* Get rid of code duplication
* Ease return values: Classes with a static string field are replaced with a string

BUG=

Review URL: https://codereview.chromium.org/558593003

git-svn-id: svn://svn.chromium.org/blink/trunk@181967 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The patch restores per-word wrapping of console messages. This was
regressed in r180833.

BUG=412515
R=pfeldman, vsevik

Review URL: https://codereview.chromium.org/542383004

git-svn-id: svn://svn.chromium.org/blink/trunk@181965 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=414163
TBR= aandrey@chromium.org, kouhei@chromium.org, hajimehoshi@chromium.org

Review URL: https://codereview.chromium.org/573633002

git-svn-id: svn://svn.chromium.org/blink/trunk@181964 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Currently, if you click on the selector container, there are two
handlers that conflict with each other. The patch fixes
the conflict.

BUG=413894
R=vsevik, apavlov@chromium.org

Review URL: https://codereview.chromium.org/571653002

git-svn-id: svn://svn.chromium.org/blink/trunk@181963 bbb929c8-8fbe-4397-9dbb-9b2b20218538

In r181420 we started pulling the list of virtual test suites to run
from LayoutTests/VirtualTestSuites (a new file). The browser_test ports
do not pull their tests from that directory, and need a different list
of suites, but I forgot to override the port.virtual_test_suites() call
in their implementations.

The browser_test ports don't currently need or have any virtual test suites,
so this patch implements returning an empty list and adds tests to ensure
that we would catch this regression if it happened again.

We also rework the browser_test_unittest.py tests to eliminate a bunch of duplication and make it clearer that the tests are shared and testing the same behavior.

TBR=thestig@chromium.org
BUG=413986

Review URL: https://codereview.chromium.org/569913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181962 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=160207
R=vsevik, yurys@chromium.org

Review URL: https://codereview.chromium.org/548323002

git-svn-id: svn://svn.chromium.org/blink/trunk@181961 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Fix to keep the selection of the text field in input element after setSelectionRange is called by dom events related to mouse

The problem is that the selection is cleared when handling mouse release.
The selection should be kept if the selection is set by setSelectionRange during handling mouse event.

BUG=32865
R=yosin@chromium.org
R=rbyers@chromium.org
TEST=LayoutTests/fast/forms/setrangetext-within-events.html

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181490

Review URL: https://codereview.chromium.org/507533002

git-svn-id: svn://svn.chromium.org/blink/trunk@181959 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Revert "Remove resetScrollbars" (patchset #1 id:1 of https://codereview.chromium.org/534103003/)

Reason for revert:
This was reverted speculatively and was not the cause of the failure.

Original issue's description:
> Revert "Remove resetScrollbars"
> 
> This reverts commit ebcbf43b12652bf96a1d1d94d8dbb5bdfd363ce6.
> 
> Speculative revert.
> 
> NOTRY=True
> BUG=409708
> TBR=skobes@chromium.org
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181275

TBR=
NOTREECHECKS=true
NOTRY=true
BUG=409708

Review URL: https://codereview.chromium.org/568303002

git-svn-id: svn://svn.chromium.org/blink/trunk@181958 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This reverts commit 0ad77c5152a930f08e04a2db05ad5331c711333f.

It breaks compilation on Linux GN (dbg) which is tree closer.
http://build.chromium.org/p/chromium.linux/builders/Linux%20GN%20(dbg)

BUG=312586
TBR= dpranke@chromium.org, haraken@chromium.org, jochen@chromium.org

Review URL: https://codereview.chromium.org/557543004

git-svn-id: svn://svn.chromium.org/blink/trunk@181957 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Blink on github is not supported, Blink lives in:
chromium.googlesource.com/chromium/blink/+/master.

So these scripts are from an era where Chromium was integrating WebKit,
but since we forked and created Blink, they don't make much sense
anymore.

BUG=None
TEST=None
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/563983002

git-svn-id: svn://svn.chromium.org/blink/trunk@181956 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Gardening: Mark fast/events/touch/gesture/gesture-tap-frame-scrollbar.html as failing for all platforms

BUG=414034
TBR= dpranke@chromium.org, rbyers@chromium.org, esprehn@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/558123003

git-svn-id: svn://svn.chromium.org/blink/trunk@181955 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jochen@chromium.org

Review URL: https://codereview.chromium.org/569873002

git-svn-id: svn://svn.chromium.org/blink/trunk@181953 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This completes the implementation of ServiceWorkerContainer#getRegistration().

Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/#navigator-service-worker-getRegistration

[1/3] https://codereview.chromium.org/553983010/
[2/3] https://codereview.chromium.org/535753002/

BUG=404951
TEST=LayoutTests/http/tests/serviceworker/getregistration.html,webkit_unit_tests

Review URL: https://codereview.chromium.org/540823003

git-svn-id: svn://svn.chromium.org/blink/trunk@181952 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=413987

Review URL: https://codereview.chromium.org/573473002

git-svn-id: svn://svn.chromium.org/blink/trunk@181951 bbb929c8-8fbe-4397-9dbb-9b2b20218538

As discussed on blink-dev[1].

[1] https://groups.google.com/a/chromium.org/d/topic/blink-dev/gfifgxHdPXU/discussion

BUG=396369

Review URL: https://codereview.chromium.org/568253002

git-svn-id: svn://svn.chromium.org/blink/trunk@181950 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change is the third in a three-sided set of changes, and lets
WebSourceBufferClient be the sole trigger for Blink adding a
SourceBuffer into SourceBuffer.activeSourceBuffers.

R=acolwell@chromium.org,philipj@opera.com,tkent@chromium.org
TEST=No mediasource layout test regression
BUG=249428, 397243

Review URL: https://codereview.chromium.org/562503002

git-svn-id: svn://svn.chromium.org/blink/trunk@181949 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Now that most invalidations have moved to after layout,
these ASSERTs should not trigger. If they do, we should
catch them and fix the callers.

This change doesn't touch RenderObject's
invalidatePaintForWholeRenderer as it is called when
removing a renderer, which can be on an unrooted tree.

BUG=368140

Review URL: https://codereview.chromium.org/571643002

git-svn-id: svn://svn.chromium.org/blink/trunk@181948 bbb929c8-8fbe-4397-9dbb-9b2b20218538

isSampleRateRangeGood() -> isValidAudioBufferSampleRate()
minAllowedSampleRate() -> minAudioBufferSampleRate()
maxAllowedSampleRate() -> maxAudioBufferSampleRate()

These functions have been moved to AudioUtilities.
Some const values were used in some files sporadically instead of them.
Make these functions using every places.

BUG=413244

Review URL: https://codereview.chromium.org/565643003

git-svn-id: svn://svn.chromium.org/blink/trunk@181947 bbb929c8-8fbe-4397-9dbb-9b2b20218538

To support using V8RecursionScope in other places, drop the dependency on ExecutionContext in favor of just an v8::Isolate. This requires moving IDBPendingTransactionMonitor from a supplement on the context to per-isolate data.

Review URL: https://codereview.chromium.org/429453010

git-svn-id: svn://svn.chromium.org/blink/trunk@181946 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch is the blink side. The chromium side is handled on issue #180153010

It doesn't revert functions anymore in blink. Instead, it sets the direction parameter to WebAnimation, which will in turn pass it to the compositor.

BUG=348071

Review URL: https://codereview.chromium.org/225183014

git-svn-id: svn://svn.chromium.org/blink/trunk@181945 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=409593

Review URL: https://codereview.chromium.org/568903002

git-svn-id: svn://svn.chromium.org/blink/trunk@181943 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Prefer to keep the border-radius for cssText output if it is
explictly used.

Matches FireFox behavior.

BUG=407012

Review URL: https://codereview.chromium.org/547043002

git-svn-id: svn://svn.chromium.org/blink/trunk@181942 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore.

Review URL: https://codereview.chromium.org/564193002

git-svn-id: svn://svn.chromium.org/blink/trunk@181940 bbb929c8-8fbe-4397-9dbb-9b2b20218538

There is a bug that a script will incorrectly not run when a nonce is
specified if 'unsafe-inline' is also specified in the policy and there's
a *second* policy that only specifies 'unsafe-inline'. This is due to a
cascading failure where the initial isAllowedByAllWithNonce check fails
because the second policy doesn't have a nonce, while the later
allowInlineScript check fails because the first policy's nonce
invalidates the 'unsafe-inline'.

This CL allows allowScriptNonce (and allowScriptHash) to pass if
'unsafe-inline' is present (and no hash or nonce is present). This also
adds tests to verify.

BUG=413482

Review URL: https://codereview.chromium.org/568583003

git-svn-id: svn://svn.chromium.org/blink/trunk@181939 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Move the user agent styles sheets to blink_resources.grd (Part 3) (patchset #10 id:260001 of https://codereview.chromium.org/438843004/)

Reason for revert:
Speculative revert for breaking quite a few browser_tests and content_browsertests across multiple platforms:
https://build.chromium.org/p/chromium.webkit/builders/Mac10.6%20Tests/builds/26427
http://build.chromium.org/p/chromium.webkit/builders/Mac10.8%20Tests/builds/9662
http://build.chromium.org/p/chromium.webkit/builders/Win7%20Tests/builds/5566


Original issue's description:
> Move the user agent styles sheets to blink_resources.grd (Part 3)
> 
> Blink should make use of blink_resources.grd for the inline resources of user agent stylesheets.
> This removes the dependency upon using make-file-arrays.py which embeds these resources as strings. 
> 
> Also the .rodata section of libblink_web (in component build mode) is reduced by ~33kb.
> 
> Part 1: https://codereview.chromium.org/436843004/
> Part 2: https://codereview.chromium.org/422023008
> Part 2 Unit Test support: https://codereview.chromium.org/456413002/
> 
> BUG=312586
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181917

TBR=eseidel@chromium.org,abarth@chromium.org,jochen@chromium.org,vivekg@chromium.org,vivek.vg@samsung.com
NOTREECHECKS=true
NOTRY=true
BUG=312586

Review URL: https://codereview.chromium.org/567073004

git-svn-id: svn://svn.chromium.org/blink/trunk@181938 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch takes care of the left out places where 
newly created ImageBuffer is not validated.

BUG= 248420

Review URL: https://codereview.chromium.org/562543004

git-svn-id: svn://svn.chromium.org/blink/trunk@181936 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Today there are three different ways we hit-test for scrollbars:
1) for frame scrollbars, explicitly call FrameView::scrollbarAtPoint
2) for subframe scrollbars, use HitTestRequest::AllowFrameScrollbars
3) for DIV scrollbars, rely just on the normal HitTestResult

There's apparently no good reason not to be consistent here.  This patch
updates hit-testing to always consider all 3 types of scrollbars, and
removes the AllowFrameScrollbars mode entirely.

This also fixes a bug where we weren't properly hit-testing for
subframe scrollbars on tap, and so not sending mouse events through
to the frame behind (as we do for touch).

I also split ScrollView::scrollbarAtPoint into two variants for window
and view co-ordinates (since we weren't being consistent previously,
passing view co-ordinates as if they were window co-ordinates in
RenderPart::nodeAtPoint.

BUG=410661

Review URL: https://codereview.chromium.org/527263002

git-svn-id: svn://svn.chromium.org/blink/trunk@181935 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This adds the following behavior:
1. If input is a Request object, run these substeps:
  1. If input's used flag is set, throw a TypeError.
  2. Set input's used flag.

Outlined in this change:
https://github.com/whatwg/fetch/commit/a898f9a2941350aa625aa79b24673628ac2b2a8e#diff-1feda49b40370635faef8b655f144f64R2681

Spec:
http://fetch.spec.whatwg.org/#dom-request

BUG=413072

Review URL: https://codereview.chromium.org/562413003

git-svn-id: svn://svn.chromium.org/blink/trunk@181934 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This patch add a new trace event InspectorLayerInvalidationTrackingEvent for invalidation reason tracking. The event tracks when compositor invalidates the whole RenderLayer including its descendents, along with its reason.

BUG=410701

Review URL: https://codereview.chromium.org/565793003

git-svn-id: svn://svn.chromium.org/blink/trunk@181933 bbb929c8-8fbe-4397-9dbb-9b2b20218538

WebRemoteFrameClient only inherits from WebFrameClient as a temporary measure, separate them.

willCheckAndDispatchMessageEvent() is used to give the embedder a chance to postMessage() externally. Move it from FrameLoaderClient to FrameClient and implement it in RemoteFrame and WebRemoteFrameImpl.

This is step 3 of 3 in getting WebRemoteFrameClient up and running.


BUG=411066

Review URL: https://codereview.chromium.org/543913002

git-svn-id: svn://svn.chromium.org/blink/trunk@181932 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/564973002

git-svn-id: svn://svn.chromium.org/blink/trunk@181930 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Most of the code wasn't touching |this| or the renderers but
they were not marked as const.

This is needed for another change that I have.

Review URL: https://codereview.chromium.org/566973002

git-svn-id: svn://svn.chromium.org/blink/trunk@181929 bbb929c8-8fbe-4397-9dbb-9b2b20218538

TBR=jianli@chromium.org
BUG=413454

Review URL: https://codereview.chromium.org/544173005

git-svn-id: svn://svn.chromium.org/blink/trunk@181928 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://src.chromium.org/viewvc/blink?view=revision&revision=181873

BUG=412516
TBR=wangxianzhu@chromium.org

Review URL: https://codereview.chromium.org/564183002

git-svn-id: svn://svn.chromium.org/blink/trunk@181927 bbb929c8-8fbe-4397-9dbb-9b2b20218538

After https://codereview.chromium.org/476113004 CC depends on the
tree structure of scroll/clip layers to determine the viewport size, so
detaching them breaks fullscreen mode.  Switch to the other
approach of changing the scroll layer bounds.

BUG=410452

Review URL: https://codereview.chromium.org/558813003

git-svn-id: svn://svn.chromium.org/blink/trunk@181926 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Adding Vector<char> to a String results in one (or more) temporary
copies of that Vector<char> since Vector isn't a pointer/smart pointer
like the types usually used.

Luckily there are many other ways to solve the problem. With StringBuilder
or using a String.

BUG=389085 (related to, not necessarily fixing it)

Review URL: https://codereview.chromium.org/559103002

git-svn-id: svn://svn.chromium.org/blink/trunk@181925 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=

Review URL: https://codereview.chromium.org/565813002

git-svn-id: svn://svn.chromium.org/blink/trunk@181924 bbb929c8-8fbe-4397-9dbb-9b2b20218538