- 10 Aug, 2018 40 commits
-
-
depot-tools-chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/15a5a77db412..284b5e0c60ac git log 15a5a77db412..284b5e0c60ac --date=short --no-merges --format='%ad %ae %s' 2018-08-10 recipe-roller@chromium.org Roll recipe dependencies (nontrivial). 2018-08-09 recipe-roller@chromium.org Roll recipe dependencies (trivial). 2018-08-09 iannucci@chromium.org [osx_sdk] Add mac_toolchain based osx_sdk module. Created with: gclient setdep -r src/third_party/depot_tools@284b5e0c60ac The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: Ia35a53873c5576541eef1bcce633baa62f7b4b15 Reviewed-on: https://chromium-review.googlesource.com/1170284Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582042}
-
Julie Jeongeun Kim authored
This CL introduces SetRestoredBoundsInPixels/GetRestoredBoundsInPixels in PlatformWindow to communicate with DesktopWindowTreeHostPlatform and makes DesktopWindowTreeHostPlatform use PlatformWindow:: GetRestoredBoundsInPixels() to get restored bounds. When WaylandWindow is created, HandleSurfaceConfigure() is always called without any state setting and |state_| is normal at first. In order to know the right time when the state is changed, this patch also updates the initial value for |state_| of WaylandWindow to 'PLATFORM_WINDOW_STATE_NORMAL'. With this, it clears |restored_bounds_| correctly. --ozone-platform=wayland --in-process-gpu, see crbug.com/848131 for more details. Test: ozone_unittests and manual testing with ./out/ozone/chrome Bug: 848131, 578890 Change-Id: Ifc27e60e24865a2237a0a49d5dc0f1452702c716 Reviewed-on: https://chromium-review.googlesource.com/1080354Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Julie Jeongeun Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#582041}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/60627d6eafd0..4174b5ab6ac9 git log 60627d6eafd0..4174b5ab6ac9 --date=short --no-merges --format='%ad %ae %s' 2018-08-10 tsepez@chromium.org Add CFX_DIBSource::GetWritableScanline(). 2018-08-09 tsepez@chromium.org Move all utf8 decoding under fx_string.h Created with: gclient setdep -r src/third_party/pdfium@4174b5ab6ac9 The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Id740ab3447b12f44c2d3d1ecbab50da62dd3e9b2 Reviewed-on: https://chromium-review.googlesource.com/1170283Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582040}
-
Ned Nguyen authored
Capacity issue on Nexus6 Webview has been resolved, so this may be ok to reenable the benchmarks on this platform now TBR=ksakamoto@chromium.org NOTRY=true Bug: 676612 Change-Id: I8f6a93767d47f94ba66a8a9df43b8d3a0b03b951 Reviewed-on: https://chromium-review.googlesource.com/1170422Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#582039}
-
Matt Menke authored
The class is refcounted and uses Mojo pipes. It could execute tasks as a result of Mojo callbacks after its refcount was 0, while there was a task to delete itself posted. Those tasks, if executed, would grab another reference (incrementing it from 0 to 1). That would result in use-after-frees and double deletion, once the already posted delete task was executed. This CL fixes that by getting rid of the callbacks executed from Mojo, and removing the weak reference used in another call. The downside of this approach is that Mojo errors are only lazily detected, which could result in displaying an extra error page in the case of network service crash. Bug: 870942 Change-Id: Ic7b00de6e7c623dc62098118292290666c91b1a7 Reviewed-on: https://chromium-review.googlesource.com/1164302Reviewed-by:
Chong Zhang <chongz@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582038}
-
Ned Nguyen authored
Bug:873033, 873032 Change-Id: Iff4749c56872f8a56322bce4e353b31bb59f454f TBR=kouhei@chromium.org, ksakamoto@chromium.org NOTRY=true Change-Id: Iff4749c56872f8a56322bce4e353b31bb59f454f Reviewed-on: https://chromium-review.googlesource.com/1170400Reviewed-by:
-
Wenzhao Zang authored
The current code assumes that a frame-less window does not need shadow. However, it's important for the CrOS wallpaper picker to remain frame-less to support wallpaper preview in tablet mode (spec [1]), and have a shadow in clamshell mode. It should makes sense to delete this logic since wallpaper picker is the only component extension that needs this behavior, and no current public apps are able to use the API. [1] https://drive.google.com/corp/drive/folders/0B_2Uyb2Rhx2ObU5VTFJVWHR2WW8 Bug: 835205 Change-Id: I96c9b14806f8f03ea2278d11031a33b08e7a68e8 Reviewed-on: https://chromium-review.googlesource.com/1135577 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#582036}
-
sawtelle authored
This CL creates the option to call setPictureInPictureControls() on an HTML video element with the desired info for custom controls. An example of the form this takes can be seen below: await videoElement.setPictureInPictureControls([ { id: "thumbs-up", label: "Thumbs up", icons: [ { src: "http://dummyimage.com/96x96", sizes: "96x96", type: "image/png" } ] } ]); The actual addition of these controls to the PiP window will come in a future CL. Bug: 863967 Change-Id: I6f6e65a28b546ba31ed67dd4ac92c550a0249b40 Reviewed-on: https://chromium-review.googlesource.com/1138640 Commit-Queue: Steven Sawtelle <sawtelle@google.com> Reviewed-by:Daniel Cheng <dcheng@chromium.org> Reviewed-by:
apacible <apacible@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#582035}
-
Sarah Hu authored
Move auth related metrics recording from LoginMetricsRecorder in ash to LoginAuthRecorder in chrome, because fingerprint attempt is observed in chrome. Extend existing uma to support fingerprint case and also add some new uma. Detail is listed in crbug.com/862295#c2 Bug: 862295 Change-Id: I460ea4edcd8798c54998b5afe7e6691f65ebbb06 Reviewed-on: https://chromium-review.googlesource.com/1166462 Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582034}
-
Eric Willigers authored
Embedded CSP enforcement shipped in M61 https://chromium-review.googlesource.com/525693 https://www.chromestatus.com/features/5750241810710528 BUG=647588 Change-Id: I90e82d7b3427015f7f173338001e2e473fa2fff3 Reviewed-on: https://chromium-review.googlesource.com/1165045Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#582033}
-
Michael Giuffrida authored
Whitelist the new Highlights app for chromeosInfoPrivate and public sessions. There are two versions of this app. Bug: 841089 Change-Id: Ie893d5f697c4cca36a5d7ca7427419eb4d3e8b2a Reviewed-on: https://chromium-review.googlesource.com/1152291Reviewed-by:
Toni Barzic <tbarzic@chromium.org> Reviewed-by:
Ivan Šandrk <isandrk@chromium.org> Commit-Queue: Michael Giuffrida <michaelpg@chromium.org> Cr-Commit-Position: refs/heads/master@{#582032}
-
Mohsen Izadi authored
BrowserGpuClientDelegate might have been destroyed when OnEstablishGpuChannel callback is run. Although this callback does not use |this| and just runs the other callback passed to it, it is technically an undefined behavior. Making it a non-member function, helps us avoid this undefined behavior. BUG=872140,872219,872244 Change-Id: Id7641c6c3ff2dcb153e9ed9b245013e878cc947a Reviewed-on: https://chromium-review.googlesource.com/1169964Reviewed-by:
Antoine Labour <piman@chromium.org> Commit-Queue: Mohsen Izadi <mohsen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582031}
-
Muyuan Li authored
Bug: b/111748671 Test: Manual Change-Id: I9dcd0800903309e8984f9a88d52f4bc49c316ca7 Reviewed-on: https://chromium-review.googlesource.com/1170162Reviewed-by:
Muyuan Li <muyuanli@chromium.org> Reviewed-by:
Yue Li <updowndota@chromium.org> Commit-Queue: Muyuan Li <muyuanli@chromium.org> Cr-Commit-Position: refs/heads/master@{#582030}
-
Raymond Toy authored
Have the BaseAudioContext do the audibility detection instead of the AudioDestination. And also post a task to the main thread when audible audio starts or stops. This is in preparation for reporting this information to the browser. Bug: 855069 Test: Change-Id: I8abd9be664697e8cc02998daec06f9ca0d34a98d Reviewed-on: https://chromium-review.googlesource.com/1165947Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#582029}
-
Jennifer Apacible authored
Currently, switching between videos in Picture-in-Picture mode sometimes causes letterboxing or pillarboxing, depending on the aspect ratio. This will size the window to adhere to the updated aspect ratio rather than immediately letterboxing the video. Future polish to be done in follow up patches. Bug: 864394 Change-Id: Ie0956f2b42c46207cc4f8af371755eee76e5c3c3 Reviewed-on: https://chromium-review.googlesource.com/1157523Reviewed-by:
-
Wei Li authored
When an out-of-process subframe itself also has out-of-process subframe(s), we need to be able to embed such contents too. This CL adds a test to make sure our code works in such cases. BUG=853942 Change-Id: I09d1fab4f10e299d3a7fb7f164bbbcfade3eebb5 Reviewed-on: https://chromium-review.googlesource.com/1166032 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#582027}
-
Reid Kleckner authored
This reverts commit cc14e55b. Reason for revert: The new version of clang appears to have regressed -O0 code size significantly (https://crbug.com/870907) Original change's description: > Roll clang 337439:338452. > > Bug: 866225 > Change-Id: I11d97d9a97432a1abb97e69a1395948b9d3e19fe > Reviewed-on: https://chromium-review.googlesource.com/1157290 > Commit-Queue: Reid Kleckner <rnk@chromium.org> > Reviewed-by: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#579922} TBR=thakis@chromium.org,hans@chromium.org,rnk@chromium.org NOTRY=true Bug: 866225, 870907 Change-Id: I39ac706d7fc4191d4519f1692f927788a072a081 Reviewed-on: https://chromium-review.googlesource.com/1170006 Commit-Queue: Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Reid Kleckner <rnk@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#582026}
-
angle-chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/c43cdad25851..9b6a3f926032 git log c43cdad25851..9b6a3f926032 --date=short --no-merges --format='%ad %ae %s' 2018-08-09 jmadill@chromium.org D3D: Speculative fix for VertexBuffer crash. 2018-08-09 jmadill@chromium.org Make Context handle dirty texture events. 2018-08-09 jmadill@chromium.org Remove some Vulkan perftest configs. 2018-08-09 jmadill@chromium.org Use active textures mask in GL and Vulkan. 2018-08-09 jmadill@chromium.org Program: Add cache samplers and type masks. 2018-08-09 jmadill@chromium.org Vulkan: Fix perftests null driver. Created with: gclient setdep -r src/third_party/angle@9b6a3f926032 The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@chromium.org Change-Id: I64ac64402a8aabbfd84f5301598f3a79556a9e04 Reviewed-on: https://chromium-review.googlesource.com/1170102Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582025}
-
John Abd-El-Malek authored
Bug: 871549 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I53fe4c0163964961e1a44fa9f81b95e63c395433 Reviewed-on: https://chromium-review.googlesource.com/1167989Reviewed-by:
Doug Turner <dougt@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#582024}
-
Matt Giuca authored
This reverts commit 3d493dc6. Reason for revert: FindIt blamed this CL with 85% confidence. Sorry. I don't see anything wrong with this CL, but I also don't see anything wrong with any other CL in the blamelist, so I'm starting here. See https://crbug.com/873015 for analysis. Original change's description: > Remove unnecessary NetworkService flag check in ResourceDispatcher > > blink::ServiceWorkerUtils::IsServicificationEnabled() checks > whether NetworkService is enabled, so we don't need the check > in ResourceDispatcher::StartAsync(). > > Bug: N/A > Change-Id: I06bab175489f42dc0cefa2a257806db29192eba1 > Reviewed-on: https://chromium-review.googlesource.com/1168707 > Reviewed-by: Makoto Shimazu <shimazu@chromium.org> > Reviewed-by: Yutaka Hirano <yhirano@chromium.org> > Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581828} TBR=yhirano@chromium.org,bashi@chromium.org,shimazu@chromium.org Change-Id: Ia89cf9c0523395c7b331482f39e708f283cbc3ec No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: N/A Reviewed-on: https://chromium-review.googlesource.com/1170402Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Matt Giuca <mgiuca@chromium.org> Cr-Commit-Position: refs/heads/master@{#582023}
-
Livvie Lin authored
This will display the SCT list similar to how it's displayed in the DevTools Security Panel. Screenshot: https://drive.google.com/file/d/1kXpVmXspx1vzoPKjHaGDpn5rfEEc-C8a/view?usp=sharing Bug: 845297 Change-Id: I8f028ecb5a8b0c1ff2b247c932c38bdacd9a55bc Reviewed-on: https://chromium-review.googlesource.com/1169769 Commit-Queue: Livvie Lin <livvielin@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Cr-Commit-Position: refs/heads/master@{#582022}
-
Jun Choi authored
As a workaround for BlueZ implementation that prevents simultaneous advertisement and scanning, start discovery process for Cable devices pior to registering advertisements. Also, once expected Cable device is found and is ready for connection, unregister all ongoing advertisements. Change-Id: I180513d2ae17734ee19165f7e209ecd336691496 Reviewed-on: https://chromium-review.googlesource.com/1164408 Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#582021}
-
kristipark authored
Pressing enter in the edit link dialog will no longer delete the link. The current event handler was not being called. Bug: 864357 Change-Id: Idbba0cf0a3f9f0afa7dbcf91b49ec45de5c9e144 Reviewed-on: https://chromium-review.googlesource.com/1169763 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#582020}
-
akaba authored
This CL updates SurfaceManager::GetLatestInFlightSurface to consider presistent references while computing the latest surface. In addition, it allow GetLatestInFlightSurface to return something other than the fallback in case the FrameSinkIds of the range differ. Bug: 871964 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I9f0de1cbb6bbdd10a69f70305a499123b34d7912 Reviewed-on: https://chromium-review.googlesource.com/1166163 Commit-Queue: Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Reviewed-by:
Saman Sami <samans@chromium.org> Cr-Commit-Position: refs/heads/master@{#582019}
-
Scott Haseley authored
The emum labels had a mix of "visible" and "active". The page lifecycle state is "active", not "visible". Change-Id: I580f6037464e5a54810170ceddb71ce586901ef5 Reviewed-on: https://chromium-review.googlesource.com/1170177Reviewed-by:
Shubhie Panicker <panicker@chromium.org> Commit-Queue: Scott Haseley <shaseley@google.com> Cr-Commit-Position: refs/heads/master@{#582018}
-
Oystein Eftevaag authored
This enables it for a limited subset of tests to catch any regressions before enabling it for all perf tests, and will only have an effect on Mac/Windows/Android platforms currently. Bug: 839084 Change-Id: Ifcfcaefbbb3be177f9a5941031e48ead60f1fc77 Reviewed-on: https://chromium-review.googlesource.com/1169768 Commit-Queue: oysteine <oysteine@chromium.org> Reviewed-by:
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/644d8e7175ae..bc6f9c9a8c6b git log 644d8e7175ae..bc6f9c9a8c6b --date=short --no-merges --format='%ad %ae %s' 2018-08-09 herb@google.com Remove GrTextUtil::Paint 2018-08-09 fmalita@chromium.org [skottie] Avoid UB while parsing 1-based indices 2018-08-09 mtklein@google.com in MS land, -include is /FI 2018-08-09 timliang@google.com Reland "implemented GrMtlSampler for metal gpu backend" 2018-08-09 enne@chromium.org Add max_fragment_uniform_vectors_32 workaround 2018-08-09 mtklein@google.com turn on alignment sanitizer 2018-08-09 ethannicholas@google.com fixed early return breaking things in .fp files 2018-08-09 brianosman@google.com Allow any color space when making a picture backed image 2018-08-09 fmalita@chromium.org [skottie] Optimize color filter layerization 2018-08-09 bungeman@google.com Viewer to resize Samples with window resize. 2018-08-09 herb@google.com Remove RunPaint 2018-08-09 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 c43cdad25851..468484201532 (1 commits) Created with: gclient setdep -r src/third_party/skia@bc6f9c9a8c6b The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:864564,chromium: 829614 TBR=djsollen@chromium.org Change-Id: I71da299909970ffe5f2ac7fde0bb6d761e7d1abe Reviewed-on: https://chromium-review.googlesource.com/1169667Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Mike Klein <mtklein@chromium.org> Cr-Commit-Position: refs/heads/master@{#582016}
-
Ned Nguyen authored
NOTRY=true TBR=sadrul@chromium.org, vmiura@chromium.org Bug: 873014 Change-Id: Ie2e2161a36445df755f3414ca484cbfc44e14bf7 Reviewed-on: https://chromium-review.googlesource.com/1170386Reviewed-by:
-
Andrey Kosyakov authored
We accidentally used a CORS fetch() to a resource that dit not allow CORS access in the test, expecting Network.loadingFinished to happen after the resource is loaded. However, with per-message dispatch tasks (https://chromium-review.googlesource.com/c/chromium/src/+/1145692), the request is cancelled before we receive loadingFinished, so we now get loadingFailed with net::ERR_ABORTED instead. Bug: 872081 Change-Id: I9cfd6c8ebc49f1e835916fb87f4d6cea0e4262b1 Reviewed-on: https://chromium-review.googlesource.com/1168185 Commit-Queue: Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582014}
-
Jennifer Apacible authored
This updates the scrim, or the background layer of the controls, based on UX feedback. Bug: 872806 Change-Id: Ieb036815599057b6e0869bf61dee0b811cc42333 Reviewed-on: https://chromium-review.googlesource.com/1168735 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
-
Dirk Pranke authored
This reverts commit 7e545610. Reason for revert: Speculative revert for crbug.com/872714 Original change's description: > android/asan: Don't depend on llvm version number at test time. > > Instead, copy the runtime to the build dir at build time and find it there > at test time. > > Matches how things work on other platforms with the asan runtime in a shared > library (mac/ios/win). > > This also makes things do the right thing with a custom clang_base_path. > > Bug: 872278 > Change-Id: I930bd88206f973c10eb47bfd2f132e70167235f4 > Reviewed-on: https://chromium-review.googlesource.com/1167465 > Reviewed-by: Hans Wennborg <hans@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#581682} TBR=thakis@chromium.org,hans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 872278 Change-Id: Ie2903e4f2a65dc44abe698f3a26c6d370afd1e89 Reviewed-on: https://chromium-review.googlesource.com/1169933Reviewed-by:
-
Jinsuk Kim authored
There is a timing-related bug in Find in page menu on NTP, which happens when the web contents was already switched to one for NTP but the menu for the action remained available. The actual find toolbar is designed not to appear by checking if the current web contents is for NTP or not. Previously, null check against |tab.getContentViewCore| was enough but after https://crrev.com/c/989515, |tab.isNativePage| should be called as well as |tab.getWebContents|. This CL adds the missing check. Bug: 872650 Change-Id: Ibef4d335cf2dc2a4ceab5b507eb9f08c47e5e946 Reviewed-on: https://chromium-review.googlesource.com/1170142Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#582011}
-
Jennifer Apacible authored
For ChromeOS, ash (window manager), will handle adjusting the window size to adhere to the specified aspect ratio. This change adds a new aura constant to keep track of the window's aspect ratio, if any. This is used in WindowResizer to determine the new window bounds. Bug: 853276 Change-Id: I4c7eaa6252e26ffccf3ac10a4dafd635a3b556d1 Reviewed-on: https://chromium-review.googlesource.com/1164483 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by:
-
Hitoshi Yoshida authored
For now, IDL parser allows to put extended attributes on enum values, that is syntactically invalid in Web IDL spec [1]. In Blink, other IDL compiler parts ignore them, and no IDL files have them. In order to avoid misleading developers, this CL makes IDL parser to disallow extended attributes on enum values. [1] https://heycam.github.io/webidl/#idl-enums Bug: 871867 Change-Id: Ic57406ce3ff94a0c1a4cf38da12b217c05667eb0 Reviewed-on: https://chromium-review.googlesource.com/1169482Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#582009}
-
Ned Nguyen authored
Bug:873013 NOTRY=true TBR=sadrul@chromium.org, vmiura@chromium.org Change-Id: I191cc697f66945c327c2c8a4bdf5ecb1029e041b Reviewed-on: https://chromium-review.googlesource.com/1170359Reviewed-by:
-
Raymes Khoury authored
With Permission Delegation enabled, GetPermissionStatusForFrame should always be used to determine the permission status for an embedded origin. GetPermissionStatus should only be used when there is no frame available (e.g. for UI or in the case of service workers, etc.). Bug: 802945 Change-Id: I45867eb3c3e98be57b48e8c2c3cade6287e9a8fd Reviewed-on: https://chromium-review.googlesource.com/942504 Commit-Queue: Raymes Khoury <raymes@chromium.org> Reviewed-by:
Timothy Loh <timloh@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#582007}
-
David Black authored
Fixes a crash caused by using Assistant before our service side references are fully initialized. Bug: b:112427263 Change-Id: If2845ae4365b005c029d73e113a1989f0f210ef8 Reviewed-on: https://chromium-review.googlesource.com/1169911 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
file://static_top_25/yahoonews.htmlNed Nguyen authored
NOTRY=true TBR=vmpstr@chromium.org Bug: 873011 Change-Id: I96ef9604433cd5b03c8a0e51dd124e7d5d0e7999 Reviewed-on: https://chromium-review.googlesource.com/1170357Reviewed-by:
-
Jordy Greenblatt authored
This Behavior will be used by the multidevice settings UI so it should live in a common area. Note that because some files in the folder are used by iOS9 which does not support newer js features, the convention is to use older syntax (such as var instead of let of const). Change-Id: I1bf8a8c99c20322fb43e4c0afe54caf853e5c37e Reviewed-on: https://chromium-review.googlesource.com/1170091Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jordy Greenblatt <jordynass@chromium.org> Cr-Commit-Position: refs/heads/master@{#582004}
-
Peter Collingbourne authored
This will allow ShellMainDelegate and TestShellMainDelegate to share an implementation of the browser subprocess later. Bug: 855193 Change-Id: Id4ef662bd96b606f19b4ecedda15a8a1bbed979b Reviewed-on: https://chromium-review.googlesource.com/1168647Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582003}
-
