GitLab

This takes the values returned as base::Value from the sandbox
policy and allows them to be expanded in the summary display of
chrome://sandbox.

Expansion is deferred as the page can become slow in debug builds if
it is performed every time, and expanded values are not always
required for debugging.

Bug: 1115305
Change-Id: I96d71b21ccc28e678fdb3fb9714f30cf88b730ef
Tests: manual testing on Win7 x86 and Win10 10.0.18362
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350331Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Commit-Queue: Alex Gough <ajgo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797783}

Change the loading spinner to show when waiting time is longer than
500ms, and ensure the loading spinner is displayed for at least 500ms.

For simplicity, we also change the name of CCT fragment and use original
flow when the welcome page is going to be skipped.

Bug: 1108558
Change-Id: If22d74f1afe5a88b1637d4db29be137173c58f6d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2338932
Commit-Queue: Wenyu Fu <wenyufu@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797782}

It will create an easy workaround for developers when testing policy
on platforms that have need complicated policy management tools.

Bug: 1113792
Change-Id: Ie0431022a3aba1d5356afb32a9987a91d6ba7929
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353397
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Yann Dago <ydago@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797781}

Change logic:
* The untrusted PaymentRequest interface breaks apart from CPRImpl to
become MojoPaymentRequestGateKeeper. The new class would be responsible
for handling the untrusted mojo calls from the renderer. Doing that,
it can ensure that CPRImpl receives no invalid calls from the renderer.
* Establish the requirements for the users of CPRImpl that the CPRImpl
instances should be set null after BPRImpl#close, CPRImpl#teardown and
PRClient#close. For example, CPRImpl#OnClosedListener is provided for
the callers to nullify the instances.

Note that:
* Although MPRGateKeeper and CPRImpl both have plumbings to pass PR
calls, they are necessary, because going forwards, PRImpl will be
diminished, and eventually the plumbings would only exist between
MPRGateKeeper and CPRImpl.

Code change highlights:
* In CPRImpl#initAndValidate(), null-check the request's raw data
before passing them into BPR, so that BPR doesn't need to add @Nullable
for them.
* In MPRGateKeeper#init, discards CPRImpl (and its PRClient, BPR) when
the raw data are invalid.
* MPRGateKeeper plumbs the PR calls to CPRImpl, so that the calls are
only passed to the CPRImpl when the PaymentRequest data are valid.

Acronym:
CPRImpl = ComponentPaymentRequestImpl
BPR = BrowserPaymentRequest
PRClient = PaymentRequestClient
MPRGateKeeper = MojoPaymentRequestGateKeeper

Bug: 1102522

Change-Id: Iab160b2c3e74608b9b19ba17e454dedf32411193
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346730
Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797780}

This CL fixes VaapiWrapper::FillProfileInfo_Locked() so that it doesn't
return false when the profile is VAProfileVP9Profile2 and the driver
does not advertise support for VA_RT_FORMAT_YUV420 (and instead only
advertises support for VA_RT_FORMAT_YUV420_10 and
VA_RT_FORMAT_YUV420_12).

More context:

The uprev to iHD 20.2.0 caused TGL to advertise only
VA_RT_FORMAT_YUV420_10 and VA_RT_FORMAT_YUV420_12 for
VAProfileVP9Profile2, probably because of [1]. This seems reasonable
since VP9.2 is intended for high bit depth. Running vainfo -a shows the
following for VP9.2:

VAProfileVP9Profile2/VAEntrypointVLD
    VAConfigAttribRTFormat                 : VA_RT_FORMAT_YUV420_10
                                             VA_RT_FORMAT_YUV420_12
                                             VA_RT_FORMAT_YUV420_10BPP
    VAConfigAttribDecSliceMode             : VA_DEC_SLICE_MODE_NORMAL
                                             VA_DEC_SLICE_MODE_BASE
    VAConfigAttribDecProcessing            : VA_DEC_PROCESSING
    VAConfigAttribMaxPictureWidth          : 16384
    VAConfigAttribMaxPictureHeight         : 16384
    VAConfigAttribProcessingRate           : VA_PROCESSING_RATE_DECODE

The problem is that VaapiWrapper::FillProfileInfo_Locked() returns true
only if one of {VA_RT_FORMAT_YUV420, VA_RT_FORMAT_YUV422,
VA_RT_FORMAT_YUV444} is advertised. Therefore, for iHD 20.2.0, we would
determine that VAProfileVP9Profile2 is unsupported and subsequently fall
back to software.

This CL ensures that we check for the presence of
VA_RT_FORMAT_YUV420_10 (which is the non-deprecated version of
VA_RT_FORMAT_YUV420_10BPP [2]).

[1] https://github.com/intel/media-driver/commit/ca71e10f29ea3b232b883803b31724a8ee0d3e46
[2] https://github.com/intel/libva/blob/2.8.0/va/va.h#L821

Bug: b:161520834
Test: crosvideo.appspot.com w/ VP9.2; checked chrome://media-internals
Change-Id: Id00a0150272cc11640bd21183ee739b005f9d2cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303682Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Andres Calderon Jaramillo <andrescj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797779}

Wayland Ozone backend uses a platform drag-and-drop session to be able
to support the capabilities required by Chrome's tab dragging.
Particularly, keeping track of the focused window and the current mouse
cursor position while the tab/window is dragged around. Further context
can be found at the design doc [1].

So far, it has been relying only on {Run,End}MoveLoop API to trigger
such DND session. It works, but, as it is called after the (dragged)
windows creation and mapping, it is not possible to take the necessary
actions upon window creation or mapping (e.g: issue some dnd/extension
protocol request to the Wayland compositor), which makes it insufficient
to achieve glitches-free tab/window detaching implementation. Which has
been verified while addressing [2][3], and can be seen at video [4].

To fix it, this patch does:

- Add WaylandExtension platform window extension, with a single method
for now, that makes it possible for the upper layer components to start
the window dragging session explicitly;
- Plumbs up Chrome's Browser{Frame,DWTHLinux} such that it starts a
Wayland drag-and-drop session when the tab drag starts.

[1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing
[2] https://bugs.chromium.org/p/chromium/issues/detail?id=1099418
[3] https://chromium-review.googlesource.com/c/chromium/src/+/2307653
[4] https://www.youtube.com/watch?v=3sWVyA1OagA

R=sky@chromium.org

Bug: 896640
Test: Covered by ozone_unittests
Change-Id: I5e902caa7b495ae585330bc3e3b431bacb139d1e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346545
Commit-Queue: Nick Yamane <nickdiego@igalia.com>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Sisov (GMT+3) <msisov@igalia.com>
Cr-Commit-Position: refs/heads/master@{#797778}

Bug: 1113466
Change-Id: Idc85b749409055f0e9d5bbbc1d0fcb55a12d2df2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343494
Auto-Submit: Mark Mentovai <mark@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797777}

Also adds a test for documenting what happens when the limit is
reached.

Bug: 1115736
Change-Id: Ie488adb6b874ae47503670514bd7456bef8bfd6f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354536Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Robert Ogden <robertogden@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797776}

To ensure the MediaSourceRegistryImpl singleton is available and known
to MediaSourceAttachments before they could possibly be created, moves
the singleton construction to be done during modules initialization
instead of lazily on-demand later. This ensures that the main thread
will own the singleton, since later changes enable first real usage of
the registry to be done from either the main thread or from a dedicated
worker thread.

BUG=878133

Change-Id: Ibc4e0b77ef840d76d6048a46614affae3227c07d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353534Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797775}

The active profile was not being cleared on the |NearbyProcessManager|
singleton in the unit-test tear down which was causing unit-test
failures.

Change-Id: Iefe1b037beeb23924550c9ae6ccaf1ba0f111b5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354616
Commit-Queue: James Vecore <vecore@google.com>
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Auto-Submit: James Vecore <vecore@google.com>
Reviewed-by: Ryan Hansberry <hansberry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797774}

disconnects.

Add disconnect handlers to the speech service. If the UI in the browser
disonnects from the service in the renderer, have the speech service stop
transcribing captions. If the service in the renderer disconnects from
the utility process which connects to SODA or the cloud, send a message
to the UI that there was an error and have the UI display the error
message.

Bug: 1055150
Change-Id: I3940cae2cd12503353e105fd612b064908d9951c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353024Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Alex Gough <ajgo@chromium.org>
Reviewed-by: Evan Liu <evliu@google.com>
Commit-Queue: Abigail Klein <abigailbklein@google.com>
Cr-Commit-Position: refs/heads/master@{#797773}

Implementing AsValueInto method in NavigationRequest allows it to be
used as input into tracing events macros. This CL adds this support and
uses it to log the NavigationRequest in its constructor.

Bug: 1043616
Change-Id: Iac28d6d52944064e448d99fe2734057ad0cf6ac4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353546
Commit-Queue: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797772}

This makes it easier to track down and/or change types.

Also renames CallbackList -> RepeatingCallbackList.

Bug: 1113007
Change-Id: I42357489f2c3e7a19b0f4909fe20ca7dc9ff4339
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354225Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Maksim Moskvitin <mmoskvitin@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797771}

SerialTest.NavigateWithChooserCrossOrigin fails on Linux Ozone Tester
(X11), https://ci.chromium.org/p/chromium/builders/ci/
Linux%20Ozone%20Tester%20%28X11%29/15780,
disable it for now until it is fixed.

TBR= reillyg@chromium.org

Bug: 1116072
Change-Id: I01e63d9a87ed9e2995db21e158a9d964cf7cd5e4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354712Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Lan Wei <lanwei@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Lan Wei <lanwei@chromium.org>
Auto-Submit: Lan Wei <lanwei@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797770}

We need to pass switch --use-cras to the audio service so that chrome
will be able to use CRAS on linux.

Bug: 151905045
Change-Id: I7c8acf0f3c976ba40bf492a85a53c56a3254fcfe
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332057Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797769}

Previously Vulkan extensions VK_KHR_external_memory_fd and
VK_KHR_external_semaphore_fd were not enabled for swiftshader because
they were not supported. They are supported now, so they can be enabled.

Bug: 963988
Change-Id: I4d72fe965038615f19311e1e5bca5600b54035ab
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353930
Auto-Submit: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797768}

When user enters into an overscroll (without fling) and lifts off the
fingers while the scroller is stretched, we can occasionally observe
forward jerks before a bounce back animation plays. This happens due to
stray finger movements. When the finger lifts off, there can be small
velocities that trigger a forward animation (i.e the quick forward
jerk). This CL fixes the issue by preventing the scroller from playing
the bounce forward animation when velocities are really small.

Bug: 1116057
Change-Id: I1f3c53b510172b6d5509e09354db3d97a9814492
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348009Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: Rahul Arakeri <arakeri@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#797767}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/2bc574fa..42ae8f6e

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I2f87a47bad57dadf37ab5f8a1af9f7cdb7a54b44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354261Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797766}

https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/f20a184a017f..a22614c51d49

2020-08-13 jacktfranklin@chromium.org Regenerate all bridge files
2020-08-13 alexrudenko@chromium.org Show list of grid elements in Layout pane

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/devtools-frontend-chromium
Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Bug: chromium:1109177
Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com
Change-Id: I9dd21c2181ce7c9ac1ea2f0bbc16728961ad1eb9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354474Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797765}

Change-Id: I5eedd07b2e3d4b81b3fb573eb70bb543cf6965b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354591
Auto-Submit: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Chris Hamilton <chrisha@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@google.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Cr-Commit-Position: refs/heads/master@{#797764}

Sometimes [ToolbarMediator updateShareMenuForWebState:]
is passed a null WebState, so do nothing if that is the case.

Bug: 
Change-Id: Id083687df59199489a80ca21a9182113e2ad62ae
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354710
Auto-Submit: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797763}

- We were using the wrong proto message for the response.
  I've made a new discover_actions_service.proto file to
  more closely match the server definitions.
- The response does not have a varint prefix

Added a test, UploadedActionsAreNotSentAgain. It wouldn't
have caught the problem, but looks like a case we weren't quite
testing yet.

Bug: b/163866547
Change-Id: Iab8c11ce3ceb3ab61d2b56cc694af9f127e45b38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354245
Commit-Queue: Dan H <harringtond@chromium.org>
Reviewed-by: Ian Wells <iwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797762}

- omnibox-autocomplete-titles (m85 -> 95)
- omnibox-drive-suggestions (m85 -> 95)
- omnibox-local-entity-suggestions (m85 -> 88)

Change-Id: I216a56be058155eea666261303f823ed4e7f0247
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353537Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797761}

In order to work around the inability to inspect the contents of
include_dirs when creating an action within the nocompile_test template,
this change adds a dedicated include_dirs parameter to the template.
This allows callers to provide extra include dirs explicitly, which will
e.g. be required once classes in base include Abseil headers, and thus
affecting base's nocompile tests as well.

Bug: None
Change-Id: I2354dd428e5ada8c5a41bb9b2c3e7007a3df9282
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351772Reviewed-by: Brett Wilson <brettw@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797760}

This removes some unnecessary complexity.

BUG=none
TEST=test only change

Change-Id: Ide08a5af6915c93a9cdf5b06132a3fc47e3138b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349788
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Peter Kotwicz <pkotwicz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797759}

Implement a concrete location::nearby::api::BluetoothSocket, created via
a bluetooth::mojom::Socket and Mojo DataPipes supplied by the newly
implemented BluetoothClassicMedium::ConnectToService().

Nearby Connections uses this BluetoothSocket to communicate with a
remote device. At a high-level, it first exchanges frames to encrypt
the connection, then delegates to its caller (e.g., Nearby Share)
to authenticate the connection, and finally expects its caller to
send and receive application-level messages. The following precautions
are taken to handle untrusted bytes received from remote devices:
  * Nearby Connections (including the code being added in this CL) is
    hosted in a Nearby utility process.
  * Whenever Nearby Connections provides bytes received from a remote
    device to its caller, even after it has been authenticated, the
    caller must not trust those bytes, and is responsible for first
    passing those bytes through the trusted NearbyDecoder interface
    (see go/nearby-chrome-mojo). NearbyDecoder is hosted in the same
    Nearby utility process.

api::BluetoothSocket is a synchronous interface, so this
implementation consumes the synchronous signatures of
bluetooth::mojom::Socket methods.

api::BluetoothSocket's subclasses are also synchronous interfaces,
but the Mojo DataPipes they consume only provide asynchronous
interfaces. This is reconciled by blocking on the caller thread when
waiting (via a mojo::SimpleWatcher) for the DataPipes to become
readable or writable (this is expected by the callers of
api::BluetoothSocket's subclasses). Mojo DataPipe operations are
handled on a separate task runner so that blocking on the calling
thread will not deadlock.

Please see design doc go/nearby-chrome-bt for more details.

Bug: b:154849033, b:158848873
Change-Id: I2e945277aa1f75b4ca378d0b961f7682ff25d812
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2322166
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Alex Chau <alexchau@chromium.org>
Reviewed-by: James Vecore <vecore@google.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797758}

This class tracks whether notification access has been granted by the
user on their phone. Because notification access is a sensitive
permission, this requires the user completing a special setup flow and
is not included with the rest of Phone Hub opt-in.

Note that currently, this class defaults to "false" (i.e., has not yet
granted access). A future CL will set this value based on whether the
phone has sent a message indicating that access has been granted.

Bug: 1106937
Change-Id: Ice4968ef684b96f090ee566013aa39dc8224e4f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353709
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797757}

(where they should have been from the beginning; placed in Chrome by mistake).

Bug: b:153649905
Change-Id: Iea5a43b7ea4dc553d544977f62177e0a01200eb3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354532
Auto-Submit: Leonid Baraz <lbaraz@chromium.org>
Reviewed-by: Zach Trudo <zatrudo@google.com>
Commit-Queue: Zach Trudo <zatrudo@google.com>
Cr-Commit-Position: refs/heads/master@{#797756}

Bug: 1114678
Change-Id: I4880e93b9d0e3b0339cba52e5b50000e9a2c8432
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354516
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mohamed Heikal <mheikal@chromium.org>
Auto-Submit: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Mohamed Heikal <mheikal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797755}

Bug: 1114946
Change-Id: Id73c5537ab2de1912af57e3235e88adcdb52016c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343770
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Darin Fisher <darin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797754}

This adds various entrypoints to Prerender code in WebLayer, now that
all the delegate interfaces have implementations and all factories are
in place.

Please see the following spreadsheet to see corresponding chrome
entrypoints and my reasoning for the chrome entrypoints I have left out
of WebLayer:
https://docs.google.com/spreadsheets/d/1u13bzBQiBqibXzDDmkB4Kbvm29DslTQmXmY91864gOU/edit#gid=299677236

Bug: 1096088
Change-Id: I62549bf3a8f6dbd5a5334c87048b197d75fc4001
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346349
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Martin Barbella <mbarbella@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797753}

In this CL, EffectNode holds a flag to determine whether the node and ancestor has filters.
So that disallowing LCD text for filters can apply to descendants.

Bug: 1114504
Change-Id: I7059f396aac83bfb686e86cc1c6cf4145da0a975
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352569Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797752}

These are errors that pop up when running `git cl lint`.

Bug: none
Change-Id: I7f105d13ab65ca48a478e4abf3acb4d171cfec15
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352528
Commit-Queue: Nina Satragno <nsatragno@chromium.org>
Auto-Submit: Nina Satragno <nsatragno@chromium.org>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#797751}

Bug: 1102747
Change-Id: I4ec074babd58d5de2e6e5880ddafbb81b9a60879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354409Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Caitlin Fischer <caitlinfischer@google.com>
Auto-Submit: Caitlin Fischer <caitlinfischer@google.com>
Cr-Commit-Position: refs/heads/master@{#797750}

By making CompromisedCredential implement Parcelable and provide a
static CREATOR, it can be serialized and used in Bundles. This enables
to pass it as extra when:
 * Saving the instance state if an activity is recreated
 * Starting fragments that need a compromised credential as extra

Bug: 1114720, 1092444
Change-Id: Ice45d321488794083f59217fc60c72a11f893e85
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352879Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Friedrich [CET] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797749}

CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome
TBR=chrome-os-gardeners@google.com

Change-Id: I7f1f5af0efd13e16d6ec066ed4a02e95b81562ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353490Reviewed-by: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#797748}

This CL adds a new create shortcut feature guarded by a feature flag for incognito mode on windows.
 - created a new string value.
 - created a new button in the incognito view menu.
 - added UMA metrics to the create shortcut button.

Old Incognito Menu
https://screenshot.googleplex.com/s69MjunQKMx

New Incognito Menu
https://screenshot.googleplex.com/oy0e7GywXMt

Design Deck: go/add2desktop

Bug: 1113162
Change-Id: I6b336045d4e423d63d11d52cf75d84eb69e6eb7b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341132
Commit-Queue: Ramin Halavati <rhalavati@chromium.org>
Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ramin Halavati <rhalavati@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797747}

Before this patch, the test environment for an ARC PaymentAppService
unit test was being setup inside of the only PaymentAppService unit
test, which prevented sharing this environment among multiple unit test
files.

This patch separates the ARC PaymentAppService test environment into its
own test support file.

After this patch, it's possible to share the setup code for ARC
PaymentAppService test environment among multiple unit test files;

Bug: 1061503
Change-Id: If8271d7d277823dc53630bcdc4f6097bc9a6a2b4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248749
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797746}

Bug: 1076880
Change-Id: I9931707d9f15ac3013195592f78a95e7579bca38
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352812Reviewed-by: Monica Basta <msalama@chromium.org>
Commit-Queue: David Roger <droger@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797745}

This reverts commit ef93a320.

Reason for revert: suspected to be the root cause of crbug.com/1115767

Original change's description:
> Add an iOS port to blinkpy
>
> This adds an iOS port to blinkpy to allow sharing logic for running
> WPTs using 'wpt run'. In particular, the goal is to share logic for
> managing expectations and for running tests on a bot.
>
> Change-Id: I6e9b5bddc1f20494b7d9124a7027777c53e38e93
> Bug: 673423
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1739390
> Reviewed-by: Robert Ma <robertma@chromium.org>
> Commit-Queue: Ali Juma <ajuma@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#684770}

TBR=ajuma@chromium.org,robertma@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1115767, 673423
Change-Id: Ib1dba6a03a77160fc2641b565676d8809004827a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354273
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Ali Juma <ajuma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#797744}