- 13 May, 2019 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/2947e88f7938..e935dac9ef8a git log 2947e88f7938..e935dac9ef8a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 stevenperron@google.com Make pointers to isomorphic type interchangeable with option. (#2570) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@e935dac9ef8a The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I76bee692be829c25266527d1cc8ba0e461fb5aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610449Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659152}
-
Robert Sesek authored
Bug: 958163 Change-Id: I356398a77cee42c71ccc6c722523b832a0b9d649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610639Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#659151}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I105d94fc7c03764215f07f6c3f298ff488724c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608970 Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Cr-Commit-Position: refs/heads/master@{#659150}
-
Scott Violet authored
Ahmed asked about the difference between ScopedExclude and ScopedForceVisible, which tells me the docs aren't good enough. Attempts to better describe what happens with the two. BUG=none TEST=doc only change Change-Id: Ia3b798b77f7609ad70dd9f8bed0f50157b10a6e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604327 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Cr-Commit-Position: refs/heads/master@{#659149}
-
chrome://managementNicolas Ouellet-payeur authored
Instead of always getting redirected to 'chrome://settings/help', the back button now goes back in the tab's history. If the tab has no history, it falls back to the old behavior. Bug: 959258 Change-Id: I32c6700648839b23879c48dd69878fa74ef42986 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606190Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Cr-Commit-Position: refs/heads/master@{#659148}
-
Kevin Babbitt authored
- Fix ITableItemProvider implementation to retrieve column/row header items from the containing table. - Eliminate S_FALSE return from ITableItemProvider methods. - Return empty SAFEARRAYs as nullptr across all properties and control patterns. This is the same behavior as EdgeHTML. - Add missing tests for ITableItemProvider and update ITableProvider tests to cover paths checking for invalid item references. To assist with this, I split apart the SAFEARRAY testing macros to take either a property ID or a SAFEARRAY directly. Bug: 847971 Change-Id: If6f38d7ac7526fa374840f5755eb5aeb99a1b6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1601633 Commit-Queue: Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#659147}
-
Richard Townsend authored
Checks in the arm64 variant of the test DLL. Values in the unit test have been updated using the output from dumpbin. Bug: 925584, 893460 Change-Id: Iab41f94283d88d39a986ca100c9538b4ba61228f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1599594Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Richard Townsend <richard.townsend@arm.com> Cr-Commit-Position: refs/heads/master@{#659146}
-
Tao Bai authored
The some changes of element will not cause remove/add LayoutText, instead, LayoutText is changed. This patch supports the content change in this case, DidUpdateContent() is added and invoked after new content is sent. Bug: 952973 Change-Id: Ia530e7e71570801f1f494bd584526cc7dc3ccba8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1598310 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#659145}
-
Tony de Luna authored
This CL adds browser tests that verify that guest signing becomes visible when available and clicking on the link starts a guest session. Bug: 959340 Change-Id: I5e52b2a93818c11779b573d71ccc1174c5b48977 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606574 Commit-Queue: Tony De Luna <tonydeluna@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#659144}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2ebf5239782b..3dfb68082e1a git log 2ebf5239782b..3dfb68082e1a --date=short --no-merges --format='%ad %ae %s' 2019-05-13 yvesg@webrtc.org Use robust variance computation in RollingAccumulator. Created with: gclient setdep -r src/third_party/webrtc@3dfb68082e1a The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I7dc8c6aacf1939fe64854a9e59093c1a3943582a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610447Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659143}
-
Patrick Monette authored
This fixes most of the presubmit errors you get when modifying those files Bug: 714018 Change-Id: I5581e3264ea172e725a9dae07f3a734d845d92aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592766 Commit-Queue: Patrick Monette <pmonette@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#659142}
-
Abhijeet Kandalkar authored
Bug: 891908 Change-Id: I43fae34afee2c5b278cd652908eb6ff666e0020e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608871Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#659141}
-
Lukasz Anforowicz authored
Bug: 961307 Change-Id: I55619a8c5994bd7008db9bf2baad700efe496e32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606644 Auto-Submit: Łukasz Anforowicz <lukasza@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#659140}
-
Rohit Rao authored
If Recent Tabs is invoked from incognito, restored tabs are placed in the non-OTR WebStateList. Before this CL, the current non-OTR WebState was clobbered and replaced, resulting in a crash if the WebStateList was empty. This CL forces restoration to happen in a new WebState, which sidesteps the crash. BUG=960742 TEST=Restore a tab from incognito, with no non-Incognito tabs open. The app should not crash, but the app will also not switch to show the newly-restored tab. Change-Id: Id38e74cb9bfdada160f1fa049d02219a3a9f1f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605788 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#659139}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/02f2aec13451..a69e8c1681da Created with: gclient setdep -r src-internal@a69e8c1681da The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=anthonyvd@google.com,alph@google.com,battre@google.com Change-Id: I74b0d456a6b9313c29f88ea447f8806683f4ad8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659138}
-
Patrick Monette authored
Bug: 668690 Change-Id: Iac624c067336b2f2479a6541a5d2fc7566f4dd5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603065Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#659137}
-
Christopher Cameron authored
This was used only to guard calls to the static method LayoutThemeDefault::SetSelectionColors. This static methods should have been virtual on blink::LayoutTheme to begin with. It also shouldn't be routed through blink::WebView (rather, it should be called directly, like the adjacent blink::SetFocusRingColor). Note that after changing selection colors, we call both blink::WebWidget::ThemeChanged and blink::Page::PlatformColorsChanged. I don't know the distinction between the two. Bug: 961342 Change-Id: I3edd3d41d6ad6de1fc3331bb03308f2dc7c6a683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606185 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#659136}
-
Mugdha Lakhani authored
This CL adds logic to dispatch periodic Background Sync event, and updates BackgroundSyncManager unit tests to verify that the event is fired correctly when expected. Bug: 925297 Change-Id: I6f3c32d63d8950ea4fc17bb145a704e276ffd627 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1591619Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Mugdha Lakhani <nator@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Cr-Commit-Position: refs/heads/master@{#659135}
-
Stephen McGruer authored
Both these DCHECKs attempted to use <= on floating point numbers, and were failing on within epsilon equality. Bug: 962138 Change-Id: I005f9503b325b07401c95bec2b3620c0b1ac4a3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610145Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#659134}
-
Koji Ishii authored
This patch addresses review comment on crrev.com/c/1607719 by adding more comments. No behavior changes. Change-Id: I1362fd4dd18467eeb0e30aecb0e80c7cf9bd43cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609718Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#659133}
-
Yann Dago authored
Bug: 960101 Change-Id: I50e5332f85ee9078eae6b2d3aaecc23fd7f5c301 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1595454Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Yann Dago <ydago@chromium.org> Cr-Commit-Position: refs/heads/master@{#659132}
-
Madeleine Barowsky authored
This change skips long_running:tools:gmail-background, long_running:tools:gmail-foreground, and load:games:spychase:2018 on ChromeOS because they are failing. The whole system_health.memory_desktop suite is not running, and we hope disabling some flaky or long-running stories may bring it back. NOTRY=true TBR=perezju@chromium.org CC=cbruni@chromium.org,rnephew@chromium.org Bug: 959418 Change-Id: I8b500a6d8ed2d8ca07fca31d87728aea1c2867d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610084Reviewed-by:
Madeleine Barowsky <mbarowsky@chromium.org> Commit-Queue: Madeleine Barowsky <mbarowsky@chromium.org> Cr-Commit-Position: refs/heads/master@{#659131}
-
chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/6f8388801226..87bafc38b0d0 git log 6f8388801226..87bafc38b0d0 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 tsepez@chromium.org Rename CXFA_LayoutItem methods to match fxcrt::TreeNode. Created with: gclient setdep -r src/third_party/pdfium@87bafc38b0d0 The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=pdfium-deps-rolls@chromium.org Change-Id: Iab7e811ba0bd393ab3c1eba7b2363056518c2cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610439Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659130}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42db0b42abad..a04028c2e67b git log 42db0b42abad..a04028c2e67b --date=short --no-merges --format='%ad %ae %s' 2019-05-13 raul@tambre.ee Fix invalid Python file encoding "utf8" Created with: gclient setdep -r src/third_party/depot_tools@a04028c2e67b The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:962277 TBR=agable@chromium.org Change-Id: I26e77664220b9bd742ebe415c818edc46a2b4e36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610445Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659129}
-
danakj authored
BrowserTestBase decides to run ContentMain() or BrowserMain() based on the OS. On Android it uses BrowserMain() instead. When using BrowserMain() on Android, the test harness reimplements some of ContentMain() before calling BrowserMain(). This is done in the ContentBrowserTestSuite currently, but that can not be shared with chrome browser tests, which inherit ContentTestSuiteBase but not ContentBrowserTestSuite. To promote code sharing and move the logic to the same place where the ContentMain() decision is made, we move this setup code over to BrowserTestBase. While doing so, we update the code to more closely match what ContentMain() does. This makes Android existing browser test suites act more like desktop browser tests, which go through ContentMain() already: - Instead of hardcoding using ShellContentClient, we use the ContentMainDelegate to create the ContentClient (which will be a ShellContentClient in existing cases, but will differ in chrome browser tests). - Ordering is adjusted to match. - The ContentMainDelegate is used and called throughout the setup process the same way that ContentMain() would, including calls to ShouldCreateFeatureList(), PostFieldTrialInitialization(), PreCreateMainMessageLoop(), PostEarlyInitialization(), PostTaskSchedulerStart(), and BasicStartupComplete(). Using the ContentMainDelegate doesn't change existing behaviour for the most part though, as the ShellMainDelegate overrides largely set up for web test mode, which browser tests do not run in (content shell is run separately for that). The InitMessagePumpForUIFactory() call from ContentBrowserTestSuite must be made before the test suite is initialized, however, so it can not move to BrowserTestBase. Instead we put it in the JNI_Onload method of each browser test target. This ensures it is run first, and we DCHECK that it succeeded. In single process mode, we also must initialize a ContentRendererClient which was being done in ContentBrowserTest, so moved this up to the BrowserTestBase. R=avi@chromium.org Bug: 961849 Change-Id: Iefc105e3dc9f142774331aa97b0f1006bd701c0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1606424 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#659128}
-
Kyle Milka authored
The new styling should only apply to the new customization menu. Bug: 962353 Change-Id: I8f9ff9dc925a58c9403576c0d33b845d8673d523 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609601Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#659127}
-
Eric Willigers authored
Change-Id: I6917c4ad8ae90d797e87db6a5b9409f4ae54c8ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608963Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#659126}
-
Collin Baker authored
This flag was just for debugging so it is more appropriate as a command line switch. Also, this function is called in hot code, and feature flag queries are slow. A command line switch is safer to cache; tests are allowed to enable or disable feature flags on the fly, hence caching a feature flag lookup breaks this contract. This allows for caching the result without breaking expectations. Bug: 960913 Change-Id: Ibb9f9b7b7db7b9329984d71318c7488534e04f9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1600494Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#659125}
-
bsheedy authored
Refactors all the classes in //device/vr/windows_mixed_reality/wrappers/wmr_origins.h to inherit from an interface, and switches the mock versions to inherit from the same interface instead of subclassing the real versions. Also moves the static creation functions into factories in //device/vr/windows_mixed_reality/wrappers/wmr_wrapper_factories.h, which now guarantee that the mock and real classes can't be mixed together. Bug: 961020 Change-Id: I0928bcadc9d942bd6ea513c156c832ffcaf0433f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1603748Reviewed-by:
Bill Orr <billorr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#659124}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/f1e3609c24ce..e1de1ab33d7f git log f1e3609c24ce..e1de1ab33d7f --date=short --no-merges --format='%ad %ae %s' 2019-05-13 geofflang@chromium.org D3D: Store error message by std::string instead of const char*. Created with: gclient setdep -r src/third_party/angle@e1de1ab33d7f The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:962439 TBR=syoussefi@google.com Change-Id: I546638d3392c0bfa60b032cf2b1a26668c243aa8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610457Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659123}
-
Jeffrey Cohen authored
add utility functions to determine when to display the STTS UI Bug: 959475 Change-Id: I0318090e1b018bb4be874f967bbee0500dcff39b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1597909Reviewed-by:
Peter Lee <pkl@chromium.org> Reviewed-by:
sebsg <sebsg@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659122}
-
Scott Violet authored
BUG=958241 TEST=purely dead code removal Change-Id: If1235ea072f867a0cdbbbe09ece1586015e40d3f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1605163 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#659121}
-
Danan S authored
- Create WebUI - Add PostMessageAPI* and AddSupervisionAPI* JS classes for communication with web-content. - Added switch to control the feature: ChromeOSAddSupervision Bug: 937995 Change-Id: I1e65b1a899776b5aa9028921d028030d147baaec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1500832 Commit-Queue: Danan S <danan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Reviewed-by:
Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#659120}
-
Xida Chen authored
The TickAnimationsIf is not a member function and is used in the same file. In this case, it should be in the anonymous namespace. This CL doesn't introduce any behavior change. Bug: None Change-Id: I4cc3340335dfbd8b9c3b50765710d8c46bbda603 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1604110Reviewed-by:
Yi Gu <yigu@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#659119}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/a7a375565cdb..4a4c259fa148 git log a7a375565cdb..4a4c259fa148 --date=short --no-merges --format='%ad %ae %s' 2019-05-13 chrisforbes@google.com Implement vkCmdDispatchBase Created with: gclient setdep -r src/third_party/swiftshader@4a4c259fa148 The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:b/126871859 TBR=swiftshader-team+autoroll@google.com Change-Id: I961a358bead0389c8b405ac68ef6832867497688 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610458Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#659118}
-
Anastasia Helfinstein authored
TBR=katie@chromium.org Bug: None Change-Id: I2efb8d4ae5affe1653e4ac395cc33afeb5fac6cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610521Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#659117}
-
Abigail Klein authored
To test, open a video that has a WebVTT captions file. For example, https://www.iandevlin.com/html5test/webvtt/html5-video-webvtt-sample.html is a nice example. Introduce new background opacity text track property for webvtt captions and wire it to apply opacity to the WebVTT caption HTML element. Bug: 897730 Change-Id: Ic8dabc2279117b7ff12eb75a9daa8d26c9d9bb25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1592622 Commit-Queue: Abigail Klein <abigailbklein@google.com> Auto-Submit: Abigail Klein <abigailbklein@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#659116}
-
Sergey Ulanov authored
WebEngine needs to use CodecFactory interface in order to create HW video decoders, but CastRunner didn't have that service in the manifest, so the coresponding web context had to use SW decoder. Bug: Fuchsia: WEB-39 Change-Id: I9e943ef0cee06b96499992eaa1231f1021ea46b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1610518 Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#659115}
-
https://chromium-review.googlesource.com/1602732Nico Weber authored
It was added for that bug and is now no longer needed. Bug: 958955 Change-Id: Ib335d3946d158f566124dbf57ac5f328b14affc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1609879 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#659114}
-
Raphael Kubo da Costa authored
IWYU. size_t needs to come somewhere, so rather than indirectly including it via <utility>, explicitly include <stddef.h>. This fixes the libstdc++ build after commit 01ca125f ("[NTP] Define constants for max number of Most Visited and Custom Links"): In file included from ../../components/ntp_tiles/constants.cc:5: ../../components/ntp_tiles/constants.h:15:14: error: unknown type name 'size_t'; did you mean 'std::size_t'? extern const size_t kMaxNumCustomLinks; ^~~~~~ std::size_t ../../../../../../usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/x86_64-redhat-linux/bits/c++config.h:2182:26: note: 'std::size_t' declared here typedef __SIZE_TYPE__ size_t; ^ ../../components/ntp_tiles/constants.cc:9:7: error: unknown type name 'size_t'; did you mean 'std::size_t'? const size_t kMaxNumCustomLinks = 10; ^~~~~~ std::size_t ../../../../../../usr/bin/../lib/gcc/x86_64-redhat-linux/8/../../../../include/c++/8/x86_64-redhat-linux/bits/c++config.h:2182:26: note: 'std::size_t' declared here typedef __SIZE_TYPE__ size_t; ^ Bug: 957519 Change-Id: I347bef878b954779442a640213952432b329411c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1608744 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#659113}
-