GitLab

Revert of Disable tabmodel.UndoTabModelTest#testReverseOrderRestore (patchset #1 id:1 of https://codereview.chromium.org/2572753002/ )

Reason for revert:
Reenabling the test.

Original issue's description:
> Disable tabmodel.UndoTabModelTest#testReverseOrderRestore
>
> BUG=673729
> TBR=dfalcantara@chromium.org
>
> Committed: https://crrev.com/7eae967f8220868aa2ac64f04a1fb636f97c5aa2
> Cr-Commit-Position: refs/heads/master@{#438158}

TBR=nednguyen@google.com
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=673729

Review-Url: https://codereview.chromium.org/2570303002
Cr-Commit-Position: refs/heads/master@{#438506}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/041b58513c96..c78686903901

$ git log 041b58513..c78686903 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 perezju [Telemetry] Fix JavaScript interpolation in telemetry actions

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2574153002
Cr-Commit-Position: refs/heads/master@{#438505}

4836af (20 May 2016) to 222564 (02 Dec 2016)

BUG=641008

Review-Url: https://codereview.chromium.org/2537133002
Cr-Commit-Position: refs/heads/master@{#438504}

The DOMTimer's ScheduledAction hold on to the script source and
state needed to execute the timer action. Let go of ShceduledAction's
resource early.

Apart from reducing the lifetime of script source, this is a speculative
fix for crashes reported in v8::PersistentValueVector::Clear() during
lazy sweeping of ScheduledAction objects.

R=
BUG=

Committed: https://crrev.com/11bd50343795ed1dc1977da91e9a1588687522fd
Review-Url: https://codereview.chromium.org/2552673002
Cr-Original-Commit-Position: refs/heads/master@{#436298}
Cr-Commit-Position: refs/heads/master@{#438503}

When computing the baseline position of inline-block elements we use the
InlineFlow logicalTop and the FontMetrics ascent. The issue comes from
the fact that these units are incompatible. The logicalTop of a
vertical-lr element is offset to the left edge, while the ascent is the
distance from the right edge.

We need to either use logical value for the FontMetrics ascent so we can
compute the correctly the baselines of vertical-lr elements, or just using
the logicalBottom for these cases.

The approach based on a logicalAscent API for FontMetrics would require
a lot of work because inline-block logic assumes everything is vertical-rl
and at some point, flips the elements along the block-axis in case of
vertical-lr mode.

While it'd be desirable to get rid of this flipping logic, this patch tries
first the simpler approach of using logicalBottom, which aligns with the
currently implemented logic.

BUG=664386

Review-Url: https://codereview.chromium.org/2523573003
Cr-Commit-Position: refs/heads/master@{#438502}

The agent used to have separate unittests that verified that the right values
were recorded into histograms. To reduce duplication, this CL merges these
tests into the corresponding tests that verify basic functionality.

BUG=637415

Review-Url: https://codereview.chromium.org/2573093002
Cr-Commit-Position: refs/heads/master@{#438501}

Most links redirected to the right location, some were found manually.

In IDL files, links remain in modules/mediasource/TrackDefault.idl which
is gone from the spec and modules/speech/*.idl, which is still
maintained at dvcs.w3.org

BUG=673852
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2573043002
Cr-Commit-Position: refs/heads/master@{#438500}

https://skia.googlesource.com/skia.git/+log/24f19780d1e7..d316e77c1e19

$ git log 24f19780d..d316e77c1 --date=short --no-merges --format='%ad %ae %s'
2016-12-14 robertphillips Revert "Add a deferred copy surface (take 2)"
2016-12-14 mtklein Revert "clamp to premul when reading premul sRGB"
2016-12-14 mtklein Revert "SkNx basically always is fast now."
2016-12-14 mtklein Revert "Do not build the ktx encoder for android framework"
2016-12-13 jvanverth Fix SDF generation for pixel-aligned paths (take two)
2016-12-13 scroggo Do not build the ktx encoder for android framework
2016-12-13 mtklein clamp to premul when reading premul sRGB
2016-12-13 mtklein SkNx basically always is fast now.
2016-12-13 robertphillips Add a deferred copy surface (take 2)

BUG=668550

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=msarett@google.com

Review-Url: https://codereview.chromium.org/2572103002
Cr-Commit-Position: refs/heads/master@{#438499}

Made the following arguments / attributes nullable to match the spec.

BUG=662005

Review-Url: https://codereview.chromium.org/2569993003
Cr-Commit-Position: refs/heads/master@{#438498}

The proposed specification has the BudgetState interface exposed to
Workers. This brings the implementation in sync with that spec.

This also expands the interface tests to validate that the interface is
exposed.

BUG=672111

Review-Url: https://codereview.chromium.org/2578513002
Cr-Commit-Position: refs/heads/master@{#438497}

This is a speculative fix for a performance regression on Android.

BUG=673754

Review-Url: https://codereview.chromium.org/2576563003
Cr-Commit-Position: refs/heads/master@{#438496}

This plugs the ExternalBeginFrameSource provided by
WindowCompositorFrameSink into the browser's cc::Display, effectively
enabling unified BeginFrames for the browser client.

BUG=580357

Review-Url: https://codereview.chromium.org/2568783002
Cr-Commit-Position: refs/heads/master@{#438495}

Adds a new command to cachetool called "list_dups". It md5sums the response
bodies in the cache and prints out any duplicates along with their mime-type
and number of bytes. This is useful for helping to explore the possible
benefits to content-addressable caching.

BUG=665548

Review-Url: https://codereview.chromium.org/2421583002
Cr-Commit-Position: refs/heads/master@{#438494}

The adapter could change at any time during an animation, so we get the
adapter position from the ViewHolder at the end of the animation.

Also, add an upper bound check to InnerNode.getChildIndexForPosition()
to complement the lower bound check, to get more direct stack traces in
cases like this.

BUG=673709

Review-Url: https://codereview.chromium.org/2573053002
Cr-Commit-Position: refs/heads/master@{#438493}

This patch introduces a new class IdleSpellCheckCallback for implementing
most of the idle time spell checker. The new class currently has only a
skeleton implementing the state machine as specified in the design doc.

It does not contain any real spell checking logic, and is not exposed to
any other class, yet. Follow-up patches will do that.

Design doc: https://docs.google.com/document/d/1vo71cnlGOqOuXyy1zjzXSlUIjG7GsWgRjqmkrq1g5hk/edit?usp=sharing

BUG=517298

Review-Url: https://codereview.chromium.org/2578493002
Cr-Commit-Position: refs/heads/master@{#438492}

Follow up to crrev.com/2575033002
Given the flakyness it's safe to extend the disabling to all platforms
until the source of the flakiness is clarified.

BUG=658054

Review-Url: https://codereview.chromium.org/2573063002
Cr-Commit-Position: refs/heads/master@{#438491}

In order to keep the previous text formatting when continuing typing on the word,
confirming the ongoing composition, or inserting new text, this CL introduces
InsertIncrementalTextCommand for insertion. The command detects  what was
there already, and restricts the write to the character(s) that actually changed.
Note that this CL doesn't change the behavior of events, i.e., it still sends
'beforeinput', 'input', and 'textInput' events with the entire text.

BUG=620549

Review-Url: https://codereview.chromium.org/2530843003
Cr-Commit-Position: refs/heads/master@{#438490}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/21cc02a8..dbb28119

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2574113002
Cr-Commit-Position: refs/heads/master@{#438489}

Changes: https://chromium.googlesource.com/external/webrtc/trunk/webrtc.git/+log/f23e926..2410df4

$ git log f23e926..2410df4 --date=short --no-merges --format=%ad %ae %s
2016-12-14 ivoc@webrtc.org Fix for left shift of negative value in NetEq.
2016-12-14 nisse@webrtc.org Delete method Pathname::url and base/urlencode*
2016-12-14 skvlad@webrtc.org Disable flaky test VideoProcessorIntegrationTest.ProcessNoLossChangeFrameRateFrameDropVP9
2016-12-14 peah@webrtc.org This CL adds the basic framework for AEC3 in the audio processing module. It will be followed by a number of other CLs that extends this framework.
2016-12-14 nisse@webrtc.org Delete unused class rtc::RegKey.
2016-12-14 nisse@webrtc.org Delete stl_util.h. Unused since cl https://codereview.webrtc.org/2447103002
2016-12-14 nisse@webrtc.org Revert of Delete rtc::linked_ptr. Only use, in statstypes.h, replaced bu std::unique_ptr. (patchset #1 id:1 of https://codereview.webrtc.org/2567143003/ )
2016-12-13 nisse@webrtc.org Delete rtc::linked_ptr. Only use, in statstypes.h, replaced with std::unique_ptr.
2016-12-14 kjellander@webrtc.org Disable AudioDeviceTest.StartPlayoutOnTwoInstances on iOS
2016-12-13 deadbeef@webrtc.org Fixing possible crash due to RefCountedChannel assignment operator.
2016-12-13 deadbeef@webrtc.org Fixing integer overflow when parsing bandwidth attribute.
2016-12-13 gyzhou@chromium.org Support external audio mixer in webrtc 2.
2016-12-13 deadbeef@webrtc.org Removing "crypto_required" from MediaContentDescription.
2016-12-13 hnsl@webrtc.org ParseCandidate(): Refactor to fix memcheck false positive. Also make supported protocols explicit in check.
2016-12-13 minyue@webrtc.org Update common_audio/smoothing_filter.
2016-12-13 nisse@webrtc.org Delete VideoFrame default constructor, and IsZeroSize method.
2016-12-13 kthelgason@webrtc.org Disable flaky QualityScaler tests for now.
2016-12-13 hnsl@webrtc.org Refactor "secure bool" into explicit PROTO_TLS.
2016-12-13 thomasanderson@google.com Add a gtk3 port of peerconnection_client on Linux
2016-12-13 palmkvist@webrtc.org Logging basic bad call detection
2016-12-13 hbos@webrtc.org Revert of New PeerConnectionInterface::GetStats: No bogus default implementation. (patchset #1 id:1 of https://codereview.webrtc.org/2566143002/ )
2016-12-13 johan@webrtc.org Rename RtpStreamReceiver::SetCodec() to ::AddCodec().
2016-12-13 hbos@webrtc.org New PeerConnectionInterface::GetStats: No bogus default implementation.
2016-12-13 ivoc@webrtc.org Fix for negative shift value in NetEq.
2016-12-12 nisse@webrtc.org Delete unused class AsyncFile.
2016-12-12 deadbeef@webrtc.org Don't allow changing ICE pool size after SetLocalDescription.
2016-12-12 deadbeef@webrtc.org Implement parsing/serialization of a=bundle-only.
2016-12-12 gyzhou@chromium.org Revert of Support external audio mixer. (patchset #5 id:140001 of https://codereview.webrtc.org/2539213003/ )
2016-12-12 gyzhou@chromium.org Support external audio mixer in webrtc.
2016-12-12 minyue@webrtc.org Making audio network adaptor config proto a JAVA package.
2016-12-12 noahric@chromium.org Fix header guard in thread_annotations.h.
2016-12-12 noahric@chromium.org Destroy encoders that fail to InitEncode.
2016-12-12 deadbeef@webrtc.org Add SSRC to RtpEncodingParameters for audio.
2016-12-12 stefan@webrtc.org Add OWNERS to BWE modules.
2016-12-12 brandtr@webrtc.org Remove sequenced task checker from FlexfecSender.
2016-12-12 henrik.lundin@webrtc.org Delete voice_engine_configurations.h
2016-12-12 philipp.hancke@googlemail.com remove googViewLimitedResolution stat
2016-12-12 peah@webrtc.org Disabling the potentially flaky test VideoProcessorIntegrationTest. ProcessNoLossSpatialResizeFrameDropVP9
2016-12-12 hnsl@webrtc.org Fix out of bound reads in ParseIceServerUrl() for various input.
2016-12-12 brandtr@webrtc.org Try to deflake VideoSendStream tests with ULPFEC.
2016-12-12 hbos@webrtc.org RTCIceCandidatePairStats.consentRequestsSent set by RTCStatsCollector and requestsSent is updated.
2016-12-12 nisse@webrtc.org Replace VideoCaptureDataCallback by VideoSinkInterface.
2016-12-12 kjellander@webrtc.org Change MANUAL -> DISABLED for ScreenCapturerIntegrationTest tests
2016-12-11 ssaroha@gmail.com Set OPENSSL_EC_NAMED_CURVE explicitly on EC key so that certificate has ASN1 OID and NIST curve info. Without this openSSL handshake negotiation fails throwing NO_SHARED_CIPHER error. the change made is along the lines of openssl behavior documented here: https://wiki.openssl.org/index.php/Elliptic_Curve_Diffie_Hellman#ECDH_and_Named_Curves
2016-12-11 minyue@webrtc.org Adding googAudioNetworkAdaptorConfig to MediaConstraintsInterface.
2016-12-10 deadbeef@webrtc.org Implement the "needs-ice-restart" logic for SetConfiguration.
2016-12-10 deadbeef@webrtc.org Adding error enum to be used by PeerConnectionInterface methods.
2016-12-09 zijiehe@chromium.org MANUAL tests of GDI capturers

TBR=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
BUG=

Review-Url: https://codereview.chromium.org/2575013002
Cr-Commit-Position: refs/heads/master@{#438488}

Until the driver is not signed with the proper Microsoft cert from
the WHQL program or Google's cert is added as a 'Tristed Publisher'
installation can not be performed unless the user confirms that they
trust the driver issuer.

BUG=629512
TEST=manual (see bug#127)

Review-Url: https://codereview.chromium.org/2577583003
Cr-Commit-Position: refs/heads/master@{#438487}

In this CL we incorporate MediaListDirective subsumption logic
into the main subsumption flow on CSPDirectiveLevel.

BUG=647588

Review-Url: https://codereview.chromium.org/2562953002
Cr-Commit-Position: refs/heads/master@{#438486}

When the page is going to be closed, loader() may return nullptr.
In MIDIAccess::sendMIDIData(), we refer the DocumentLoader without any
check, thus it results in a renderer crash though it rarely happens.

I had a report on a similar issue, but the specific code in the case was
already removed. This patch also fixes another potential problem that
may cause the same issue.

BUG=674005

Review-Url: https://codereview.chromium.org/2566223006
Cr-Commit-Position: refs/heads/master@{#438485}

In "advanced" constraints, naked values are to be treated as "exact".
In "basic" constraints, they should be treated as "ideal".

BUG=673734

Review-Url: https://codereview.chromium.org/2569233002
Cr-Commit-Position: refs/heads/master@{#438484}

TBR=primiano@chromium.org

BUG=658054

Review-Url: https://codereview.chromium.org/2575033002
Cr-Commit-Position: refs/heads/master@{#438483}

They were only supported in chrome://snippets-internals, and are now
removed there too.

Note that, if a user somehow manages to issue an interactive request
before the snippets service reports itself as ready, we schedule a
request for later, which will be marked as non-interactive.

BUG=648567
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2570673004
Cr-Commit-Position: refs/heads/master@{#438482}

In some rare cases pref_change_registrar_ do not unsubscribed during the
test body, resulting unsubscribe-on-destruction, but at time of test's
class dtor execution pref_service was already destroyed.
With this CL prefs_registrar lifespan will not exeed pref_service's.

BUG=

R=dbeam@chromium.org, stevenjb@chromium.org

Review-Url: https://codereview.chromium.org/2569083003
Cr-Commit-Position: refs/heads/master@{#438481}

OfflinePageProxy class has need removed, but a mention of it in a
comment remained. This CL removes it completely.

BUG=672432

Review-Url: https://codereview.chromium.org/2575793002
Cr-Commit-Position: refs/heads/master@{#438480}

Removed a DCHECK which was being hit. The code should recover from the
condition without issues. Added a TODO to investigate why the code is
able to reach this point without SUCCESSFUL_CONNECTION being set.

BUG=673706

Review-Url: https://codereview.chromium.org/2567373002
Cr-Commit-Position: refs/heads/master@{#438479}

This is in preparation for Android and Mus to provide a BeginFrameSource
that is owned further up in the object hierarchy (e.g. by WindowAndroid
/ WindowCompositorFrameSink).

BUG=401336,580357
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2565783002
Cr-Commit-Position: refs/heads/master@{#438478}

[Command buffer]: Generate INVALID_OPERATION if designated attachments in read fb miss image during blitting

BUG=672719
TEST=conformance2/rendering/read-draw-when-missing-image.html

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2570823002
Cr-Commit-Position: refs/heads/master@{#438477}

BUG=673163

Review-Url: https://codereview.chromium.org/2572813003
Cr-Commit-Position: refs/heads/master@{#438476}

NavigatorServiceWorker needs to reset m_serviceWorker when the context
gets destroyed. This CL makes ServiceWorkerContainer do the reset work
and removes ContextLifecycleObserver from NavigatorServiceWorker.

See the discussion on the CL for more rationale.

BUG=610176

Review-Url: https://codereview.chromium.org/2556893003
Cr-Commit-Position: refs/heads/master@{#438475}

These metrics suffer from that they count the number of bytes since
the beginning of the call, and average them during the 10-second
measuring window after 60-seconds of warmup. This means that if there's
any variance in the warmup period or the call gets established a little
earlier or later, it will have a big impact on the numbers.

I think we can just delete them. An alternative approach is to
do like in https://codereview.chromium.org/2545553003 and subtract the
count at the beginning of the measuring window, which means we
effectively measure the bitrate during the measuring window. That's
covered by the test added in that patch though, only it's going through
the new stats API instead of the old one.So, let's just delete them
from the old API for now.

BUG=666725
CC=ehmaldonado@chromium.org
R=kjellander@chromium.org

Review-Url: https://codereview.chromium.org/2568133006
Cr-Commit-Position: refs/heads/master@{#438474}

Replace net::FileStream with base::File for finer errno handling.

BUG=671510
TEST=unit_tests

Review-Url: https://codereview.chromium.org/2551913004
Cr-Commit-Position: refs/heads/master@{#438473}

Move the popular sites factory next to it.

Currently PopularSites is explicitly not enabled (not even instantiated)
on desktop. We could in theory create it and let the field trial decide
whether to show tiles from it, but it really needs some work first for a
world where we use thumbnails instead of icons. Also, Desktop has its
own, separate mechanism for displaying default tiles baked into
TopSites.

BUG=655622

Review-Url: https://codereview.chromium.org/2572533002
Cr-Commit-Position: refs/heads/master@{#438472}

This will enable more parts of Chromium to use PA, and will make it easier for things outside of Chromium (e.g. PDFium) to use PA.

This change is intended to be merely a move, and should not have significant performance impact.

This moves only the core of PA; higher API layers that Blink uses to call into PA remain in Blink.

BUG=632441
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2518253002
Cr-Commit-Position: refs/heads/master@{#438471}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/969e8394..21cc02a8

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,littledan@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2577553003
Cr-Commit-Position: refs/heads/master@{#438470}

Displayed origins of stored passwords are elided to fit the cell they are in.
The ellipsis needs to be applied from the left, because the most important
security information about the hostname are the top (right-most) parts of the
domain [1]. In the past this needed to be done by password_manager.js, because
changing the text direction in CSS to allow eliding from left left to issues
with screen readers.

This CL drops the JS code for computing the elided string, and instead specifies
the text direction for the hostname to be RTL. This applies the ellipsis from left,
while working as expected with the screen reader, and not interfering with the
text direction of the Chrome UI.

[1] https://www.chromium.org/Home/chromium-security/enamel#TOC-Eliding-Origin-Names-And-Hostnames

BUG=667130
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2567693002
Cr-Commit-Position: refs/heads/master@{#438469}

To move core/dependency so that core/fetch can be moved under
platform, move ImageResource, ImageResourceClient, and related classes
to core/loader/resource/.

After this patch, all dependencies from core/fetch to core/ will be
removed, and core/fetch gets ready to be moved under platform.

BUG=655920
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2558033002
Cr-Commit-Position: refs/heads/master@{#438468}

Both are conceptually same. So merge them into ArcSessionObserver.

BUG=657687
BUG=b/31079732
TEST=Ran bots.

Review-Url: https://codereview.chromium.org/2567083002
Cr-Commit-Position: refs/heads/master@{#438467}