- 31 Jul, 2020 40 commits
-
-
Numfor Mbiziwo-Tiapo authored
This change updates the existing putAll implementation to match the explainer more. It does not yet support the put-all-or-none behavior, but it does only return one request now. Design Doc: https://docs.google.com/document/d/1wawQ8Pl-Vi6GQN5-y2UVkcghipcOGg0WRAC0ZyBkezg/edit# Bug: https://bugs.chromium.org/p/chromium/issues/detail?id=1087927 Change-Id: I2c5e9d2d71801eaab3c1c9e94a3968afb8d109b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310110 Commit-Queue: Numfor Mbiziwo-tiapo <nums@google.com> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#793656}
-
Viktor Semeniuk authored
This change updates string according with the latest mocks. Bug: 1075494 Change-Id: Ief7e24cc8810895652ca893149370d36eb028c7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332619Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Cr-Commit-Position: refs/heads/master@{#793655}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/07ef703f1646..be774187b1ce 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 08a3cc4cfbaa to aa5bd7657e6c (3 revisions) 2020-07-31 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-ValidationLayers from 4400cab64b22 to 71573c7f64cb (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I39e17675a0262f30e79d1cda86dcf8bb6d6c1c5e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332551Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793654}
-
Viviane Yang authored
This CL enables Push Subscriptions to support a expiration time, set by Chrome in push_messaging_constants.h (currently 90 days). This feature is disabled by default, so to try it out you must set --enable-features= PushSubscriptionWithExpirationTime. 3 BrowserTests are added to check the expiration time behaviour when the flag is set or not set. The expiration time is set in PushMessagingServiceImpl when a subscription is made and saved by PushMessagingAppIdentifier in the browser preference. The following CLs prepare for this change: 1. 2292292: [Push] Add expirationTime attribute to PushSubscription https://chromium-review.googlesource.com/c/chromium/src/+/2292292 2. 2302192: [Push] Pass expirationTime attribute from PushMessagingService to PushManager https://chromium-review.googlesource.com/c/chromium/src/+/2302192 3. 2315682: [Push] Add expiration time property in app identifier https://chromium-review.googlesource.com/c/chromium/src/+/2315682 Bug: 1104215 Change-Id: I341f05096fa57246fa18cb338a1a59f7a1ae01ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302610Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Reviewed-by:
Rayan Kanso <rayankans@chromium.org> Commit-Queue: Viviane Yang <viviy@google.com> Cr-Commit-Position: refs/heads/master@{#793653}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/bf47d2ef673b..de0ed93bda63 2020-07-31 mmortensen@google.com BuildAPI: Improve exception processing in service.UnmountPath. 2020-07-31 vapier@chromium.org licensing: add ustreamer to Google-TOS list 2020-07-31 tcwang@google.com toolchain: Cleanup tmp directory for artifact during prepare If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: I3510835f6d40a8e56e78696925ca442749f9bd3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331917Reviewed-by:
-
Himanshu Jaju authored
- Implements mutual accept alarm - Address other small TODOs Bug: 1085068 Change-Id: I1f13e2e766f12e29cb69dde291e8b8098207e0d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332178Reviewed-by:
-
ckitagawa authored
Link rects were previously recorded in a naive way that failed to account for the overall transformation matrix that needs to be applied to the rect. This CL rectifies that behavior by relying on Annotations in the PaintOpBuffer and tracking transforms while walking the buffer. A similar fix for subframe rects might be needed (in a follow-up CL). Bug: 1110227 Change-Id: I73cca7e4e398d724731f091c68910066d7b91785 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327251 Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Cr-Commit-Position: refs/heads/master@{#793650}
-
Danil Chapovalov authored
To be more sure it is safe to use absl::variant in chromium Abseil already uses EXPECT_DEATH_IF_SUPPORTED instead of EXPECT_DEATH thus the only blocker for these test was already resolved. Bug: 1073011 Change-Id: I3103fd558253aa80d6e770bd2cbf29840a5f768c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332439Reviewed-by:
Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#793649}
-
Alex Rudenko authored
When we position the labels using absolute coordinates we don't need to subtract the first track position for the subsequent track positions. Bug: 1106681 Change-Id: I0c6f11d9c9277d5911af3cc3ef642f6868e56827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332256 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#793648}
-
John Chen authored
Fix a typo that causes sizes.py to fail on Mac. Bug: 1097180 Change-Id: I5d375aa25d6fe9925b889bbd3ea7b061bd0f7473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330823 Auto-Submit: John Chen <johnchen@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Cr-Commit-Position: refs/heads/master@{#793647}
-
Tim Volodine authored
Flaky on Lollipop Phone Tester BUG=1111816 NOTRY=true TBR=skyostil@chromium.org Change-Id: Ia1176f4ec57495aaef0dfd107a494c940a533b92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332621Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#793646}
-
Sean McAllister authored
This migrates is_linux (which is also set for chromeos) to explicitly include chromeos as is_linux || is_chromeos in preparation for separating those flags. Bug: 1110266 Change-Id: I51be3638dab55a4b2bc933a1bb48ace81be51761 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326291Reviewed-by:
Bill Budge <bbudge@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Sean McAllister <smcallis@google.com> Cr-Commit-Position: refs/heads/master@{#793645}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1596185080-c872132dd1db16f5ff75ea8e09512987a9ceadc2.profdata to chrome-win32-master-1596192746-6fea58b93463f5fc9ccbb164a8054cb0a38af6db.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I1bdaff1048622448eaf6536769697276d3cae664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332553Reviewed-by:
-
Sebastien Marchand authored
This finishes the LocalDB migration to PerformanceManager. This migration has been done by copying the code and now that the migration is done it's also time to remove the previous version (it's hard to keep both versions at the same time and to then remove the old version in a later CL). Most of these files are owned by chrisha@, except for the following ones: wfh: chrome/browser/ui/webui/discards/site_data.mojom avi: chrome/browser/profiles/DEPS chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc chrome/browser/usb/usb_tab_helper_unittest.cc bcwhite: tools/metrics/histograms/histograms.xml Bug: 961336, 1089370, 1049469, 977554 Change-Id: Id11ea6204d402204dd1f36a013e54bb64e7973b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2251747Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#793643}
-
Olivier Li authored
This CL introduces the "OptOutZeroTimeoutTimersFromThrottling" which disables all types of throttling for Javascript timers whose timeout is zero. Why is this needed? ------------------- A page may use setTimeout(..., 0) to post continuation tasks, which improves main thread responsiveness by breaking down a long task into multiple shorter tasks. For example, a page could receive a chat message in a XHR handler and play a sound to notify the user in a continuation task. If intensive throttling is enabled and all timer tasks are throttled, irrespective of their delay, the continuation task is delayed by up to 1 minute. If throttling is disabled when the timeout is zero, the continuation task can run immediately. This doesn't increase the number of idle wake ups, as the continuation task is posted and runs within the same wake up (almost - see https://crbug.com/402694). Implementation: --------------- The TaskType kJavascriptTimer is split into two TaskTypes: kJavascriptTimerDelayed and kJavascriptTimerImmediate. DOMTimer selects the appropriate TaskType depending on the timeout computed by the algorithm at https://html.spec.whatwg.org/multipage/timers-and-user-prompts.html kJavascriptTimerDelayed is for timers with timeout > 0 (either because the argument is > 0 or the nesting level > 5) kJavascriptTimerImmediate is for timers with timeout == 0 (the argument is <= 0 and the nesting level is <= 5) FrameSchedulerImpl uses the "can be throttled" queue trait when selecting a TaskQueue for kJavascriptTimerDelayed, but not when selecting a TaskQueue for kJavascriptTimerImmediate. Alternative implementation: --------------------------- It is possible to implement this without introducing a new TaskType, by having a TaskRunner that selects the TaskQueue at post time depending on the delay. However, this means that the assumption that there is a 1:1 mapping between TaskType and TaskQueue is broken (what should FrameSchedulerImpl::GetTaskQueue(TaskType::kJavascriptTaskRunner) return?). Also, DOMTimer currently rounds up a 0ms delay to 1ms, making it harder for the TaskRunner to determine whether a task is immediate or not. See alternative implementation: http://crrev.com/c/2304155. Bug: 1075553 Change-Id: I6e61b535f7377755ed002b69e6a93dabd6c6e795 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305111 Commit-Queue: Oliver Li <olivierli@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Scott Haseley <shaseley@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#793642}
-
Changwan Ryu authored
This helps debug ProxyView behavior by providng more detailed information about window focus. Bug: 1108237 Change-Id: Ibcbdf7e0751b78d9cd0d52f1abf2edcc4bd23849 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332036Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Changwan Ryu <changwan@chromium.org> Cr-Commit-Position: refs/heads/master@{#793641}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/03677716c86d..3186e69eb799 2020-07-31 jacktfranklin@chromium.org Component bridges: export the generated class 2020-07-31 pfaffe@chromium.org [eslint] Ensure that linting doesn't crash on a custom it.skip 2020-07-31 sadym@chromium.org Allow simulating Idle Detection in the Sensors tab 2020-07-31 janscheffler@chromium.org Migrate `front_end/changes` to `devtools_entrypoint` 2020-07-31 petermarshall@chromium.org tests: Use source maps for better error output for e2e tests If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1090802,chromium:1101738,chromium:1104096 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie63690a06288e08e8955545cecdfe10e7e2c50f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332555Reviewed-by:
-
Richard Knoll authored
This implements success and failure notifications and adds the optional token to connection request notifications. Bug: 1102348 Change-Id: Ie2509d23f399a9a905a79100732697b3608563ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327490 Commit-Queue: Richard Knoll <knollr@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
James Vecore <vecore@google.com> Cr-Commit-Position: refs/heads/master@{#793639}
-
Hans Wennborg authored
LLD will sort the binary section based on a call-graph profile when such profile information is available in the object files. Since the last Clang roll, that information gets written to the object files when building with a profile (as is done on Android). Since call-graph sorting leads to larger binaries on Android, and we already have good section order files there, tell the linker to disable it. Bug: 1110413, 1107461 Change-Id: I4f37c57dd65437c4269b0e216f64102ae233aeeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332398Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#793638}
-
Samuel Huang authored
This fixes merge failure for build/config/BUILDCONFIG.gn. Change-Id: I7c4a1709835b2b04e79f5751abd9341848027791 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331294Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Samuel Huang <huangs@chromium.org> Cr-Commit-Position: refs/heads/master@{#793637}
-
Travis Skare authored
Add user actions for page vs. image context menu. Bug: 1106111 Change-Id: I95f99f9835b22336371a7c1f4da49c0faef28013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320419Reviewed-by:
-
Leonard Grey authored
This is a first draft of a command source that handles basic Chromium commands independent of actual content (like tabs, windows, bookmarks, etc.) The purpose for now is just to provide something that can be interacted with when the view layer is added. Accordingly, commands have been chosen on the basis of: it's something we would like to implement and it has a cross-platform translation that works for this context. (NB: I didn't try particularly hard to find all of these) There's also a stubbed out fuzzy finder which is not fuzzy in the least at the moment. Bug: 1014639 Change-Id: I08282aed82ba9fb1c62e592088e774a02479142e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327820 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#793635}
-
Sophey Dong authored
Bug: 1079467 Change-Id: I44219c4ff69ffeafaac048784e90dc372a043794 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330301Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Sophey Dong <sophey@chromium.org> Cr-Commit-Position: refs/heads/master@{#793634}
-
Viktor Semeniuk authored
This change fixes Password Check section after loading indicator was added to the Passwords screen. Now password check section reflects actual status of the Check on creation instead of disabled state. Bug: 1075494 Change-Id: I902b97448f358552df7dcf88370a8d8a824ff66b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2326230Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
-
Jonathan Ross authored
This test has begun flaking since an Angle roll landed: https://chromium-review.googlesource.com/c/chromium/src/+/2330032/2 This change marks it as retry while the Angle team looks to revert the cause. TBR=ynovikov@chromium.org TEST=webgl_conformance_vulkan_passthrough_tests on Intel GPU conformance/context/context-size-change.htm Bug: 1111652 Change-Id: I78b442589af66fac14ebe6bdf1002d4e5f15d607 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332836Reviewed-by:
Jonathan Ross <jonross@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#793632}
-
Jeffrey Young authored
BUG=None TEST=None Change-Id: I43e5195637cd82d5843fd2af445f90d5f4870e27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327511 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#793631}
-
Dave Tapuska authored
We need to call into the gpu factories and assign the rendering color space so the easiest way to do that is add a new method to the platform object. BUG=1097816 Change-Id: I68e5c279b3b9d923a2e77af050b92e74c578230d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316825 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
-
Peter Kasting authored
* Improve comments * Make DEPS block "third_party/abseil-cpp" and "absl" both * Update formal "allowed on" date to date this lands * Remove visibility restrictions Bug: 1096380 Change-Id: I10f615cfd02c397a988f73e4548cdf2309b44b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327638 Commit-Queue: Peter Kasting <pkasting@chromium.org> Reviewed-by:
-
Matt Menke authored
With the removal of Link Doctor, it's no longer being used. Bug: 1030281 Change-Id: Idc3151dc439d9bba88455a8e109214f4b67f4cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2324505Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#793628}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/fc8ba49c06f7..4470ba1491e5 2020-07-31 skia-autoroll@skia-public.iam.gserviceaccount.com Roll skcms from 8da4cb002cb4 to b1f9041ffe31 (1 revision) 2020-07-31 ethannicholas@google.com SkSL include files are now stored in a binary format 2020-07-31 bsalomon@google.com Add option to LazyYUVImage to build mip maps If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: Ie09c8adc6acec1e47f4360dd13074d1d8ea050e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332552Reviewed-by:
-
Thomas Nguyen authored
For view-source file scheme URL, clicking on omnibox will inject back file:/// in the middle, which is inconsistent with https behavior. This CL will not elide the file scheme in this case. Bug: 1096066 Change-Id: I99bde8e868fd3799386da7920c7cf79303b30968 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2323337 Commit-Queue: Eric Lawrence [MSFT] <ericlaw@microsoft.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Auto-Submit: Thomas Nguyen <haitung.nguyen@avast.com> Cr-Commit-Position: refs/heads/master@{#793626}
-
chromium-autoroll authored
Roll ChromeOS Orderfiles from 86-4181.3-1594638142-benchmark-86.0.4205.0-r1 to 86-4183.39-1595842708-benchmark-86.0.4208.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I19b1f1a9dc9ae92ea3782182d3dc3fc5fc815650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331918Reviewed-by:
-
Liviu Tinta authored
The study name is the same as the Finch experiment here: https://critique-ng.corp.google.com/cl/323785153 Bug: 1098466 Change-Id: I86a3ad6f35bf3cf0e099d3b13c7815b6fca9dd02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2329934 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:
-
Marc Treib authored
It was used by the UssMigrator which was deleted a few months ago. Bug: 1084499 Change-Id: I792e2493aed494229a0b0c6c3cdd34892630a2e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332175 Commit-Queue: Rushan Suleymanov <rushans@google.com> Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#793623}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/01ef15ed..2a2392d4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I2fadaf3525edf01e4e9d8e6dceed16472c2f1831 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2331861Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#793622}
-
adamta authored
Ensures that label and menu button don't surpass Discover feed cards in Bling NTP. Mulder team recommends hardcoding a value since they can't easily expose the card content width. Bug: 1109685, 1085419 Change-Id: I2458a48464625d58009317cef3e4fc4ffc3453df Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325378 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#793621}
-
Matthias Körber authored
Disabled test due to a P1 flakiness bug. TBR: twellington@chromium.org Bug: 1111655 Change-Id: I772ff68d69dfc415cff8945ac8c514d4ad877a74 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332159Reviewed-by:
Matthias Körber <koerber@google.com> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#793620}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/f6c424bb5923..4766bd88cf78 2020-07-31 fmayer@google.com Merge "Remove HeapGraph.type_names." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia869b98520c9b1b3e6b247fdfd7a0e4b22c4a74a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2332548Reviewed-by:
-
Benjamin Beaudry authored
This change adds the containing block offset inside NGPhysicalOutOfFlowPositionedNode and NGLogicalOutOfFlowPositionedNode. This is part of the work for handling layout of positioned elements at the fragmentainer level rather than at the containing block level. A follow-up change will make use of this offset to compute where the layout of an OOF positioned node should start in a multicolumn context. Bug: 1079031 Change-Id: I2e3370a4ec0a4011203d0c3e916a64584aceaa2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2321405 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#793618}
-
Jeffrey Young authored
Add new UMA Ash.Assistant.AnimationSmoothness.ResizeAssistantPageView to be used in animation smoothness tast tests. BUG=b:161888779,b:161700638 TEST=open launcher, press assistant key, view chrome://histograms TEST=press assistant key, search "weather" view chrome://histograms Change-Id: Idef3e07e9ca13ce34e26727d82fc05e1b6512a43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314236 Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#793617}
-
