GitLab

This CL migrates socket_dispatcher_host.h to use NetworkChangeObserver.
More details are in the following bug

Bug: 780470
Change-Id: If48f749c81272d32bfcee84ea5f5b5639157f5a0
Reviewed-on: https://chromium-review.googlesource.com/754765Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517154}

This CL updates the following parameters.
  Position of the buttons
  Background color
  Buttons colors
  The gap between the text and the icon
  Position of the audio prompt

Bug: 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I9fe0f6037333c1fb3c19111157999c151faffec4
Reviewed-on: https://chromium-review.googlesource.com/772403Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Amirhossein Simjour <asimjour@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517153}

Control Flow Integrity [1] indirect call (cfi-icall) checking can not
verify that dynamically resolved function pointers call their intended
function. Instead we place the LibcFunctions pointers in
ProtectedMemory, a wrapper for keeping variables in read-only memory
except for when they are initialized.  After setting the pointers in
protected memory we can use the UnsanitizedCfiCall wrapper to disable
cfi-icall checking when calling them since we know they can not be
tampered with.

[1] https://www.chromium.org/developers/testing/control-flow-integrity

Bug: 771365
Change-Id: Ib74faff066e1107293b67d11f2a1a054bbff08b5
Reviewed-on: https://chromium-review.googlesource.com/769853Reviewed-by: Chris Palmer <palmer@chromium.org>
Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org>
Reviewed-by: Peter Collingbourne <pcc@chromium.org>
Commit-Queue: Peter Collingbourne <pcc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517152}

The ExtensionFrameHelper already has logic to find extension frames
matching certain criteria, which is used by custom bindings to return
the global objects for those frames. Move the logic to get the v8
global objects from the custom bindings to the ExtensionFrameHelper in
order to allow re-use with other bindings.

Bug: 653596

Change-Id: Ibb7d57e90bdb83cd574a95eb80db222456dd3e79
Reviewed-on: https://chromium-review.googlesource.com/763572
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517151}

https://webrtc.googlesource.com/src.git/+log/8b64fd8a85c1..8d9c5406c7ba

$ git log 8b64fd8a8..8d9c5406c --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I69affadf2b7890f11fdc4995249ec2bb97637d64
Reviewed-on: https://chromium-review.googlesource.com/775318Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517150}

Bug: 771028
Change-Id: I323d63f4f7b845a4d2588b385c18e673c47257e3
Reviewed-on: https://chromium-review.googlesource.com/767656Reviewed-by: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Nathan Parker <nparker@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517149}

Expanded the existing model of calling NoNotify methods, and changed
some sync only methods to return a bool representing whether a change
was made to the local data or not. RemoveNoNotify does not currently
expose if a change was actually made, so we assume that one was, fixing
this was out of scope. This allowed the sync methods (apply and merge)
to track if any changes were made, and invoke a single NotifyObservers
after all local changes had been applied.

As made evident by the unit tests, there's some complexity around
changing the default search engine that may still result in more than
one notification call.

Bug: 775049
Change-Id: Ie0b3080a60852f6cc09704feb4de8f850386353b
Reviewed-on: https://chromium-review.googlesource.com/745521Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517148}

This CL does some micro cleanups in VaapiVideoDecodeAccelerator:

- removes the member |num_input_buffers_|, which is use for TRACEing
only, and uses instead |input_buffers.size()|.  This is a change in
behaviour, since now we would also count the Flush-type InputBuffers,
but I think the change is justified since it's just for TRACEing
and they are, after all, InputBuffers as well.

  With the same logic s/Stream buffers at decoder/Input buffers/
at the TRACE_COUNTER1 statements.

- Rewrites the logic in GetInputBuffer_Locked() to avoid deep
condition layers, using instead early return.

- Rewrites Reset() to have less lines.

- Removes one of two consecutive empty lines.

- Simplifies CreateSurface() return statement.

Except for the |num_input_buffers_|, **there should be no new code**.

Nonetheless:
TEST=compiled-ran video_decode_accelerator_unittests on soraka,
all passing w/ same perf numbers. Ran standard VP9 playback,
all good as on ToT.

Bug: 717265
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id96d63f3245c04008927f94daf3ae05d48be9bbd
Reviewed-on: https://chromium-review.googlesource.com/774998
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517147}

Chrome security is trending away from showing the URL scheme, to an
icon-based representation. To support that, we should return to showing
the info icon if there is no other state (either secure or dangerous).

BUG=778411
R=bshe

Change-Id: Ic6ec0af9ff628bcacab55484a7e584339e59528f
Reviewed-on: https://chromium-review.googlesource.com/773119Reviewed-by: Biao She <bshe@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517146}

Test incorrectly called beRejected with an argument.  It should have
used beRejectedWith.  But the error was also incorrectly set to
TypeError when it should have been DataCloneError according to the
spec.

Bug: 785359
Test: decodeAudioData/decode-audio-data-neuter.html
Change-Id: I31be85867c2e792d1b79ec63105aadcf8f98dea7
Reviewed-on: https://chromium-review.googlesource.com/772353Reviewed-by: Hongchan Choi <hongchan@chromium.org>
Commit-Queue: Raymond Toy <rtoy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517145}

https://skia.googlesource.com/skia.git/+log/24f9c19172e1..5627d65146cb

$ git log 24f9c1917..5627d6514 --date=short --no-merges --format='%ad %ae %s'
2017-11-16 bsalomon Add method to sk_gpu_test::TestContext to automatically restore the previous context.
2017-11-15 reed remove legacy Create from SkTextBlob

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=brianosman@chromium.org

Change-Id: Ib7ef715dab844f58982e7b08bde43d30e70330cd
Reviewed-on: https://chromium-review.googlesource.com/775046Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517144}

Bug: 637172
Change-Id: I1f700efd223ed7e8fe61067b1ac581723f7dbd59
Reviewed-on: https://chromium-review.googlesource.com/774458Reviewed-by: Antoine Labour <piman@chromium.org>
Commit-Queue: Dominic Battré <battre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517143}

There are two problems with ImeTest that seem to be caused by scrolling (caused
by calling methods in DOMUtils, such as clickNode(), on various elements):

- Various test cases in ImeTest are intermittently failing in startup
  (crbug.com/781174). I am unable to reproduce the problem or determine what's
  happening. Test output and screenshots taken upon failure seem to indicate
  that focus is somehow getting moved to the <textarea> element in the HTML file
  immediately after the first <input> element, instead of remaining on the
  <input>. I am hopeful that avoiding scrolling resolves this problem. At the
  very least, it will rule out a potential cause of the issue.

- In https://chromium-review.googlesource.com/c/chromium/src/+/740373, I
  attempted to land a change to the HTML file used by ImeTest to support a few
  new tests. The change made the webpage longer so more scrolling happens. In
  particular, a test failure results because single taps on two different
  elements are getting counted as a double tap, because scrolling is bringing
  the second element to the location of the first element (so the taps are now
  in the same location on screen, whereas before they were in different
  locations, and hence the taps weren't eligible to be interpreted as a
  double-tap.

  This issue *does* reproduce locally, and I have confirmed that avoiding
  scrolling fixes the issue.

This CL avoids scrolling in ImeTest by making the whole webpage fit on-screen.

Moving the elements closer together seems to make a click in
testKeyboardAppFinishesCompositionOnUnexpectedSelectionChange() get counted as a
double-click in some test runs (I had to compile a release build to test this),
so I'm also adding a call to Thread.sleep() in that test to avoid this problem.

Bug: 781174
Change-Id: I4982be105846b954e7495fee682fcfe988dd2155
Reviewed-on: https://chromium-review.googlesource.com/773105Reviewed-by: Changwan Ryu <changwan@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517142}

This runs a given gtest binary 2 tests at a time (with
--gtest_shuffle and --gtest_repeat to try to encourage both
orderings of the test), and reports on any pairs that fail.

Change-Id: I9f4f8698aa97988a18290a4a5e5561975aac9aad
Reviewed-on: https://chromium-review.googlesource.com/646851Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Commit-Queue: Scott Graham <scottmg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517141}

The CSS Containment spec explicitly states that containment has no
effect on elements with display:contents element for paint, layout and
others. Not stated for contain:style.

Check for style containment for counters even when LayoutObject is null.

Note that due to the bug reported in 766650, the added test passes even
without this code change.

Bug: 766650
Change-Id: I64082f52255d5d810ba803148a418edff5da66c8
Reviewed-on: https://chromium-review.googlesource.com/771830Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517140}

This race should have been more common but it only reproed on iPhone 7
hardware running iOS 11 with a release version of base_unittests.
Setting DCHECK_ALWAYS_ON to true would cause the bug to stop reproing.

Because the test task signalled its WaitableEvent at the beginning of
the task instead of at the end, it was possible for the function
holding |manager_started| to return before the task had a chance to
check it.

The fix here moves the signalling to the end of the task, ensuring that
|manager_started| is alive when it is checked by the test task.

BUG=784051

Change-Id: I1e88395bcc45b5390af0c75be806a0a7301e483e
Reviewed-on: https://chromium-review.googlesource.com/773299
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517139}

Bug: 785931
Change-Id: Id9a97a37985a9888efe2633d688a0818536b2d66
Reviewed-on: https://chromium-review.googlesource.com/774690
Commit-Queue: Chris Dalton <csmartdalton@chromium.org>
Reviewed-by: Robert Phillips <robertphillips@google.com>
Cr-Commit-Position: refs/heads/master@{#517138}

Even though they're failing on 5X webview and they're disabled on 5X,
there's a bug where 5X webview isn't matching the 5X test condition
(https://github.com/catapult-project/catapult/issues/4045).

TBR=ashleymarie@chromium.org
NOTRY=true

Bug: 784540
Change-Id: I100929183b15c1d84ff4e0cecddb15236644bb84
Reviewed-on: https://chromium-review.googlesource.com/775433Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517137}

Bug: 762018
Change-Id: I51b9890df2ec4cde768bd08f2e6d5ed54eca999a
Reviewed-on: https://chromium-review.googlesource.com/769737Reviewed-by: agrieve <agrieve@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Commit-Queue: Biao She <bshe@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517136}

This CL removes clean/ view controllers from Showcase.

Bug: 785925, 710662, 772186
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Iebce9f69b7776aa2755e46ec379d7245075a55a7
Reviewed-on: https://chromium-review.googlesource.com/774465
Commit-Queue: Mark Cogan <marq@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517135}

This change fixes two bugs with caching of media sinks and a potential
initialization race that could also affect the cache's performance.

The first fix is to allow network ID changes of network1->network2 to
cache sinks for network1 rather than only caching for
network1->disconnected/unknown.  The cache originally used the latter
logic because net::NetworkChangeNotifier broadcasts a disconnect between
any two network changes.  However, DiscoveryNetworkMonitor doesn't
necessarily forward this behavior to its observers because it actually
calculates the current network ID on every net::NetworkChangeNotifier
notification.  Not caching in the former case could account for some of
the cache's low utilization currently seen in metrics.

The second fix is to add CastMediaSinkServiceImpl as a
DiscoveryNetworkMonitor::Observer from the correct sequence so it
receives notifications on the correct sequence.  This in turn
exacerbates a race between the first network ID update and
CastMediaSinkServiceImpl's AddObserver call.  The race was therefore
also addressed in this change.

Bug: 782788, 782859
Change-Id: I064bd184508e66f1806e55dc5afe1eea907836ea
Reviewed-on: https://chromium-review.googlesource.com/760667
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517134}

NOTRY=true
TBR=junov@chromium.org

Bug: 785286
Change-Id: Ie6ea11ecb9a5ea4153da9aee124012ed9a5626bc
Reviewed-on: https://chromium-review.googlesource.com/771853
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517133}

Bug: 785435
Change-Id: I783aeedf9d67f4a8280d7770b9b276dbfab68b79
Reviewed-on: https://chromium-review.googlesource.com/772882
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517132}

This CL adds a metric to measure the time spent from URLRequest creation
and when Start() is called on it. The purpose is to measure time spent
in various resource handlers before sending the request out to the net
stack.

Bug: 779914
Change-Id: I8e462a7d9fb541de38589aeb926f81047a735d50
Reviewed-on: https://chromium-review.googlesource.com/771549
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517131}

Convert PrintTabHelper to directly track registration
with the observed WebState instead of relying on the
deprecated code in WebStateObserver.

Bug: 775684
Change-Id: I2788f302863f7f23bf35fab7a98a75ced00b17f1
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Reviewed-on: https://chromium-review.googlesource.com/768719
Commit-Queue: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517130}

This change is a precursor to a more extensive change where
ExternalAppLauncher API is changed to be asynchronous.

This simpler change is to call the decision handler in the implemention
of WKNavigateDelegate method
webView:decidePolicyForNavigationResponse:decisionHandler:
asynchronously on iOS 11 and up.

iOS 10 (and possible below) has a bug where JavaScript on the page would
not execute if the decision handler is called asynchronously.

This change is to make sure that there are no other unforeseen
issues with calling decision handler asynchronously on iOS 11.

Bug: 774736
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I7a6dfe637cb6be4ce5c7efe5824728b8f06b902a
Reviewed-on: https://chromium-review.googlesource.com/773570
Commit-Queue: Peter Lee <pkl@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517129}

gfx::Image object is not threadsafe, we process the image async to
avoid blocking UI thread but causes DCHECK error.  Now we explicity
transfer ownership of the object down to the callback.

BUG=None
TEST=running with DCHECK on and no error triggered after change.

Change-Id: I1b3f678ddd9a411c59328e67de44b4e5db7ae865
Reviewed-on: https://chromium-review.googlesource.com/764373
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517128}

This cl contains cleanup that was part of the forthcoming MD tab spinner
cl but has been separated out for clarity.

Bug: 602558
Change-Id: Ibb58e9283a379f818b4c65ab79ae2e278e13b387
Reviewed-on: https://chromium-review.googlesource.com/769238Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jayson Adams <shrike@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517127}

BUG=721888

Change-Id: I42ac9339a8091c683c6dce60a857f71e0a9be7b8
Reviewed-on: https://chromium-review.googlesource.com/773626Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517126}

This reverts commit 9a8baf49.

These bots don't have enough capacity to handle all net/ CLs, and
they've been blocking people from landing changes.

Bug: 712733
Change-Id: I270079658a22301553c998acff8ae2395d3e2fa3
Reviewed-on: https://chromium-review.googlesource.com/774958
Commit-Queue: Miriam Gershenson <mgersh@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517125}

Page almost idle signal is calculated from main thread task load and network
activity. This patch plumbs page almost idle signal to TabLoader to experiment
using this signal to schedule tab loading in SessionRestore. Currently,
SessionRestore uses timeout and onload as signals to start to load next tab. A
Finch Trial will be set up to experiment it.

BUG=749789, 778766

Change-Id: Id83b6decc1ade9d3377b5184f0c717ac24bebabb
Reviewed-on: https://chromium-review.googlesource.com/764569Reviewed-by: Zhen Wang <zhenw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: lpy <lpy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517124}

These tests were passing and just needed new expectations:
paint/overflow/fixed-background-scroll-window.html
fast/sub-pixel/repaint-subpixel-layer-in-subpixel-composited-layer.html
fast/sub-pixel/should-not-repaint-subpixel-composited-layer.html

Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls
Change-Id: I2fb8c49e3aa5d1ce054bcd2d63f5f19ef66d1caa
Reviewed-on: https://chromium-review.googlesource.com/772813Reviewed-by: Stefan Zager <szager@chromium.org>
Commit-Queue: Philip Rogers <pdr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517123}

Using wpt-import in Chromium 41d5cb07.
With Chromium commits locally applied on WPT:
23705631 "service worker: Upstream sandboxed iframe test to WPT."


Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/5343

Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
hongchan@chromium.org, rtoy@chromium.org:
  external/wpt/webaudio
kojii@chromium.org:
  external/wpt/css/css-writing-modes
meade@chromium.org:
  external/wpt/web-animations
nzolghadr@chromium.org, mustaq@chromium.org:
  external/wpt/pointerevents
rego@igalia.com:
  external/wpt/css/css-grid
smcgruer@chromium.org:
  external/wpt/css/css-position
worker-dev@chromium.org:
  external/wpt/service-workers

TBR=raphael.kubo.da.costa@intel.com

No-Export: true
Change-Id: I0192a75b5f542020d9e200c88b8b0c7a2a8d2739
Reviewed-on: https://chromium-review.googlesource.com/774898
Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Reviewed-by: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517122}

r499728 has incorrectly translated domAutomationController.sendWithId
calls into domAutomationController.send calls - the first argument of
the calls should have been dropped.  This CL fixes this.

Bug: 662543
Change-Id: If06e033ddddfe3e86000c2cbd68e49f9039dd706
Reviewed-on: https://chromium-review.googlesource.com/741921Reviewed-by: Nick Carter <nick@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517121}

Only generic all-PASS testharness.js baselines can be safely removed.
Removing platform-specific all-PASS baselines can lead to falling back
to a different (and wrong) baseline.

Bug: 768525
Change-Id: Ia4f2f37068e21cf85535864dbf6e196392fc1533
Reviewed-on: https://chromium-review.googlesource.com/773738
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Quinten Yearsley <qyearsley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517120}

https://webrtc.googlesource.com/src.git/+log/34d4e5a4d1a7..8b64fd8a85c1

$ git log 34d4e5a4d..8b64fd8a8 --date=short --no-merges --format='%ad %ae %s'

Created with:
  roll-dep src/third_party/webrtc


The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I04be5a185c79b3e867371457649823032b3fed64
Reviewed-on: https://chromium-review.googlesource.com/775039Reviewed-by: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517119}

- This class actually contains methods for both persistent and
non persistent notifications, not just persistent ones.

TBR=avi@chromium.org

Bug: 
Change-Id: I047d9863592823812d9c56c2dd6f538e4c07b3d1
Reviewed-on: https://chromium-review.googlesource.com/774464
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517118}

Drive-by: Fix PRESUBMIT that was not allowing "toolbar::after" string in a CSS file.

BUG=769614

Change-Id: I4ac2bf3520acac391df8999d09617e3375308393
Reviewed-on: https://chromium-review.googlesource.com/769990Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Commit-Queue: Alexei Filippov <alph@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517117}

Findbugs has been removed. Keeping comments as they are good for context
and still contain relevant information on threading etc. Also makes
removing easier.

Will remove actual file in follow-up CL to reduce revert-churn. TBR for
cross-repo refactoring.

BUG=777511
TBR=dtrainor@chromium.org,jochen@chromium.org,torne@chromium.org,peter@chromium.org,yusufo@chromium.org,mdjones@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iec9c044375b9fd68ed605515381026e00a3c5431
Reviewed-on: https://chromium-review.googlesource.com/772399
Commit-Queue: Peter Wen <wnwen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517116}

A new test
  WebRtcCaptureFromElementBrowserTest.CaptureFromCanvas2DHandlesContextLoss

was landed in https://chromium-review.googlesource.com/c/chromium/src/+/756474

It is consistently failing in viz_content_browsertests due to 785023. This
change updates the tests filters to include this new test. While also copying
the updates which the FYI bot received yesterday.

TBR=sky@chromium.org
TEST=viz_content_browsertests

Bug: 760181
Change-Id: Idf6c9ff0239a7ec8dd871518a65e427aaf927577
Reviewed-on: https://chromium-review.googlesource.com/774978
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#517115}