- 14 Sep, 2020 40 commits
-
-
Adam Langley authored
The string-based version of this function takes const inputs, but the vector-based one did not. Align them so that the vector-based function is more general. Change-Id: I25ee663cc1d35fa9b0bb6cffc33dd0cd8b460423 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404067Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Adam Langley <agl@chromium.org> Cr-Commit-Position: refs/heads/master@{#806720}
-
Mei Liang authored
This CL adds the following a11y support to the GTS: * Requests focus to the currently selected tab after GTS is finished showing. * Updates the close button content description for individual tabs and tab groups with or without group name. This CL also updates the placeholder for the accessibility_close_tab_group_button_with_group_name string. Note: set `Skip-Translation-Screenshots-Check: True` to bypass error since the screenshot is the same before and after editing the string. Everything introduced in this CL is gated by by Finch parameter "enable_launch_polish" under flag "enable-tab-grid-layout". The changes in TabSwitcherCoordinator is also gated by the Finch flag "enable-tab-groups-continuation". Most of the code is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. The changes in following files can't be verified by the tool, but it is expected and no-op without both flags: * new property in TabProperties * StartSurfaceLayout#canHostBeFocusable is the only diff * Lots of diffs in language files due to the string placeholder change Skip-Translation-Screenshots-Check: True Bug: 1124921 Change-Id: If665464d82f83596c93449e8910878b4c00d02cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402302 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806719}
-
David Grogan authored
These files, from external/wpt/css/vendor-imports/mozilla/mozilla-central-reftests/flexbox/flexbox-intrinsic-ratio-00*, have ~20 test cases each. Chrome fails some of them but not others. With check-layout we can use -expected.txt files to prevent regressions for the cases that we pass. With the current ref tests, we have to disable an entire file if we fail even one case in it. No expectations were changed in the porting. You can see exactly which lines changed at [1], because it doesn't rename the files. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2387420 Change-Id: I6fa59df56599c15cccddba4c77afcad6668b9f3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2387148Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: David Grogan <dgrogan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806718}
-
John Abd-El-Malek authored
Bug: 1127518 Change-Id: I9639b5b047033ec92331a2dc5bb8541e4e08546c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406667 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#806717}
-
Risan authored
Currently, Removable Media is watched at the top-level directory under /media/removable. Unfortunately, this only works if the removable media was attached before the inotify is attached (since inotify does not detect mount event). This changes listen to the mount events from cros-disks through ArcVolumeManager (to synchronize with Android volume mounting) and create a FilePathWatcher per removable media. BUG=b:150883493 TEST=Mount invisible removable media, the media changes are indexed. TEST=Reboot DUT with non-visible removable media attached, still indexed. TEST=Change the removable media to be visible, still indexed. TEST=Reboot DUT with visible media attached, still indexed TEST=Change the removable media to be invisible, still indexed. Change-Id: Ia02012676681e025431d74f2c3f9b951a77ca783 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362376 Auto-Submit: Risan <risan@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Commit-Queue: Risan <risan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806716}
-
Greg Thompson authored
mini_installer recursively deletes directories left behind from previous runs. As it recurses through them, it may delete files with reparse points in those dirs. This is bad, since such files may actually be maliciously-created links to other entities on the filesystem. This CL skips anything with a reparse point during deletion -- since Chrome never creates files/dirs with reparse points, it shouldn't try to delete them. BUG=1125018 R=wfh@chromium.org Change-Id: I9897947ed883a91758c31990ed0b9648c38d2942 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409698 Auto-Submit: Greg Thompson <grt@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#806715}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 91b2c272. With Chromium commits locally applied on WPT: 0cd6359d "Modify failing cookie WPTs to use HTTPS" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: If882f7400fbbf9e8d5778bae83d01037ad18fee1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409923Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806714}
-
Erik Chen authored
This CL is a refactor with no intended behavior change. It updates the method parameter from Callback -> OnceCallback. Bug: 1127505 Change-Id: I8848dbf345db44a278e9a9cd59e0cebb20b0e5c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406590 Commit-Queue: Erik Chen <erikchen@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Auto-Submit: Erik Chen <erikchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806713}
-
Daniel Libby authored
This allows small raster scales like we see for some directly composited images to not trip over this particular DCHECK. Since these raster scales are all chosen by inverting the minimum dimension of the layer bounds, these minimum values round trip, and the resulting tiles won't be empty as they are doing a EnclosingContentsRectFromLayerRect to compute the tiling (and tile) size. Bug: 1124342 Change-Id: Ifb364e7d569d66903a04f9e4c80d56fc3ef8b9da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398985Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Daniel Libby <dlibby@microsoft.com> Cr-Commit-Position: refs/heads/master@{#806712}
-
Xiaohui Chen authored
The window containers for wallpaper all have fill layout, there is no need to set the bounds manually. Bug: None Test: manual and unit test Change-Id: I60cd9940ec64ab4afe924377cabe8dd7b6b6e908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406670Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#806711}
-
Glen Robertson authored
These targets fail to build if depended upon without `enable_media_drm_storage`, so prevent that from being possible. Split out from crrev.com/c/2383400 Bug: 898837 Change-Id: I7e0b94d81d2a722d93e41188812d532533a0255c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407420 Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: John Rummell <jrummell@chromium.org> Reviewed-by:
John Rummell <jrummell@chromium.org> Cr-Commit-Position: refs/heads/master@{#806710}
-
Greg Thompson authored
This fixes an issue where a long-lived child proc can block browser uninstallation. BUG=1126506 R=robliao@chromium.org Change-Id: I47cc3b7d701dcc454fcabce0751f2e08f21fd013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409493 Auto-Submit: Greg Thompson <grt@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#806709}
-
Robert Phillips authored
Bug: 1126424 Change-Id: I17ddbdce78d89a997a73c37f18cd945b83936f7f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405644Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Robert Phillips <robertphillips@google.com> Cr-Commit-Position: refs/heads/master@{#806708}
-
Anthony Cui authored
New name for feature is more accurate, as it is used to completely disable Translate and is not UI specific. Bug: 770776 Change-Id: I2f86da6de3d044d5b4e01186629f58f2c812e757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404484Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Anthony Cui <cuianthony@chromium.org> Cr-Commit-Position: refs/heads/master@{#806707}
-
Peter Wen authored
Add WebviewErrorCode @IntDef. Bug: 1116130 Change-Id: I740ad5b03eb2c03effd16413b57640d872b00a0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401813Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#806706}
-
Nico Weber authored
Else we can't tell if it's working on trunk. TBR=rnk Bug: 1127713 Change-Id: I9cefb00517ea71399e382678ce6da81e3629b501 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410817Reviewed-by:
-
Robert Sesek authored
Change-Id: I336a6acb2c60f992be5aab3f76a17ca02df8bc03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406702 Commit-Queue: Ken Rockot <rockot@google.com> Auto-Submit: Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#806704}
-
arthursonzogni authored
Sensitive information are removed from URLs sent with COOP. This was duplicated several time and way more are coming to support access-reporting. This patch: 1. Factorize the logic inside SanitizedURL(url) 2. Clear the #fragment part of the URL. Developers need to know the document's URL, not which part of it the user scrolled into. 3. Clear non HTTP/HTTPS urls. 4. As in the ReportingServiceImpl, use GetAsReferrer() instead. This is slightly more optimized. 5. Remove the useless sanitization in QueueNavigationReport. Bug: 1090273 Change-Id: I4b2a23dcb3ed218c58d8a940bed1a34fe42a7fc8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401025Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#806703}
-
Maksim Ivanov authored
Fix use-after-move (potential) bugs found by the "bugprone-use-after-move" clang-tidy check. Bug: 1122844 Change-Id: I9a3c384c5efb7fc82a65cac1bf615ebdb42e6d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401660Reviewed-by:
-
Robert Ogden authored
Moves the feature logic to a check-everything paradigm instead of doing early returns, for the sake of easy to understand metrics. privacy doc: http://shortn/_99lQLYJfL1 Bug: 1115259 Change-Id: I036a412104d9ccce885789637461314d50f1e967 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2388270Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#806701}
-
Omer Katz authored
The issue below is mostly timeouts. The relevant diff was to DrainWorklist which used to return true for empty worklists, but now might return false. The change to DrainWorklist was made to guarantee no draining is done when we should yield (due to deadline or job scheduling). Before the change we would also drain at least one item, which could take some time. This CL adds a check for emptiness before the yielding check. This restores previous behavior for empty worklists and avoid draining an object if we should already yield. Bug: 1127888 Change-Id: I726d205516bc23b7a2345e5e68e35e08d866f722 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409944Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#806700}
-
Torne (Richard Coles) authored
We no longer merge APKs - the build time saving it provided stopped working some time ago due to additional dependencies between the ABIs, and we just archive the symbols from 64-bit bots' 32-bit binaries separately so there's no real need for the libs to be identical. Remove the script to make it clear we don't support this any more. Fixes: 1039881 Change-Id: I5f6f5e102b69518b737664011b7abeb78a40ba65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409924 Commit-Queue: Richard Coles <torne@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Auto-Submit: Richard Coles <torne@chromium.org> Reviewed-by:
Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#806699}
-
Kyle Milka authored
Pass in a SettingsLauncher when constructing ShareSheetCoordinator that will eventually be passed to SendTabToSelfShareActivity. Bug: 1090917 Change-Id: I0690a2b552503e95873b9aec1b993f1a18405476 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2250699Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#806698}
-
Andrei-Laurențiu Olteanu authored
Add implementation to chrome://. Add implementation to chrome-untrusted://. Add tests. Bug: b:162051831 Change-Id: I3749503e240a14b1d4ff76cfd3c477470ae704c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2396089 Commit-Queue: Laurențiu Olteanu <lolteanu@google.com> Reviewed-by:
Oleh Lamzin <lamzin@google.com> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Mahmoud Gawad <mgawad@google.com> Cr-Commit-Position: refs/heads/master@{#806697}
-
Scott Violet authored
The NPE occurs with the following sequence: 1. show tab-modal dialog. 2. some portion of the containing view hierarchy is removed from a window. 3. dialog dismissed. 4. animation started in 1 finishes, triggering trying to use an object that was set to null. Step 3 needs to cancel the start animation. BUG=1127254 TEST=covered by test Change-Id: I58c80c0a1e8330c0b87b2a56e228d67bc61b2cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406933 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Ian Struiksma authored
Added builders to luci.chromium.try, waiting for that to land. Bug: 990885,1125612 Change-Id: If4031cc35a54c987fcaa4b4e494645dd73c77e85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402762Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Ian Struiksma <ianstruiksma@google.com> Cr-Commit-Position: refs/heads/master@{#806695}
-
Aaron Krajeski authored
Bug: 1046463 Change-Id: I19836bb8315c62d50510d19673a7f4baff3df51a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2399002 Commit-Queue: Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Aaron Krajeski <aaronhk@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806694}
-
Juanmi Huertas authored
IT seems that canvas_fuzzer is yielding lots of false positives, this CL disables the fuzzer temporarily in order to improve it to reduce false positives. Bug: 1124824, 1124812 Change-Id: I293de80684f7878c1b2c8da43a816bf8572840e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402970 Commit-Queue: Juanmi Huertas <juanmihd@chromium.org> Reviewed-by:
-
Xianzhu Wang authored
The code was added in crrev.com/769833 to catch the cases that some DisplayItemClients were deleted before PaintController::FinishCycle(). We haven't seen any crash reports caught by the code. Remove the code to ease refactoring of PaintController. Bug: 1021766, 917911 Change-Id: I06b2bff15207739c1b64779ff20876cd86205511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409212 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#806692}
-
Alice Wang authored
This CL improves AccountPickerBottomSheetRenderTest's account list expanding action to reduce the flakiness. Bug: 1127676 Change-Id: Id0849d4c388151b2752a3678a722cac05eb7e9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407255Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806691}
-
adamta authored
Adds user actions in the Discover feed metrics recorder alongside the existing histograms. Mostly reuses existing actions, but added a few to be in sync with the currently logged histograms. Bug: 1127457, 1085419 Change-Id: I54db65f31122787942601e6c421b713c8a440022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2405858Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Cr-Commit-Position: refs/heads/master@{#806690}
-
Mirko Bonadei authored
The iOS testing templates are not generating .runtime_deps files at 'gn gen' time and this is a pre-requisite to be able to switch WebRTC tests from the old isolate procedure the the one based on GN/MB. Bug: webrtc:11930 Change-Id: I2cfde6a9f47526c9e5f0c6a2dbfc470bf4d3284f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407898Reviewed-by:
Takuto Ikuta <tikuta@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#806689}
-
Jan Wilken Dörrie authored
This change modifies the WellKnownChangePasswordNavigationThrottle to only be instantiated for main frame navigations. Fixed: 1127520 Change-Id: Ia63ecaa4a2411a578956049797cb722012339ddc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410382Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#806688}
-
Dominic Mazzoni authored
Crash stack traces are pointing to very occasional errors with AXPosition. They all seem to be cases where a DCHECK would have failed. I think the best approach is to not only DCHECK but also gracefully handle the failure case if it does occur. Not setting the selection doesn't have to be a fatal error. Bug: 1116340 Change-Id: I038dc793118214905aa46daf587b9c7a2f9018e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404386 Commit-Queue: Nektarios Paisios <nektar@chromium.org> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#806687}
-
Filip Gorski authored
This reverts commit 3481a5a7. Reason for revert: Broke TranslateBrowserTest on android-pie-x86-rel https://ci.chromium.org/p/chromium/builders/ci/android-pie-x86-rel/2212 Test output https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8869167939689927152/+/steps/weblayer_browsertests/0/logs/Deterministic_failure:_TranslateBrowserTest.TranslateInfoBarNeverTranslateSite__status_FAILURE_/0 It is possible that that specific test needs an adjustment to go in together with this. Original change's description: > [WebLayer] Add ability to override translate target language > > This CL adds the ability to override the target language used by the > translate feature on a per-Tab basis. This is analogous to the > functionality of CCT's TRANSLATE_LANGUAGE intent extra. Once the > override is set, all translate infobars in the given Tab will appear > with the specified language as the target language. Calling > Tab#setTranslateTargetLanguage() with an empty string clears the > override and causes behavior to revert to normal. > > Note that even with the override set the translate infobar will not > appear for pages that are in the user's locale. This is internal > behavior of Chromium's translate component and is common to CCT and > WebLayer. > > I marked the added method as since 86 as this CL will be targeted for > cherrypicking to 86. > > Bug: 1116394 > Change-Id: Ic4f08c16a64a3f0ceebed5feab7cdc9401001279 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397716 > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Clark DuVall <cduvall@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#806633} TBR=jam@chromium.org,blundell@chromium.org,cduvall@chromium.org Change-Id: Idbb50b93aea9a4037e2956ba63a570047e50944b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1116394 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410610Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Filip Gorski <fgorski@chromium.org> Cr-Commit-Position: refs/heads/master@{#806686}
-
Zarah Tesfai authored
Since getDefaultPaymentInformation is PaymentRequest UI logic, move it into PaymentUIsManager. Bug: 1102522, 1114791 Change-Id: If2f958f38bd81677d734621150ad944b19945212 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2406693 Commit-Queue: Zarah Tesfai <ztesfai@google.com> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#806685}
-
Kevin Marshall authored
Refactors NamedMessagePortConnector into a platform-agnostic component, which can be reused across FIDL, in-process, and testing contexts. It uses Blink messages and message ports as a common basis for message and port transport. * Implements some missing portions of the Blink/FIDL MessagePort conversion layer. * Adds a Fuchsia implementation of NMPC. Bug: 1104369 Change-Id: I01e86c38963bfb114a7466c6f73b143e5302ad1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293110 Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#806684}
-
David Bienvenu authored
If the IVirtualDestkopManager COM method IsWindowOnCurrentVirtualDesktop fails on a window, treat the window as non-occluding, because that's safer than treating it as occluding - it might be on an another virtual desktop, and thus should be non-occluding. Previously, IsWindowOnCurrentVirtualDesktop was incorrectly returning base::Optional nullopt on Windows 7 and 8.1 (i.e., unknown). This CL makes it return true, because there are no virtual desktops on Win 7/8, so every window is on the current desktop. This allows us to require that IsWindowOnCurrentVirtualDesktop return true to say that a window is occluding - previously we checked for != false, to handle Win7. Bug: 813093 Change-Id: Iee49eff9333a8530314720702b1815256acdbfc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410420Reviewed-by:
Jesse McKenna <jessemckenna@google.com> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#806683}
-
Ramin Halavati authored
DownloadManagerService#getProfileKey used getLastUsedRegularProfile to get profile, which could cause exceptions if the function was called before regular profile was created. This is now changed to use ProfileKey#getLastUsedRegularProfile which handles this case and returns the ProfileKeyStartupAccessor in that case. Bug: 1106324, 1099577 Change-Id: I1deb3c1484abfcdf871dde1fb8a81853ee1bb371 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409272Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#806682}
-
Evan Stade authored
It moved to //components in ff2cc1b1 Bug: 1057100,1127697 Change-Id: Ie1a88bb576d73b04fd73dc5d1214250ddbc82266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410437 Auto-Submit: Evan Stade <estade@chromium.org> Reviewed-by:
-
