- 03 Aug, 2018 40 commits
-
-
Benjamin Shaya authored
Bug: 80048435 Test: User EQ on video device w/ mixer Change-Id: Iccd7ffb26e1cc75fbc79ec0bb1db04dc6551ee08 Reviewed-on: https://chromium-review.googlesource.com/1159694 Commit-Queue: Benjamin Shaya <bshaya@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#580680}
-
Nico Weber authored
Removes: - not_site_per_process_interactive_ui_tests - not_site_per_process_sync_integration_tests - not_site_per_process_unit_tests Bug: 870761,843511 Change-Id: I498ae273ffcef62698f0992783dbea89f1bbe7d1 Reviewed-on: https://chromium-review.googlesource.com/1161975Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#580679}
-
Charlie Andrews authored
This is a follow-up to https://crrev.com/c/1122489, which removed the BattOr PowerTracingAgent from Chrome. R=oysteine@chromium.org, dcheng@chromium.org Bug: 859514 Change-Id: Ib4324289fcf9d1d0e3d34f828550a488a694644b Reviewed-on: https://chromium-review.googlesource.com/1162626 Commit-Queue: Charlie Andrews <charliea@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#580678}
-
Johannes Henkel authored
This is straight forward except for understanding what's up with Restore. I've added a comment there, it may be worth resolving in this change. Bug:851762 Change-Id: I45b56b3f10dd96dae2b6c502030ced8e8ace026b Reviewed-on: https://chromium-review.googlesource.com/1161178 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#580677}
-
Mohamed Amir Yosef authored
This reverts commit 0856d23e. Reason for revert: <INSERT REASONING HERE> Original change's description: > Reland "Reland "[Sync::USS] Bookmark sync conflict resolution"" > > This is a reland of a445460b > because it was reverted by mistake. > > TBR=mastiz@chromium.org > > Original change's description: > > Reland "[Sync::USS] Bookmark sync conflict resolution" > > > > This is a reland of 553ec6da > > > > Original change's description: > > > [Sync::USS] Bookmark sync conflict resolution > > > > > > This patch addresses the problem of conflict in bookmarks upon > > > receiving a remote update for a node that has local changes. > > > > > > The general polic that is implemented is that server wins except in > > > case of deletion. > > > > > > Bug: 516866 > > > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > > > Reviewed-on: https://chromium-review.googlesource.com/1157006 > > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#580436} > > > > Bug: 516866 > > Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e > > Reviewed-on: https://chromium-review.googlesource.com/1161861 > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580496} > > Bug: 516866 > Change-Id: I285dfa50ae5374bc82840b6d140f99f7edddd552 > Reviewed-on: https://chromium-review.googlesource.com/1162181 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580553} TBR=treib@chromium.org,mastiz@chromium.org,mamir@chromium.org Change-Id: Ibd5c2c5ddd40a916dd8a2e04866ddedd46458da1 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866 Reviewed-on: https://chromium-review.googlesource.com/1162841Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#580676}
-
Johannes Henkel authored
I made it so that clearDeviceOrientationOverride() delegates to disable(), which is now more careful about clearing out the state. For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. We're migrating things from state_ to this new mechanism, which allows incremental updates to flow back to the browser process. Bug:851762 Change-Id: I388198b01da77e04943a4c23e90f521e25aeab94 Reviewed-on: https://chromium-review.googlesource.com/1159697 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
sczs authored
Uses CGAffineTransformMakeRotation to do a 180 rotation of the collection cells accessoryView whenever a chevron is being used on RTL. Bug: 869142 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic10ebc0067e34a7fe8d593d4aafeb25dca4f9e99 Reviewed-on: https://chromium-review.googlesource.com/1162428 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#580674}
-
Roberto Carrillo authored
This reverts commit e8b14cdd. Reason for revert: Mistakenly reverted. Original change's description: > Revert "chromeos: splits ash's file list into public/sources sections" > > This reverts commit 2e803140. > > Reason for revert: speculative revert, seems to have introduced the following failure: https://bugs.chromium.org/p/chromium/issues/detail?id=870827 > Original change's description: > > chromeos: splits ash's file list into public/sources sections > > > > I'm putting all the '.h' files into public. We can refine the list as necessary > > later. > > > > I'm doing this as I would like to have private headers that other targets can't > > include (well, except tests). > > > > BUG=none > > TEST=none > > > > Change-Id: I84ab155a1449d969076dcd94feaa0150f3e9ad85 > > Reviewed-on: https://chromium-review.googlesource.com/1161498 > > Commit-Queue: Scott Violet <sky@chromium.org> > > Reviewed-by: James Cook <jamescook@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580581} > > TBR=jamescook@chromium.org,sky@chromium.org > > Change-Id: Icfed283e1b854f9639fe111fbd83b948b8d6147f > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: none > Reviewed-on: https://chromium-review.googlesource.com/1162207 > Reviewed-by: Roberto Carrillo <robertocn@chromium.org> > Commit-Queue: Roberto Carrillo <robertocn@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580630} TBR=jamescook@chromium.org,sky@chromium.org,robertocn@chromium.org Change-Id: I66a38be64c22fb1b6a6f808bfee64517f912e7ad No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: none Reviewed-on: https://chromium-review.googlesource.com/1162212Reviewed-by:
Roberto Carrillo <robertocn@chromium.org> Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Cr-Commit-Position: refs/heads/master@{#580673}
-
Robert Sesek authored
This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox Bug: 850878 Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198 Reviewed-on: https://chromium-review.googlesource.com/1152080Reviewed-by:
Greg Kerr <kerrnel@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#580672}
-
Chris Palmer authored
Also use the correct type, size_t, for its size. Some code cleanup and simplification. Bug: 817982 Change-Id: I42f4d4230a60d64de8ea483450159c92475e3e4b Reviewed-on: https://chromium-review.googlesource.com/1157649 Commit-Queue: Chris Palmer <palmer@chromium.org> Reviewed-by:
-
Nasko Oskov authored
With error page isolation, navigations that result in a chrome error page (as opposed to HTTP errors such as 404) are isolated in their own process. This CL adds some validations at commit time to ensure that invariants we expect are enforced by the browser. It only includes some of the possible checks, as more investigations are needed to understand the behavior of HTTP layer errors. Bug: 866549 Change-Id: I8389629eb68213681983b37d1cfc945832e35ea7 Reviewed-on: https://chromium-review.googlesource.com/1160877 Commit-Queue: Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#580670}
-
Michael Spang authored
Make these polymorphic types so that we can provide a fake implementation of libgbm for test purposes. Bug: 869206 Test: ozone_unittests Change-Id: I773cdac62bade798fbcddac54a2d5557ce1da8ce Reviewed-on: https://chromium-review.googlesource.com/1162655 Commit-Queue: Michael Spang <spang@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Cr-Commit-Position: refs/heads/master@{#580669}
-
Sammie Quon authored
This requires deleting WindowSelectorItem::RoundedContainerView. screenshot: https://screenshot.googleplex.com/Gu5wG5LOPHY Test: manual, run WindowSelectorTests Bug: 839477 Change-Id: I933d0de5ba38a9c829d2266f945cc62fd2b5d7c9 Reviewed-on: https://chromium-review.googlesource.com/1161482 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#580668}
-
webrtc-chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d54f5f5c763c..50eb4c44ad92 git log d54f5f5c763c..50eb4c44ad92 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 srte@webrtc.org Adds BBR field trial to CallTest. 2018-08-03 sakal@webrtc.org Fix remaining target name for AppRTCMobile_stubbed_video_io_test_apk. 2018-08-03 buildbot@webrtc.org Roll chromium_revision 06e87fb3..62642dd6 (580149:580526) 2018-08-03 oprypin@webrtc.org Remove Syzygy from deps 2018-08-03 oprypin@webrtc.org Fix gitignore pattern to never exclude sha1 files Created with: gclient setdep -r src/third_party/webrtc@50eb4c44ad92 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:None,chromium:None,chromium:None TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Iaf357cc4b58e9f9be30d6dd57fd3cbf51940b8d1 Reviewed-on: https://chromium-review.googlesource.com/1162386Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580667}
-
David Tseng authored
Bug: 869921, 854321,869955 Change-Id: I9d9ae5aa5c590cf0200e6953054dff1833fc7b76 Reviewed-on: https://chromium-review.googlesource.com/1161176 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580666}
-
Robert Shield authored
Bug: 747557 Change-Id: I2997faa2de1cb384287afc5d4eb23c352b8ea7a5 Reviewed-on: https://chromium-review.googlesource.com/1157864Reviewed-by:
Chris Sharp <csharp@chromium.org> Reviewed-by:
-
Scott Violet authored
This code is no longer hit after the switch to ws2. BUG=none TEST=none Change-Id: I7ad3607d1db7f5d670c69e0bdcd386876ae2e942 Reviewed-on: https://chromium-review.googlesource.com/1162718Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#580664}
-
Ehsan Karamad authored
The smooth-scroll animations are local frame root concepts. This move will avoid a nested OOPIF same process with a parent to use the same sequencer so their animations are independently scheduled. Bug: 865446 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ic07c22eef5d7a6ec25fe51c32d3e22e056398522 Reviewed-on: https://chromium-review.googlesource.com/1159189 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#580663}
-
Shakti Sahu authored
This CL contains following changes : 1 - Moved the storage summary text out of toolbar into RecyclerView due to font size issues. 1 - Renamed StorageSummary to StorageSummaryProvider which will provide the updated storage info through a delegate. 2 - Added StorageCoordinator which will own the provider, model, view and viewbinder and create the storage summary view to be shown inside RecyclerView. 3 - StorageSummaryProvider will be observing offline items and update the storage info on Add/Removes. Updates are ignored due to high frequency of updates. Bug: 868547 Change-Id: I50a2f8c14d95b3f29aeec49fa34b08618b3bf3ba Reviewed-on: https://chromium-review.googlesource.com/1157868 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:Ted Choc <tedchoc@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#580662}
-
Quan Nguyen authored
This makes the views-login dialog more consistent with how the webui version looks. Change-Id: I1c931623ae9c8b6408debe315ab7cac8d4cac742 Reviewed-on: https://chromium-review.googlesource.com/1162745Reviewed-by:
Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580661}
-
Roberto Carrillo authored
This reverts commit 22333d92. Reason for revert: suspected of breakage in 'generate_build_files': https://bugs.chromium.org/p/chromium/issues/detail?id=870827#c3 Original change's description: > Fix missing dependencies with RLZ target. > > chrome_rlz_tracker_delegate.cc depended on browser_process.h which had transitive dependencies on generated mojoms. But it didn't get the public_deps because the rlz target didn't depend on chrome/browser to avoid circular dependencies. Fold it into chrome/browser to fix this properly. > > This does mean that the one unit test in chrome_rlz_tracker_delegate_unittest.cc > will not run on chromium-branded bots anymore. That seems better than having flaky dependencies, since untangling the build dependencies looks like a lot of work. > > Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng > Change-Id: I85d78d25b1905c68524e0636cec3006102d17749 > Reviewed-on: https://chromium-review.googlesource.com/1161610 > Reviewed-by: Avi Drissman <avi@chromium.org> > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580579} TBR=avi@chromium.org,jam@chromium.org Change-Id: I5bca5200d639f01dbba1ed582d9dccb3290cf0c4 No-Presubmit: true No-Tree-Checks: true No-Try: true Cq-Include-Trybots: luci.chromium.try:linux_chromium_dbg_ng Reviewed-on: https://chromium-review.googlesource.com/1162211Reviewed-by:
-
Trent Apted authored
ShowInactive() is usually used to make a hidden window visible without having it also take key focus. It can also be used to raise an already-visible window higher in the window stacking order (also without taking focus). However, a quirk of AppKit is that calling orderWindow: will also trigger a Space switch to the desktop containing that window, if Chrome is the active application. Since we never want ShowInactive() to do that, and since child windows can not control their stacking order, skip the call to orderWindow for child windows, if the window is already visible. Bug: 866760 Change-Id: I984c2ce8b0cb1754ee68e0392524c64739253ab9 Reviewed-on: https://chromium-review.googlesource.com/1161701Reviewed-by:
-
Tessa Nijssen authored
Previously, each tab had its own SuggestedTextTouchBarController. Now, because of http://crrev/c/1151613, there is only one SuggestedTextTouchBarController per window. Because the controller does not maintain the state of each tab, as a user switches tabs, the controller needs to update its state to match the tab. When the controller's WebContents change, new suggestions should be generated for the selected text in the current tab. The methods -webContentsTextSelectionChanged:range: and -webContentsFinishedLoading were combined into a singular method, -updateTextSelection:range:, because they had very similar functionality. The parameters for -requestSuggestionsForText:inRange: were removed because they were always |text_| and |selectionRange_|. A new method was created, -webContentsChanged, to get a tab's current text and selected range and then call -updateTextSelection:range: with the proper parameters. When the controller gets a new pointer to a WebContents, the pointer may be null. To avoid calling WebContents::IsFocusedElementEditable() on a null pointer, a method -isTextfieldFocused was created to check that |webContents_| is not a null pointer and that an editable element is focused. A new SuggestedTextTouchBarControllerBrowserTest was written, SetWebContentsTest, to test that the SuggestedTextTouchBarController properly updates its current text selection based on the new WebContents. This CL is the same as http://crrev/c/1153728 with the following changes: - Browser tests for methods that are not restricted to MacOS 10.12.2+ were modified to also run on earlier versions of MacOS. The expected behavior for different MacOS versions is accounted for in the tests. - A call to UnfocusTextfield() was added to SetWebContentsTest to ensure that a later call to FocusTextfield() works as intended and focuses an editable element. Bug: 717553 Change-Id: Id061e392dd279e7a3cc9a34a023eb9bd97e52940 Reviewed-on: https://chromium-review.googlesource.com/1160929Reviewed-by:
-
Sammie Quon authored
Internal keyboard and touchpad events are previously locked when entering tablet mode and unlocked when leaving. Now, when we attach a mouse, it will exit tablet mode, but the keyboard should not stay locked as the keyboard will be facing downwards in the case of flip chromebook. The lock should instead be controlled by the hinges regardless if change in hinge causes tablet mode to change. Also rename EnterTabletMode to AttemptEnterTabletMode as it does not always enter. Test: ash_unittests TabletModeControllerTest.LeaveTabletModeWhenExternalMouseConnected Bug: 870757 Change-Id: I38a537871aa6a1e7cd94311308d421af3dfc2ad1 Reviewed-on: https://chromium-review.googlesource.com/1162512 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by:
-
Christopher Cameron authored
Adding a glFlush at the end of every batch of decoded commands in GLES2DecoderImpl::DoCommandsImpl eliminated this crash, but that is somewhat egregious and hacky. This adds a glFlush to every place where we switch virtual contexts, doing the flush both before and after the state restore (and also before switching away from a virtual context, just for good measure). If the crashes don't re-appear then we can leave it at this. We will eliminate virtual contexts when OOP-D and OOP-R are enabled. If this isn't sufficient to eliminate the crashes, then we can go back to doing a glFlush at the end of every GLES2DecoderImpl::DoCommandsImpl call, at least for merging to Chrome 69. Bug: 863817 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: Ie8b4531ea800918eac42083ceecd5e65b9c02301 Reviewed-on: https://chromium-review.googlesource.com/1162516 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580656}
-
Ehsan Karamad authored
All GuestViews except for MimeHandlerViewGuest are now implemented based on cross-process frames. There is however a hadnful of browser tests which are not MimeHandlerViewTest but still use BrowserPlugin. This CL will 1- Change the MimeHandlerViewTest from parameteric to normal test. Essentially, the UseCrossProcessFramesForGuest flag is unrelated to the MimeHandlerViewGuest. There is a separate flag for that matter which is "MimeHandlerViewInCrossProcessFrame" and will be added eventually when the a first version of MimeHandlerViewGuest based on cross-process frames is implemented on ToT. 2- Move WebViewBrowserPluginSpecificTest.AcceptTouchEvents to MimeHandlerViewTest. This involves overhauling the test test is also modified to load MimeHandlerViewGuest instead of WebViewGuest. The short-term plan is to change all such (BrowserPluginSpecific) tests to become MimeHandlerViewBrowserPluginSpecificTest. The longer term goal is to remove all such tests when MimeHandlerViewInCrossProcessFrames is shipped. Bug: 659750, 533069, 330264 Change-Id: Icad9ddd1f2d1e6851b20f6c0d923dd2192b7dcec Reviewed-on: https://chromium-review.googlesource.com/1161745 Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Ehsan Karamad <ekaramad@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Cr-Commit-Position: refs/heads/master@{#580655}
-
Etienne Bergeron authored
R=oysteine@chromium.org Bug: 867931 Change-Id: I257c7b6e6220e9e00eecf3ab14b4cb6e19d55a1b Reviewed-on: https://chromium-review.googlesource.com/1162635Reviewed-by:
-
Sammie Quon authored
Test: compiles Bug: none Change-Id: I7651e96e727110205740e0884550d559f9078abd Reviewed-on: https://chromium-review.googlesource.com/1162582Reviewed-by:
-
Ryan Meier authored
Adds checks before modifying whether or not a tab uses extra padding to ensure that padding doesn't get changed while the tab is closing. Without these checks, tab titles would suddenly jump several pixels to the left near the end of the tab's closing animation. Found while reproducing/fixing Bug: 859321 Change-Id: Id7db4b160530535af520cdfaf99202aa863a019a Reviewed-on: https://chromium-review.googlesource.com/1162359 Commit-Queue: Ryan Meier <rameier@chromium.org> Reviewed-by:
Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#580652}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/27928c385ec6..d30f10814bd0 git log 27928c385ec6..d30f10814bd0 --date=short --no-merges --format='%ad %ae %s' 2018-08-03 bsheedy@chromium.org Fix ReplaceSystemApp not granting permissions 2018-08-03 wangge@google.com Long Term Health Tool File Reorganization Created with: gclient setdep -r src/third_party/catapult@d30f10814bd0 The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:870782,chromium:863390 TBR=sullivan@chromium.org Change-Id: I61cecf50cbb85a042494bab6182d719c6cb8b714 Reviewed-on: https://chromium-review.googlesource.com/1162387Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580651}
-
Fredrik Hubinette authored
apparently nothing breaks Bug: 649199 Change-Id: I728637ba8b7ffea50191014f07d9581d08eb33ed Reviewed-on: https://chromium-review.googlesource.com/1162431Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Fredrik Hubinette <hubbe@chromium.org> Cr-Commit-Position: refs/heads/master@{#580650}
-
Becca Hughes authored
Remove the AutoplayMutedVideos feature which is set based on the autoplay policy command line switch. This means it ignores if we have overridden the autoplay policy for the document. Instead we should perform this check in AutoplayPolicy which will have the final autoplay policy for the document. BUG=865548 Change-Id: Iddfb9d0b3fef3bfa6efc493876094eaf2f8f7799 Reviewed-on: https://chromium-review.googlesource.com/1157215Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580649}
-
Alexander Alekseev authored
This CL delays startup sound playback until default sound output device has known type. Bug: 848485 Change-Id: I911e37afd34d28f142c46ef63b7b6345988d159b Reviewed-on: https://chromium-review.googlesource.com/1160143Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Commit-Queue: Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#580648}
-
Paul Jensen authored
Convert it to "new" (2012) NeworkChangeObserver. Bug: 754695 Change-Id: Ifc63ddff076da40fd1a18d052b73f03e778cbd56 Reviewed-on: https://chromium-review.googlesource.com/1161966Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#580647}
-
Johannes Henkel authored
inspector_network_agent.cc: This is a behavior change, there are a fair number of fields here. E.g., previously, the extra headers would be preserved between disable() and enable(), now they're cleared out. inspector_page_agent.cc: Similarly, this is a behavior change. E.g., previously, setFontFamilies and setFontSizes settings would be preserved between disable() and enable(), now it's cleared out. Bug: 851762 Change-Id: I923a2d49ec92f395c5954116e115686517994a0f Reviewed-on: https://chromium-review.googlesource.com/1161175Reviewed-by:
-
Vladimir Levin authored
R=pdr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ibe0b3837e5ffd0919d8162a46c48bb550f9e4780 Reviewed-on: https://chromium-review.googlesource.com/1162586Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#580645}
-
Johannes Henkel authored
This is a refactoring except for kVirtualTimeTaskStarvationCount. Previously, the code called state_->setDouble(...VirtualTimeTaskStarvationCount, ...); but then read it as an int, so it basically wouldn't get saved. Now it's always an int. Bug: 851762 Change-Id: I288274ddddc44c910d89ef1fb8c1a6eacd54d8c5 Reviewed-on: https://chromium-review.googlesource.com/1161329 Commit-Queue: Johannes Henkel <johannes@chromium.org> Reviewed-by:
-
Jérôme Lebel authored
Before: https://drive.google.com/open?id=1HZzgWAeGjTOREQzj-uBROCDvS-kBMwJL After: https://drive.google.com/open?id=1WTN_Bhjdwrhz1kMZAQDSbKTmc0YhZrb6 Bug: 827072 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I5b3d162b495a22d55cce42fd643a4c9d982e8c87 Reviewed-on: https://chromium-review.googlesource.com/1162158Reviewed-by:
Sergio Collazos <sczs@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#580643}
-
Theresa authored
Delete unused SuggsetionsMetrics methods and mark corresponding user actions as obsolete. BUG= Change-Id: I2c9d43d517ed03162dbe5fa051639a0cc342846a Reviewed-on: https://chromium-review.googlesource.com/1162316Reviewed-by:
-
Theresa authored
Don't record a histogram entry for NewTabPage.ActionAndroid2 or the Suggestions.Card.Tapped user action when a contextual suggestion is clicked. BUG=870424 Change-Id: I7d10c1b00628c83f4dbde2a4353707a483722656 Reviewed-on: https://chromium-review.googlesource.com/1162319Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#580641}
-
