GitLab

Evalation order of arguments is undefined, which can result
in NULL pointers passed to ResolveLanguageListOnBlockingPool.

BUG=422002
TEST=build & run on link_freon

Review URL: https://codereview.chromium.org/641693008

Cr-Commit-Position: refs/heads/master@{#299091}

This CL:
* Introduces ContentSettingsClient interface.
* Includes some functions to be transferred to interface from TabSpecificContentSettings.

To be done in follow-up CLs:
* Introduce a Chrome implementation of this interface.
* Add code to create those objects.
* Move the methods from TabSpecificContentSettings included in the interface to the implementation.

BUG=387075,384873,393248

Review URL: https://codereview.chromium.org/640753002

Cr-Commit-Position: refs/heads/master@{#299090}

These methods are no-ops in the current implementations and are going
away in the upstream interface, where a default implementation is
provided in the interrim.

R=tommi@chromium.org
BUG=webrtc:3876

Review URL: https://codereview.chromium.org/639393002

Cr-Commit-Position: refs/heads/master@{#299089}

BUG=412254

Review URL: https://codereview.chromium.org/614893002

Cr-Commit-Position: refs/heads/master@{#299088}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/20a3bc7..3332a34

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/642263003

Cr-Commit-Position: refs/heads/master@{#299087}

This is first step towards establishing an API between src and recipes.
The goal is to convert all Test subclasses from recipes' steps.py
into scripts like this one.

BUG=422235
R=iannucci@chromium.org

Review URL: https://codereview.chromium.org/645593002

Cr-Commit-Position: refs/heads/master@{#299086}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/4a137c2..20a3bc7

TBR=eseidel@chromium.org,caseq@chromium.org,apavlov@chromium.org

Review URL: https://codereview.chromium.org/643843002

Cr-Commit-Position: refs/heads/master@{#299085}

BUG=421958, 334149
R=hans@chromium.org, haraken@chromium.org

Review URL: https://codereview.chromium.org/641353002

Cr-Commit-Position: refs/heads/master@{#299084}

BUG=417756

Review URL: https://codereview.chromium.org/620133002

Cr-Commit-Position: refs/heads/master@{#299083}

Recently, getSources path moved to UserMediaClient and MediaStreamDispatcher[Host]. The old path shall be removed.

BUG=420975

Review URL: https://codereview.chromium.org/629953002

Cr-Commit-Position: refs/heads/master@{#299082}

ShellDevToolsFrontend::RenderProcessGone's functionality is now entirely
contained in LayoutTestDevToolsFrontend; I should have removed this
definition in https://codereview.chromium.org/644723002.

BUG=420994

Review URL: https://codereview.chromium.org/644963002

Cr-Commit-Position: refs/heads/master@{#299081}

If GL_EXT_blend_minmax is available then make use of that
to accelerate blending for the 'lighten' blendmode.

BUG=243223

Review URL: https://codereview.chromium.org/614953002

Cr-Commit-Position: refs/heads/master@{#299080}

This fix the C++ and python generation to allow circular dependencies
between structs.

R=viettrungluu@chromium.org

Review URL: https://codereview.chromium.org/622593002

Cr-Commit-Position: refs/heads/master@{#299079}

Revert of Revert of Re-enabling fixed WebRTC getusermedia tests. (patchset #1 id:1 of https://codereview.chromium.org/630143002/)

Reason for revert:
Should be fixed by https://codereview.chromium.org/638423002/ and https://codereview.chromium.org/640253002.

Original issue's description:
> Revert of Re-enabling fixed WebRTC getusermedia tests. (patchset #1 id:1 of https://codereview.chromium.org/623733002/)
>
> Reason for revert:
> still flaky, see bug
>
> Original issue's description:
> > Re-enabling fixed WebRTC getusermedia tests.
> >
> > BUG=417756
> >
> > Committed: https://crrev.com/9fa6d13fdbac6c82917c23c9b63b4f3cb7b7593e
> > Cr-Commit-Position: refs/heads/master@{#298205}
>
> TBR=perkj@chromium.org,kjellander@chromium.org,phoglund@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> BUG=417756
>
> Committed: https://crrev.com/290d2cfa5187ac1f2c87fde4c6dd6f27dad0c93a
> Cr-Commit-Position: refs/heads/master@{#298262}

TBR=perkj@chromium.org,kjellander@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417756

Review URL: https://codereview.chromium.org/644873003

Cr-Commit-Position: refs/heads/master@{#299078}

Revert of Content Shell: Introduce LayoutTestBrowserContext. (patchset #2 id:20001 of https://codereview.chromium.org/637843003/)

Reason for revert:
Tentatively resulted in multiple layout test timeouts across the chromium.webkit waterfall.

Original issue's description:
> Content Shell: Introduce LayoutTestBrowserContext.
>
> This splits the DRT-specific parts of ShellBrowserContext out into a new
> class that we'll only instantiate when the flag is set.
>
> BUG=420994
>
> Committed: https://crrev.com/98ce5ad6bdd2cd058c21f19b997032f3b958cb73
> Cr-Commit-Position: refs/heads/master@{#299068}

TBR=jochen@chromium.org,mkwst@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=420994

Review URL: https://codereview.chromium.org/641203004

Cr-Commit-Position: refs/heads/master@{#299077}

BUG=421407
TEST=Open Files.app (WindowA); Create a directory; Open a new window of Files.app, and open the directory which is created in the previous step; Delete the directory in WindowA.

Review URL: https://codereview.chromium.org/639273002

Cr-Commit-Position: refs/heads/master@{#299076}

BUG=421277
TEST=components_unittests
R=tengs@chromium.org

Review URL: https://codereview.chromium.org/629183003

Cr-Commit-Position: refs/heads/master@{#299075}

BUG=

Review URL: https://codereview.chromium.org/644943002

Cr-Commit-Position: refs/heads/master@{#299074}

This improves the execution speed by a factor 3x, and I think they're
just as correct. Essentially we are waiting until we see a good
aspect ratio, rather than the old behavior which was to wait 10x50 ms
and see if we have a good aspect ratio. This wasn't a problem on fast
machines, but it's a big problem on bots with GPU emulation where
canvas operations are expensive.

BUG=417756
R=perkj@chromium.org,mcasas@chromium.org

Review URL: https://codereview.chromium.org/638423002

Cr-Commit-Position: refs/heads/master@{#299073}

The test is no longer needed.
Reverted revision: crrev.com/293821

BUG=NONE
TEST=NONE

Review URL: https://codereview.chromium.org/644923002

Cr-Commit-Position: refs/heads/master@{#299072}

Cr-Commit-Position: refs/heads/master@{#299071}

1) Avoid using 'us' as password layout for those layouts can be remapped to 'us'.
2) Norwegian decoding language should be 'no', and password layout
should not be no.compact.qwerty instead of us.compact.qwerty.
3) Korean 2set IME can use m17n:ko_2set layout.
4) Korean IMEs OSK url uses hash to support fast switching.

BUG=416504
TEST=Verified on linux_chromeos.

Review URL: https://codereview.chromium.org/646863004

Cr-Commit-Position: refs/heads/master@{#299070}

This cl change the mock to create remote mediastreams based on the mediastreams that have been added as local mediastreams. The remote streams are updated once RTCPeerConnection::setRemoteDescription is called. The purpose is to be able to test remote mediastreams in blink layouttests.

BUG=417245

Review URL: https://codereview.chromium.org/597283006

Cr-Commit-Position: refs/heads/master@{#299069}

This splits the DRT-specific parts of ShellBrowserContext out into a new
class that we'll only instantiate when the flag is set.

BUG=420994

Review URL: https://codereview.chromium.org/637843003

Cr-Commit-Position: refs/heads/master@{#299068}

BUG=401588
R=brettw@chromium.org, thestig@chromium.org, blundell@chromium.org
TEST=manually

Review URL: https://codereview.chromium.org/637163002

Cr-Commit-Position: refs/heads/master@{#299067}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/8f1f7f8..494f910

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/641313002

Cr-Commit-Position: refs/heads/master@{#299066}

Part #1 in fixing the synced devices menu.

R=dmazzoni@chromium.org
BUG=362424

Review URL: https://codereview.chromium.org/642223002

Cr-Commit-Position: refs/heads/master@{#299065}

R=dmazzoni@chromium.org
BUG=419272
TEST=hold delete on history page => no assertions or double messages

Review URL: https://codereview.chromium.org/643013002

Cr-Commit-Position: refs/heads/master@{#299064}

BUG=None
TEST=None
TBR=sky

Review URL: https://codereview.chromium.org/639183004

Cr-Commit-Position: refs/heads/master@{#299063}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/644903002

Cr-Commit-Position: refs/heads/master@{#299062}

A histogram entry is emitted each time a browser window enters fullscreen. Each
entry has 3 associated parameters:
  - Whether the mechanism used was AppKit or Immersive.
  - Whether the window was on a primary or secondary screen.
  - Whether the "Displays have separate spaces" option in mission control was
  enabled.

BUG=

Review URL: https://codereview.chromium.org/600303003

Cr-Commit-Position: refs/heads/master@{#299061}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/232f6b0..8f1f7f8

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=reed@google.com

Review URL: https://codereview.chromium.org/639973003

Cr-Commit-Position: refs/heads/master@{#299060}

Cleaning up weak_ptr_factory destruction order.
WeakPtrFactory should remain the last member so it'll be destroyed and
invalidate its weak pointers before any other members are destroyed.

BUG=303818

Review URL: https://codereview.chromium.org/612783003

Cr-Commit-Position: refs/heads/master@{#299059}

This patch adds:
1. Flag supports_notify_tag to chrome.fsp.mount().
2. Method chrome.fsp.Notify() to notify about changes of observed entries.
3. Events chrome.fsp.OnObserveDirectory and OnUnobserveEntry.

Missing things, to be added in a separate patch:
1. Glueing chrome.fsp.Notify to the C++ layer properly, not with fake data.
2. Saving and restoring observed entries together with tags from preferences.

TEST=unit_test: *FileSystemProviderProvidedFileSystem*,
     *FileSystemProvider*Observe*, *FileSystemProvider*Unobserve*
BUG=248427

Review URL: https://codereview.chromium.org/625463002

Cr-Commit-Position: refs/heads/master@{#299058}

BUG=421767
TEST=Open Gallery.app; In slide mode, delete all images by clicking bottom-right delete button.

Review URL: https://codereview.chromium.org/638383002

Cr-Commit-Position: refs/heads/master@{#299057}

This step is a giant search and replace for OVERRIDE to
replace them with their lowercase versions.

BUG=417463

Review URL: https://codereview.chromium.org/631683002

Cr-Commit-Position: refs/heads/master@{#299056}

Move geometry, input_event and surfaces TypeConverters.
Move conversion-related helpers and tests as well.

Flatten lib sub-directories into their parents.
Update includes, guards, DEPS, GYP, and GN.
Add mojo_converters.gypi to avoid a false-positive cycle.

BUG=421234
TEST=No GYP, GN, compile, or link problems.
R=jamesr@chromium.org
TBR=reed@google.com,sadrul@chromium.org,piman@chromium.org

Review URL: https://codereview.chromium.org/640893003

Cr-Commit-Position: refs/heads/master@{#299055}

The IPC that is used to send tooltip text to BrowserPlugin was sent on every mouse movement, and unnecessarily sent the same text repeatedly. This is now checked and only new text is actually sent.

Review URL: https://codereview.chromium.org/638253004

Cr-Commit-Position: refs/heads/master@{#299054}

BUG=421840
TEST=manually

Review URL: https://codereview.chromium.org/644883002

Cr-Commit-Position: refs/heads/master@{#299053}

This implements proper out-of-process support for SurfaceTexture backed
GpuMemoryBuffers using our generic GPU service side GpuMemoryBuffer
allocation mechanism. Both renderer and browser compositor usage is
supported.

BUG=368716,418553
TBR=jln@chromium.org,sky@chromium.org

Review URL: https://codereview.chromium.org/634643002

Cr-Commit-Position: refs/heads/master@{#299052}