- 27 Sep, 2020 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fab653f821de..bdcc75794121 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1127088 Tbr: Change-Id: I810d2ae392a50c8310775e6bfe9b9a494b0003be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434384Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811066}
-
Maks Orlovich authored
Verifying vs. RenderFrameHostImpl's UKM ID doesn't work due to the frame ID's potentially changing interpretation when the fetch races against a navigation. (I am really looking forward towards RenderDocumentHost...) Bug: 1131134 Change-Id: I66e1e0ed160994dbe3473f5a21495d38566b9cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429235Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Cr-Commit-Position: refs/heads/master@{#811065}
-
Chromium WPT Sync authored
Using wpt-import in Chromium c913d715. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I77c6315bd04295cfe6cba8eeb68bf017e5ae1e38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434244Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811064}
-
tby authored
Bug: 1034842 Change-Id: I95859612d1603a1fe87641d636c29a7de8dbc658 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426668Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#811063}
-
Gang Wu authored
If screen space is limited, app menu should show one and an half of the menu item at least. Bug: 1132258 Change-Id: I4721c4fb5d4eacf415c56e1aa112d8f7647a5227 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432764 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#811062}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_h8KubnXkcH - Diagnostics Page (after) http://shortn/_NHJD1CxaNh Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic6fe3463c089d1f0b5150f1be128621cbb28623a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432125 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#811061}
-
Michael Checo authored
Screenshots: - Diagnostics Page (before) http://shortn/_h8KubnXkcH - Diagnostics Page (after) http://shortn/_uW8J9zp2i5 Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: Ic649e7c4a84f9bdb27f3050aee4e0b821c49c76d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429823 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
-
David Bienvenu authored
Also fix cpp lint warnings. No functional changes. Bug: 1010217 Change-Id: I60c13a4f4667522c7661b3ab91b948e71a06e657 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2432204 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#811059}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009270800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/0WU_n4W64ltaAxz5MUUNLa1sbT9wx_IZiR2vRW6vn2sC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: Ia8d11c7e3c6eef3d59258d79ef3af1a32aedadf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433986Reviewed-by:
-
tby authored
The LSP can DCHECK when calculating query/title score matches, because the query or title text can be empty. This is partly because the LSP runs even on zero-state searches, and (perhaps) partly because files can have no title. This CL adds various checks to prevent calculating scores when we don't have both a query and title. It also stops the LSP from running at all on zero-state searches. Bug: 1131358 Change-Id: I65c264def66e83f1c7fd47956eb0a9ddf59e099e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426088Reviewed-by:
-
Antonio Gomes authored
This is (a drive by CL) part of effort to reduce the dependency of /caption_buttons/ on other parts of //ash/public/cpp/. It also removes some trailing tablet_mode.h includes from //chrome as well. BUG=1113900 R=sky@chromium.org TBR=alemate@chromium.org Change-Id: Ied7a7395ce7ad103fd3ba42282dd55ca1913cc60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431727 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#811056}
-
Nick Diego Yamane authored
TL;DR: Wayland Protocol needs to be extended to make it possible to properly support full Chromium's tab dragging experience. Further details in the Design document [1]. This is the first of a patch series which implements extended-drag extension in Exo compositor, adding the protocol descriptor XML file, boilerplate code as well as a stub implementation of it. Follow-up CLs will incrementally implement the extension features and start using it in Chromium Ozone/Wayland (client-side). ----------------------------------------------------------------------- An overview of how this protocol is aimed to be used in a tabdrag-like scenario, but in generic terms, is outlined below: 1. An UI item (eg: a tab in a tab bar) starts to be dragged within shell surface A owned by source client S. At some point, it gets far enough from its original location and S then starts a Wayland "extended drag" session, which protocol-wise requires to: 1.1. Create a wl_data_source, set one (or more) mime type and the supported dnd actions; 1.2. Create a zcr_extended_drag_source for the newly created drag source. Here it is possible to set a few options, such as: - ALLOW_SWALLOW: determines that the dragged item can be attached (or incorporated, also referred to as "swallow" in this protocol) to another surface, including use cases such as Chrome's tab drag. - ALLOW_DROP_NO_TARGET: In the standard DND protocol, dropping something outside shell surfaces lead to a wl_data_source::cancel, which is problematic in use cases such as tab drag, preventing us from detecting when it was really cancelled, e.g: ESC pressed. - LOCK_CURSOR: Keep the cursor shape unchanged during the whole session. Ultimately, having an extended drag source attached to the wl_data_source used to wl_data_device::start_drag instructs the compositor to run the drag session in the "extended mode". 1.3 Start the drag session as usual (i.e: wl_data_source::start_drag), with a null drag icon surface. Assuming that we're still in attached mode for now. In addition, from now on, client S must start watching for wl_data_device::{enter,leave,motion} events in order to be able to detect the next actions and state transitions as the user drags the UI item around. 1.4 Store the (x_offset, y_offset) location where the drag started in S and keep them synced to the values received in wl_data_device::motion() events. 2. Once the drag gets far enough from the original UI item's container (ie: tab bar), it's time to detach (or unswallow) it from surface A. To achieve it, client S must: 2.1. Create a new wl_surface B + its corresponding shell surface, e.g: a toplevel xdg surface where a new detached browser window will rendered to in Chrome's tab drag use case; 2.2. Issue a zcr_extended_drag_source::drag(B, x_offset, y_offset) request, which tells the compositor (in advance) that B must be set as the extended-drag surface, using x and y offsets to translate it from the current pointer location; 2.3. Map surface B (configure, attach buffer, etc) as usual. After this B's shell surface should show up tied to the mouse pointer and the compositor is supposed to take care of it, putting it in a special state where, for example, it does not receive events, etc, acting just like a standard DND "drag icon". At this point, the "unswallow" operation is done and the extended-drag session enters in detached state. 3. Supposing the drop happens while in detached state, there are 2 possible flows, which depend on whether ALLOW_DROP_NO_TARGET config is set or not (see 1.2). If it is set, wl_data_source::dnd_finished event is sent to the source client S, otherwise wl_data_source::cancelled is sent. 4. Otherwise, if before dropping, the pointer enters surface C, owned by client T. T receives a wl_data_offer O through wl_data_device::offer event as usual, to which it can attach a zcr_extended_drag_offer XO to it by issuing zcr_extended_drag::get_extended_drag_offer(O). Target client T, then starts monitoring wl_data_device::motion events, so that it can trigger a swallow based on where the pointer is. If B is dragged over a region that leads to a swallow, T must: 4.1 Issue a zcr_extended_drag_offer::swallow(serial, mime) request, asking source client S to incorporate the dragged item into its UI. S then receives a zcr_extended_drag_source::swallow(mime) event and it can accept it by calling zcr_extended_drag_source::drag(null, 0, 0), so client T can finally render it as part of its UI. At this point, the session is back to a state similar to 1.4. So, similarly to 2, once the drag gets far enough, T might want to unswallow (aka: detach) the UI item. In order to do so it must: 4.1.1 Call unswallow(serial, mime, x_offset, y_offset) on the extended-drag offer XO (created at step 4), whereas the offsets tell how the dragged surface must be positioned related to the pointer location. Client S will then receive a zcr_extended_drag_source::unswallow(mime, x_offset, y_offset) event so that it can create and map a new surface D and issue a zcr_extended_drag_source::drag(D, x_offset, y_offset), same as in step 2.3, making surface D to show up under the pointer. At target side, T can then re-render its UI without the dragged item. This finishes the unswallow (or detaching) operation, transitioning the session back to "detached" state. [1] https://docs.google.com/document/d/1s6OwTi_WC-pS21WLGQYI39yw2m42ZlVolUXBclljXB4/edit?usp=sharing Bug: 1099418 Change-Id: I8d876e96e45717c625c1d1bdcc269b100524cbc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2307653 Commit-Queue: Nick Yamane <nickdiego@igalia.com> Reviewed-by:Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#811055}
-
Yuta Hijikata authored
In order to build lacros-chrome with target_os="chromeos", we will be replacing existing defined(OS_CHROMEOS) with BUILDFLAG(IS_ASH) where appropriate i.e. the parts only needed for ash-chrome. For more detail please read the design doc go/lacros-build-config. Test: None Bug: 1052397 Change-Id: Iee48f0a3cc37efbee1b7959c9340d1255e735a1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426071Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Yuta Hijikata <ythjkt@chromium.org> Cr-Commit-Position: refs/heads/master@{#811054}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 69467c7c. With Chromium commits locally applied on WPT: 74e4b2fc "[COOP] access reporting: Use infinite timeout for receive." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=foolip@google.com No-Export: true Change-Id: I367c3750ac47dbbd1a7c4b0d889a6cea557ba974 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433474Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601185204-f94c687281888552298caf7544ad9515cd75dc6d.profdata to chrome-mac-master-1601207727-a01abff7a6bd2da6f6116384bec1a348a3a7afe9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: Icdf5d06d39e72feecdaf424c4a3080f0f2623b40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433904Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811052}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601185204-ea08500963e5ec1d97fc799611c84c5499e59042.profdata to chrome-linux-master-1601207727-0dd0eb0febc74c41e7a623fe044ff01ea199dede.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: I360a4e2bed07474701c46c26b4779d36a159e44a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433888Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/aaed4d13394f..d6aeaf33afbe 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4b973b8986bf6bb1f9b70d7d11a444c6b2b5475c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433887Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I8143fd83dbbd803046e308580bfd178cf2d41b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433886Reviewed-by:
-
Jinsuk Kim authored
user_education/ is used as a shim allowing the classes in chrome/android::chrome_java to use feature_engagement component. This CL modularizes it under chrome/browser/user_education so that toolbar/ can use it without relying on chrome_java. Bug: 1127732 Change-Id: I33d2e4851914f743f72540181f1cc222f2c6d70e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422060 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#811048}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/d3db8535d3a9..111de34102c7 2020-09-27 marinaciocea@webrtc.org Revert "Delete the non-const version of the EncodedImage::data() method." 2020-09-26 deadbeef@webrtc.org Fix for OnSctpInboundPacket being called after transport destruction. 2020-09-26 tommi@webrtc.org Move win32 files to a new "win32" target to avoid cyclic dependencies. 2020-09-25 peah@webrtc.org Clean up the AVX2 activation in the gni file 2020-09-25 ricebin@google.com Allow clients to provide custom scheduler to AudioModule 2020-09-25 peah@webrtc.org Reland "Activating AVX2 support by default" 2020-09-25 alessiob@webrtc.org AGC2 AdaptiveModeLevelEstimator min consecutive speech frames (1/3) 2020-09-25 alessiob@webrtc.org AGC2 VAD probability: instant decay / slow attack 2020-09-25 nisse@webrtc.org Delete the non-const version of the EncodedImage::data() method. 2020-09-25 peah@webrtc.org Revert "Activating AVX2 support by default" 2020-09-25 alessiob@webrtc.org AGC2 VadWithLevel(::LevelAndProbability) renamed + injectable VAD 2020-09-25 tommi@webrtc.org Make MessageHandler be a pure virtual interface. 2020-09-25 peah@webrtc.org Activating AVX2 support by default 2020-09-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 063275b4..0957d98f (810396:810507) 2020-09-25 kwiberg@webrtc.org Fix RoboCaller::Send perfect forwarding If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1127774 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I663abdef701485f79a495a4af0f3ff1790095b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433884Reviewed-by:
-
Nazerke authored
This CL adds a view controller for the TabStrip and adds it as a property to TabStripCoordinator along with other its required properties. Bug: 1128249,1130401, 1130400 Change-Id: I891ee1f2d5551aba7ce39c7fa68d8dfe0c56ac3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421108Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Cr-Commit-Position: refs/heads/master@{#811046}
-
Jinsuk Kim authored
Triggering requests may come after the action delegate is nulled out when the activity is being destroyed, which can cause crashes for swipes on the rendered pages. This CL checks the situation and ignores the requests accordingly. Bug: 1131424 Change-Id: I4914ef220638ea69cf1522aa2ac974c73ed89ece Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428512 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#811045}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/25acdad71bae..fab653f821de If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: Change-Id: I89d643f0b2e5de2e01ae36b24708b2650e9619f8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433078Reviewed-by:
-
Satoshi Niwa authored
If launchParams.searchQuery is set, 1) Performs a search at Files app start up. 2) Select the first root directory that contains one or more query-matched files. Also did refactoring around DirectoryModel.createDirectoryContents_(...) - Split createDirectoryContents_ into 2 functions isSearchDirectory(...) and createScannerFactory() - Removed all DirectoryContents.createFor*(...) functions. For now we expect that the searchQuery param is used only when Files app is launched as Android file picker. 1) and 2) are required by DocumentsUI CTS (See go/arc-r-documents-ui) Bug: 1126742 Test: atest DocumentsTest#testGetContentWithQuery_matchingFileShowing Change-Id: I1a76a93ee7fbf7ce7ae3fdd2a3dc408311bbd12a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408502Reviewed-by:
Naoki Fukino <fukino@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Satoshi Niwa <niwa@chromium.org> Commit-Queue: Satoshi Niwa <niwa@chromium.org> Cr-Commit-Position: refs/heads/master@{#811043}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I04c734f74b61a785b0c37210bbd1a13e3c5d5ad3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431418Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#811042}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601161893-c98711c556128fe090127be76465e02b263358c0.profdata to chrome-linux-master-1601185204-ea08500963e5ec1d97fc799611c84c5499e59042.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ife984df8eebe63c740bb5f4d05fbab3b39dde6ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433717Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601161893-754a2aafc98ad7a6afd910c0b7dd36e782bfe76d.profdata to chrome-mac-master-1601185204-f94c687281888552298caf7544ad9515cd75dc6d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I71738c95f8aab7edf3702c5ee5d3e14f69bb0b9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433714Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c28560a53906..aaed4d13394f 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Icaf177c0eb6a6b14ddd3517252c0391f836683cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433797Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/eabce08bb2f2..0922403dcdc6 2020-09-27 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: brianosman@google.com Change-Id: Ic33d94ece81c8cb3f5a95c4809d608467c9c5cda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433796Reviewed-by:
-
Pavel Yatsuk authored
This is a basic implementation of MessageQueueManager. MessageQueueManager: - maintains a queue of messages and a mapping from message key objects to MessageStateHandlers. - shows the message at the head of the queue - hides and dismisses the message when it gets dismissed through the API BUG=1123947 R=lazzzis@chromium.org Change-Id: Ifa3fbba6162323bdc79305796472fdaea0829ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2416740 Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Lijin Shen <lazzzis@google.com> Cr-Commit-Position: refs/heads/master@{#811037}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ie72832249a82eace947bf1ffe9927e72f675252d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433603Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/ddef7a04a2d3..ed2b465f8607 2020-09-27 jiawei.shao@intel.com Report more detailed error information for the failures of mapAsync If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I2913a4925ec804aa90f6c658f35c3f387fe4b592 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433600Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/1815d86a224b..d0e7ed37fc4e 2020-09-27 cstout@chromium.org [spirv-remap] Fix undefined behavior in hashing (#2403) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,syoussefi@google.com Change-Id: I7eefd643d430a39345a3081b3bf3dce49b96c457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433595Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/7950eb55c076..c28560a53906 2020-09-27 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib9be59235f9aefa0e3ef20acb6674e13014cc8fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433785Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1601143179-1807d013279f571b26d42737d0da6c008dd25766.profdata to chrome-mac-master-1601161893-754a2aafc98ad7a6afd910c0b7dd36e782bfe76d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand@chromium.org,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib976d6e3040067f412fa44b4903e8043f42b968f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433599Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1601143179-7e0fff784977a232da08a71c4f8ef38f5aa5597c.profdata to chrome-linux-master-1601161893-c98711c556128fe090127be76465e02b263358c0.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand@chromium.org,jeffyoon@google.com Change-Id: I452d22410810f73db2b1b1e48dfbeb3348e6723c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433597Reviewed-by:
-
Claude van der Merwe authored
The following changes are made: 1. WifiSyncFeatureManager is injected into FeatureStateManager. 2. PerformSetFeatureEnabledState relies on WifiSyncFeatureManager to set enable/disable Wifi Sync, which acts as a global toggle. 3. GetEnabledOrDisabledState relies on WifiSyncFeatureManager to get the enabled/disabled state for Wifi Sync. 4. Add fakes for WifiSyncFeatureManager to be used in feature_state_manager_impl unittests Bug: 1117619 Change-Id: I68e6cad0e9d878d4029dea9cfeedc52dcee4a4b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2419451 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Jon Mann <jonmann@chromium.org> Cr-Commit-Position: refs/heads/master@{#811030}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/dff9331631e4..6f521921351e 2020-09-26 syoussefi@chromium.org Vulkan: Use one triangle for full-screen utils 2020-09-26 syoussefi@chromium.org Revert "Add a small unit test that dumps system info." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC syoussefi@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: syoussefi@google.com Change-Id: I62e4b00da2b954fa5539d79b8e5698e9315ccabb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433531Reviewed-by:
-
Reilly Grant authored
On systems with both the built-in serial driver and a third-party driver the same port can be enumerated more than once. This difference is visible to the user in the device path shown in the chooser but was previously ignored when constructing a persistent ID for the port. This patch replaces the generic persistent ID field with the individual components that are available on each platform. This should make it easier to modify these rules over time as the components won't be opaque to SerialChooserContext. This is a breaking change which will cause previously granted persistent permissions to be ignored. On macOS the name of the USB driver (the parent of the BSD serial port) is now included in the set of fields used to identify a device in order to differentiate between USB devices with otherwise have the same USB vendor ID, product ID and serial number. Bug: 1127535 Change-Id: If1b06ab82a975976e1e3b7d2075216f11afda5dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2413176 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
James Hollyer <jameshollyer@chromium.org> Cr-Commit-Position: refs/heads/master@{#811028}
-
Antonio Gomes authored
Some constants in ash_constants.h are used in BrowserNonClientFrameViewAsh. In order to make this class available to lacros, these constants need to be factored out, once lacros chrome can not link to ash symbols. The following constants are moved: ash::kDefaultFrameColor ash::kResizeAreaCornerSize ash::kResizeInsideBoundsSize ash::kResizeOutsideBoundsSize ash::kResizeOutsideBoundsScaleForTouch now under the `chromeos` namespace. Also, CL adds a README.md to chromeos/ui directory. This is phase 2.2 on the design document [1]. [1] https://docs.google.com/document/d/1xHwcHrAiEaWuA4usGEqKZ9zm1H8SGk3WkS-Jf2Q_los/ BUG=1113900 R=jamescook@chromium.org Change-Id: I01cf20ed5a77f752fee2c72df0d5cb0cf42125a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429441Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#811027}
-
