- 24 Aug, 2018 40 commits
-
-
Hans Wennborg authored
Previously we used a GCC/libstdc++ package from Ubuntu Precise to build a Clang that would work on Precise or later. These days, all bots and developers are on Trusty or later, so this should no longer be necessary. Besides simplifying things, this allows us to easier move to using the latest CMake when building Clang, because it was built with a newer libstdc++ than the Precise one. Bug: 797991 Change-Id: I528825389241f60ccc96167015370cd5e285725d Reviewed-on: https://chromium-review.googlesource.com/1188679Reviewed-by:
Reid Kleckner <rnk@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#585953}
-
John Abd-El-Malek authored
Move the code to call certificate verification from content/browser to services/network. Bug: 803774 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: I7a7c6c986afa8340a6467d26024e6382b8b2f13b Reviewed-on: https://chromium-review.googlesource.com/1182872 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#585952}
-
Morten Stenshorne authored
Should use min-inline-size instead of min-width, so that it works as intended in vertical writing modes too. See https://github.com/whatwg/html/pull/3914 Bug: 874053 Change-Id: I4fd4bd74606721bb44170a926f8be3d98a67db3e Reviewed-on: https://chromium-review.googlesource.com/1188678Reviewed-by:
Emil A Eklund <eae@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#585951}
-
Theresa authored
BUG=874966 Change-Id: I77bf82689f064128bcd9a511c8be19d1403dc4ff Reviewed-on: https://chromium-review.googlesource.com/1188440Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#585950}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/284c5139836c..ce26d7d03d6c git log 284c5139836c..ce26d7d03d6c --date=short --no-merges --format='%ad %ae %s' 2018-08-24 thestig@chromium.org Change CPDF_MetadataTest test data to static const char data[]. Created with: gclient setdep -r src/third_party/pdfium@ce26d7d03d6c The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Ida777df324abe42e083dd2f1fa9ce1c470aee85f Reviewed-on: https://chromium-review.googlesource.com/1188511Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#585949}
-
Robert Liao authored
The removal of the light assets will be in a separate change. BUG=722573 Change-Id: I58e84da3fa4f149cad0a0048ee912eba1a1c9755 Reviewed-on: https://chromium-review.googlesource.com/1185786 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#585948}
-
Chris Mumford authored
This is a switch from using net::URLFetcher to network::SimpleURLLoader as part of the network serviceification effort. Bug: 876470 Change-Id: Ib47afb4a3a3b10735204fd5fdf131844d3107d51 Reviewed-on: https://chromium-review.googlesource.com/1187339Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Mumford <cmumford@chromium.org> Cr-Commit-Position: refs/heads/master@{#585947}
-
Chase Phillips authored
Part 2 in moving the IDB Mojo file from content/common/indexed_db/ to third_party/blink/public/mojom/indexeddb/indexeddb.mojom. This commit: - moves IndexedDBKeyPath from content to blink This commit converts Chromium to the following Mojom types: - indexed_db.mojom.KeyPath -> blink.mojom.IDBKeyPath Bug: 717812 Change-Id: I286081555c62c18c5f423813a41035ce8316d494 Reviewed-on: https://chromium-review.googlesource.com/1185790 Commit-Queue: Chase Phillips <cmp@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#585946}
-
John Abd-El-Malek authored
One file, which normally fails loading, sometimes loads depending on timing of network data. Bug: 874259 Change-Id: Ieeccd75c79f19499887fb72b99affedac89a560d Reviewed-on: https://chromium-review.googlesource.com/1187889Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585945}
-
yoshiki iguchi authored
This CL add a "Change" button to open lock screen notification setting next to the message "Notifications are hidden" in the unified system tray on the lock screen. This CL just adds a button which doesn't work. The code to open the setting is separated. Bug: 864964 Test: manual (see the button in the unified systray) Change-Id: I812fc1369d4020044e22874a83cafb187f173e31 Reviewed-on: https://chromium-review.googlesource.com/1176301 Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#585944}
-
Ben Kelly authored
Many of the timing histograms in cache_storage have been hitting the default 10 second cap. Convert the histograms to use LONG_TIMES to increase the maximum to 1 hour so that we can see real values. R=jsbell@chromium.org Bug: 874868 Change-Id: Ida097a80aee2f8181a4eb2526d1f55e0aa8da77c Reviewed-on: https://chromium-review.googlesource.com/1186822 Commit-Queue: Ben Kelly <wanderview@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#585943}
-
John Abd-El-Malek authored
One of the callsites, for browser-initiated requests, was calling it. Change-Id: Ifa9ffa30e0961b10fba1200fc6c79d5bb304b234 Reviewed-on: https://chromium-review.googlesource.com/1187136Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#585942}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 28091394. Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/23221 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/resources rego@igalia.com: external/wpt/css/selectors rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I39c5a858e7d96eb3e21f08508c42f998d7c97390 Reviewed-on: https://chromium-review.googlesource.com/1188439 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#585941}
-
Melisa Carranza Z authored
platforms. Bug: b/111922445 Test: Successfully build CastShell. Change-Id: Iaf61f099001370fb3b948654e126ffa91f6e57d7 Reviewed-on: https://chromium-review.googlesource.com/1186147Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Commit-Queue: Melisa Carranza Zúñiga <melisacz@google.com> Cr-Commit-Position: refs/heads/master@{#585940}
-
gogerald authored
Note that there is a warning for the interface CreateFrom1xBitmap that WARNING: The resulting image will be pixelated when painted on a high density display. Change-Id: I59011a994a5766999e1af64f7082542cbde88dc6 Reviewed-on: https://chromium-review.googlesource.com/1188743Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585939}
-
Will Harris authored
This is a false positive which is hitting when mojo is trying to marshall an array of a 64-bit primitive type. e.g. interface VisitedLinkNotificationSink defines a method AddVisitedLinks(array<uint64> link_hashes) and results in this warning: [1243/29517] CXX obj/components/visitedlink/common/interfaces_shared_cpp_sources/visitedlink.mojom-shared.obj In file included from gen/components/visitedlink/common/visitedlink.mojom-shared.cc:10: In file included from gen\components/visitedlink/common/visitedlink.mojom-shared.h:17: In file included from ../..\mojo/public/cpp/bindings/array_data_view.h:10: ../..\mojo/public/cpp/bindings/lib/array_internal.h(140,48): warning: implicit conversion loses integer precision: 'const mojo::internal::ArraySerializationHelper<unsigned long long, false, false>::ElementType' (aka 'const unsigned long long') to 'int32_t' (aka 'int') [-Wshorten-64-to-32] if (!validate_params->validate_enum_func(elements[i], validation_context)) ~~~~~~~~~~~~~~~ ^~~~~~~~~~~ ../..\mojo/public/cpp/bindings/lib/array_internal.h(344,20): note: in instantiation of member function 'mojo::internal::ArraySerializationHelper<unsigned long long, false, false>::ValidateElements' requested here return Helper::ValidateElements(&object->header_, object->storage(), ^ ../..\mojo/public/cpp/bindings/lib/validation_util.h(160,13): note: in instantiation of member function 'mojo::internal::Array_Data<unsigned long long>::Validate' requested here T::Validate(input.Get(), validation_context, validate_params); ^ gen/components/visitedlink/common/visitedlink.mojom-shared.cc(127,24): note: in instantiation of function template specialization 'mojo::internal::ValidateContainer<mojo::internal::Array_Data<unsigned long long> >' requested here if (!mojo::internal::ValidateContainer(object->link_hashes, validation_context, ^ 1 warning generated. However, since enum validation actually only happens when the array contains enums, and enums are defined by mojo to be 32-bit (see enum_macros.tmpl) it's safe to downcast here. BUG=588506 Change-Id: I565b40987799bcac465319cd83ee22c5c279be99 Reviewed-on: https://chromium-review.googlesource.com/1185880Reviewed-by:Ken Rockot <rockot@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#585938}
-
https://chromium-review.googlesource.com/c/chromium/src/+/1185786Robert Liao authored
BUG= TBR=grt@chromium.org Change-Id: I419ac4198888416170e1cb7ce56119219f79903f Reviewed-on: https://chromium-review.googlesource.com/1188769Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#585937}
-
Xiaohan Wang authored
On Android, change the default protected media identifier content setting from ASK to ALLOW. See Bug for more context on this change. For existing profiles, if user has not changed the setting before (so it remains the old default which is ASK), the new default value (ALLOW) will automatically take effect. If user has changed the setting (the only possibility is BLOCK), this setting will stay unchanged. Bug: 854737 Test: Manually tested Change-Id: I732961672bec453c3e985848f0848b0754f180e9 Reviewed-on: https://chromium-review.googlesource.com/1184509 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#585936}
-
Jun Mukai authored
PointerWatcher will receive OnPointerEventObserved with the location in screen coordinate, but the current code simply makes an offset of the current display to the event location. When the event has the target window, the event location is relative to the target window, which makes the location incorrect. This CL fixes such situation. Bug: NONE Test: views_mus_unittests with new test cases Change-Id: I600db85fe054689f57e4dfbc6a039ec87cf0133d Reviewed-on: https://chromium-review.googlesource.com/1186062 Commit-Queue: Jun Mukai <mukai@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585935}
-
Oystein Eftevaag authored
This is a reland of 32c8ebbe The last Perfetto roll in https://chromium-review.googlesource.com/c/chromium/src/+/1188362 includes a fix for the bug that caused the revert. Original change's description: > Enable Perfetto by default for all telemetry tests > > This will use Perfetto instead of TraceLog for all > trace-based Telemetry tests running on Mac/Windows/Android. > > R=nednguyen@google.com > > Bug: 839084 > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01 > Reviewed-on: https://chromium-review.googlesource.com/1176119 > Commit-Queue: oysteine <oysteine@chromium.org> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > Reviewed-by: Ned Nguyen <nednguyen@google.com> > Cr-Commit-Position: refs/heads/master@{#585368} TBR=nednguyen@google.com Bug: 839084 Change-Id: Id416f7f81ae4f0056e80b678c32e608c2021d2ea Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi Reviewed-on: https://chromium-review.googlesource.com/1188752Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#585934}
-
Sergey Ulanov authored
Send() method in P2PSocketUdp and P2PSocketTcpBase checks that packet size is under the limit, but it wasn't handling the error correctly. Bug: 877514 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: If4ee08051d1085cbdb995868790dacf622b09aad Reviewed-on: https://chromium-review.googlesource.com/1188751Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585933}
-
Kyle Horimoto authored
This CL: (1) Moves SmartLock's enabled and allowed preferences to the MultiDeviceSetup service (see go/cros-multidevice-prefs). (2) Renames existing preferences so that they are named in the same format. (3) Removes some of these preferences from the settings whitelist, since they are not edited in settings. Note: This CL unblocks adding enterprise policies to FeatureStateManager, which must have access to the preferences. TBR=stevenjb@chromium.org Bug: 870113, 824568 Change-Id: Icffa4ed6b80095dd51e53b30a352289f584deba7 Reviewed-on: https://chromium-review.googlesource.com/1186033 Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:Michael Giuffrida <michaelpg@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Cr-Commit-Position: refs/heads/master@{#585932}
-
Scott Violet authored
This reverts commit 2e7bbc1f. Reason for revert: Caused build failure Original change's description: > window-service: moves most mojoms to ws namespace > > This also removes window_manager_constants as it was not used. > > BUG=876924 > TEST=covered by tests > TBR=msw@chromium.org,tsepez@chromium.org > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel > Change-Id: I32224509d1f7264088333c674544559a8759729a > Reviewed-on: https://chromium-review.googlesource.com/1188427 > Reviewed-by: Scott Violet <sky@chromium.org> > Commit-Queue: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#585924} TBR=sky@chromium.org,msw@chromium.org,tsepez@chromium.org Change-Id: Id6a4f068bb134122a3557b1c93e3c70e37d1d382 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 876924 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/1188761Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585931}
-
Wenzhao Zang authored
cvox.Api.speak may work but it requires goog.provide and goog.require. Instead we could focus the checkmark and ChromeVox will announce its aria-label. This is a no-op for non-ChromeVox users. Bug: 779449 Change-Id: I48de41156bb66e86d5e6051963f25be8355e12e0 Reviewed-on: https://chromium-review.googlesource.com/1187822 Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org> Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Cr-Commit-Position: refs/heads/master@{#585930}
-
Justin Cohen authored
Bug: 877195 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I6b94acbe327886c90b640b149099db62c17c7719 Reviewed-on: https://chromium-review.googlesource.com/1188609 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#585929}
-
Joe Downing authored
This is a clean-up CL which moves all of the LocalInputMonitor related classes into their own folder and provides a public header and lib for usage by the rest of the host classes. Change-Id: I0a9ced94750d0724f99dace24c991fd3194eebb4 Reviewed-on: https://chromium-review.googlesource.com/1185298 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585928}
-
Chris Blume authored
Previously, ParentLocalSurfaceIdAllocator would default to an invalid LocalSurfaceId. A new LSI had to be explicitly allocated before the normal behavior could use it. With ParentLocalSurfaceIdAllocator now default initializing a valid LSI, the various call sites no longer need to explicitly check for the uninitialized state. services/ui/ has some of those call sites. BUG=837030 Change-Id: I1b82b0133de0ecc3e8fa71f5a40f25762732ccf3 Reviewed-on: https://chromium-review.googlesource.com/1038144 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#585927}
-
Sandra Sun authored
Some tests in scrollTo-scrollBy-snaps.html are failing on wpt dashboard. This is caused by the uncertainty of the window size for testharness tests. If the window size becomes small enough that the snap area covers the snapport, the expected snap position is ignored because any scroll position is considered a valid snap position. This patch changes the landing position of scrollTo and scrollBy for failing cases so that the snap area does not cover ths snapport regardless of the window size. More specifically, the snap area's vertical and horizontal dimensions are 600px each thus covering the [1000, 1600] range with expected snap position at 1000. Previously if the test vertically scrolled to 1200 and the window's size is smaller than 400, the snap area will cover the window. Now the test scrolls to 900 (100px before the snap position), ensuring that the target snap area won't cover the window regardless of the size. Bug: 876052 Change-Id: I448ecb1e3cc2cc458d467472ca38d49bf01d2901 Reviewed-on: https://chromium-review.googlesource.com/1182299 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#585926}
-
Scott Haseley authored
This CL adds versions of FirstContentfulPaint, FirstMeaningfulPaint, and FirstInputDelay metrics that are bucketed by the number of live tabs open in the browser. The following metrics are added: PageLoad.Experimental.PaintTiming.NavigationToFirstMeaningfulPaint.ByLiveTabCount.<BucketRangeSuffixText> PageLoad.PaintTiming.NavigationToFirstContentfulPaint.ByLiveTabCount.<BucketRangeSuffixText> PageLoad.InteractiveTiming.FirstInputDelay.ByLiveTabCount.<BucketRangeSuffixText> <BucketRangeSuffixText> corresponds to the LiveTabCountMetrics histogram_suffixes in histograms.xml, e.g. "1Tab", "2Tabs", etc. Bug: 861796 Change-Id: I50a7b806f82b7284543a97ed5d2496213c9a5d62 Reviewed-on: https://chromium-review.googlesource.com/1168287 Commit-Queue: Scott Haseley <shaseley@google.com> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#585925}
-
Scott Violet authored
This also removes window_manager_constants as it was not used. BUG=876924 TEST=covered by tests TBR=msw@chromium.org,tsepez@chromium.org Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel Change-Id: I32224509d1f7264088333c674544559a8759729a Reviewed-on: https://chromium-review.googlesource.com/1188427Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#585924}
-
Adrienne Walker authored
Bug: 877109 Change-Id: I77918382df9e5ef5c14f3f55d2581bc58c5ccb3b Reviewed-on: https://chromium-review.googlesource.com/1187656Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: enne <enne@chromium.org> Cr-Commit-Position: refs/heads/master@{#585923}
-
Stephane Zermatten authored
With this change, the script executor follows AssistantActionProto.action_delay_ms, when it is set. Bug: 806868 Change-Id: I4cb7ba2074f316cb27bffb61f9f14dc200639792 Reviewed-on: https://chromium-review.googlesource.com/1186737 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585922}
-
Lei Zhang authored
Fix overrides and remove a bunch of calls to new. Change-Id: Icac6516cae60dfcde967540022262088dc230f74 Reviewed-on: https://chromium-review.googlesource.com/1188040Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#585921}
-
Manas Verma authored
Bug: 855186 Change-Id: I0f83e8c802f98b01f62447bc2515d7a5cb2dc133 Reviewed-on: https://chromium-review.googlesource.com/1187626Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Manas Verma <manasverma@google.com> Cr-Commit-Position: refs/heads/master@{#585920}
-
Stephane Zermatten authored
This change extends the controller to include a ClientMemory struct, that is data shared between all actions. Bug: 806868 Change-Id: I32e43c2302b93cb6f8a6972789843b08df5d0750 Reviewed-on: https://chromium-review.googlesource.com/1186881Reviewed-by:
Ganggui Tang <gogerald@chromium.org> Commit-Queue: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#585919}
-
Gabriel Charette authored
[RenderProcessHost/Desktop] Update process priority on process launch and fix navigation priority inversion This is a second take on https://chromium-review.googlesource.com/c/chromium/src/+/754299 It's under an experiment to (1) be able to see the side-effects and (2) make merge to M69 easier. Intentionally kept old (and buggy) behavior intact under the non-experimental branch for comparison. This fixes all aspects of crbug.com/560446: 1) Fixes the OP better than r385608 did. 2) Fixes the side-effect of r385608 which was to default all tabs created backgrounded to run at foreground priority until visiblity was toggle on/off again. 3) Fixes a major priority inversion on foreground navigation which could cause them to background their associated renderer while navigation (which reintroduced the OP but worse since all background tabs were running foregrounded per r385608)... See https://crbug.com/560446#c74 for details. Updated ChildProcessLauncherPriority::is_background() to consistently reflect backgrounding decision to all callers and renamed |ChildProcessLauncherPriority::foreground| to |ChildProcessLauncherPriority::visible| to better reflect that it's a property but not the resulting foreground/background state. See in code comment on ShouldBoostPriorityForPendingViews() for more details. TBR=haraken@chromium.org (side-effect in third_party/blink) Bug: 560446 Change-Id: I901b702506a44704b53c007bcdd498fb60824e94 Reviewed-on: https://chromium-review.googlesource.com/1142593 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#585918}
-
Weilun Shi authored
This CL modify a few event listener, using keydown event instead of keyup event making the arrow key interaction between tiles will not propagate to the menu. With this CL, when hitting arrow key on the tile will not move the scroll unless it has to eg. the next focus item located outside the current viewpoint. Screencast: https://screencast.googleplex.com/cast/NDgzNTA4MjMwOTIwNjAxNnw5NjFlYmFkZC0zNA Bug: 872601 Change-Id: I352a28dbc0a05779818ee27fd9df563114caf6c2 Reviewed-on: https://chromium-review.googlesource.com/1187236Reviewed-by:
Kristi Park <kristipark@chromium.org> Commit-Queue: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#585917}
-
Dominik Röttsches authored
For issue 828317 we need an end to test for checking whether the correct fonts have been selected for @font-face { src: local(<fontname>) } rules. Since this cannot be reliable verified with web platform API, I am using DevTools to connect to the content instance and retrieve information about the selected fonts, just like in the style panel of DevTools. The DevTools protocol communication is modeled after content/browser/devtools/protocol/devtools_protocol_browsertest.cc I appreciate feedback on whether I should duplicate this DevTools communication code here, whether there is an easier way to achieve this, or whether we should factor out the relevant parts of content/browser/devtools/protocol/devtools_protocol_browsertest.cc into a separate file that I can reuse here for the FontUniqueNameBrowserTest. Bug: 874059 Change-Id: I4a2beeb81a3b5e4cec68cf196fcf0ebf29287d38 Reviewed-on: https://chromium-review.googlesource.com/1174540Reviewed-by:Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#585916}
-
Steve Anton authored
This change implements the RTCIceTransport.start() method and associated methods/events: addRemoteCandidate(), getRemoteCandidates(), role, onstatechange. Bug: 864871 Change-Id: Ic6ac7ce4c9ba98b1dc2610ed7847e6b9714f6c8d Reviewed-on: https://chromium-review.googlesource.com/1161605 Commit-Queue: Steve Anton <steveanton@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#585915}
-
Joe Downing authored
This work is to support the auto-hide disconnect window. The idea is to allow consumers of the Local*InputMonitor interfaces to choose which Monitors they want to subscribe to. This means breaking the current impls up into Mouse and Hotkey variations. Change-Id: Id38e37e23b0b4747a672d8f4b21fe9fd1656c680 Bug: 877176 Reviewed-on: https://chromium-review.googlesource.com/1185289 Commit-Queue: Joe Downing <joedow@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#585914}
-