GitLab

This CL migrates filter-effect-removed[-expected].html
tests from css3/filters to external/wpt/css/filter-effects
with WPT styles, adding links to the relevant specs, and
test description.

Additionally, this test is renamed to
filter-effect-remove-unattached[-ref].html to be align with
WPT naming style.

Bug: 1063749
Change-Id: I15ec6149c6c3bdc5ae271389f7559a2b502aa5ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143018
Commit-Queue: Robert Ma <robertma@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758255}

Pixel_OffscreenCanvasIBRCWebGLHighPerfWorker is set to retry on failure
on mac intel-0xd26 because of flakiness.

TBR=kbr@chromium.org

Bug: chromium:1069339
Change-Id: I92875215b66998b33504d2bc5068ef14b0d3690e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145566
Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758254}

These histograms are in active use and seem useful indefinitely.

BUG=1059804,1037279

Change-Id: If1b5f3d6ae21792d3a6721377f5ee9501153a94c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140917Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758253}

Removed the hardcoded color values of MessageView,
focus_view sets the color appropriately already

Bug: 1056948
Change-Id: I9ed0caf6fed54dd5b0da18925d0a21d978523e9f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138232
Commit-Queue: Matthew Porter <matt.porter@microsoft.com>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758252}

Bug: 1067057
Change-Id: Ib8d60aa02fac5d278069541555a4e615ab5237bd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142584
Auto-Submit: Garrett Beaty <gbeaty@chromium.org>
Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Aaron Gable <agable@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758251}

Change-Id: Idcd3b5b470db3fd782396fa219ca657077b792c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144672Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758250}

--disable-media-suspend only disables the background suspend feature.
Renamed to --disable-background-media-suspend.

--enable-media-suspend is a no-op except on Cast. Removed.

Bug: 867146
Change-Id: Id5e8acf3aa890b25dedcadd27f1f81976f774358
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144819Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: Dan Sanders <sandersd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758249}

BUG=949819

Change-Id: I09e3546e3e14f469e3a68fcddfd840ec3fd76e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140928Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758248}

Most likely has already been disabled on mobile and an experiment found
that most likely can also safely be disabled on desktop.

+ Remove now redundent fieltrial testing config of the desktop
  experiment.

Bug: 1009579
Change-Id: I5028c2babcef71862096dcd9684eaa29d0ad08b5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142758Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758247}

BUG=chromium:1055389
TEST=validate.py

Fixed: chromium:1055389
Change-Id: I510e858c1e9e010b6153afbce9aa2de46f3a3391
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137675Reviewed-by: Ian Barkley-Yeung <iby@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Miriam Zimmerman <mutexlox@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758246}

This test has been updated to work with --site-per-process, but remained
disabled. It passes fine now.

Fixed: 671734
Change-Id: I7ba432eb43375b26e672da64e60e953196dee8d5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144828
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Auto-Submit: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758245}

This test appears to be flaky. See the attached bug for more details.

Bug: 1069850
Change-Id: I6f5ba61be70c59f0a274a32d38301f9d882d6c6c
Tbr: katie@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145857Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758244}

The background iframe was not loading correctly on initial load and
after an image was selected following the customize dialog closure. To
fix this, only set the path of the background image iframe if the path
is not empty and is different. Also do not reset the background
selection unless the theme changes.

The logo was not updating when the customize dialog background selection
changed.

Bug: 1032328
Change-Id: I99304d80e7149439f57c02c9192af98af5deb4de
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145554
Commit-Queue: Esmael Elmoslimany <aee@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758243}

https://chromium.googlesource.com/catapult.git/+log/90ff937ff645..0780cae6bf8d

git log 90ff937ff645..0780cae6bf8d --date=short --first-parent --format='%ad %ae %s'
2020-04-10 bsheedy@chromium.org Revert "[Telemetry] Standardize CrOS quoting"
2020-04-10 bsheedy@chromium.org [Telemetry] Standardize CrOS quoting

Created with:
  gclient setdep -r src/third_party/catapult@0780cae6bf8d

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC oysteine@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: chromium:1068708
Tbr: oysteine@google.com
Change-Id: I20fb92b41c339e0cc30a1b2ba24450734ee02c18
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145772Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758242}

Bug: none
Test: NA
Change-Id: I4f577c8383408f8e716e52f96cf977af17b96697
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137913Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758241}

The share dialog opens when clicking the share button on simple and
animated doodles. The dialog lets the user share the doodle via
Facebook, Twitter, email, and copy the doodle URL.

+ Add doodle description tooltip.

+ Remove TODO about the share button focus ring working for dark
  doodles. We decided it's an edge case and doesn't warrant fixing.

This is a reland of 275bf019 with a fix
for flaky Mac tests. `navigator.clipboard.readText()` requires a focused
document. Therefore, 'clicking copy copies URL' was moved to
interactive_ui_tests, which focuses the document for each test case
robustly. Original change info:
> Change-Id: Ib2b8d9ca9447a2d6363d3c76167b393f914f60e1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2138792
> Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
> Reviewed-by: Alex Gough <ajgo@chromium.org>
> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758033}

TBR=ajgo@,owone@,aee@

Bug: 1039910
Change-Id: Ia3cd23e03c3c147314066d7e5420138c906b3557
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145755Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758240}

This test appears to be flaky and caused a failure on the waterfall.

Bug: 1069843
Change-Id: I5afee14c34ed645cc0aed53d5f7ce0e6dc2749c2
Tbr: loyso@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145569Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758239}

Forces ShouldScopeFullscreenControllerToBrowser to be enabled when in
multiwindow. This greatly improves usability with multiwindow.

Bug: 1069752, 1060653
Change-Id: I4521b4814ebd42aaadbe27c5252a8ef710928d11
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144108Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758238}

This is step 2 of a N-way patch to move Dawn's GN test targets to a
subdirectory: //third_party/dawn to //third_party/dawn/src/tests

Bug: chromium:1064305
Change-Id: Icefe9fca706ed19de7a11d989a470b87343317f4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144956Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: Corentin Wallez <cwallez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758237}

Add a new message and a field in the certificate-based registration
data that allows us to provide device identification during
registration.

Bug: b:153503823
Test: None
Change-Id: If6246345a52f79114622fb8d6c3cfc35fe81f635
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141216Reviewed-by: Pavol Marko <pmarko@chromium.org>
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Auto-Submit: Yves Arrouye <drcrash@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758236}

Bug: 1068323
Change-Id: I9a4588f858169fee41b045f9d8331752df3bd413
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145556
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758235}

https://skia.googlesource.com/skia.git/+log/f4403e7a7805..2faa33772be4

git log f4403e7a7805..2faa33772be4 --date=short --first-parent --format='%ad %ae %s'
2020-04-10 egdaniel@google.com Revert "Split apart flushing and submitting in the GrGpu classes and GrDrawingManager."
2020-04-10 egdaniel@google.com Remove vulkan validation layer workaround.
2020-04-10 robertphillips@google.com Appease VS 2019
2020-04-10 bsalomon@google.com Remove GrCaps::getYUVAColorTypeFromBackendFormat().
2020-04-10 bsalomon@google.com Remove unused GrVkFormatColorTypePairIsValid
2020-04-10 egdaniel@google.com Split apart flushing and submitting in the GrGpu classes and GrDrawingManager.
2020-04-10 stani@google.com Trace texture upload always with Android framework
2020-04-10 jvanverth@google.com More fixes to get D3D tests running.
2020-04-10 bsalomon@google.com Always initialize YUYAIndex::fChannel in wacky YUV format GMs

Created with:
  gclient setdep -r src/third_party/skia@2faa33772be4

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC csmartdalton@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: csmartdalton@google.com
Change-Id: Id47abb93ee51658a12da17df5e5357650591c4db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145773Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758234}

This CL fixes the warning in mojo_unittests:
The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<EndToEndRemoteTest>

Bug: 1045846
Change-Id: Ic67c23f9cdbc3544c857777451691cecc62de92c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144793
Auto-Submit: Alan Cutter <alancutter@chromium.org>
Commit-Queue: Ken Rockot <rockot@google.com>
Reviewed-by: Ken Rockot <rockot@google.com>
Cr-Commit-Position: refs/heads/master@{#758233}

This reverts commit 65a40c3d.

Reason for revert: Failing downstream tests: https://ci.chromium.org/p/chrome/builders/ci/iphone-device/7813

Original change's description:
> [iOS] Add ClearSyncedData experiment to field trial testing.
> 
> Updates EarlGrey tests that are impacted by the new default signout UI.
> 
> Bug: 1005509
> Change-Id: I688c15b7b3a7b77be6da9e87d2047dd831818aff
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139708
> Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
> Reviewed-by: Jesse Doherty <jwd@chromium.org>
> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758162}

TBR=jwd@chromium.org,sdefresne@chromium.org,fernandex@chromium.org

Change-Id: I47fac14ddd3767267ad115fbd7816e06c2e71dd0
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 1005509
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2143859Reviewed-by: Chris Lu <thegreenfrog@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758232}

If a window is not animated, clipping will happen on first bounds update
and without animation. Windows animated into overview remain unchanged.

See bug for before and after videos [1].

[1] https://bugs.chromium.org/p/chromium/issues/detail?id=1069540#c11

Test: manual
Bug: 1069540
Change-Id: I683b49e87c5fa4fe0bc6d27b2dee31389fbb0d32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145233
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Ahmed Fakhry <afakhry@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758231}

Bug: 1061344
Change-Id: If8f966a92069e5d6a6a157e29c3a454678cc9590
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141564
Commit-Queue: Bruce Dawson <brucedawson@chromium.org>
Auto-Submit: Jiaxun Wei <leuisken@gmail.com>
Reviewed-by: Bruce Dawson <brucedawson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758230}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bb2c6c025366..647a242debd9


Created with:
  gclient setdep -r src-internal@647a242debd9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC nhiroki@google.com,reillyg@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1024586,chromium:1024588,chromium:1029346,chromium:1031465,chromium:1047869,chromium:1047876,chromium:1058017,chromium:1058152,chromium:1061193,chromium:1063948,chromium:1065041
Tbr: nhiroki@google.com,reillyg@google.com
Change-Id: I073707be66294e8f0c8ef4f362e5624230a28157
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145608Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758229}

We need to know total input delay and number of inputs for each page visit. To better align with `PageForegroundSession.ForegroundDuration`, we plan to add TotalInputDelay, TotalAdjustedInputDelay,  NumInputEvents UKM for each PageForegroundSession.

UKM privacy review: https://docs.google.com/document/d/1F4ZImXniH_YZA6Z4FcONHbwe-ze0q0Bp0W6RKxDf-Kg/edit?usp=sharing

Change-Id: I010d8b7b35af3d3f611f8a29542dd10956c2ab7f
Bug: 1069304
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144362
Commit-Queue: Hongbo Song <hbsong@google.com>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758228}

This reverts commit 677e751d.

Reason for revert: Failures on ios-simulator-noncq.

https://ci.chromium.org/p/chromium/builders/ci/ios-simulator-noncq/3637

Original change's description:
> [iOS] Fix NTP presentation on bad ssl pages
> 
> This CL makes sure that we don't display the NTP if the loaded page is
> an interstitial page.
> This is caused by the behaviour of interstitial when the committed
> interstitial feature isn't enabled. In that case the workflow is:
> 1. about:newtab is loaded
> 2. User loads bad.badssl.com
> 3. Navigation did start for bad.badssl.com
> 4. Navigation ends for bad.badssl.com
> 5. This is a bad ssl page so Chrome actually reverts to about:newtab
> 6. Load stops, but at this point the visible URL is about:newtab
> 7. The interstitial is displayed and the visible URL is updated to
>    bad.badssl.com
> 8. The observers are notified through DidChangeVisibleSecurityState
> 9. No further callbacks
> 
> So the main issue is that there is not callback notifying that the
> visible URL has changed.
> This CL fixes it by adding a callback on DidChangeVisibleSecurityState
> and also on LoadStop to avoid having the NTP flashing between 6 and 7.
> 
> Fixed: 1067250
> Change-Id: Ifc57addf5a6fa9e6295446da34e117028add73fb
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141971
> Commit-Queue: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Livvie Lin <livvielin@chromium.org>
> Reviewed-by: Justin Cohen <justincohen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#758163}

TBR=justincohen@chromium.org,gambard@chromium.org,livvielin@chromium.org

Change-Id: I62d19870a0ad15fbfc4725f43de6eae28950f04e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145763Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758227}

Use new method for skipping screen. Add tests for UMA stats.

Bug: 1064561
Change-Id: Ieabfdab904e6e83501a3188a3ff8d4184da0bb10
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142264
Commit-Queue: Roman Aleksandrov <raleksandrov@google.com>
Reviewed-by: Roman Sorokin [CET] <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758226}

This patch also add a constructor to make unit test easy.

Bug: 1064420
Change-Id: Ibeaa4bdab2c66f581360eea1a37e199b2c009313
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140920
Commit-Queue: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758225}

SiteForCookies's function will, conditionally on the SchemefulSameSite
feature, take scheme of the URLs into account when determining
first-partyness and equivalency.

Schemefully_same_ will also be used in determining IsNull() when
SchemefulSameSite is enabled.

Bug: 1030938
Change-Id: I4599555faddf3f294144023af50c1a0ade67cca0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144258
Commit-Queue: Steven Bingler <bingler@chromium.org>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Maksim Orlovich <morlovich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758224}

Certain types of suggestions such as the proactive zero-prefix suggestions
may be associated with suggestion group IDs that indicate their type, e.g.,
trending or onboarding PZPS.

Since proactive zero-prefix suggestions cannot be individually deleted,
users should be able to hide/show all suggestions belonging to a given
group ID. This CL introduces a list pref that controls the visibility of
suggestion group IDs. Convenience methods are added to the omnibox::
namespace to check whether a given suggestion group ID is hidden and to
toggle visibility of a given suggestion group ID. This CL also renames the
files omnibox_pref_names.h/cc to omnibox_prefs.h/cc as they contain more
than just the pref names.

Bug: 1046547
Change-Id: Iea9a03eb70b780c583e3cf8f48d819a9aa9c1f20
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137866Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758223}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/a5c914b63a0c..97d7f070200a

git log a5c914b63a0c..97d7f070200a --date=short --first-parent --format='%ad %ae %s'
2020-04-10 sonnysasaka@chromium.org Add -blueznext suffix as special images
2020-04-09 lamontjones@chromium.org api: update python bindings.
2020-04-09 chrome-bot@chromium.org Update config settings by config-updater.
2020-04-09 kimjae@chromium.org build_dlc.py: Add DLC_DESCRIPTION flag
2020-04-09 saklein@chromium.org cros_build_lib: mute_output only used when set
2020-04-09 saklein@chromium.org cros_build_lib.run: Fix quiet argument.
2020-04-09 saklein@chromium.org run(mute_output): Remove usages of the argument.
2020-04-09 saklein@chromium.org flash-ap: Simplify and enumerate config checks.

Created with:
  gclient setdep -r src/third_party/chromite@97d7f070200a

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/chromite-chromium-autoroll
Please CC chrome-os-gardeners@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel
Bug: None
Tbr: chrome-os-gardeners@google.com
Change-Id: Iebec4597f73ffcd1c8e1e078fbae81b3dd168c21
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145606Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#758222}

Change-Id: I157f2b427d2f18d6687661bee941bc9e568d2530
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145559
Commit-Queue: Adam Langley <agl@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Auto-Submit: Adam Langley <agl@chromium.org>
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758221}

Bug: 1025603
Change-Id: I3c38b25403e3400eec7eb13c597a7e52be0b198a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144745
Commit-Queue: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758220}

This reverts commit b163621e.

Reason for revert: These tests no longer fail under Fuchsia.

Original change's description:
> [Fuchsia] Filter tests broken by getsockname().
>
> Temporarily filter some tests which fail due to broken getsockname()
> semantics on connect()ed UDP sockets.
>
> Bug: 989223
> Change-Id: I5ddd5783d33ce84999cced12f273d3680f56fae1
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730653
> Auto-Submit: Wez <wez@chromium.org>
> Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
> Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#683366}

Bug: 989223
Change-Id: I6c15a468c80ccceafe3c198cc333f0487a52404b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144175
Auto-Submit: Wez <wez@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Commit-Queue: David Dorwin <ddorwin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758219}

Bug: none
Change-Id: I16fbd6b1d6a712e69628136d13884a38128d3121
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144403
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758218}

Bug: 790886
Change-Id: I90fdb3e503ca8792d54cf474ee59772ac9aeafe2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142141Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758217}

Symbolize log_listener output, in order to get logs from WebEngine.
Able to provide more information when tests fail.
If system-log-file is not specified, we create a temp system log that Telemetry can consume.

Bug: 1069256
Change-Id: I8a10a37356dc72206a40d985f548b29048b4ee31
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142498
Commit-Queue: Chong Gu <chonggu@google.com>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#758216}