- 15 Apr, 2020 40 commits
-
-
Siyu An authored
Add an experiment flag and change the navigation logic for upstream bubble and card migration bubble. New sets of metrics will be added in the following CL. Bug: 1070799 Change-Id: I7c81b1b568ea10c179c402aeb9be9a3002496370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149696 Commit-Queue: Siyu An <siyua@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#759376}
-
Kurt Horimoto authored
TabHelperDelegateInstaller is a utility class template that sets up delegates for tab helpers for all the WebStates in a Browser. Now that OverlayPresenter can be used to implement tab-specific UI functionality, tab helpers can show UI without delegating this functionality to coordinators. This coupled with the increasing usage of BrowserAgents in preparation for multi-window support means that more tab helpers will be using Browser-scoped C++ delegates implemented in BrowserAgents. Bug: none Change-Id: Ieed54409bcfb228685baa417ad4fdc7d3e3f45b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144465 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#759375}
-
Taylor Bergquist authored
Revert "Tab strip ideal bounds are calculated from the available width instead of the current width." This reverts commit d091784a. Reason for revert: caused crash regression https://bugs.chromium.org/p/chromium/issues/detail?id=1070980#c1 Original change's description: > Tab strip ideal bounds are calculated from the available width instead of the current width. > > This obviates the need for the work described in > go/chrome-nonpredictive-tabstrip-animations. > > One known issue: with stacked tabs enabled, resize a window to trigger > a transition into the stacked layout. The tabs will animate into the > new layout, and while this is taking place, they will ignore any > further changes to the tabstrip's bounds. > > Further work: Continue removing now-dead code from the new animation > system. > > Bug: 958173 > Change-Id: I977b3836ad87647fa17e431a1215ebd1ce81727c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055544 > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Connie Wan <connily@chromium.org> > Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> > Cr-Commit-Position: refs/heads/master@{#759054} TBR=sky@chromium.org,pbos@chromium.org,tbergquist@chromium.org,connily@chromium.org Change-Id: I4b995aeb6515aa675442e4cf69a4a4d0be48e840 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 958173 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151425Reviewed-by:
Taylor Bergquist <tbergquist@chromium.org> Commit-Queue: Taylor Bergquist <tbergquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#759374}
-
Antonio Gomes authored
BUG=767015, 1063749 R=svillar@igalia.com Change-Id: I727fd772a631c03e038da4687881d3f9ec707ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144250 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Manuel Rego <rego@igalia.com> Cr-Commit-Position: refs/heads/master@{#759373}
-
Aaron Leventhal authored
It's a performance bottleneck. It was originally added here: https://codereview.chromium.org/1195353002 - but the test added then still passes without this code. I tried reverting some other recent patches but I can't pinpoint what made it start working. We re-landed this a year ago and it caused crashes on the index.html page for the built-in PDF viewer extension, specifically on Mac. We should try relanding and determine the actual cause of that crash if it occurs again, since we know what page causes it. Bug: 489590, 579199, 916936 Change-Id: Ic142d7ac2711698513069bdda5376920a8e00bf7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148035Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#759372}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: I2a94f532d738c88f24b6dc7fa4fa2f8d990a421e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150400Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#759371}
-
Harald Alvestrand authored
This simplifies the class hierarchy; the class is no longer used outside of modules/peerconnection. Bug: chromium:787254 Change-Id: Iff526b1ef1d6d324c67b72ff3e1420ccd1f0ae9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144025Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#759370}
-
Bryan Clark authored
We don't have support for alsa on borg, so this is needed to prevent an endless stream of alsa related errors. Bug: b/151360165 Change-Id: I765b98d637ed1741c16069024160c5748ec6cde9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150032 Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Auto-Submit: Bryan Clark <bryanclark@google.com> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#759369}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/97d22cb8bd41..9f64a3e1686e git log 97d22cb8bd41..9f64a3e1686e --date=short --first-parent --format='%ad %ae %s' 2020-04-15 tross@microsoft.com Fix check-type-closure for serverless Java installs 2020-04-15 livvielin@chromium.org [DevTools] Improve Security Panel color contrast Created with: gclient setdep -r src/third_party/devtools-frontend/src@9f64a3e1686e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1062409 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I0514e23457023b32157f7c7b4d2c7106d68dc9cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151065Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759368}
-
Kurt Horimoto authored
This CL refactors the browser container to use a mediator and consumer. The BrowserContainerMediator observes presentation of HTTP authentication dialogs. If one is presented from a different host than the rendered page in the content area, a blocking view is inserted behind the HTTP auth overlay to block out the page. In order to support this change, a URL is added to the OverlayRequest config so that it can be compared with the last committed URL of the Browser's active WebState. Bug: 1063690 Change-Id: I21c7abe83818180762e3a2dda6f764ea635ee42a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136232 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
-
Ben Joyce authored
This CL needs to land first: https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/2886688 Bug: 1070424 Change-Id: Idf685c8a428e90520c752f734c8d63172098b9c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150767Reviewed-by:
Peter Wen <wnwen@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Commit-Queue: benjamin joyce <bjoyce@chromium.org> Cr-Commit-Position: refs/heads/master@{#759366}
-
Jesse Schettler authored
This reverts commit f64a6c0a. Reason for revert: Logging no longer needed. Original change's description: > arc: Add logging to investigate ARC print failures > > Print preview occasionally fails in the arc.Print tast test. Add logging > to investigate these failures. > > Bug: b:152251595 > Change-Id: I5b8b18213ec8c7fc2a56646c65dfe5262b86f677 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144456 > Reviewed-by: Lei Zhang <thestig@chromium.org> > Commit-Queue: Jesse Schettler <jschettler@chromium.org> > Cr-Commit-Position: refs/heads/master@{#758262} TBR=thestig@chromium.org,jschettler@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: b:152251595 Change-Id: Iaaa10289a1ba47b7415b1fa820702d9791ad19ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150817Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Commit-Queue: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#759365}
-
Sigurdur Asgeirsson authored
Bug: 1068233 Change-Id: Iac17d0b65f6b9c996b5b4e35b97c5bb5d79a211b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150063Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759364}
-
Becca Hughes authored
Add a histogram to store the safe search result. BUG=1024362 Change-Id: Ie6b7cf349f502f85b1ba39103092a56879671643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2137584 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#759363}
-
Rune Lillesveen authored
When color-scheme affects other CSS properties, invalidation diffing those properties are sufficient. However, some parts of UA rendered UI elements are painted based on colors not defined in CSS. Invalidate paint when the used color-scheme value changes so that such elements are properly repainted on color-scheme changes. Bug: 929098 Change-Id: Icedafd9fa1d787b4db64e6d698ecfcdc144a4ec7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150905Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#759362}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b26c7ec23a..6732305714ca Created with: gclient setdep -r src-internal@6732305714ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ricea@google.com,nektar@google.com,guidou@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1005895,chromium:1019685,chromium:2877672 Tbr: ricea@google.com,nektar@google.com,guidou@google.com Change-Id: Iceaad3d6b2f4b417544ee4cb2841d91f1163cfd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149942Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#759361}
-
Clark DuVall authored
This splits chrome-specific logic into ChromeContentSettingsAgentDelegate, and moves common logic into //components/content_settings. This will allow sharing the content settings agent with WebLayer. The unit test for WhitelistedSchemes was moved into the browser tests, which means we no longer need a static version of IsWhitelistedForContentSettings() just for testing. Bug: 1065537 Change-Id: I99d401542497e3c180e7ff5024adcb3691d84e71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2142636 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#759360}
-
Jeffrey Cohen authored
Bug: 1036023 Change-Id: I4bb00ab9185e03b08ec1204f82049270f86eb214 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148242Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#759359}
-
Alexander Cooper authored
Describes the source of the two static_initializers so that anyone who adds a new one can more easily diagnose which is theirs. This is especially useful when the new static initializer may come from a lib or other such code being linked in that the developer may not be familiar with. Change-Id: Ibaecb74f66f87d83bc5140ba7ed281399e56e95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150057 Auto-Submit: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#759358}
-
Sinan Sahin authored
After switching themes (dark/light), the ConnectivityDetector instance would not be destroyed since it's added as an observer to the NetworkChangeNotifier singleton. This was keeping a lot of objects around and causing invalid status indicator instances to access a null activity reference through a lambda created in TabbedRootUiCoordinator. This CL adds a #destroy method to ConnectivityDetector and a call to it from OfflineIndicatorControllerV2#destroy(). Bug: 1070386 Change-Id: Iee7a9cb913fa8aa62960f602e6f45242e0cc60e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150026Reviewed-by:
Jian Li <jianli@chromium.org> Reviewed-by:
-
David Tseng authored
This change fixes a case where Googletts, running in split mode, would not have both extensions kept alive. In particular, when running in the login session, Googletts would be loaded into both the off the record and non-otr profiles. The otr profile gets all tts extension api calls, but the extension system calls OnExtensionLoaded with the non-otr BrowserContext. Fix this by explicitly looking for an associated otr profile and modifying the keep alive count for Googletts there accordingly. Test: manually test on: - login session - guest session - normal session R=dmazzoni@chromium.org - flip on ChromeVox; wait for > 20 seconds. Trigger speech. Verify that speech comes immediately (aka tts kept alive) - flip off ChromeVox; wait > 20 seconds. Verify that flipping back on ChromeVox incurs a delay in speech response. Also, inspecting Chrome, verify tts is actually not loaded. Do: Change-Id: I93bc68d058017e3722c486dbb1848fac94ddca3e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147014Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/60af4efbe0e2..9ac89e3e1842 git log 60af4efbe0e2..9ac89e3e1842 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 skyostil@google.com TrackEvent: Detect incorrect use of dynamic event names Created with: gclient setdep -r src/third_party/perfetto@9ac89e3e1842 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:148779455 Tbr: perfetto-bugs@google.com Change-Id: I8f059848d3e0688017ca0cf629d25c5f83d15900 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149944Reviewed-by:
-
Mark Schillaci authored
This CL relands AccessibilityEvent throttling on Android. Original CL: http://crrev.com/c/2067443 Revert: http://crrev.com/c/2132927 This change was reverted to prevent regression before M83 was cut, but with this CL it will be relanded along with the improvements added here. This CL improves the throttling logic by separating it from the WebContentsAccessibilityImpl into it's own class, which we have called AccessibilityEventDispatcher. Whenever the WCAI wishes to send an event, it sends it to the dispatcher. The dispatcher can then act as a pass-through, throttle the event, discard the event, etc. as determined by preset rules that are opaque to the WebContentsAccessibilityImpl. This will make unit testing easier and allows us to make wholesale changes to our throttling without affecting implementations. This CL also adds an improvement by taking into account the |virtualViewId| of whatever node is trying to send an event. Until now we have relied solely on the eventType and ensured that no two events of the same type are sent in quick succession (if the eventType is one we are throttling). This creates an issue where two separate nodes with different |virtualViewId|'s can each request an event of some type to be sent, but only one will get through. We fix this problem by making our throttling check not just the eventType but also |virtualViewId|. This requires some sort of 2D structure, or a key of Pair or some wrapper object that will hold the two ints (|virtualViewId| and eventType). Here we use a long in place of a Pair, by bitshifting |virtualViewId| left 32 bits and doing a bitwise OR with eventType. This gives us a 64bit long that is essentially two int's concatenated in memory, which will be a unique id for a |virtualViewId|-eventType pairing. This CL also adds an improvement by allowing us to specify a delay time on a per eventType basis. Before this change we had a simple Set that contains a list of eventTypes to delay. We have now made this a map from eventType to delay time in ms, so that we can potentially delay different events by different amounts. Change-Id: I7431253a715cc712a81b1f6ac2b39d19e91daa8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139905Reviewed-by:
Mark Schillaci <mschillaci@google.com> Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
-
Tina Wang authored
Ensure that the password saving behaves correct when the pref is unset, enabled and disabled. Bug: 1065143 Change-Id: I7e112f167008b01c903cea53f06958f6e0c10e1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2136863 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Guillaume Jenkins <gujen@google.com> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#759353}
-
Mugdha Lakhani authored
Previews/Lite Mode is a series of optimizations that Chrome may use to optimize webpages that load slowly. It is only enabled for Lite Mode users (see Settings > Lite Mode) which is only supported on Chrome Android. This is a Chrome-specific feature which WebLayer doesn't intend to support for now. The overlap with Page Info UI is that in lite mode/Previews, we change the security strings in the Page Info Dialog to convey that the page is a Google-served preview/lite version of the actual page. Moving this change to a Chrome-specific delegate implementation allows PageInfoController to not depend on this, and eventually be componentized for reuse by WebLayer. Bug: 1052375 Change-Id: Ice09ed10af2358c5a943fe6e05e15caa0533b185 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144015 Commit-Queue: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#759352}
-
Jeff Yoon authored
waterfall renamed to chrome.pgo Bug: 1059277 Change-Id: I3be24ce4c9d19132f6117a3a931bf9917bc3b64b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149951 Auto-Submit: Jeff Yoon <jeffyoon@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#759351}
-
Nikita Podguzov authored
This allows to reuse this function for all platforms. We'll need it in the follow-up CL with PrintingPaperSizeDefault policy. Bug: 1015690 Change-Id: Ibb5daa2958e88b376556f3374b88ab8457d08402 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144030Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759350}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/b2bcf0eb3a4d..f4308e08dc82 git log b2bcf0eb3a4d..f4308e08dc82 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 rwkeane@google.com Discovery: Update contract between discovery layers Created with: gclient setdep -r src/third_party/openscreen/src@f4308e08dc82 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Ia53f5ef5edcfe5de8b25b0c4f7645b4e67c2a660 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150845Reviewed-by:
-
Michael Thiessen authored
See additional context on the bugs. Before Q (or maybe earlier), window focus told you when your Activity was visible. With at least Q, onStart is now the correct indicator of visibility. Bug: 1053375, 1062286 Change-Id: Ie8c86b22e69e4625d27830daba7b899996df0364 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2146286 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#759348}
-
Wan-Teh Chang authored
This requires the new libavif function avifDecoderNthImageTiming, which provides each frame's duration before the frames are decoded. Bug: 960620 Change-Id: Id00c760e094b8663b1a8781201fdd4a6c88beddd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149915 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#759347}
-
Nikita Podguzov authored
Bug: 1061077 Change-Id: I7f455fd05962a41928f9a462fb97dbf6b692ec92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2102328Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Commit-Queue: Nikita Podguzov <nikitapodguzov@chromium.org> Cr-Commit-Position: refs/heads/master@{#759346}
-
danakj authored
Convert pointers to WebTestDelegate into pointers to BlinkTestRunner. Change a few places that hold a pointer to TestInterfaces in order to get a (potentially changing over time...?) BlinkTestRunner to point to a BlinkTestRunner directly instead. We still grab the BlinkTestRunner off TestInterfaces for now though. R=avi@chromium.org TBR= Bug: 866140 Change-Id: Id1f336a7a178a8ec0b0f8a0b792ef9040c788d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149506 Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#759345}
-
Kyle Horimoto authored
This CL migrates multi-device UI strings to a per-page provider and adds TODOs for adding relevant search tags. Bug: 1069849 Change-Id: I7623883c0d44fcde2008d8ff3c9ca4640d37935b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150185Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759344}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/094974dab674..2430d665d3f2 git log 094974dab674..2430d665d3f2 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 amaiorano@google.com CMake: split out turbo-cov target 2020-04-15 amaiorano@google.com CMake: split out test and benchmark targets Created with: gclient setdep -r src/third_party/swiftshader@2430d665d3f2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic6fec60e2441df10adcfd6a8045a606d60135d8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150620Reviewed-by:
-
David Bertoni authored
Bug: 366181 Change-Id: Ie21ae708883e32745350d2227086acc31ff890bc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149496Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#759342}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/68626439f360..9ff1d841f6cc git log 68626439f360..9ff1d841f6cc --date=short --first-parent --format='%ad %ae %s' 2020-04-15 robertphillips@google.com Revert "Update DDL test harness to use backendTextures to back tiles" 2020-04-15 robertphillips@google.com Update DDL test harness to use backendTextures to back tiles 2020-04-15 bsalomon@google.com Reland "GaussianConvolutionFragmentProcessor uses GrTextureEffect." 2020-04-15 brianosman@google.com Support markers (custom matrices) in SkVertices Attributes 2020-04-15 reed@google.com SkMatrix44 is deprecated: use SkM44 instead Created with: gclient setdep -r src/third_party/skia@9ff1d841f6cc If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC kjlubick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: kjlubick@google.com Change-Id: I2e3341d749e9817e9e5ea971d1aa342d24000882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150726Reviewed-by:
-
Ravi Chandra Sadineni authored
Recently an additional dropdown has been added to allow setting battery idle behavior differently from AC idle behavior. This setting is visible only when battery is present and is hidden behind a dom-if template. Since nodes under dom-if are dynamically created, they are not added to the this.$ hash. As a result battery idle setting dropdown is not working. Instead use this.$$ for accessing the dynamically created #batteryIdleSelect node. This change also adds a test to catch the same. Bug: b:148105990, 1065050, b:154051991 Test: Run browser_tests and manual tests. Change-Id: I5970d6b362fc4c4c9685ddfe7d388e0a197007b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147015 Commit-Queue: Ravi Chandra Sadineni <ravisadineni@chromium.org> Auto-Submit: Ravi Chandra Sadineni <ravisadineni@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#759340}
-
Doug Turner authored
The initial IOS cronet prevented per request User-Agent header. This CL reverts that restriction and allows one to specify a UA per request. if a User-Agent is not specified, the default User-Agent will be used. Bug: 968358 Change-Id: Idaffeaab2d128f6b64963f38e0f68f10c6d47aea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2141140 Commit-Queue: Doug Turner <dougt@chromium.org> Reviewed-by:
Misha Efimov <mef@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#759339}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/e3f44e3cd6a1..0ff7ed41ecc5 git log e3f44e3cd6a1..0ff7ed41ecc5 --date=short --first-parent --format='%ad %ae %s' 2020-04-15 cwallez@chromium.org Remove CreateBufferMappedAsync Created with: gclient setdep -r src/third_party/dawn@0ff7ed41ecc5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I190bb73cc4efbd8e8e3b1a2ee2aada6b9c4b603c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149940Reviewed-by:
-
Tom Anderson authored
Requested by agable@ after investigating Linux.Distro for [1]. Rather than adding new enum values, this CL records the distro version in an UMA sparse histogram so we don't need to update chrome_browser_main_extra_parts_metrics.cc in the future if all we want to do is add new versions. [1] https://bugs.chromium.org/p/chromium/issues/detail?id=1064354#c13 R=thestig,agable Bug: None Change-Id: I20042e2a12d62f919c2aa77f6a049e321d2cd146 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2140719Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Reviewed-by:
-
