GitLab

Fix a bug where the BrowserActionsContainerView would return the incorrect
resize delta x if it was changed while the user was resizing it (which could
happen during navigation).

Also fix a bug where actions were hidden if the toolbar redrew while the user
was resizing.

BUG=472821

Review URL: https://codereview.chromium.org/1061623002

Cr-Commit-Position: refs/heads/master@{#323922}

RenderFrameProxyHosts need to exist in a SiteInstance so long as
at least one active frame exists: when we're about to
trigger the (1 -> 0) transition in |active_frame_count|,
we need to destroy any lingering proxies.

Bug 444955 occurs because we don't check for the (1 -> 0) transition
when the last active frame happens to be a pending frame when it's
deleted.

Also fixed here is bug 473714, found by inspection,
where deletion of a not-live frame would incorrectly rambo
the RenderFrameProxyHosts that could potentially be needed by
another live RenderFrameHost. A new test demonstrates this
and verifies the fix.

TEST=content_unittests
BUG=444955,473714

Review URL: https://codereview.chromium.org/1055203002

Cr-Commit-Position: refs/heads/master@{#323921}

BUG=143619

Review URL: https://codereview.chromium.org/1063603003

Cr-Commit-Position: refs/heads/master@{#323920}

BluetoothAdapter is not thread safe, this change moves the requestDevice() call to it onto the UI thread.

BUG=420284

Review URL: https://codereview.chromium.org/1058373002

Cr-Commit-Position: refs/heads/master@{#323919}

Based on https://codereview.chromium.org/1040143002/

BUG=470114

Review URL: https://codereview.chromium.org/1064663002

Cr-Commit-Position: refs/heads/master@{#323918}

- Renamed the method to Tab#getAllContentViews to be more specific.
- Prevent the method from returning NativePage views.

BUG=462114

Review URL: https://codereview.chromium.org/1057043002

Cr-Commit-Position: refs/heads/master@{#323917}

Cast Ozone is now fully implemented in chromecast/ozone, including
the Ozone factory function. The CastEglPlatform interface is moved
to public and its implementation will be loaded from shared library.

BUG=

Review URL: https://codereview.chromium.org/1059073002

Cr-Commit-Position: refs/heads/master@{#323916}

BUG=473283

Review URL: https://codereview.chromium.org/1051273006

Cr-Commit-Position: refs/heads/master@{#323915}

Tested on Linux with the following command lines:

$ rm -rf out/
$ ./build/gyp_chromium
$ ninja -C out/Debug sandbox_linux_unittests
$ out/Debug/sandbox_linux_unittests

BUG=138542
TEST=see above
R=mdempsky@chromium.org,jln@chromium.org

Review URL: https://codereview.chromium.org/1066523002

Cr-Commit-Position: refs/heads/master@{#323914}

HSTS/HPKP headers should only be parsed when the host is not an IP
address. This change requires fixing the HSTS/HPKP tests to use
localhost test server URLs instead of 127.0.0.1, with a corresponding
cert.

BUG=456712

Review URL: https://codereview.chromium.org/1059303002

Cr-Commit-Position: refs/heads/master@{#323913}

Remove all inlined enums from extension APIs.

BUG=472279
TBR=derat@chromium.org (mechanical changes to chrome/browser/chromeos/app_mode/kiosk_app_update_service.cc and chrome/browser/ui/ash/ash_keyboard_controller_proxy.cc)

Review URL: https://codereview.chromium.org/1055673002

Cr-Commit-Position: refs/heads/master@{#323912}

Fixes a mistake in https://codereview.chromium.org/1057983002/

R=rtenneti@chromium.org

Review URL: https://codereview.chromium.org/1065623002

Cr-Commit-Position: refs/heads/master@{#323911}

With recent changes, all known device types can be monitored. Update
CanMonitorPower() to reflect this.

BUG=

Review URL: https://codereview.chromium.org/1057423002

Cr-Commit-Position: refs/heads/master@{#323910}

There is CHECK(!val.IsEmpty()) in V8ValueConverterImpl::FromV8ValueImpl. We should call v8_converter->FromV8Value function only with not empty value.

BUG=468344
R=rdevlin.cronin@chromium.org

Review URL: https://codereview.chromium.org/1066563002

Cr-Commit-Position: refs/heads/master@{#323909}

With this change (and another fix for NACL_BUILD_SUBARCH), we can test
Pepper/Mojo/NaCl support on Windows.

This also moves embedder initialization to nacl_helper for clarity:
The Mojo embedder must be initialized in nacl_helper when that process
is used. When the plugin is running in a chrome process, ContentMain()
handles Mojo embedder initialization.

This change doesn't enable the test MojoFailsWithoutFlag on Windows,
since the abort() triggers a dialog that causes the test to time out.

BUG=414804
R=dmichael@chromium.org, ncbray@chromium.org

Review URL: https://codereview.chromium.org/1059233004

Cr-Commit-Position: refs/heads/master@{#323908}

Update down-arrow-showing.png and add 2X version of it.

BUG=464222

Review URL: https://codereview.chromium.org/1055273002

Cr-Commit-Position: refs/heads/master@{#323907}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/26fc1bf..f559de4

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1059863003

Cr-Commit-Position: refs/heads/master@{#323906}

Also clean up OWNERS to remove ex-googlers.

R=reed@google.com,fmalita@chromium.org
BUG=473772

Review URL: https://codereview.chromium.org/1059833002

Cr-Commit-Position: refs/heads/master@{#323905}

Cr-Commit-Position: refs/heads/master@{#323904}

BUG=468902
TEST=trybots literally
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/1064573002

Cr-Commit-Position: refs/heads/master@{#323903}

BUG=469421

Review URL: https://codereview.chromium.org/1047653003

Cr-Commit-Position: refs/heads/master@{#323902}

Previously the width of input box exceeded the width of container, and it got
other components in the same component scrolled out.

BUG=472582
TEST=manually

Review URL: https://codereview.chromium.org/1063663002

Cr-Commit-Position: refs/heads/master@{#323901}

BUG=472077

Review URL: https://codereview.chromium.org/1054253004

Cr-Commit-Position: refs/heads/master@{#323900}

Move getGCReason() and two string definitions into _AddTracingResults()

BUG=438074
TEST=./tools/perf/run_tests oilpan --browser=content-shell-release

Review URL: https://codereview.chromium.org/1067503002

Cr-Commit-Position: refs/heads/master@{#323899}

Previously Gallery adds image items to its model after fetching the
metadata. Because items are added by chunk, users cannot see all the items
before load completes. It causes strange behavior e.g. users may move from the
last item of the current chunk to the first item when the next chunk has not
been loaded.

The CL lets Gallery add all items to the model without fetching metadata. And
then, lets Gallery dispatch 'content' event to update thumbnails after fetching
metadata.

BUG=chrome-os-partner:33931
TEST=manually

Review URL: https://codereview.chromium.org/853653004

Cr-Commit-Position: refs/heads/master@{#323898}

This patch make the menus in Files.app accessible by Chromevox.

This patch works:
- Make the menuitems focusable
- Even the elements get lost focus, don't focus to the mainview

BUG=465938
TEST=manually tested

Review URL: https://codereview.chromium.org/1052343004

Cr-Commit-Position: refs/heads/master@{#323897}

Cr-Commit-Position: refs/heads/master@{#323896}

Adds AX role of <details> element for blink layout tests.

BUG=N/A
R=dmazzoni

Review URL: https://codereview.chromium.org/1066503002

Cr-Commit-Position: refs/heads/master@{#323895}

This test case would be enabled after this blink CL https://codereview.chromium.org/1045693002/
rolls in.

BUG=471152

Review URL: https://codereview.chromium.org/1059983002

Cr-Commit-Position: refs/heads/master@{#323894}

We have progress bar on dialog footer, and it should show for file open dialog
that needs local cache file for drive files. (e.g. dialog called by NPAPI plugin)

Also the CL adjust mergin so that "Preparing..." label should be placed with the
correct margin no matter if the "New directory" button is shown or not.

BUG=459876
TEST=manually

Review URL: https://codereview.chromium.org/1056413002

Cr-Commit-Position: refs/heads/master@{#323893}

The CL extracts existing code as utility methods so that they can be used by
newly added BatchRequest class.

BUG=451917
TEST=None

Review URL: https://codereview.chromium.org/1053623004

Cr-Commit-Position: refs/heads/master@{#323892}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/aa4c7a7..26fc1bf

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=msarett@google.com

Review URL: https://codereview.chromium.org/1065533002

Cr-Commit-Position: refs/heads/master@{#323891}

This is for https://codereview.chromium.org/1058723004/ in Blink,
to add "tabStop" property/attribute stats.

BUG=380445
TBR=isherman

Review URL: https://codereview.chromium.org/1059153002

Cr-Commit-Position: refs/heads/master@{#323890}

In menu.js, the Menu.menuItemSelector is refereed in the decorator, so we need to set it before decoration

BUG=none
TEST=manually tested

Review URL: https://codereview.chromium.org/1053123003

Cr-Commit-Position: refs/heads/master@{#323889}

BUG=412045, 454716
R=anthonyvd@chromium.org

Review URL: https://codereview.chromium.org/1062693002

Cr-Commit-Position: refs/heads/master@{#323888}

Fix is to notify the factory about session being closed.

BUG=473884
R=rch@chromium.org

Review URL: https://codereview.chromium.org/1056263002

Cr-Commit-Position: refs/heads/master@{#323887}

isolate_holder.h is public and used by blink and therefore cannot refer to types from base. As part of porting this to other platforms we needed to load snapshots from BaseFile descriptors.

BUG=421063

Review URL: https://codereview.chromium.org/1011133006

Cr-Commit-Position: refs/heads/master@{#323886}

This reverts commit 3f8a241f.

This was a wrong optimization to "improve" the performance of Speedomenter.
We shouldn't have landed a change that is not adopted in the upstreamed Speedometer.

TBR=peria@chromium.org

Review URL: https://codereview.chromium.org/1064433003

Cr-Commit-Position: refs/heads/master@{#323885}

It is already done.

BUG=461019
R=dpranke@chromium.org
CQ_EXTRA_TRYBOTS=tryserver.chromium.linux:android_chromium_gn_compile_dbg,android_chromium_gn_compile_rel;tryserver.chromium.win:win8_chromium_gn_rel,win8_chromium_gn_dbg;tryserver.chromium.mac:mac_chromium_gn_rel,mac_chromium_gn_dbg

Review URL: https://codereview.chromium.org/1054753003

Cr-Commit-Position: refs/heads/master@{#323884}

They were basically including it for DISALLOW macros.

BUG=138542
TEST=sandbox_linux_unittests
R=mdempsky@chromium.org

Review URL: https://codereview.chromium.org/1065503002

Cr-Commit-Position: refs/heads/master@{#323883}