- 30 Sep, 2020 40 commits
-
-
Hiroki Nakagawa authored
PrerenderProcessorImpl etc should not trust an initiator origin passed from a renderer process that can be compromised. Instead of the passed origin, this CL makes the prerender components use the origin given by RenderFrameHostImpl::GetLastCommittedOrigin(). Bug: 1133185 Change-Id: I47b8ea93f9e73099fc1c1ef82eb19d8f9b71d86b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437713Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Robert Ogden <robertogden@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#812049}
-
Victor Hugo Vianna Silva authored
By adding a title tag to the underlying web page, we ensure that the title of the dialog is read even though the Yes button is focused. Screencast of final state: crbug.com/1097085#c11 Bug: 1097085 Change-Id: I7969418715fe4d75d1d41283bb2146165155f8ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2440056Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#812048}
-
George Burgess IV authored
`row.normalized_term` is a `string16`, but the RHS here is an int64. This means the string16 is being assigned to a single-char string, where the char has a value of: `(uint16_t)statement.ColumnInt64(2)`. This probably isn't what was intended. Bug: 1130867 Change-Id: Id7b692a2901514b2f3cd1d5833ce145074b41983 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424814Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: George Burgess <gbiv@chromium.org> Cr-Commit-Position: refs/heads/master@{#812047}
-
Sebastien Marchand authored
Fixes: 1089860,1089859,1089857,1089858 Change-Id: I5d60284003bdae9ed49a6d3811069afb0756feb0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426768 Auto-Submit: Sébastien Marchand <sebmarchand@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#812046}
-
Lei Zhang authored
Combine horizontal/vertical DPI into a gfx::Size. Combine output bitmap width/height into a gfx::Size. Change-Id: I603025b11ce8cc76ab8f890cb9104cdca25ac335 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430764Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#812045}
-
Gavin Williams authored
When a printer is clicked in destination dialog, don't show the printer status error messages while it's attempting to configure the printer. The After screenshot shows: 1. Dialog initially opened with error status text 2. Clicking that printer to attempt to configure 3. Configuration failing Before: http://screen/9FJ2jistunJS2Uy After: http://screen/DbsdghWiGmf2UdZ Bug: 1123754 Change-Id: I1a632e281070e38f070153f18fdfad674f126425 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438638Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#812044}
-
Maksim Sisov authored
This is a reland of b372dd07 Original change's description: > Reland "ozone/wayland: Fix drop down menus for touch events." > > This is a reland of 7138b785 > > WaylandPopup didn't allow empty bounds. Fixed by > https://crrev.com/c/2397695 > > Original change's description: > > ozone/wayland: Fix drop down menus for touch events. > > > > In case of touch events, we may not find currently focused windows > > as menu windows might be created on touch up events. Thus, > > GetCurrentFocusedWindow returns nullptr. > > > > To fix that, use a concept of a currently active window. That is, > > Wayland sets a window to "active" state if it has had a focus. > > There can be only one focused window at a time. > > > > Thus, if there is no a focused window, use currently active window > > as a parent. That's the best effort one could make to find a parent > > window for a newly created non-toplevel window. At some point, > > it might be worth reconsidering the design and make aura always pass > > parent widgets for new windows if applicable. > > > > Bug: 1123521 > > Change-Id: Ib9479632e049df082ed17e3089680006a32f19fc > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2385279 > > Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> > > Reviewed-by: Nick Yamane <nickdiego@igalia.com> > > Cr-Commit-Position: refs/heads/master@{#804674} > > Bug: 1123521 > Change-Id: I62c6b254bc2e931bc93ac4609290518138aa19b8 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2397715 > Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Auto-Submit: Maksim Sisov (GMT+3) <msisov@igalia.com> > Reviewed-by: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> > Cr-Commit-Position: refs/heads/master@{#804914} TBR=nickdiego@igalia.com Bug: 1123521 Change-Id: I1b8df57f41f52b886f4ab53ea574929cf8fa34b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2414192Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#812043}
-
Roman Sorokin authored
Bug: none Change-Id: Ia9546c2c9652997ddff2f3d134b365f222094d18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426501 Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Amr Aboelkher <amraboelkher@google.com> Reviewed-by:
Victor-Gabriel Savu <vsavu@google.com> Reviewed-by:
Roland Bock <rbock@google.com> Reviewed-by:
Igor <igorcov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812042}
-
Eric Willigers authored
Populates IntentFilter for PWAs with share targets. Spec: https://w3c.github.io/web-share-target/level-2/ Both single files (kIntentActionSend) and multiple files (kIntentActionSendMultiple) may be shared. Bug: 1125880 Change-Id: I39a63cbad3bb1b765185a008cc74927152b34a2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2434079 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Maggie Cai <mxcai@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#812041}
-
Alice Wang authored
This CL adds a test to check that IdentityDisc shows on NTP when user is signed in but not sync. Bug: 1132238 Change-Id: Ib68be2ea5198bc7cbcca76761d2e4dc9c40b4201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2431924 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#812040}
-
Lei Zhang authored
- Change ProtobufHttpStatus::OK, a static instance of ProtobufHttpStatus initialized at runtime, to OK(). Internally, OK() will create the instance on first use. - Remove ProtobufHttpStatus::CANCELLED, which is only used in test code. Bug: 537099 Change-Id: Icc7d2865e9721157cff3c5f477f4a418ab1a1b20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437734 Commit-Queue: Lei Zhang <thestig@chromium.org> Reviewed-by:
Yuwei Huang <yuweih@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#812039}
-
Francois Beaufort authored
Intent to ship: https://groups.google.com/a/chromium.org/forum/#!msg/blink-dev/j-Q08QgBipM/F3a5sau1BwAJ Bug: 934063 Change-Id: Ie5c20d07c25b939a4970e9423ed0c0442b0e2466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2274598Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Eero Häkkinen <eero.hakkinen@intel.com> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#812038}
-
Liquan (Max) Gu authored
Context: On desktop & Android, when payment handler is opened, PaymentProviderApp::setOpenedWindow() must be called to notify of the payment handler's WebContents. Now that desktop doesn't call setOpenedWindow, this CL is to add this missing part. Change: * Call payment request web-contents' PaymentProviderApp::setOpenedWindow() when the payment handler window has just opened. Bug: 1131874 Change-Id: Ibd8405ff3dec6ec02f5ba0e0cb4fc0433667c21c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436310 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#812037}
-
Peter Kasting authored
Bug: 772945 Change-Id: I680e763fa212bbceaded6b337c29323f59bae9ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439439 Auto-Submit: Peter Kasting <pkasting@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#812036}
-
Marc Treib authored
This reverts commit 42484004. Reason for revert: Investigation has concluded, see crbug.com/1120899 Original change's description: > Sync: don't start up again (in transport mode) after StopAndClear > > This is essentially a revert of crrev.com/c/1082267 (undoing the actual > 1-line change from that CL, but keeping the comment improvements). > This is a temporary measure to investigate crbug.com/1120899. > > Bug: 1120899, 1082267 > Change-Id: I7761418c038824218a7fc36b325f1b364f7bbbe5 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401460 > Commit-Queue: Marc Treib <treib@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#805489} TBR=treib@chromium.org,mastiz@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1120899 Bug: 1082267 Change-Id: I75e64d1988cc585e2aa344058ac4d50dbb73fd34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438386Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#812035}
-
Austin Tankiang authored
This is so that we don't stay subscribed to Drive invalidations in Chrome when we switch to using DriveFS's invalidation stack. Bug: 1130427 Change-Id: I290f5ddacac20175a3e4845d8dc7c62f86315c61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428286Reviewed-by:
Kazuhiro Inaba <kinaba@chromium.org> Reviewed-by:
Sergei Datsenko <dats@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#812034}
-
Olivier Robin authored
Duplicate initialization was introduced by crrev.com/c/2167852 resulting in a dependency issue. Previous fix crrev.com/c/2435344 fixed the dependency but kept the double initialization. Restore the init order pre- crrev.com/c/2167852 Bug: 1132784 Change-Id: I69abeea6826e3aecbad7b321cdda33b6138628de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438427Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812033}
-
Marijn Kruisselbrink authored
This renames the content and blink directories. Other directories and file and class names will be renamed in follow up CLs. Bug: 1110509 Change-Id: I5c8788faac9cb53d42707a4ca0b6e1d62fde7fa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425009 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#812032}
-
Tanmoy Mollik authored
Add signout icon to the 'Turn On Sync' preference in ManageSyncSettings. Also use a regular preference instead of SyncOffPreference so that onClick animation is shown. SyncOffPreference class will be removed in a different cl. Screenshot: https://crbug.com/1131414#c4 Bug: 1131414 Change-Id: Ica45f3a97162189e142e9770b6f1545c0a9bb7e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438410Reviewed-by:
Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812031}
-
arthursonzogni authored
This test was failing for about a week. This patch disables it. TBR=lazzzis@chromium.org Bug: 1131684 Change-Id: I7fb23fc5bbba589b6048552d71f6f7d0756f8916 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438457Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812030}
-
Ian Kilpatrick authored
There should be no behaviour change. Change-Id: Iaf844f6ba65813022147d91fe8e0d7ebdaacd7e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2386457 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
David Grogan <dgrogan@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#812029}
-
Asami Doi authored
This CL makes the timer start immediately after an event is enqueued, and erases the event from the queue when it has not started to run yet and the timeout happens. Also, this CL updates kUpdateInterval because the minimum possible timeout is 10 seconds for offline events. Bug: 965802 Change-Id: Ib84c6f3164aa00d525d2f936385a152fdad1fa49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423698 Commit-Queue: Asami Doi <asamidoi@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#812028}
-
Mikhail Khokhlov authored
As a part of the experiment to run all execution on little cores we want to make sure that the cpu affinity doesn't change at runtime, e.g. when Chrome goes back from background. To do this, we introduce an interface in content that allows to enforce affinity by checking it on a regular basis (every 100 tasks) and setting it back when it changes. Change-Id: I766e94af42861870abe3a0079dd335a23462d481 Bug: 1111789 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2418673 Commit-Queue: Mikhail Khokhlov <khokhlov@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#812027}
-
Dominic Farolino authored
This CL migrates all calls to RT::GetRemoteRouteProvider() through ASG, so that it is the sole mojom::RouteProvider* in the renderer. This CL further restricts the usage of RT::GetRemoteRouteProvider to ASG via util::PassKey. For now, we still delegate to the RenderThread implementation to provide AssociatedInterfaceProvider routes. A subsequent CL will make AgentSchedulingGroup a fully-fledged RouteProvider, and we'll remove the RenderThread::GetRemoteRouteProvider public API then. Bug: 1132901 Change-Id: Idbd9311c777736d0a478da7a66718baa4e723275 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2433590Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Tal Pressman <talp@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Dominic Farolino <dom@chromium.org> Cr-Commit-Position: refs/heads/master@{#812026}
-
Aga Wronska authored
This reverts commit 9e410191. Reason for revert: Needed to merge this change into M85 and M86. It is not needed on Tot. Original change's description: > Disable iframes filtering feature for supervised users > > The feature has been disabled in Chrome OS < M87 with > Finch kill-switch and in this cl we apply the same change > in Chromium repo. > > Bug: 1132862 > Change-Id: I7c3446b6a6d7e4d06cdf2df5f12d6cf9eec4dc24 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435721 > Reviewed-by: Aga Wronska <agawronska@chromium.org> > Reviewed-by: Yilkal Abe <yilkal@chromium.org> > Auto-Submit: Aga Wronska <agawronska@chromium.org> > Commit-Queue: Yilkal Abe <yilkal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811255} TBR=agawronska@chromium.org,yilkal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1132862 Change-Id: Ia74140aaf0510f6b6d9e3b272c02e4cfd83d74f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437401Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#812025}
-
Anders Hartvoll Ruud authored
When setting the 'font' attribute, it must parse according to the grammar of <font> (minus CSS-wide keywords) [1]. Values with var() do not match the grammar of <font>, but the parsing function we use allow it anyway, since var()-containing values have special handling during regular CSS declaration parsing. There are multiple call sites that parse a <font> and then try to fix up the result (with IsCSSWideKeyword). This CL adds CSSParser::ParseFont which does the check for CSS-wide keywords, and now also for the pending-substitution value (which is what you get if you parse a var()-containing sequence as a shorthand). This fixes DCHECKs/undefined behavior when using var() in a canvas font attribute, or in FontFaceSet.load(). Bug: 1131922 [1] https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-font Change-Id: Ic906932fa14ad46683cf97edc78e2929020e0fd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2436346 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#812024}
-
Kuo Jen Wei authored
Bug: 1123750 Test: Manually Change-Id: I452a73ae553ad76c7b0ab5ad551edc6e6288eba0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438080 Commit-Queue: Inker Kuo <inker@chromium.org> Commit-Queue: Shik Chen <shik@chromium.org> Auto-Submit: Inker Kuo <inker@chromium.org> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#812023}
-
David Black authored
This will enable the better onboarding experience by default which shows a more welcoming UI in Assistant to new users. Bug: b:157510970 Change-Id: I029e3e79f738b05a338167db0a87db70023def93 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438075 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#812022}
-
Arthur Eubanks authored
This reverts commit 69f5d986. Breaks bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8867785886893833968/+/steps/gclient_runhooks/0/stdout Change-Id: Ic5c2bed98840e5d1cc2543bcdad5790a1ac82d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439437 Auto-Submit: Arthur Eubanks <aeubanks@google.com> Commit-Queue: Hans Wennborg <hans@chromium.org> Reviewed-by:
Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#812021}
-
Yoshifumi Inoue authored
This patch changes runtime enabled feature EditingNG from experimental to test to avoid users who turn on "Experimental Web Platform features" not to hit EditingNG issues. Bug: 707656, 1125477 Change-Id: I81b56ff56c44da74b0702e4e2f2d81355a0a0c2e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437834 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#812020}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/68983d39e5ce..adc22042d09d 2020-09-30 taylori@google.com Merge "ui: Don't allow selection in the track shell area" 2020-09-29 treehugger-gerrit@google.com Merge "ui: Add a metrics page" 2020-09-29 treehugger-gerrit@google.com Merge "Use CPU/wall time to descend TRACE_EVENTs when multiple children exist" 2020-09-29 dproy@google.com Merge "HistogramName interning" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4977c1c8e2841483ccb3efa5129e9ff419784169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437927Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812019}
-
Anders Hartvoll Ruud authored
This CL makes it possible to verify that two selector lists produce identical RuleFeatureSets. This will be very useful for testing the feature collection behavior for :is/:where in future CLs. This also adds code for compact stringification of RuleFeatureSets for debugging purposes. This is helpful for failing reftests, since it makes it possible to spot the differences. Bug: 568705 Change-Id: I1d8e9a3d10bef74c9d56c7406b7812038cad86f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2435345 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#812018}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8b16441c661b..2494f4964a64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC sinhak@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1073476,chromium:1080853,chromium:1080854,chromium:1099917,chromium:1105693,chromium:1109276,chromium:1116130,chromium:1126509,chromium:1127088,chromium:1128767,chromium:1130343,chromium:1131852,chromium:1132482,chromium:1132930,chromium:1132961,chromium:1132967,chromium:3289230,chromium:912681,chromium:989569 Tbr: sinhak@google.com Change-Id: I58082fb0271747c474ee800a383ce922a38f2fb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439105Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#812017}
-
Arthur Sonzogni authored
This reverts commit 8a94c67d. Reason for revert: https://crbug.com/1133354 Original change's description: > Generates the values of rich text fields on the browser from their inner text > > This patch prepares the groundwork for three related changes: > 1. The merging of AXNodePosition and BrowserAccessibilityPosition by moving hypertext computation > to AXNode. > This work will be completed in the following patch: > https://chromium-review.googlesource.com/c/chromium/src/+/2327552 > > 2. Computing the value of rich text fields on the browser which will improve performance > considerably in online document editors such as Google Docs, once Blink stops computing and sending their value > with every selection or text change event. > This work will be done in the following patches: > A) Improves performance by generating value and text changed events on the browser instead of in Blink. > https://chromium-review.googlesource.com/c/chromium/src/+/2322487 > B) Stops generating the value attribute for non-native text controls. > https://chromium-review.googlesource.com/c/chromium/src/+/2250070 > > 3. Consolidates all the methods for retrieving the value of any control, e.g. text field, color well, > <select> element and ARIA combo box, in AXNode::GetValueForControl. > This will enable Views to use an AXTree and deduplicate logic between BrowserAccessibility and > AXPlatformNodeDelegateBase. > > R=dmazzoni@chromium.org, aleventhal@chromium.org > > AX-Relnotes: n/a. > Change-Id: Iadd42e69d47394db95401a9822dd5a5eb55fb520 > Bug: 1049261 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2312642 > Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org> > Auto-Submit: Nektarios Paisios <nektar@chromium.org> > Cr-Commit-Position: refs/heads/master@{#811425} TBR=sadrul@chromium.org,dmazzoni@chromium.org,nektar@chromium.org,aleventhal@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1049261 Change-Id: If779fb97f99e5947ae4481689f56d185c7cbecd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438397Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812016}
-
Kent Tamura authored
Text controls in LayoutNG won't inherit from LayoutTextControl. We should avoid operations on LayoutTextControl. All of usages of casting to LayoutTextControl were to get TextControlElements. This CL replaces them with To<TextControlElement>(layout_object->GetNode()). This CL has no behavior changes. Bug: 1040826 Change-Id: Ic6879147314e91cdaf361734e8d6a06300eaeb6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438097 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#812015}
-
Gauthier Ambard authored
This CL makes sure to call FinalizeSessionRestore when resetting the restored_visible_item when an item is being committed. Fixed: 1127434 Change-Id: Idb6ca7ed3a2267dd5343b471c67251c756c8387c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421113Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#812014}
-
kyle Ju authored
Using wpt-import in Chromium 665502a0. With Chromium commits locally applied on WPT: 6bdcd688 "[COOP] access reporting: split property.https.html test." 58087bc8 "[Text Decorations] Compute ink_overflow" ff0d5a18 "[Trusted Types] Fix eval handling in workers." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true No-Export: true Change-Id: I1248dcd89d2e8260cd0615839ca6c46c568f9115 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2439422 Commit-Queue: Robert Ma <robertma@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#812013}
-
Harald Alvestrand authored
This also adds a failing test for the outstanding issue with transceiver updates. Bug: chromium:980879 Checkpoint Change-Id: Ib7a87042bd5a8dbf14d484731da4a1ffc5d563d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2437402 Commit-Queue: Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#812012}
-
arthursonzogni authored
Due to a bug, this was also executed on same-document and bfcache navigations. Executing this several time per document isn't causing issues, but it isn't logic, and represents unnecessary work. RFH::DidCommitNewDocument() has been introduced by: https://chromium-review.googlesource.com/c/chromium/src/+/2395777 and this patch moves: - RecordCrossOriginIsolationMetrics(this); - CrossOriginOpenerPolicyReporter::InstallAccessMonitorsIfNeeded(..) into it. Bug: 1090273 Change-Id: Idcf42f2d9194659a46c88cf7593161128b809fb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2409913Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#812011}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/92e869a63782..26525f46199d 2020-09-30 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-09-29 vidorteg@microsoft.com Improving description on some strings in the elements panel 2020-09-29 michael.liao@microsoft.com [Console Pin Pane]: use dt-close-button as remove live expression button 2020-09-29 vidorteg@microsoft.com Improving string description in resources_strings.grdp 2020-09-29 soxia@microsoft.com Device emulation extra reloading 2020-09-29 jalyn@microsoft.com Restore Toolbar button focus background 2020-09-29 yangguo@chromium.org Consider console.{assert, error, exception} messages e2e test failures If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1132333,chromium:1133075,chromium:1133344 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8681ae70698cdfdaa09bbd0d6f7df6e83632066c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2438292Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#812010}
-