- 06 Jan, 2020 23 commits
-
-
Alexandre Courbot authored
Use the Fourcc class instead of uin32_t with the GL/EGL image creation methods. This simplifies their logic a bit. BUG=None TEST=Video plays properly on Hana and Kevin non-VD. Change-Id: I50ae21d1ce34d3dba4c08bb59887d5f208b41a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982348Reviewed-by:
Hirokazu Honda <hiroh@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#728443}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I2b9520d6d7805d7c202a27b9cb72bae27e742812 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986022Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728442}
-
Alex Bergman authored
(see: i18n/input/javascript/chos/testing/integration/automation_ext/manifest.json) This extension is used for Essential Inputs testing, and permission is needed to enable typing on Virtual Keyboard. Change-Id: I5fcfc5a8de8d2f12c7302904146e3c36ee21e6bb Bug: 1039158 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983686 Commit-Queue: Alex Bergman <abergman@google.com> Reviewed-by:
Ben Wells <benwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#728441}
-
Matt Falkenhagen authored
These are still useful and for the foreseeable future, so extend by one year (plus one month to avoid alerts during the holiday season). Bug: 1037275, 1037273, 1037272, 1037271, 1037266 Change-Id: I26cad90d4dd9cc366ac7db920b71b2dbf6d225a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981235 Commit-Queue: Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#728440}
-
Koji Ishii authored
This patch changes |NGInlineLayoutAlgorithm| to place inline box placeholders to before children. Before this patch, they were created after children, only when the inline box is not culled. This change: 1. Reduces the insertion to |Vector| in |CreateBoxFragments|, which involves memory copy. This is not common today, but will be common when |NGFragmentItem| is enabled. 2. Allows easier implementation to "disable culled inline boxes" when |NGFragmetnItem| is enabled. There should be no behavior changes. Bug: 982194 Change-Id: I0d7077e4c9b78b99276afc2e7919258b33bd4ea6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980663Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728439}
-
Julie Jeongeun Kim authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/webgl. Bug: 1001114 Change-Id: Idac16870d09425fbe140ef5ed93b5558d4b555c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986476Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#728438}
-
Alexandre Courbot authored
The V4L2Device::Create(EGL|GL)Image methods took a const reference to the vector of DMAbufs representing the buffer. This suggests that the reference to the DMAbufs is borrowed, while the methods take full ownership of them. The clients of these methods are already correctly duplicating the FDs before passing them. However, for clarity make these methods take explicit ownership through a rvalue reference. BUG=None TEST=VDAtest passes on Hana TEST=crosvideo.appspot.com plays videos properly on Hana. TEST=VDAtest passes on Kevin TEST=crosvideo.appspot.com plays videos properly on Kevin with VD disabled. Change-Id: I91c1ba964c24ed4d8d8db4d0e1612c6eb147b7c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1981965Reviewed-by:
Chih-Yu Huang <akahuang@chromium.org> Commit-Queue: Alexandre Courbot <acourbot@chromium.org> Cr-Commit-Position: refs/heads/master@{#728437}
-
Noel Gordon authored
CL:1978684 increased the ChromeOS DEBUG bot timeout, and since that CL FilesApp browser tests do not flake in DEBUG anymore, issue 981420. Re-enable the FilesApp copyBetweenWindows tests that were marked flaky on the DEBUG bots, issue 1008909. Bug: 981420, 1008909 Change-Id: Ibb253b8aa79b093935db312448339f5feaa350f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983681 Auto-Submit: Noel Gordon <noel@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#728436}
-
Miyoung Shin authored
This is a part of effort for using [RaisesException] when synchronously rejecting a promise. It uses [RaisesException] for //third_party/blink/renderer/modules/cache_storage. Bug: 1001114 Change-Id: I78e3b02518e5c04725f50abb9e6ca54b191f3bc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985833Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#728435}
-
Wanming Lin authored
This CL adds several wpt tests for Web NFC: - Test push operation fails when data transfer fails - Verify pushed message for empty record type - Test reading message with multiple records should succeed Bug: 520391 Change-Id: Iadb13f6cebaf30514ba7bef65a69302b368e4359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982271 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
Leon Han <leon.han@intel.com> Reviewed-by:
Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#728434}
-
Koji Ishii authored
This patch reverts |LayoutInline::CollectLineBoxRects| not to use |NGInlineCursor|, by manually merging parts of r706815 <crrev.com/c/1862534> and r710694 <crrev.com/c/1888624>. |NGInlineCursor| is rapidly changing that reverting is not easy. This patch reverts not to use it for |getClientRects| and a few other callers. Testing more on culled inline box indicates that the phase 1 of LayoutNG regressed some cases from legacy, and |NGInlineCursor| work regressed further. We might want to fix when NGFragmentItem ships, but better not to change the behavior until then. Bug: 1036358 Change-Id: I47a60f5d3a505d4b43eba0d8b5adc64e02cbcd28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971632Reviewed-by:
-
Richard Li authored
Although overlay cannot process HDR video without colorspace degraded, renderpass will still be sent to OverlayProcessor. Since there isn't an explicit skipping policy for processing HDR content with overlay in HDR mode, this CL adds an condition to skip further processing when target colorspace is HDR. Change-Id: I14d2c39a332827990b950ee04f5174ddac0f1ee0 Bug: 1036736 Change-Id: I14d2c39a332827990b950ee04f5174ddac0f1ee0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1977848Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Richard Li <richard.li@intel.com> Cr-Commit-Position: refs/heads/master@{#728432}
-
Robert Liao authored
This reverts commit 547be407. Reason for revert: Causes a CFI Failure https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16082 ../../content/browser/renderer_host/render_widget_host_view_aura_unittest.cc:1625:9: runtime error: control flow integrity check for type 'content::NativeWebKeyboardEvent' failed during base-to-derived cast (vtable address 0x55aaa1c38368) 0x55aaa1c38368: note: vtable is of type 'blink::WebKeyboardEvent' const NativeWebKeyboardEvent* native_key_event = static_cast<const NativeWebKeyboardEvent*>( events[0]->ToEvent()->Event()->web_event.get()); Original change's description: > Modernize WebInputEvent > > Since the class is no longer memcopied between processes we can > use virtuals. > - Add virtual destructor > - Add pure virtual cloning > - Remove memset > - Remove size attribute > > BUG=836826 > > Change-Id: I92f7c1394009223d0e7970929ae5cdfc4bec2b00 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972167 > Commit-Queue: Dave Tapuska <dtapuska@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Reviewed-by: Jeremy Roman <jbroman@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728205} TBR=nasko@chromium.org,bokan@chromium.org,jbroman@chromium.org,dtapuska@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 836826 Change-Id: Id8d19c45afaa236288b9a03abecd91ad12b1e031 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1988025Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#728431}
-
David Munro authored
Bug: chromium:1038610 Test: Deploy and view. Change-Id: I5eda1e169936c3ab3c8eb0419564b5615688de4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985826 Auto-Submit: David Munro <davidmunro@google.com> Reviewed-by:
Jason Lin <lxj@google.com> Reviewed-by:
Julian Watson <juwa@google.com> Commit-Queue: Julian Watson <juwa@google.com> Cr-Commit-Position: refs/heads/master@{#728430}
-
Mason Freed authored
The [1] CL enabled the FormControlsRefresh feature by default for Windows, Linux, and ChromeOS. In the process, many layout tests were disabled, because the form controls have a different appearance with the feature enabled. This is one of several patches rebaselining those disabled tests. [1] http://crrev.com/c/1967608 Bug: 1035582 Change-Id: I1cf7247ed3f0b866db223f2bc927c7755fc9f8f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986263 Auto-Submit: Mason Freed <masonfreed@chromium.org> Commit-Queue: Stephen Chenney <schenney@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#728429}
-
Robert Liao authored
This reverts commit c907f4bb. Reason for revert: https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16085 Contained the revert and the same tests are failing. Original change's description: > Revert "Remove CompositorFrame handling in render_host" > > This reverts commit aad41255. > > Reason for revert: > This is being reverted by the build sheriff on suspicion of causing the following break. > > https://ci.chromium.org/p/chromium/builders/ci/Linux%20CFI/16082 > > The following two tests seem to fail consistently after this changelist: > RenderWidgetHostViewAuraTest.KeyEventRoutingWithKeyboardLockActiveForAllKeys > > RenderWidgetHostViewAuraTest.KeyEventRoutingWithKeyboardLockActiveForOneKey > > > Original change's description: > > Remove CompositorFrame handling in render_host > > > > This CL starts to remove code in content/browser/renderer_host/ that > > existed to receive CompositorFrames and submit them to the display > > compositor running on the browser UI thread. The VizDisplayCompositor > > feature has launched so this code is no longer used. > > > > This CL is a first pass to delete code that doesn't have require > > significant changes to tests. > > > > TBR=sky@chromium.org > > > > Bug: 759653, 812322, 1038683 > > Change-Id: I7bf29f57e7418eb8d3a16b86169f2b30bb9fbf80 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978997 > > Reviewed-by: Saman Sami <samans@chromium.org> > > Commit-Queue: kylechar <kylechar@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#728209} > > TBR=sky@chromium.org,kylechar@chromium.org,samans@chromium.org > > Change-Id: Ia0b20ebad951e8f22fb0f108cb9d09160e1a645c > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 759653, 812322, 1038683 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986978 > Reviewed-by: Peter Williamson <petewil@chromium.org> > Commit-Queue: Peter Williamson <petewil@chromium.org> > Cr-Commit-Position: refs/heads/master@{#728341} TBR=sky@chromium.org,petewil@chromium.org,kylechar@chromium.org,samans@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 759653, 812322, 1038683 Change-Id: I8e27abb2e5e6cc818f08f3473a1eb626c7bcaa66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983687Reviewed-by:
-
Melissa Zhang authored
BUG=968439 Change-Id: If92868debe3c0a2b1c2532a05e97fa953c50901c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1939148 Commit-Queue: Melissa Zhang <melzhang@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#728427}
-
Matt Menke authored
It wasn't being used meaningfully, and we want to remove the class. Bug: 651119 Change-Id: Id479b735d1ef677d7eb55faf5e44ab2de859cd2c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971755Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#728426}
-
Peter Kasting authored
Specifically, the caption colors need to update. On Ash this was happening indirectly already, since BrowserNonClientFrameViewAsh::OnThemeChanged() was calling UpdateFrameColor(). But on other platforms, it was not. Handling this eliminates the need to set these colors at construction or in BrowserNonClientFrameViewAsh::Init(), since OnThemeChanged() will always be called when the frame is added to a widget, which happens after both those. This also eliminates the need to null-check the frame view in WebAppFrameToolbarView::UpdateCaptionColors(), since by OnThemeChanged() that will always be set. Finally, this eliminates the need for BrowserNonClientFrameViewAsh::OnThemeChanged() to indirectly call WebAppFrameToolbarView::UpdateCaptionColors(), since that is now called locally. Also, the BrowserNonClientFrameView need not explicitly SchedulePaint(), since if any children of the web app frame actually change color, they will invalidate themselves as necessary. Bug: none Change-Id: If0a24ccebcf8ce105dc3662ee6468d6b9b36d419 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980166Reviewed-by:
Alan Cutter <alancutter@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#728425}
-
Hiroki Sato authored
Bug: b:129680977 Test: manual. (ChromeVox and HighlightInputFocus on eve and laser14) Change-Id: Ifb14d413e1135d4acd8bbc8f24631df6862bc3db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1978202Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Hiroki Sato <hirokisato@chromium.org> Cr-Commit-Position: refs/heads/master@{#728424}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/f4ee9eec3ea5..9e850d191a29 Created with: gclient setdep -r src-internal@9e850d191a29 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Iefad82a80e304c9e09ff06d7fede3b15c2f0409d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987850Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728423}
-
nancy authored
The reason is CL:1981526 removes default iconn loading, so ARC icon loading could take some time. When FetchImage, icon is set as null: gfx::ImageSkia() So UpdateImage could load null image, which causes DCHECK error: Check failed: InitializedWithRecordingBounds() Add checking for null image, and if image is null, don't call delegate to update image. BUG=1038602 Change-Id: I15515d318b8601aaf456ea499c3f9d82fff0a437 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985628 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#728422}
-
Rob Schonberger authored
Bug: 1009290 Change-Id: I416da812513b27e80c0150ad76028e6dab20c596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984798 Commit-Queue: Rob Schonberger <robsc@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#728421}
-
- 05 Jan, 2020 17 commits
-
-
chromium-autoroll authored
Roll ChromeOS orderfile from 81-3987.18-1577705382-benchmark-81.0.4012.0-r1 to 81-3987.18-1577705382-benchmark-81.0.4013.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: If76e2a04cee27853256f2a35eee28ecf232f169a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987848Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728420}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bdb4f178f67f..f4ee9eec3ea5 Created with: gclient setdep -r src-internal@f4ee9eec3ea5 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I5e6e93887c57da3fcbf5f22acc88e5eeed7d39d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987847Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3940172c..7c5025db Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1d3652798e820b97756e600fbca659ccd045a29c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986142Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728418}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/bfa2664cb4ce..bdb4f178f67f Created with: gclient setdep -r src-internal@bdb4f178f67f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I7441ee7612027aeb6b0ca6e538269f3f1f73916d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987890Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/6655f1a07a50..bfa2664cb4ce Created with: gclient setdep -r src-internal@bfa2664cb4ce If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I705ef5046d6227b54bb464b1953f7a58c35074a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987885Reviewed-by:
-
Yuki Shiino authored
CodeGenContext.template_bindings() may be bound multiple times in a chain of parent-child code nodes. This patch supports such shadowing of template variables only for CodeGenContext. Bug: 839389 Change-Id: I0d3c83c05e5e807bcc5f11ca9839380b972e3526 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982575 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#728415}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I7b8166d27a8e74c3cff1741ab0e5e78044e93124 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1983685 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Yuki Shiino authored
web_idl.file_io reads/writes in binary mode so that it produces the same result on Windows. Also makes intermediate directories if necessary. Bug: 839389 Change-Id: I9743af13acfaa0cefaed6f4b76d6fac28ae3e608 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980606Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2de68515..3940172c Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1f5c7508f66c54e03fb06ba8cb979129b969374c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1984508Reviewed-by:
-
Yuki Shiino authored
Bug: 839389 Change-Id: I9d5d9238d48516d3d32e971510a3ca506a16c12c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980605Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium eedc81a7. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I18b59d46f2f81d816d815ad83abc081978f1e83a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986141Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#728410}
-
Koji Ishii authored
Following bot results are included. 822 823 824 825 826 827 828 829 830 831 832 833 834 835 836 837 76 lines were removed and 18 lines were deflaked by consecutive results since 822. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ic2bafcc371c6a37dd82781f808e38475524180c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1982572Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#728409}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/2de044fed052..6655f1a07a50 Created with: gclient setdep -r src-internal@6655f1a07a50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I625368cef243bd26cd426c03ba6a8abdb8fb5076 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987713Reviewed-by:
-
Monica Basta authored
Change-Id: I280a9af2368e7edad77f7e6104acae9cdabd2463 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985845Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#728407}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0a272f3acd2c..2de044fed052 Created with: gclient setdep -r src-internal@2de044fed052 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I81f56fb6f134ab236781855a0041d37d008b1098 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1987711Reviewed-by:
-
Md. Hasanur Rashid authored
The conditions have been phrased positively to understand better in future. Bug: 919870 Change-Id: Ib76393bf7dff667bcdca9abc50d5f2b26ddf5569 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1985638Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Cr-Commit-Position: refs/heads/master@{#728405}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I583f47fc7f065489fb4f5a2473898fb95c9c7bb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980604 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
