GitLab

OnSizeConstraintsChanged should be skipped if the window is a popup or child.

BUG=439038

Review URL: https://codereview.chromium.org/792303002

Cr-Commit-Position: refs/heads/master@{#308016}

This will ensure that WeakPtrs are invalidated before any other members'
destructors are invoked. This is also one of the last classes needing to
change to allow us to turn on a Clang check for WeakPtrFactory member order.
Please see the bug for more details.

BUG=303818

Review URL: https://codereview.chromium.org/795003003

Cr-Commit-Position: refs/heads/master@{#308015}

This is only used in specific circumstances in the renderer, so move it to ChildSharedBitmapManager.

Review URL: https://codereview.chromium.org/795843002

Cr-Commit-Position: refs/heads/master@{#308014}

The new ResourceManager assumes the generated resource is of type
RGBA8. Add additional type support for A8, the format used by the
overscroll effect on Android L.

BUG=426939

Review URL: https://codereview.chromium.org/798783002

Cr-Commit-Position: refs/heads/master@{#308013}

Partial revert of the following patch:
https://codereview.chromium.org/675313002/

BUG=436689
TBR=tedchoc@chromium.org

Tbr since code-review is broken and Ted gave me the LGTM.

Review URL: https://codereview.chromium.org/797833002

Cr-Commit-Position: refs/heads/master@{#308012}

* Moves some functions that deal TabState filenames to TabState
  from TabPersistentStore downstream.

* Moves DOCUMENT_SCHEME from IntentHandler.java to UrlConstants.java
  with similar schemes.  Note that the DOCUMENT_SCHEME doesn't include
  the "://" string like the other Java scheme constants; this is because
  the Document classes use a real Uri parse to parse the scheme instead
  of doing a plain old TextUtils.equals() comparison.

BUG=415747

Review URL: https://codereview.chromium.org/796113003

Cr-Commit-Position: refs/heads/master@{#308011}

Changing in the intialization order of WeakPtrFactory such that all
member variables should appear before the WeakPtrFactory to ensure
that any WeakPtrs to Controller are invalidated before its members
variable's destructors are executed, rendering them invalid.

BUG=303818

Review URL: https://codereview.chromium.org/791353002

Cr-Commit-Position: refs/heads/master@{#308010}

The new methods are meant to replace similar functions from kill.h

BUG=417532

Review URL: https://codereview.chromium.org/791503002

Cr-Commit-Position: refs/heads/master@{#308009}

BUG=438474
TEST=as in bug; no crash
TBR=thestig@chromium.org,atwilson@chromium.org

Review URL: https://codereview.chromium.org/790423002

Cr-Commit-Position: refs/heads/master@{#308008}

R=cmumford@chromium.org

Review URL: https://codereview.chromium.org/783393002

Cr-Commit-Position: refs/heads/master@{#308007}

BUG=441046

Review URL: https://codereview.chromium.org/799443002

Cr-Commit-Position: refs/heads/master@{#308006}

The original CL used instance variables in a class extension and automatic
generation of ivars for synthesized properties, features only available on
64-bit builds. The Mac Memory bots are still compiling Chromium in 32-bits.
This reland removes the usage of those features.

> This CL adds the class HandoffManager, which is responsible for interfacing
> with Apple's Handoff APIs. It takes a GURL, and exposes that GURL to Handoff.
>
> This CL adds the class ActiveWebContentsObserver, which is responsible for
> listening to changes to the active browser, the active tab, and the visible
> URL. It notifies its delegate when any of this state might have changed.
>
> AppControllerMac is the delegate of ActiveWebContentsObserver, as well as the
> owner of the HandoffManager. When it receives a delegate callback, it passes an
> updated GURL to the HandoffManager. There is some minimal logic in
> AppControllerMac that prevents URLs from incognito windows from being passed to
> the HandoffManager.
>
> BUG=431051, 438823
> Committed: https://crrev.com/708abc5b0abb5e0916d779bf6d1342fd472a2aa1
> Cr-Commit-Position: refs/heads/master@{#307846}

BUG=431051, 438823
TBR=sky, erikwright, mmenke, avi

Review URL: https://codereview.chromium.org/794853004

Cr-Commit-Position: refs/heads/master@{#308005}

glGenTransformFeedbacks
glDeleteTransformFeedbacks
glIsTransformFeedback
glBindTransformFeedback
glBeginTransformFeedback
glEndTransformFeedback
glPauseTransformFeedback
glResumeTransformFeedback

The missing ones are:
glTransformFeedbackVaryings
glGetTransformFeedbackVarying

Also this CL fixed a bug that's introduced in a previous CL for glIs* handling.  Basically the client ID needs to be mapped to the service ID before passing down to the driver. The test is generalized to mask this bug, so this CL fixes both the code and the test behavior.

BUG=429051
TEST=gpu_unittests
R=bajones@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/795243002

Cr-Commit-Position: refs/heads/master@{#308004}

The return value of DesktopNativeCursorManager::GetInitializedCursor() is no
longer valid after DesktopNativeCursorManager::SetDisplay() is called.
This CL ensures that the return value of
DesktopNativeCursorManager::GetInitializedCursor() is not cached.

BUG=440534
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/751063008

Cr-Commit-Position: refs/heads/master@{#308003}

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/792183003

Cr-Commit-Position: refs/heads/master@{#308002}

This is a follow-up for an internal discussion about possible jank, and more generally, performance issues that potentially are not tracked by about://profiler and UMA profiler data.

This CL adds instrumentation that adds tracking for all WM_ message handlers. It's enabled only in Canary, and on other channels we won't track WM_ messages.

If we find it valuable and safe, we can enable this instrumentation on other channels too.

BUG=440919

Review URL: https://codereview.chromium.org/793893002

Cr-Commit-Position: refs/heads/master@{#308001}

Add a new background to TrayPopupHeaderButton which is used for both mouse and touch feedback. Mouse hover, and tap down, events will trigger the background. Completing a click or tap, or exiting the button, will remove the feedback.

The size of TrayPopupHeadButton has been updated according to the new spec in issue 402515.

TEST=TrayDetailsViewTest.TrayPopupHeaderButtonTouchFeedback, TrayDetailsViewTest.TrayPopupHeaderButtonTouchFeedbackCancellation, TrayDetailsViewTest.TrayPopupHeaderButtonMouseHoverFeedback
BUG=402515

Review URL: https://codereview.chromium.org/800513002

Cr-Commit-Position: refs/heads/master@{#308000}

BUG=417532

Review URL: https://codereview.chromium.org/793453002

Cr-Commit-Position: refs/heads/master@{#307999}

We added the horizontal_axis value to the SendMouseWheelEvent method, so that
the mousewheel event now can scroll vertically and horizontally.

BUG=435154

Review URL: https://codereview.chromium.org/792333004

Cr-Commit-Position: refs/heads/master@{#307998}

BUG=436603

Review URL: https://codereview.chromium.org/802503003

Cr-Commit-Position: refs/heads/master@{#307997}

It currently uses ChromeViewsDelegate.

This is a problem for MacViews, because ChromeViewsDelegate only
provides an out-of-process compositor, which isn't available in tests
using ViewEventTestBase.

It's not a problem for Aura, because Aura platforms tend to get their
ContextFactory form aura::Env instead of ViewsDelegate

BUG=403679

Review URL: https://codereview.chromium.org/785233008

Cr-Commit-Position: refs/heads/master@{#307996}

BUG=439529

Review URL: https://codereview.chromium.org/797463002

Cr-Commit-Position: refs/heads/master@{#307995}

Moves the native-event test from RenderWidgetHostViewAura::OnKeyEvent()
down to MakeWebKeyboardEvent() so that nativeKeyCode is correctly set.

Symptoms included incorrect characters in Chromoting, and Search key not working in non-web windows.

BUG=425156
BUG=440184

Review URL: https://codereview.chromium.org/789153004

Cr-Commit-Position: refs/heads/master@{#307994}

Requests is already mirrored on chromium.
It has an Appache 2.0 license.
It is required for the appurify python api found in thirdparty to work.

BUG=439624

Review URL: https://codereview.chromium.org/782083002

Cr-Commit-Position: refs/heads/master@{#307993}

The flag can be removed once the remaining references in blink are removed.

BUG=426520

Review URL: https://codereview.chromium.org/707173003

Cr-Commit-Position: refs/heads/master@{#307992}

This was a workaround for VS's before 2013 that lack va_copy, and is
no longer required. The unittest is removed as it seems unnecessary
to test the standard library's implementation of va_copy.

R=thakis@chromium.org
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/802533002

Cr-Commit-Position: refs/heads/master@{#307991}

onBackgroundColor is currently coming through ContentViewCore.
The downstream counterpart to this will remove the downstream
notification.

BUG=344589

Review URL: https://codereview.chromium.org/791393003

Cr-Commit-Position: refs/heads/master@{#307990}

BUG=353260

Review URL: https://codereview.chromium.org/801503002

Cr-Commit-Position: refs/heads/master@{#307989}

Warning was:
src\sandbox\win\src\policy_engine_processor.cc(81) : warning C6313:
Incorrect operator:  zero-valued flag cannot be tested with bitwise-and.

This change should have no effect because the kStopOnErrors policy is
never requested.

BUG=427616

Review URL: https://codereview.chromium.org/789543004

Cr-Commit-Position: refs/heads/master@{#307988}

BUG=396568
TBR=feng@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/797783002

Cr-Commit-Position: refs/heads/master@{#307987}

The current implementation of
GestureRecognizerImpl::GetTargetForGestureEvent() will insert a
mapping between a touch ID and a NULL GestureConsumer to
|touch_id_target_for_gestures_| if queried with a touch ID that
does not already exist in the map. Use .at() instead of []
to avoid this possibility.

BUG=403346
TEST=none

Review URL: https://codereview.chromium.org/466323004

Cr-Commit-Position: refs/heads/master@{#307986}

Causes views_unittests EventMonitorTest.ShouldNotReceiveEventsFromOtherWindow to fail, see
http://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20Tests%20%28dbg%29%281%29/builds/35121/steps/views_unittests/logs/stdio

This reverts commit e393fdb1.

Cr-Commit-Position: refs/heads/master@{#307985}

These people are not really owners. Bye.

BUG=None
TBR=reillyg@chromium.org
NOTRY=True

Review URL: https://codereview.chromium.org/797633003

Cr-Commit-Position: refs/heads/master@{#307984}

This is the second platform-dependent CL on our way to support pointer, any-pointer, hover and any-hover media queries.
http://dev.w3.org/csswg/mediaqueries-4/#mf-interaction
This CL includes changes for windows, aurax11, linux and ozone.

This follows the platform-independent patch (crrev.com/685153003) and the Android-specific patch (crrev.com/696713002).

BUG=136119

Review URL: https://codereview.chromium.org/781753005

Cr-Commit-Position: refs/heads/master@{#307983}

Include tests that verify the interaction of the data
reduction proxy's bypass mechanism and a real server.

BUG=438866

Review URL: https://codereview.chromium.org/749793002

Cr-Commit-Position: refs/heads/master@{#307982}

- Save off various events in DataReductionProxyEventStore for later use
(last bypass event, data reduction proxy configuration, canary request
state)
- Plumb DataReductionProxyEventStore through ChromeNetworkDelegate to
net_internals_ui.cc for consumption by bandwidth_view.js/html
- Update bandwidth_view.* for rendering the DataReductionProxyEventStore
information

BUG=346356

Review URL: https://codereview.chromium.org/775773002

Cr-Commit-Position: refs/heads/master@{#307981}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/b393412..4a1d377

TBR=rtoy@chromium.org,lushnikov@chromium.org,vsevik@chromium.org

Review URL: https://codereview.chromium.org/797743002

Cr-Commit-Position: refs/heads/master@{#307980}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/798693002

Cr-Commit-Position: refs/heads/master@{#307979}

BUG=417532

Review URL: https://codereview.chromium.org/790003002

Cr-Commit-Position: refs/heads/master@{#307978}

depends on https://codereview.chromium.org/756333003/

BUG=437116

Review URL: https://codereview.chromium.org/773653002

Cr-Commit-Position: refs/heads/master@{#307977}