- 04 Jun, 2020 40 commits
-
-
arthursonzogni authored
This test is flaky on Android Pie. TBR=hanxi@chromium.org, wychen@chromium.org Bug: 1091311 Change-Id: I0a64088ffd0274d0ba77326fc1cdd503e6a8c73b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231047 Auto-Submit: Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Arthur Sonzogni <arthursonzogni@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775183}
-
Daniel Winkler authored
Recent ChromeOS bluez-next uprev fixes a bug that clears a client's discovery filter between discovery sessions. Now that it is fixed, we must be sure the filter is refreshed to prevent lingering filters from affecting client discovery. BUG=b:157266509 TEST=ARC++ bluetooth tests that use LE filters Change-Id: I06cf494a49d6bcf83370fbcb0f1d365a50e27560 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225278 Commit-Queue: Daniel Winkler <danielwinkler@google.com> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Miao-chen Chou <mcchou@chromium.org> Reviewed-by:
Sonny Sasaka <sonnysasaka@chromium.org> Cr-Commit-Position: refs/heads/master@{#775182}
-
Koji Ishii authored
Sometimes we may need to retrieve |NGLayoutResult| after its |WillBeDestroyed| is called. 1. |LayoutBox::WillBeDestroyed| marks its cached |NGLayoutResult| as |WillBeDestroyed|. 2. |LayoutObject::WillBeDestroyed| clears its children by |DestroyLeftoverChildren|. 3. One of its descendant calls |SetNeedsLayout|. 4. In determining the container chain to mark dirty, |GetCachedLayoutResult| is needed to know if |ObjectIsRelayoutBoundary|. There will be rooms to improve, such as: * |DestroyLeftoverChildren| after |WillBeDestroyed| of its subclasses look dangerous. |LayoutBlockFlow| calls |DestroyLeftoverChildren| probably to prevent this. * We can probalby stop marking objects that are |BeingDestroyed|, though knowing exactly where may not be easy. but these changes are likely risky. This patch simply allows retrieving |GetCachedLayoutResult| if |BeingDestroyed|. Bug: 1091188 Change-Id: I966e1c6e7844fed795eadeb775b520bbd239e56a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230562 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#775181}
-
Chris Lu authored
This change leaves BannerVisibilityChanged unimplementated in InfobarBannerInteractionHandler. This will allow the PasswordInfobarBannerInteractionHandler implementation to be executed. This change also modifies GetInfobarDelegate to return the generic InfoBarDelegate since BannerDismissedByUser is a general implementation by all Infobars. Translate is not a ConfirmInfoBarDelegate. Change-Id: Id6bfa73a8d1ca274466bb8c14217135438c19e3c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229602Reviewed-by:
Kurt Horimoto <kkhorimoto@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#775180}
-
Katie D authored
The UX mock has a slightly different string, so this just adjusts the string. AX-Relnotes: Adjust STS background shading string. Bug: 1079424 Change-Id: Ic485e1a39dbcfb614c8f5159d419fe1fe811a97a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231020 Auto-Submit: Katie Dektar <katie@chromium.org> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#775179}
-
Yi Gu authored
This test is flaky under a variety of test suites: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyYwsSBUZsYWtlIlhjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZmFzdC9zY3JvbGxpbmcvc2Nyb2xsYmFycy9tb3VzZS1hdXRvc2Nyb2xsaW5nLW9uLXNjcm9sbGJhci5odG1sDA TBR=arakeri@microsoft.com NOTRY=TRUE Bug: 1057060 Change-Id: Ib4fa290128f5b106c551bf756d0665d72117d112 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230910Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775178}
-
Xiyuan Xia authored
ui::ThroughputTracker provides a more accurate smoothness tracking than ash::FpsCounter. Re-wire the start/stop smoothness tracking api using that. Bug: 1062124 Change-Id: I7472593810e2dc2151059e16656041cb1a7a72d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226278Reviewed-by:
Jun Mukai <mukai@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775177}
-
Haiyang Pan authored
Currently they have been disabled on Emulator on Pie. See https://crbug.com/1077316#c1 Bug: 1077316, 1022533 Change-Id: I0a9d917a650e27c477ef7f693010f2c8e1bd07f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229878 Auto-Submit: Haiyang Pan <hypan@google.com> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Cr-Commit-Position: refs/heads/master@{#775176}
-
James Cook authored
I renamed a test and didn't realize there was a filter file to update. TBR=rsorokin@chromium.org Bug: 1074436 Change-Id: I89f46e71c8422043af9f369fda238b436cae477f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231450Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#775175}
-
Jonah Ryan-Davis authored
We are still tracking these metrics. Bug: chromium:1088816 Bug: chromium:1088825 Bug: chromium:1089985 Bug: chromium:1089986 Change-Id: I1999ba730fa60299f213d00f8a1fc6c62c36643f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227882 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#775174}
-
Mila Green authored
Bug: 1090553 Change-Id: I7f64266160d1de8b321c8d2df863e6faed92f20a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225250 Commit-Queue: Mila Green <milagreen@chromium.org> Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Cr-Commit-Position: refs/heads/master@{#775173}
-
Vladimir Levin authored
In NodeHighlightTool ctor, we may override which node is actually used, if the node in question is under a content-visibility element which prevents visibility. When later on we fetch the contrast values for that node, we should use |node_| as opposed to |node| since at that time, the two values could be different. Note that this changes includes leveraging NodeHighlightTool directly in the getHighlightObjectForTest function, since previously the two implementations were different. The updated test would now fail without the |node| -> |node_| switch, but passes with the switch. R=chrishtr@chromium.org Fixed: 1090371 Change-Id: Ic98aafaf02818203311bf6a745575a0612612914 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228124Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775172}
-
Naomi Musgrave authored
Bug: 1084582 Change-Id: Ia384e12083a590f52beb1f98d50b192ab20f31cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182654 Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#775171}
-
Koji Ishii authored
Minor refactoring while reviewing crbug.com/1091188. This patch has no behavior changes. Change-Id: Ic1ccef8b6c093039e34b536573ef16889a52dc6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230585 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Tarun Bansal authored
These are flaky on other platforms too. Bug: 1087675,1087728,1087697,1087876,1088454,1088454 Change-Id: I73833f8edae03ba2c62c8093f9808b1667dcdbef TBR: ryansturm@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231444 Commit-Queue: Tarun Bansal <tbansal@chromium.org> Auto-Submit: Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#775169}
-
Sean O'Brien authored
Currently a keyboard device must present the udev attribute 'function_row_physmap' if we want to handle custom top row mappings. This change also allows the same mapping to be provided in a udev property. This will allow us to move existing keyboards to the custom layout codepath. BUG=b:157067041 TEST=Add udev rule for an external keyboard and test manually. Unit tests. Change-Id: I8f213b5254e34ad6ce9403e66aadb65e6b5c5d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229665Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
-
Gyuyoung Kim authored
This CL converts GetSavableResourceLinksFoo IPC messages to Mojo, - FrameMsg_GetSavableResourceLinks - FrameHostMsg_SavableResourceLinksResponse - FrameHostMsg_SavableResourceLinksError FrameMsg_GetSavableResourceLinks is converted to the blink's LocalFrame interface with a reply. GetSavableResourceLinks will return a callback with a result(GetSavableResourceLinksReply struct). If the result is nullptr, it means that an error happens. Thus, we don't need to keep FrameHostMsg_SavableResourceLinksResponse and FrameHostMsg_SavableResourceLinksError messages anymore. SavableSubframe native struct is moved to the blink's frame.mojom, then savable_subframe.h file is removed. This CL moves savable_resource.h/cc from //content/renderer to blink. But, DomSerializerTests should continue using it. So, this CL introduces web_savable_resources_test_support.h/cc files which support below testing function in order to support the tests. - GetSubResourceLinkFromElementForTesting Bug: 1047312 Change-Id: I8e95afcb4f55efa23a106654ec92729424301d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2208085 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#775167}
-
Eric Orth authored
Bug: 878582,1087444 Change-Id: I46d852911322d1a246ec48ca45f61c18ff485de2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219016 Commit-Queue: Eric Orth <ericorth@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#775166}
-
Peng Huang authored
For non-GL backends, shared image backings doesn't need GL API, so call MakeCurrent with needs_gl = false. For GL backend, MakeCurrent() will ignore needs_gl, and always make the context current. Bug: None Change-Id: I95ab79f0bb332122d7243f2a7361c6ff07e85407 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230327 Auto-Submit: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#775165}
-
arthursonzogni authored
This test is consistently failing on the test-o-phone bot. This patch disables it on Oreo. TBR=wychen@chromium.org, meiliang@chromium.org Bug: 1091148 Change-Id: I6931a1ebfe3f18d3657a0d2c251c9adbf2e304c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230492Reviewed-by:
-
Yi Gu authored
TBR=johnchen@chromium.org Bug: 1091274 Change-Id: I1e4b6ccf64c3966b17ba582f420b2f0e83648fc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230763Reviewed-by:
-
Dave Tapuska authored
This class duplicated ui::ImeTextSpan. blink/public already depended on a number of parts of base/ime so this is just another one. BUG=1073560 Change-Id: I042d613d6f7fa2490f507193a2b1611054bbe511 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225240Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#775162}
-
Dan Zhang authored
https://quiche.googlesource.com/quiche.git/+log/4026f6e15a63..d7b17f31c55ae $ git log 4026f6e15..d7b17f31c --date=short --no-merges --format='%ad %ae %s' 2020-06-02 bnc Deprecate gfe2_reloadable_flag_spdy_hpack_use_indexed_name. 2020-06-02 renjietang Add << operator for TransmissionType to make debugging easier. 2020-06-02 fayang Deflake //third_party/quic/core/http:end_to_end_test. 2020-06-02 fayang In quic, add num_draining_outgoing_streams_ to quicsession, and this counter will be used to determine shouldkeepconnectionalive in quicspdyclientsessionbase. client side only. not protected. 2020-06-02 fayang In quic, do not arm pto if the only in flight packet is half rtt data before handshake completion. protected by gfe2_reloadable_flag_quic_fix_server_pto_timeout. 2020-06-02 fayang Log max_packet_length and header when failed to serialize packet. 2020-06-02 nharper Improve QuicCryptoServerStreamBase functions for querying resumption status 2020-06-02 renjietang Internal QUICHE change 2020-06-02 fayang In quicsession, unify num_*_incoming_streams_ and num_*_outgoing_streams_. refactoring only, not protected. Created with: roll-dep src/net/third_party/quiche/src src/third_party/quic_trace/src substitute GetNumDrainingStreams and GetNumOpenDynamicStreams R=dschinazi@chromium.org Change-Id: I65bf6eb1a694d62ba4bc25a1142f587595de79aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229719 Commit-Queue: Dan Zhang <danzh@chromium.org> Auto-Submit: Dan Zhang <danzh@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Cr-Commit-Position: refs/heads/master@{#775161}
-
Gabriel Charette authored
As a new name for ScopedNestableTaskAllower. A migration will follow to move callers either to the new name or to RunLoop::Type::kNestableTasksAllowed. R=fdoray@chromium.org Bug: 781352 Change-Id: I5208655072728b4305e70815ccb933173ff0842e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225834 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#775160}
-
Liviu Tinta authored
This fails the DCHECK at https://cs.chromium.org/chromium/src/content/browser/renderer_host/input/mouse_wheel_event_queue.cc?rcl=ef743dd6fa992f43b9417d07c281b1f39b7d5ad2&l=273 leading to subsequent wheel events be not cancelable when preventDefault is called. Also even if preventDefault is called the page still scrolls. Bug: 1063722 Change-Id: I89170b16be4d0ee3151872e7bbaca8182db93b64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229000Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Cr-Commit-Position: refs/heads/master@{#775159}
-
David Black authored
Bug: b:157689497 Change-Id: Ibbb23b34f8fd4b335b418bdb9213f9eaf0381aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226313 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#775158}
-
Teresa Kang authored
As part of the performance improvement for read access, the `willReadFrequently` attribute is added to `CanvasRenderingContext2DSettings`. It's currently hidden behind the feature flag `NewCanvas2DAPI`. Bug: 1090180 Change-Id: I0e9f542b9b45c940d7a55f9ebf5451972492dc6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225495Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Juanmi Huertas <juanmihd@chromium.org> Commit-Queue: Teresa Kang <teresakang@google.com> Cr-Commit-Position: refs/heads/master@{#775157}
-
Jamie Madill authored
https://chromium.googlesource.com/external/github.com/GPUOpen-LibrariesAndSDKs/VulkanMemoryAllocator.git/+log/dac952eb0a27..431d6e57284a $ git log dac952eb0..431d6e572 --date=short --no-merges --format='%ad %ae %s' 2020-06-04 adam.sawicki Fix VmaAllocator_T::ImportVulkanFunctions_Dynamic for cases when Vulkan 1.1 is used 2020-05-25 adam.sawicki Remove invalid outdated assert in vmaBeginDefragmentationPass 2020-05-08 Adam.Sawicki Clarified documentation in few places to mention textures need to use LINEAR layout when accessed from the host 2020-05-03 hartmut.behrens fix(docs): instance not optional in quick start Created with: roll-dep src/third_party/vulkan_memory_allocator Bug: angleproject:4685 Change-Id: Id6ee6468b9ad60573c69b05d4f0f6b961aad976f Tbr: penghuang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231279Reviewed-by:
Jamie Madill <jmadill@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> Cr-Commit-Position: refs/heads/master@{#775156}
-
David Roger authored
Bug: 1091232 Change-Id: Idfbecb611c0bde730a375a3bf3059c19c4d115ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231221Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#775155}
-
Denis Kuznetsov authored
This CL Adds MultiStepBehavior that eases implementation of multistep screens. Bug: 1073095 Change-Id: I5d56449abdc8c25dde8c9e332a4820f2e3ec4389 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228656 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Roman Aleksandrov <raleksandrov@google.com> Reviewed-by:
Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#775154}
-
Varun Khaneja authored
Rename SetExtendedReportingPref() to SetExtendedReportingPrefForTests() since it is used only in tests. R=drubery TBR=agl Change-Id: I31a887e2a8f55e3fc34dff70aa543bb44fde6acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225472 Commit-Queue: Varun Khaneja <vakh@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Auto-Submit: Varun Khaneja <vakh@chromium.org> Cr-Commit-Position: refs/heads/master@{#775153}
-
Milica Selakovic authored
The new variation will allow showing credential leaked dialog after every form submission (helpful for testing). Bug: 1086111 Change-Id: Ifdc553e98ac923f2b762621c25ea0becc35134ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228619Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Milica Selakovic <selakovic@google.com> Cr-Commit-Position: refs/heads/master@{#775152}
-
Denis Kuznetsov authored
Bug: 1067260 Change-Id: I4d99ac3a4821a2116319e181e8a3781a5125251d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231361 Commit-Queue: Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Auto-Submit: Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
-
Adrian Taylor authored
As discussed and agreed with the V8 team (vahl@). Change-Id: Ife8785cc0ac0201ab0813a6486b3ee88de70ca0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229603Reviewed-by:
Andrew Whalley <awhalley@chromium.org> Commit-Queue: Adrian Taylor <adetaylor@chromium.org> Cr-Commit-Position: refs/heads/master@{#775150}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3d920083ed23..273da44ed986 2020-06-04 lalitm@google.com tp: add dense mode for sparse vector 2020-06-04 simonmacm@google.com Fix disappearance of all little core summaries. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:157216280 Tbr: perfetto-bugs@google.com Change-Id: I99ff1865353feea6947543f5439300c1bd84b81a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2231244Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#775149}
-
John Williams authored
This CL fixes an issue where all Cast devices show "source not supported" after selecting a local file to cast. Bug: 1078448, b/155777239 Change-Id: Ia71a0cca55c45ed9578e7d49ffccef7333b3319e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210634Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Commit-Queue: John Williams <jrw@chromium.org> Cr-Commit-Position: refs/heads/master@{#775148}
-
Juanmi Huertas authored
There was two TODOs in CanvasResourceProvider of some checks that were leftovers of the previous. Both of them involved SharedBitmap resource provider. Both of them were a check that the Create method was doing. One of the tests is about checking we have a Dispatcher. That is needed as inside the constructor of the CanvasResourceProvider of SharedBitmap it has a DCHECK that it has a valid Dispatcher. However the other check about the max texture size of the WebGraphicsContext3dProviderWrapper is not needed, thus, I'm removing that in this CL and simplifying the API. Bug: 1035589 Change-Id: Id53f45c178b0ca5d8c143d411832731742e699e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225330Reviewed-by:
Yi Xu <yiyix@chromium.org> Reviewed-by:
-
Rouslan Solomakhin authored
Before this patch, some of the Android integration tests for payment handler capabilities still used the internals of ServiceWorkerPaymentApp.java, which prevented moving the payment handler logic from Java to the C++ service_worker_payment_app. This patch replaces all of the Android integration tests for capabilities with the cross-platform Android browsertests. After this patch, payment handler capabilities tests don't depend on ServiceWorkerPaymentApp.java internals, so its logic can be moved from Java to C++. Design: https://bit.ly/cross-platform-pay-app-factory Bug: 1022512 Change-Id: I40710b81cd21669b738f80c9e8fe013ad5769dbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2223997Reviewed-by:
Sahel Sharify <sahel@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#775146}
-
chrome://discards/graphSigurdur Asgeirsson authored
This CL applies the swimlane constraints to the page bounds in X, to squish all nodes into the page bounds instead of overflowing out through both edges. Bug: 1086231 Change-Id: I78755ec8edc054d9f18f91766a5460313715b3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2230323 Commit-Queue: Sigurður Ásgeirsson <siggi@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#775145}
-
Rune Lillesveen authored
We don't support MediaValues based feature evaluation in UA stylesheet, only matching media types. There was an instance of (-webkit-min-device-pixel-ratio: 2) in mediaControls.css which would always evaluate to true in the UA sheet, but not in the context of the evaluator in the StyleEngine for dpr=1. That caused us to constantly update active stylesheets for frame resizes because we thought the media result would change. This also contributed to hide a bug on tweetdeck.twitter.com before we optimized the ruleset invalidation for media query changes. This should not be a behavior change for the mediaControls stylesheet since the removed query would always evaluate to true so that we would always use the high resolution image. Bug: 1088340 Change-Id: I23f582893b21db6f14903836d58608caa82e5577 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228848Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#775144}
-
