- 11 Sep, 2014 40 commits
-
-
dhnishi authored
BUG=372607 Review URL: https://codereview.chromium.org/543983005 Cr-Commit-Position: refs/heads/master@{#294464}
-
prasadv authored
Note that the pattern used to check commit position appears two times in reverted CL, therefore match the pattern at begining of the line BUG=413365,412054 NOTRY=true Review URL: https://codereview.chromium.org/564873003 Cr-Commit-Position: refs/heads/master@{#294463}
-
Steven Bennetts authored
This also includes a bit of JS cleanup to use ONC properties directly where possible. BUG=279351 R=pneubeck@chromium.org Review URL: https://codereview.chromium.org/552113002 Cr-Commit-Position: refs/heads/master@{#294462}
-
dalecurtis authored
This is wrong according to the HTML Media specification: http://dev.w3.org/html5/spec-preview/media-elements.html#offsets-into-the-media-resource "If the media resource somehow specifies an explicit timeline whose origin is not negative (i.e. gives each frame a specific time offset and gives the first frame a zero or positive offset), then the media timeline should be that timeline." BUG=413292 TEST=updated unittest. Review URL: https://codereview.chromium.org/562323002 Cr-Commit-Position: refs/heads/master@{#294461}
-
brettw authored
A previous patch commented these out, but this ended up not being necessary. Put them back. Review URL: https://codereview.chromium.org/565733003 Cr-Commit-Position: refs/heads/master@{#294460}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/5af3948f23b6954c5f76bac93474432805751cae..a1f6307669c32a40076d299272d220343ff74bb9 TBR=jianli@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/563883002 Cr-Commit-Position: refs/heads/master@{#294459}
-
jshin authored
On Oct 26, 2014, Russia will switch from 9 timezones to 11 timezones with most of the current zones going back by an hour from the current zone. (e.g. Europe/Moscow will be UTC+0300 instead of UTC+0400). Add new Russian time zones and shuffle the timezone order in the tz selection UI to make them roughly in the order of their tz offsets when the change gets effective on Oct 26, 2014. In the meantime, some zones will be out-of-place. This ordering can't be perfect beause of DST. To address that issue, this CL will be followed by a CL to sort them dynamically instead of using the hardcoded order. BUG=404445 TEST=Go to settings - advanced - timezone setting and look for Asia/Kamchatka. Review URL: https://codereview.chromium.org/548683002 Cr-Commit-Position: refs/heads/master@{#294458}
-
michaeln authored
Better coordinate what's responsible for associating a registration to a document. During navigation, its the ServiceWorkerControlleeRequestHandler responsibility, but the ServiceWorkerRegisterJob takes over there after. Review URL: https://codereview.chromium.org/558873003 Cr-Commit-Position: refs/heads/master@{#294457}
-
tfarina authored
Looks like nobody is using this script? Checked in Chromium, Blink and Buildbot repos. BUG=338338 TEST=None R=dpranke@chromium.org Review URL: https://codereview.chromium.org/562813003 Cr-Commit-Position: refs/heads/master@{#294456}
-
achuith authored
BUG=398467 TEST=ExtensionTest Review URL: https://codereview.chromium.org/556003005 Cr-Commit-Position: refs/heads/master@{#294455}
-
pneubeck authored
Also change from the observer pattern to the simpler callback pattern, as there is only a single notification type (TPM is enabled/disabled). This simplifies ownership of the observer/receiver especially if multiple threads (typically UI and IO) are involved: A temporary callback with a WeakPtr can be used instead of an observer object that has to be owned by someone. BUG=413219 Review URL: https://codereview.chromium.org/567553002 Cr-Commit-Position: refs/heads/master@{#294454}
-
nyquist authored
Since the introduction of nano protobufs for Java in https://codereview.chromium.org/532303003 (and updated in https://codereview.chromium.org/549543002), there is no need for the lite protocol buffers anymore. This CL removes the checked out files initially introduced when protobuf lite support for Java was added in https://chromiumcodereview.appspot.com/11347026 and cleans up the infrastructure regarding generating protocol buffers. Since lite is not supported anymore, this also removes the requirement for setting the 'proto_runtime' variable for targets using build/protoc_java.gypi. BUG=377891 TBR=zea@chromium.org Review URL: https://codereview.chromium.org/556933002 Cr-Commit-Position: refs/heads/master@{#294453}
-
tsepez authored
Review URL: https://codereview.chromium.org/551043004 Cr-Commit-Position: refs/heads/master@{#294452}
-
kmarshall authored
R=wez BUG= Review URL: https://codereview.chromium.org/563003002 Cr-Commit-Position: refs/heads/master@{#294451}
-
andresantoso authored
This was recently broken by https://codereview.chromium.org/476313003/. The problem is that when opening a new window, the fullscreen button was not enabled yet by the time we layout the profile button. We need to call layoutSubviews after the fullscreen button is enabled because the avatar button's position depends on it. But with the old avatar button, we need to call layoutSubviews first because the fullscreen button's position depends on it. BUG=412018 Review URL: https://codereview.chromium.org/567713002 Cr-Commit-Position: refs/heads/master@{#294450}
-
danakj authored
This will disable low res tilings on all platforms but android, since RenderWidgetCompositor only sets this to true on android. R=vmpstr BUG=410610 Review URL: https://codereview.chromium.org/563723004 Cr-Commit-Position: refs/heads/master@{#294449}
-
estade authored
BUG=409349 Review URL: https://codereview.chromium.org/531873002 Cr-Commit-Position: refs/heads/master@{#294448}
-
spang authored
NOTRY=true Review URL: https://codereview.chromium.org/559713004 Cr-Commit-Position: refs/heads/master@{#294447}
-
spang authored
All of the subclasses do the same thing for the polling part, so share it. Not all of them use DispatchEventToCallback, so remove that part. NOTRY=true Review URL: https://codereview.chromium.org/561243002 Cr-Commit-Position: refs/heads/master@{#294446}
-
dmazzoni authored
BUG=314889 Review URL: https://codereview.chromium.org/537893003 Cr-Commit-Position: refs/heads/master@{#294445}
-
skia-deps-roller authored
https://skia.googlesource.com/skia/+log/33a30503d76fdd989358cedd78445ba96bb809dd..790ffe3feb90370318f42b28eb9c6af6e38cd4f9 CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg TBR=fmalita@google.com Review URL: https://codereview.chromium.org/564913002 Cr-Commit-Position: refs/heads/master@{#294444}
-
fsamuel authored
This is a useful debug aid and better matches the behavior of tabs. BUG=none Review URL: https://codereview.chromium.org/564933002 Cr-Commit-Position: refs/heads/master@{#294443}
-
gcasto authored
BUG=347777 Review URL: https://codereview.chromium.org/538173002 Cr-Commit-Position: refs/heads/master@{#294442}
-
jmedley authored
BUG=none R= TEST=none NOTRY=true (documentation only change) Review URL: https://codereview.chromium.org/549043004 Cr-Commit-Position: refs/heads/master@{#294441}
-
xhwang authored
Review URL: https://codereview.chromium.org/560253002 Cr-Commit-Position: refs/heads/master@{#294440}
-
morrita authored
There are a few MessagePipeReader sublcasses defined as inter-classes of ChannelMojo. This makes it harder to hook them for unit testing. This CL moves these classes their own file. Now unittest can define subclasses of these to hook some behavor for testing. This is a preparation for a crash fix. BUG=410813 TEST=none R=viettrungluu@chromium.org,yzshen@chromium.org Review URL: https://codereview.chromium.org/559723002 Cr-Commit-Position: refs/heads/master@{#294439}
-
pneubeck authored
BUG=411927 Review URL: https://codereview.chromium.org/556243003 Cr-Commit-Position: refs/heads/master@{#294438}
-
wjmaclean authored
This is a simple move, except that we move three functions out of chrome/browser/extensions/api/web_request/web_request_api_helpers to extensions/browser/api/web_request/web_request_api_utils in order to remove the chrome/ dependency. A new namespace is introduced to avoid confusion. BUG=352293. Review URL: https://codereview.chromium.org/562913002 Cr-Commit-Position: refs/heads/master@{#294437}
-
brettw authored
When printing dependency cycles, the old meticulously walked the list backwards and explained that this was because the list was in the reverse order of the dependencies. This is wrong, the list is in the normal forward direction and doing that prints out the reverse cycle which is very confusing. Reverse the order of printing to get the correct cycle. Review URL: https://codereview.chromium.org/557103003 Cr-Commit-Position: refs/heads/master@{#294436}
-
blink-deps-roller authored
https://chromium.googlesource.com/chromium/blink/+log/f00fc1e323c6f7222c9a394187567b43e8589dc5..5af3948f23b6954c5f76bac93474432805751cae TBR=jianli@chromium.org,loislo@chromium.org Review URL: https://codereview.chromium.org/561133006 Cr-Commit-Position: refs/heads/master@{#294435}
-
lliabraa authored
As a temporary solution, use 2x assets on 3x screens. BUG=413300 Review URL: https://codereview.chromium.org/563713003 Cr-Commit-Position: refs/heads/master@{#294434}
-
oshima authored
BUG=None TBR=dpolukhin@chromium.org Review URL: https://codereview.chromium.org/561283002 Cr-Commit-Position: refs/heads/master@{#294433}
-
avi authored
This reverts commit 86823cbf. BUG=407376 TBR=rsesek@chromium.org Review URL: https://codereview.chromium.org/566593002 Cr-Commit-Position: refs/heads/master@{#294432}
-
nasko authored
Revert of Reenable DevToolsSanityTest.TestDeviceEmulation. (patchset #1 id:1 of https://codereview.chromium.org/564763002/) Reason for revert: Fails on the main waterfall on Windows and Linux: https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(2)/builds/22510 https://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20(dbg)(1)/builds/33246 Original issue's description: > Reenable DevToolsSanityTest.TestDeviceEmulation. > > BUG=397889 > TBR=pfeldman@chromium.org > > Committed: https://crrev.com/8844a8eba4465ff5f66bff5b7db195a0192625c3 > Cr-Commit-Position: refs/heads/master@{#294375} TBR=pfeldman@chromium.org,dgozman@chromium.org NOTREECHECKS=true NOTRY=true BUG=397889 Review URL: https://codereview.chromium.org/562343002 Cr-Commit-Position: refs/heads/master@{#294431}
-
mukai authored
BUG=387077, 387079 R=bauerb@chromium.org, jochen@chromium.org, markusheintz@chromium.org TBR=abarth@chromium.org TEST=build succeeds / components_unittests Review URL: https://codereview.chromium.org/541813002 Cr-Commit-Position: refs/heads/master@{#294430}
-
mohsen authored
When a window is being transformed, position of touch selection handles might not be valid anymore, hence deactivating touch selection. BUG=407659 Review URL: https://codereview.chromium.org/551883002 Cr-Commit-Position: refs/heads/master@{#294429}
-
stgao authored
NOTRY=true Review URL: https://codereview.chromium.org/551433003 Cr-Commit-Position: refs/heads/master@{#294428}
-
henriks authored
BUG=413214 R=acolwell@chromium.org Review URL: https://codereview.chromium.org/563773002 Cr-Commit-Position: refs/heads/master@{#294427}
-
cmasone authored
OS_CHROMEOS is defined in //build/config/linux:sdk per brettw recommendation. Typo fixed in ui/ozone/BUILD.gn Some source-list fixes in content/browser/BUILD.gn that take both use_x11 and use_ozone into account. BUG=None TEST=None Review URL: https://codereview.chromium.org/558343002 Cr-Commit-Position: refs/heads/master@{#294426}
-
rch authored
Fix a bug when a QUIC session is closed during the call to InitializeSession. This seems to be able to happen if too much time elapses between the call to the constructor and the call to InitializeSession. Also adds a histogram to monitor the frequency of this situation. BUG=399147 Review URL: https://codereview.chromium.org/560913002 Cr-Commit-Position: refs/heads/master@{#294425}
-