- 08 Jan, 2021 40 commits
-
-
Weiliang Chen authored
In order to use the WebVitalMetrics class with shared memory in the follow up CLs, make the WebVitalMetrics class trivially copyable. R=sadrul Bug: 1151343 Change-Id: Ib613198bfc0b54667b4048ab9e2eefe16b4fbdf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2602383Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
weiliangc <weiliangc@chromium.org> Commit-Queue: weiliangc <weiliangc@chromium.org> Cr-Commit-Position: refs/heads/master@{#841635}
-
Claude van der Merwe authored
Logs all of the reasons why the networks are ineligible for syncing if zero networks have been synced. If there are no wifi networks kNoWifiNetworks is logged as the reason. If there are eligible networks but zero networks have been synced kNetworkIsEligible is logged as the reason. Bug: 1154341 Change-Id: I5a1553396dc7b295abd466cf02c13fc5d2c9fb00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597538 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Jon Mann <jonmann@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#841634}
-
chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/299d4780ec86..d28e6c52e05e 2021-01-08 fabiansommer@chromium.org Fix llvm build on toolchain/linux-pnacl-x86_64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/nacl-autoroll Please CC mseaborn@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: mseaborn@chromium.org Change-Id: I85da3666767bbb0bfc65ca44f0dc795016f52680 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616826Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#841633}
-
Kaiyu Chen authored
The feature flag controls the GPay native app integration for dynamic update with web payments on Android. The integration for dynamic update is mainly about adding callback service to notify the browser about changes like shipping address. Design doc is go/dynamic-update-mweb. Bug: 1074423 Change-Id: I608ca5ddd5aa28f2da5672da83eefd0128720992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617201 Commit-Queue: Kaiyu Chen <kylechenkyc@google.com> Reviewed-by:
Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#841632}
-
chinsenj authored
This test was disabled by crrev.com/2616228 since the test was flaky. This is because the RootWindowDeskSwitchAnimator fails to take a screenshot due to the remove animation starting after the test ends. This CL re-enables the test and fixes it by using the RemoveDesk() fcn from desks_test_util.h instead of DesksController::RemoveDesk(). This makes the test wait for the desk remobal animation. Test: manual Bug: 1164381 Change-Id: I0970e333f3593c8265acbe276e85b6ab91d2ade2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615353Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@chromium.org> Cr-Commit-Position: refs/heads/master@{#841631}
-
Jonah Ryan-Davis authored
The passthrough decoder has been default on Linux since Aug 25, 2020. We don't need to test the validating decoder on the CQ. Bug: chromium:976283 Change-Id: I0f21d1dfb996708705aacb281fa03465fe56dbbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615460 Commit-Queue: Jonah Ryan-Davis <jonahr@google.com> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#841630}
-
Haiyang Pan authored
* chrome_public_test_apk at 50% * chrome_public_smoke_test at 100% * weblayer_unittests at 100% * webview_ui_test_app_test_apk at 100% Since now there are about 800 (http://shortn/_JqmfiRDZkq) test devices in the pool which is even more than the amount before the outage (690, http://shortn/_ABaTS4EnNU), we can add the test suites more aggressively. Also re-organize the compound test suite for android-pie-arm64-rel to make it easier to re-enable test suites. Bug: 1111436 Change-Id: I456046376d76c1632a74fdfc68862b234c741132 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611650Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Haiyang Pan <hypan@google.com> Cr-Commit-Position: refs/heads/master@{#841629}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610107094-a1b03a814715c7959032a16f0512a58b7ebd318d.profdata to chrome-linux-master-1610128749-0f05f817c8023f7311c3f1f138caa77d30d9071d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I66006d98e0d48035bf2f81df500117425799da6e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616824Reviewed-by:
-
Clark DuVall authored
This allows supersize to analyze split APKs. These show up as child containers to the base APK since they are named with "<base name>/<split name>". Example report: https://chrome-supersize.firebaseapp.com/viewer.html?load_url=https%3A%2F%2Fstorage.googleapis.com%2Fchrome-supersize%2Foneoffs%2Fcduvall7.size&group_by=container&type=mx Example diff: https://chrome-supersize.firebaseapp.com/viewer.html?load_url=https%3A%2F%2Fstorage.googleapis.com%2Fchrome-supersize%2Foneoffs%2Fcduvall4.sizediff&group_by=container&type=mx&diff_mode=on Bug: 1143690 Change-Id: I6ed7d516607e56431cf4c3fb67989d6783520a78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614123 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#841627}
-
Jonathan Freed authored
Even though the last two commits did not require changes to be merged, I'm updating the bookmark so future deps rollers don't need to look at them. Change-Id: I90ce34ecdef960ca510a8f3150b57234aaf29788 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618396 Commit-Queue: Jonathan Freed <freedjm@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Auto-Submit: Jonathan Freed <freedjm@chromium.org> Reviewed-by:
Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#841626}
-
Liquan (Max) Gu authored
PaymentUiService used to depend on ChromeActivity. This is undesirable because the Clank modularization efforts requires that "ChromeActivity should fully build/initialize the app without feature code having to reference ChromeActivity for dependencies". This CL breaks this dependency. This also unblocks CL https://crrev.com/c/2602382 because PaymentRequestParamsBuilder no longer has to depend on ChromeActivity after this change. Bug: 1155788 Change-Id: Ib539f37ca5056565d3c385b56f0ada0f1a430533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615480Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Nick Burris <nburris@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841625}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/937395c1ed5d..2e89a70e3561 2021-01-08 capn@google.com Fix missing fields initializers warnings If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I9084df729452fdab5b0bfc35bdfc57c64f4aa23a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618160Reviewed-by:
-
David Bienvenu authored
This fixes TestTabStatsTracker failures running unit_tests.exe, because PowerMonitor dchecks if the same observer is added multiple times. Bug: 956719 Change-Id: Ic01197209d65a7d272f7e943ccc403a1c49107fa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618221Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841623}
-
Adam Rice authored
Blocking port 554 has known compatibility issues. Unblock it. BUG=1148309,1164418 Change-Id: I51de0e944cdd57cad5f2d5fec145dad7320dfc51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618418 Auto-Submit: Adam Rice <ricea@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#841622}
-
Lucas Berthou authored
Change expiration date of histograms: Media.GpuMemoryBufferVideoFramePool.UnsupportedFormat Change-Id: I0d0a4129f68e16ff8d2420e3b788696b1ea0128f Bug: 1053014 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611247Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Lucas Berthou <berlu@chromium.org> Cr-Commit-Position: refs/heads/master@{#841621}
-
Dale Curtis authored
R=wjmaclean Bug: 1164459 Change-Id: Ic21cb372e8e8886075cbab00023dfe994a251d68 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618525 Auto-Submit: Dale Curtis <dalecurtis@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#841620}
-
Adithya Srinivasan authored
Missed fixing these callsites in https://crrev.com/c/2386012. Bug: 1126901 Change-Id: If94b71e0767bb222df3840185e7e00e515592fd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616459Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#841619}
-
Katie Dillon authored
This features removal has been pushed back to M93. This CL extends the flag to correspond to the new removal timeline. Bug: 1003101 Change-Id: Iebe77bc047034f4f6f6ae1c4538a2f85236c33f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613562Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Katie Dillon <kdillon@chromium.org> Cr-Commit-Position: refs/heads/master@{#841618}
-
Brandon Jones authored
Previously dataOffset and size were always in bytes, which isn't consistent with the WebGPU spec. Corresponding CTS test here: https://github.com/gpuweb/cts/pull/431 Bug: 1163667 Change-Id: I5360cfbd66542c044dcf909b8673d3ed3f5e6724 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615520Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#841617}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d8ca7d624751..fa449cf3b0d0 2021-01-08 jmadill@chromium.org Fix separable Geometry Shaders. 2021-01-08 jmadill@chromium.org Merge Program/ProgramPipeline::getMergedVaryings(). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com Change-Id: Iec8d1c8a2172b107ba5cea105456f12cdb089170 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618199Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/24cfa1c1796a..a24bf6b63c40 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC dalecurtis@google.com,wjmaclean@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1151860 Tbr: dalecurtis@google.com,wjmaclean@google.com Change-Id: Ica0d4d702cedb9f9cfcb4d3500df7dbbf67b5c07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618245Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
-
Philipp Hancke authored
BUG=chromium:1164376 Change-Id: Ic9321b007e652f8d6b0ca40e490645735296317b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616411Reviewed-by:
Harald Alvestrand <hta@chromium.org> Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Cr-Commit-Position: refs/heads/master@{#841614}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/60b433cf0b29..0e4e5ae5944a 2021-01-08 ehmaldonado@google.com Reland "[owners] Refactor OwnersClient." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I344a3ae5bedbc7be7a7d7de6aee33317b336c6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617282Reviewed-by:
-
Sunggook Chue authored
OsIntegrationManager is a proxy class that doesn't have to know its detailed OS calls instead it delegates a work to the target class if it exists. AppShortcutManager handles shortcut creation (see CreateShortcuts in OsIntegrationManager) that includes proper telemetry message at the end of it. However the current DeleteShortcuts is simply handled by the OsItengrationManager instead of AppShortcutManager. The change is to follow pattern of CreateShortcuts for the shortcut deletion that seems more consistent in terms of OsItegrationManager and AppShortcutManager relationship. Bug: 1151796 Change-Id: I01e80b0a13ef1169a238d65a2ffc5acb6cca292f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606680Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#841612}
-
Nancy Wang authored
Add the class FullRestoreDataHandler to observe AppRegistryCache. When the app is removed, remove the full restore data from both FullRestoreReadHandler and FullRestoreSaveHandler. BUG=1146900 Change-Id: Ie55b6310e3e302ac4829b7c76c10880928266651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2608045 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#841611}
-
Claude van der Merwe authored
This CL: 1. Does not initialize the network cache until the user's networks have been loaded. 2. Queues calls to GetAllSyncableNetworks until the network cache has been loaded Bug: 1154341 Change-Id: I158cb29109c9f8de52ff09f1c82866931e371459 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2600119 Commit-Queue: Claude van der Merwe <cvandermerwe@google.com> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
-
Allen Bauer authored
Bug: 938501 Change-Id: Idcc0c7970542266d5b4b53b938238309f063e27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618487 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Wei Li <weili@chromium.org> Auto-Submit: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#841609}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/3ce4e8ee1301..11e6cfe60a92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ic81f2494a44e073389df2d30df907565429b0d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618162Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/a2e02836a260..c4efeef83334 2021-01-08 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 766e31d50710 to 1e01c2c11613 (3 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC enga@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: enga@google.com Change-Id: I302a5d2316ea7e0f5225be6dea072905436266a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618500Reviewed-by:
-
Bo Liu authored
ScreenOrientationProvider(Impl) is currently coded to assume the embedding Activity handles (and thus is not destroyed and recreated) on orientation change. All the API methods take WindowAndroid. This does not work for embedder that recreates the Activity (and by extension the WindowAndroid) on orientation change. This causes orientation requests made in this transition time to be completely dropped. Fix this for cases for requests made from WebContents from native code. If there is no WindowAndroid, add an observer to to wait until WebContents gets a WindowAndroid to make the request. Bug: 1159529 Change-Id: Iae177faffa67d3e4db58ea1e0d5a9df989d303a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2603856 Commit-Queue: Bo <boliu@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#841606}
-
Ana Salazar authored
Set the multipaste clipboard menu option as a new feature, depending on whether or not the feature flag should show. Bug: 1156270 Change-Id: I1b8c30bbb506c360a0206a31bbebea0286123d1e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618491Reviewed-by:
-
Will Cassella authored
This CL enables DAV1D on Android, which allows decoding of AV1 videos via Dav1dVideoDecoder, as well as decoding AVIF images via AVIFImageDecoder. Binary-Size: Decoders are large. Change-Id: I63bfb0b31a38f4ccde4e7aafe8f16bca7d8b926f Bug: 2558924 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2605293Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
-
Liquan (Max) Gu authored
Since the isShowWaitingForUpdatedDetails parameter is unused in buildPaymentRequestUI(), this CL is to delete it. Change-Id: Ia98e24fab92e71505358abaa80ded9ff20047520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615321Reviewed-by:
-
Gordon Seto authored
Fix flaky OSSettingsCellularNetworksListV3Test failures caused by DOM not rendering completely before testing started. This is fixed by triggering the DOM to flush again before executing the rest of the test. This fix is confirmed by running the test with [100/100] passes. Fixed: 1164157 Change-Id: Ic014252a5ed749bc6641e6a6ab2f21383f09b165 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618480Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gordon Seto <gordonseto@google.com> Cr-Commit-Position: refs/heads/master@{#841602}
-
Kyle Horimoto authored
This will provide granular results for potential failure reasons for Nearby Share and Phone Hub. Note that location::nearby::chrome::BluetoothClassicMedium is the only client of this function, so we can be confident that results of this metric are due to Nearby Connections. Fixed: 1163605 Bug: 1106937 Change-Id: Ib1091eb6f41f09daca038a5d07071bd81feae561 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613737 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#841601}
-
Nancy Wang authored
This CL implements the notification based on the full restore ui review deck: https://docs.google.com/presentation/d/1kg1HAyjHc3l9EnaBehCQS3K_O7BmLpE6x_JWAAGUOMc/edit#slide=id.g838f61fb61_2_38 For “ask every time” users, if they show consistent behavior, Chrome OS can suggest them to change defaults: If users choose “Restore” 3x in a row, show the set restore pref notification to suggest that they can set restore to default. Add the pref "restore_selected_count" to record how many times the user has selected the restore option. If the count is equal or more than 3 times, show the set restore pref notification. BUG=1146900 Change-Id: I98a3fd05116b4f722d48a76a5aef45d3cf299c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606404 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/vulkan-deps.git/+log/e395b66ed41c..a86dded0f15e 2021-01-08 chromium-autoroll@skia-public.iam.gserviceaccount.com Roll SPIRV-Cross from ce18d1b8a563 to 702c903f982d (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/vulkan-deps-chromium-autoroll Please CC ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ianelliott@google.com,enga@google.com,radial-bots+chrome-roll@google.com Change-Id: Ifde5b67bf812b4400c5560ef3b170cb91c346d36 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616823Reviewed-by:
-
Siye Liu authored
This partially reverts commit d46bdb4f. Reason for revert: the change causes a regression where inserting text at end of current block and next block is an inline block, then the new selection will be end up at the beginning of next block. Per suggestion in crbug.com/1161370#c15, we only need to partially revert the change( change made in VisiblePositionTemplate::Create. Original change's description: > [Editing] Fix canonical caret position at line break > > Consider this testcase: > <style>div { width: min-content; padding: 5px; }</style> > <div contenteditable>line1<wbr>line2</div> > which is rendered as > line1 > line2 > > Before this patch, when clicking at the beginning of the 2nd line, the > caret would appear at the end of the 1st one, because CanonicalPosition > would search backwards even with a downstream affinity. > > Also, when clicking at the beginning of the 1st line and pressing the > down arrow key, the caret would move to the end of the 1st line instead > of to the beginning of the 2nd one. And pressing the key again would > have no effect, the caret would refuse to go down. > > This patch fixes these problems by making CanonicalPosition take a > TextAffinity parameter which affects whether the canonical position is > first searched backwards or forwards. If no suitable candidate is found, > it will still search in the other direction. > > And then, VisiblePosition::Create takes care of deciding between the > upstream and the downstream canonical positions, depending on the > affinity and whether there is a line break. > > Bug: 1002937 > > Web tests: > TEST=external/wpt/editing/run/caret-navigation-around-line-break.html > > Unit tests: > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/0 > TEST=All/ParameterizedVisibleUnitsLineTest.inSameLine/1 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/0 > TEST=All/ParameterizedVisibleUnitsWordTest.StartOfWordShadowDOM/1 > TEST=VisiblePositionTest.ShadowV0DistributedNodes > TEST=VisibleUnitsLineTest.endOfLine > TEST=VisibleUnitsLineTest.isEndOfLine > TEST=VisibleUnitsLineTest.isLogicalEndOfLine > TEST=VisibleUnitsLineTest.isStartOfLine > TEST=VisibleUnitsLineTest.logicalEndOfLine > TEST=VisibleUnitsLineTest.logicalStartOfLine > TEST=VisibleUnitsLineTest.startOfLine > TEST=VisibleUnitsTest.canonicalPositionOfWithHTMLHtmlElement > TEST=VisibleUnitsTest.canonicalPositionOfWithInputElement > TEST=VisibleUnitsTest.canonicalizationWithCollapsedSpaceAndIsolatedCombiningCharacter > > Change-Id: I82d86d40a87513b2e92c024735957e9f71154094 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2410404 > Commit-Queue: Oriol Brufau <obrufau@igalia.com> > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#813744} Bug: 1002937 Bug: 1161370 Change-Id: I65dbc8b442ae308f42582095e4693d9f146b8b32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616734Reviewed-by:
Siye Liu <siliu@microsoft.com> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Commit-Queue: Siye Liu <siliu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#841598}
-
Brandon Wylie authored
TBR=peconn@chromium.org Bug: 1164424 Change-Id: If98fe7d9ef0f688816c26eec3abf32786d130a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618486 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
bttk <bttk@chromium.org> Cr-Commit-Position: refs/heads/master@{#841597}
-
Clark DuVall authored
We are planning on running binary experiments for isolated splits enabled/disabled on M89. I want to make sure there are no problems with the disabled version before branch cut. I'll revert this CL after a couple days. Bug: 1150162 Change-Id: I20061a079e897058625506dab810c4584c200fec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618367 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
