- 14 Feb, 2020 40 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/3b3069e9b4a3..657c0f420df0 git log 3b3069e9b4a3..657c0f420df0 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 dproy@chromium.org [trace viewer] Fix test runner under polyfill 2020-02-14 dproy@chromium.org [results.html] Add webcomponents v0 polyfill to results.html Created with: gclient setdep -r src/third_party/catapult@657c0f420df0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1036492 Tbr: skyostil@google.com Change-Id: I368059cd4833730cce08dba62575e9a8143e2b3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057734Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741655}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/330671f6..ab921263 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I9c0fc460cd0abdf2ddad4ea8457bd4367d16034a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056647Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741654}
-
Nate Fischer authored
No change to logic. I'm adding myself to OWNERS for more javatest files, to help with code reviews & flakiness triage. Test: N/A Change-Id: I0c9cafaff87976b819149fe030cd1c570d2452ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057762 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#741653}
-
Christopher Thompson authored
This re-enables a SecurityStateTabHelper browser test that improperly used ScopedFeatureList by changing it to use a class that initializes the feature list during construction, and removing the (somewhat superfluous) re-initialization in the middle of the test. Bug: 1012507 Change-Id: Ia17e58abc265b7b94ea8c92fafe0868cf31e2312 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057805Reviewed-by:
Carlos IL <carlosil@chromium.org> Commit-Queue: Christopher Thompson <cthomp@chromium.org> Cr-Commit-Position: refs/heads/master@{#741652}
-
John Budorick authored
Bug: 1052159 Change-Id: I8f5ddd424546b926448254369ab787c06d6f33f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055885Reviewed-by:
David Trainor <dtrainor@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#741651}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3a36511f21d1..b444ec4d1fa9 git log 3a36511f21d1..b444ec4d1fa9 --date=short --first-parent --format='%ad %ae %s' 2020-02-14 herb@google.com Remove unneeded test, and support code 2020-02-14 robertphillips@google.com Improve DDLPromiseImageHelper 2020-02-14 jvanverth@google.com Manage renderCmdEncoder over lifetime of GrMtlOpsRenderPass. 2020-02-14 bsalomon@google.com Fix typo in GrTextureEffect::onIsEqual 2020-02-14 robertphillips@google.com Improve DDLTileHelper 2020-02-14 reed@google.com Fix impl for OverdrawColorFilter to not rely on details of pmcolor, 2020-02-14 bsalomon@google.com Remove GrTextureEffect::MakeTexelSubset. Created with: gclient setdep -r src/third_party/skia@b444ec4d1fa9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC stani@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: stani@google.com Change-Id: Id6377b5c29c98350dbbc481ade7950c7e1c19957 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057160Reviewed-by:
-
Javier Ernesto Flores Robles authored
Organize common UI utils to be consistent with ios/c/b/ui. Bug: 1052505 Change-Id: Iab882655a3eccf66d74b4f97905953e5ad8f1776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057803 Commit-Queue: Javier Ernesto Flores Robles <javierrobles@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#741649}
-
Ken Rockot authored
Adds a StorageServiceOutOfProcess feature, disabled by default. When enabled, the Storage Service (currently providing only DOM Storage implementation) will run outside of the browser process. This CL does not establish sandboxing, nor does it address restartability concerns. Bug: 1000959 Change-Id: I172db10c2645d2587a2e5b8f25ebeeb3abc975ab Test: manually tested browser, and browser tests pass with feature enabled Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053032 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#741648}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/7ed8a344d043..3aa23228350c git log 7ed8a344d043..3aa23228350c --date=short --first-parent --format='%ad %ae %s' 2020-02-14 mfoltz@chromium.org [Open Screen] Remove use of atomics in module code. Created with: gclient setdep -r src/third_party/openscreen/src@3aa23228350c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: I0dc5b10c1a144b7dee3510828ab2499c08a217ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057729Reviewed-by:
-
Pavol Marko authored
Make sure that the credentials returned from the login delegate are stored in the StoragePartition that the WebContents that requested it is actually using. This also adds a browsertest that verifies this for the Chrome OS gaia sign-in webview, which uses a different StoragePartition from the default one. Bug: 1049349, 1051053 Test: browser_tests --gtest_filter=SamlTest.IdpRequestHttpAuth Change-Id: Ie0a60eef561fe736ffa84ea2edd2b1c649815908 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056083 Commit-Queue: Pavol Marko <pmarko@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#741646}
-
Tao Bai authored
Notify MetricsService of WebView apps' foreground and background state Bug: 1042048 Change-Id: I320d9baea677d30c464f9eaf987ab8c0f082f714 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053126 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741645}
-
Jarryd authored
Add const qualifier to parameters where appropriate and use modern cast syntax. Change-Id: I2f932988244416501c4435eb26413f976a6fd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057100Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#741644}
-
Akihiro Ota authored
This option is being added so that users can intuitively turn on braille commands in the ChromeVox menus. Without this patch, users must turn on braille captions in order to see braille commands in the menus; we have gotten feedback that this is somewhat confusing, as the connection between braille captions and braille commands isn't always clear. Functionality has also been added to enable/disable this setting when a braille display is connected/disconnected, respectively. Bug: 1049363 Change-Id: If9f846bb14a5944300d8afcab0900657762085dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2039979 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#741643}
-
Kurt Horimoto authored
After crrev.com/c/1787562, OverlayPresenter will only present upon the presentation context when its presentation capabilities are sufficient to support the current request. Before that CL, OverlayPresenterImpl simply used the presence of a non-null presentation context as a signal for when presentation was possible, and would call ShowOverlayUI() on that context even if it was not yet provided with a coordinator capable of showing that request's UI. OverlayPresentationContextImpl simulated the presentation flow for requests sent by OverlayPresenter when the backing coordinator was null. After crrev.com/c/1787562, these condition blocks can be replaced with DCHECKs since the overlay UI presentating/cancelling/hiding functionality will not be called for unsupported requests. Bug: none Change-Id: Ia3bed1ffbf771f1b0deb0d17a81662111fec79c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056206 Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Cr-Commit-Position: refs/heads/master@{#741642}
-
Sky Malice authored
Bug: 1050094 Change-Id: I247ac07b80be87a94623d2bcf4b6dea7f8accb23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055356 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#741641}
-
Ken Rockot authored
This wires up the Storage Service implementation in-process as a private detail of content::StoragePartitionImpl. All DOM Storage implementation is moved behind Storage Service public Mojo interfaces, and DOM Storage support in the browser no longer depends directly on any private details of the Storage Service. No functional changes are intended here, as the in-process service instance still runs on the IO thread, where DOM Storage implementation has also run for some time. Bug: 1000959 Change-Id: I6fddd8605e3ba426576d9d9348964c5083dd4b4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2052609Reviewed-by:
Daniel Murphy <dmurph@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#741640}
-
Alan Cutter authored
This CL fixes the instantiates the warning thrown by browser_tests: [test_launcher.cc(1498)] The following parameterized test case is not instantiated: UninstantiatedParamaterizedTestSuite<SecureOriginWhitelistBrowsertestWithMarkHttpDangerous> by instantiating the SecureOriginWhitelistBrowsertestWithMarkHttpDangerous browser tests Change-Id: Ie7030c1f8d8dd53f35b2e2aa6b0d94e59a218e02 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053873 Auto-Submit: Alan Cutter <alancutter@chromium.org> Commit-Queue: David Trainor <dtrainor@chromium.org> Reviewed-by:
-
Xing Liu authored
This CL removes all dead code in DownloadManagerService. Bug: 922929 Change-Id: I2990a1dd126a683fb12cc78c59b051ed42d373d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057472Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741638}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c663845357d0..149341bb048d Created with: gclient setdep -r src-internal@149341bb048d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I553a721a869ff1e15abb57577d9369a55632685e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057725Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#741637}
-
Xianzhu Wang authored
Previously when we copy subsequences, we did everything to construct the paint chunks freshly. Now avoid most of the operations by copying data from the cached paint chunks. This also avoids callbacks into the DisplayItemClient in the cached paint chunks, to avoid security issue on under-invalidation of subsequences. Bug: 1050090 Change-Id: Ie6b7c0b1f24c63100d73b988f303faf09b75ae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055596Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#741636}
-
Stephen Chenney authored
Image orientation was not correctly applied in base_rendering_context_2d, resulting in always oriented images sometimes drawn with the wrong source rect. This change fixes that. The image-orientation setting we respect always comes from the canvas into which the image is being drawn. This keeps the rules for which orientation to apply simple. As part of this change, orientation is added to StaticBitmapImage and used in the necessary cases to track the orientation of the source image. As part of this change, the code to correct an image source rect is moved to Image and callers updated. Bug: 1043790 Change-Id: I13d74b66cff912382f8f5efe0050eae6a0f283c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044050Reviewed-by:
Fredrik Söderquist <fs@opera.com> Reviewed-by:
Xida Chen <xidachen@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Auto-Submit: Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#741635}
-
Rainhard Findling authored
* Tests that the safety check is present in basic settings and in the settings menu if the privacy settings redesign flag is on, and absent if the flag is off. * This test has been moved from https://chromium-review.googlesource.com/c/chromium/src/+/1959036 to this CL to not prevent the first from landing. Bug: 1015841 Change-Id: Idea2368bdeeff5722eb0e0c9f82b5c09a9ad062c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044077 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#741634}
-
Dave Tapuska authored
The RenderFrameHostImpl implements this interface and will process calls when it is in fact the main frame. WebViewImpl attaches to this interface when the local main frame is attached. BUG=1046424 Change-Id: I41db5ba44cb50832dc1523e55ec7aed90d606cee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044764 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#741633}
-
Jason Chase authored
In [1], we implemented a workaround to re-enable WebComponents V0 in headless, regardless if any valid origin trial tokens are present. That workaround has been merged to M80. In [2], we implemented a fix so that origin trials are properly supported in headless (that is intended for merge to M81). This CL removes the workaround, as it is no longer needed. It also implements a basic test to verify that trials are working in headless, and specifically the WebComponents V0 trial. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2039601 [2] https://chromium-review.googlesource.com/c/chromium/src/+/2042382 Bug: 1049126 Change-Id: Ie118f2d53a535ff8cb8f9f1644b866298e57f036 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2042689Reviewed-by:
Jason Chase <chasej@chromium.org> Reviewed-by:
Johannes Henkel <johannes@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Jason Chase <chasej@chromium.org> Cr-Commit-Position: refs/heads/master@{#741632}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/f9f999f5a2eb..348f07b40c2b git log f9f999f5a2eb..348f07b40c2b --date=short --first-parent --format='%ad %ae %s' 2020-02-14 amaiorano@google.com Fix unit test when ENABLE_RR_EMIT_PRINT_LOCATION is defined Created with: gclient setdep -r src/third_party/swiftshader@348f07b40c2b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: Ifde9770700d6746b7435ae6fbe736c6af96d5d26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057162Reviewed-by:
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I65c266c6c16e5d6123609a476f54252c8c9c2e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056525 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#741630}
-
Anastasia Helfinstein authored
Currently, calls to NavigationManager need to check if it has been initialized. Instead, avoid initializing any of Switch Access until the desktop node has been returned. TBR=dtseng@chromium.org Bug: None Change-Id: I579c2e6622bef831e55d38792c1e79c320a362dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2049827Reviewed-by:
Anastasia Helfinstein <anastasi@google.com> Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Cr-Commit-Position: refs/heads/master@{#741629}
-
Tricia Crichton authored
Reland: After a test times out during a ChromeDriver command, trigger a Chrome crash and a minidump collection for troubleshooting. This is not available on tests connecting to a remote browser, or when running on Android. Added exception handing for the Page.crash request and a fix to detect when session_id has not yet been set. Bug: 1045241 Change-Id: I34c088d669d272bb3517d47826ef97d8c10a1ab8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055549Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Tricia Crichton <triciac@chromium.org> Cr-Commit-Position: refs/heads/master@{#741628}
-
Robbie Gibson authored
This reverts commit fabf13a1. Reason for revert: Talked to ender@, and this is the wrong flag to use on iOS. We should use omnibox-on-focus-suggestions instead. Original change's description: > [iOS] Add flag for zero-suggest on NTP > > This extends the definition of kZeroSuggestionsOnNTP from > Desktop/Android to iOS. > > Bug: 1048193 > Change-Id: I593c8dfd287a20b7afb9b4041ce6c33abbb99c22 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036030 > Commit-Queue: Robbie Gibson <rkgibson@google.com> > Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#738183} TBR=stkhapugin@chromium.org,rkgibson@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1048193 Change-Id: I42b97ef1c5279a923a12d0fcff3c3bb81524ba17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057635Reviewed-by:
Robbie Gibson <rkgibson@google.com> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#741627}
-
Meilin Wang authored
This is a reland of 75161d96 Original change's description: > assistant: Fix mic button doesn't work with fake gaia account. > > |Service| stores the current account info and later registered as a > session activation observer for this account, so that it can enable > listening when the session becomes active. Previously when the login > account was a fake gaia account, e.g. in Tast tests, we did not update > the stored account info with the latest primary account when requesting > access token. In this way, |Service| couldn't receive any session active > signals because it was not observing a valid account. > > Bug: b/147442943 > Test: run the service in signed-out mode and manually verified. > > Change-Id: Iaaef86303686291b419754505ead9b14cca0adbc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2033642 > Commit-Queue: Meilin Wang <meilinw@chromium.org> > Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org> > Reviewed-by: Tao Wu <wutao@chromium.org> > Cr-Commit-Position: refs/heads/master@{#740818} Bug: b/147442943 Change-Id: Iad700a8dc8a2747619dd2fbe81a32e5cea6d5d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053284Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Meilin Wang <meilinw@chromium.org> Cr-Commit-Position: refs/heads/master@{#741626}
-
Anastasia Helfinstein authored
This change is a pure refactor. TBR=akihiroota@chromium.org Bug: None Change-Id: Ibaea6dd273eadb4c49cd590be8744b1003502370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057156Reviewed-by:
-
Sangwoo Ko authored
This allows consumers to choose which alert state to use. Bug: 1004983 Change-Id: Icac5c3f658710acfcf1589e845451075f381f91c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2056005 Commit-Queue: Peter Boström <pbos@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#741624}
-
Aaron Leventhal authored
Bug: None Change-Id: Icaaa7fdc44ad65d0569e2cb412b3671ef70756ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2047405Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#741623}
-
Tricia Crichton authored
For nontypeable input elements - where primary input is by means other than direct text input - ChromeDriver will set the value attribute directly rather than simulating keyboard events. Initially this applies to color input types, but others can be added easily. Bug: chromedriver:3352 Change-Id: I873e00d3616e1dfb3892595f15926453ced96ea7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1986912Reviewed-by:
-
Moe Ahmadi authored
The GWS experiment stats are expected in the following format in suggest response: "google:experimentstats":[ { "2":"0:67", "4":10001 }, { "2":"46:67", "4":10001 }, ] and are to be encoded into the AQS match URL param in the following format expected by the Searchbox logging flow: aqs=[CLIENT_NAME].[ASSISTED_QUERY_INFO].[AVAILABLE_SUGGESTIONS].[EXPERIMENT_STATS].[EXPERIMENT_STATS_V2] For instance: aqs=chrome.3.35i39l6j69i59l2.198455216j1j15.10001:0,67j10001:46,67 Bug: 1044255 Change-Id: Ief567ffe1c1f513d30442d91f6c9c24748a89b7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2036556Reviewed-by:Marc Treib <treib@chromium.org> Reviewed-by:
-
Chris Blume authored
Some platforms would prefer to raster in sRGB unless there is reason not to, such as content using a wide color gamut.t cl for This CL adds a setting to indicate the preference of using sRGB and short-circuits GetRasterColorSpace() to return sRGB instead. Bug: 955158 Change-Id: I5762851ffc7cf93a50e6d46eefebf8a652ee3e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2045053 Commit-Queue: Chris Blume <cblume@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#741620}
-
Maks Orlovich authored
This further centralizes the first-partiness check, and increases type safety by having the notion of 1st party be more consistently kept inside net::SiteForCookies (this helped find 2 bugs!) Bug: 577565 Change-Id: Ie11f8a0fc5a762318c3a0c0b818b488c4775374b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992264 Commit-Queue: Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#741619}
-
Connor Clark authored
Bug: 10521119 Change-Id: Ib103c7a9e639a1f9f7eae00924b1d20872e06b3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055398 Commit-Queue: Connor Clark <cjamcl@chromium.org> Reviewed-by:
Tim van der Lippe <tvanderlippe@chromium.org> Cr-Commit-Position: refs/heads/master@{#741618}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/0bf716dac129..591a14bda6ae git log 0bf716dac129..591a14bda6ae --date=short --first-parent --format='%ad %ae %s' 2020-02-14 John.Emau@microsoft.com SoftDropdown: Remove workaround for DCHECK failure Created with: gclient setdep -r src/third_party/devtools-frontend/src@591a14bda6ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I436b846ae6df8dd2f1be6a5791dfa9c4f0e53b60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057161Reviewed-by:
-
Eugene But authored
Breakscrumbs (feature which attaches steps to reproduce to crashlogs) relies on not_user_triggered="true" to filter out non-interesting events. Notable changes: - Add MobileNTPShowMostVisited metric to actions.xml (this is not a new metric, it's already logged on iOS, but was not part of xml) - Add not_user_triggered="true" to MobileNewTabOpened, MobileTabGridEntered, MobileTabGridExited, MobileTabSwitched, NewTabPage_ContentSuggestions_ArticlesUsage as all these metrics are triggered from the code without user involvement. Bug: 1046231 Change-Id: I12d97758f304426da7af1784f1f0126014baa600 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2057159 Auto-Submit: Eugene But <eugenebut@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#741616}
-
