GitLab

This CL is part of a serie of CLs to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: Ifa92b8d5b357addd135d9fdc641696e92ed53f2d
Reviewed-on: https://chromium-review.googlesource.com/1102581Reviewed-by: Nasko Oskov <nasko@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567677}

When I moved the test suites from chromium.webkit to the debug
builders on chromium.linux and chromium.mac in r576522, I
accidentally dropped the --debug flag; this causes the builds
to fail completely when it looks in the //out/Release directory
for the binaries.

BUG=853209
TBR=robliao@chromium.org
NOTRY=true

Change-Id: Ia36854052c07c3b94a1b42b128e769ed08fc160e
Reviewed-on: https://chromium-review.googlesource.com/1102657Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567676}

In https://chromium-review.googlesource.com/1096489, I added a fix for an issue
where a tab could get stuck in a partially-discarded state if you started
dragging it and then tapped the incognito button while you still had your finger
down. Unfortunately, my original fix for the issue, which was to start an
undiscard animation in NonOverlappingStack#runSwitchAwayAnimation(), is a bad
idea, since that animation animates the StackTabs' scroll offsets, conflicting
with the incognito animation, causing animation jankiness.

This CL replaces the call to start the discard animation with a loop that just
sets each tab's scroll offset to 0.

Bug: 853034,852995,831359
Change-Id: I4b6e34bf68afb9ce025e3272c0c0816f84f8b48e
Reviewed-on: https://chromium-review.googlesource.com/1102115Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ryan Landay <rlanday@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567675}

ProxyResolvingClientSocketFactory takes care of creating a new
HttpNetworkSession that is based on a given net::URLRequestContext.

This CL switches GCM's ConnectionFactoryImpl to using
ProxyResolvingClientSocketFactory, so there is less code duplication. This
will makes it easier to standardize usage of ProxyResolvingClientSocket to
prepare for servicifying it.

Bug: 844187
Cq-Include-Trybots: luci.chromium.try:linux_mojo
Change-Id: I06b1f6b7c6fc7e8c458b24f2ee3dcc5664bd4c21
Reviewed-on: https://chromium-review.googlesource.com/1101058
Commit-Queue: Helen Li <xunjieli@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567674}

Change-Id: Id4ab9fafa2546b42a0094466c3f4cbefa6a65a56
Reviewed-on: https://chromium-review.googlesource.com/1102483Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567673}

https://chromium.googlesource.com/angle/angle.git/+log/06a2262078b2..0661eb899f46


git log 06a2262078b2..0661eb899f46 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 jiawei.shao@intel.com Fix compile error in iterating ShaderBitSet


Created with:
  gclient setdep -r src/third_party/angle@0661eb899f46

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I424a7199d0df4a709e72f95ef40d5d3f72d85704
Reviewed-on: https://chromium-review.googlesource.com/1102403Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567672}

TBR=charliea@chromium.org
NOTRY=true

Bug: 853212
Change-Id: Id5f9e32f018e5cf3bcec17f49ea98738e1368eb0
Reviewed-on: https://chromium-review.googlesource.com/1102572Reviewed-by: Emily Hanley <eyaich@chromium.org>
Commit-Queue: Emily Hanley <eyaich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567671}

This patch stops painting a line break the end of inline-block
because if an inline-block is at the middle of line, we should not paint
a line break.
Old layout paints line break if the inline-block is at the end of line, but
since its complex to determine if the inline-block is at the end of line on NG,
this patch just cancels block-end line break painting for any inline-block.

This patch fixes:
 paint/selection/text-selection-inline-block-rtl.html
 paint/selection/text-selection-inline-block.html
(rebase is for 1px line height).

Bug: 708452
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I270b48fd432e31b327796b098edc7c9553b356ad
Reviewed-on: https://chromium-review.googlesource.com/1096922
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567670}

Bug: 852075
Change-Id: Ic0dad63f55974911ae45355d546d1b7ec5efcdc3
Reviewed-on: https://chromium-review.googlesource.com/1101925Reviewed-by: David Trainor <dtrainor@chromium.org>
Commit-Queue: Justin DeWitt <dewittj@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567669}

BrowserDMToken storage should already read DM token from Registry.
MachineLevelCloudPolicyFetcher should be created if there is a DM token
avaiable.

Bug: 852903
Change-Id: Ib10f03a3c0c944358212d076b5c39f38fb88c4ce
Reviewed-on: https://chromium-review.googlesource.com/1101556
Commit-Queue: Owen Min <zmin@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Reviewed-by: Roger Tawa <rogerta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567668}

List of patterns of .class files to exclude from the cronet_impl_native_java.jar,
while they still exist in the cronet_impl_native_java-src.jar. This CL fixes their
consistency, and reduce the cronet_impl_native_java-src.jar by about 50 KiB.

TBR=xunjieli@chromium.org

Change-Id: Ieefd47e47b406873c941203d509e898371392ee9
Reviewed-on: https://chromium-review.googlesource.com/1102235Reviewed-by: Helen Li <xunjieli@chromium.org>
Commit-Queue: Helen Li <xunjieli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567667}

Bug: 635619
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: I12d68f1153e78d4ebd8d3e92b7ab83a9f6e2f036
Reviewed-on: https://chromium-review.googlesource.com/1101905
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567666}

When building using Jumbo files gets merged.
This results in a conflict with the namespace prefs in
webui/media_router/media_router_webui_message_handler.cc.
This commit solves this by specifying that the global
namespace should be used, by adding the "::" prefix.

Bug: 773275
Change-Id: I504984ef83db8cc23561f1f16ce99cdbee89721e
Reviewed-on: https://chromium-review.googlesource.com/1102419Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#567665}

Bug: 820036
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I3a7a713b90cfb314685b680cbf476d115a9c3771
Reviewed-on: https://chromium-review.googlesource.com/1101246
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Danyao Wang <danyao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567664}

Bug: 377995
Change-Id: Iff66c6d214dfd0cb7ea9c80f83afeedfff703541
Reviewed-on: https://chromium-review.googlesource.com/983558
Commit-Queue: Andy Paicu <andypaicu@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567663}

This reverts commit 42c62276.

Reason for revert: suspect for browser crashes in canary as per
crbug.com/853049.

Original change's description:
> Avoid a proxy tab helper on Android for sync delegation
> 
> Prior to this patch, TabContentsSyncedTabDelegate was itself a tab
> helper (WebContentsUserData) that was created on all platforms, with the
> whole purpose to reuse a partial implementation of
> sync_sessions::SyncedTabDelegate.
> 
> This was a bit weird because
> a) The life cycle diverges across platforms: created lazily on Android,
>    early otherwise.
> b) On Android there was no real need to register a tab helper.
> c) On Android, it's weird to reason about two tab delegates coexisting,
>    one of which is a proxy but also overrides some logic.
> 
> Instead, let's make TabContentsSyncedTabDelegate a base class that is
> *NOT* a WebContentsUserData, and let platform-specific subclasses
> decide whether they want to register as WebContentsUserData, as well
> as which logic they need to override.
> 
> This also removes code that is dead on some platforms, because the
> base class is abtract and doesn't implements all methods (as opposed
> to a proxy object which cannot be abstract).
> 
> Bug: 851905
> Change-Id: I305ad85e2392fdd2ce428c0464b7750ac599babf
> Reviewed-on: https://chromium-review.googlesource.com/1097405
> Commit-Queue: Mikel Astiz <mastiz@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Reviewed-by: Marc Treib <treib@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567213}

TBR=avi@chromium.org,treib@chromium.org,mastiz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 851905,853049
Change-Id: I71a78fa8fd50b551c5ae50cb64f1fe5e033383e5
Reviewed-on: https://chromium-review.googlesource.com/1102537Reviewed-by: Mikel Astiz <mastiz@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567662}

The enums ColumnSetType are defined in both
views/passwords/password_pending_view.cc
and views/passwords/password_items_view.cc.
When building using Jumbo both declaration
ends up in the same namespace, causing a
conflict. This commits resolves the issue
by renaming the enums to something more
file specific.

Bug: 773275
Change-Id: I8f48b68df53166e910ab0beaf13ba80af63e40ae
Reviewed-on: https://chromium-review.googlesource.com/1102432Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#567661}

Rather than enforcing a limit on the smallest exponent, pass all
negative exponents straight to pow(...) and let it deal with it. Per
IEEE754 pow(10, -Inf) should yield 0, and the cast should round properly
for larger negative exponents (smaller than -37.)

Bug: 852785
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: Iccd80f7e80c8b87c49cd5eedf5e49ad1e9ccc8dc
Reviewed-on: https://chromium-review.googlesource.com/1102329
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Reviewed-by: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567660}

Add tags to all pages in each page set to enable filtering results by different page
sets.

Bug: 849392
Change-Id: Icf6a97566925de783b81cf2f4cb71f3d68f11971
Reviewed-on: https://chromium-review.googlesource.com/1093012
Commit-Queue: Amy Qiu <amyqiu@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567659}

https://webrtc.googlesource.com/src.git/+log/8643b78750bb..e61d72b37c64


git log 8643b78750bb..e61d72b37c64 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 yinwa@webrtc.org Disables congestion window in pacer when CongestionWindowPushback is enabled.
2018-06-15 nisse@webrtc.org Delete an unneeded include of pathutils.h.
2018-06-15 ilnik@webrtc.org Remove wire-up for cancelled experement on VAAPI VP8 encoding
2018-06-15 danilchap@webrtc.org Replace rtc::Optional with absl::optional in modules/rtp_rtcp
2018-06-15 nisse@webrtc.org Delete unused methods on rtc::Pathname.
2018-06-15 magjed@webrtc.org Android: Add helper class for generating OpenGL shaders


Created with:
  gclient setdep -r src/third_party/webrtc@e61d72b37c64

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

// Everything green except for purple bot (unrelated failure).
NOTRY=True

BUG=chromium:None,chromium:794608
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: Ia01ef0d0f498f78587fc27878cf7da12596641ea
Reviewed-on: https://chromium-review.googlesource.com/1102402Reviewed-by: Henrik Boström <hbos@chromium.org>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567658}

Bug: 849055
Change-Id: Ie60a938bc8831d149cd13c796e0089a5c3ccd988
Reviewed-on: https://chromium-review.googlesource.com/1100309
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567657}

TBR=noel@chromium.org

Bug: 852788
Change-Id: Idd41928a141d9717a398d36b41a335837d55e48e
Reviewed-on: https://chromium-review.googlesource.com/1102482Reviewed-by: François Doray <fdoray@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567656}

A fix for color emoji bounds on Windows is about to land in Skia but
will affect three layout tests. This flag will suppress the Skia change
until it is possible to rebaseline.

BUG=chromium:698492

Change-Id: I716e47b0fba0921a8fe9779aab071000a3960d7e
Reviewed-on: https://chromium-review.googlesource.com/1102488Reviewed-by: Florin Malita <fmalita@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567655}

This CL is part of a serie of CL to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: Ieafcedbb929d97847e379a8b7b383c42905dbe19
Reviewed-on: https://chromium-review.googlesource.com/1102460Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org>
Commit-Queue: Camille Lamy <clamy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567654}

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I66ba6c0cc89ce8a9a03db89dabeea475b0a40e5c
Reviewed-on: https://chromium-review.googlesource.com/1102485Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567653}

https://skia.googlesource.com/skia.git/+log/b7a72a501713..d7bfcaf57c1f


git log b7a72a501713..d7bfcaf57c1f --date=short --no-merges --format='%ad %ae %s'
2018-06-15 fmalita@chromium.org [skjson] Some short string optimizations
2018-06-15 borenet@google.com Roll infra/tools/git to 0ae21738597e5601ba90372315145fec18582fc4
2018-06-15 robertphillips@google.com Move op memory storage to GrContext
2018-06-15 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 9491e5ebed98..06a2262078b2 (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@d7bfcaf57c1f

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:851716
TBR=csmartdalton@chromium.org

Change-Id: Ie1d8b1352d00130250968912158a9e3021ee5471
Reviewed-on: https://chromium-review.googlesource.com/1102400Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567652}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/900b6b8c..16e54609

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia502ff0179f396ba8faa7be6e3d36a16ba969e17
Reviewed-on: https://chromium-review.googlesource.com/1102345Reviewed-by: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: V8 Autoroller <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567651}

So that they can be shared with ash.

BUG=837686
TEST=covered by tests
TBR=tsepez@chromium.org

Change-Id: Ide4e36e141454c4c120ad2f04544bf201f402550
Reviewed-on: https://chromium-review.googlesource.com/1102079Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567650}

This CL is part of a serie of CL to remove usage of the deprecated
method NavigationController::GetActiveEntry.

Bug: 273710
Change-Id: I179116d10ad8894ad0c88112cea519641dc240ae
Reviewed-on: https://chromium-review.googlesource.com/1102457
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567649}

This reverts commit 66769134.

Reason for revert: Experiment didn't work out. Looks like we'll need to figure out http://crbug.com/853069 or find an alternative to land this one :-/

Original change's description:
> Reland "Reland "[scheduler] Add a perftest to measure basic scheduling costs.""
> 
> This is a reland of abe98131
> 
> Original change's description:
> > Reland "[scheduler] Add a perftest to measure basic scheduling costs."
> >
> > This is a reland of 586e21ec
> >
> > Original change's description:
> > > [scheduler] Add a perftest to measure basic scheduling costs.
> > >
> > > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452
> > > Reviewed-on: https://chromium-review.googlesource.com/1085295
> > > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> > > Commit-Queue: Alexander Timin <altimin@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#566362}
> >
> > Change-Id: Ib9cfd16602c6bd0719059905250b91e0eb91dd22
> > Reviewed-on: https://chromium-review.googlesource.com/1097295
> > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> > Commit-Queue: Alexander Timin <altimin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#567645}
> 
> Change-Id: I047a8a8bc9d5cf0e8da58f9b8f9c1d669d3e67c5
> 
> TBR=skyostil@chromium.org
> NOTREECHECKS=true
> NOTRY=true
> 
> Change-Id: I047a8a8bc9d5cf0e8da58f9b8f9c1d669d3e67c5
> Reviewed-on: https://chromium-review.googlesource.com/1102597
> Commit-Queue: Robert Liao <robliao@chromium.org>
> Reviewed-by: Robert Liao <robliao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567647}

TBR=robliao@chromium.org,skyostil@chromium.org,alexclarke@chromium.org,altimin@chromium.org

Change-Id: I5ebffb9dcfb6776adc740ec0cff26ee62c1aa38e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1102519Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567648}

This is a reland of abe98131

Original change's description:
> Reland "[scheduler] Add a perftest to measure basic scheduling costs."
>
> This is a reland of 586e21ec
>
> Original change's description:
> > [scheduler] Add a perftest to measure basic scheduling costs.
> >
> > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452
> > Reviewed-on: https://chromium-review.googlesource.com/1085295
> > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> > Commit-Queue: Alexander Timin <altimin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566362}
>
> Change-Id: Ib9cfd16602c6bd0719059905250b91e0eb91dd22
> Reviewed-on: https://chromium-review.googlesource.com/1097295
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567645}

Change-Id: I047a8a8bc9d5cf0e8da58f9b8f9c1d669d3e67c5

TBR=skyostil@chromium.org
NOTREECHECKS=true
NOTRY=true

Change-Id: I047a8a8bc9d5cf0e8da58f9b8f9c1d669d3e67c5
Reviewed-on: https://chromium-review.googlesource.com/1102597
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567647}

This reverts commit abe98131.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 567645 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FiZTk4MTMxNzNjZGMzMzMwODI2MDdlNDk1Yjg1MzIzNGE3OTk1NGQM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/Linux%20x64/66495

Sample Failed Step: compile

Original change's description:
> Reland "[scheduler] Add a perftest to measure basic scheduling costs."
> 
> This is a reland of 586e21ec
> 
> Original change's description:
> > [scheduler] Add a perftest to measure basic scheduling costs.
> > 
> > Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452
> > Reviewed-on: https://chromium-review.googlesource.com/1085295
> > Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> > Commit-Queue: Alexander Timin <altimin@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#566362}
> 
> Change-Id: Ib9cfd16602c6bd0719059905250b91e0eb91dd22
> Reviewed-on: https://chromium-review.googlesource.com/1097295
> Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567645}

Change-Id: I973b98959cc75f61d024ec8a2ba382b66d1ef337
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/1101763
Cr-Commit-Position: refs/heads/master@{#567646}

This is a reland of 586e21ec

Original change's description:
> [scheduler] Add a perftest to measure basic scheduling costs.
> 
> Change-Id: Idda9f71ae005250848fd2a118e5c4344e36be452
> Reviewed-on: https://chromium-review.googlesource.com/1085295
> Reviewed-by: Alex Clarke <alexclarke@chromium.org>
> Commit-Queue: Alexander Timin <altimin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#566362}

Change-Id: Ib9cfd16602c6bd0719059905250b91e0eb91dd22
Reviewed-on: https://chromium-review.googlesource.com/1097295Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alexander Timin <altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567645}

https://chromium.googlesource.com/chromiumos/chromite.git/+log/90d481078b9b..ce952677d647


git log 90d481078b9b..ce952677d647 --date=short --no-merges --format='%ad %ae %s'
2018-06-15 dgarrett@google.com config_lib: Remove most UseBuildbucketScheduler hardcoding.


Created with:
  gclient setdep -r src/third_party/chromite@ce952677d647

The AutoRoll server is located here: https://chromite-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:851183
TBR=chrome-os-gardeners@chromium.org

Change-Id: Ic2db98b3dbf6ef5b994dfbda8e019d03e507cf82
Reviewed-on: https://chromium-review.googlesource.com/1102401Reviewed-by: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567644}

This CL updates the vector icons for several Answers in Suggest (AiS)
icons.

Bug: 841594
Change-Id: Id4464de95bdbaf02d9f8fc48d17868acedb2e594
Reviewed-on: https://chromium-review.googlesource.com/1102105
Commit-Queue: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567643}

Bug: 804645
Change-Id: I19e29e9d201eea3d6bd9e8a42f6e0621672ae2aa
Reviewed-on: https://chromium-review.googlesource.com/1100972Reviewed-by: Rick Byers <rbyers@chromium.org>
Commit-Queue: Luna Lu <loonybear@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567642}

This reverts commit 43e035ee.

Reason for revert: browser_test failures on
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Win7%20Tests%20%28dbg%29%281%29 starting around 69747

Small subset of tests failing:
PrerenderBrowserTest.PrerenderPageNewTab
DefaultIsolation/TaskManagerOOPIFBrowserTest.OrderingOfDependentRows/0
PrerenderBrowserTest.PrerenderDownloadClientRedirect
PrintPreviewBrowserTest.TaskManagerNewPrintPreview
TabManagerTest.OomPressureListener

Stack:
Received fatal exception EXCEPTION_BREAKPOINT
Backtrace:
base::win::RegisterInvalidParamHandler [0x738B4167+71]
invalid_parameter [0x6FDAECD1+161]
std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<unsigned long const ,std::unique_ptr<memory_instrumentation::GlobalDumpGraph::Process,std::default_delete<memory_instrumentation::GlobalDumpGraph::Process> > > > > >::operator* [0x6296CB0C+156]
std::_Tree_const_iterator<std::_Tree_val<std::_Tree_simple_types<std::pair<unsigned long const ,std::unique_ptr<memory_instrumentation::GlobalDumpGraph::Process,std::default_delete<memory_instrumentation::GlobalDumpGraph::Process> > > > > >::operator-> [0x6299A3C1+17]
memory_instrumentation::QueuedRequestDispatcher::Finalize [0x62998EF4+3364]
memory_instrumentation::CoordinatorImpl::FinalizeGlobalMemoryDumpIfAllManagersReplied [0x629303EB+587]
memory_instrumentation::CoordinatorImpl::OnOSMemoryDumpResponse [0x629324F3+819]

Original change's description:
> Add RequestPrivateMemoryFootprint method to MemoryInstrumentation.
> 
> Most clients only need private memory footprint, but the existing methods would
> still query all the MemoryDumpProviders and then filter the results. This CL
> adds a new method that avoids querying MemoryDumpProviders.
> 
> Bug: 851712
> Change-Id: I269be2b5a74c32205ba6f4087a9bb8affb9cffb6
> Reviewed-on: https://chromium-review.googlesource.com/1098623
> Reviewed-by: Primiano Tucci <primiano@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Commit-Queue: Erik Chen <erikchen@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567417}

TBR=dcheng@chromium.org,thakis@chromium.org,primiano@chromium.org,erikchen@chromium.org,lalitm@chromium.org

Change-Id: I5dd27418aad49f2fcfbcb10c5510f11b91f4d875
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 851712
Reviewed-on: https://chromium-review.googlesource.com/1102518Reviewed-by: Robert Liao <robliao@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567641}

Assigned Node ID may not be the same for each executions of the test
DomTreeExtractionBrowserTest.RunAsyncTest. This CL clears the value of
backendNodeId to make this test more deterministic.

backendNodeId uses DOMNodIds::IdForNode(). Here are two stack traces
where the ID number 3 is assigned to a different Node.

02 blink::DOMNodeIds::IdForNode()
03 blink::InspectorDOMSnapshotAgent::VisitNode()
04 blink::InspectorDOMSnapshotAgent::VisitContainerChildren()
05 blink::InspectorDOMSnapshotAgent::VisitNode()
06 blink::InspectorDOMSnapshotAgent::getSnapshot()
07 blink::InspectorDOMSnapshotAgent::getSnapshot()
08 blink::protocol::DOMSnapshot::DispatcherImpl::getSnapshot()
09 blink::protocol::DOMSnapshot::DispatcherImpl::dispatch()
10 blink::protocol::UberDispatcher::dispatch()
11 blink::InspectorSession::DispatchProtocolMessage()
12 blink::WebDevToolsAgentImpl::Session::DispatchProtocolCommand()
13 blink::mojom::blink::DevToolsSessionStubDispatch::Accept()

02 blink::DOMNodeIds::IdForNode()
03 blink::CompositedLayerMapping::CreateGraphicsLayer()
04 blink::CompositedLayerMapping::CreatePrimaryGraphicsLayer()
05 blink::CompositedLayerMapping::CompositedLayerMapping()
06 blink::PaintLayer::EnsureCompositedLayerMapping()
07 blink::PaintLayerCompositor::AllocateOrClearCompositedLayerMapping()
08 blink::CompositingLayerAssigner::AssignLayersToBackingsInternal()
09 blink::CompositingLayerAssigner::Assign()
10 blink::PaintLayerCompositor::UpdateIfNeeded()
11 blink::PaintLayerCompositor::UpdateIfNeededRecursiveInternal()
12 blink::PaintLayerCompositor::UpdateIfNeededRecursive()
13 blink::LocalFrameView::UpdateLifecyclePhasesInternal()
14 blink::LocalFrameView::UpdateAllLifecyclePhases()
15 blink::PageAnimator::UpdateAllLifecyclePhases()
16 blink::PageWidgetDelegate::UpdateLifecycle()
17 blink::WebViewImpl::UpdateLifecycle()
18 blink::WebViewFrameWidget::UpdateLifecycle()
19 content::RenderWidget::UpdateVisualState()
20 content::RenderWidgetCompositor::UpdateLayerTreeHost()
21 cc::LayerTreeHost::RequestMainFrameUpdate()

Currently, this test doesn't appear to be flaky. I am working on:
https://crbug.com/831155. It causes the navigation to commit slightly
faster. The test fails one time out of four, all the backendNodeId in
getSnapshot() are shifted by one.

Bug: 831155
Change-Id: I83a30202877bb65953957438284062f13fabeb6c
Reviewed-on: https://chromium-review.googlesource.com/1101693Reviewed-by: Alex Clarke <alexclarke@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567640}

Fixes menu positioning miscalculations in MenuController.

Bug: 852153
Change-Id: I494bf3b80e33712d515c1369a0fa1be9e3c3e90b
Reviewed-on: https://chromium-review.googlesource.com/1101966Reviewed-by: Michael Wasserman <msw@chromium.org>
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567639}

There were capacity issues when we last added viz_browser_tests to Windows.
However based on discussions in https://crbug.com/829187 there appears to be
capacity on Win7 Tests (dbg)(1). This change re-eanbles them
on that config.

TEST=viz_browser_tests

Bug: 851631
Change-Id: Ie5f33ee667097faf0a1aadc3b5e23b85b2bd1aca
Reviewed-on: https://chromium-review.googlesource.com/1096078
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567638}