GitLab

The current integration of crash keys into v8 got the dependencies
wrong: it introduced into v8 a dependency on components and base. This
change is the second half of fixing the design to keep the dependencies
in the embedder. The change depends on
https://chromium-review.googlesource.com/c/v8/v8/+/1699102.

Bug: v8:9323
Change-Id: Ib5b497a50718c451ab38b2bf32c4d68f5a9e22e1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1690003
Commit-Queue: Irina Yatsenko <irinayat@microsoft.com>
Reviewed-by: Stefan Zager <szager@chromium.org>
Reviewed-by: Ross McIlroy <rmcilroy@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686502}

The items eat the events aimed for the controller than shifts the grid
left and right, we need to change so window drags on begin on
long presses.

Test: manual, added tests
Bug: 991346
Change-Id: I387fa0a4acff17e4b9673f1d042cf8ae8d4b1eec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749710
Commit-Queue: Danton Vu <dantonvu@google.com>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686501}

Update devtools to no longer require the id property as identifying the
animation name or transition property and instead use the proper IDL
hierarchy and properties.

Bug: 849927
Change-Id: I85a1c6eda7f176ce23906ee64b4c9c2d3374c57c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740647
Auto-Submit: George Steel <gtsteel@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Commit-Queue: George Steel <gtsteel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686500}

Bug: 986298
Change-Id: Ia6950462efa1ed9128892059abca965fb9aeb86a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751725
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686499}

Currently extensions are allowed to use the download API to override
downloaded file extensions. This causes some security issues
as file with dangerous extensions can be override to safe extensions
and bypassing dangerous prompt. And there are also other possible
attacks using this feature.
This CL blocks plugings from changing the file extensions to an
arbitrary one. The mime type will be used to determine the final
extension. However, it is possible for plugins to remove the
extensions from the final file name.

BUG=989078

Change-Id: Idd28510d3db191f40bbe24256d64449856e4644f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1740048Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Min Qin <qinmin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686498}

These were added during the MacViews port to support Mac code like this:

  if (IsUsingViewsDialogs())
    ShowThingViews();
  else
    ShowThingCocoa();

without the Mac code directly linking the Views code, but that build config is
now long dead.

A followup CL will also remove CreateLoginHandlerViews, but that will be more
involved.

Bug: None
Change-Id: Ifef442e159317763bd6f6f8e652e56495cc195f5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752066
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Reviewed-by: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686497}

This is now safe to do for all of our apks since we don't support
JellyBean anymore.

Bug: 993342
Change-Id: I670a0d54e6b524c6fa21f712efc6214a04c74bb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752102
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Reviewed-by: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686496}

Various webkit-appearance tests have been passing for quite some time.

TBR=ikilpatrick@chromium.org
BUG=626703

Change-Id: I68a2659e39ec80387de851d6a5035854abb69380
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752125Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Stephen Chenney <schenney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686495}

This CL adds the current track title and artist to the right of the
artwork in a vertical layout. This CL also fixes the elide behavior of
the app/source label on the header row.

See bug for pictures.

Bug: 991647
Change-Id: Ia9c8601a17e1ce472bb984e90cb8a11926edb307
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752170Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Mia Bergeron <miaber@google.com>
Cr-Commit-Position: refs/heads/master@{#686494}

The original counter only counts unitless length literals, which is
incorrect and was exposed by a recent refactoring crrev.com/c/1696274

This patch changes the counter to also count unitless lengths involved
in math functions (e.g., calc(1 + 1%)).

Bug: 979895
Change-Id: I49744bceee307485e979addb3ea9be95d9d22922
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750189Reviewed-by: Emil A Eklund <eae@chromium.org>
Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686493}

This CL is a reland of:
https://chromium-review.googlesource.com/c/chromium/src/+/1747031

It implements the updater::TaskScheduler class to allow
creating scheduled tasks using Windows's task scheduler.

The code is similar to what //chrome/chrome_cleaner/os has for this
purpose. Future refactoring work to eliminate duplicated code is
possible but unknown at this point how such effort could proceed.

Several dependencies are needed for unit testing this code. The
general idea is that a program is invoked by the unit tests
scheduled tasks. To detect that such program has run, synchronization
with the unit test execution is required.

Since the MS task scheduler API is finicky, minimal changes were done to
the TaskScheduler class implementation.

Bug: 992551
Change-Id: I429a979f3a0aad70bedcf4d6c4847f97dc4b1392
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751766Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Sorin Jianu <sorin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686492}

Do not provide the color for inkdrop directly, provide the background
color of the element that wants to apply inkdrop instead. And then use
AshColorProvider::GetRippleAttributes to get the ripple attributes
based on the given background color.


Bug: 982950
Change-Id: I7404b24f1df74ca7782a411c21290a975205d72f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746765Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Min Chen <minch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686491}

This reverts commit f57f0ad1.

Reason for revert: Causes crashes, see crbug.com/993442

Original change's description:
> CHECK that OnURLsDeleted() receives info for all deleted origins.
> 
> A developer reported a failure in the DCHECK that verifies that
> LocalSiteCharacteristicsDataStore::OnURLsDeleted() receives details
> for the origin of all deleted URLs.
> 
> This CL transforms the DCHECK into a CHECK to determine whether this
> can happen in production.
> 
> Bug: 966059
> Change-Id: Ia3328ca7d832935ee906ddb5570aa3035a65c0ec
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749248
> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
> Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#686219}

TBR=fdoray@chromium.org,sebmarchand@chromium.org

Change-Id: I761101e0e2f4f122013ea7f76c701c3024b2b621
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 966059
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752079Reviewed-by: Sébastien Marchand <sebmarchand@chromium.org>
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686490}

This flag will spin up WPR in quiet mode, so that the log doesn't
balloon with basic stdout call and response information

This helps the readability and usefulness of the logs for diagnosing issues

Bug: 988509
Change-Id: Ibc195ed4bb135ecdb07e78d0bae7e5701e240917
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747863
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Auto-Submit: Ian Struiksma <ianstruiksma@google.com>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686489}

Remove the wrong baselines on mac and linux. The wrong baselines
contained wrong width of margin box for an element, which were
created probably because of a pre-LayoutNG bug.

Bug: 984926
Change-Id: I3f4f163e3c5d96cf129a3399b145110722a9c189
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747978Reviewed-by: Philip Rogers <pdr@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686488}

This allows DropdownBarHost animation to be driven by ui::Compositor.
There's no intentional behavior change.

Bug: 953585
Change-Id: Ie2d4ce5666dd8f1d07918083fcbb813e06c1c3c0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750504
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686487}

Using wpt-import in Chromium 09cf3681.
With Chromium commits locally applied on WPT:
329c91e5 "Attempt to make test more stable"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
rego@igalia.com:
  external/wpt/css/css-ui

NOAUTOREVERT=true
TBR=robertma

No-Export: true
Change-Id: I745b557eb4b60ac2f52edb05176dbb31ec483b6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752062Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#686486}

There's no longer anything to do here.

Bug: 729808
Change-Id: Ic0cf93abdcbdfdbfc2392df1a46e1c129a5166fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752286
Commit-Queue: James Cook <jamescook@chromium.org>
Commit-Queue: Xiyuan Xia <xiyuan@chromium.org>
Auto-Submit: James Cook <jamescook@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686485}

This cl removes stale reference to
components/supervised_user_error_page/OWNERS which has been moved.

NOPRESUBMIT=true

Bug: 969748
Change-Id: I5b82b8ff2e18415e1b191c1a3fbb04383482f03d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751969Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yilkal Abe <yilkal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686484}

This CL aims at removing rest of the code to use gmscore isUVPAA.

This CL is the third of 3 CLs to add isUVPAA implemenration on clank
and remove the flow to call isUVPAA that gmscore supports.
First CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1739973
Second CL:
https://chrome-internal-review.googlesource.com/c/clank/internal/apps/+/1587528

Bug: n/a
Change-Id: I8f045738e3b3213184e7109bb42f1924ad8c55b0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750406
Commit-Queue: Suzy Li <suzyli@google.com>
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686483}

Some features need to know if the screen is on and unlocked (e.g. the
ClickToCall feature will use this to open the dialer immediately instead
of displaying a notification). This adds this information to
DeviceConditions and updates all dependencies.

Bug: None
Change-Id: If67dc2d736b20284c0e79a0244753f594bfdba74
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751730Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Richard Knoll <knollr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686482}

The goal of this CL is to fix WebApkIntegrationTests flakiness
on touchless bots.

The WebApkIntegrationTests with the exception of
testWebApkLaunchesByLauncherActivity test WebApkActivity not the
WebappLauncherActivity/WebApkActivity launch flow. This CL moves those
tests to WebApkActivityTest.
The differences between WebApkIntegrationTest and WebApkActivityTest
are:
WebApkActivityTest builds WebApkInfo directly instead of reading the
AndroidManifest
WebApkActivityTest does not use --host-resolver-rules weirdness

BUG=983769

Change-Id: I0273a34c27f4d07e38ea67fdb9dac7b2b900e6ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747164
Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686481}

Environment variable "CHROMIUM_TEST_LAUNCHER_BOT_MODE"
will set retry limit to 3.
This causes RunMockTests test to retry failing and crashed tests.

Bug: 993323
Change-Id: If2ba3baa52a356b732bdc317171a3dc73ce306df
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752169
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Reviewed-by: Erik Chen <erikchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686480}

For Captured Sites test automation, we now log what is in the cache,
and we log the key that was looked for on a miss, but we don't log
what key was requested when there is a hit. This line fixes that.

Change-Id: I01561dd39d7152f87b66bb9d1a993dbe2d94b33f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748604Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Commit-Queue: Ian Struiksma <ianstruiksma@google.com>
Cr-Commit-Position: refs/heads/master@{#686479}

- Adds a fullScreenBadge property to BadgeViewController beside the
displayedBadge that is shown regardless if fullscreen is enabled or
disabled.
- Creates BadgeIncognitoItem as a model representation of the incognito
badge.
- Checks if new WebState is OffTheRecord in BadgeMediator to add
an incognito badge.

Screenshot: https://drive.google.com/open?id=1_GyW4tQ2iNIJmv-5yBH4fEGRf8i2GOxf

Bug: 976901, 976815
Change-Id: Ic1a3580c51ca2f5ee0d33f326e069d32c0b72ea2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1746464
Commit-Queue: Chris Lu <thegreenfrog@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686478}

... the window has an un-identity transform in place.

This is to fix the animation when snapping an overview window in clamshell mode.

Bug: 890029
TEST: Manually
Change-Id: I5d05eee296b16a5b84da10bfbad848c78969c8a4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1731697
Commit-Queue: Xiaoqian Dai <xdai@chromium.org>
Reviewed-by: Mitsuru Oshima (OOO 8/12,13) <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686477}

This is to fix the issue mentioned in crbug.com/993363

NOTRY=true
TBR=jbudorick

Bug: 993363
Change-Id: I58f3cd8ebc0761124d51be5328852a493b487eea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751906
Commit-Queue: Haiyang Pan <hypan@google.com>
Reviewed-by: Stephen Martinis <martiniss@chromium.org>
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Auto-Submit: Haiyang Pan <hypan@google.com>
Cr-Commit-Position: refs/heads/master@{#686476}

After non-sync users are able to migrate local cards, the
primary account email will no longer be correct.

Bug: 897998
Change-Id: I932b38ed2d6bf0ffdd238ab73a76998a31ed898c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1747076
Commit-Queue: Jared Saul <jsaul@google.com>
Reviewed-by: Jared Saul <jsaul@google.com>
Cr-Commit-Position: refs/heads/master@{#686475}

This CL makes AutocompleteMatch::duplicate_matches sorted from
best-to-worst.

It refactors the deduplication process by splitting the duplicate
preference sorting code into a comparator, and puts the relevance
upgrading logic into its own method in:
AutocompleteMatch::UpgradeMatchWithPropertiesFrom().

This CL is needed, because almost any re-duplication logic used for
Entity Suggest "plain" match (see bug) will need to sort the duplicates
from second-best to worst.

But this should also be a pretty beneficial change on its own for code
clarity.

Bug: 989232
Change-Id: I71f093fe69714ee491328a54e3e2238a3ecadbbc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1730598
Commit-Queue: Tommy Li <tommycli@chromium.org>
Reviewed-by: manuk hovanesian <manukh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686474}

CQ-DEPEND=chromium:1698490

Change-Id: I15d3ee4e0e5425c34fbbbccff63c937af2e1e4ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1733712
Commit-Queue: Shaojiang Zhong <sjzhong@google.com>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686473}

|update_network_isolation_key_on_redirect| should only be set on
navigation requests, and renderers are not trusted to set it.

This CL introduces ResourceRequest::TrustedParams, which contains fields
only the browser process is trusted to set, and an |is_trusted| bit that
can be set when creating URLLoaderFactories. If TrustedParams are sent
to a URLLoaderFactory without that bit set, the request will fail.

Bug: 991736
TBR: alexilin@chromium.org
Change-Id: Id3263e03e663b330ee9c21682a4d0de753c5331a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1744926
Commit-Queue: Matt Menke <mmenke@chromium.org>
Reviewed-by: Shivani Sharma <shivanisha@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686472}

Users from browswer side can call AddDataRestoreKey() in cryptohome_client
so that the client will send D-Bus call to chromeOS cryptohome. The
reply sent from chromeOS will contain the raw bytes of generated
data_restore_key.

CQ-DEPEND=chromium:1698490
BUG=chromium:969916

Change-Id: I671f826ac6795de021f9c93e093a7f04b7738730
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736817Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Shaojiang Zhong <sjzhong@google.com>
Cr-Commit-Position: refs/heads/master@{#686471}

The stuck-child timeout tests were using a 5ms timeout, which on some
systems caused CoordinatorImplTest.TimeOutStuckChildMultiProcess to fail
due to no "browser" dump being received within those 5ms.

Remove the dependency on the speed of the system on which the test is
running by using MOCK_TIME instead.

Bug: 970819
Change-Id: I48fc6c8b8b6e7bc5c19179a01cd9e80ee40e8555
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750405Reviewed-by: Hector Dearman <hjd@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686470}

This adds a global CHECK that ensures we hopefully won't miss new processes as
they are added.

This enables all processes to initialize system tracing as early as possible.

Bug: 979576
Change-Id: Id9d841dad5980cf82e46586238fe682722558cea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1748886
Commit-Queue: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Eric Seckler <eseckler@chromium.org>
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686469}

chrome_cleaner is built into a separate executable from chrome, so many
of chrome's include_rules shouldn't apply to it.

Also moves several common dirs to chrome_cleaner's main DEPS file so they're
allowed in the whole chrome_cleaner project. The remaining includes that are
only allowed in some subdirs are:

* components/crx_file (only used in the component that unpacks CRX's)
* mojo/core/embedder (only used in IPC setup, and by some tests - mojo/public is allowed everywhere)
* net/traffic_annotation (only used in networking code)
* third_party/crashpad (only used in the crash reporter)
* third_party/zlib (only used in the unpacker component and zip_archiver)

R=proberge

Bug: 967728
Change-Id: I96dc59014ebb9be0e0483a190e000f42902b49da
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749249Reviewed-by: proberge <proberge@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Joe Mason <joenotcharles@google.com>
Cr-Commit-Position: refs/heads/master@{#686468}

This class now requires an anchor view (which in practice it always has) and
does not support having an anchor point.

Bug: 989080
Change-Id: I7c0b24e5cbe9794ef87c97ce5e6d174938192170
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749308
Auto-Submit: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Reviewed-by: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686467}

This helps to see what happened around DCHECK failure.

Bug: 993249
Change-Id: I2f7dd76c63899599140f15149da761ac33b2d7f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750539
Auto-Submit: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Vlad Tsyrklevich <vtsyrklevich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686466}

  ../../chromeos/services/secure_channel/ble_scanner_impl_unittest.cc:231:12:
  error: address of stack memory associated with local variable
  'fake_bluetooth_device' returned [-Werror,-Wreturn-stack-address]
      return fake_bluetooth_device.get();
             ^~~~~~~~~~~~~~~~~~~~~

I guess the test worked before because it didn't actually dereference the
pointer.

Bug: 992458
Change-Id: I82f189588644a63de1a9f16dbf158dfcdca5e5a9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751789Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686465}

Bug: 992355
Change-Id: I9a61e2f21d7d0492763d444d228c13090d0d4262
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1751982Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Yasmin Molazadeh <yasmo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686464}

Test: added test
Bug: 992223
Change-Id: I717921ba2a0cc428b934b57e247f54395691b907
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1750155Reviewed-by: Avery Musbach <amusbach@chromium.org>
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Cr-Commit-Position: refs/heads/master@{#686463}