- 27 Jul, 2020 40 commits
-
-
David Benjamin authored
The IO thread bits originally set up a URLRequestContext and friends, but that has been removed as of https://chromium-review.googlesource.com/c/1355136. Bug: 908955 Change-Id: I5d2cd6f53352d142d64b7fa1e9fef7ba9f1939a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314831Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#791853}
-
Omer Katz authored
The HashTraits for KeyValuePair were updated to allow concurrent marking, but HashMapValueTraits did not inherit that. kCanTraceConcurrently is moved from HashTraits<KeyValuePair> to KeyValuePairHashTraits so that it is inherited by HashMapValueTraits. Bug: 986235 Change-Id: Id33b6054db3b8bf044cab6ebfd0e1d677118fab4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320169 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#791852}
-
Hitoshi Yoshida authored
A CL (https://crrev.com/c/2302972) seems to regress a performance test. This CL fixes the regression. ImageResource seems to be more frequently accessed, and creating base::optional<> in the hot spot would regress the performance. This CL reverted to use a reference of String in ParseType(), and to check ImageResource.type availability outside of the function. Bug: 1108870 Change-Id: Ie5de9aff7b9ca479452637a22c90a82c829147ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318494Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#791851}
-
Eleonora Rocchi authored
This CL adds an image button to restart the check passwords once the previous one has been completed successfully or if there has been an error in the previous check. It also adds the tests to verify the correct visibility of the button. IDS_ACCESSIBILITY_PASSWORD_CHECK_RESTART_BUTTON.png.sha1 image: https://storage.cloud.google.com/chromium-translation-screenshots/ead1b2a3b13694352574ef214e5945cb5aace20e Bug: 1109691, 1092444 Change-Id: I079d08820a3c98cefb4be2d7f3139a34dcfcc390 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315339Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Commit-Queue: Eleonora Rocchi <erocchi@google.com> Cr-Commit-Position: refs/heads/master@{#791850}
-
Garrett Beaty authored
This reverts commit 9a66d347. Reason for revert: android-pie-arm64-rel is not a bottleneck for the CQ health Original change's description: > Temporarily disable chrome_public_test_apk on android-pie-arm64-rel. > > Bug: 1108071 > Change-Id: I2b8053233567b2478d3efd9eb3976000a6422bef > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311369 > Commit-Queue: Garrett Beaty <gbeaty@chromium.org> > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Stephen Martinis <martiniss@chromium.org> > Cr-Commit-Position: refs/heads/master@{#790588} TBR=martiniss@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108071 Change-Id: I514d589541a79989c8e34cce26837a615887428f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318786Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#791849}
-
jonross authored
This test suite has been failing consistently for 11 days. One test crashes consistently: EGLFeatureControlTest.InvalidDisplay/ES2_OpenGL_NoFixture The other tests are all identified to not even run on this configuration. I'm adding an exception for this bot to not run the suite until the root cause can be addressed. TBR=ynovikov@chromium.org Bug: 1094629 Change-Id: If8eadabb03de0e54d11956bce50761cf71aadcf9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320408Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#791848}
-
David Jean authored
TBR=sdefresne@chromium.org Bug: 1109740 Change-Id: I7f0d80fabe01f264629311374a968da52f10e0db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320275Reviewed-by:
David Jean <djean@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#791847}
-
Maksim Sisov authored
it was only limited to non-Ozone/X11. It's time to enable that for OS_LINUX instead as it can be either USE_X11 or USE_OZONE or both. Bug: 789065, 578890 Change-Id: I549f48b731cd9b4ae5d076be02c092939a6e3350 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315888 Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Reviewed-by:
-
Trent Begin authored
This change creates a connection with the cros_healthd service factory when the service connection is created. This will eventually allow Chrome services (NetworkHealth and NetworkDiagnostics) to be passed to cros_healthd when Chrome starts. Bug: chromium:1057739 Change-Id: I0b2142d40adeac4d1991b22642b4555acbf31b97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303362 Commit-Queue: Trent Begin <tbegin@chromium.org> Reviewed-by:
Paul Moy <pmoy@chromium.org> Reviewed-by:
Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#791845}
-
Dominique Fauteux-Chapleau authored
This will allow to override the URL used by BinaryUploadService::Request on Chromium builds for development purposes. Bug: 1108856 Change-Id: I8a4645b3fdb73c6268e0dbb790c539b1a2eb5824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314688 Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#791844}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3f851efa2adc..c3ccd3a79714 2020-07-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Vulkan-Headers from 83825d55c7d5 to a0f1f5149d91 (1 revision) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: tobine@google.com Change-Id: I242fae423f74722e760931b9edd38b1b09b35367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320033Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791843}
-
Mikel Astiz authored
This patch migrates tests away from deprecated APIs and adopts TestingProfile::Builder for tests in /chrome/browser/ui/sync. Rationale: creating or overriding keyed services after the profile has been created is problematic and known to cause hard-to-debug test flakiness, because it bypasses BrowserContextDependencyManager and often leading to use-after-free. This CL was uploaded by git cl split. R=msarda@chromium.org Bug: 1106699 Change-Id: I3b8aa9ab1e730ef7a3ad554311d4d69db0ab91e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316363 Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#791842}
-
Stepan Khapugin authored
Makes blob: URLs just show the domain name, like all other URLs, and formats by clipping the head. Bug: 1080395 Change-Id: If9bf4921044dfd94bcd8cb79c53083ac49266f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310430 Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#791841}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1595785360-159b80f78c6519bfeba1228f89c3740bd393f1a5.profdata to chrome-win64-master-1595807480-d17b0499af342f0654e8c059a08be3424e0d8a06.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: If770e07f4c2f7b2c67b2b1c1c1d07b51676f3eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319888Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I5309e4ace12277bf918ea8eed724db9cfc62154a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319542Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#791839}
-
Adithya Srinivasan authored
Bug: 1109768 Change-Id: Idc425021c9674e52a3b183f459efea3e34dd48ad Tbr: droger@chromium.org No-Try: True Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320132Reviewed-by:
Adithya Srinivasan <adithyas@chromium.org> Commit-Queue: Adithya Srinivasan <adithyas@chromium.org> Cr-Commit-Position: refs/heads/master@{#791838}
-
Dominic Schulz authored
This change is to avoid bootlooping on SWA installation. With this change, we will attempt the same version 3 times and then stop attempting reinstallation. We will try installation again when a new version is pushed. Formatting fixes Fix up the tests Abandon failed SWA install after 3 at same version First test code Bug: 1095523 Change-Id: I3139652767d94586e5dd6fc0c8070eae8a25cce5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2268207 Commit-Queue: Dominic Schulz <dominicschulz@google.com> Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Cr-Commit-Position: refs/heads/master@{#791837}
-
Andrey Zaytsev authored
Bug: 1070620 Change-Id: I03bb8b01f07d815036b536e1b4fec6bfbc7bf1f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317880 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#791836}
-
Nicolas Ouellet-Payeur authored
This class makes it easy to starts multiple SandboxedUnpacker's in parallel, and get notified as soon as any of them completes. Since SandboxedUnpacker is disk-bound and often takes >2s to run, running them in parallel can be beneficial. Right now ParallelUnpacker is not used anywhere, but a follow-up CL will use it to make extensions update in parallel, which will speed up extension installs when many of them are queued at the same time (such as for force-installed extensions). Bug: 1103447 Change-Id: Ibc35588134fe0e91c4f7a243677181a08c642552 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294563 Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791835}
-
Peter Wen authored
Add -C as well for --output-directory to match ninja's syntax. Make it clear in the help text that there are easier ways to permanently specify a default output directory. Remove some unused fields and use f-strings. Bug: None Change-Id: I0a9ba8329095a5c6d8c46ddb63966f31d3307754 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315093 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#791834}
-
Kevin Ellis authored
Use requestAnimationFrames instead of setTimeouts in the ref tests to accommodate variability in timing. The background color is animated between green and red to better align with reftest guidelines. The test to slow down the animation was removed since it would be essentially equivalent to the zero playback rate test after the refactoring. Bug: 1108342, 1064127 Change-Id: Ie933b68cf45caabfa70fbe5deb881e120ea5e28a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2313157Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#791833}
-
Chris Sharp authored
Key is 'future_on' Change-Id: Ibef7b85ea6fa4853effb922b1d9d0383ec536e30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2300005Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#791832}
-
Karel Král authored
Provide more information by adding a trace event to WaitableEvent::Wait. Connect WaitableEvent::Signal with the end of WaitableEvent::TimedWait by a flow event. Make the implementation of WaitableEvent::Wait cross-platform and move it in waitable_event.cc. Bug: 1043616 Change-Id: I07d13d43e951d6fa223202ccd5f6a076559b416f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2267160Reviewed-by:
Gabriel Charette <gab@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Karel Král <karelkral@google.com> Cr-Commit-Position: refs/heads/master@{#791831}
-
Tommy Martino authored
This adds the string used for the entry point for the Link to Text (Shared Highlighting) feature. Bug: 1099268 Change-Id: Id1f990658d32a2c206d8b1115fe581493c42969e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315087Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Tommy Martino <tmartino@chromium.org> Cr-Commit-Position: refs/heads/master@{#791830}
-
Sebastien Lalancette authored
This new class will be aggregating all the dependencies (e.g. QRGeneratorCoordinator) around sharing scenarios and hide them away under a simple interface. The current interface is only about sharing the current page. In the near future, we'll be adding another method to allow sharing a URL that doesn't have any associated WebView (e.g. coming from Bookmarks). Ideally, these dependencies would already be part of ActivityServiceCoordinator. However, since QRGeneratorCoordinator itself owns an ActivityServiceCoordinator instance, we had to add this extra layer of aggregation. Bug: 1102890 Change-Id: I6c2fc63239d6fd9567b244616e7b080e4ebd9a45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2297601 Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#791829}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/522fd1e551b2..e94b4e1b49a3 2020-07-27 robertphillips@google.com Update more tests to use the GrDirectContext/GrRecordingContext pair 2020-07-27 johnstiles@google.com Enable move construction for OpChain and SkTArray<OpChain>. 2020-07-27 jmbetancourt@google.com Reland "implement working CorrectnessActivity to generate lottie keyframe PNGs" 2020-07-27 johnstiles@google.com Add missing #includes for referenced types. 2020-07-27 scroggo@google.com Add texture size to Android's GPU upload trace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I20d65634540f159244526df1850c9ecc2910a18c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320195Reviewed-by:
-
Adithya Srinivasan authored
Bug: 1109117 Change-Id: Iaa980b203de782cdfec56ad89e01a2c86fadd1f0 Tbr: marq@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320130Reviewed-by:
-
Torne (Richard Coles) authored
Apps that target R or later default to setAllowFileAccess(false). Update the WebView UI test code to explicitly enable it before trying to load file:// URLs in the tests, so that it won't break once we build against the R SDK. Bug: 1106471 Change-Id: I863ffefcf2eec947062e2e99f2e40e60ec452fbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316400Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Richard Coles <torne@chromium.org> Cr-Commit-Position: refs/heads/master@{#791826}
-
Raymond Toy authored
The audio thread reads the looping parameters (looping, start, and end) possibly many times while rendering the data. The main thread can modify any of these at any time. This is a race. To eliminate the race, modify the setters for looping, loop start, and loop end to add a mutex for the process lock so that the main thread can't modify these until audio thread is finished processing. Bug: 1107500 Change-Id: Ied5cfb35cfb91e7982dc68e694dead09b1c74aa2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2306555 Commit-Queue: Raymond Toy <rtoy@chromium.org> Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Cr-Commit-Position: refs/heads/master@{#791825}
-
Tarun Bansal authored
Also, remove some of the resource loading hints tests that are not needed or are covered by Defer browser tests Change-Id: I9a812a29952ca4c6753627ffedd7b27655e71652 Bug: 1089371,1089208,1089207,1089118,1088701 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316835Reviewed-by:
Sophie Chang <sophiechang@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#791824}
-
Kevin Ellis authored
Change-Id: I99a11b123e46c43fd59ee04b0a8e3c916cdbeae4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317847 Commit-Queue: Kevin Ellis <kevers@chromium.org> Reviewed-by:
-
Adithya Srinivasan authored
This reverts commit 8b10bc20. Reason for revert: camera.CCAUISanity.fake is failing again: https://ci.chromium.org/p/chromium/builders/ci/chromeos-kevin-rel/27932 Original change's description: > Reland "Do not expose media devices before a successful getUserMedia()" > > This reverts commit 69a60019. > > chrome-prefixed URLs are exempted from the getUserMedia() requirement. > > Original change's description: > > Revert "Do not expose media devices before a successful getUserMedia()" > > > > This reverts commit d64e736a. > > > > Reason for revert: Caused chrome_all_tast_tests / camera.CCAUISanity.fake failures; e.g. https://ci.chromium.org/p/chrome/builders/ci/chromeos-betty-pi-arc-chrome/7680 > > > > Original change's description: > > > Do not expose media devices before a successful getUserMedia() > > > > > > This is a spec-compliance change. > > > > > > This CL also adds some improvements to the blink MediaDevices unit test. > > > > > > Bug: 1101860 > > > Change-Id: If2e7824df3b3dbd3cdb80f4bcf6b5c417d6f0ef2 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2279808 > > > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > > > Reviewed-by: Harald Alvestrand <hta@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#786253} > > > > TBR=hta@chromium.org,guidou@chromium.org > > > > Change-Id: I41b676c7d3e437c06d23f2b46270453f1cc81670 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1101860 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288282 > > Reviewed-by: Mohsen Izadi <mohsen@chromium.org> > > Commit-Queue: Mohsen Izadi <mohsen@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#786615} > > TBR=mohsen@chromium.org,hta@chromium.org,guidou@chromium.org > > # Not skipping CQ checks because this is a reland. > > Bug: 1101860 > Change-Id: I3fb6d9a620291cda57eb5fe48ce330b45425a5bc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289833 > Commit-Queue: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Guido Urdaneta <guidou@chromium.org> > Reviewed-by: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791797} TBR=shik@chromium.org,hta@chromium.org,guidou@chromium.org,wtlee@chromium.org Change-Id: I6b18c308de10dc5e5251025fd887892ecfef938b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1101860 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320081Reviewed-by:
-
Miguel Casas authored
This CL flips the FeatureFlag to be enabled by default. Bug: 958166 Change-Id: I75edaccca252c3bcb87d8550b6b6350348000022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317569Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#791821}
-
Alex Rudenko authored
Previously, `TrackSizesForComputedStyle` was used incorrectly because it didn't account for paddings and borders. This CL changes that to using `ColumnPositions`/`RowPositions` instead. Bug: 1105808 Change-Id: I5bb0994dfb670ae2d43641f8a576a4acf43dd369 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317225 Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Reviewed-by:
Oriol Brufau <obrufau@igalia.com> Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Reviewed-by:
Brandon Goddard <brgoddar@microsoft.com> Cr-Commit-Position: refs/heads/master@{#791820}
-
Garrett Beaty authored
This reverts commit bb13d209. Reason for revert: Get back to normal Original change's description: > Throttle submits from the CQ. > > There is likely to be a large backlog of CLs to submit that built up > during the network outage. Throttling the submits that land will prevent > large blamelists for CI runs. > > Bug: 1108842 > Change-Id: I117c89082640bb30daf12b2bf5daa2e1b25c323f > No-Try: true > No-Tree-Checks: true > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317760 > Auto-Submit: Garrett Beaty <gbeaty@chromium.org> > Reviewed-by: Erik Staab <estaab@chromium.org> > Reviewed-by: Ben Pastene <bpastene@chromium.org> > Commit-Queue: Erik Staab <estaab@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791308} TBR=estaab@chromium.org,bpastene@chromium.org,gbeaty@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1108842 Change-Id: I17dcb58de486345e71c0551fb9d2501cc259a1dc No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320069 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
-
Maksim Ivanov authored
Add more browser tests for the CryptohomeKeyDelegate D-Bus service implementation, for various scenarios when of parameters being missing or malformed. Bug: 1033936 Change-Id: Ifa6a2fd337b5ccc1011813814796e7a6b84b2edc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2318065Reviewed-by:
Fabian Sommer <fabiansommer@chromium.org> Commit-Queue: Maksim Ivanov <emaxx@chromium.org> Cr-Commit-Position: refs/heads/master@{#791818}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ec788be8b577..522fd1e551b2 2020-07-27 fmalita@chromium.org Fix SkottieKit font loading If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC borenet@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: borenet@google.com Change-Id: I6942d4460de029e8a8e34a7d3c7675633d43974c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320186Reviewed-by:
-
Roman Sorokin authored
TBR=gambard@chromium.org Bug: 1109202 Change-Id: Ifdf188c159c8ee8a672886b6de3c98c04c3e4a61 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320273Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#791816}
-
Oriol Brufau authored
In https://github.com/w3c/csswg-drafts/issues/4206, the CSSWG resolved that the 'text-transform' property should apply to ::marker, and that by default it should be set to 'none' in the UA stylesheet. This patch implements these changes. Note that setting it to 'none' is an observable change in LayoutNG, since it prevents the ::marker from inheriting the 'text-transform' of the list item. This was considered a better behavior by the CSSWG, and it's the behavior that legacy layout already had. LayoutListMarker, used for ::marker with 'content: normal' in legacy layout, doesn't implement the marker text as actual text. Therefore, 'text-transform' has no effect. Bug: 1031667 TEST=external/wpt/css/css-pseudo/marker-default-styles.html TEST=external/wpt/css/css-pseudo/marker-text-transform-default.html TEST=external/wpt/css/css-pseudo/marker-text-transform-uppercase.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties-in-animation.html TEST=external/wpt/css/css-pseudo/parsing/marker-supported-properties.html TEST=http/tests/devtools/elements/styles-2/pseudo-elements.js Change-Id: I2c2b554f521139fabb502856fedc6230aa45c787 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315872Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#791815}
-
Roman Sorokin [CET] authored
This reverts commit 706a5c51. Reason for revert: Speculative revert for https://ci.chromium.org/p/chromium/builders/ci/Mac10.12%20Tests https://crbug.com/1109738 Original change's description: > [Nearby] Start discovery on discovery page > > This calls the DiscoveryManager interface from JS and listens for > discovered and lost devices to update the device list. The selected > device is then passed through to the confirmation-page. > > Bug: 1103190 > Change-Id: I9296e5449533eb869fd9f20fe442d4ac1bc05a42 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315862 > Commit-Queue: Richard Knoll <knollr@chromium.org> > Reviewed-by: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#791591} TBR=mvanouwerkerk@chromium.org,knollr@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1103190 Change-Id: I80a3d398897ca3f77b41f0d72012d1039773583c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320272Reviewed-by:
-
