Commits · 05e96dcac622a426157d3450591ad13bf8cce1f0 · eriksson monteiro / tangled

03 Mar, 2020 40 commits

Remove unused scrollable behavior from edit printer dialog · 05e96dca

Jimmy Gong authored Mar 03, 2020

- The scrollable behavior is not used for this dialog as the
  items in the list do not require updates.
- Fixes a bug where two scrolls bars are visible when zoomed in.

Bug: 1055733
Change-Id: Ib28babbf5dbdf3aedf5bff4aec7875918de997d9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083056Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Commit-Queue: jimmy gong <jimmyxgong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746266}

05e96dca

Introduce ResourceSnapshotForWebBundle and implement in renderer process · f8d1efb7

Tsuyoshi Horo authored Mar 03, 2020

This CL introduces ResourceSnapshotForWebBundle mojo interface and
GetResourceSnapshotForWebBundle() method in LocalFrame mojo interface.
This method will be used to create a web bundle file.
Design Doc: https://docs.google.com/document/d/1O1fH7ev2NwRqOVd_WjEtv4JaI6fA4x6G3ogfz6Hi9Pc/edit#
This is the working-in-progress CL: https://crrev.com/c/1994848
  - The browser process will call GetResourceSnapshotForWebBundle()
    to get the Mojo endpoint of the interface.
  - The browser process will pass the Mojo endpoint to the utility
    (data decoder) process.
  - The utility process will calls the methods of the interface using
    the passed Mojo endpoint, and will generate a Web Bundle file.

Basically this CL implements GetResourceSnapshotForWebBundle() method
using the existing page serialization logic for MHTML generation.
For web bundle generation, we need to change the serialization logic:
  - Subframe URL replacement
  - Style element URL replacement
  - Shadow DOM support
But this CL doesn't implement the web bundle specific logic.
We will create another CL to implement them.

Bug: 1040752
Change-Id: Ia7470de2cd1e418d8bc2d393f5136042145f62d7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2060360Reviewed-by: Robert Sesek <rsesek@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Tsuyoshi Horo <horo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746265}

f8d1efb7

[style_var_gen] Integrate into OS Settings. · a8b24c14

Christopher Lam authored Mar 03, 2020

This CL replaces cros_colors and cros_palette the new JSON5 generated
color format.

This CL also adds GN generation targets and plumbs the generated CSS
file through to OS Settings.

Bug: 1018654
Change-Id: I5ef6b3f76c48aa59eac54163b085cd555b18369a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2035483
Commit-Queue: calamity <calamity@chromium.org>
Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746264}

a8b24c14

Change functions Next() in file_system/ to use base::Optional<url::Origin>. · 39db88fd

Zhuoyu Qian authored Mar 03, 2020

This CL update the functions SandboxFileSystemBackendDelegate::Next and
ObfuscatedFileUtil::Next to use dedicated Origin type instead of GURL.

Bug: 598424
Change-Id: Ib48ef509f171906bffa38f643f573aa647874831
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2007321
Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com>
Reviewed-by: Victor Costan <pwnall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746263}

39db88fd

Rename webkit_layout_tests to blink_web_tests · aab16fc0

John Chen authored Mar 03, 2020

Rename test webkit_layout_tests to blink_web_tests, and update
related tools and docs.

Bug: 914213
Change-Id: I13031dee55409da093f8450db834c3c4595f579e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2040050
Commit-Queue: John Chen <johnchen@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746262}

aab16fc0

Roll src/third_party/webrtc d084ea93b6c9..83762b21dbd2 (1 commits) · 4944fbd5

chromium-autoroll authored Mar 03, 2020

https://webrtc.googlesource.com/src.git/+log/d084ea93b6c9..83762b21dbd2

git log d084ea93b6c9..83762b21dbd2 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 deadbeef@webrtc.org Use NetworkToHost32 instead of HostToNetwork32 to translate PPID.

Created with:
gclient setdep -r src/third_party/webrtc@83762b21dbd2

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Ic2665c9cb248b27f2f6fc97013d0ae964dbdc28c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084103Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746261}

4944fbd5

Rename LookalikeUrlInterstitialPage to LookalikeUrlBlockingPage · d9bca519

Livvie Lin authored Mar 03, 2020

Match the naming convention of SSL blocking pages for consistency.

Design doc: go/security-interstitial-cleanup

Bug: 1042467
Change-Id: Ie6f26e8f5494bfcbdc3cd7a76e99dbd967f74dc4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076759Reviewed-by: Joe DeBlasio <jdeblasio@chromium.org>
Reviewed-by: Mustafa Emre Acer <meacer@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Livvie Lin <livvielin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746260}

d9bca519

usb_ids: Explicit ASCII, ignore codec errors · 7dc570ba

Raul Tambre authored Mar 03, 2020

Specify the defaults of Python 2 explicitly, so it also works on Python 3.
Need to use codecs.open() because Python 2's open() doesn't support the "errors" argument.

Traceback (most recent call last):
  File "../../services/device/public/cpp/usb/tools/usb_ids.py", line 90, in <module>
    table = ParseTable(opts.input)
  File "../../services/device/public/cpp/usb/tools/usb_ids.py", line 20, in ParseTable
    input = input_file.read().split("\n")
  File "C:\Program Files\Python38\lib\codecs.py", line 322, in decode
    (result, consumed) = self._buffer_decode(data, self.errors, final)
UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb4 in position 544490: invalid start byte

Bug: 941669
Change-Id: Ie0789d68d574b7baa5c31d81ae846773630cd7b7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082511
Auto-Submit: Raul Tambre <raul@tambre.ee>
Reviewed-by: Ken Rockot <rockot@google.com>
Commit-Queue: Raul Tambre <raul@tambre.ee>
Cr-Commit-Position: refs/heads/master@{#746259}

7dc570ba

Refactor the session managers by using SessionManagerObserver · 63964fe6

Anqing Zhao authored Mar 03, 2020

Use a new class 'UserSessionInitializer' to handle common initialization
logics in 'ChromeSessionManager' and 'UserSessionManager'. Whenever
profiles are loaded, corresponding methods in the observer will be
triggered.

Bug: 977489
Change-Id: I24259636906d80cfbec48268eb0c68aa851a4df7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2044278
Commit-Queue: Anqing Zhao <anqing@google.com>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746258}

63964fe6

Refactor SmbCredentialsDialog::Show() to respond with a callback · b2c2977e

Anand K. Mistry authored Mar 03, 2020

Also change |mount_id| to be a string to accommodate smbfs. Oh, and add
a browser test.

Bug: 1054704

Change-Id: I7c5b8eee7886093cde6b0088de489f8f91fb8084
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076862
Commit-Queue: Anand Mistry <amistry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746257}

b2c2977e

Rename an old referrer policy value · 361353df

Dominic Farolino authored Mar 03, 2020

This CL renames kNoReferrerWhenDowngradeOriginWhenCrossOrigin to
kStrictOriginWhenCrossOrigin. It was generated via the following:

git grep -l 'kNoReferrerWhenDowngradeOriginWhenCrossOrigin' | \
    xargs sed -i '' -e 's/kNoReferrerWhenDowngradeOriginWhenCrossOrigin/kStrictOriginWhenCrossOrigin/g'

R=estark@chromium.org, jochen@chromium.org

Bug: N/A
Change-Id: Iead49f11e74852d2b08cdf60c04f948d5910d642
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082856Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Emily Stark <estark@chromium.org>
Commit-Queue: Dominic Farolino <dom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746256}

361353df

WebUI Tab Strip: Support dropping a group into place · 7b0b7a6a

John Lee authored Mar 03, 2020

When a drag enters with tab group data from another window, the tab
strip will create a placeholder TabGroupElement and use it to move
elements around.

Bug: 1048894
Change-Id: I9a93996745bae6b56f47851a906efd4243d174cb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076762
Commit-Queue: John Lee <johntlee@chromium.org>
Reviewed-by: dpapad <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746255}

7b0b7a6a

bindings: Include v8_dict.h for generated dictionaries · 34299f0f

Hitoshi Yoshida authored Mar 03, 2020

Updates included files of IDL dictionaries from {component}/xxx/foo.h
to bindings/{component}/v8/v8_foo.h for coming new code generator.


Bug: 839389
Change-Id: I9f3f1c88dc6dfc2b4dd278f0038c753ae5834b4f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083779
Commit-Queue: Hitoshi Yoshida <peria@chromium.org>
Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746254}

34299f0f

Use AppServiceAppIconLoader to load icons for ARC apps. · dc1a0243

nancy authored Mar 03, 2020

This is the preparing for removing ArcAppIconLoader.
AppServiceAppIconLoader is used to replace ArcAppIconLoader to load app
icons for all apps.

AppServiceAppIconLoader doesn't call OnAppImageUpdated to update for
the default icon, so remove the DCHECK.

Fix the browser tests, because AppService uses mojom, so add run loop to
to wait AppService to load the app.

BUG=10161599

Change-Id: Ifbd799911016c386fb9b3b34bfd98bffbd5d9c75
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081635
Commit-Queue: Nancy Wang <nancylingwang@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746253}

dc1a0243

Roll src-internal e92ada58142f..042cbe61eee3 (10 commits) · abafda3c

chromium-internal-autoroll authored Mar 03, 2020

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e92ada58142f..042cbe61eee3


Created with:
  gclient setdep -r src-internal@042cbe61eee3

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: None
Tbr: jbudorick@google.com
Change-Id: I42263810cb2e9d4bc2934fa57de83056ab5c719a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082919Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746252}

abafda3c

crostini: Add basic UI for Crostini Mic settings · b7dbd5ef

danielng authored Mar 03, 2020

Adding basic UI elements as outlined in the PRD attached to the bug.
Note that these are not final, or to spec (as no spec exists yet),
and it is all behind an experimental flag.

Bug:1016193

CQ-DEPEND=CL:2079711

Change-Id: I6ec7fee8247342688d883e7ad6d0c6a05940cb25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079718
Commit-Queue: Daniel Ng <danielng@google.com>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Julian Watson <juwa@google.com>
Cr-Commit-Position: refs/heads/master@{#746251}

b7dbd5ef

Roll src/third_party/skia 777e146564b4..8121d27b297c (29 commits) · fb5247f0

chromium-autoroll authored Mar 03, 2020

https://skia.googlesource.com/skia.git/+log/777e146564b4..8121d27b297c

git log 777e146564b4..8121d27b297c --date=short --first-parent --format='%ad %ae %s'
2020-03-03 mtklein@google.com stick to 256-bit ymm on skx
2020-03-02 mtklein@google.com allow FMA discovery
2020-03-02 senorblanco@chromium.org Dawn: increase maximum texture size in caps to 8192.
2020-03-02 fmalita@chromium.org [skottie] Text anchor point grouping support
2020-03-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-03-02 bsalomon@google.com Prevent unbounded listener growth on SkPixelRefs.
2020-03-02 mtklein@google.com hoist1
2020-03-02 mtklein@google.com auto-detect MCPU
2020-03-02 benjaminwagner@google.com [infra] Upgrade iPhone6 to iOS 12.4.5
2020-03-02 mtklein@google.com basic hoisting
2020-03-02 robertphillips@google.com Revert "Add onPrePrepareDraws & createProgramInfo methods to GrDrawVerticesOp"
2020-03-02 mtklein@google.com noalias for params, inbounds for GEPs
2020-03-02 reed@google.com remove bones from SkVertices
2020-03-02 robertphillips@google.com Add onPrePrepareDraws & createProgramInfo methods to GrDrawVerticesOp
2020-03-02 jvanverth@google.com Fill in most D3DCaps texture property queries.
2020-03-02 brianosman@google.com Restore logic to check for .git in ANGLE BUILD.gn
2020-03-02 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).
2020-03-02 csmartdalton@google.com Add a bindBuffers() call to GrOpsRenderPass
2020-03-02 rmistry@google.com [Tree Status] Update all references in Skia repo to tree-status
2020-03-02 scroggo@google.com SkJpegCodec: Gracefully handle malloc failure
2020-03-02 bsalomon@google.com Avoid unbounded listener growth on SkImage_Lazy when textures are purged
2020-03-02 borenet@google.com [recipes] Move DM flags logic into gen_tasks_logic/dm_flags.go
2020-03-02 nifong@google.com Patch public.bzl change from cl/298337962
2020-03-02 brianosman@google.com (Manual) Roll third_party/externals/angle2 4dc19c38c0c5..ff60abaf62b4 (51 commits)
2020-03-02 csmartdalton@google.com Reland "Move setupGeometry() from GrGLGpu to GrGLOpsRenderPass"
2020-03-02 fmalita@chromium.org [skottie] Stroke dash support
2020-03-02 robertphillips@google.com Standardize behavior of ops that implement onPrePrepare
2020-03-02 jlavrova@google.com Bugs: skia: 9968
2020-03-02 borenet@google.com [recipes] Reland DM recipe changes with fix

Created with:
gclient setdep -r src/third_party/skia@8121d27b297c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC herb@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: herb@google.com
Change-Id: I4183f95c25f7725aa678f4116950b69c60c6a9bc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084092Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746250}

fb5247f0

Move the contents of ShowPopup() and HidePopup() from HTMLSelectElement to SelectType · 2de8f40e

Kent Tamura authored Mar 03, 2020

HTMLSelectElement still needs these functions because accessibility code
and testing code call them.

This CL has no behavior changes.

Bug: 1052232
Change-Id: Id34b9fa50138ed2193d57eadaa80f43206c87e60
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082226Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746249}

2de8f40e

media/gpu/vaapiVEA: Do not log framerate and bitrate if they don't vary · 9343964e

Hirokazu Honda authored Mar 03, 2020

RequestEncodingParametersChange() can configure the same
bitrate and framerate as the last configured values.
Since VaapiVieoEncodeAccelerator logs them every
RequestEncodingParametersChange(), it floods chrome logging.

As we are not interested in the unchanged values, this CL makes
VaapiVEA log the framerate and bitrate only if they vary.

Bug: None
Test: appr.tc/?vsc=h264&debug=loopback
Change-Id: Ie0354bc92b919c2bfcb4d2131de29e8e2736a4ca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082741Reviewed-by: Andres Calderon Jaramillo <andrescj@chromium.org>
Commit-Queue: Hirokazu Honda <hiroh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746248}

9343964e

Add event latency to compositor latency metrics · a52ab64c

Mohsen Izadi authored Mar 03, 2020

If handling of an event leads to producing a compositor frame, an UMA
histogram is recorded measuring the time between the event timestamp and
presentation of the corresponding frame to the screen, in the form of
"EventLatency.<EventType>.TotalLatency". In future, we will add
appropriate break-down metrics, too.

Bug: 1054007

Change-Id: If85f99fb83172337c21b374073a3c2d098c2fd50
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018704Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org>
Reviewed-by: Behdad Bakhshinategh <behdadb@chromium.org>
Commit-Queue: Mohsen Izadi <mohsen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746247}

a52ab64c

Reland "bind-gen: Implement V8DOMConfiguration::InstallConstants" · 63fffe25

Yuki Shiino authored Mar 03, 2020

This is a reland of 783ef8ee

Original change's description:
> bind-gen: Implement V8DOMConfiguration::InstallConstants
> 
> Implements V8DOMConfiguration::InstallConstants for context-
> dependent property installation.
> 
> Bug: 839389
> Change-Id: I3f67010e247ff4b1719cafec37b0865c9e05aa75
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081729
> Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
> Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#745959}

Bug: 839389
Change-Id: I39fabb9ea119b2c40d87ea8f9478f23c543290ec
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083778Reviewed-by: Hitoshi Yoshida <peria@chromium.org>
Commit-Queue: Yuki Shiino <yukishiino@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746246}

63fffe25

Roll src/third_party/depot_tools 4576851428dd..a3b6fd06f9d7 (1 commits) · 0d32a4e8

chromium-autoroll authored Mar 03, 2020

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/4576851428dd..a3b6fd06f9d7

git log 4576851428dd..a3b6fd06f9d7 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 ehmaldonado@google.com Reland "my_activity.py: Run using vpython3 by default."

Created with:
  gclient setdep -r src/third_party/depot_tools@a3b6fd06f9d7

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/depot-tools-chromium-autoroll
Please CC agable@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: agable@chromium.org
Change-Id: I4bd4f5c6cff0dd17afc492eb70cf2d2b8536f2cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083810
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746245}

0d32a4e8

Add TPM version string for Cr50 0.4.26 · 29727d18

Mary Ruthven authored Mar 03, 2020

The python script attached to the bug was used to generate version
strings for all images.

BUG=chromium:728134
TEST=None

Change-Id: I1618d7307b25acd0ccfa7b81d5bd67147ded2260
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083926Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Mary Ruthven <mruthven@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746244}

29727d18

Roll src/third_party/angle 35785308a451..80f55e974204 (5 commits) · 312d2ac9

chromium-autoroll authored Mar 03, 2020

https://chromium.googlesource.com/angle/angle.git/+log/35785308a451..80f55e974204

git log 35785308a451..80f55e974204 --date=short --first-parent --format='%ad %ae %s'
2020-03-03 jmadill@chromium.org Expose glGetInteger64vEXT.
2020-03-02 lexa.knyazev@gmail.com Add OES_draw_buffers_indexed autogenerated wrappers and validation redirects.
2020-03-02 geofflang@google.com Add scripts for rolling and generating Android.bp for AOSP
2020-03-02 tobine@google.com Vulkan:Disable FramebufferVk cache on Apple
2020-03-02 geofflang@google.com Change commit_id 'check' back to looking for .git files.

Created with:
gclient setdep -r src/third_party/angle@80f55e974204

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/angle-chromium-autoroll
Please CC ianelliott@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: ianelliott@google.com
Change-Id: Ib3254a0c0272fa7c88cccd8e29f498ba6dcf951c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083930Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746243}

312d2ac9

Roll src/third_party/shaderc/src 1059f43a379f..06b6db68ff7e (1 commits) · 2bc67895

chromium-autoroll authored Mar 03, 2020

https://chromium.googlesource.com/external/github.com/google/shaderc/+log/1059f43a379f..06b6db68ff7e

git log 1059f43a379f..06b6db68ff7e --date=short --first-parent --format='%ad %ae %s'
2020-03-02 rharrison@google.com Rolling 6 dependencies and updating expectations (#990)

Created with:
gclient setdep -r src/third_party/shaderc/src@06b6db68ff7e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/shaderc-chromium-autoroll
Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: radial-bots+chrome-roll@google.com
Change-Id: Idb6968073363fc86cfd8e9d597bd4a9c203f4d0b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083795Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746242}

2bc67895

DNR: Update documentation for generic priorities · f8f6786b

Theodore Dubois authored Mar 03, 2020

R=karandeepb@chromium.org

Bug: 1026733
Bug: 1042650
Change-Id: I37da28a4e02d6eed97ba1b458b68803fa95084b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026932
Commit-Queue: Theodore Dubois <tbodt@google.com>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Auto-Submit: Theodore Dubois <tbodt@google.com>
Cr-Commit-Position: refs/heads/master@{#746241}

f8f6786b

Add UMAs for terminal settings changes · e8fb2509

Joel Hockey authored Mar 03, 2020

We will record which settings have been changed from
defaults each time settings are fetched.

Bug: 1056444
Change-Id: Iea61d82f9d440e05d11785490d01657b207fd7fc
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082416Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746240}

e8fb2509

Roll src/third_party/webrtc f52d3ed084e3..d084ea93b6c9 (2 commits) · 6ee1b68d

chromium-autoroll authored Mar 03, 2020

https://webrtc.googlesource.com/src.git/+log/f52d3ed084e3..d084ea93b6c9

git log f52d3ed084e3..d084ea93b6c9 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 kwiberg@webrtc.org BoundedInlineVector: Add resize() method
2020-03-02 kwiberg@webrtc.org BoundedInlineVector: Vector class of bounded size with inline allocation

Created with:
gclient setdep -r src/third_party/webrtc@d084ea93b6c9

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: None
Tbr: webrtc-chromium-sheriffs-robots@google.com
Change-Id: Id3abecfe68e68261cfc8b6b651a62d70c1adb504
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083928Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746239}

6ee1b68d

Update V8 to version 8.2.231. · 3540a78e

v8-ci-autoroll-builder authored Mar 03, 2020

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/93969500..aa1b2c63

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: I4a27c7cfec10f3e911cd6ed5790d246fadd8b823
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083656Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746238}

3540a78e

Adding CPEs for a few dependencies. · 0a06ec3a

Adrian Taylor authored Mar 03, 2020

CPEs are the way that MITRE tracks different projects and versions, and
that's the input required by Vomit, Google's automated vulnerability
notification system. At present Vomit is unable to identify the versions
for these components and is therefore reporting the wrong CVEs in crbugs.

Adding this CPEPrefix line will enable Vomit to notify for any
vulnerabilities affecting these versions.

This is the first such change to README.chromium files. If successful,
CPEPrefix lines will be added to many others too.

Bug: 895969
Change-Id: Ibec5adf9069cdc20e40fb13658e7b056e938f5ce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2053847Reviewed-by: Charlie Reis <creis@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Adrian Taylor <adetaylor@chromium.org>
Auto-Submit: Adrian Taylor <adetaylor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746237}

0a06ec3a

Fix test flake for Crostini settings page. · 586bdb30

Nicholas Verne authored Mar 03, 2020

The flake was in the setting page's existence test for the
"Upgrade Available" section. The existence is determined by a value that
is initialized from loadTimeData and updated from a webUIListener.

There was a race between loadTimeData's default "true" value and the
webUIListenerCallback's replacement "false" which would change right
when the page was loading, so the settings test would see the
occasional "false" instead of expected "true" and fail.

Bug: 1057823
Change-Id: I3822eda06c5631c2328f80891f9f5e5de4821172
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083773
Commit-Queue: Nicholas Verne <nverne@chromium.org>
Auto-Submit: Nicholas Verne <nverne@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746236}

586bdb30

Update Crashpad to 3c573b54ae138c81c0224f22b38f5d439b56f9a1 · 563d1e4d

Justin Cohen authored Mar 03, 2020

9ed829054711 Bring up skeleton crashpad_client_ios
22701bb0e448 fuchsia: Use zx_system_get_version_string
f79cba47ba0d [lsan][crashpad] Suppress leak sanitizer on crashpad_test
0c20aeabd37a [UBSan] Temporarily disable UBSan for snapshot and minidump
d632f625a2f2 Fix a Wrange-loop-analysis warning in crashpad
8bad6f140e0b [UBSan] Temporarily disable UBSan for gtest and file
11b8eb10d4ad Don’t use the disappearing MSVC_PUSH_DISABLE_WARNING()
             macro
3c573b54ae13 [ios] Fix iOS device build

Change-Id: Icaa0526b9d2b070ac0a70f6f3bfeca319b077ce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081530
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746235}

563d1e4d

Use new downcast helper for blink::LoadableTextTrack · 0b063634

Abhijeet Kandalkar authored Mar 03, 2020

This CL has two goals,
  1. Use To<LoadableTextTrack> and DynamicTo<LoadableTextTrack> as new
     downcast helper
  2. Use IsA<LoadableTextTrack>(element) in place of
     IsLoadableTextTrack(element)

Bug: 891908
Change-Id: I1b96f72a9904c8a64813f14d085f42e16c2e8628
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018352Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com>
Cr-Commit-Position: refs/heads/master@{#746234}

0b063634

WebUI Tab Strip: Keep new tab button fixed · ac74713f

John Lee authored Mar 03, 2020

The tab strip's height can change while it is animating in and out
but its final height is the sum of var(--tabstrip-tab-height) and
2 of var(--tabstrip-tab-list-vertical-padding). Hard-coding the top
value of the new tab button to 50% of this ensures the button stays
fixed in the middle of the tab strip, even if the height is being
animated.

Change-Id: I555052195eaf7e2c97b212817debd73093f6d630
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076543Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746233}

ac74713f

crostini: use async in page tests · 6fbd33d2

Julian Watson authored Mar 03, 2020

Bug: None
Change-Id: I2ffbdec3ccf5fc94118e2080df159bc78869c711
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084034
Commit-Queue: Julian Watson <juwa@google.com>
Auto-Submit: Julian Watson <juwa@google.com>
Reviewed-by: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746232}

6fbd33d2

Roll src/third_party/swiftshader a4347a9460bb..176f3a3dbbc9 (1 commits) · a6ba460f

chromium-autoroll authored Mar 03, 2020

https://swiftshader.googlesource.com/SwiftShader.git/+log/a4347a9460bb..176f3a3dbbc9

git log a4347a9460bb..176f3a3dbbc9 --date=short --first-parent --format='%ad %ae %s'
2020-03-02 swiftshader.regress@gmail.com Regres: Update test lists @ 416d3745

Created with:
gclient setdep -r src/third_party/swiftshader@176f3a3dbbc9

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I9478ddb684bb2e88a6d61216a65e8ebb291a0eba
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083719Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746231}

a6ba460f

Settings: Port reset_page/ to Polymer 3. · 0818aabf

dpapad authored Mar 03, 2020

Bug: 1026426
Change-Id: Id544fa55788bb17899758d0d5f7298367a49eb47
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2078823
Commit-Queue: dpapad <dpapad@chromium.org>
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Auto-Submit: dpapad <dpapad@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746230}

0818aabf

Roll src/third_party/perfetto fc12e7fd7eb8..df7c402d99bc (3 commits) · d607f692

chromium-autoroll authored Mar 03, 2020

https://android.googlesource.com/platform/external/perfetto.git/+log/fc12e7fd7eb8..df7c402d99bc

git log fc12e7fd7eb8..df7c402d99bc --date=short --first-parent --format='%ad %ae %s'
2020-03-02 primiano@google.com UI: use window.open for legacy catapult and reland CSP
2020-03-02 ilkos@google.com Merge "Revert "Cleanup startup: remove CPU ratio""
2020-03-02 lalitm@google.com tp: fix startup metric to look at slice tables

Created with:
gclient setdep -r src/third_party/perfetto@df7c402d99bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

Bug: chromium:149573396,chromium:150605504
Tbr: perfetto-bugs@google.com
Change-Id: Ibfb4218523e97913d9aae8f66443531be79bf4a5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083925Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#746229}

d607f692

Enable gn check for //chrome/elevation_service/*. · e76078f7

Sorin Jianu authored Mar 03, 2020

The empty line is due to git cl format.

Change-Id: Ifd3d8f1d8f7b3290e8c839affe3d181732d3d4b8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082022
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746228}

e76078f7

Add chrome.inputMethodPrivate.hideInputView() · 9a822b4d

Tetsui Ohkubo authored Mar 03, 2020

This CL adds a method to explicitly close the virtual keyboard.
It will be used from Tast's Chrome ResetState function.

Tast side CL: https://crrev.com/c/2071552

TEST=tast run arc.ChromeVirtualKeyboard
BUG=None

Change-Id: Iffb9fb1f9b9e5059b38d3315f9d135d23624a479
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071549
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Reviewed-by: Keith Lee <keithlee@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#746227}

9a822b4d