- 27 Jan, 2020 40 commits
-
-
Rushan Suleymanov authored
Add switch to fallback to default latency value. Bug: 1034928 Change-Id: I5b4bf1bb5e3d80ab854b1c6b9758c4c06c26152f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022765Reviewed-by:
vitaliii <vitaliii@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#735387}
-
Takashi Toyoshima authored
After the last cleanup, https://chromium-review.googlesource.com/c/chromium/src/+/2007285, syntax check for policy template does not work as the newly related ArgumentParser does not support taking type='string'. Bug: 1032064 Change-Id: I2d0f87781f402bbf3867590ceeed8147743c4d71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022025 Auto-Submit: Takashi Toyoshima <toyoshim@chromium.org> Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Alexander Hendrich <hendrich@chromium.org> Cr-Commit-Position: refs/heads/master@{#735386}
-
Xida Chen authored
Bug: 1042205 Change-Id: Iac11eb940802a21ef012adc92f33fc880a3d3922 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022727Reviewed-by:
Yi Gu <yigu@chromium.org> Commit-Queue: Xida Chen <xidachen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735385}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/995992bed045..0deb202d1620 Created with: gclient setdep -r src-internal@0deb202d1620 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1042208 Tbr: jbudorick@google.com Change-Id: I24c0c4dab89b1cde5df3eada3ef0dad1f7c0426e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021968Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735384}
-
Andrew Solovey authored
Extract header ASCII graphic emitting code from [WriteAsciiImpl] to add more flexibility in style setup. Rename [WriteAsciiImpl] to [WriteAsciiBody] because the method writes histogram body content only. Extract newline string to constants to avoid multiple initialization. R=sinhak@google.com Bug: 1006447 Change-Id: Ie03ac7d2ee5a6a412f7e0f26f179d81728b5b2c4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1971927Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Andrei Salavei <solovey@google.com> Cr-Commit-Position: refs/heads/master@{#735383}
-
Nohemi Fernandez authored
Re-enables the 'ClearSyncData' feature reverted in change 2020323. Fixes the DCHECK errors due to incomplete URLs in tests and uses the ScopedFeatureList to enable the experimental flag that is compatible with both EarlGrey 1 and 2. Bug: 1005509 Change-Id: Ib300eb8d89e125e9bfa26045b41f59209228ac85 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019362Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#735382}
-
Yi Gu authored
The test is flaky on all platforms. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2FuaW1hdGlvbi13b3JrbGV0L2lkbGhhcm5lc3MuYW55Lmh0bWwM Bug: 1045329 Change-Id: I8b324dcf7585408cd8f9867a07a3a31423606643 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021969Reviewed-by:
Xida Chen <xidachen@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#735381}
-
Matt Menke authored
This reverts commit 966cd90b. Reason for revert: Turns out that we are actually starting to listen synchronously, since that call doesn't go over mojo, so this didn't accomplish anything. Original change's description: > network::HttpServer tests: Wait for the HttpServer to start listening. > > The tests use an HttpServer run over a Mojo connection, but they don't > ensure that the HttpServer has started listening for connections before > trying to establish a connection to the server over a client socket > (also used over Mojo). The tests seem to be passing, but it sometimes > times out on Fuchsia, when the HttpServer tries to accept a second > socket. This seems likely due to some other bug (possibly in the > Fuchsia socket layer), but regardless of the underlying cause, having > the test fixture wait for the server to start listening seems to make > the test consistently pass, and is something the tests should be doing > anyways. > > Bug: 1032620 > Change-Id: I48b57e99923189496d4e405f84a22767ca42a68a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1992205 > Reviewed-by: Maksim Orlovich <morlovich@chromium.org> > Commit-Queue: Matt Menke <mmenke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#729477} TBR=mmenke@chromium.org,morlovich@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1032620 Change-Id: I45c8283101306e5627d9b696f176a2d357dfff69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019790Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735380}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f78f1881..3c2484f8 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I99babe02045b7b979c968c3cbb7ef7609131e4b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022323Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735379}
-
Andrew Solovey authored
Add tests to check output format of the |WriteAscii| and |WriteHTMLGraph| methods for |SparseHistogram| class. Tests check that all components of the graph graphical representation are on there places: graph header, newline symbols, graph pillars with value description. Bug: 1006447 Test: browser_tests --gtest_filter="SparseHistogramTest" Change-Id: I6ab33d7848a105c1c3353d1c3b5852fbb2456a71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1980729Reviewed-by:
-
Gauthier Ambard authored
The computation for the edge insets used by the NTP to resize itself was using the fullscreen model which is updated too late to be used here. Instead, use directly the correct values. Fixed: 1044329 Change-Id: Ibfe84cbe9abecd516f222e0e1d12a3fe6f1f7ca1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019244Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Auto-Submit: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#735377}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/760fd5249488..9c0a83ea4dae git log 760fd5249488..9c0a83ea4dae --date=short --first-parent --format='%ad %ae %s' 2020-01-27 phoglund@webrtc.org Remove strip_absolute_paths_from_debug_symbols from mb. 2020-01-26 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 812b6f89..08a3245b (735202:735303) 2020-01-25 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision c0451968..812b6f89 (734489:735202) 2020-01-25 steveanton@webrtc.org Validate ICE ufrag/pwd according to the spec 2020-01-24 jamiewalch@chromium.org Include cursor rects in updated_region. 2020-01-24 kron@webrtc.org Revert "Reland "Reland "Distinguish between send and receive codecs""" 2020-01-24 saza@webrtc.org Reland "Change log level of AEC3 buffer info to VERBOSE" 2020-01-24 titovartem@google.com Add ability to set custom adapter type on emulated endpoint 2020-01-24 saza@webrtc.org Add parameterization for three multi channel AEC3 unit tests 2020-01-24 danilchap@webrtc.org Detach LossNotificationController from RtpGenericFrameDescriptor 2020-01-24 ivoc@webrtc.org Improvements for NetEqControllers 2020-01-23 kron@webrtc.org Reland "Reland "Distinguish between send and receive codecs"" Created with: gclient setdep -r src/third_party/webrtc@9c0a83ea4dae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1029737,chromium:1043325,chromium:1044521 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I91565c6c4053c0f827bda92f483b96796356085c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021965Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#735376}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/589b1875f6b6..60a3d848a8ca git log 589b1875f6b6..60a3d848a8ca --date=short --first-parent --format='%ad %ae %s' 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-loader/src 37d3a235af2c..310fb8617946 (1 commits) 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src b97057e7f747..1b3441036a8f (6 commits) 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 5ef91b82cbed..748ad200897b (6 commits) Created with: gclient setdep -r src/third_party/angle@60a3d848a8ca If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: I1daa7a2bd5b6e7615b6562ecabb039ce2d005e3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021963Reviewed-by:
-
Kenichi Ishibashi authored
Currently ServiceWorkeStorage depends on ServiceWorkerContextCore to schedule database error recovery (see the original design doc [1]). This dependency needs to be removed so that ServiceWorkerStorage can be moved to the Storage Service. In other words, we need to move ScheduleDeleteAndStartOver() to ServiceWorkerRegistry (see the related section of the refactoring plan [2]). This CL is the first CL to move scheduling DeleteAndStartOver() to ServiceWorkerRegistry. Specifically, this CL modifies GetUserData{,ByKeyPrefix}() so that we can call ScheduleDeleteAndStartOver() from ServiceWorkerRegistry. Subsequent CLs will do the same for other methods in ServiceWorkerStorage. [1] https://docs.google.com/document/d/1eXdgnAOZC4dDDybmRpXT0t0lOYGhFf7xajOSanEb91Y/edit#heading=h.kboaqpwv2bvf [2] https://docs.google.com/document/d/1PXg_8SKtXqfwcwTfJaPHMyUeZ4el92nU76jDbEMwkt4/edit#heading=h.hrlvq4dn719m Bug: 1039200 Change-Id: Ic91013a244538160a2600af6d9fe201358896003 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018625 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#735374}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/5f86e050c2e8..8fdda11ff772 git log 5f86e050c2e8..8fdda11ff772 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 tvanderlippe@chromium.org Add presubmit check to prevent checking in large files Created with: gclient setdep -r src/third_party/devtools-frontend/src@8fdda11ff772 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I84c1d276864c3cec2680c78b9b37978f7e2d543d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021966Reviewed-by:
-
David Jean authored
Keep them as already sorted (by locale use). Bug: 1043943 Change-Id: Iac9f5d75ed5dae5d917ab9c97f7442965a37a9b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022706Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#735372}
-
Wez authored
The //topaz/packages/sdk:topaz target appears to now be empty, so remove it from the build specification in local-sdk.py Change-Id: I71d02f7f7e2baf61db33bbfb26068deda3115669 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019367Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#735371}
-
David Roger authored
This CL removes a reference to diceEnabled in shouldShowProfile_. Additionally it removes dead code: on desktop this branch is only used when signin is disallowed and the user is signed out. The tests related to the signout button are converted to use the Dice flow. Bug: 891781 Change-Id: I227bdbce52c38c24920433d6b2c8d21a4c6f3bd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015247 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#735370}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5a0e94681cf8..995992bed045 Created with: gclient setdep -r src-internal@995992bed045 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib1210dd5ab16182614fdd71d19872f9416c4d4bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022613Reviewed-by:
-
Ross McIlroy authored
Removes the old 2016 system health stories that have been updated to 2018/9 recordings. Perf Sheriffs: This change will cause movement in metrics which track across the whole story set instead of individual stories. BUG=chromium:878390 Change-Id: I3504263c8f432fe6a26336f45d56775e08cd579a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012954 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#735368}
-
David Roger authored
Bug: 891781 Change-Id: I25eed43ab6bd1b0ead335b9246962932b5b2f4b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2014912Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#735367}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/ded3dd5b..f78f1881 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I059ca6e74659fafe673e0b6d46a9fa2974f713a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2021344Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I7488cb81c2e655dec6aaf630009030cb82bc3bbd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017507Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I1e39b9c33f4b1a99c713f560e10c5d759dd25b5f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017329Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: Ib956dacb9e2c63120faec9de2b485130903c87bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017522Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I2379c1b78e2088aa448ab50b2156c99f545d8139 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017363Reviewed-by:
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: Ia66d2e3144a30257a5056a5e027948e756bd4da7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017348Reviewed-by:
-
Colin Blundell authored
As one of the final steps in componentizing SSLErrorHandler for sharing with WebLayer, this CL introduces a //components-level SecurityBlockingPageFactory interface and has ChromeSecurityBlockingPageFactory derive from it. By doing so, SSLErrorHandler no longer needs to know about the embedder-level ChromeSecurityBlockingPageFactory. Bug: 1030692 Change-Id: If95f7d1871ff337f7aa252aa74291dc4fa89d3be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2019264 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#735360}
-
Eric Seckler authored
Replaces the KeyedServiceFactory::GetServiceForContext trace event with a typed trace event. Corresponding proto buffer definitions for these events were added in aosp/1180211. Typed trace events will allow inclusion of the event arguments in slow reports data in the future. The trace format is protocol-buffer based under the hood already (see docs.perfetto.dev for details), this patch adds strong typing for the arguments of the respective event(s) only. TBR: eseckler@google.com Bug: 644264 Change-Id: I67c0f8f78caca2db76e201f8f649f84eda53e3fc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1950966 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#735359}
-
Sylvain Defresne authored
The ChromeBrowserState has been moved from the "ios" namespace to the global namespace by http://crrev.com/c/2014913. Fix the uses from ios::ChromeBrowserState to ChromeBrowserState. Also remove includes of chrome_browser_state_forward.h and use a simple forward declaration instead (since the old name is no longer necessary). This CL was uploaded by git cl split. R=olivierrobin@chromium.org Bug: 1042208 Change-Id: I8681d8f472f14a1dbc22e680b236581e02093c45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017503Reviewed-by:
-
sczs authored
Bug: 1040844 Change-Id: Id780551c330924f783bad502cad8bfc6195d63b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2018328 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#735357}
-
Omer Katz authored
Tracing a Member or a WeakMember first checks whether the member is deleted. If the check passes, the member is traced. The check and the trace both use atomic loads, but not the same load. This can result in time-of-check vs time-of-use data races. This CL merges both loads to a single load to avoid such issues. Furthermore, members in hash tables now might be deleted while the relevant entry is deleted. Since the is deleted check is performed on a copy, member types need to bail out on deleted values (used to be a DCHECK before). Bug: 986235 Change-Id: I4307361af94081b62d159af67cdbde5666378550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2012285 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/master@{#735356}
-
Koji Ishii authored
Following bot results are included. 1140 1146 1151 1158 4 lines were removed and 4 lines were deflaked by consecutive results since 1128. TBR=yosin@chromium.org NOTRY=true Bug: 982194 Change-Id: Ibb13d19075f0edeceed016a972af5e7e46eebf6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022043Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735355}
-
Koji Ishii authored
This patch fixes |LayoutInline::InvalidateDisplayItemClients| to support changes to culled inline boxes in rr729656 <crrev.com/c/1774425>. Also moves |NGInlineCursor::CurrentDisplayItemClient| to |NGInlineCursorPosition::GetDisplayItemClient|. Bug: 982194 Change-Id: Icc4ac6c3c27132473d235b9384c46a4f010b6932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016822Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#735354}
-
Dominik Röttsches authored
The out-of-process font loader, now that it has moved to using CTFontManagerCreateFontDescriptorFromData, does not need to create a full CTFontRef anymore, but can instead wrap the out-of-process font data into a CTFontDescriptorRef built from data. Doing that avoids creating an extra CTFont copy in font_platform_data_mac, as we can merge the data descriptor with the cascade list attributes, and only then create the CTFontRef from it. Bug: 1033478 Change-Id: I025c265caf472578fd77a11acbc4b23a1d8fffb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2013289 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#735353}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I81e8fe019528dc7c2009c83fed797ef23ad1a15d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022565 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#735352}
-
Rushan Suleymanov authored
Do not send sharing message to sync server after first failure. Bug: 1034930 Change-Id: Ic88c12d646ef8028a3280f017d851ba1759575ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017410 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/fcef6dcb6ab2..589b1875f6b6 git log fcef6dcb6ab2..589b1875f6b6 --date=short --first-parent --format='%ad %ae %s' 2020-01-27 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/vulkan-tools/src 93ab50fc27de..b181c1a7ddb5 (4 commits) Created with: gclient setdep -r src/third_party/angle@589b1875f6b6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: timvp@google.com Change-Id: Idfab494e303fcc1b5a0ace737ffec8df2e488aff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022610Reviewed-by:
-
Koji Ishii authored
This function was added to be the same interface as |NGPaintFragment::InlineFragmentsFor|, but as |NGInlineCursor| evoles, it has the same functionality though |MoveTo(const LayoutObject&)| and |MoveToNextForSameLayoutObject()|. Now we prefer |NGInlineCurosr| for all traversals that this patch removes |ItemsFor()| function and switch all usages to |NGInlineCusror|. Bug: 982194 Change-Id: Ia9dfd4f608d8cfc2c5f6ccc5b40b1e1dda0876f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022445Reviewed-by:
-
Mathias Carlen authored
This patch fixes a NPE by guarding for null tabs. There are situations where a tab is not ready or available and direct action availability is queried. In that case a null tab would crash instead of reporting that this direct action is simply not yet available. Bug: 1041669 Change-Id: Idda1c166405c726cca416898fcd842606e74d3cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2016625Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#735348}
-
