- 17 Sep, 2019 40 commits
-
-
Hesen Zhang authored
Implements reading config from Finch with unittest. Bug: 1004498 Change-Id: Ib4326314d849cf66d8e702359a71fba74649471d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808098 Commit-Queue: Hesen Zhang <hesen@chromium.org> Auto-Submit: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697058}
-
Tom Anderson authored
This fixes a regression introduced between PS14 and PS15 of CL [1] where blend_toward_max_contrast() was switched for blend_for_min_contrast(). But for dimmed text, we specifically don't want to blend for min contrast because this will usually result in the same text color. What we want is a new text color distinct from the original text color, specifically with less contrast. Also updated COLOR_OMNIBOX_RESULTS_ICON while we're at it to use derive_default_icon_color(), which logically makes more sense, and gives results quite close to the colors before CL [1]. Updated colors: [2] [1] https://chromium-review.googlesource.com/c/chromium/src/+/1754155/14..15 [2] https://docs.google.com/spreadsheets/d/1Nev_DSPECQ9vGrFDO-ARjLudL6O2NjOTnBu_9mTq_cU/edit?usp=sharing Bug: 1004135 R=pkasting Change-Id: I243f809b409de7178408601a1fb80e4bddce7087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808191 Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Auto-Submit: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#697057}
-
Austin Tankiang authored
DriveFS is going to be used regardless of its feature flag, and the legacy drive sync client will be deleted, so clean up code that relies on the legacy drive sync client. Bug: 1002339 Change-Id: I85827f39bd174362a9a9e37eb5721384fea37d69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798947Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#697056}
-
Yuki Shiino authored
Supports Interface.operations, operation_groups. Also fixes several minor things. Bug: 839389 Change-Id: I77fbd80172d3d7ca5f385a1bc2ceabc40079556f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800856 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#697055}
-
nancy authored
BUG=1002351 Change-Id: I8df9f7f59599d5874c7170555a285b46141bb125 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803035Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#697054}
-
Wei-Yin Chen (陳威尹) authored
Bug: 998949 Change-Id: I29fbedca05f986d33f486684c1db8909bcd6b14a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1805296Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#697053}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/e65bb926f1f3..ca95a4ccd809 git log e65bb926f1f3..ca95a4ccd809 --date=short --no-merges --format='%ad %ae %s' 2019-09-17 saklein@chromium.org portage_util: Add HasPrebuilt function. Created with: gclient setdep -r src/third_party/chromite@ca95a4ccd809 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I0b3a551ed36c5612944d8769faa6fff395280d15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808229Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697052}
-
Fergus Dall authored
TBR=tommi@chromium.org TBR=sergeyu@chromium.org TBR=sandersd@chromium.org TBR=xhwang@chromium.org TBR=liberato@chromium.org TBR=dalecurtis@chromium.org TBR=chcunningham@chromium.org TBR=wolenetz@chromium.org TBR=jrummell@chromium.org TBR=tguilbert@chromium.org Bug: 1004580 Change-Id: I82e9610eda564e0197e5e4f546108f4ac7fd5f23 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808292Reviewed-by:
Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697051}
-
Antonio Gomes authored
This is a preliminary step to Onion souping //content/renderer/p2p. The following typemaps got added, and listed to [1]: - services/network/public/cpp/ip_address_for_blink.typemap (based on ip_address.typemap) - services/network/public/cpp/ip_endpoint_for_blink.typemap (based on ip_endpoint.typemap) - services/network/public/cpp/network_interface_for_blink.typemap (based on network_interface.typemap) Additionally, the following typemap files got listed in [1] as-is: - services/network/public/cpp/p2p.typemap - services/network/public/cpp/mutable_network_traffic_annotation_tag.typemap [1] //third_party/blink/renderer/platform/mojo/blink_typemaps.gni BUG=787254 R=dcheng@chromium.org, haraken@chromium.org Change-Id: Ife391517c3191bea57e41aa2a94efe091805257d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804541Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Tina Lu authored
Bug: 656625 Change-Id: I6a21ede043092e7db201c8b1edd3f3bd4740e558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804516 Commit-Queue: Tina Lu <ltina@google.com> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697049}
-
Yuchen Liu authored
Check if cdm object still alive before calling fidl APIs on it. Bug: 1001358 Test: Open page using Widevine on device without Widevine service. Change-Id: Ib82ab66b8dc5eec03a4f64c5e499fef3a93a0493 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802711Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Auto-Submit: Yuchen Liu <yucliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697048}
-
Yue Zhang authored
This CL adds components needed for the toolbar menu in TabGridDialog. Right now there is no consumer for this part of logic. Bug: 1000381 Change-Id: I03b51e8bbcefdb0f5ac4fc8224303f3d3debeff8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1785517 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
-
rbpotter authored
Since the tools/polymer/polymer.py script has been updated to handle export annotations, revert https://chromium-review.googlesource.com/c/chromium/src/+/1795315, which split of the AnchorAlignment enum into a separate file, since it is no longer necessary. Bug: 965770 Change-Id: I7109485280d8d22befe4cdccca3a7e5cf54629bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804957 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#697046}
-
Zhenyao Mo authored
Right now we collect them for all gpu_integration tests, which caused Win10 Intel bot to timeout. Instead, we only need to do that for info collection test. This also fixes a potential racing in GpuDataManager. BUG=1004472,977034 TEST=gpu bots R=kbr@chromium.org Change-Id: I4010fda150ff3872b1dcefd2ac8aa7e4ad689e73 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808012 Commit-Queue: Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697045}
-
Dmitry Gozman authored
Calling into WebLocalFrame::WillStartNavigation may cancel the navigation, for example when dispatched javascript event handlers do "window.stop()". Currently, we call RFO::DidStartNavigation prematurely, and never issue a paired "canceled" call when WillStartNavigation fails. We can instead try to start and only then issue observer notification to ensure proper sequence. Tests which navigate from onload handler now correctly report "first navigation finished, second navigation started" instead of the reverse. onreadystatechange-detach previously reported a new navigation, which does not actually happen because frame detaches itself before being able to start navigating. This behavior is fixed now. Bug: 855189 Change-Id: Ia12518ebddf54557f4699cd39168217762c874eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1800916Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#697044}
-
Miyoung Shin authored
This is a followup CL of https://crrev.com/c/1787663 and uses base::NullCallback instead of base::DoNothing for mojo interface in TrayBluetoothHelperExperimental class. Bug: 955171 Change-Id: I66fba9b9ffb8db2163111930254a9a87eaa19667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806157Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Cr-Commit-Position: refs/heads/master@{#697043}
-
Kent Tamura authored
I2IS: https://groups.google.com/a/chromium.org/d/msg/blink-dev/g8MP8KUf96w/360rLewrDwAJ Bug: 995679 Change-Id: I8d670ddb3a6a97642fcb5d6161178a3a86ccd568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798246Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#697042}
-
Miyoung Shin authored
This CL converts HidManager{Ptr, Request} in device, services, chrome and extensions to the new Mojo type. Bug: 955171 Change-Id: Iaeb03869b1ed99a769bc88553167c7b265aae32a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804942Reviewed-by:Adam Langley <agl@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4b35cce04ad4..e76231afda98 Created with: gclient setdep -r src-internal@e76231afda98 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:954450,chromium:913074 Change-Id: I8f2960259f237ecad8db32751191859c6e7858ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808223Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697040}
-
Julie Jeongeun Kim authored
This CL migrates AutofillRendererTest and FormAutocompleteTest with new Mojo types, PendingAssociatedReceiver and AssociatedReceiverSet instead of using AutofillDriverAssociatedRequest and AssociatedBindingSet. Bug: 955171 Change-Id: I06127b19f8f896ad6d13777637f6b5c3725d5af2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806615Reviewed-by:
sebsg <sebsg@chromium.org> Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts QueryableDataStorePtr and QueryableDataStoreRequest to new Mojo types. It uses Remote, PendingReceiver and ReceiverSet instead of QueryableDataStorePtr, QueryableDataStoreRequest and BindingSet. Bug: 955171 Change-Id: Iecdac72ae103960845b4764b0513c7ac98a99ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804712Reviewed-by:
Luke Halliwell <halliwell@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697038}
-
Austin Tankiang authored
DriveFS is going to be used regardless of its feature flag, and the legacy drive sync client will be deleted, so clean up code that relies on the legacy drive sync client. Bug: 1002339 Change-Id: Iba820095870d8aad1ba92b747af0849b750a150d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1798257Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Austin Tankiang <austinct@chromium.org> Cr-Commit-Position: refs/heads/master@{#697037}
-
Andrew Xu authored
This CL enables the scrollable shelf to show context menu for proper gestures (like long-time tapping). It helps to keep the UI consistency with the shelf view. Bug: 1003584 Change-Id: I74b69ffea84fedc6c780cacc01b6eea680b6875b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801320Reviewed-by:
-
Ryan Sturm authored
NavigationPredictor currently only recieves the first 40 links from the renderer. Instead, we should report the first 100. In pages that have a large number of small navigational links at the top, we may not see the main content links in NavigationPredictor. Bug: 1001593 Change-Id: I074bb70fb5cca14799a875b74c15ebdbdfe69a1b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797137 Auto-Submit: Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#697035}
-
Ryan Sturm authored
This restriction has limited the data pool the predictor can choose links from, and may severely limit coverage of the predictor. Instead of only using links from the visual viewport, links from anywhere on the page will be used as long as they have a size. Bug: 1001593 Change-Id: Iea4387d72952e850a02a7f4fdc1818d252daae26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797135Reviewed-by:
-
Fergus Dall authored
TBR=fdoray@chromium.org Bug: 1004578 Change-Id: I3d9fdd9c114f93b91958653f4ab1d73bed7e7b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808291Reviewed-by:
-
Fergus Dall authored
TBR=treib@chromium.org, rdevlin.cronin@chromium Bug: 1004573 Change-Id: I4ecd8c752b587b26c17f6176db230449fcee4c88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808287Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f73f0f401a6b..2c210a490857 git log f73f0f401a6b..2c210a490857 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ehmaldonado@chromium.org Revert "git-cl: Use bb to schedule try jobs." Created with: gclient setdep -r src/third_party/depot_tools@2c210a490857 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=agable@chromium.org Bug: chromium:976104 Change-Id: I099edf7da9f0952681d485edd6bb6ad9bdd20800 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808140Reviewed-by:
-
Andrew Xu authored
With the flag of scrollable shelf enabled, when adding a shelf item, scrollable shelf is notified when the shelf view's bounds animations end. Tests should wait for bounds animations to finish. Otherwise, they will fail. This CL fixes such an issue. Bug: 1002576 Change-Id: Ib2e80916a11a2b90f248886992f7221b1dce6563 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808189 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#697030}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/eb8f5aa220f6..b19a360c1269 git log eb8f5aa220f6..b19a360c1269 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 ntfschr@chromium.org Devil: IsApplicationInstalled API Created with: gclient setdep -r src/third_party/catapult@b19a360c1269 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=rmhasan@google.com Bug: chromium:1002774 Change-Id: I25fb405a04d46177fd178d014d433978dfd097cd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808222Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/ae8010776652..b47704b0bd34 git log ae8010776652..b47704b0bd34 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 brianosman@google.com Fix license comment in skottie_ios Created with: gclient setdep -r src/third_party/skia@b47704b0bd34 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: Ia04cf72df2f6b8293da3922eefc1a6744b74b5e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808219Reviewed-by:
-
Glen Robertson authored
Resets state_ ABM to INACTIVE in ResetCurrentPageData (called in DidFinishNavigation). This fixes a race possible when there are multiple navigations in quick succession. More info: There is no guarantee about the ordering of Did{Start,Finish}Navigation and DidFinishLoad for multiple navigations [1], so it is possible to get the order: [DidStartNav(url1), DidFinishNav(url1), DidStartNav(url2), DidFinishLoad(url1), DidFinishNav(url2), DidFinishLoad(url2)] The state_ in ABM is reset to INACTIVE on DidStartNavigation and checked (expected to still be INACTIVE) in DidFinishLoad. In the case of unusual call order, the state was no longer INACTIVE (usually it is COMPLETE) in DidFinishLoad(url2). This fix wouldn't help in the even-more-unusual order: [DidFinishNav({url1,url2}), DidFinishLoad({url1,url2})] I'm not sure how possible/likely that is. [1]: https://cs.chromium.org/chromium/src/content/public/browser/web_contents_observer.h?rcl=c954302bbe18174ce8a54242282eace7f25644e3&l=166-168 Bug: 991832 Change-Id: I0f04a5b26ee396557b56d9e1dca7570d3355f0da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1797527 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by: -
Fergus Dall authored
TBR=grt@chromium.org Bug: 1004568 Change-Id: Ia54998fa290e42b5b13b83d9d65d86e8f093a9b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808285Reviewed-by:
-
Nick Harper authored
TBR=rsleevi@chromium.org Change-Id: I5df128161982a1a18084188aac4262499460a52f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808095Reviewed-by:
Nick Harper <nharper@chromium.org> Commit-Queue: Nick Harper <nharper@chromium.org> Cr-Commit-Position: refs/heads/master@{#697025}
-
Shimi Zhang authored
FirstLayoutDone state was removed long time ago in https://chromiumcodereview.appspot.com/14787005, change the comment to reflect the current states. Bug: None Change-Id: Idac41a01e3f85d8187eae8c8ea89ba1a576f3096 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1802522 Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#697024}
-
Jack Lynch authored
This is a reland of 1da9c254 The test has been slimmed down the the minimum complexity necessary to test this part of the UI in order to avoid future CI timeouts. Original change's description: > DevTools: Add axe test for Changes drawer > > This adds an axe test for the accessibility changes in #1659355. The > test is in a separate PR from the changes because of the flaky axe test > issue which should be fixed by #1638125. > > Bug: 963183 > Change-Id: Ibc3dbd8dd954e2493521bef48abdb65a802a91ca > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1666445 > Commit-Queue: Jack Lynch <jalyn@microsoft.com> > Reviewed-by: Joel Einbinder <einbinder@chromium.org> > Auto-Submit: Jack Lynch <jalyn@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#677600} Bug: 963183 Change-Id: Ie537409e0b740a5c39b67dd5a280e4fcb330997f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713441Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jack Lynch <jalyn@microsoft.com> Cr-Commit-Position: refs/heads/master@{#697023}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/09feed378ddc..e65bb926f1f3 git log 09feed378ddc..e65bb926f1f3 --date=short --no-merges --format='%ad %ae %s' 2019-09-16 tcwang@google.com afdo: Prepare orderfile generate and verify builders on branch. 2019-09-16 dhanyaganesh@chromium.org Make coral critical Created with: gclient setdep -r src/third_party/chromite@e65bb926f1f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I024c80fe5ce886de1fb2f7af320941db09558eaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808004Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/cec6a1f798c4..c0326d5a977f git log cec6a1f798c4..c0326d5a977f --date=short --no-merges --format='%ad %ae %s' 2019-09-16 treehugger-gerrit@google.com Merge "Remove 'disabled-by-default' categories prefix" Created with: gclient setdep -r src/third_party/perfetto@c0326d5a977f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: I6c7c86185323ae3d8f8e907c9694d0d6d8f5c0ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808220Reviewed-by:
-
Yue Li authored
Update legacy code names and comments to use 'Assistant'. Remove obsolete logics. Bug: b/140823590 Test: Run existing tests Change-Id: Ie5647e85b0030c2cddfa1dfeab86c752ab6148f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808091Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
-
Khushal authored
For usages that are now handled by shared images, remove unused provider types and clean up some of the setup code. R=fserb@chromium.org Bug: 900706 Change-Id: Ibc3c3795dc7bd7620378acc2c874f445f136c333 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1753698 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#697019}
-
