1. 07 Apr, 2011 40 commits
    • ossy@webkit.org's avatar
      [Qt][WK2] Decrease flakiness of test results. · 05f99b67
      ossy@webkit.org authored
      * platform/qt-wk2/Skipped:
       - Add canvas tests not to break css2.1 tests.
       - Remove passing css2.1 tests.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83227 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      05f99b67
    • mitz@apple.com's avatar
      Build fix. · cba393f5
      mitz@apple.com authored
      * platform/graphics/cairo/GraphicsContextCairo.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83226 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cba393f5
    • eric@webkit.org's avatar
      2011-04-07 Eric Seidel <eric@webkit.org> · 666b08bf
      eric@webkit.org authored
              Reviewed by Adam Barth.
      
              Add stub support for generating Gtk build system from gyp
              https://bugs.webkit.org/show_bug.cgi?id=58086
      
              This adds support for a new --port argument and plumbs through
              the necessary paths to allow generating for a port other than Mac.
      
              * Source/gyp/configure:
      2011-04-07  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add stub support for generating Gtk build system from gyp
              https://bugs.webkit.org/show_bug.cgi?id=58086
      
              This does not produce a buildable JavaScriptCore, but it
              does allow running gyp/configure --port=gtk and having
              it generate a gtk.Makefile which we can use for testing
              the rest of the plumbing.
      
              * gyp/gtk.gyp: Added.
      2011-04-07  Eric Seidel  <eric@webkit.org>
      
              Reviewed by Adam Barth.
      
              Add stub support for generating Gtk build system from gyp
              https://bugs.webkit.org/show_bug.cgi?id=58086
      
              This does not produce a buildable WebCore, but it
              does allow running gyp/configure --port=gtk and having
              it generate a gtk.Makefile which we can use for testing
              the rest of the plumbing.
      
              * gyp/gtk.gyp: Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83225 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      666b08bf
    • scherkus@chromium.org's avatar
      2011-04-07 Andrew Scherkus <scherkus@chromium.org> · d7dd7419
      scherkus@chromium.org authored
              Revert ENABLE_TRACK patch due to compile failures.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83223 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d7dd7419
    • jer.noble@apple.com's avatar
      Unreviewed; Add failing legacy full screen tests to the gtk/Skipped list. · b60904fe
      jer.noble@apple.com authored
      * platform/gtk/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83222 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b60904fe
    • hyatt@apple.com's avatar
      https://bugs.webkit.org/show_bug.cgi?id=57736 · 501e3453
      hyatt@apple.com authored
              
      Reviewed by Dan Bernstein.
      
      Crash on openstreetmap.org while using the map. Fix a bad interaction between the positioned movement layout
      optimization and the simplified layout optimization that could lead to blocks remaining marked as dirty when
      layout finished. This would eventually lead to an inability to properly determine the correct layout root and
      would cause a deleted root to be used later on.
      
      Added fast/block/positioning/complex-positioned-movement.html.
      
      Source/WebCore: 
      
      * page/FrameView.cpp:
      (WebCore::FrameView::scheduleRelayoutOfSubtree):
      Add asserts to catch cases in the future where a layout root is set that has a dirty containing block.
          
      * rendering/RenderBlock.cpp:
      (WebCore::RenderBlock::simplifiedLayout):
      Change simplified layout so that the positioned movement optimization no longer clears the other layout
      flags. This will ensure that we still lay out our descendants if they need it.
              
      (WebCore::RenderBlock::layoutPositionedObjects):
      Changed to clear our layout flags now if the positioned movement is successful, since tryLayoutDoingPositionedMovementOnly
      no longer does the clear.
          
      * rendering/RenderBox.h:
      (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly):
      tryLayoutDoingPositionedMovementOnly now returns a boolean indicating success or failure.  On success it no longer
      does setNeedsLayout(false), but instead will let the caller take care of it. This way the caller can still look at
      the other flags in case other kinds of layout are still needed.
          
      * rendering/RenderObject.h:
      (WebCore::RenderObject::setNeedsPositionedMovementLayout):
      (WebCore::RenderObject::setNeedsSimplifiedNormalFlowLayout):
      Changed these methods to only set their respective flags and not to try to be clever about avoiding propagation.
      
      LayoutTests: 
      
      * fast/block/positioning/complex-positioned-movement.html: Added.
      * platform/mac/fast/block/positioning/complex-positioned-movement-expected.checksum: Added.
      * platform/mac/fast/block/positioning/complex-positioned-movement-expected.png: Added.
      * platform/mac/fast/block/positioning/complex-positioned-movement-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83221 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      501e3453
    • scherkus@chromium.org's avatar
      2011-04-07 Anna Cavender <annacc@chromium.org> · 30cd864c
      scherkus@chromium.org authored
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * configure.ac:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * Configurations/FeatureDefines.xcconfig:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              No new tests. No real functionality added just yet.
      
              * CMakeLists.txt:
              * Configurations/FeatureDefines.xcconfig:
              * DerivedSources.make:
              * GNUmakefile.am:
              * WebCore.gypi:
              * WebCore.xcodeproj/project.pbxproj:
              * features.pri:
              * html/HTMLAttributeNames.in:
              * html/HTMLTagNames.in:
              * html/HTMLTrackElement.cpp: Added.
              (WebCore::HTMLTrackElement::HTMLTrackElement):
              (WebCore::HTMLTrackElement::create):
              (WebCore::HTMLTrackElement::insertedIntoTree):
              (WebCore::HTMLTrackElement::willRemove):
              (WebCore::HTMLTrackElement::src):
              (WebCore::HTMLTrackElement::setSrc):
              (WebCore::HTMLTrackElement::kind):
              (WebCore::HTMLTrackElement::setKind):
              (WebCore::HTMLTrackElement::srclang):
              (WebCore::HTMLTrackElement::setSrclang):
              (WebCore::HTMLTrackElement::label):
              (WebCore::HTMLTrackElement::setLabel):
              (WebCore::HTMLTrackElement::isDefault):
              (WebCore::HTMLTrackElement::setIsDefault):
              (WebCore::HTMLTrackElement::isURLAttribute):
              * html/HTMLTrackElement.h: Added.
              * html/HTMLTrackElement.idl: Added.
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define + initial HTMLTrackElement
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * WebKit.xcodeproj/project.pbxproj:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * features.gypi:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * Configurations/FeatureDefines.xcconfig:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * Configurations/FeatureDefines.xcconfig:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * Scripts/build-webkit:
      
      2011-04-07  Anna Cavender  <annacc@chromium.org>
      
              Reviewed by Eric Carlson.
      
              Setup ENABLE(TRACK) feature define
              https://bugs.webkit.org/show_bug.cgi?id=53556
      
              * win/tools/vsprops/FeatureDefines.vsprops:
              * win/tools/vsprops/FeatureDefinesCairo.vsprops:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83220 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      30cd864c
    • tony@chromium.org's avatar
      2011-04-07 Tony Chang <tony@chromium.org> · ef49d22a
      tony@chromium.org authored
              Reviewed by Eric Seidel.
      
              update DRT to embed checksums in png files
              https://bugs.webkit.org/show_bug.cgi?id=57871
      
              We insert the bytes for the comment in printPNG rather than at encode
              time because each platform does its own PNG encoding (either using CG
              or cairo).  Putting this in pringPNG avoids having to duplicate this
              code, although it's not as clean as doing it at encoding time.
      
              We insert the comment right after the IHDR chunk of the PNG.
      
              * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
              * DumpRenderTree/CyclicRedundancyCheck.cpp: Added.
              (makeCrcTable): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
              (computeCrc): Ported from LayoutTests/fast/canvas/webgl/resources/pnglib.js
              * DumpRenderTree/CyclicRedundancyCheck.h: Added.
              * DumpRenderTree/PixelDumpSupport.cpp:
              (dumpWebViewAsPixelsAndCompareWithExpected):
              (convertChecksumToPNGComment): Generate the bytes to insert.
              (printPNG): Insert the png comment before the first IDAT section.
              * DumpRenderTree/PixelDumpSupport.h:
              * DumpRenderTree/cairo/PixelDumpSupportCairo.cpp:
              (printPNG):
              (dumpBitmap):
              * DumpRenderTree/cg/PixelDumpSupportCG.cpp:
              (printPNG):
              (dumpBitmap):
              * DumpRenderTree/win/DumpRenderTree.vcproj:
              * GNUmakefile.am:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83219 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ef49d22a
    • mrobinson@webkit.org's avatar
      2011-04-07 Martin Robinson <mrobinson@igalia.com> · c0a95891
      mrobinson@webkit.org authored
              Fix the WebKit2 GTK+ build for older versions of GTK+.
      
              * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Include the GtkVersioning.h header.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83218 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c0a95891
    • abarth@webkit.org's avatar
      2011-04-07 Adam Barth <abarth@webkit.org> · 679947ce
      abarth@webkit.org authored
              Fix whitespace in GNUmakefile.am.
      
              * GNUmakefile.am:
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83217 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      679947ce
    • mitz@apple.com's avatar
      <rdar://problem/9018212> Underline thickness is not uniform under non-integral scale factor · d3b9324e
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=58083
      
      Reviewed by Simon Fraser.
      
      Source/WebCore: 
      
      Test: fast/text/decorations-transformed.html
      
      * platform/graphics/GraphicsContext.h: Added a RoundingMode enum with two values. RoundAllSides
      is the existing rounding mode, where each side of the rectangle snaps to the nearest pixel
      gridline. RoundOriginAndDimensions snaps the origin to the nearest pixel gridpoint and rounds
      the width and the height. In this new mode, translating a rectangle in user space never changes
      its dimensions in device pixels.
      * platform/graphics/cg/GraphicsContextCG.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels): Implemented RoundOriginAndDimensions.
      (WebCore::GraphicsContext::drawLineForText): Use RoundOriginAndDimensions, thus ensuring that
      all underlines have the same thickness in device pixels.
      * platform/graphics/openvg/GraphicsContextOpenVG.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels): Added RoundingMode parameter, but did not implement it.
      * platform/graphics/qt/GraphicsContextQt.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
      * platform/graphics/skia/GraphicsContextSkia.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
      * platform/graphics/wince/GraphicsContextWinCE.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
      * platform/graphics/wx/GraphicsContextWx.cpp:
      (WebCore::GraphicsContext::roundToDevicePixels): Ditto.
      * rendering/InlineTextBox.cpp:
      (WebCore::InlineTextBox::paintDecoration):
      
      LayoutTests: 
      
      * fast/text/decorations-transformed.html: Added.
      * platform/mac/fast/text/decorations-transformed-expected.checksum: Added.
      * platform/mac/fast/text/decorations-transformed-expected.png: Added.
      * platform/mac/fast/text/decorations-transformed-expected.txt: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83216 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d3b9324e
    • mrobinson@webkit.org's avatar
      2011-04-07 Amruth Raj <amruthraj@motorola.com> and Martin Robinson <mrobinson@igalia.com> · 8a17da6c
      mrobinson@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [GTK] Implement SharedMemory for WebKit2
              https://bugs.webkit.org/show_bug.cgi?id=49791
      
              Share the SharedMemory, Attachment and Connection implementations with the Qt port.
              Both implementation are, in fact, general Unix implementations using standard Unix
              domain sockets and sendmsg / recvmsg. This should reduce the amount of duplicated code
              greatly and lay the groundwork for GTK+/Qt implementations for other operating systems.
      
              * GNUmakefile.am: Replaced GTK+ versions of files with the Unix ones.
              * Platform/CoreIPC/ArgumentDecoder.cpp: Extended Qt #ifdefs to include GTK.
              (CoreIPC::ArgumentDecoder::~ArgumentDecoder):
              * Platform/CoreIPC/ArgumentEncoder.cpp: Ditto.
              (CoreIPC::ArgumentEncoder::~ArgumentEncoder):
              * Platform/CoreIPC/Attachment.h: Ditto.
              * Platform/CoreIPC/Connection.h: Combined the GTK+ and Qt sections.
              * Platform/CoreIPC/unix/AttachmentUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/AttachmentQt.cpp.
              * Platform/CoreIPC/unix/ConnectionUnix.cpp: Renamed from Source/WebKit2/Platform/CoreIPC/qt/ConnectionQt.cpp.
              * Platform/unix/SharedMemoryUnix.cpp: Renamed from Source/WebKit2/Platform/qt/SharedMemoryQt.cpp.
              * UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:
              (WebKit::ProcessLauncher::launchProcess): Use SOCK_DGRAM instead of SOCK_STREAM to match Qt.
              * WebKit2.pro: Updated source list to reflect file renaming.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83215 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8a17da6c
    • jer.noble@apple.com's avatar
      Unreviewed; Add the media/media-fullscreen-inline.html test to the mac-snowleopard Skipped list. · 83745c62
      jer.noble@apple.com authored
      The legacy full screen API now redirects to the new full screen API, breaking the media-fullscreen-inline.html
      test.
      
      * platform/mac-snowleopard/Skipped:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83214 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      83745c62
    • vitalyr@chromium.org's avatar
      2011-04-06 Vitaly Repeshko <vitalyr@chromium.org> · c80cb320
      vitalyr@chromium.org authored
              Reviewed by Nate Chapin.
      
              [V8] Remove custom DOMImplementation getter on Document.
              https://bugs.webkit.org/show_bug.cgi?id=57991
      
              The custom getter is no longer required because DOMImplementation
              objects are now created per document.
      
              Test: fast/dom/DOMImplementation/implementation-identity.html
      
              * bindings/scripts/CodeGeneratorV8.pm:
              * bindings/v8/custom/V8DocumentCustom.cpp:
              * dom/Document.idl:
      
      2011-04-06  Vitaly Repeshko  <vitalyr@chromium.org>
      
              Reviewed by Nate Chapin.
      
              [V8] Remove custom DOMImplementation getter on Document.
              https://bugs.webkit.org/show_bug.cgi?id=57991
      
              * fast/dom/DOMImplementation/implementation-identity-expected.txt: Added.
              * fast/dom/DOMImplementation/implementation-identity.html: Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83213 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c80cb320
    • barraclough@apple.com's avatar
      Fix a couple of typos in comments that Darin spotted. · 993edfa7
      barraclough@apple.com authored
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_not):
      * runtime/JSImmediate.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83212 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      993edfa7
    • ap@apple.com's avatar
      Reviewed by Brian Weinstein. · d116ad60
      ap@apple.com authored
              REGRESSION (r83081): Use of deallocated memory in WebEditorClient::respondToChangedSelection()
              https://bugs.webkit.org/show_bug.cgi?id=58082
      
              * WebProcess/WebCoreSupport/WebEditorClient.cpp: (WebKit::WebEditorClient::respondToChangedSelection):
              Now that the Range is used outside the full expression where it's created, it needs to be
              protected with RefPtr.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83211 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d116ad60
    • commit-queue@webkit.org's avatar
      2011-04-07 Steve Lacey <sjl@chromium.org> · edbd1ffa
      commit-queue@webkit.org authored
              Reviewed by Eric Carlson.
      
              Make various video layout tests platform independent by selecting an appropriate media file.
      
              Various layout tests depend on mp4 files.
              https://bugs.webkit.org/show_bug.cgi?id=57804
      
              * http/tests/media/remove-while-loading.html:
              * http/tests/media/video-load-and-stall.cgi:
              * http/tests/media/video-play-stall-before-meta-data.html:
              * http/tests/media/video-play-stall-seek.html:
              * http/tests/media/video-play-stall.html:
              * http/tests/media/video-seekable-stall.html:
              * media/media-file.js:
              (mimeTypeForFile):
              (stripExtension):
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83210 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      edbd1ffa
    • inferno@chromium.org's avatar
      2011-04-07 Sergey Glazunov <serg.glazunov@gmail.com> · d6d93333
      inferno@chromium.org authored
              Reviewed by Dimitri Glazkov.
      
              setHasID() is only called for styled elements
              https://bugs.webkit.org/show_bug.cgi?id=57267
      
              Test: fast/dom/non-styled-element-id-crash.html
      
              * dom/Element.cpp:
              (WebCore::Element::attributeChanged):
              (WebCore::Element::idAttributeChanged):
              * dom/Element.h:
              * dom/StyledElement.cpp:
              (WebCore::StyledElement::parseMappedAttribute):
      2011-04-07  Sergey Glazunov  <serg.glazunov@gmail.com>
      
              Reviewed by Dimitri Glazkov.
      
              setHasID() is only called for styled elements
              https://bugs.webkit.org/show_bug.cgi?id=57267
      
              * fast/dom/non-styled-element-id-crash-expected.txt: Added.
              * fast/dom/non-styled-element-id-crash.html: Added.
              * svg/custom/embedded-svg-disallowed-in-dashboard.xml: Fix the failing test.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83209 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d6d93333
    • jer.noble@apple.com's avatar
      2011-04-07 Jer Noble <jer.noble@apple.com> · bfab9a2b
      jer.noble@apple.com authored
              Reviewed by Eric Carlson.
      
              HTMLVideoElement::webkitEnterFullscreen does not use new Full Screen API when available.
              https://bugs.webkit.org/show_bug.cgi?id=58070
      
              Make the HTMLMediaElement full screen functions call into the new Full Screen API when
              FULLSCREEN_API is enabled.
      
              * html/HTMLMediaElement.cpp:
              (WebCore::HTMLMediaElement::enterFullscreen):
              (WebCore::HTMLMediaElement::exitFullscreen):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83208 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      bfab9a2b
    • bweinstein@apple.com's avatar
      Fix a typo in the Skipped list from r83203. · 521aaaaa
      bweinstein@apple.com authored
      * platform/win-wk2/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83207 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      521aaaaa
    • mrowe@apple.com's avatar
      <rdar://problem/9251566> WebBackForwardList::createCFDictionaryRepresentation's current item index · 6a0bcb13
      mrowe@apple.com authored
      doesn't account for items removed by filter callback.
      
      Reviewed by Dan Bernstein.
      
      * UIProcess/cf/WebBackForwardListCF.cpp:
      (WebKit::WebBackForwardList::createCFDictionaryRepresentation): Update the current item index
      when we omit an item due to the filter callback.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83206 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6a0bcb13
    • abarth@webkit.org's avatar
      2011-04-07 Adam Barth <abarth@webkit.org> · 85f0b276
      abarth@webkit.org authored
              Reviewed by Eric Seidel.
      
              Implement CSP's options directive
              https://bugs.webkit.org/show_bug.cgi?id=58014
      
              * http/tests/security/contentSecurityPolicy/inline-script-allowed-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/inline-script-allowed.html: Added.
              * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt: Added.
              * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html: Added.
      2011-04-07  Adam Barth  <abarth@webkit.org>
      
              Reviewed by Eric Seidel.
      
              Implement CSP's options directive
              https://bugs.webkit.org/show_bug.cgi?id=58014
      
              This patch contains the full options parser, but we only have enough of
              CSP implemented to see the effects of disable-xss-protection.  Will
              need to do some more work before we can see eval-script in action.
      
              Tests: http/tests/security/contentSecurityPolicy/inline-script-allowed.html
                     http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html
      
              * page/ContentSecurityPolicy.cpp:
              (WebCore::CSPOptions::CSPOptions):
              (WebCore::CSPOptions::disableXSSProtection):
              (WebCore::CSPOptions::evalScript):
              (WebCore::CSPOptions::parse):
              (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
              (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
              (WebCore::ContentSecurityPolicy::allowInlineScript):
              (WebCore::ContentSecurityPolicy::addDirective):
              * page/ContentSecurityPolicy.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83205 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      85f0b276
    • ap@apple.com's avatar
      Reviewed by Anders Carlsson. · 260cad1b
      ap@apple.com authored
              REGRESSION (WebKit2): Reverse conversion doesn't work in Kotoeri
              https://bugs.webkit.org/show_bug.cgi?id=58066
              <rdar://problem/8965302>
      
              * Scripts/webkit2/messages.py:
              * Shared/mac/AttributedString.h: Added.
              * Shared/mac/AttributedString.mm: Added.
              (WebKit::AttributedString::encode):
              (WebKit::AttributedString::decode):
              Added an class that wraps NSAttributedString. As far as I can tell, one can't pass a CF
              or NS object to another process without wrapping it in a C++ one.
              
              * Shared/mac/ArgumentCodersMac.h: Added.
              * Shared/mac/ArgumentCodersMac.mm: Added.
              Added coders for Foundation objects, similar to ArgumentCodersCF. There are two reasons why
              these are needed:
              1) Even though most Foundation objects are toll free bridged with CF, CFGetTypeID() doesn't
              work properly for them (I've been just getting 1).
              2) NSColor isn't toll free bridged to CF.
              This adds just the types necessary for editing NSAttributedString (and I don't yet know what
              happens with attachments).
      
              * UIProcess/API/mac/WKView.mm: (-[WKView attributedSubstringFromRange:]):
              * UIProcess/WebPageProxy.h:
              * UIProcess/mac/WebPageProxyMac.mm:
              (WebKit::WebPageProxy::getAttributedSubstringFromRange):
              * WebKit2.xcodeproj/project.pbxproj:
              * WebProcess/WebPage/WebPage.h:
              * WebProcess/WebPage/WebPage.messages.in:
              Boilerplate code for making a sync call to web process.
      
              * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::getAttributedSubstringFromRange):
              Ported from WebHTMLView.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83204 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      260cad1b
    • enrica@apple.com's avatar
      Unreviewed. · 20bd0bda
      enrica@apple.com authored
      Adding to skipped list for Windows (WK2) the
      tests relative to undo removed from the skipped list
      for Mac where execCommand('undo') is now supported.
      
      * platform/win-wk2/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83203 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      20bd0bda
    • enne@google.com's avatar
      2011-04-07 Adrienne Walker <enne@google.com> · 137a8e35
      enne@google.com authored
              [chromium] Unreviewed, rebaseline progress element tests.
      
              * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
              * platform/chromium-linux/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
              * platform/chromium-mac-leopard/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png: Added.
              * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum: Removed.
              * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
              * platform/chromium-win/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
              * platform/chromium-win/fast/dom/HTMLProgressElement/progress-element-expected.txt:
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83202 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      137a8e35
    • aestes@apple.com's avatar
      2011-04-07 Andy Estes <aestes@apple.com> · 4f8b8419
      aestes@apple.com authored
              Reviewed by Darin Adler.
      
              REGRESSION (r64712): Microsoft Outlook 2011: original message contents
              not included when replying to an email.
              https://bugs.webkit.org/show_bug.cgi?id=57794
      
              * WebKit.xcodeproj/project.pbxproj:
      2011-04-07  Andy Estes  <aestes@apple.com>
      
              Reviewed by Darin Adler.
      
              REGRESSION (r64712): Microsoft Outlook 2011: original message contents
              not included when replying to an email.
              https://bugs.webkit.org/show_bug.cgi?id=57794
              
              Outlook populates a reply message by creating an empty WebView and
              using DOM API to populate the WebView's empty document with content
              from the original message. It expects the initial empty document to
              simply be "<html></html>", and it proceeds to dynamically create and
              append a BODY node and add the original message content as a child of
              that node. Outlook then takes the innerHTML of the frame's first body
              element and copies it into a *new* document that is displayed and
              edited in the reply message window.
              
              Due to implementing the HTML5 tree building algorithm in r64712,
              initial empty documents went from being "<html></html>" to being
              "<html><head></head><body></body></html>". Outlook still dynamically
              creates a BODY node to parent the original message content, but this
              BODY node duplicates the one created by the tree builder. When Outlook
              then takes the innerHTML of the first body element to populate the
              reply message window it gets the empty body element created by the
              parser, not the one it created with the original message content.
              
              Fix this by injecting a user script into the initial empty document
              that removes the HEAD and BODY nodes created by the parser. This
              ensures that the BODY created by Outlook is the only BODY in the
              document.
      
              * Misc/OutlookQuirksUserScript.js: Added.
              * WebView/WebView.mm:
              (leakMailQuirksUserScriptContents):
              (-[WebView _injectMailQuirksScript]):
              (needsOutlookQuirksScript):
              (leakOutlookQuirksUserScriptContents):
              (-[WebView _injectOutlookQuirksScript]):
              (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
      2011-04-07  Andy Estes  <aestes@apple.com>
      
              Reviewed by Darin Adler.
      
              REGRESSION (r64712): Microsoft Outlook 2011: original message contents
              not included when replying to an email.
              https://bugs.webkit.org/show_bug.cgi?id=57794
              
              * WebCore.exp.in:
              * loader/FrameLoader.cpp:
              (WebCore::FrameLoader::finishedParsing): Call Frame::injectUserScripts()
              before checking if the FrameLoader is parsing the initial empty document.
              This allows user scripts to be injected at the end of document parsing
              (if the setting is enabled).
              * page/Frame.cpp:
              (WebCore::Frame::injectUserScripts): Do not inject scripts if this
              feature is disabled on the initial empty document.
              * page/Settings.cpp:
              (WebCore::Settings::Settings):
              * page/Settings.h: Add a setting for injecting user scripts into the
              initial empty document (defaults to false).
              (WebCore::Settings::setInjectUserScriptsInInitialEmptyDocument):
              (WebCore::Settings::injectUserScriptsInInitialEmptyDocument):
              * platform/mac/RuntimeApplicationChecks.h:
              * platform/mac/RuntimeApplicationChecks.mm:
              (WebCore::applicationIsMicrosoftOutlook): Check if the embedding
              application is Microsoft Outlook.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83201 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4f8b8419
    • jeffm@apple.com's avatar
      Mac build fix. · 6e53d8ab
      jeffm@apple.com authored
      * Shared/WebString.h:
      (WebKit::WebString::getCharacters): Add explict cast when using std::min().
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83200 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6e53d8ab
    • jer.noble@apple.com's avatar
      Unreviewed; rebaseline expected results in platform/mac-wk2. · 272ea9af
      jer.noble@apple.com authored
      * platform/mac-wk2/media/controls-without-preload-expected.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83199 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      272ea9af
    • jeffm@apple.com's avatar
      2011-04-07 Jeff Miller <jeffm@apple.com> · b9daa3e7
      jeffm@apple.com authored
              Reviewed by Adam Roben.
      
              Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
              https://bugs.webkit.org/show_bug.cgi?id=58058
      
              * TestWebKitAPI/Tests/WebKit2/WKString.cpp:
              (TestWebKitAPI::TEST): Add tests for  WKStringGetLength() and WKStringGetCharactersPtr().
      2011-04-07  Jeff Miller  <jeffm@apple.com>
      
              Reviewed by Adam Roben.
      
              Replace WKStringGetCharactersPtr() with WKStringGetCharacters()
              https://bugs.webkit.org/show_bug.cgi?id=58058
              
              WKStringGetCharactersPtr() exposes the internal implementation of WKString, so change this to WKStringGetCharacters(), which makes a UTF-16 copy.
      
              * Shared/API/c/WKString.cpp:
              (WKStringGetCharacters): Added, replaces WKStringGetCharactersPtr().
              * Shared/API/c/WKString.h: Replaced WKStringGetCharactersPtr() with WKStringGetCharacters().
              * Shared/WebString.h:
              (WebKit::WebString::getCharacters): Added.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83198 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b9daa3e7
    • bweinstein@apple.com's avatar
      WebKit2: Support window bounce when panning. · df831400
      bweinstein@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=58065
      <rdar://problem/9244367>
              
      Reviewed by Adam Roben.
      
      Make gestureDidScroll synchronous, as once we scroll, we need to know
      whether or not we are at the beginning or end of the scrollable document.
              
      If we are at either end of the scrollable document, we call the Windows 7
      API to bounce the window to give an indication that you are past an end
      of the document.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::gestureDidScroll): Pass a boolean for the reply, and return it.
      * UIProcess/WebPageProxy.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::WebView): Inititalize a new variable.
      (WebKit::WebView::onGesture): Once we send the message to scroll, check if have gone to
          an end of the document, and if we have, bounce the window.
      * UIProcess/win/WebView.h:
      * WebProcess/WebPage/WebPage.h:
      * WebProcess/WebPage/WebPage.messages.in: GestureDidScroll is now sync.
      * WebProcess/WebPage/win/WebPageWin.cpp:
      (WebKit::WebPage::gestureDidScroll): When we are done scrolling, check if we have a vertical
          scrollbar and if we are at the beginning or the end of the scrollable document.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83197 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      df831400
    • jer.noble@apple.com's avatar
      2011-04-06 Jer Noble <jer.noble@apple.com> · ed03cbf2
      jer.noble@apple.com authored
              Reviewed by Maciej Stachowiak.
      
              AVF: MediaPlayerPrivateAVFoundation never reaches playable state.
              https://bugs.webkit.org/show_bug.cgi?id=57962
      
              Add support for a new AVPlayerItem API which will notify clients when their
              seek completes.  This requires a new Notification type to be passed to the main
              thread in MediaPlayerPrivateAVFoundation.
      
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
              (WebCore::MediaPlayerPrivateAVFoundation::seekCompleted): Added.
              (WebCore::MediaPlayerPrivateAVFoundation::scheduleMainThreadNotification): Added two new
                  overloaded functions which take a Notification; and a Notification::Type and boolean.
              (WebCore::MediaPlayerPrivateAVFoundation::dispatchNotification): Support new SeekCompleted
                  Notification type.
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
              (WebCore::MediaPlayerPrivateAVFoundation::Notification::Notification): Added one new constructor.
              (WebCore::MediaPlayerPrivateAVFoundation::Notification::finished): Added ivar and accessor.
              * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
              (WebCore::MediaPlayerPrivateAVFoundationObjC::seekToTime): Call new AVPlayerItem API.
              (-[WebCoreAVFMovieObserver seekCompleted:]): Added.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83196 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ed03cbf2
    • commit-queue@webkit.org's avatar
      2011-04-07 Chang Shu <cshu@webkit.org> · 68c071f2
      commit-queue@webkit.org authored
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.isPageBoxVisible
              https://bugs.webkit.org/show_bug.cgi?id=42695
      
              Unskip passed tests.
      
              * platform/mac-wk2/Skipped:
              * platform/qt-wk2/Skipped:
      2011-04-07  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.isPageBoxVisible
              https://bugs.webkit.org/show_bug.cgi?id=42695
      
              * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
              (WKBundleIsPageBoxVisible):
              * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
              * WebProcess/InjectedBundle/InjectedBundle.cpp:
              (WebKit::InjectedBundle::isPageBoxVisible):
              * WebProcess/InjectedBundle/InjectedBundle.h:
      2011-04-07  Chang Shu  <cshu@webkit.org>
      
              Reviewed by Darin Adler.
      
              WebKitTestRunner needs layoutTestController.isPageBoxVisible
              https://bugs.webkit.org/show_bug.cgi?id=42695
      
              * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
              * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
              (WTR::LayoutTestController::isPageBoxVisible):
              * WebKitTestRunner/InjectedBundle/LayoutTestController.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83195 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      68c071f2
    • enrica@apple.com's avatar
      Source/WebKit2: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac). · eabff8ad
      enrica@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=58055
      <rdar://problem/8862023>
              
      Reviewed by Oliver Hunt.
      
      Adding support for execCommand('undo') and execCommand('redo')
      in WebKit2 for Mac.
      
      * UIProcess/API/mac/PageClientImpl.h:
      * UIProcess/API/mac/PageClientImpl.mm:
      (WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager.
      (WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager.
              
      Added new empty PageClient methods for other platforms.
      * UIProcess/API/qt/qwkpage.cpp:
      (QWKPagePrivate::canUndoRedo):
      (QWKPagePrivate::executeUndoRedo):
      * UIProcess/API/qt/qwkpage_p.h:
      * UIProcess/PageClient.h:
      * UIProcess/gtk/WebView.cpp:
      (WebKit::WebView::canUndoRedo):
      (WebKit::WebView::executeUndoRedo):
      * UIProcess/gtk/WebView.h:
      * UIProcess/win/WebView.cpp:
      (WebKit::WebView::canUndoRedo):
      (WebKit::WebView::executeUndoRedo):
      * UIProcess/win/WebView.h:
      
      * UIProcess/WebEditCommandProxy.cpp:
      (WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching
      of asychronous messages while waiting for a sync message reply.
      (WebKit::WebEditCommandProxy::reapply): Same as above.
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::canUndoRedo):
      (WebKit::WebPageProxy::executeUndoRedo):
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      * WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation.
      (WebKit::WebEditorClient::canUndo):
      (WebKit::WebEditorClient::canRedo):
      (WebKit::WebEditorClient::undo):
      (WebKit::WebEditorClient::redo):
      
      LayoutTests: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
      https://bugs.webkit.org/show_bug.cgi?id=58055
      <rdar://problem/8862023>
      
      Reviewed by Oliver Hunt.
      
      * platform/mac-wk2/Skipped: Remove skipped tests related to undo/redo.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83194 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      eabff8ad
    • beidson@apple.com's avatar
      <rdar://problem/9250368> and https://bugs.webkit.org/show_bug.cgi?id=58062 · ff3e3cc8
      beidson@apple.com authored
      Reviewed by Maciej Stachowiak.
      
      * UIProcess/API/C/WKIconDatabase.cpp:
      (WKIconDatabaseClose):
      * UIProcess/API/C/WKIconDatabase.h:
              
      * UIProcess/WebIconDatabase.cpp:
      (WebKit::WebIconDatabase::close):
      * UIProcess/WebIconDatabase.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83193 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ff3e3cc8
    • barraclough@apple.com's avatar
      Bug 58057 - Store boolean payload in low bit of JSImmediate · f62e368c
      barraclough@apple.com authored
      Reviewed by Geoff Garen.
      
      And remove some uncalled functions from JSImmediate.h
      
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitTagAsBoolImmediate):
      * jit/JITOpcodes.cpp:
      (JSC::JIT::emit_op_not):
      * runtime/JSImmediate.h:
      (JSC::JSImmediate::makeInt):
      (JSC::JSImmediate::makeBool):
      (JSC::JSImmediate::intValue):
      (JSC::JSImmediate::boolValue):
      (JSC::JSImmediate::asInt32):
      (JSC::JSImmediate::toDouble):
      (JSC::JSValue::asInt32):
      (JSC::JSValue::isUInt32):
      (JSC::JSValue::asUInt32):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83192 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f62e368c
    • commit-queue@webkit.org's avatar
      2011-04-07 Nancy Piedra <nancy.piedra@nokia.com> · dd5827fe
      commit-queue@webkit.org authored
              Reviewed by Eric Carlson.
      
              Add tests for parsing codecs parameter in video-can-play-type.html
              https://bugs.webkit.org/show_bug.cgi?id=53275
      
              * media/video-can-play-type-expected.txt:
              * media/video-can-play-type.html:
      2011-04-07  Nancy Piedra  <nancy.piedra@nokia.com>
      
              Reviewed by Eric Carlson.
      
              Parse quotes from content type parameters
              https://bugs.webkit.org/show_bug.cgi?id=53275
      
              This functionality is tested in video-can-play-type.html layout test
              where I've added codecs parameter with good and bad formatting.
      
              * platform/ContentType.cpp:
              (WebCore::ContentType::parameter):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83191 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dd5827fe
    • pfeldman@chromium.org's avatar
      2011-04-07 Pavel Feldman <pfeldman@google.com> · 05d9ce24
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: remove "enabled" from the setBreakpoint protocol.
              https://bugs.webkit.org/show_bug.cgi?id=58047
      
              * bindings/js/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::hasBreakpoint):
              * bindings/v8/DebuggerScript.js:
              ():
              * bindings/v8/ScriptDebugServer.cpp:
              (WebCore::ScriptDebugServer::setBreakpoint):
              * inspector/Inspector.json:
              * inspector/InspectorDebuggerAgent.cpp:
              (WebCore::buildObjectForBreakpointCookie):
              (WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
              (WebCore::InspectorDebuggerAgent::setBreakpoint):
              (WebCore::InspectorDebuggerAgent::continueToLocation):
              (WebCore::InspectorDebuggerAgent::didParseSource):
              * inspector/InspectorDebuggerAgent.h:
              * inspector/ScriptBreakpoint.h:
              (WebCore::ScriptBreakpoint::ScriptBreakpoint):
              * inspector/front-end/DebuggerModel.js:
              (WebInspector.DebuggerModel.prototype.setBreakpoint):
              (WebInspector.DebuggerModel.prototype.setBreakpointBySourceId):
              * inspector/front-end/DebuggerPresentationModel.js:
              (WebInspector.DebuggerPresentationModel):
              (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
              (WebInspector.DebuggerPresentationModel.prototype._updateBreakpointsAfterLiveEdit):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint.callback):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger):
              (WebInspector.DebuggerPresentationModel.prototype._setBreakpointInDebugger.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._removeBreakpointFromDebugger):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled.afterUpdate):
              (WebInspector.DebuggerPresentationModel.prototype.setBreakpointEnabled):
              (WebInspector.DebuggerPresentationModel.prototype.updateBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype.removeBreakpoint):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded.didRequestSourceMapping):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
              (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
              (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpointsFromSettings):
              (WebInspector.DebuggerPresentationModel.prototype._saveBreakpoints):
              (WebInspector.DebuggerPresentationModel.prototype._reset):
              (WebInspector.PresentationBreakpoint):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83190 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      05d9ce24
    • jberlin@webkit.org's avatar
      [WebKit2 Tests] fast/events/select-element.html failing since introduction in r83096 · 73660610
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=58059
      
      Adding this test to the mac-wk2 skipped list to get the bots green.
      
      * platform/mac-wk2/Skipped:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83189 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      73660610
    • jberlin@webkit.org's avatar
      WebKit2: Implement TextChecker on Windows · 91a2855c
      jberlin@webkit.org authored
      https://bugs.webkit.org/show_bug.cgi?id=57862
       
      Reviewed by Adam Roben.
      
      Part 3: Implement checkSpellingOfString
      
      In WebCore, checkTextOfParagraph is only defined and used on platforms where
      WTF_USE_UNIFIED_TEXT_CHECKING is defined (which right now is only non-Leopard and non-Tiger
      Mac builds).
       
      On other platforms, checkSpellingOfString and checkGrammarOfString (coming in a separate
      patch in an attempt to keep things easier to review) are used.
      
      * UIProcess/API/C/win/WKTextChecker.h:
      * UIProcess/TextChecker.h:
      Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
      checkSpellingOfString.
      
      * UIProcess/WebPageProxy.cpp:
      (WebKit::WebPageProxy::checkTextOfParagraph):
      Surround this by #if USE(UNIFIED_TEXT_CHECKING).
      (WebKit::WebPageProxy::checkSpellingOfString):
      Call through to the client.
      * UIProcess/WebPageProxy.h:
      * UIProcess/WebPageProxy.messages.in:
      Surround checkTextOfParagraph by #if USE(UNIFIED_TEXT_CHECKING) and add
      checkSpellingOfString.
      
      * UIProcess/win/TextCheckerWin.cpp:
      (WebKit::TextChecker::checkSpellingOfString):
      Call through to the WebTextCheckerClient.
      * UIProcess/mac/TextCheckerMac.mm:
      (WebKit::TextChecker::checkTextOfParagraph):
      Surround this by #if USE(UNIFIED_TEXT_CHECKING) for clarity.
      (WebKit::TextChecker::checkSpellingOfString):
      Add a call to notImplemented.
      * UIProcess/qt/TextCheckerQt.cpp:
      (WebKit::TextChecker::checkSpellingOfString):
      Ditto, and remove the implementation for checkTextOfParagraph.
      * UIProcess/gtk/TextCheckerGtk.cpp:
      (WebKit::TextChecker::checkSpellingOfString):
      Ditto.
      
      * UIProcess/win/WebTextCheckerClient.cpp:
      (WebKit::WebTextCheckerClient::checkSpellingOfString):
      * UIProcess/win/WebTextCheckerClient.h:
      
      * WebProcess/WebCoreSupport/WebEditorClient.cpp:
      (WebKit::WebEditorClient::checkSpellingOfString):
      Send a sync message to the UI Process (similar to the sync message used for
      checkTextOfParagraph).
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83188 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      91a2855c
    • enne@google.com's avatar
      2011-04-07 Adrienne Walker <enne@google.com> · 829ec707
      enne@google.com authored
              [chromium] Unreviewed, now that bug 57975 is fixed, mark test as passing.
      
              * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@83187 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      829ec707