GitLab

Following bot results are included.
2493 2495 2496 2498 2499 2500 2502 2505 2508 2511 2512 2513 2524 2526

16 lines were removed by consecutive passes since 2485.

TBR=eae@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I1c0ecfac97903ff168d97597290ebf7f17037de9
Reviewed-on: https://chromium-review.googlesource.com/831309
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524623}

TBR=nednguyen@chromium.org
BUG=795585

Change-Id: Idbe16201235a53ad7669478d58611708e607d5bc
Reviewed-on: https://chromium-review.googlesource.com/831508Reviewed-by: oysteine <oysteine@chromium.org>
Commit-Queue: oysteine <oysteine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524622}

We would like to sync this data in order to make sync-ed history entries
corresponding to history.replaceState() and similar Javascript events
distinguishable from user-initiated events (typed URLs or clicks on
bookmarks).

Most notably, this solves the problem of duplicates in the NTP for
server-side suggestions, which otherwise may count the URL after
replaceState() as being typed by the user and hence worth suggesting.

Design Doc (accessible to Google employees only):
https://docs.google.com/document/d/1g8w7VkLjI1V1f5N_Hkn3Lb66C3iUbV91SufFu2vEBSk/

Bug: 751023
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I7616d5f1782c0ee9af779d2c102a29b042ce44a1
Reviewed-on: https://chromium-review.googlesource.com/738095Reviewed-by: Stefan Kuhne <skuhne@chromium.org>
Reviewed-by: Nicolas Zea <zea@chromium.org>
Reviewed-by: Charlie Reis <creis@chromium.org>
Commit-Queue: Mikel Astiz <mastiz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524621}

This patch adds support for clang-based AFDO to Chromium.

AFDO stands for Automatic Feedback Directed Optimization. In short, it
allows you to use the postprocessed output of a special `perf` command
to inform the compiler of hot/cold code, among other things.

This allows users to easily specify a profile to use, and allows for
platforms to specify default profiles. It turns none of this on on its
own.

At the moment, this is very sharp and pointy, since the sample profile
isn't a dependency for anything. Ideally, anything built with AFDO
should depend on the profile. I have a CL to make this easily possible
(CL:827560), but think this is useful enough (given care) to get in now.

(and with clang_use_default_sample_profile set to true). We built
with profiles and failed to `gn gen`, respectively. Patch seemed to be
a nop running on an otherwise "regular" build.

Bug: 794750
Test: Ran the build with and without clang_default_afdo_profile defined
Change-Id: I7b2730d52875f108681232f4d8ce7e82e7570a74
Reviewed-on: https://chromium-review.googlesource.com/828277Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: George Burgess <gbiv@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524620}

Adding UMA for saving and deleting pages:
- Refactored DeletePageTask for metric collection.
- Added new histogram names and made old ones obsolete.
- Updated related tests with histogram tester.

This CL also contains:
- Renamed test_util to test_utils for consistency.
- Added offline_pages::model_utils for utility methods used across all
  tasks and model itself.
- Updated OfflinePageItemGenerator for testing support

Bug: 772204
Change-Id: I894da05d510addbf01f3dd9b7ccda29b27404752
Reviewed-on: https://chromium-review.googlesource.com/811829Reviewed-by: Mark Pearson <mpearson@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524619}

TBR=chrome-os-gardeners@google.com

Change-Id: I118b5e3c5799130dc23cde5ee601d50b7f331631
Reviewed-on: https://chromium-review.googlesource.com/831566Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524618}

TBR=govind@chromium.org

Change-Id: I98fdf9497b8e9ac33ff1554c02898296e590a16c
Reviewed-on: https://chromium-review.googlesource.com/830791Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524617}

Previously VoiceInteractionControllerClient has the same life cycle as
ArcVoiceInteractionFrameworkService, which is only alive when primary
profile running and has ARC++ enabled.  This life cycle isn't a good
fit for VoiceInteractionControllerClient since it is used to update
Ash states, which has a global life time.  It caused bugs like in multi-
profile, and restricted profile, Ash UI wasn't properly rendered.

BUG=b:68664196
TEST=unit tests and locally build and manually test multi-profile

Change-Id: I8495e2c41274db385741b86d778c96e15a25b977
Reviewed-on: https://chromium-review.googlesource.com/827540
Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524616}

This change adds a class which shows a Presentation API receiver page in
a popup-style window that is started fullscreen on a specific wired
display.

It also changes the handling of one-off OTR profiles used by
presentations, which affects this class and offscreen tabs.  Previously,
offscreen tabs assumed ownership of their OTR profiles.  However, it was
possible for this to be violated by opening a DevTools window and
Browser would think that it could destroy the profile.  Additionally,
there was no handling of the original profile being destroyed, which
would leave dangling references in the OTR profile.  This has been
addressed by adding an IndependentOTRProfileManager class, which helps
both offscreen tabs and PresentationReceiverWindow manage the lifetime
of these one-off OTR profiles.

Bug: 777654, 786158, 664351, 727487
Change-Id: I64d032419d341affbdde4ee80b57d45c99648588
Reviewed-on: https://chromium-review.googlesource.com/742122
Commit-Queue: Brandon Tolsch <btolsch@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Reviewed-by: Derek Cheng <imcheng@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524615}

Bug: none
Change-Id: I4bce34a6169cf655a02129f5ff0a265a3f6b89a3
Reviewed-on: https://chromium-review.googlesource.com/831060Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524614}

This reverts commit 86c790e6.

Reason for revert: This is causing performance / memory regressions that are trickier to address than expected. Reverting this for now.

Original change's description:
> Remove use of DeferredTextureImageData APIs and Support Decode to Scale
> 
> We aren't benefitting from the complexity added by the
> DeferredTextureImageData APIs, and this API blocks us from using
> PaintImage::Decode's decode-to-scale functionality.
> 
> This change removes our usage of DeferredTextureImageData APIs,
> instead using SkImage::makeTextureImage to handle upload. Additionally,
> we now use the PaintImage::Decode API, adding decode-to-scale support.
> 
> Bug: 773799
> Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel
> Change-Id: Ia5f480213c3a5c8225ccd289aa2c081056840f94
> Reviewed-on: https://chromium-review.googlesource.com/713593
> Reviewed-by: vmpstr <vmpstr@chromium.org>
> Commit-Queue: Eric Karl <ericrk@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#517206}

TBR=vmpstr@chromium.org,ericrk@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 773799
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: Ie4493559e334100f03dfed1dfb7a408fc26a33e0
Reviewed-on: https://chromium-review.googlesource.com/830587
Commit-Queue: Eric Karl <ericrk@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524613}

Now that we have compression enabled, system tracing doesn't cause
flakes due to filling up /tmp, and we should be able to safely turn
it on by default.

Also increase the websocket timeout, since very large traces might take
more than 10s to compress.

BUG=786091
TEST=trace.py

Change-Id: I65726a723eb4b28466f4bff0dd818db916165227
Reviewed-on: https://chromium-review.googlesource.com/830916Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Commit-Queue: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524612}

TBR=zea@chromium.org

Change-Id: I84aa98d03d40cb98f7f43788389e6aa9a9607249
Reviewed-on: https://chromium-review.googlesource.com/831250Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524611}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/99da619f6cdc..454acc12ef55

$ git log 99da619f6..454acc12e --date=short --no-merges --format='%ad %ae %s'
2017-12-15 iannucci [vpython] Bump depot_tools version of vpython.

Created with:
  roll-dep src/third_party/depot_tools


The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=phajdan.jr@chromium.org

Change-Id: I5273810e26fe3a0728b9decfa0e73ab3f2403b56
Reviewed-on: https://chromium-review.googlesource.com/830518Reviewed-by: depot-tools-roller . <depot-tools-roller@chromium.org>
Commit-Queue: depot-tools-roller . <depot-tools-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524610}

This CL is part of VectorMath code clean up series:
[1/4] https://chromium-review.googlesource.com/c/824046
[2/4] https://chromium-review.googlesource.com/c/824047
[3/4] this CL
[4/4] https://chromium-review.googlesource.com/c/824049

Bug: 778262
Change-Id: I26f4e6cf672e2739e93cbf2a52dc44d776deec70
Reviewed-on: https://chromium-review.googlesource.com/824048Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#524609}

This changes the gclient hook to run only conditionally on
linux, which keeps it from running and printing stuff on
the other platforms.

R=jbudorick@chromium.org

Change-Id: Id1dbfb50f139308b3c39875e00294ea9a0a76016
Reviewed-on: https://chromium-review.googlesource.com/831219Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524608}

This CL is part of VectorMath code clean up series:
[1/4] https://chromium-review.googlesource.com/c/824046
[2/4] this CL
[3/4] https://chromium-review.googlesource.com/c/824048
[4/4] https://chromium-review.googlesource.com/c/824049

Bug: 778262
Change-Id: If74c8bc5761b73a4282de20ae4c72e6ad839e464
Reviewed-on: https://chromium-review.googlesource.com/824047Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Raymond Toy <rtoy@chromium.org>
Commit-Queue: Eero Häkkinen <eero.hakkinen@intel.com>
Cr-Commit-Position: refs/heads/master@{#524607}

https://skia.googlesource.com/skia.git/+log/594706566a62..ef0384835757

$ git log 594706566..ef0384835 --date=short --no-merges --format='%ad %ae %s'
2017-12-16 reed remove deprecated SkPixelSerializer

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Ic32ec8ddd05a47ae5eeb0c1725a654f60dcf1acc
Reviewed-on: https://chromium-review.googlesource.com/831467Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524606}

https://skia.googlesource.com/skia.git/+log/dd821bc56488..594706566a62

$ git log dd821bc56..594706566 --date=short --no-merges --format='%ad %ae %s'
2017-12-16 reed remove dead SK_SUPPORT_LEGACY_IMAGEDESERIALIZER code

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Ica74a7dd036510eeb431ce38ed498156d2039b23
Reviewed-on: https://chromium-review.googlesource.com/831351Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524605}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7be4ef7e..62729327

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: Ia7c0b1871759681d9ec6b362c1ebc6941a3be89f
Reviewed-on: https://chromium-review.googlesource.com/830932Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524604}

Dereferencing a null extension(), change it to use extension_id_safe()

bug: chromium:795399
Change-Id: If072049509dca199707c48ff374c6a296b45625a
Reviewed-on: https://chromium-review.googlesource.com/831186Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Ivan Šandrk <isandrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524603}

Record the time elapsed since last time there is no partner
bookmark. This will help tune the banning duration and skipping
rate.

Bug: 787132
Change-Id: I70864105f19a315674b4f525ecc7cfe3905b01c9
Reviewed-on: https://chromium-review.googlesource.com/826365Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524602}

Record time spent on reading partner bookmarks, since this is part of
the critical path of showing bookmark UI.

Bug: 787132
Change-Id: I8aa68436b0d762d644691992bde0e2df095259f0
Reviewed-on: https://chromium-review.googlesource.com/825004Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524601}

https://pdfium.googlesource.com/pdfium.git/+log/175f01bb081b..682118834b3c

$ git log 175f01bb0..682118834 --date=short --no-merges --format='%ad %ae %s'
2017-12-16 thestig Fix null-dereference in CPDF_ShadingPattern::Load().

Created with:
  roll-dep src/third_party/pdfiumBUG=795490


The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=dsinclair@chromium.org

Change-Id: I6ddeaa08056edde34d2469221124f90d704dec0f
Reviewed-on: https://chromium-review.googlesource.com/831116
Reviewed-by: <pdfium-deps-roller@chromium.org>
Commit-Queue: <pdfium-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524600}

TBR=chrome-os-gardeners@google.com

Change-Id: I3fd9414ddcfd6910226f841e998837028a8ff573
Reviewed-on: https://chromium-review.googlesource.com/831076Reviewed-by: ChromeOS Commit Bot <chromeos-commit-bot@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524599}

Only 6 new events that ChromeVox actually uses are migrated by this
change. I added comments to the other events to keep track of which
ones are candidates for migration or for removal in the future.

Bug: 699438, 788893
Change-Id: Ica13cd36369770242a20954c020e80f0f1fbff63
Reviewed-on: https://chromium-review.googlesource.com/820353
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524598}

Expose renderer hit test API to the browser
with a mojo interface. With this API browser
can ask a renderer about the target frame
of a given point. The API returns the sink id
of the target frame. The result frame could be
either a remote or local frame from the
renderer's point of view.

Bug: 732405
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_site_isolation
Change-Id: I2606dbeb71eb0cc7d593c80eb73cbcb24d2774ad
Reviewed-on: https://chromium-review.googlesource.com/751721Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Navid Zolghadr <nzolghadr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524597}

http://crrev.com/524139 moved WatchTimeRecorderProvider and
VideoDecodeStatsRecorder into MediaMetricsProvider, but forgot
to update the manifest.

BUG=779192
TEST=no more connection errors

Change-Id: I5cc2c4401545979b788dd028fee9a76c8584edbd
Reviewed-on: https://chromium-review.googlesource.com/831220
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524596}

BUG=521776

Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I166b8e48a70cfbbc37f72490b4bcedc383653123
Reviewed-on: https://chromium-review.googlesource.com/674751
Commit-Queue: Lei Zhang <thestig@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Rebekah Potter <rbpotter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524595}

https://chromium.googlesource.com/catapult.git/+log/cb66d9d95233..ad4583d06ecd

$ git log cb66d9d95..ad4583d06 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 dtu [pinpoint] Defer Commit creation when resolving DEPS.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: Ia7b193f41ca6a1894ee6541d2e19013ea330b5e1
Reviewed-on: https://chromium-review.googlesource.com/831388
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524594}

We removed this typemap when moving the mojom into WebKit, now we add it
back to do the marshaling between ClipboardBuffer and ClipboardType on
the browser side.

As we don't intend at this time to send messages of this type in the
opposite direction we only implement the FromMojom method in
clipboard_struct_traits.

Bug: 775830
Change-Id: Ib3dacbcc5b3c029167e902afbf7c8c5c809f1ee9
Reviewed-on: https://chromium-review.googlesource.com/823542Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524593}

GetHashes() doesn't modify ComputedHashes::Reader.


Bug: None
Change-Id: I879d164539ed905e5fcb80c8eaa333ba04c42d5a
Reviewed-on: https://chromium-review.googlesource.com/827614Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524592}

The original landing broke EGTests for iOS Simulator and Device which
were not run by the CQ. This change includes updated EGTests.

TBR=pkasting@chromium.org

Bug: 789163, 643458
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: Ie30afcb7bcba5affc7266d72a10b7f8dc0074314
Reviewed-on: https://chromium-review.googlesource.com/830093Reviewed-by: Eric Lawrence <elawrence@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Eric Lawrence <elawrence@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524591}

ContentHashReader doesn't need to remember whether each of
"verified_contents.json" and "computed_hashes.json" were found
correctly, the caller only cares whether both of them are present or
not. Collapse the two bools into one.

Bug: None
Change-Id: Idc0b0538f66ff88767acee87eba048ecd429df00
Reviewed-on: https://chromium-review.googlesource.com/828543
Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524590}

Update the handler for Generate Page Bundle button, so that output
text has information needed by UI automation test.

Bug: 794011
Change-Id: I67894eab2fac59cb0368e5dda53552bb889a0009
Reviewed-on: https://chromium-review.googlesource.com/823210Reviewed-by: Tommy Li <tommycli@chromium.org>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524589}

Before crrev.com/c/695934, a top message was always being displayed.
Now thats not the case, this CLremoves the top cell that contains the message if there's no message.

Also, on iOS11 the contentInset was being adjusted automatically, causing an even larger
blank space on top. This is fixed by setting the ContentInsetAdjustmentBehavior to never.

Screenshots:
https://drive.google.com/open?id=1N6egGvEOeSF2uags3w4hmLupWy7Vk4v3
https://drive.google.com/open?id=1hCW15FIUtw2o5rJ7MiqDcRd1z6Xq42O0

Bug: 778571
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I2b9f2b5f92e22f955fb10c5ea609f4ee4f130836
Reviewed-on: https://chromium-review.googlesource.com/830911
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Louis Romero <lpromero@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524588}

Bug: none
Change-Id: Ic7cc7e665a8dd5f8999b2243b3fae342f5c8d960
Reviewed-on: https://chromium-review.googlesource.com/830681Reviewed-by: Andrey Lushnikov <lushnikov@chromium.org>
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524587}

Chrome's copy of ICU is built with U_CHARSET_IS_UTF8=1 so that |char *|
buffer is treated as UTF-8 when constructing UnicodeString() regardless
of the default encoding of the current locale on Linux or non-Unicode code
page on Windows.

However, some Linux distros do not set U_CHARSET_IS_UTF=1 when building
ICU and Chromium build with system_icu crashes when Chromium is run in
non-UTF-8 locale (e.g. 'C').

To make Chromium work in a non-UTF-8 locale (which is pretty rare these
days), use 'icu::UnicodeString::fromUTF8(StringPiece)' instead of
'icu::UnicodeString(const char*)'.

Bug: 772655
Test: components_unittests --gtest_filter=*IDN*
Test: Chromium built with system_icu does not crash in C locale.
Change-Id: I0daa284ec06b8e83814fc70eb8e9e5c96444ebfa
Reviewed-on: https://chromium-review.googlesource.com/831247Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Jungshik Shin <jshin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524586}

https://skia.googlesource.com/skia.git/+log/29c14a760682..dd821bc56488

$ git log 29c14a760..dd821bc56 --date=short --no-merges --format='%ad %ae %s'
2017-12-16 ericrk Revert "Increase accuracy of float -> fixed in ICC code"
2017-12-15 ericrk Revert "Remove SkImage deferred texture image data APIs."
2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ e42ec189c..647dca767 (2 commits)
2017-12-15 benjaminwagner Add Goma to CQ as experimental.
2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ 9fc873318..e42ec189c (1 commit)
2017-12-15 reed Revert "Revert "remove SK_SUPPORT_LEGACY_PDF_PIXELSERIALIZER dead code""
2017-12-15 reed Revert "Revert "hide SkImageDeserializer""
2017-12-15 brianosman Remove unnecessary includes from Viewer
2017-12-15 reed hide unused var
2017-12-15 brianosman Increase accuracy of float -> fixed in ICC code
2017-12-15 caryclark move homogenous with stride to matrixpriv
2017-12-15 angle-deps-roller Roll skia/third_party/externals/angle2/ 195be9424..9fc873318 (2 commits)
2017-12-14 bsalomon Remove fallback in GrRenderTargetContext for using coverage to draw paths with msaa
2017-12-15 benjaminwagner Use n1-highcpu-64 machines for Windows Builds.
2017-12-15 mtklein add 0->0 path to approx_powf()
2017-12-15 reed Revert "hide SkImageDeserializer"
2017-12-11 halcanary SkQP: make_gmkb, gm_knowledge (GM Knowledgebase)
2017-12-15 bsalomon Transform vertices for distance field glyphs on CPU.

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=liyuqian@chromium.org

Change-Id: Idf78fbf655920981240cc56a07d78147265fd634
Reviewed-on: https://chromium-review.googlesource.com/831262Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524585}

We want to be able to recognize when the PCA rejects an improper
request versus a transient failure. We use the bad request status to
upload an empty enrollment certificate to the Cloud to indicate that
a machine cannot obtain en enrollment certificate because it is not
able (setup) to do attestation-based enrollment.

BUG=chromium:778535
TEST=unit tests

Change-Id: Ic8b3684dc85895fe23bd192d534393fe45fc1a07
Reviewed-on: https://chromium-review.googlesource.com/823173
Commit-Queue: Yves Arrouye <drcrash@chromium.org>
Reviewed-by: Darren Krahn <dkrahn@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524584}