- 16 Aug, 2019 40 commits
-
-
Emily Stark authored
Committed interstitials for HTTP auth renders the 401 body underneath the auth prompt. This has proven to be problematic in some cases (see bug). This CL disables committed interstitials for HTTP auth by default while I work on a fix for avoiding rendering the 401 body. Bug: 992639 Change-Id: I63195a66c4ad81452e24d260afdc7dd938eab769 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756638Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#687695}
-
Ken Rockot authored
This removes all Service Manager dependencies from the Font Service in favor of direct Mojo interface connection. The browser maintains an internal API for connecting new pipes to the in-process service instance. This requires ChildProcessHostImpl to support the BindHostReceiver() mojom API for non-renderer child processes, as well as plumbing it up to UtilityProcessHost and PluginProcessHost. Rather than generic support through Service Manager with manifest-based filtering, each process host type explicitly implements its support for binding the FontService interface when requested by the child process. This CL also fixes some thread-safety bugs in the existing Font Service client library code which could cause the client endpoint and/or the WeakPtrFactory to be destroyed on the wrong sequence. FontServiceThread has been refactored to make the WeakPtrFactory unnecessary, and the client endpoint is now always destroyed on the correct sequence. Finally, this changes font_service_unittests to use an in-process background service instance rather than using the Service Manager to spin up a dedicated service executable. Bug: 977637 Change-Id: I3efdafb06ae2d79e9cb149675e49c29e30d0cad6 Test: for good measure, manually tested PDF rendering Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756435 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#687694}
-
Koji Ishii authored
Reduces crashes in the enabling CL[1]. [1] https://crrev.com/c/1719913 Bug: 988015 Change-Id: I78cbd3730957616ce5f70e9c69368a18b1d9d996 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757965 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Auto-Submit: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#687693}
-
Dominik Röttsches authored
The feature has been tested at 50% in beta. Before marking it as rolled out for 100% in the experimentation configuration, activate it to 100% on ToT. Bug: 627143, 828317 Change-Id: I8824ef67c48846533d30f0b5416bcc184354dbcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1752829 Commit-Queue: Dominik Röttsches <drott@chromium.org> Auto-Submit: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Cr-Commit-Position: refs/heads/master@{#687692}
-
Jeremy Chinsen authored
Currently the PDF Viewer goes to the next/previous page by calling ViewportImpl.goToPage() with the result of ViewportImpl.getMostVisiblePage() +/- 1, respectively. This assumes that the layout is in single-view and makes it so that PDF viewer needs to know what layout the document is in. This CL adds goToNextPage() and goToPreviousPage() to ViewportImpl which moves the aforementioned page traversal logic out of PDF viewer and into ViewportImpl. This allows PDF viewer to traverse the document correctly without having to know what layout the document is in. Bug: 51472 Change-Id: If1880d5fb35283ecc8d05a2529f8d7626265402a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757148Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Jeremy Chinsen <chinsenj@google.com> Cr-Commit-Position: refs/heads/master@{#687691}
-
Morten Stenshorne authored
This is extremely slow with the legacy layout engine (about 5 runs per second here), and also with the current LayoutNG feature set, but not with LayoutNGBlockFragmentation enabled (about 1000 runs per second here). Bug: 990319 Change-Id: I649c49b3732027400daa33ff968ed22790c1c1a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755987Reviewed-by:
-
Sahel Sharify authored
This cl disables PointerLockBrowserTest.PointerLockWheelEventRouting browsertest on Windows. sample flakes: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyXAsSBUZsYWtlIlFjaHJvbWl1bUBjb250ZW50X2Jyb3dzZXJ0ZXN0c0BQb2ludGVyTG9ja0Jyb3dzZXJUZXN0LlBvaW50ZXJMb2NrV2hlZWxFdmVudFJvdXRpbmcM TBR=mustaq@chromium.org,nzolghadr@chromium.org NOTRY=true Bug: 994228 Change-Id: I935cb93ffafd47dfb1a8fdb4a06e13a8e5c6c903 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758483Reviewed-by:
Sahel Sharify <sahel@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#687689}
-
Kamila authored
[Tests incoming in other cl] Background-------------------------------------------------------------- Starting with Mojave, Camera and Mic are now also manageable in System Preferences in macOS. This cl adds the UI bubble to be shown when a site has tried to access Microphone and/or Camera, and these permissions have been previously allowed in Chrome but not in the OS level. The button in the bubble, leads the user to the System Preferences>Security and Privacy. Details----------------------------------------------------------------- - Changing icon from a static one to a sliding one for the above scenario. - Switching to a different bubble ui for when: a) Camera is blocked b) Microphone is blocked c) Camera and Microphone are blocked. - Button which leads user to System Preferences > Security and Privacy - Gathering user actions for when: a) "Open Preferences" button is clicked. b) Sliding camera or microphone icon is clicked. Known issues------------------------------------------------------------ - When you click on "Open preferences" button, when camera and microphone are blocked, you are led to only camera first. The user has to figure out that they should also switch on Mic. Screenshots------------------------------------------------------------- - Screenshots and gifs slides (general): https://docs.google.com/presentation/d/1xgXc2m2jMKyeA1T7Cjbf-2kc5tSxGA1haWFNHt55dX8/ edit?usp=sharing - Screenshots:https://imgur.com/a/irE9WHa Change-Id: Idcd04a131b81e3991c089e8f9e840d1da1ea7a4b Bug: 940893 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1623087 Commit-Queue: Kamila Hasanbega <hkamila@google.com> Reviewed-by:
Michael Wasserman <msw@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#687688}
-
Qingsi Wang authored
The current buffer size often induces ERR_MSG_TOO_BIG and increases the chance that we miss expected messages. Bug: 993770 Change-Id: I067782f0aa287627a6948b0286771d3fe54aef18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757395Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Qingsi Wang <qingsi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687687}
-
Lindsay Pasricha authored
to roll in status bar fix. https://chromium.googlesource.com/external/github.com/google/EarlGrey.git/+log/6791abc9c6967ce01b2c069e36065e59f46994ac 6791abc Optimizing visibility checker by only drawing portions necessary for screenshots. by Mobile DevX Robot · 4 days ago earlgrey2 0fea3ae Optimizing visibility checker by only drawing portions necessary for screenshots. by Mobile DevX Robot · 4 days ago 186436d Delete crash in remote executor. by Aditya Atul Tirodkar · 7 days ago 054822e Don't try and check for visibility of views that are definitely not visible by Aditya Atul Tirodkar · 8 days ago 690fdaa Move handler getter to NSThread mainThread. by Aditya Atul Tirodkar · 8 days ago fb37152 Collect gVisibilityDuration across all methods. by Mobile DevX Robot · 8 days ago 110b879 Don't try and check for visibility of views that are definitely not visible by Mobile DevX Robot · 9 days ago 4c4b2b0 Format block to use var and use return value instead of touching error directly. by Sundeep Khandpur · 9 days ago a9fd663 Change EG2 and eDO to build all archs by Brett Fazio · 10 days ago 4b503fa Fix unused variable warning. by Aditya Atul Tirodkar · 10 days ago 861c515 Shorten the names of failure artifacts by getting rid of the screenshot prefix. by Sundeep Khandpur · 10 days ago a1575e4 Nix documentation line saying to use 'gem install earlgrey' by Brett Fazio · 10 days ago 1b93403 Add Interaction point info in matcher. by Aditya Atul Tirodkar · 11 days ago f942ffb iOS 13 build fix. by Aditya Atul Tirodkar · 11 days ago Bug:991334,977161 Change-Id: Idc71bdff3e3022caef57eb22b27f3e06109b12a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727890 Commit-Queue: Lindsay Pasricha <lindsayw@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#687686}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/96a45cf8d1b0..2ab018e61faa Created with: gclient setdep -r src-internal@2ab018e61faa The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I521c842bea22efad09640c29473538b195746438 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758138Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687685}
-
Abhijeet Kandalkar authored
This CL has two goals, 1. Use To<HTMLMarqueeElement> as new downcast helper. 2. Use IsA<HTMLMarqueeElement>(element) in place of IsHTMLMarqueeElement(element). Bug: 891908 Change-Id: I762bce76eb27442a192b914fb3167106df8452e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758184Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Commit-Queue: Abhijeet Kandalkar <abhijeet@igalia.com> Cr-Commit-Position: refs/heads/master@{#687684}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/791e19e774ce..125154257bc2 git log 791e19e774ce..125154257bc2 --date=short --no-merges --format='%ad %ae %s' 2019-08-16 jmadill@chromium.org Remove context from linking state. Created with: gclient setdep -r src/third_party/angle@125154257bc2 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Bug: None Change-Id: I07319d47c3cd09a65d2be66d045f65bc4946694d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758136Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687683}
-
Clark DuVall authored
Now that NavigationLoaderOnUI is launched, we don't need to handle running this on two different threads. Bug: 824854 Change-Id: Id53b3331aac6ccf52ab5e52b0e80542095c842d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756428Reviewed-by:
Tsuyoshi Horo <horo@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#687682}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/7ee0ac8ea00f..e48647012eba git log 7ee0ac8ea00f..e48647012eba --date=short --no-merges --format='%ad %ae %s' 2019-08-16 taylori@google.com Merge "Revert "Split up FrontendLocalState"" Created with: gclient setdep -r src/third_party/perfetto@e48647012eba The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I783880ec3de51c06c51c9a9170aa98064accdcc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758135Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/97d3ec761eb6..6a630d42ad20 git log 97d3ec761eb6..6a630d42ad20 --date=short --no-merges --format='%ad %ae %s' 2019-08-16 perezju@chromium.org [Telemetry] Add text/html content type for artifacts Created with: gclient setdep -r src/third_party/catapult@6a630d42ad20 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:966835 Change-Id: Id2af919ff9a4cb0ac9ee922c2d57383fc03670ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758137Reviewed-by:
-
Sky Malice authored
This fixes the feedless build because FeedRefreshTask is used outside of feed specific code. When feed is compiled out, the feed-extenal code needs to a FeedRefreshTask object to instantiate and use. Bug: 993858 Change-Id: I7cf588e4709bbd64d556feb34eb12339a2ab9f22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754704 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#687679}
-
Victor Costan authored
Change-Id: I9ccce314272b75c9e5f868cea4c825c0df12ca4b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757462 Auto-Submit: Victor Costan <pwnall@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#687678}
-
Sahel Sharify authored
This cl marks animations/events/play-state-initially-paused-start-event.html as flaky. sampe flakes: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=animations%2Fevents%2Fplay-state-initially-paused-start-event.html NOTRY=TRUE Bug: 994746 Change-Id: I6238f233ac6e4ff524b6472b7a6e9153cd02c5e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758214Reviewed-by:
-
Sahel Sharify authored
This reverts commit 3fafe5c5. Reason for revert: The newly added test wpt_internal/display-lock/rendersubtree/activation/selection.html is flaky. https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVycAsSBUZsYWtlImVjaHJvbWl1bUBibGlua193ZWJfdGVzdHNfZXhwYXJjaGl2ZUB3cHRfaW50ZXJuYWwvZGlzcGxheS1sb2NrL3JlbmRlcnN1YnRyZWUvYWN0aXZhdGlvbi9zZWxlY3Rpb24uaHRtbAw Original change's description: > DL: Make selection activate locked elements & ignore non-activatable subtrees > > Previously selection just skips over locked subtrees (like > visibility:hidden), though it still crashes in some cases (see > crbug.com/988033). This CL makes selecting nodes within locked > subtrees activate/unlock the locks if they're activatable, > and ignore them if they're not. > > Rejecting acquire() if a node is included in a selection already > will be implemented in another CL. > > Bug: 988033, 966802 > Change-Id: Icc54cf56f5f54ef4f893172e560b9bbc6ae4402a > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728451 > Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> > Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org> > Reviewed-by: Kent Tamura <tkent@chromium.org> > Reviewed-by: vmpstr <vmpstr@chromium.org> > Commit-Queue: Rakina Zata Amni <rakina@chromium.org> > Cr-Commit-Position: refs/heads/master@{#687530} TBR=yosin@chromium.org,vmpstr@chromium.org,chrishtr@chromium.org,tkent@chromium.org,xiaochengh@chromium.org,rakina@chromium.org Change-Id: Id714a5b86e05aa60a32fe918e58bec17931b2caa No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 988033, 966802 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758216Reviewed-by:
-
Kamila authored
These strings have been modified from the UI side, changing them in the codebase as well. Bug: 986737 Change-Id: Ib7f0d01c145e69d2b4e0135e302c504162af2430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754204Reviewed-by:
-
Eric Stevenson authored
To create this change: * cd chrome/android/features * base/android/jni_generator/jni_refactorer.py -R --nonstatic * base/android/jni_generator/jni_refactorer.py -R * Change the native side of VrShellDelegateJni#recordVrStartAction to not pass the Java object Bug: 929661 Change-Id: I1d2c57e0f7a30a8b7e50e9e3ce905172cbb761cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1749737 Commit-Queue: Eric Stevenson <estevenson@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Auto-Submit: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#687674}
-
yongseok-choi authored
Bug: 648382 Change-Id: I43525db40843528773cae2a675e6a28a244dc46d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1735228 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#687673}
-
Abhijeet Kandalkar authored
This CL convert .h/.cc to use new mojo types and port dependent files to adopt new implementation. Bug: 955171, 978694 Change-Id: I80bba8d7c1caa5597d1456371d4050b00968ac90 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755797Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Sahel Sharify authored
This cl marks compositing/reflections/nested-reflection-anchor-point.html as flaky on Windows and Linux. flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=webkit_layout_tests&tests=compositing%2Freflections%2Fnested-reflection-anchor-point.html TBR=schenney@chromium.org NOTRY=TRUE Bug: 994692 Change-Id: I3b0c5b624ce24f4c34207fb3edada8146545ce78 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757088Reviewed-by:
-
Ben Kirchman authored
Bug: 994428 Change-Id: I590987ce4d5e583e9b91252b739ca67d4cfdea66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758324 Commit-Queue: Benjamin Kirchman <kirchman@google.com> Commit-Queue: Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687670}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d5ecd93e. With Chromium commits locally applied on WPT: 329c91e5 "Attempt to make test more stable" 02426f68 "Rewrite interpolation-testcommon.js" be8f9eea "[IntersectionObserver] Use inclusive intersect with remote frame parent" 4ba540d7 "Clean up WPT TestExpectations for CSS animations and transitions" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6265eeb3a545a5dd4aada053599638a8caccafdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757486Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#687669}
-
Jeffrey Cohen authored
Revert "[SendTabToSelf] Use new cache guid method to assert that local device is not listed as a target" This reverts commit 38392a67. Reason for revert: This caused a regression crbug/991943 on android and i have been unable to determine a root cause of that platform treating the current local cache guid differently than other platforms. Original change's description: > [SendTabToSelf] Use new cache guid method to assert that local device is not listed as a target > > Bug: 966413 > Change-Id: I29fe887806b07a51d7490603aaf81415a5a349cb > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721379 > Commit-Queue: Jeffrey Cohen <jeffreycohen@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Cr-Commit-Position: refs/heads/master@{#682341} TBR=mastiz@chromium.org,jeffreycohen@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 966413 Change-Id: I054d328715c6d71944f06946f5e2631501835cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757168Reviewed-by:
Jeffrey Cohen <jeffreycohen@chromium.org> Reviewed-by:
Ramya Nagarajan <ramyan@chromium.org> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org> Auto-Submit: Jeffrey Cohen <jeffreycohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#687668}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/material-components/material-components-ios/+log/26ba6a09142b..2ed6691f2848 git log 26ba6a09142b..2ed6691f2848 --date=short --no-merges --format='%ad %ae %s' 2019-08-16 rsmoore@google.com Merge branch 'release-candidate' into stable Created with: gclient setdep -r src/ios/third_party/material_components_ios/src@2ed6691f2848 The AutoRoll server is located here: https://autoroll.skia.org/r/material-components-ios-chromium Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:ios-internal-mdc TBR=bling-p10-rolls@google.com Bug: None Change-Id: I8fa7048c7c42653e073d7a5343702d2a840eb35a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1758134Reviewed-by:
-
Chris Hamilton authored
This entirely retires the old private observer implementation. BUG=910288 Change-Id: I6369c51accc5f38a9145a515cd77c757c5bc28da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756255 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sigurður Ásgeirsson <siggi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687666}
-
Rayan Kanso authored
The Background Sync BackgroundTask fires ready background sync events, which schedules another background task if necessary. This change doesn't allow rescheduling to happen if the firing of events originates from the Background Task. When the events are complete, another background task can be scheduled if necessary. Bug: 991326 Change-Id: I974e7bedae6125dd4e3fe9c3a3693601bb8910f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1755916Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#687665}
-
Anthony Vallee-Dubois authored
Change-Id: Id2972c13c2da888a4c7f2974b933ae190fdfe2fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756147Reviewed-by:
Alexandre Frechette <frechette@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: anthonyvd <anthonyvd@chromium.org> Cr-Commit-Position: refs/heads/master@{#687664}
-
Finnur Thorarinsson authored
Bug: 993775, 860467 Change-Id: I1cb4cbfa9e66cca8b97a16d56ab95409bd6c97a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754012 Commit-Queue: Jesse Doherty <jwd@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Auto-Submit: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#687663}
-
Shelley Vohr authored
Using const container elements like const std::vector<const std::string> a = {"a"}; will fail when building with libc++ on: 'The C++ Standard forbids containers of const elements because allocator<const T> is ill-formed." Electron encountered this issue as we build Chromedriver with libc++. This fixes the issue by changing the elements to non-const std::strings. Bug: 994347 Change-Id: I309a521fa360e3b36beca53354edadc668a9a12f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756424Reviewed-by:John Chen <johnchen@chromium.org> Reviewed-by:
Nina Satragno <nsatragno@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#687662}
-
Owen Min authored
Enable device info and device local account policy. Pretty print, policy type conversion and user policies are enabled by default. Policy value conversion is disabled by default. Also update the documentation of extension api definition. Bug: 983174 Change-Id: I20747c3b607e41dfd364d6488bb83acd65204d1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757124 Auto-Submit: Owen Min <zmin@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687661}
-
Owen Min authored
The failure is not able to be reproduced. Going to re-enable the test and watch. Change-Id: I385491388093be9701ed0ff2b58ba6553311f443 Bug: 984902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1756863Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#687660}
-
Kenichi Ishibashi authored
We've noticed that some tasks related to IndexedDB took considerable amount of time while service worker controlled navigations. Add IndexedDB category to background tracing so that we can check what's going on. Bug: 561209 Change-Id: Ib615bd74ed22dca64205c31bb1eaaf2a60876987 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1745678Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#687659}
-
jongkwon.lee authored
Re-enable interactive uitests that were disabled for crbug/823543 and crbug/824418. These issues are because of crbug/641969 which is no longer reproduced on MacViews browser now. This CL disables StatusBubbleMacInteractiveUITest because ui_test_utils::BringBrowserWindowToFront makes trouble on NSApp hide: and unhide:. BUG=823543, 824418, 641969 Change-Id: Ideab87d4416bdb3f7549b01968c0a5f96eb59107 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1743428Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#687658}
-
Yi Gu authored
WaitForHitTestDataOrChildSurfaceReady has been renamed. Update the comment to reflect the change. Bug: None Change-Id: I417370405a70a5fb04251486684b416007167520 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1754667Reviewed-by:
Bo <boliu@chromium.org> Commit-Queue: Yi Gu <yigu@chromium.org> Cr-Commit-Position: refs/heads/master@{#687657}
-
Hiroki Nakagawa authored
This code path is no longer used. Bug: 967272 Change-Id: Ib426e6895d03c19f6684dfa5c049b1af5e706cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1757607 Auto-Submit: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#687656}
-
