GitLab

Update README.chromium to include instructions on creating a cloud
bucket such as "chromium-webxr-test".

Change-Id: I0e3e575be60d35436246dc6e67eb8cb104742552
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314198Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Luis Garcia <luisggarcia@google.com>
Cr-Commit-Position: refs/heads/master@{#791899}

The original plan was to put all account-storage-related code into such
subfolders, but that hasn't happened, and this factory was in fact the
only thing in such a subfolder. So for consistency with all the other
code, move it out of the subfolder as well.

Bug: none
Change-Id: I5dcccbb960203cafd46f13460ad784b1ca6de85c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317962Reviewed-by: Mohamed Amir Yosef <mamir@chromium.org>
Commit-Queue: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791898}

This reverts commit e44d3738.

Reason for revert: It looks to have been necessary after all; crbug.com/1107830

Original change's description:
> webview: don't use UI thread pool unnecessarily.
> 
> Just use the general pool at best-effort priority for logging command
> line and field trials during startup, since it doesn't need to be on the
> UI thread.
> 
> Change-Id: I73dfb14ae67bcc953fa7c90b5840354d5b4a84b3
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302946
> Reviewed-by: Nate Fischer <ntfschr@chromium.org>
> Commit-Queue: Richard Coles <torne@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#789538}

TBR=torne@chromium.org,ntfschr@chromium.org,hazems@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Fixed: 1107830
Change-Id: If9f8038787cc0a16377aca599cbcb18efa055463
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316414Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Richard Coles <torne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791897}

The parent cl should fix the failure

Bug: 1102296
Change-Id: Iea806b0dc067a2966651482c112845d6c2be4c4b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317189Reviewed-by: Marc Treib <treib@chromium.org>
Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791896}

This builder is superseded by metadata-exporter builder.

Depends on
https://chromium-review.googlesource.com/c/chromium/tools/build/+/2313785

Bug: 1106176
Change-Id: Ia391aea0fc36fb55260f1289d30b789f23fb02a6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314032Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Reviewed-by: Garrett Beaty <gbeaty@chromium.org>
Auto-Submit: Nodir Turakulov <nodir@chromium.org>
Commit-Queue: Garrett Beaty <gbeaty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791895}

After discussion with chrome-privacy, this can be enabled for
users who have opted-in UMA.

Bug: 1017434
Change-Id: I140dac0327206846127be4befa3e6c9fca8780fd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292510
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791894}

Move IdleManager to RenderFrameHost for better isolation of simulating Idle Status.

Bug: 1090802
Change-Id: Ia0e3ca436e612aaba29dc9880c69ae54305f13d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2308722Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Avi Drissman <avi@chromium.org>
Auto-Submit: Maksim Sadym <sadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791893}

Bug: 672917
Change-Id: Ie28e6de56bcfea09bf9462236665c31497e2494b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2311116
Auto-Submit: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791892}

https://chromium-review.googlesource.com/c/chromium/src/+/2302609
revealed that the dependencies are broken for the MojoLPM bindings
generators. Suspect that this is also the root cause of the linked
bug

Bug: 1108739
Change-Id: I1cac1fbf2a2cc139f972f7e6e605bd4a70323c33
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315340Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Commit-Queue: Mark Brand <markbrand@google.com>
Cr-Commit-Position: refs/heads/master@{#791891}

Provides a simpler mechanism for checking whether the associated flag is
enabled.

Bug: 1106937
Change-Id: I7b54cae69f52d25ea6aa50843ab2e0b7e88ed7c4
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317768Reviewed-by: Josh Nohle <nohle@chromium.org>
Commit-Queue: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791890}

This reverts commit 33253a15.

Reason for revert: Broke PWA content fullscreen
https://crbug.com/1109608

Original change's description:
> Mac: modernize menu reveal tracking
> 
> The fullscreen toolbar controller currently uses undocumented Carbon
> events to track the menubar's reveal amount in fullscreen. In recent
> macOS versions, the intermediate values are no longer send and we
> only receive events when the menubar is fully shown or fully hidden.
> 
> The Mac immersive code which is still behind a flag uses a different
> technique, observing the reveal amount on a hidden titlebar accessory
> view. This *does* provide correct intermediate values.
> 
> This change extracts the reveal code from the immersive controller
> and uses it in the current fullscreen code rather than the Carbon
> event. Unfortunately, despite receiving the correct progress
> notifications, the topchrome still does a discontinuous jump, but
> we'll cross that bridge later.
> 
> Bug: 1063417
> Change-Id: I6827cafbcad58eeaabf98c6facaeb85ce3439997
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314998
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Leonard Grey <lgrey@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#791273}

TBR=avi@chromium.org,lgrey@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1063417
Change-Id: Ie70a1ce26feddaa6aec2e0f061b8dd7656fcf55e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320409Reviewed-by: Leonard Grey <lgrey@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791889}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/f23e4df5..2f54b1a2

Please follow these instructions for assigning/CC'ing issues:
https://v8.dev/docs/triage-issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel
CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com

Change-Id: If7c449219f01f3304d184bded2e8d3e7f34edf04
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320348Reviewed-by: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791888}

https://android.googlesource.com/platform/external/perfetto.git/+log/84ab9b3dd3ae..f2780c629ddc

2020-07-27 hjd@google.com Merge "Investigate SaveTraceIntoDropboxAndIncidentOrCrash"

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/perfetto-chromium-autoroll
Please CC perfetto-bugs@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel
Bug: None
Tbr: perfetto-bugs@google.com
Change-Id: Icc6d3b45d0c355afece4410dc436bb3a22c57c32
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320037Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791887}

Create a generated preference to support the Password Leak Detection
toggle within chrome://settings/security. This toggle has additional
behavior based on profile state that currently requires additional
front-end JS logic. This CL recreates this logic within C++ code and
exposes it via a generated preference.

Bug: 1063265
Change-Id: Iacf35ae323bfb22fbc24702e369bee866babb982
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283610Reviewed-by: dpapad <dpapad@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com>
Cr-Commit-Position: refs/heads/master@{#791886}

This reverts commit 592b68f4.

Reason for revert: Caused a significant number of crashes in canary
builds. http://crbug.com/1109463



Original change's description:
> Crash if a BrowserContext is referenced by a RenderProcessHost at destruction.
> 
> Adding an extra sanity check in the BrowserContext destructor to
> immediately terminate if we detect that a RenderProcessHost still
> references the object being destroyed.
> 
> 
> Bug: 1099998
> Change-Id: I84af3b5d5f09274fa551b63903101ab5710d073d
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2305674
> Auto-Submit: Aaron Colwell <acolwell@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Commit-Queue: Aaron Colwell <acolwell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#791282}

TBR=nasko@chromium.org,acolwell@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 1099998, 1109463 
Change-Id: Id15033cbe5880c92d6985d199962c199aa7e0a80
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320410Reviewed-by: Aaron Colwell <acolwell@chromium.org>
Commit-Queue: Aaron Colwell <acolwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791885}

checkteamtags is no longer necessary.
- Add a check to validate DIR_METADATA files.
  This obviates the need fo checkteamtags, as `dirmd` validates metadata in
  OWNERS files, and we no longer need to enforce a unique team email for all
  (component, OS) pair.
- Add a check to enforce that OWNERS files contain no metadata if a
  DIR_METADATA file is present in the same directory.

Bug: 1102997
Change-Id: I661f7a1958824e7d20642d65534c2502d1a050e2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317838Reviewed-by: Nodir Turakulov <nodir@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@google.com>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791884}

Patch [3/N] modified blink windows's binding to call CheckCoopAccess()
whenever a "CrossOrigin" attribute/methods was accessed.

So far, so good. Nevertheless, some attributes are missing, because they
have a custom implementation. CheckCoopAccess needs to be added manually
for them. This patch fixes the accesses when setting "opener".

COOP access reporting:
[ 1/N] https://chromium-review.googlesource.com/c/chromium/src/+/2264294
[ 2/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270185
[ 3/N] https://chromium-review.googlesource.com/c/chromium/src/+/2270472
[ 4/N] https://chromium-review.googlesource.com/c/chromium/src/+/2273120
[ 5/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309433
[ 6/N] https://chromium-review.googlesource.com/c/chromium/src/+/2308715
[ 7/N] https://chromium-review.googlesource.com/c/chromium/src/+/2309697
[ 8/N] https://chromium-review.googlesource.com/c/chromium/src/+/2275889
[ 9/N] https://chromium-review.googlesource.com/c/chromium/src/+/2310530
[10/N] this patch.

Bug: 1090273
Change-Id: I4a5357d123db9e04ac4ac4fcf119ac3cacd93688
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315024Reviewed-by: Yuki Shiino <yukishiino@chromium.org>
Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791883}

Add Troy card which card number have prefix 2205 or 9792
for autofill

Bug: 1026289
Skip-Translation-Screenshots-Check: True
Change-Id: I72b7b363c2ec63cb5ba1192b996773bcdf2d2e67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1952628Reviewed-by: Dominic Battré <battre@chromium.org>
Reviewed-by: Friedrich [CET] <fhorschig@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Hwanseung Lee <hs1217.lee@samsung.com>
Cr-Commit-Position: refs/heads/master@{#791882}

This is part of a larger cleanup effort of Chrome's use of cookies. The
eventual goal is to make the constructor private and to have other parts
of Chrome use CreateSanitizedCookie().

Bug: 1102874
Change-Id: Id27150b987d2303fc670aac8cdf83300d2238877
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2303300
Commit-Queue: Dylan Cutler <dylancutler@google.com>
Reviewed-by: Lily Chen <chlily@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791881}

The chrome://history page is a native page, and currently
TabListMediator and TabListFaviconProvider return the default round
favicon for all native pages. To fix this issue, both classes will only
check if it is a NTP, and treat other native pages the same as regular
URLs, and load real favicon for them.

Bug: 1104811
Change-Id: Ia93cfb77e41f2fdd2da9eb06c12fd797c4b34a82
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2310151
Commit-Queue: Xi Han <hanxi@chromium.org>
Reviewed-by: Wei-Yin Chen (陳威尹) <wychen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791880}

Test: VirtualBrowsingContextGroupTest.HistoryNavigation
android-bot: https://ci.chromium.org/p/chromium/builders/ci/android-bfcache-rel
linux-bot: https://ci.chromium.org/p/chromium/builders/ci/linux-bfcache-rel

Bug: 1109648
Change-Id: If153c4143b1ad9c6e0fc2f684ef46d41882e624c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320126Reviewed-by: Arthur Sonzogni <arthursonzogni@chromium.org>
Commit-Queue: Sreeja Kamishetty <sreejakshetty@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791879}

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll
Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast
Tbr: cr-fuchsia+bot@chromium.org
Change-Id: Ia9a830eb7acec89ff253da36f7d64be47e0b17b2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320197Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791878}

Bug: 1104976
Change-Id: Id5f7228b00ace088c8943461554b9957208e7dde
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2296921
Auto-Submit: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791877}

If an Autofill session is triggered on the UrlBar before
setTextForAutofillServices has been called for the first time, the
member mTextForAutofillServices, which is null, is passed to the
constructor of SpannableStringBuilder. This results in a crash.

This is fixed by always intializing mTextForAutofillServices.

R=tedchoc@chromium.org

Bug: 1109186
Change-Id: I2d2e2b73521a6261c23c1cc3dd36ba83dc19f110
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317209Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791876}

Add closure compilation for:
- duplex_settings_test.js
- dpi_settings_test.js
- destination_store_test.js

Bug: 1000989
Change-Id: I799f0006f738c8f6650d5af2a8e87a6efe25adb2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314666
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: John Lee <johntlee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791875}

This CL introduces the following changes as per UI feedback :-
1) Illustration is too low when there is no button on OOBE screen.
Moved it 40px higher as per feedback.
2) Space between text lines in the footer section is too tight.
Added line-height 20px as per feedback.
3) Updated margin-top for progress message as per OOBE spec.

Bug: 1106768
Change-Id: If1fcbbc5af9af86ec1336428c6035a388d5a869c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302639Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Commit-Queue: Saurabh Nijhara <snijhara@google.com>
Cr-Commit-Position: refs/heads/master@{#791874}

The tests were skipped because they were out-dated and blocked shipping
WebAssembly BigInts and MultiReturn. The tests got updated by now.

R=mlippautz@chromium.org

Bug: chromium:1097765
Change-Id: I1a82d11ba7df237fac755e72b6ed2d88de8da05a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320279Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Commit-Queue: Andreas Haas <ahaas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791873}

This CL migrates fast/replaced/available-height-for-content.html to
external/wpt/css/css-sizing/available-height-for-replaced-content.html.

Change-Id: Ife10bdaf02857ff5b4e4142e6354c7d002671c3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320270
Commit-Queue: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#791872}

This cl fixes an issue where the offset calculation for css grid
line name labels do not account for the first offset as expected
by the inspector overlay (see the line number calculations for
example).

This causes the label to be incorrectly spaced if the grid wrapper
has a padding applied.

Before: https://imgur.com/3o6RrIA

After: https://imgur.com/XaHtACA

Bug: 1108528
Change-Id: I976a781e73a076de8092931bc4c3f393a44bafbb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2314699Reviewed-by: Oriol Brufau <obrufau@igalia.com>
Reviewed-by: Peter Marshall <petermarshall@chromium.org>
Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
Commit-Queue: Brandon Goddard <brgoddar@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#791871}

From an V8 Binding, minus the degenerate scenario where V8 Pointer Compression
currently disables externalization for small strings (even though there is a
likely significant performance benefit) an AtomicString is always created
when projecting a V8 String into a DOM string.

Thus, for the DOM Element APIs called by the bindings code, there is no
benefit to StringView in the common case. Later on, if temporary strings
for things like lowercasing are required, taking a StringView can be
beneficial in internal APIs to avoid an AtomicStringTable entry creation
but the public API does best just taking an AtomicString.

Furthermore, because the current ToBlinkStingView() creates a local
AtomicString reference to the externalied String, this causes a local
refcount thrash. When StringImpl's refcount is made threadsafe, this
thrash can account for 10-15% degredation on blink_perf benchmarks
such as get-element-by-id.html. ToBlinkStingView() can theoretically
be fixed, but as there is little benefit to using a StringView,
removing is easier.

This reverts commit 88bd95fa and
part of 41f55e37.

Bug: 1083392
Change-Id: I0b11e8e43f18dfc7711aadeefb8f000fee689741
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319544
Commit-Queue: Jeremy Roman <jbroman@chromium.org>
Reviewed-by: Jeremy Roman <jbroman@chromium.org>
Auto-Submit: Albert J. Wong <ajwong@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791870}

This logic was being duplicated on Mac because of an earlier change.

Bug: chromium:914976
Change-Id: I724c3447f9ed50c54e0e448e994a74f693f05168
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2316150Reviewed-by: Kramer Ge <fangzhoug@chromium.org>
Reviewed-by: Peng Huang <penghuang@chromium.org>
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Cr-Commit-Position: refs/heads/master@{#791869}

This test aborts if the OSK doesn't seem to work, which can be the case
when a hardware keyboard is present. I found no better way to determine
if the soft keyboard is disabled or force it to be enabled. The CQ bots
appear to run with a soft keyboard and no hard keyboard, so they should
run the test to completion.

The presence of the OSK is verified by checking the size of the content
when not in fullscreen, behavior that has always worked. This is because
the behavior under test is respecting the OSK size when the content *is*
in fullscreen, so aborting based on fs behavior would not have caught
this bug (the bug would have made it seem as if there were no OSK).

This is split off from the fix in case the test turns out to be flaky.

Bug: 1107651
Change-Id: I803a67a4adef0bc4ee19b70a4d2ebd3126cd632f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315425Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791868}

Removes test asserts verifying ChromeSigninController state where it is
redundant - both SigninFragmentTest and SigninSignoutIntegrationTest
verify ChromeSigninController.isSignedIn after checking
IdentityManager.hasPrimaryAccount, which is now the source of truth for
the sign-in state.

Bug: 1046412
Change-Id: I4ca41bc2c838a37e31a957390efc75cedac4202d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317212
Auto-Submit: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Alice Wang <aliceywang@chromium.org>
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791867}

This CL changes the method
AccountPickerCoordniator.Listener#goIncognito to default as it is not
needed for all implementations of the listener. The non necessary
empty implementations are also removed.

Bug: 1093795
Change-Id: I5882d9c35294d2b9de9a59d1e76e5673df7250ff
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317799
Commit-Queue: Boris Sazonov <bsazonov@chromium.org>
Reviewed-by: Boris Sazonov <bsazonov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791866}

This reverts commit f844efb2.

Reason for revert: Removed additional tests from commit

Original change's description:
> Revert "Explicitly name webgl/2 conformance tests on Windows"
>
> This reverts commit 539778cf.
>
> Reason for revert: not enough HW capacity for more tests
>
> Original change's description:
> > Explicitly name webgl/2 conformance tests on Windows
> >
> > These tests should be explicit about using ANGLE's d3d11 backend.
> >
> > Bug: chromium:850252
> > Change-Id: I0f3d348edf38f845efeb5ba9d2a70f38b662efbf
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2302413
> > Reviewed-by: Jonah Ryan-Davis <jonahr@google.com>
> > Reviewed-by: Kenneth Russell <kbr@chromium.org>
> > Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
> > Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
> > Cr-Commit-Position: refs/heads/master@{#790942}

Bug: chromium:850252
Change-Id: I281612c7770ae8e33dce0d739e501455b8fd3dfa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315183
Commit-Queue: Jonah Ryan-Davis <jonahr@google.com>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Reviewed-by: Yuly Novikov <ynovikov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791865}

Interface to be implemented using leveldb-proto.
See go/nearby-chrome-cert-manage

Bug: b/154865267
Change-Id: Ibeb17fa2962c95bdf152d633d79cd78753457baa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2261218
Commit-Queue: Curt Clemens <cclem@google.com>
Reviewed-by: Josh Nohle <nohle@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791864}

Hover cards are currently rolling out to stable on Mac and hover card
images are as well so we want to keep these metrics to monitor that.

Bug: 1097849, 1097848
Change-Id: I0e56e9a26ec4723c751b74db020afdf988440ffd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315809Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Caroline Rising <corising@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791863}

Add FamilyLinkNoticeScreen after gaia sign-in to tell user supervision can be added via Family Link afterward. It should display when user selects sign in for a child and the child is older than 13 years old.

Bug: 1101318
Change-Id: If7c9c491f2967da038b70cc3ebb7d1318ea86b51
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2294861
Commit-Queue: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Reviewed-by: Denis Kuznetsov [CET] <antrim@chromium.org>
Cr-Commit-Position: refs/heads/master@{#791862}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/450afef18d5b..f81afad16767

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC adithyas@google.com,rsorokin@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome
Bug: chromium:1033067,chromium:1098562,chromium:1105907
Tbr: adithyas@google.com,rsorokin@google.com
Change-Id: I5e7038e94b75dd2c936d4900d003043e54ab5835
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320192Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791861}

Roll Chrome Mac PGO profile from chrome-mac-master-1595829164-c22b50893110427f86ce6cde1b20f409df22cb84.profdata to chrome-mac-master-1595851043-c48b6bdf39deda41f847276998118df921bfd4ef.profdata

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/pgo-mac-chromium
Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: chrome/try:mac-chrome
Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com
Change-Id: Ie81710b23f5279a5d712e72978df40d14ac81be8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2320189Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#791860}