GitLab

This test fails flakily there.

TBR=perkj@chromium.org
NOTRY=true
BUG=373637

Review URL: https://codereview.chromium.org/292433005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270944 0039d316-1c4b-4281-b951-d872f2087c98

This test has been failing frequently on bots and closing the tree.

NOTRY=true
TBR=mtomasz@chromium.org
BUG=374097

Review URL: https://codereview.chromium.org/290613004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270943 0039d316-1c4b-4281-b951-d872f2087c98

This is a split of https://codereview.chromium.org/287673004/, to avoid
merging issues.

It is almost impossible to land a CL adding histograms via CQ, without
a merging conflict.

TBR=isherman@chromium.org
TEST=Just histograms, no actual changes.
BUG=248427

Review URL: https://codereview.chromium.org/289063006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270942 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: https://codereview.chromium.org/289053003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270941 0039d316-1c4b-4281-b951-d872f2087c98

In the beginning there was an app/ directory, which is what ui/ is
today. This was back in 2011.

Ben started moving the pieces of app/ into ui/ in
commit f6767806 - r70743

Looks like we forgot to update this when we moved the code test/data
directory.

BUG=None
TEST=ui_unittests --gtest_filter=DataPackTest.*
R=tony@chromium.org
TBR=ben@chromium.org

Review URL: https://codereview.chromium.org/288323003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270940 0039d316-1c4b-4281-b951-d872f2087c98

Trying to initialize the UI systems more than once can end up creating the
same subsystem (e.g. surface-factory) multiple times, which is not supported.
So remember whether the UI/GPU parts of the platform has been initialized.

BUG=361137
NOTRY=true
TBR=spang@chromium.org

Review URL: https://codereview.chromium.org/284253006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270939 0039d316-1c4b-4281-b951-d872f2087c98

It's not safe for a RefCounted object to PostTask in its constructor.
Refcounts start at zero, so if the task completes before the constructor
returns, the closure will see the refcount going 0->1->0 and think the
object can be deleted.

This change moves the PostTask in ..::EstablishRequest() to a separate
Create() static function so it can be called after assignment into a
scoped_refptr wrapper, which ensures the refcount is incremented before
posting the task.

BUG=116100

Review URL: https://codereview.chromium.org/286983002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270938 0039d316-1c4b-4281-b951-d872f2087c98

-The real guts of content_hash_fetcher.cc, which fetches the
 verified_contents.json file from the webstore if needed and also runs
 tasks to compute and cache the block-level hashes of all files in an
 extension.

-The real guts of content_hash_reader.cc, which uses the work done by
 the content_hash_fetcher during validation of extension file content as
 it's read off of disk at time of use.

-Code to avoid verifying transcoded files (images used in browser
 process, and message catalogs).

-Don't allow downgrade of mode via kForceFieldTrials command line switch

-Various bits of plumbing to support all of the above

This is a re-land with fixes; original review was:
  https://codereview.chromium.org/289533003

BUG=369895,373854
R=rockot@chromium.org

Review URL: https://codereview.chromium.org/288273004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270937 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270936 0039d316-1c4b-4281-b951-d872f2087c98

http://build.chromium.org/f/chromium/perf/dashboard/ui/changelog_blink.html?url=/trunk&range=174065:174118&mode=html
TBR=
BUG=

Review URL: https://codereview.chromium.org/282303004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270935 0039d316-1c4b-4281-b951-d872f2087c98

This CL adds a MainAxisAlignment setting to BoxLayout which functions like the CSS
justify-content property. This property aligns the children items of a view
in the orientation axis of the BoxLayout.

set_spread_blank_space has been removed and replaced with
MAIN_AXIS_ALIGNMENT_FILL.

BUG=None

Review URL: https://codereview.chromium.org/284753002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270934 0039d316-1c4b-4281-b951-d872f2087c98

Broke Windows Debug build; see comments in bug 365012 for details.

> Tweaks to ViewManager:
> 
> . OnNodeHierarchyChanged() is only sent for nodes the client cares
>   about (see ShouldNotifyOnHierarchyChange for exact details).
> . OnNodeHierarchyChanged() now includes any nodes not yet known to the
>   client.
> . Added OnServerChangeIdAdvanced, which is sent if the change id
>   advances but the client didn't get a notification (this can happen
>   when hierarchy changes are done in other clients that the client
>   isn't notified about).
> . OnConnectionEstablished now includes the state of the tree.
> 
> BUG=365012
> TEST=covered by tests
> R=ben@chromium.org
> 
> Review URL: https://codereview.chromium.org/288313002

TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/286973009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270933 0039d316-1c4b-4281-b951-d872f2087c98

The tests are leaking a profile. Suspect this is caused by enabling
multi profile by default on ChromeOS.

NOTRY=true
TBR=nkostylev@chromium.org
BUG=374078

Review URL: https://codereview.chromium.org/284263004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270926 0039d316-1c4b-4281-b951-d872f2087c98

. OnNodeHierarchyChanged() is only sent for nodes the client cares
  about (see ShouldNotifyOnHierarchyChange for exact details).
. OnNodeHierarchyChanged() now includes any nodes not yet known to the
  client.
. Added OnServerChangeIdAdvanced, which is sent if the change id
  advances but the client didn't get a notification (this can happen
  when hierarchy changes are done in other clients that the client
  isn't notified about).
. OnConnectionEstablished now includes the state of the tree.

BUG=365012
TEST=covered by tests
R=ben@chromium.org

Review URL: https://codereview.chromium.org/288313002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270925 0039d316-1c4b-4281-b951-d872f2087c98

> Remove knowledge of nacl from content.
> 
> Content should not have knowledge of NaCl. Moving per process NaCl debug
> stub port information to NaClBrowser.
> 
> More explicitly distiquish between the case where the debug port is not yet
> known versus when it is unused.
> 
> Switch debug port to being a per-process value (as it is).
> 
> BUG=None
> TEST=trybots
> R=jam@chromium.org
> 
> Review URL: https://codereview.chromium.org/286993006

This caused the compile to fail on the TSAN v2 bot:
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Builder%20%28TSan%20v2%29/builds/19971

TBR=bradnelson@google.com

Review URL: https://codereview.chromium.org/290633006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270924 0039d316-1c4b-4281-b951-d872f2087c98

his is a simplified version of api_test/stubs. It touches all the parts
of each chrome.foo.bar.baz API path and ensures they are defined. This
catches cases where a developer adding an API to _api_features.json but
did not provide a schema for them.

(Original CL https://codereview.chromium.org/264923009/. It was reverted
because it leaked an "about" file in the source checkout. The underlying
issues in platform app launch and chrome startup have been fixed.)

TBUG=369318
TEST=added browser_tests ExtensionApiTest.StubsApp

Review URL: https://codereview.chromium.org/283363004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270923 0039d316-1c4b-4281-b951-d872f2087c98

Before this patch, the tile manager perftest would directly register
the tiles into tile manager in order to test. This provided accurate
numbers with regards to the number of tiles we had registered, but
it also coupled the knowledge that tile manager deals with tiles
directly.

This patch adds a bit of indirection to the perftest to create layers
that have tiles, and then call manage tiles. This decouples tile manager
from the perftest in the sense that the tile manager is free to choose
what it does with layers/tiles as the perftest better represents the
real world.

NOTE TO PERF SHERIFFS
---------------------

Please note that this changes TileManager perftest. In particular,
any changes in graphs to cc_perftests.manage_tiles should be
disregarded. This patch completely reworks the perftest, so
the results are not comparable to previous results.

Review URL: https://codereview.chromium.org/284553002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270922 0039d316-1c4b-4281-b951-d872f2087c98

This causes the test ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo
to fail if the target device is in airplane mode.

BUG=372174

Review URL: https://codereview.chromium.org/289653002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270921 0039d316-1c4b-4281-b951-d872f2087c98

TBR=perkj@chromium.org
NOTRY=true
This test fails flakily there.

BUG=373637

Review URL: https://codereview.chromium.org/284253004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270919 0039d316-1c4b-4281-b951-d872f2087c98

The page works fine on ToT. Looks like the scrolling problem has been fixed.

R=tonyg@chromium.org
BUG=366371

Review URL: https://codereview.chromium.org/288033011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270918 0039d316-1c4b-4281-b951-d872f2087c98

This extracts the device temp file creation deletion into a context
manager. This context manager will delete the temporary file when
leaving the with: scope.

Also changes logic for finding a temp file from a linear search from 0
to just using a random number (still checking that the file doesn't
exist). Both of these approaches could return the same file in
consecutive calls if the earlier files aren't written to (though it is
nearly impossible with the random number approach instead of essentially
guaranteed).

Removed the temp file name patterns and just added a prefix+suffix
argument to DeviceTempFile (like tempfile.NamedTemporaryFile).

BUG=371054

Review URL: https://codereview.chromium.org/276813002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270917 0039d316-1c4b-4281-b951-d872f2087c98

The Life SIMD demo exercises 16 element fixed point vectors to operate on 16
cells at a time. The Earth SIMD demo uses a mix of 4 element single precision
floating point and a small amount of fixed point SIMD. At the moment, both
demos do not exhibit much speedup from using SIMD, but this should improve as
the quality of PNaCl's code generation gets better.

Also, fix an issue where dragging a slider wasn't continuously updating in the
regular voronoi & earth demos.

R=binji@chromium.org
BUG=http://code.google.com/p/nativeclient/issues/detail?id=2205
TEST=demo

Review URL: https://codereview.chromium.org/289023002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270916 0039d316-1c4b-4281-b951-d872f2087c98

This test has unrelated flaky leaks there, the tests seem flaky and need
to be investigated more deeply. Disabling the most flaky test.

NOTRY=true
TBR=shess@chromium.org
BUG=373155

Review URL: https://codereview.chromium.org/291503005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270915 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270909 0039d316-1c4b-4281-b951-d872f2087c98

Content should not have knowledge of NaCl. Moving per process NaCl debug
stub port information to NaClBrowser.

More explicitly distiquish between the case where the debug port is not yet
known versus when it is unused.

Switch debug port to being a per-process value (as it is).

BUG=None
TEST=trybots
R=jam@chromium.org

Review URL: https://codereview.chromium.org/286993006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270907 0039d316-1c4b-4281-b951-d872f2087c98

This extracts Answers from the results JSON, if they exist, and make
sure they're available on AutocompleteMatch objects.

BUG=370192
R=pkasting@chromium.org

Review URL: https://codereview.chromium.org/285343004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270906 0039d316-1c4b-4281-b951-d872f2087c98

BUG=371303
NOTRY=true

Review URL: https://codereview.chromium.org/286193002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270905 0039d316-1c4b-4281-b951-d872f2087c98

This calls OnNativeWindowChanged when the window enters or exits
fullscreen. It also redundantly calls AppWindow::OSFullscreen and
AppWindow::Restore to get the AppWindow to update it's internal state.

BUG=372301

Review URL: https://codereview.chromium.org/280483004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270904 0039d316-1c4b-4281-b951-d872f2087c98

Some of the ozone subsystems don't need to be initialized in the GPU
process (e.g. events). So let the ozone-platform know what process the
platform is being initialized for, and initialize only the subsystems
that make sense for that process.

The changes include:
 * Remove SetInstance() from EventFactoryOzone, SurfaceFactoryOzone and
   CursorFactoryOzone. Instead, set the instance from the constructor.
 * Require the platforms to provide one explicit constructor for the UI
   and GPU processes through the OzonePlatform interface.
 * Do not initialize any of the sub-systems in InitializeGPU() in all
   platforms.
 * Move the initialization of ozone-platform into aura::Env::Init.
 * Move the creation of udev-monitor in DeviceManagerUdev from the
   constructor to ScanDevices(), since it needs the message-loop, and the
   message-loop is constructed later.
 * Update EventFactoryEvdev to set the ui_task_runner_ from
   OnDispatcherListChanged(), since this too is created before the
   message-loop.

BUG=361137
R=piman@chromium.org
TBR=spang@chromium.org

Review URL: https://codereview.chromium.org/291473002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270903 0039d316-1c4b-4281-b951-d872f2087c98

Follow symlinks (some build systems use one symlink per file in the app).

Ignore all values in the window create options. app_shell doesn't use them
and this allows the app developer to use whatever their build system will
validate (and whatever they want to use while working in Chrome).

BUG=373822
TEST=manual

Review URL: https://codereview.chromium.org/292453002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270902 0039d316-1c4b-4281-b951-d872f2087c98

Disable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo

The test is still failing on Android Tests (dbg) bots. See:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29

BUG=372748,372174
TBR=boliu
NOTRY=true

Review URL: https://codereview.chromium.org/284253003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270901 0039d316-1c4b-4281-b951-d872f2087c98

To enable this support, the following things are changed:
* ExtensionSyncData, and the ExtensionSpecifics protobuf have a new
  remote_install field, to mark a remotely installed extension.
* A new DISABLE_REMOTE_INSTALL reason is added to track this state
  locally.
* CrxInstaller::allow_silent_install is changed from a bool to a
  three-state enum, where the options are:
    - install after showing a permission prompt,
    - install and grant all permissions without a prompt and
    - install without a prompt and don't grant any permissions
* AddExtensionDisabledError is modified to keep track of the disable
  reasons, and change the text that is displayed accordingly.
* ExtensionInstallPrompt has a new prompt type with different text
  for remotely installed extensions.

BUG=365737

Review URL: https://codereview.chromium.org/264763002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270900 0039d316-1c4b-4281-b951-d872f2087c98

BUG=367863

Review URL: https://codereview.chromium.org/284153005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270899 0039d316-1c4b-4281-b951-d872f2087c98

auth: local auth i.e. cryptohome related
lock: screen lock
signin: browser signin related such as OAuth2*
users: user management
users/avatar: user avatars (profile pictures)
users/wallpaper: user wallpapers
ui: login/lock dialogs/host/view etc.

BUG=370175
TEST=existing tests, presubmit hooks

TBR=benwells

Review URL: https://codereview.chromium.org/286933002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270898 0039d316-1c4b-4281-b951-d872f2087c98

BUG=373096
TEST=none
R=keybuk@chromium.org

Review URL: https://codereview.chromium.org/286993002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270897 0039d316-1c4b-4281-b951-d872f2087c98

Revert of Disable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayF… (https://codereview.chromium.org/292473002/)

Reason for revert:
Forgot to import DisabledTest

Original issue's description:
> Disable org.chromium.android_webview.test.ExternalVideoSurfaceContainerTest#testEnableVideoOverlayForEmbeddedVideo
> 
> The test is still failing on Android Tests (dbg) bots. See:
> http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29
> 
> BUG=372748,372174
> TBR=boliu
> NOTRY=true
> 
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270889

TBR=boliu@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=372748,372174

Review URL: https://codereview.chromium.org/290083003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270896 0039d316-1c4b-4281-b951-d872f2087c98

To verify it I ran the following command line:

$ g grep -h "#include \"" ui/surface/ | sort | uniq

Removing unused dependencies will help when converting this target to
GN, specially since media is not yet ported.

BUG=None
TEST=still links + green trybots
R=piman@chromium.org

Review URL: https://codereview.chromium.org/278173004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270895 0039d316-1c4b-4281-b951-d872f2087c98

Once all pages are force composited by default, this allows these tests
to not explode when trying to create GraphicsLayers because of a lack of
Platform::compositorSupport.

BUG=none

Review URL: https://codereview.chromium.org/287043002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270894 0039d316-1c4b-4281-b951-d872f2087c98

This test consistently fails on Android Tests (dbg). See:
http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29

BUG=374038
TBR=henrika
NOTRY=true

Review URL: https://codereview.chromium.org/286023005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270893 0039d316-1c4b-4281-b951-d872f2087c98

BUG=163931

Review URL: https://codereview.chromium.org/288083002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@270892 0039d316-1c4b-4281-b951-d872f2087c98