- 29 Jan, 2018 40 commits
-
-
David 'Digit' Turner authored
Completely remove the ability to call r_brk() at runtime for release builds. Normally, this is controlled at runtime by calling crazy_set_debugger_support(false), which is actually performed by the //base/android/linker/legacy_linker.cc. However, due to yet-unsolved reasons, runtime crashes in r_brk() still happen on Intel-based devices, even though this function is now supposed to never be called. This patch is an ugly hack that removes the ability to call r_brk() entirely from the library's code, to unlock the release. A proper fix would understand what's really going on (e.g. passing of dangling pointers in deferred task callbacks?) and address that accordingly. Unfortunately, the issue is really difficult to reproduce locally. BUG=796938 R=agrieve@chromium.org,pasko@chromium.org,rmcilroy@chromium.org Change-Id: I10a08fe3d551be39b6b9919420224b925b8be9a0 Reviewed-on: https://chromium-review.googlesource.com/889757Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#532429}
-
Nico Weber authored
Bug: 177475 R=jochen@chromium.org Change-Id: Id6c4b989d652860b5bdbdb04ace4199ab1e1db0f Reviewed-on: https://chromium-review.googlesource.com/889840Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532428}
-
Peter Wen authored
Using aapt to crunch and then avoiding crunching with aapt2's --no-crunch flag crashes aapt2. Just use aapt2's default crunching. BUG=805668 Change-Id: I61a578eb577069e899cd8a830458d54515fc7d21 Reviewed-on: https://chromium-review.googlesource.com/884064 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by:
-
Sandra Sun authored
Bug: 762054 Change-Id: If11cd4b3bf8cc24a97e4edf90a7dfbde983c0fb5 Reviewed-on: https://chromium-review.googlesource.com/862971Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Cr-Commit-Position: refs/heads/master@{#532426}
-
Tommy Steimel authored
This CL modifies the SingleWebsitePreferences setup to always show the sound setting even when it's not currently set by showing the default setting as selected. Bug: 796873 Change-Id: Id7dec2bb0e75ee138dae95bbd219c569794d2b09 Reviewed-on: https://chromium-review.googlesource.com/889519Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#532425}
-
chrome://snippets-internalsJan Krcal authored
The CL reveals the info whether the last fetch was authenticated or not via chrome://snippets-internals. The CL also does a minor polish of the internals page (only to be able to display the new field in a logical place. Bug: 804809 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I040ad1b6c223e8ab7c2a0893a820dcc014fbcdba Reviewed-on: https://chromium-review.googlesource.com/880862 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#532424}
-
Jonathan authored
Recent bug fixes have lead to more passing tests. Re-enable them. TBR=kylechar@chromium.org Bug: 760320 Change-Id: Iaf8bb1985bda1de31af30c775180f64bdf3d526e Reviewed-on: https://chromium-review.googlesource.com/860277Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#532423}
-
Nico Weber authored
R=jochen@chromium.org Change-Id: I9bfb6786d2fb2ef764c91145c488b50cbf76c487 Reviewed-on: https://chromium-review.googlesource.com/889879Reviewed-by:
-
Yang Guo authored
R=mlippautz@chromium.org Bug: v8:7275 Change-Id: Iacfb9b4b3a4237a445caf8bcc99a1c88ac3feabd Reviewed-on: https://chromium-review.googlesource.com/891226Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#532421}
-
Allen Bauer authored
Bug: 803815 Change-Id: I32dbf0ed1736339f3420d113a1a5a6440c7b8542 Reviewed-on: https://chromium-review.googlesource.com/887243Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Allen Bauer <kylixrd@chromium.org> Cr-Commit-Position: refs/heads/master@{#532420}
-
Michael Giuffrida authored
discard_metrics_util.cc should include discard_metrics_util.h. Change-Id: I542f831ec61202d210c2aa854bfe7276df1f6f5a Reviewed-on: https://chromium-review.googlesource.com/890305Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#532419}
-
Nico Weber authored
Fixes a bug where many WebFeature::kScrollToFragment* use counters were overcounted. This CL was uploaded by git cl split. R=dcheng@chromium.org Bug: 177475 Change-Id: I09276f288ca751448639dde1f5dbf4c9894155a9 Reviewed-on: https://chromium-review.googlesource.com/890006Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#532418}
-
David Bokan authored
EditingStyle: :AddAbsolutePositioningFromElement is unused. Change-Id: I7c5dfc825ca5453c19e6164dfef04fc3cebdd1c6 Reviewed-on: https://chromium-review.googlesource.com/887735Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532417}
-
Anita Woodruff authored
R=peter@chromium.org Change-Id: Ia25e9c21b020dfa524c5d2e8ccbf7ba5bf440dcd Reviewed-on: https://chromium-review.googlesource.com/888525Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Anita Woodruff <awdf@chromium.org> Cr-Commit-Position: refs/heads/master@{#532416}
-
Keishi Hattori authored
Epehemeron iteration done callbacks cleanups the Enqueued flag, so it needs to be called on incremental marking abort. This CL moves them to its own stack so they can be invoked separately. Bug: 757440 Change-Id: I815532db4858c2a81ef810891e6569de8e1de002 Reviewed-on: https://chromium-review.googlesource.com/832546 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Yuki Shiino authored
This patch removes use of filesystem's VoidCallback. The motivation is the same as https://crrev.com/844307 . Bug: 778580 Change-Id: I2f57919461a31a4f64af287b40e0a3a6d1f242cb Reviewed-on: https://chromium-review.googlesource.com/888234 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#532414}
-
Koji Ishii authored
Following bot results are included. 3356 3357 3358 3359 3362 3365 3368 3369 25 lines were removed and 29 lines were deflaked by consecutive results since 3334. TBR=eae@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ic4879340dd6c0f7f555f282bf2bfc18a100c82d4 Reviewed-on: https://chromium-review.googlesource.com/890679 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532413}
-
David Bokan authored
The stacktrace in the bug revealed a path where we don't check that the LocalFrameView isn't null. No test since I couldn't reproduce the crash. Bug: 805420 Change-Id: Ief57e784e765efadb18b5c9c040e7b5a40ee904c Reviewed-on: https://chromium-review.googlesource.com/887826Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#532412}
-
Elly Fong-Jones authored
This change: 1) Resurrects the 10.6/10.7/10.8 deprecation strings and updates them to 10.9; 2) Adds a feature "Enable109ObsoleteInfobar"; 3) Shows the obsolete system infobar on 10.9 systems when that feature is enabled; 4) Adds a *placeholder* chrome::kMac10_9_ObsoleteURL link for the "learn more" link in the infobar. Bug: 806071 Change-Id: I48ab95e50fd2be7438650bc7f7cbb35fd2c2b02b Reviewed-on: https://chromium-review.googlesource.com/889020 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#532411}
-
Sunny Sachanandani authored
We want to merge various smoothness page sets into desktop and mobile page sets for the new rendering benchmark. Since the same urls are duplicated in different page sets e.g. same page with scroll and pinch-zoom or same page with and without gpu raster, it's necessary to have unique names for each instance. This CL allows specifying a name when instantiating these pages. BUG=760553 Change-Id: I7fe789fbda625c6700e089433e75c07cad7d7db8 Reviewed-on: https://chromium-review.googlesource.com/885644Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#532410}
-
Alexander Timin authored
Split out input task queue from the compositor task queue and use it in content/renderer/input's MainThreadEventQueue. For now scheduler applies the exact same policies to the new queue, so this patch does not affect scheduling policies. It is planned in the future to run input task queue with high priority unconditionally. R=skyostil@chromium.org,haraken@chromium.org,dtapuska@chromium.org BUG=806271 Change-Id: I73204187131d01b936a0a5d5052b8969a62205eb Reviewed-on: https://chromium-review.googlesource.com/888521Reviewed-by:
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b4e468e1..ce789d48 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: Id4572c982100e3f97b43e13f4a8f59f0ae12e6a6 Reviewed-on: https://chromium-review.googlesource.com/891138Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#532408}
-
vitaliii authored
Disable ProcessManagerBrowserTest.NestedURLNavigationsToExtensionBlocked because it timeouts constantly on Win. TBR=rdevlin.cronin@chromium.org Bug: 806684 Change-Id: Ic86b6219db299489ec6392b2fd2fe885904bb3d9 Reviewed-on: https://chromium-review.googlesource.com/891022 Commit-Queue: vitaliii <vitaliii@chromium.org> Reviewed-by:
vitaliii <vitaliii@chromium.org> Cr-Commit-Position: refs/heads/master@{#532407}
-
Yuki Shiino authored
This patch removes use of filesystem's MetadataCallback. The motivation is the same as https://crrev.com/844307 . Bug: 778580 Change-Id: I75dda3272deb5cd641aa01da638b9ea5fee98bff Reviewed-on: https://chromium-review.googlesource.com/886921 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Add tracing for methods in BrowsingData[Counter]Bridge and each browsing data counter. This will allow easier debugging of performance issues with the Clear Browsing Data dialog. Bug: 804839 Change-Id: I971d08edea77fee4e76e48b901516253e46fcb33 Reviewed-on: https://chromium-review.googlesource.com/883530Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#532405}
-
Anita Woodruff authored
- No longer necessary to wait for NotificationDisplayService mutation now that we are back to waiting for the 'show' event in this test, since f5ae28 Change-Id: I19506c1a8cf1a1f040919a20be131986fff7df44 Reviewed-on: https://chromium-review.googlesource.com/888819Reviewed-by:
-
Greg Thompson authored
BUG=None R=ljusten@chromium.org Change-Id: I0c0f6e061c5d81e0d823d155b84dbf887867bbde Reviewed-on: https://chromium-review.googlesource.com/889499Reviewed-by:
Lutz Justen <ljusten@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#532403}
-
Gabriel Charette authored
Add a developer hint to an otherwise cryptic error when accidently registering a second RunLoop::Delegate on a thread. While Runloop::Delegate isn't aware of MessageLoop/ScopedTaskEnvironment: I find useful to add developer hints about the typical developer mistake a DCHECK catches. This avoids multiple developers wasting time figuring out the same thing. Started doing this in a few places in //base and this is another instance recently surfaced by chrisha @ https://groups.google.com/a/google.com/d/topic/lucky-luke-dev/9_eZ6pnvo7Y/discussion R=chrisha@chromium.org Bug: Cryptic error when creating a ScopedTaskEnvironment over an existing MessageLoop. Change-Id: I427e0400b2a2b91ab9b175fa2427014bc8fc4406 Reviewed-on: https://chromium-review.googlesource.com/890174 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#532402}
-
vitaliii authored
This reverts commit 4db68ed9. Reason for revert: Seems to cause failures on Mac ASan 64 Tests (see crbug.com/806712). Original change's description: > [Variations] Avoid duplication of the safe seed value stored in prefs. > > When the safe seed and the latest seed have identical contents, use a sentinel > value to avoid storing a duplicate value for the two seeds. This is purely a > storage space optimization; no difference in observed functionality is expected. > > R=asvitkine@chromium.org > > Bug: 727984 > Change-Id: Ica641a479228b0cdfcc4af2ec04ddfc54c36c5eb > Reviewed-on: https://chromium-review.googlesource.com/880482 > Commit-Queue: Ilya Sherman <isherman@chromium.org> > Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532027} TBR=isherman@chromium.org,asvitkine@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 727984, 806712 Change-Id: Ic5de33c61bb2acf88d7445ded4f0a1743ab7f456 Reviewed-on: https://chromium-review.googlesource.com/891119Reviewed-by:
-
Javier Fernandez authored
The CSS WG has resolved that it doesn't make sense to define Baseline Content-Alignment in the inline/main axis. https://github.com/w3c/csswg-drafts/issues/1184 The spec has been updated so that <baseline-postion> is not valid for the 'justify-content' property's syntax. This CL updates our parsing logic to match the new spec, including the parsing logic of the place-content shorthand. Additionally, this CL updates the computed value of the <baseline-position> values to match other browsers. We don't implement support for <baseline-position> values in the Content Distribution properties (align-content and justify-content), so I don't expect this change to break content of sites using the CSS Box Alignment feature. Bug: 802248, 803275 Change-Id: I0d3b1b7e7dd28552ee7e131bfe09ef7198565283 Reviewed-on: https://chromium-review.googlesource.com/882362Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#532400}
-
Keishi Hattori authored
In anticipation for incremental marking, disable promptly free for weak collection backings. This is required to avoid callbacks to objects that can be destroyed during the mutator between incremental marking. This CL: - Disable prompty free for weak hash table backings - Adds CheckObjectNotInCallbackStacks which checks that an object doesn't have any callback registered Bug: 757440 Change-Id: Ibeffed9e5a2f15a1b88c934f68e5d86f54c2e2c9 Reviewed-on: https://chromium-review.googlesource.com/836299 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
-
Christian Dullweber authored
Remove the -tabs suffix from CBD code as the old dialog has been removed and the new dialog isn't special anymore. Also remove some footer related code as the footer has been removed. Bug: 800184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I937e2133feb192eff9f043c5bc060d8296806070 Reviewed-on: https://chromium-review.googlesource.com/873911 Commit-Queue: Christian Dullweber <dullweber@chromium.org> Reviewed-by:
Dave Schuyler <dschuyler@chromium.org> Cr-Commit-Position: refs/heads/master@{#532398}
-
Anita Woodruff authored
Change-Id: I6b8d69e82bc99b1a01ca053afb31b044362048ae Reviewed-on: https://chromium-review.googlesource.com/888621 Commit-Queue: Anita Woodruff <awdf@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Accessing FetchContext passed to ResourceLoadScheduler causes indeterminate crashes. This implies that there might be a race to access NullInstance because dedicated FetchContext instance should be passed in usual production code path, and NullInstance use is only the exception. XHR will touch this regardless of threads, and can cause a race condition among the first and the second access over multiple-threading. This patch creates new FetchContext instance always instead of sharing one instance among all threads. If this affects performance we would consider to make it thread-local. Bug: 803849 Change-Id: I8bcdab577aceccaaea15288c6e3ae4c83f218213 Reviewed-on: https://chromium-review.googlesource.com/880421 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#532396}
-
vitaliii authored
This reverts commit d26dcac0. Reason for revert: Seems to cause an exception (time out) on Linux ChromiumOS MSan Tests (see crbug.com/806715). The original CL (the one relanded) caused this exception too. Original change's description: > Re-land "FrameSinkVideoCapturer: Fix refresh logic for damaged sources." > > This reverts commit 52c31b74, to re-land > the original CL (https://chromium-review.googlesource.com/884996). The > viz_content_browsertests were failing because of a bug in the posix > shmem impl (in base/memory/shared_memory_helper.cc) when the pool is > being run in the VIZ process. For now, the tests have been added to the > viz_content_browsertests filter file; and once the root-cause issue has > been resolved, they can be re-enabled. > > TBR=xjz@chromium.org,kylechar@chromium.org > > Bug: 806635, 785072, 754872 > Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel > Change-Id: I0f419ce2aee170a0fbd966ff8e10bb99c3b7067f > Reviewed-on: https://chromium-review.googlesource.com/889934 > Commit-Queue: Yuri Wiitala <miu@chromium.org> > Reviewed-by: Yuri Wiitala <miu@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532322} TBR=miu@chromium.org,kylechar@chromium.org,xjz@chromium.org Change-Id: Ia3715ed63494598badbe85e2f418b792c952dadb No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 806635, 785072, 754872, 806715 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/890445Reviewed-by:
-
Ben Wagner authored
https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/707cd028b2b4..994eb2b34934 $ git log 707cd028b..994eb2b34 --date=short --no-merges --format='%ad %ae %s' 2018-01-26 wl [truetype] Fix multiple calls of `FT_Get_MM_Var' (#52955). 2018-01-23 apodtele [apinames] Anonymous version map for GNU linker. 2018-01-21 apodtele [unix] Call libtool to clean up. 2018-01-18 apodtele * src/base/ftver.rc: Fix mingw-w64 compilation. 2018-01-18 apodtele [build] Enable VERSIONINFO resource for Cygwin/MinGW. 2018-01-18 apodtele [build] Move VERSIONINFO resource. 2018-01-12 apodtele [build] Expand dllexport/dllimport to Cygwin/MinGW. 2018-01-12 apodtele [build] Improve and document MSVC build. Created with: roll-dep src/third_party/freetype/src R=bungeman@chromium.org,drott@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_msan_rel_ng PDFium issue: pdfium:995 Change-Id: I2a3483beea08685c6ce68c23e6f07f77988d751f Reviewed-on: https://chromium-review.googlesource.com/889767Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#532394}
-
Christian Dullweber authored
The feature shipped in M63 so the old code is not required anymore. This CL removes the old CBD dialog and the kTabsInCBD flag as well as migration code for preferences. Users that have not been migrated will get default values for selected checkboxes in the basic tab. Bug: 800184 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: If9325462be1bf652206b7956d5d25dcfec717078 Reviewed-on: https://chromium-review.googlesource.com/857059Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
James MacLean <wjmaclean@chromium.org> Reviewed-by:
-
Matthew Cary authored
VrShellTransitionTest#testExitPresentationWebVrToVrShell and VrShellNavigationTest#test2dFullscreenToWebVr continue to fail and keep the bot red. Bug: 804808 TBR: bsheedy@chromium.org,mthiesse@chromium.org Change-Id: I1721df42012b11662998f54627a8dd561c1a3253 Reviewed-on: https://chromium-review.googlesource.com/890182Reviewed-by:
Matthew Cary <mattcary@chromium.org> Commit-Queue: Matthew Cary <mattcary@chromium.org> Cr-Commit-Position: refs/heads/master@{#532392}
-
Matthew Cary authored
The test harness has working directory /, which is not readable in this test. Bug: 804348 TBR: aberent@chromium.org,brettw@chromium.org,thestig@chromium.org Change-Id: I31f02bef8aa61f62e2e07c94279e875d8b6d9570 Reviewed-on: https://chromium-review.googlesource.com/891158Reviewed-by:
-
Wei-Yin Chen (陳威尹) authored
Bug: 777962 Change-Id: I6cf85600830ddd6c2398a15e4a1c4c74aa9fbfd9 Reviewed-on: https://chromium-review.googlesource.com/886830Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532390}
-
