- 06 Apr, 2018 40 commits
- 
- 
Becca Hughes authoredThe media controls were performing manual paint invalidation from when we used to have MediaControlPainter. Now we use CSS this is handled for us automatically. According to manual testing this reduces the time painting from 153 ms to 49ms. BUG=821961,821414 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: Ie864f914c7ced0031710d81a7a702c8e3697a312 Reviewed-on: https://chromium-review.googlesource.com/998834 Commit-Queue: Becca Hughes <beccahughes@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#548832} 
- 
Mike Meade authoredThis cl adds a chromedriver test target for system, beta, dev, and canary installs. All tests involving next version mini installer are skipped due to issues with chromedriver. The change to previous version upgrade strategy will hopefully fix this. BUG=461856 Change-Id: Ic7ed5e8ba442394c26a5b3e36f9ca3c6d010916e Reviewed-on: https://chromium-review.googlesource.com/998739Reviewed-by: Greg Thompson <grt@chromium.org> Commit-Queue: Mike Meade <mmeade@google.com> Cr-Commit-Position: refs/heads/master@{#548831} 
- 
Julia Tuttle authoredWe were delaying the first report upload by a minute for no reason. Let's not do that. Change-Id: I5c6cf7c6e0b923d1722434b27698036cf9fa8d52 Reviewed-on: https://chromium-review.googlesource.com/996093 Commit-Queue: Julia Tuttle <juliatuttle@chromium.org> Reviewed-by: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#548830} 
- 
Jennifer Apacible authoredUpdate the browser/ side plumbing of updating the Picture-in-Picture viz::SurfaceId to be const&. This is already the case on the renderer/ side. BUG: 726619 Change-Id: I26ae3c8b67daca6fb958fb88ad6c762bebf1af42 Reviewed-on: https://chromium-review.googlesource.com/999305 Commit-Queue: apacible <apacible@chromium.org> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#548829} 
- 
Gustav Sennton authoredWe need to guard support library method calls with feature flags to ensure the methods are only called on webview / support library version where they're supported. In this CL we add feature flags for various APIs related to WebSettings, SafeBrowsing, and ServiceWorkers. Bug: 828612 Bug: 819595 Bug: 816506 Change-Id: Ice5f5645040ab7316ef90322812ca6319e8a2351 Reviewed-on: https://chromium-review.googlesource.com/995933 Commit-Queue: Gustav Sennton <gsennton@chromium.org> Reviewed-by: Richard Coles <torne@chromium.org> Reviewed-by: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548828} 
- 
Ehsan Karamad authoredThis CL adds support for zooming into the focused editable node when the node is inside an OOPIF. The CL resolves the issue by: * Refactoring and renaming ComputeScaleAndScrollForFocusedNode to ComputeScaleAndScrollForEditableElementRects where instead of the element, the bounds for the element and caret are passed as arguments. * Calculating the rectangle to scroll considering the current element bounds, caret bounds, and frame rects. The calculation tries to include the union of element bounds and caret bounds if possible or otherwise, a smaller rectangle which includes the caret bound. * Calculating and sending the relative position of caret and element inside the rectangle to scroll. * Using the rect to scroll and the relative caret and element bounds with the new ComputeScaleAndScrollForEditableElement to find the final zoom and scroll as similarly to the in-process case as possible. Link to design doc: https://goo.gl/2jHJUv Bug: 784982 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I63127abfeb31b543cc7e990bf01da77489357076 Reviewed-on: https://chromium-review.googlesource.com/830980Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Ehsan Karamad <ekaramad@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: David Bokan <bokan@chromium.org> Commit-Queue: Ehsan Karamad <ekaramad@chromium.org> Cr-Commit-Position: refs/heads/master@{#548827} 
- 
Koji Ishii authoredManual review of IMAGE/IMAGE+TEXT failures after the Time New Roman change in crbug.com/787020, a series started in CL:997255. This time is the result of manual reviews, up to the end in the alphabetical order, from bot result #4616. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I72a4b7b8430ba7478a06a6a343c55d4331cb10ba Reviewed-on: https://chromium-review.googlesource.com/999832 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#548826} 
- 
Tom Anderson authoredBUG=787020,829228 TBR=eae Change-Id: If6bffd3778b2bee8749fa3b1f77a0affd599d1ba Reviewed-on: https://chromium-review.googlesource.com/998133Reviewed-by: Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Thomas Anderson <thomasanderson@chromium.org> Cr-Commit-Position: refs/heads/master@{#548825} 
- 
chaopeng authoredSince touchpad gestures will expose as mousewheel events on JS. Developer may want the modifier state. In this patch, we read the modifier state and fill it into the event. Bug: 779372 Change-Id: Idf3ab53433795a40c7e89c887a9bb38a0c9f5f6b Reviewed-on: https://chromium-review.googlesource.com/996379Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#548824} 
- 
Corentin Wallez authoredTBR=kbr@chromium.org BUG=chromium:754986 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I1f48e4fe4b6f7e7d904e154f2f81ff27bdae4e0e Reviewed-on: https://chromium-review.googlesource.com/999732 Commit-Queue: Corentin Wallez <cwallez@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#548823} 
- 
Mohammad Refaat authoredDon't present StoreKitLauncher view, if there is already one presented. Also create FakeUIViewController and update store_kit_coordinater_unittest.mm to use it Bug: 828517 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I8222f0a831167999c7d3406412d94cc5b66bc6d5 Reviewed-on: https://chromium-review.googlesource.com/996375 Commit-Queue: Mohammad Refaat <mrefaat@chromium.org> Reviewed-by: Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#548822} 
- 
Michael Thiessen authoredA cvc->NativePage switch can happen while paused, leading the CVC's paused/resumed state to be incorrect because there's no current CVC when Chrome is resumed. We need to update the paused/resumed state for all CVCs during pause and resume to ensure the state is always correct. Bug: 829793 Change-Id: I64d816aad648dad0d1c5898041eabd6b56d77b91 Reviewed-on: https://chromium-review.googlesource.com/999736Reviewed-by: Ted Choc <tedchoc@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#548821} 
- 
Tommy Steimel authoredThis CL adds a test mode flag to modern media controls that hides the loading panel. This will be used for other changes as well, such as not showing the transition for the overlay play button. This is to be used for layout testing to prevent mismatch issues arising from the animations being at a different point. Bug: 775534 Change-Id: Ie79560f1f012992d50222d31f5a953b30a925916 Reviewed-on: https://chromium-review.googlesource.com/997015 Commit-Queue: Tommy Steimel <steimel@chromium.org> Reviewed-by: Nate Chapin <japhet@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#548820} 
- 
Tom Sepez authoredBug: 825557 Change-Id: Ibde6fc555aa9e35e1896a2eb5ecccdc80869c8ce Reviewed-on: https://chromium-review.googlesource.com/985026 Commit-Queue: Tom Sepez <tsepez@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#548819} 
- 
Joshua Bell authoredSimplify/rework the tests for the 'expires' options. Don't run the tests with the special secure-only prefixes, as that's orthogonal to the behvior. In Chromium, this also reveals that support for HTTP date strings as 'expires' values, as described in the explainer[1] is not yet supported. [1] https://github.com/WICG/cookie-store/blob/gh-pages/explainer.md Bug: 729800 Change-Id: I015fd643f18b59c8294f9dc62d576682132795fd Reviewed-on: https://chromium-review.googlesource.com/994284 Commit-Queue: Joshua Bell <jsbell@chromium.org> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#548818} 
- 
Garfield Tan authoredBUG=823634 BUG=b/74621390 TEST=Chrome builds. Change-Id: Id33704db9ed01b91791e111093da64ae406aeec3 Reviewed-on: https://chromium-review.googlesource.com/997024Reviewed-by: Jorge Lucangeli Obes <jorgelo@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Garfield Tan <xutan@chromium.org> Cr-Commit-Position: refs/heads/master@{#548817} 
- 
Brian White authoredChange-Id: Iaa0a21a8ef620a48874073ac7aadf25fb8087006 Reviewed-on: https://chromium-review.googlesource.com/974067Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#548816} 
- 
Owen Min authoredUsing unique_ptr instead of references to avoid copy of protobuf later. Bug: 812641 Change-Id: I847dcf99a7e475d51a04897942ea39c5c84ca47b Reviewed-on: https://chromium-review.googlesource.com/999043Reviewed-by: Maksim Ivanov <emaxx@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#548815} 
- 
Adam Rice authoredtestserver.py only supports one simultaneous request in basic auth proxy mode. This can lead to test timeouts when an unrelated request hogs the connection. Use the SelectServer.ThreadingMixIn to switch to thread-per-connection semantics, allowing the server to support any number of requests up to the limit of filehandles or memory. This CL only fixes the basic auth proxy mode. The http and https modes have the same flaw, but are harder to fix because all the handlers have to be made threadsafe. However, requests in the http and https modes are expected to be short-lived and there are no known problems caused by the deficiency. BUG=822614 Change-Id: Ieb2e91613f15e51a11af93c8da7d639da298b9a6 Reviewed-on: https://chromium-review.googlesource.com/999276Reviewed-by: Ian Clelland <iclelland@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#548814} 
- 
Pavel Yatsuk authoredBUG=811909 R=rkaplow@chromium.org Change-Id: I61e1b27c5470a5a2b334ba1adbf26a0b7605d571 Reviewed-on: https://chromium-review.googlesource.com/998350Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#548813} 
- 
Jérôme Lebel authoredThis patch adds a simple view that will be used to redo the sign-in workflow for unity project. This patch implements the IdentityPickerView which is the grey button with the down arrow. This can be seen in the mock[1] for the sign-in workflow. The accessibility is not done yet. The rest of the dialog will be implemented soon. IdentityPickerView: https://drive.google.com/open?id=1bHM8QGHl7uTVMcUMLm-v3WRclj4kNyEc IdentityPickerView in situe: https://drive.google.com/open?id=1P3ZkJqNnk9ShIUwdaSbX-aZjvPn7NReg IdentityPickerView with email only: https://drive.google.com/open?id=18jD8IZlngQbKa_KkZ6ZADsxDdRl32yn4 IdentityPickerView with big fonts: https://drive.google.com/open?id=1OLiDdQC6Tl1qBiG7ciVliAqX0LAwTXxz IdentityPickerView email only with big font: https://drive.google.com/open?id=1JkVtbTWQyCLwxwUeu0x_0nTKPvhFD9rE Mock[1]: https://docs.google.com/presentation/d/1cZfr5FGWGSy0PNaQ8uzik0alLAH-5glh1vsb030vha8/edit?ts=5aba5455#slide=id.g353bc22139_3_19 Bug: 827072 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia3caddb069b951e734161901325206555d8af0ae Reviewed-on: https://chromium-review.googlesource.com/995417 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#548812} 
- 
Roger Tawa authoredThe connector determines if the machine must be enrolled to machine level policies and begins the process if so. The connector also handles merging the machine level policies with the other policies (system policies and user cloud policies). Bug: 812641 Change-Id: I0d2e2f31cc689a6ad2a6eff96d57b49751ae1732 Reviewed-on: https://chromium-review.googlesource.com/980575 Commit-Queue: Roger Tawa <rogerta@chromium.org> Reviewed-by: Drew Wilson <atwilson@chromium.org> Cr-Commit-Position: refs/heads/master@{#548811} 
- 
Daniel Bratell authoredThe two identical AcceleratorMapping structs clashed in jumbo build experiments (no offical support of jumbo in this code yet). Bug: 803406 Change-Id: I065bfb447de67c05d2f6172ffbdeff4bc68e6538 Reviewed-on: https://chromium-review.googlesource.com/997832Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Daniel Bratell <bratell@opera.com> Cr-Commit-Position: refs/heads/master@{#548810} 
- 
Takumi Fujimoto authoredvirtual/layout_ng_experimental/fast/multicol/vertical-lr/caret-range-outside-columns.html This test is timing out on WebKit Mac10.11 (dbg), so we're labeling it as such. No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829866 Change-Id: Ica0d7a726e14111a1cae7ab3832b41af3ddf5912 Reviewed-on: https://chromium-review.googlesource.com/998983Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#548809} 
- 
lgcheng authored1. Add method for Android side to grant temporary permission to default app. 2. Create method to generate packagelist which should received USB device events. Bug: 776476 Bug: b:24572867 Test: Add test. Change-Id: I2b057e146393f90779d336b7bfafaf878077ca41 Reviewed-on: https://chromium-review.googlesource.com/998822Reviewed-by: Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Yury Khmel <khmel@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#548808} 
- 
Vaclav Brozek authored_CheckUniquePtr consistes of two checks -- one related to nullptr, one related to make_unique. The error messages are currently swapped by accident. This CL fixes that and adds a check for that. It also removes some confusing "java/src" subpaths from the mock file paths in the check. Those got in via copy&paste and are confusing, while not relevant for what the test is testing. Bug: 827961 Change-Id: Iaf3272cfc5fe0a641feaee861ad17fe71505800b Reviewed-on: https://chromium-review.googlesource.com/999604Reviewed-by: Dirk Pranke <dpranke@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548807} 
- 
Elly Fong-Jones authoredThis change: 1) Implements the Material menu spec, as linked in the attached bug; 2) Adds support to NativeThemeMac for using Aqua highlights in Aqua mode; 3) Removes the logic in BridgedNativeWidget to support translucent/blurred menu windows, since Material menus are opaque Future work: 1) Removing MenuRunnerImplCocoa, which can be rendered dead; 2) Fixing the synchronous-ness of MacViews menus Bug: 829347 Change-Id: I6219edf82c36cc0380dc9073835d8071a2709496 Reviewed-on: https://chromium-review.googlesource.com/998016 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#548806} 
- 
v8-autoroll authoredSummary of changes available at: https://chromium.googlesource.com/v8/v8/+log/3e5f91d2..6504f4a1 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I32418eb2e6e5e177bcee3569a5f0168b9baa0cf4 Reviewed-on: https://chromium-review.googlesource.com/999322Reviewed-by: v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#548805} 
- 
Oksana Zhuravlova authoredThis change also converts the minimum necessary amount of C++ code to pass objects of base::Value by value instead of std::unique_ptr. Bug: 646113,799482 Change-Id: I24fa46c4bf50526422e2f4e5e34eeb62999b9958 Reviewed-on: https://chromium-review.googlesource.com/994274Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Ilya Sherman <isherman@chromium.org> Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#548804} 
- 
Peng Huang authoredBug: 776877 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I6faa89c42bb8a6bf43c4a9c6fe86826dca316e4f Reviewed-on: https://chromium-review.googlesource.com/998317Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#548803} 
- 
Xianzhu Wang authoredThis saves a pair of RestoreOp and SaveOp between chunks with the same property tree state. https://ct.skia.org/results/cluster-telemetry/tasks/chromium_perf_runs/wangxianzhu-20180405050948/html/index.html showed that this CL can reduce paint_op_count by 3%. Bug: 803867 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I979b946e3642773152e19b8648a6e9c3e7268257 Reviewed-on: https://chromium-review.googlesource.com/997175 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by: Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#548802} 
- 
Qiyu Hu authoredThis is necessary as request_read/write_cb in android have become request_read/write_characteristic/descriptor_cb BUG: b:73743210 TEST: ./out/Default/unit_tests --gtest_filter="ArcBluetoothBridgeTest.*" Also push this to my device, working fine Change-Id: Ib850fceae979c29746affd5591cbac7264de77d2 Reviewed-on: https://chromium-review.googlesource.com/998797Reviewed-by:Luis Hector Chavez <lhchavez@chromium.org> Reviewed-by: Greg Kerr <kerrnel@chromium.org> Commit-Queue: Qiyu Hu <qiyuh@google.com> Cr-Commit-Position: refs/heads/master@{#548801} 
- 
Stephen McGruer authoredThis test is crashing consistently on Linux ASAN bots. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=MediaRouterIntegrationOneUANoReceiverBrowserTest.ReconnectSessionSameTab https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=mus_browser_tests&tests=MediaRouterIntegrationOneUANoReceiverBrowserTest.ReconnectSessionSameTab Following example in crrev.com/7bd70e54 this change prefixes the test with "MANUAL_", not "DISABLED_". Bug: 826016 Change-Id: I931cfcb34063ab11199782b9432120a7638e7d96 TBR=amp Change-Id: I931cfcb34063ab11199782b9432120a7638e7d96 Reviewed-on: https://chromium-review.googlesource.com/998660Reviewed-by: Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#548800} 
- 
Takumi Fujimoto authoredThis reverts commit 8f0f9ceb. Reason for revert: Speculative revert I think this CL is making media/controls/accessibility-timeline.html fail on WebKit Mac10.10, etc: https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Mac10.10/builds/45448 Original change's description: > Media Controls: expose current time in timeline accessibility value description. > > Instead of the proper value that may have many digits and make no sense > to a human. > > Bug: 829627 > Change-Id: I467354edc416af46de0f1c625e6b890414f8ae6f > Reviewed-on: https://chromium-review.googlesource.com/998915 > Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> > Reviewed-by: Tommy Steimel <steimel@chromium.org> > Cr-Commit-Position: refs/heads/master@{#548775} TBR=mlamouri@chromium.org,steimel@chromium.org Change-Id: I14730aa64a3b51e7fa4698eeb003d386b02e4b34 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 829627 Reviewed-on: https://chromium-review.googlesource.com/999105Reviewed-by: Takumi Fujimoto <takumif@chromium.org> Commit-Queue: Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#548799} 
- 
Yash Malik authoredBefort this CL, we would just ignore a VR intent if the VR services were out of date. In this CL, we show the DOFF, and show the update infobar in 2D. For DLAs some reason, intenting out to the play store sometimes results in Android dropping the intent, so we keep the CCT alive if the DON flow is successful and show the infobar. Bug: 824524 Change-Id: I2387b270a2e9c18f941e4a433309749f6ef25f87 Reviewed-on: https://chromium-review.googlesource.com/997018Reviewed-by: Ted Choc <tedchoc@chromium.org> Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Yash Malik <ymalik@chromium.org> Cr-Commit-Position: refs/heads/master@{#548798} 
- 
Friedrich Horschig authoredAs we have all approvals and the feature will fully launch with 66, enable it by default. Bug: 794108 Change-Id: I2cc5badc77391ff8bfe56b8653381c3648fd06a7 Reviewed-on: https://chromium-review.googlesource.com/999516Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Friedrich Horschig <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#548797} 
- 
Evan Stade authoredThis is a reland of 8ce1863f The last one was reverted for making some tests flaky. That should be fixed by 661500f0 Original change's description: > Turn on native notifications by default for Chrome OS. > > They're already on by default for Mash. This makes Chrome use the mojo > ("native") interface for notifications even in non-Mash. > > Bug: 578868 > Change-Id: If1ee85e2136dc0480ccee9a57835b0ffb9b47b8b > Reviewed-on: https://chromium-review.googlesource.com/963518 > Commit-Queue: Evan Stade <estade@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Cr-Commit-Position: refs/heads/master@{#544395} Bug: 578868 Change-Id: I33f5ec5a614e2cd7f0c745944413ea49965b82bf Reviewed-on: https://chromium-review.googlesource.com/999333Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#548796} 
- 
Asanka Herath authoredIt's not used. Change-Id: I741e8fe3285a43c12e3e1cad1cb1591647c3dc17 Reviewed-on: https://chromium-review.googlesource.com/998753Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#548795} 
- 
Theresa authoredBUG=828979 Change-Id: Ic65fcc0d1928dd07da37666b068e67daa683890c Reviewed-on: https://chromium-review.googlesource.com/999029Reviewed-by: Matthew Jones <mdjones@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#548794} 
- 
Christian Dullweber authoredUse the domain matching algorithm to determine which content setting rule could have influenced the creation of a cookie to correctly decide whether it should be deleted on exit. This fixes cases where cookies are visible to subdomains or domains with non-default ports and directly looking up the origin of a cookie in HostContentSettingsMap doesn't return the right result. Bug: 775080 Change-Id: If460537cf7a3de0a4a483d58ac1504637d9612be Reviewed-on: https://chromium-review.googlesource.com/975861Reviewed-by: Martin Šrámek <msramek@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: Karan Bhatia <karandeepb@chromium.org> Reviewed-by: Joshua Bell <jsbell@chromium.org> Reviewed-by: Matt Menke <mmenke@chromium.org> Reviewed-by: Mike West <mkwst@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#548793} 
 
-