- 25 Sep, 2020 38 commits
-
-
Rakina Zata Amni authored
It is not used outside of test code, so should be safe to remove it. Bug: 1131832 Change-Id: Id47091d52c8487cdf519cc4b3d69a660226a8a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428506Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Cr-Commit-Position: refs/heads/master@{#810396}
-
My Nguyen authored
Hide button for guest and show primary_user policy for secondary user. This is similar to the current settings behavior. View for guest: http://screen/8wpmjY3QNjs3uRV View for secondary user: http://screen/C9f2YsjQvd24QtC Note: Need to use value() for loadTimeData.overrideValues to work. Bug: 1113439 Change-Id: I6a1b15c3e403e9625bc8998578b1eee691993dff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427607 Commit-Queue: My Nguyen <myy@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810395}
-
Mike Wittman authored
Adds checks to ensure early detection of API contract violations that would lead to use-after-frees. This is a reland of affe1977, omitting a DCHECK that flakily failed. Bug: 1127466 Change-Id: I07aacfb6752fa2f2afc24cb999b08ccbb52f9f0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429307 Commit-Queue: Mike Wittman <wittman@chromium.org> Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org> Auto-Submit: Mike Wittman <wittman@chromium.org> Reviewed-by:
Etienne Pierre-Doray <etiennep@chromium.org> Cr-Commit-Position: refs/heads/master@{#810394}
-
Jinsuk Kim authored
This CL removes some outbound dependencies of TopToolbarCoordinator: 1. IdentityDiscController - observer registration is now managed by ToolbarManager - Supplier is passed to StartSurface instead 2. compositor.Invalidator.Client compositor.layouts.LayoutUpdateHost - Uses a simple Runnable instead of the interface 3. HomepageManager - observer registration is now managed by ToolbarManager Bug: 1127732 Change-Id: I52a2a714fa180637ce8418559956ec55e803da0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423144Reviewed-by:
Patrick Noland <pnoland@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#810393}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/71ee049b6b17..df53732e1b69 2020-09-24 hjd@google.com Merge "ui: Swallow key events on crash dialog" 2020-09-24 treehugger-gerrit@google.com Merge "Fix GPU memory metrics aggregation" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I270bfc38ee2c1baa1580be69e2424bdf5bf1bbd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430223Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810392}
-
Jazz Xu authored
This CL adds a pin button in media tray dialog and media controls detailed view. The button allows user to pin/unpin global media controls to/from shelf. Global media controls will be pinned by default if the primary display size is larger than 10 inches. Bug: 1130963 Change-Id: I9eb8d8abbef7029141967fff43c17d2144287f82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422867 Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#810391}
-
Scott Lee authored
All tests, including skipped ones, are added to test_run_results, and they are all logged in the json output via the test_run_results object. However, test_result_sink.sink() was missing in some places where skipped tests are added to test_run_results. With this CL, skipped tests are also reported to ResultDB. R=robertma@chromium.org, CC=chanli@chromium.org,iannucci@chromium.org,nodir@chromium.org Bug: 1099573 Change-Id: I24ab0c45fb057f7fd2b6fbb993d5c5f847806dcd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427151 Commit-Queue: Scott Lee <ddoman@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#810390}
-
Sinan Sahin authored
Change-Id: I620dd3836672a91e681842407c426c3b817adcb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430303 Commit-Queue: Sinan Sahin <sinansahin@google.com> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#810389}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/85d92d37c4c2..3cd3b4e18cd1 2020-09-24 bsheedy@chromium.org [Devil] Remove forwarder strace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC wenbinzhang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1038789 Tbr: wenbinzhang@google.com Change-Id: I3b15bd3e66d9ff5a6b0658e233da99b0ab2c067d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429372Reviewed-by:
-
Wenyu Fu authored
1. When CCT policy is set and Browser App FRE working as before; 2. When skip FRE shared pref set, FRE is not skipped with policy; 3. Variaties of test causes in *EnterpriseSupportTest, and histogram for all the testcases. Bug: 1120851 Change-Id: I766c66ca06dc5c90331c59e7f4392f5ab6d34d3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422687 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#810387}
-
Michael Checo authored
Bug:1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: I15bdcec5d4737dcd5dba187b1b36346969e43edf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429443 Commit-Queue: Michael Checo <michaelcheco@google.com> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810386}
-
Joe Laughlin authored
The calls to GetCurrentProcessToken() return a process token handle that must be closed. This function is implemented in the same file, and calls OpenProcessToken(). Win8 and later OSes have a function of the same name ::GetCurrentProcessToken() which returns a psuedo-handle that does not need to be closed. The # Enter a description of the change. Fix handle leaks of the process_token. Bug: 1126279 Change-Id: Idbeaa92a173409a7b7152c04dcc67c917e8c306e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2402081 Commit-Queue: Joe Laughlin <joel@microsoft.com> Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Bruce Dawson <brucedawson@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#810385}
-
Steven Bennetts authored
Tast.NetworkEventLog is showing some frequent errors. This demotes or modifies the errors to avoid spam on frequently loaded builders. https://tastboard.corp.google.com/test/logs.NetworkEventLog Bug: b/167581118 Change-Id: I23520471f9fc14fc7a4200143c9ac7e557cd37b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430024Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#810384}
-
Garrett Beaty authored
The mojo builders have been moved to the chromium.mojo builder group and the old entries are no longer necessary. Bug: 1131163 Change-Id: I8a2fdc1d46d24109e7fcc24ae9aa5df23aa93acb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429284 Auto-Submit: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#810383}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009240800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/jVnFFKK_QUsuM6vpE9PGM0P46Dc1MxtkuRNyoYqmMlEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome;luci.chrome.try:linux-chromeos-chrome-easwa Bug: b/159851982,b/160194281,b/161406194,b/169111126 Tbr: media-app@grotations.appspotmail.com Change-Id: I593d67ad295379640529711283caecdab8e4893c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428821Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#810382}
-
Joel Hockey authored
Screenshots: http://go/chrome-ss/0a0bc6ca1f1985c5c25a726a8ef123c27c33c7e1 http://go/chrome-ss/bd6f5d9d4ef33bd9ae8addb575c88dd2a1d04818 http://go/chrome-ss/d4b444ab2d88cb4bd11e21e52b7246de60c8bf71 When Chrome OS did not support external protocol handlers, it replaced browser/ui/views/external_protocol_dialog with browser/chromeos/external_protocol_dialog which states that no handlers are available. ARC has added a dialog which is shown when any android apps can handle a link. This CL uses the standard ExternalProtocolDialog for Guest OS apps when ARC does not handle a link, but Guest OS can. * Renamed CrOS version of ExternalProtocolDialog to ExternalProtocolNoHandlersDialog. It is still used when no handlers are found. * Changed ui/views/external_protocol_dialog to now be compiled into CrOS, but leaving out ExternalProtocolHandler::RunExternalProtocolDialog which is provided in the CrOS version: chromeos/external_protocol_dialog.cc. * Replaced platform_util_chromeos OpenExternal to Launch the registered Guest OS app. This function was previously not ever called in CrOS. Bug: b/168506505 Change-Id: I89ffd84b9308cb2ce4b7e0691183e0da3402a4cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423675 Commit-Queue: Joel Hockey <joelhockey@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Jason Lin <lxj@google.com> Cr-Commit-Position: refs/heads/master@{#810381}
-
Pranav Batra authored
Bug: 1015662 Test: xvfb-run ./unit_tests --gtest_filter=PrintPreviewStickySettingsUnittest.* Change-Id: I7eb02464ac26aa899e30b846123b1e291d90488f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2411566Reviewed-by:
Sean Kau <skau@chromium.org> Reviewed-by:
-
Mei Liang authored
crrev.com/c/2402302 assumes TabModelSelector is always initialized which is no longer true with Instant start enabled. This CL fixes the wrong assumption by checking the TabModelSelector initialization state before accessing the TabModelSelector. Because of Instant start, we should always use the cached flag/value. We need to get the thumbnail aspect ratio from the TabUiFeatureUtilities#THUMBNAIL_ASPECT_RATIO instead of ChromeFeatureList#getFieldTrialParamByFeatureAsDouble which requires native initialization. We update all the usages to use the cached value in crrev.com/c/2427149. This CL is verified to be behind the gating function TabUiFeatureUtilities#isLaunchPolishEnabled by formal equivalence checking tool here: http://crrev.com/c/1934235. Change-Id: Ib4e72d9535328034a3914adec44ea744826d92cb Bug: 1131441 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427345 Commit-Queue: Mei Liang <meiliang@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#810379}
-
Morten Stenshorne authored
We need to walk fragment item children, in case there are floats in there. This will make things like offsetLeft and offsetTop work for such floats, fixing a few web tests. Bug: 829028 Change-Id: I57f9901afe19b375d92b785a09358904d66b028e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428866Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#810378}
-
Kyle Williams authored
This destination is used by the CfM Hotlog service, a system daemon installed on Meet Device hardware to upload telemetry data to our own backends. BUG=b:169342326 TEST=none Change-Id: If51bfa6459c7c1a0fd81dca97949995d49563e70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429434 Commit-Queue: Kyle Williams <kdgwill@chromium.org> Reviewed-by:
Zach Trudo <zatrudo@google.com> Cr-Commit-Position: refs/heads/master@{#810377}
-
Kyle Horimoto authored
Includes icons for the Settings, Wallpapers, and Keyboard Shortcuts apps. Screenshot: https://screenshot.googleplex.com/7KdMiBkMFH7fuxh.png Change-Id: I6cf1d45d78f36caeb1429629cc0067b1cbd57daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429395 Auto-Submit: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#810376}
-
Andrew Grieve authored
Remnants from pre-R8. Change-Id: I7acc511189badbf61ddd69b64a0b388473079bf4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2430026 Commit-Queue: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#810375}
-
Anton Bikineev authored
This is needed to simplify initialization interface, especially when PCScan is added. Bug: 11297512 Change-Id: I674f5b2f237bfb08e4dcbfd83e1fa3854acf9886 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2421676 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#810374}
-
Kramer Ge authored
Multiple buffer acks arrive from Wayland server for a frame. BufferQueue only expects one swap completion callback and one presentation feedback per frame. This CL groups buffers acks in the same frame and run callbacks when buffers in 1 frame are all ack'ed. This is 5/? CL for overlay forwarding using wl_subsurface. Bug: 1063865 Change-Id: I026eb1aba38288c5436c672af4101d61495031b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343545Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Maksim Sisov (GMT+3) <msisov@igalia.com> Commit-Queue: Kramer Ge <fangzhoug@chromium.org> Cr-Commit-Position: refs/heads/master@{#810373}
-
Tibor Goldschwendt authored
This is in preparation to render a shopping task module on the NTP. In follow up CLs, we will use the shopping tasks service to query available tasks upon NTP load. The shopping tasks service queries GWS for available tasks and expects GWS to respond with a JSON like the one below: { "update": { "shopping_tasks": [ { "title": "hello world", "products": [ { "name": "foo", "image_url": "https://foo.com", "price": "$500", "info": "visited 5 days ago", "target_url": "https://google.com/foo" } ], "related_searches": [ { "text": "baz", "target_url": "https://google.com/baz" } ] } ] } } Fixed: 1130852 Change-Id: I544a2034540d132869b7d55da5b22b7e614358c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2426767 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:Nicolas Ouellet-Payeur <nicolaso@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#810372}
-
Brian Salomon authored
Change-Id: I7a9c9252892615fe4a7dc42566a6398403481483 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429969 Auto-Submit: Brian Salomon <bsalomon@google.com> Reviewed-by:
Peng Huang <penghuang@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Commit-Queue: Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#810371}
-
Kyle Horimoto authored
This CL also adds a NearbyConnection class, which currently does nothing when Connect() is called. A future CL will call the Nearby Connections API within that class. Bug: 1106937 Change-Id: I397c7c8ff62092559b158f8cb09b8e0948544188 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425211Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#810370}
-
K. Moon authored
Adds throttling that pauses loading when too much unread data accumulates, then resumes loading when the backlog clears. For consistency, switches all EXPECT_CALL() expectations without argument matchers in url_loader_unittest.cc to the argument-less form. Fixed: 1099022 Change-Id: Iac02f17bbcac166e92e19611e5ad35786a3c3a2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2427844 Commit-Queue: K. Moon <kmoon@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
Release_Notes: http://go/help_app-x20/relnotes/Main/help_app_nightly_202009240800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/pmx13oYqsBxVgUj6p9fCwrTtgN1M6INq4nvwNMlYmL4C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/153596786 Tbr: help-app@grotations.appspotmail.com Change-Id: Id05f048c0b4f0491ebfc252f6f509dfad0ec64db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429167Reviewed-by:
-
Ana SollanoKim authored
Previously, the size and offset of the grid in the unit test FixedSizePositioning (added in the following change https://chromium-review.googlesource.com/c/chromium/src/+/2369673) differed from the rendered result; the grid's size was 100x400 rather than 200x200, and the items' offsets in x were 0. This change fixes the expectation to match the rendered result by deleting the parameters shrink_to_fit and is_new_formatting_context from the function ConstructBlockLayoutTestConstraintSpace(). A div was also added to wrap the grid. Moreover, the intrinsic_block_size and border_box_size are defined. The case where the height is auto is a TODO for now because it depends on final computed row/column sizing, which is still in progress. Bug: 1045599 Change-Id: I4dbbb093e12aa4aa7cd1a26168212e63e870ebde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2422277 Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Ethan Jimenez <ethavar@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#810367}
-
Dana Fried authored
When allocating zero-weight views, FlexLayout expects them to be allocated up to their preferred size in the first pass or dropped out. However, if the preferred size is zero, they may not yet be visible in the second (allocate-excess-space) pass. We had a consistency DCHECK that was failing if the view wasn't visible the second pass; this is now updated to visible OR zero-preferred-size. Change-Id: I41368f09bf2fa3056f7676e26ad1b0ba2c895925 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429647 Commit-Queue: Dana Fried <dfried@chromium.org> Commit-Queue: Charlene Yan <cyan@chromium.org> Auto-Submit: Dana Fried <dfried@chromium.org> Reviewed-by:
Charlene Yan <cyan@chromium.org> Cr-Commit-Position: refs/heads/master@{#810366}
-
Frank Liberato authored
We're getting some crashes that look like either use-after-free or heap corruption in MediaWebContentsObserver. This CL adds a quick check for it, that will abort if it finds either, and tell us which one it found. Hopefully, it will help us to narrow down if (a) use-after-free/corruption is actually what's going on, and (b) if it's happening as part of the call into MWCO or earlier. Change-Id: I91edc46af55b9dcbd223b01c3bb80c22b1386903 Bug: 1111291 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429246Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Frank Liberato <liberato@chromium.org> Cr-Commit-Position: refs/heads/master@{#810365}
-
Chris Thompson authored
As part of moving CT verification to occur within the state machine of cert verification, move the CTVerifyResult fields into the CertVerifyResult as appropriate. As a nice side benefit, this allows CT verification details to be handled in browser tests using ContentMockCertVerifier. Bug: 848277, 1016635 Change-Id: I365358ca12ecd9205d8103ed0e3396cdb48144b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2423060Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Commit-Queue: Emily Stark <estark@chromium.org> Cr-Commit-Position: refs/heads/master@{#810364}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/afef7a74a796..9e81182f8ea5 2020-09-24 alessiob@webrtc.org RNN VAD build file refactoring: split into separate (private) targets 2020-09-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 532b3f34..b70f108b (810021:810146) 2020-09-24 phensman@webrtc.org Remove instance of IP logging in NetworkMonitorAutoDetect If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I4da42077bcf247fc09fc8e9e6d7c001ed5f58eea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429376Reviewed-by:
-
Sylvain Defresne authored
Change all files that depends on the existence of the deprecated global sources assignment filter to explicitly configure it by importing the deprecated_default_sources_assignment_filter.gni and calling set_sources_assignment_filter(). This is a preliminary step before removing the global assignment in //build/config/BUILDCONFIG.gn and incremental migration of those files from the deprecated feature. To verify, used a patched version of gn: https://gn-review.googlesource.com/c/gn/+/6401 And then ran: gn gen out/xxx | grep Filtering: | sort with and without the patch for all configuration (cross-compiling Windows on Linux). This is a followup of https://crrev.com/c/2418443 that missed some of the usages (as not all configuration were tested). TBR=jochen Bug: 1018739 Change-Id: I76d38ec4e3720d36de30bb7921148ca76b3d4d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2428894Reviewed-by:
-
Alan Screen authored
Components have rules about dependencies of higher vs. lower layers. Make note that //printing is a lower layer, similar to //gpu. Change-Id: Ifee3a053561a157ff400e16aeede4452486247da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2424069Reviewed-by:
-
Mason Freed authored
In [1], the view source document table was changed to word-break: keep-all, to avoid the slow layout path for word-break:break-all. The intention there was to not allow word breaking at all, and have each source line on a single displayed line. The better (correct) way to achieve that is to use the white-space property, as pointed out by kojii@ in [1]. This CL changes the white space property to pre, instead of nowrap (as suggested), to also preserve white space in the source file. [1] https://chromium-review.googlesource.com/c/chromium/src/+/2424038 Bug: 920571 Change-Id: I3271dcce2f7f546ea5f8a33997226e2ec4894fd8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429204 Commit-Queue: Mason Freed <masonfreed@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Reviewed-by:
-
James Hawkins authored
R=khorimoto@chromium.org Bug: 1045266 Test: OSSettingsNetworkProxySection* Change-Id: I3594eadfee74353e4e9b91ced94906baa81d3813 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2429245Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: James Hawkins <jhawkins@chromium.org> Cr-Commit-Position: refs/heads/master@{#810359}
-
- 24 Sep, 2020 2 commits
-
-
Zentaro Kavanagh authored
Bug: 1125150 Test: browser_tests --gtest_filter=DiagnosticsApp* Change-Id: If4bdef02e6b91446014916a4ec6ae51f97ae3cb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425424Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org> Cr-Commit-Position: refs/heads/master@{#810358}
-
Mason Freed authored
Quirks mode layout is slower, so change to no-quirks. Note that this goes against the spec [1], which mandates quirks mode for text documents. An issue [2] has been raised to change that, but in the meantime, this seems like a very low (compat) risk change. For now, however, the WPT test will not be changed, and a broken expectation will be committed. [1] https://html.spec.whatwg.org/multipage/browsing-the-web.html#read-text [2] https://github.com/whatwg/html/issues/5939 Bug: 1131185 Change-Id: If7ac8cbe8b4ec277f2cb288d120698b9bacf773c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2425109 Commit-Queue: Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#810357}
-
