- 31 Jan, 2020 40 commits
-
-
Simon Zünd authored
This CL re-writes a breakpoint web test using a new SourcesTestRunner helper introduced in https://crrev.com/c/2027427. This should not only prepare the test for the upcoming source map asyncification but also reduce the overall flakiness of breakpoint web tests. R=sigurds@chromium.org Bug: chromium:1032016 Change-Id: I1002384ffa6bbc330cd3132c183e356e5b1f59ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029368 Commit-Queue: Simon Zünd <szuend@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#737235}
-
Adam Rice authored
For "cheap" checks of state in the streams implementation, use CHECKs instead of DCHECKs. This will improve robustness against logic errors. BUG=1045931 Change-Id: I01af9c21feca586c74e354faa8f919fbb7565c64 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032471Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#737234}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a161f0c9091d..d65a6015c6a6 Created with: gclient setdep -r src-internal@d65a6015c6a6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: I02c5f142fb69151a1ea789f9e3df7183b46b10c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032846Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737233}
-
Koji Ishii authored
Bug: 982194 Change-Id: I1b55db65d9fae0903d91d0fb682da5c15ac0891c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028876Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#737232}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e196bc85ac2d..088b1baa948a git log e196bc85ac2d..088b1baa948a --date=short --first-parent --format='%ad %ae %s' 2020-01-31 ynovikov@chromium.org Change uuid attributes to declspec in winrt. Created with: gclient setdep -r src/third_party/angle@088b1baa948a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC tobine@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tobine@google.com Change-Id: Ied6ebb542bb12063bb6de5c21815417af2d929b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032844Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737231}
-
Kuznetsov Alexey authored
In chromium code audio_utility.cc we just need to use PI constant from //base instead from local file. This is some polishing. Change-Id: I71d7042a9ed40c563c67bab2237b267c822a6961 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027367Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Yuri Wiitala <miu@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#737230}
-
Tao Bai authored
Add call site for AwContents state of AwContentsLifecycleNotifier. Bug: 1042048 Change-Id: I6d59b2b956fe8b1dbf2f208a3f2881fdc6f4d778 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023400 Commit-Queue: Tao Bai <michaelbai@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737229}
-
Alan Screen authored
Given that there are so few printing-specific features, have them all in one file instead of multiple very small files for each OS. ChromeOS did not use the printing::features namespace for the flags before, so update that throughout for consistency. Change-Id: I30d062236d404d7f53c212333ddfcc8c27968503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031867 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#737228}
-
Alan Screen authored
With the removal of Harfbuzz subsetter the only printing/common features left are related to XPS printing on Windows. As discussed in [1] move these out of common so that they can be included as part of the regular printing component. [1] https://crrev.com/c/1988767/5 Bug: 1008222 Change-Id: I5b5c096eaa50cf53cfe62c1f12319cb506c6fc7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026369 Commit-Queue: Alan Screen <awscreen@chromium.org> Reviewed-by:
-
Takashi Toyoshima authored
Bug: 941354 Change-Id: Iaf0b1ca9e8a4898333dead2ba4b4a38cbee00b48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028880Reviewed-by:
Nicolas Ouellet-Payeur <nicolaso@chromium.org> Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#737226}
-
nancy authored
When adding a new user, although IsMultiProfileAvailable return true, MultiUserWindowManagerHelper::GetWindowManager is still null. So add a check for MultiUserWindowManagerHelper::GetWindowManager. When MultiUserWindowManagerHelper::GetWindowManager is still null, we don't need set owner for windows, because multiple user window manager is not ready yet. BUG=1047376 Change-Id: Idb527b24e0f7d66714b6f408b08f20e50b6f8c32 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032486Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#737225}
-
Noel Gordon authored
The iconSet property of most volume types is empty, but we expect that third party volumes (ANDROID_FILES, DOCUMENT_PROVIDERS and File System Providers) should provide icons in the respective iconSets. Add a shouldProvideIcons() helper to volume manager common, that lists the volumes types that should provide icons. Bug: 992819 Change-Id: I00b9d1910ff9069fb82d1a51519f0dc72d2c81a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032469 Commit-Queue: Alex Danilo <adanilo@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#737224}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d998cfeb. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I42cff1fb06e632c0598a10a64abb422b80a518c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031907Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737223}
-
Md. Hasanur Rashid authored
The Chromium C++ style guide recommends that DVLOG is used as it "avoids bloating the release executable and in debug can be selectively enabled at runtime". Fixed: 519010 Change-Id: I0a66e81332847b250bfc1038727ddfa020ed634d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029472 Commit-Queue: Md. Hasanur Rashid <hasanur.r@samsung.com> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#737222}
-
Kent Tamura authored
inner_block_ will be removed soon. The function will help the removal. This CL has no behavior changes. Bug: 1040828 Change-Id: I5acc8dc885a5c218fe215c37c017d0463cfb3ce6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032448Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/689bf533edd9..a161f0c9091d Created with: gclient setdep -r src-internal@a161f0c9091d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701 Tbr: jbudorick@google.com Change-Id: Ie81acfebc79a4d6d4a11f0e76c1f62b6098402a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032580Reviewed-by:
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/f28d0ae61457..f44a809f9a3b git log f28d0ae61457..f44a809f9a3b --date=short --first-parent --format='%ad %ae %s' 2020-01-31 kainino@chromium.org Remove VK_DEFINE_NON_DISPATCHABLE_HANDLE magic, use explicit VkHandle wrapper 2020-01-31 enga@chromium.org [docs] Add documentation for Dawn's testing infrastructure Created with: gclient setdep -r src/third_party/dawn@f44a809f9a3b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: chromium:1046362 Tbr: cwallez@google.com Change-Id: Ia6733a40384a8bea2380f8132a0ac1d246690cb6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032579Reviewed-by:
-
Anand K. Mistry authored
Bug: None Change-Id: Idb695ce4366dbcbbf48e2958b2f74276d5491ad9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030927 Auto-Submit: Anand Mistry <amistry@chromium.org> Reviewed-by:
François Degros <fdegros@chromium.org> Commit-Queue: Anand Mistry <amistry@chromium.org> Cr-Commit-Position: refs/heads/master@{#737218}
-
John Delaney authored
This change adds a feature which modifies the AdTagging heuristic for frames that are the results of non-srcdoc navigations. This change is only implemented in AdsPLMO for metrics and the heavy ad intervention, and is not intended to be implemented there permanently. Frames with a url that match an allowed filter list rule and are not considered ad frames even if they are created by ad script. Frames with a url that are same-domain to the top-level page and do not match a disallow filter rule are not considered ads, even if created by ad script. Bug: 1030325 Change-Id: I45831aa84e339f0d8fd8c642e8fb2520d3d76d9b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954181 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#737217}
-
Toni Barzic authored
Fixes an edge case where opaque shelf background doesn't get reshown after it's hidden for transition from home screen. The opaque background is hidden when transition from kShown hotseat state starts, and reshown once it ends. In both cases ShelfView checks the original hotseat state to determine whether the opaque background state should be updated. This does not work if the original hotseat transition is interrupted by another hotseat state change (to kShown state, as only transitions from/to shown state are animated) - in this case hosteat transition animator stops observing implicit animations before it updates the animating backgrounf transform, so it doesn't send the end notification for initial transition. Once the second animation finishes, the shelf widget delegate will only see the end notification for the second transition, and given the hotseat state is not kShown, it will not update the opaque background visibility. (If the user exits tablet mode before going to home screen again, they will see completely transparent shelf). BUG=1044751 Change-Id: I07e15126215c908831ad24b4aeb525eb2ef66513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032008Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#737216}
-
Sergey Ulanov authored
Now FuchsiaAudioRenderer can handle mid-stream configuration changes. Bug: 1047537 Change-Id: I93b61f56fd1a9e84b2a5a1c82dc3fc0c5f660e3a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029455 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Auto-Submit: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737215}
-
Manu Cornet authored
Also fix a memory management issue that was latent beforehand, use the |DeleteDelegate| pattern that the shelf widget is already using, for the navigation widget, since a widget delegate must outlive its widget. This makes it more clear that all the shelf components (nav widget, hotseat, status area, shelf widget) are now meant to play a similar role in the class hierarchy. This change isn't expected to have any impact on user-visible behavior. Change-Id: I78688ec4f4fda7185dfcdf9e260c94f083d94923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032188 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#737214}
-
Kurt Horimoto authored
The default cancellation handler is deleted after calling Cancel(), so the observer needs to be removed before cancellation. Bug: 1038514 Change-Id: I9a638b9ae7c6c44e4655fb5d80674285620c308d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032062Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Kurt Horimoto <kkhorimoto@chromium.org> Auto-Submit: Kurt Horimoto <kkhorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#737213}
-
Virender Singh authored
This change modifies the PDF document's name string to follow formatting rules defined in: http://userguide.icu-project.org/formatparse/messages Bug: 1043505 Change-Id: I1cad4ecea83b41a1ccf7adb68ad3e2a104f65749 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2030350Reviewed-by:
Kevin Babbitt <kbabbitt@microsoft.com> Reviewed-by:
Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Kent Tamura authored
If a json5 file for make_names.py contains duplicated names, make_name.py produced invalid C++ code and we had to remove duplicates. * make_names.py should report an error for duplicated entries instead of producing invalid code. * html/keywords.json5 should allow duplicated entries because it contains keyword sets for multiple attributes and some keywords are valid for multiple attributes. Change-Id: I81c2a4a978ece5a03471fd8b37d85b61cda2a8e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032465 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#737211}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/08f1abcc5bb0..659962bc1b4c git log 08f1abcc5bb0..659962bc1b4c --date=short --first-parent --format='%ad %ae %s' 2020-01-31 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. Created with: gclient setdep -r src/third_party/devtools-frontend/src@659962bc1b4c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I564612f9fcff1253adb663ddd162db42b6e629a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032569Reviewed-by:
-
Kent Tamura authored
* select-box.html Convert a pixel test to an assert_selection.js test * select-element-paragraph-boundary.html Merge this into select-box.html * document-write-option.html Convert a pixel test to a reference test. Bug: 1040828 Change-Id: I15e156016b183a44709f7a6bc7b520f83a7a73f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032644Reviewed-by:
-
Kent Tamura authored
PositoinIterator returned a wrong result if INPUT, SELECT, or TEXTAREA has two or more children. Strategy::LastOffsetForEditing() doesn't take into account of IsUserSelectContain(). It's inconsistent with ShouldTraverseChildren<Strategy>. So, this CL introduces an IsUserSelectContain()-aware version of LatOffsetForEditing(). Bug: 697283 Change-Id: Id04cf8ce5cbe3702a4c51a1b6057693c7c669cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029536 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
rbpotter authored
- Call resetString() after setting the textbox value, so that future updates to the textbox will trigger an input-change event. - Also make some conditions more clear in the margins code. Bug: 1046683 Change-Id: I742f264a0dca2c1b5a41e769ada5f5d2966e5c92 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032433 Commit-Queue: Rebekah Potter <rbpotter@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#737207}
-
Chris Palmer authored
This reverts commit a7527ee7. Reason for revert: It was a speculative workaround that may not be needed. Original change's description: > Speculatively turn off the `PartitionAllocZeroFill` optimization on macOS. > > It might? be the cause of some test flakage. > > Bug: 892550 > TBR: ajwong > Change-Id: I4ac98e2e5e3d02526ed2c187157d097b82adc756 > Reviewed-on: https://chromium-review.googlesource.com/c/1266199 > Commit-Queue: Chris Palmer <palmer@chromium.org> > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Marijn Kruisselbrink <mek@chromium.org> > Cr-Commit-Position: refs/heads/master@{#597390} TBR=ajwong@chromium.org,palmer@chromium.org,mek@chromium.org,haraken@chromium.org,mastiz@chromium.org Bug: 892550 Change-Id: I55bc9c2869f506cd0f3fa73103c715982b598599 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031709Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Albert J. Wong <ajwong@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#737206}
-
Rachel Wong authored
Bug: 1014839 Change-Id: Icd2ff4b14e42118f05bc964824bea004e3a14bf5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029388Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#737205}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/51aa23b1aa22..689bf533edd9 Created with: gclient setdep -r src-internal@689bf533edd9 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1041701 Tbr: jbudorick@google.com Change-Id: I3300c5f5b906d03766783c171d0aeb30d8b1bbc4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032570Reviewed-by:
-
Daniel Clark authored
This change implements live-update and double-escape behavior for the month input popup. When arrow keys are used to change the selection, the changes are immediately reflected on the in-page control (and input events are fired). When the user hits escape, if they have made changes these are reverted without closing the popup. A second escape (or the first one, if no changes were made) closes the popup. Behavior when clicking on a month is not changed; the popup is still submitted immediately (as opposed to other types like datetime-local where the user may want to go on to select other values after clicking the date). The selection/highlight model is changed so that using the arrow keys moves the selection instead of the highlight, invalid dates cannot receive selection, and the highlight is only used as a hover style. Initialization of the control is changed such that if there is any valid month, one will be selected, avoiding scenarios where we don't paint a focus ring because there is no starting selected month. Fixed a bug where months invalid due to the step attribute were not greyed out. The above changes required a lot of the same valid-date-range-seeking functionality already implemented in CalendarPicker, so I removed the side-effects from these functions and moved them into a mixin consumed by both CalendarPicker and YearListView. All of above behavior changes apply only to the standalone month picker; the month selector embedded in date/week/datetime-local popups is unchanged. I'm not sure that live-update and double-escape makes as much sense in those contexts, although we could consider a later follow-up to change the selection behavior to match the new standalone picker's behavior. Bug: 1045195 Change-Id: I264a5285ec7df8bca4b0ad6389886b9580c12ae2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029243Reviewed-by:
Ionel Popescu <iopopesc@microsoft.com> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Dan Clark <daniec@microsoft.com> Cr-Commit-Position: refs/heads/master@{#737203}
-
John Lee authored
When a user drags a tab or tab group from another browser, a placeholder is created and appended to the end of the tab list to suggest that the tab or group will be dropped at the very end. This is a temporary solution for not being able to directly place tabs in a specific index. Bug: 1005560 Change-Id: I283862086531a2b21222d43e9a6b650af5b9219a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032057Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/be99ee8f17f9..ec47b57f1440 git log be99ee8f17f9..ec47b57f1440 --date=short --first-parent --format='%ad %ae %s' 2020-01-30 steveanton@webrtc.org Do not transition ICE gathering state to 'complete' when closing Created with: gclient setdep -r src/third_party/webrtc@ec47b57f1440 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I1068ef7ddf88ce30abfbaf5d59b6b26eae8d0a1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032212Reviewed-by:
-
Hugo Benichi authored
This patch makes ArcNetHostImpl more robust in face of delayed or missing IP configuration properties from shill: - When no IP configuration can be obtained for a network, always request with a few seconds delay a full network property update in order to let IPv4 DHCP or IPv6 autoconf complete. - Send net.mojom ActiveNetworksChanged notifications to ARC on more triggers from NetworkStateHandlerObserver. This allows ARC to obtain IP configuration properties for the host when they are populated after the initial network connection. - Preferably use IP configurations obtained through DeviceState (shill's Device DBUS objects). This allows ARC to consistently obtain both IPv4 and IPv6 configurations for the host. - Always drop partially empty IP configuration object. This allows to filter out double IPv4 configuration objects send by shill and allows ARC to be less defensive about net.mojom notifications sent by Chrome. BUG=b:148431888 BUG=b:146182659 TEST=Flashed atlas, manually watched Chrome and ARC logs while triggering new connetions to dual stack GoogleGuest and IPv6 only GoogleGuest, confirmed that ARC now always get the IP configuration immediately or shortly after the new connection, as far as tested. Change-Id: I24d26d6492f133e0c38949c8c3b4403687bfac21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028881 Commit-Queue: Hugo Benichi <hugobenichi@google.com> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#737200}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromium.org Change-Id: I7b61247ec4a9b8c2ae610ea7a7d4ec621886b45f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2032784Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#737199}
-
Daniel Cheng authored
Change-Id: Iee21649faf1407f3c0c404b6e931d524b0ceabe5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029252 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#737198}
-
Rachel Wong authored
Bug: 1014839 Change-Id: I9104d53beebc430a285b570f640d671ffad91c8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029387Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#737197}
-
Chromium WPT Sync authored
Using wpt-import in Chromium be2478a3. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bokan@chromium.org: external/wpt/visual-viewport dcheng@chromium.org, palmer@chromium.org: external/wpt/domparsing rego@igalia.com: external/wpt/css/css-grid NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I48ad880e51389735ae52d54ced8d8b05c7c171e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2031970Reviewed-by:
-
