GitLab

BUG=133828

Review URL: https://codereview.chromium.org/491163002

Cr-Commit-Position: refs/heads/master@{#296980}

BUG=418019
TEST=linux bots, content_browsertests
TBR=viettrungluu@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/612483002

Cr-Commit-Position: refs/heads/master@{#296979}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/e48d3d4..6254fdf

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/607133002

Cr-Commit-Position: refs/heads/master@{#296978}

AwContents are deleted asynchronously, so to stop receiving
callbacks we unregister delegates / observers / listeners
from AwContents.destroy() and ContentViewCore.destroy().
Receiving callbacks after AwContents.destroy() is called is
problematic because Java refs have already been set to null.

BUG=415666

Review URL: https://codereview.chromium.org/594103002

Cr-Commit-Position: refs/heads/master@{#296977}

BUG=None

Review URL: https://codereview.chromium.org/607953002

Cr-Commit-Position: refs/heads/master@{#296976}

Previously, setShape({'rects': []}) or
setShape({'rects': [{left:0, width:0, top:0, height:1}]})
would make the window completely transparent, but still capture input.

This was because ShapedAppWindowTargeter::GetHitTestMask returned
false if the shape was empty. It now returns false only if the shape
is NULL.

BUG=417014

Review URL: https://codereview.chromium.org/602013002

Cr-Commit-Position: refs/heads/master@{#296975}

Currently the DOM Distiller does not work in incognito, since the source
for the chrome-distiller:// scheme has not been registered.

This CL moves the functionality for registering the scheme to a generic place
and it is now used by both ProfileImpl and by OffTheRecordProfile during
profile creation.

It also makes both the normal profile and the incognito profile use the same
instance of the DomDistillerService.

BUG=380036

Review URL: https://codereview.chromium.org/608653002

Cr-Commit-Position: refs/heads/master@{#296974}

BUG=413744

Review URL: https://codereview.chromium.org/611543002

Cr-Commit-Position: refs/heads/master@{#296973}

After we're sure we have fixed 317138, let's drop these CHECKs. Also,
celebrate!

R=ttuttle@chromium.org
BUG=317138

Review URL: https://codereview.chromium.org/509993002

Cr-Commit-Position: refs/heads/master@{#296972}

R=lcwu@chromium.org,byungchul@chromium.org
BUG=None

Review URL: https://codereview.chromium.org/603243003

Cr-Commit-Position: refs/heads/master@{#296971}

Previously a focus ring was only drawn around web elements; this uses a
new API to draw the focus ring around native views, too, by adding a new
field to the existing private accessibility API with the bounding rect of
the focused view.

BUG=314889

Review URL: https://codereview.chromium.org/600063002

Cr-Commit-Position: refs/heads/master@{#296970}

We were passing a 'parent_window' parameter to the network_connect::ConnectToNetwork() in an effort to open network configuration dialogs from the desktop they were triggered from. This was never a good idea since gfx::NativeWindow is actually a pointer which may become invalid before the callback is triggered.

In practice this is unnecessary since we decided that all network configuration applies to the primary user, so we should always use the currently active desktop to host the dialog (which is what GetNativeWindow() does in ash_system_tray_delegate.cc).

BUG=413925

Review URL: https://codereview.chromium.org/607613002

Cr-Commit-Position: refs/heads/master@{#296969}

sync_initialized() does not account for backup/rollback modes. For now we
just manually check the backend mode. In the future the PSS will expose
a better method for denoting when its safe to reconfigure.

BUG=417400

Review URL: https://codereview.chromium.org/605483002

Cr-Commit-Position: refs/heads/master@{#296968}

R=byungchul@chromium.org,lcwu@chromium.org
BUG=332744

Review URL: https://codereview.chromium.org/605033003

Cr-Commit-Position: refs/heads/master@{#296967}

BUG=367631
TEST=Verified with IME extensions on linux_chromeos.
NOTRY=true

Review URL: https://codereview.chromium.org/606553002

Cr-Commit-Position: refs/heads/master@{#296966}

Counter will be accumulated for each OnIceCandidate callback and report once the IceGathering is completed.

BUG=411086

Review URL: https://codereview.chromium.org/600163004

Cr-Commit-Position: refs/heads/master@{#296965}

Due to the following bug:
https://code.google.com/p/android/issues/detail?id=76644, it is not
possible in art to create an empty buffer for address NULL. This solve
the issue by creating an empty buffer on a random address. This is not
an issue as the memory will never be accessed.

BUG=406848
R=ppi@chromium.org,yfriedman@chromium.org

Review URL: https://codereview.chromium.org/601163002

Cr-Commit-Position: refs/heads/master@{#296964}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/2a007a0..e48d3d4

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/608463005

Cr-Commit-Position: refs/heads/master@{#296963}

BUG=

Review URL: https://codereview.chromium.org/607693002

Cr-Commit-Position: refs/heads/master@{#296962}

A recent security update changed the file, so the patch had to be rebased.

BUG=313751
TBR=glider@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/610643002

Cr-Commit-Position: refs/heads/master@{#296961}

BUG=408809

Review URL: https://codereview.chromium.org/541903002

Cr-Commit-Position: refs/heads/master@{#296960}

Screenshots: https://drive.google.com/open?id=0B1B1Up4p2NRMc28yXzJuRFRZbWs&authuser=1

TL; DR:
- never show a drop down arrow in the button. This means we can do s/MenuButton/LabelButton
- if there is one local, non-signed in profile, show a tiny button with a generic avatar
- in all other cases, show the avatar button with the profile name
- updated the button insets so that the icons are centered correctly in the button
- the new tab button should completely slide under the avatar button
- because of this, I made public the new tab button width (and height, to be consistent)

BUG=410946

Review URL: https://codereview.chromium.org/598163002

Cr-Commit-Position: refs/heads/master@{#296959}

This is a reland of https://codereview.chromium.org/607513003 with the
fix for the failing test.

BUG=417707
TBR=sdefresne@chromium.org

Review URL: https://codereview.chromium.org/612443002

Cr-Commit-Position: refs/heads/master@{#296958}

Fix the number of buckets in Tabs.ScrubDistance. Currently the value
19 falls in the bucket with value 18 which is confusing. Results can be
checked on uma.googleplex.com.

BUG=

Review URL: https://codereview.chromium.org/551893002

Cr-Commit-Position: refs/heads/master@{#296957}

BUG=376450

Review URL: https://codereview.chromium.org/599123002

Cr-Commit-Position: refs/heads/master@{#296956}

BUG=394284

Review URL: https://codereview.chromium.org/598003002

Cr-Commit-Position: refs/heads/master@{#296955}

Update the AvatarMenu (and the ProfileChooserView, which listens for changes to the AvatarMenu) when a supervised user's custodian info changes.

BUG=372381

Review URL: https://codereview.chromium.org/597783003

Cr-Commit-Position: refs/heads/master@{#296954}

BUG=418029

Review URL: https://codereview.chromium.org/605073003

Cr-Commit-Position: refs/heads/master@{#296953}

BUG=417408

Review URL: https://codereview.chromium.org/601293003

Cr-Commit-Position: refs/heads/master@{#296952}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/0f037ba..2a007a0

TBR=ager@chromium.org,zmo@chromium.org

Review URL: https://codereview.chromium.org/602043005

Cr-Commit-Position: refs/heads/master@{#296951}

Fix number of buckets in AsyncDNS.ServerCount and SyncDNS.ServerFailureIndex UMA
histograms. Currently the value 9 falls in the bucket with value 8 which is
confusing. Results can be checked on uma.googleplex.com.

BUG=

Review URL: https://codereview.chromium.org/551873002

Cr-Commit-Position: refs/heads/master@{#296950}

If the cause of a rename failure is suspected of being transient
(sharing violations, suspected race conditions in the file system), then
retry the rename with an exponential backoff.

BUG=368455

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278483
Reverted (Win XP issues): https://chromium.googlesource.com/chromium/src.git/+/d31e3689a5f5a0ae6eba1f15ea299bf84fd6d381

Review URL: https://codereview.chromium.org/319603003

Cr-Commit-Position: refs/heads/master@{#296949}

BUG=416041

Review URL: https://codereview.chromium.org/609663002

Cr-Commit-Position: refs/heads/master@{#296948}

Add a "domain" field that returns the hostname of the original request.
This lets sites with wildcard contexts tell which subdomain triggered the
beacons they receive.

BUG=

Review URL: https://codereview.chromium.org/605473002

Cr-Commit-Position: refs/heads/master@{#296947}

Revert of mojo: Add router for python bindings. (patchset #3 id:40001 of https://chromiumcodereview.appspot.com/607513003/)

Reason for revert:
Test are failing.

Original issue's description:
> mojo: Add router for python bindings.
>
> BUG=417707
> R=sdefresne@chromium.org,cmasone@chromium.org
>
> Committed: https://crrev.com/5d07d365694ba3e516a861a1018d31e055bfdf39
> Cr-Commit-Position: refs/heads/master@{#296941}

TBR=cmasone@chromium.org,sdefresne@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=417707

Review URL: https://codereview.chromium.org/609783004

Cr-Commit-Position: refs/heads/master@{#296946}

Adding tracking to verify the theory that jankiness of ExtensionMessageFilter::OnExtensionAddListener is because of rebuilding matchers.

BUG=417106

Review URL: https://codereview.chromium.org/597413004

Cr-Commit-Position: refs/heads/master@{#296945}

Revert of [DevTools] Implement DevToolsManager::Observer which notifies about target updates. (patchset #5 id:80001 of https://codereview.chromium.org/577923002/)

Reason for revert:
Breaks asan bot.
http://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%282%29/builds/7924

Original issue's description:
> [DevTools] Implement DevToolsManager::Observer which notifies about target updates.
>
> BUG=398049
>
> Committed: https://crrev.com/509c17cf55a12b49b017245f6d0cff558f312637
> Cr-Commit-Position: refs/heads/master@{#296921}

TBR=pfeldman@chromium.org,vkuzkokov@chromium.org,jam@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=398049

Review URL: https://codereview.chromium.org/591313006

Cr-Commit-Position: refs/heads/master@{#296944}

With current implementation forms lacking user-name fields are treated as invalid password forms and browser does not save passwords in such cases.

With this patch password manager saves passwords on forms without user-name fields as well.

BUG=406343
TBR=gcasto@chromium.org,vabr@chromium.org

Review URL: https://codereview.chromium.org/548953002

Cr-Commit-Position: refs/heads/master@{#296943}

When the data reduction proxy responds with a bypass message,
chromium constructs a redirect response and feeds that through
the network stack. This results in the request being retried
directly to the origin. If the original request had an
Origin header, then the manufactured redirect should have the
appropriate CORS headers.

BUG=415644

Review URL: https://codereview.chromium.org/603323002

Cr-Commit-Position: refs/heads/master@{#296942}

BUG=417707
R=sdefresne@chromium.org,cmasone@chromium.org

Review URL: https://codereview.chromium.org/607513003

Cr-Commit-Position: refs/heads/master@{#296941}