- 14 Sep, 2020 9 commits
-
-
Patti authored
There are a few last remaining instances of strings containing the words 'whitelist' and 'blacklist' in the chrome/app/generated_resources.grd string file. Replace them with more respectful alternatives. Bug: 1114004 Change-Id: Ie14a2cf080fea1c61a91feecb3686a82c4e0188a No-Presubmit: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400648 Commit-Queue: Patti <patricialor@chromium.org> Auto-Submit: Patti <patricialor@chromium.org> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#806520}
-
Joel Hockey authored
In crrev.com/c/1837323 |controller_| is set to null when an animation starts. The old DCHECK was never updated. This CL updates it to expect |controller_| to be null if the spinner is being removed from UpdateApps() because the animation is Finished(). https://source.chromium.org/chromium/chromium/src/+/master:chrome/browser/ui/ash/launcher/shelf_spinner_controller.cc;l=319-323;drc=c2c84a5ac7711dedcc0b7ff9e79bf7f2da019537 Bug: 1077722 Change-Id: Ie8d6b332c9cd869a7cc88dc58827e83e29e9e675 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408595 Auto-Submit: Joel Hockey <joelhockey@chromium.org> Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806519}
-
Maggie Cai authored
This CL uses the international string label from file manager for drive share action. BUG=1097623 Change-Id: I3f5aa1e3873b2677630fc49e2c341f2a3a63194f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404517Reviewed-by:
Melissa Zhang <melzhang@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#806518}
-
Kent Tamura authored
After LayoutTheme::AdjustStyle() call, we can assume a LayoutObject with a HasEffectiveAppearnace() style always has a non-null Element for GetNode(). This CL simplifies blink::LayoutTheme and blink::ThemePainter by the assumption. * Change the |const Element*| arguments of |LayoutTheme:: AdjustSliderContainerStyle()| to |const Element&|. * Remove unused |const Element*| arguments of |LayoutTheme:: AdjustMenuList*Style()|. * Change the argument order of LayoutTheme::AdjustStyle() to follow Google C++ style guide. * Public methods of ThemePainter still take |const Node*| arguments, but the methods set up |const Element&| variables at the beginning. * Protected methods of ThemePainter take |const Element&| arguments. * Add |const Element&| arguments to some of ThemePainter methods because they refer to LayoutObject::GetNode(). * Remove IsDisabled(), IsPressed(), and IsHovered() in theme_painter_default.cc. They are not helpful any longer. This CL has no behavior changes. Change-Id: I8a8fee402720ddeacfe77ebf920146b72bf6767e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404510 Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#806517}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1600019602-a9721894365ebf12d66621ff2aeda20a62d94ef9.profdata to chrome-linux-master-1600041484-5728f1bbdb3072c9a2ada1afd02e69514bec4d41.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com Change-Id: If6db8efe79d2c193f662349673168f67f0e8c269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408960Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806516}
-
Mason Freed authored
Prior to this CL, if there were multiple form associated custom elements with the same "name" attribute, the document.forms.elements.namedItem() API would not contain the custom elements. Fixed: 1124818 Change-Id: I5f97fbddc6ef9d03432edde7a643c3e01df70e56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2398953 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Auto-Submit: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#806515}
-
Nidhi Jaju authored
The service worker codebase currently uses a lot of GURLs for origins. However, url::Origin should be used for origin instead of GURL where possible due to security decisions. This CL changes ServiceWorkerContextWrapper::CountExternalRequests to use url::Origin instead of GURL. Some relevant callsites have also been modified accordingly. Bug: 1095896 Change-Id: I2d9463fc57409baab94fef7197c6229fcf7d0c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2401343 Commit-Queue: Nidhi Jaju <nidhijaju127@gmail.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Reviewed-by:
Istiaque Ahmed <lazyboy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806514}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 2e384a5d. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=smcgruer@google.com No-Export: true Change-Id: Ideee0fe9e31c1168afbe7cd664872eb4a44d6b9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408402Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806513}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I184ab3ce21629deb22b7fa6144ffd9becb0f3205 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408947Reviewed-by:
-
- 13 Sep, 2020 31 commits
-
-
My Nguyen authored
Copied from languages_page/languages_page.js Current view: http://screen/79LZtEBFUnkevpP There is no mock for this yet, but I think this should just carry over. Strings will most likely be updated. Bug: 1113439 Change-Id: I6d0ed2fc1949ad55ebd265be0b71a34a0300cd0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2400546Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: My Nguyen <myy@chromium.org> Cr-Commit-Position: refs/heads/master@{#806511}
-
My Nguyen authored
Mock: http://go/cros-lang-settings-ux-slide#slide=28 Current view: http://screen/5u7jNdndrP3bHcz Drive-by: - LanguagesSection::IsEmojiSuggestionAllowed to be consistent with header. - Add correct paddings for download error in input_page.html (accidentally removed earlier, added a comment to remind myself) Bug: 1113439 Change-Id: Ib63f44905db3b93f73c0be814b0fca37ee21f0c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2394878Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
-
Jinsuk Kim authored
This CL caches the activity tab that PIP mode got turned on with, to use it when leaving PIP mode. In this way, the reported NPE can be avoided when the activity tab is not available at the time callback needs to be invoked. Bug: 1119340 Change-Id: I5d422b4d41961a09cc8c6c1f18ca89edf50d8eed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371768Reviewed-by:
Peter Conn <peconn@chromium.org> Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Cr-Commit-Position: refs/heads/master@{#806509}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599973865-097838253c6e4fc922b30e85389ab39271465d8b.profdata to chrome-win32-master-1600019602-32c2a84e23bf8e92bb08ca2c2b541f0b03d0321b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Id710b62e31798774a2afa7458b0de9c1e9afa575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408778Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599997444-587d45f2a7d0fcdd182d1f3f19319d856a10c377.profdata to chrome-win64-master-1600019602-ed2e256fac899ca1dee4e6eb48fd53d99ebb14eb.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia4f16cea861a01b82972dedc8e2cdf8870e34fac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408779Reviewed-by:
-
Eric Willigers authored
When serializing nested selector lists for :is(), :where() and so on, we now include a space after the comma. We add various WPTs for the serialization of CSS Selectors include :is() and :where() The tests pass on Safari, Firefox and now Blink. https://drafts.csswg.org/selectors-3/ https://drafts.csswg.org/selectors/ Bug: 1127347 Change-Id: I6d990e04c50a3ea97bdab8d0225c9bf1d09d2cc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407735Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#806506}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599997444-33d71c9e7fae496e67ac1f96f0e7acae99aa1e54.profdata to chrome-mac-master-1600019602-70deeea6efa76ec6386c7bc7963d060c951bcf80.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ieb2689d12fe0d6ef312613b5e551ef499d9e48a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408750Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599997444-10f8f6dbcca0a3a3845ff8f083e0c14cd4f81df9.profdata to chrome-linux-master-1600019602-a9721894365ebf12d66621ff2aeda20a62d94ef9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ib65dd44add9de929866af2d6580226602aa95e88 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408751Reviewed-by:
-
Nazerke authored
This CL removes unused headers in tabmodel to clean it up. Bug: 1045575 Change-Id: Ie0184805885f2797c1ae3122b9d8fc8fc4db5bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2379678 Commit-Queue: Nazerke Kalidolda <nazerke@google.com> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#806503}
-
Vasiliy Telezhnikov authored
After https://crrev.com/2390861 we started to use source texture for all operations on original context. SharedImageBacking are ref-counted by their representation, but the source_texture was deleted when client deletes shared image (i.e when FactoryRepresentation is deleted). This is problematic as shared image could be deleted before raster finished. This CL adds ref-counted wrapper to source texture to keep it alive until last representation on original context and thread is alive. Bug: 1127320 Change-Id: I395f6177b752acc163f05f2d365073c67a25991a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2407182 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#806502}
-
Roman Arora authored
Allow for the Tab Search button to be anchored to a fixed position, and guard this capability via a feature flag. Related CL: https://chromium-review.googlesource.com/c/chromium/src/+/2405532 Bug: 1099917 Change-Id: Ie8ef3aad559439d0caf0f60e0e6bb07b97509815 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2377887Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Roman Arora <romanarora@chromium.org> Cr-Commit-Position: refs/heads/master@{#806501}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202009130800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/MEjLKGkVlDNdHj0W1rgJY5UBkUoBb16icAog6f-mvaEC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: media-app@grotations.appspotmail.com Change-Id: I72046ee0324d2f72a920907774b3bba7d742aba1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408643Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806500}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I5d7bb6394044a40e1041a4e2c42f4a323d6b4022 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408647Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599939715-39a100f6333ddea3b9df8b436790d57b7eeb20af.profdata to chrome-win64-master-1599997444-587d45f2a7d0fcdd182d1f3f19319d856a10c377.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I8491a867727b46a86dc230052678e65f634589e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408589Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1599939715-5c3c6b7a7288128190fde0a94ff4c1f79925306b.profdata to chrome-mac-master-1599997444-33d71c9e7fae496e67ac1f96f0e7acae99aa1e54.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: I01b9d1e4751c459064f8af7fe10d37fbed4a7bc0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408580Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/18ef10a679b8..87a2e015f06e 2020-09-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I478b915e61e768b328005a9ce5c3722d6a2968be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408574Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599973865-886522d8a973df66b1ce97a6e2b8a71588d59e84.profdata to chrome-linux-master-1599997444-10f8f6dbcca0a3a3845ff8f083e0c14cd4f81df9.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com,sebmarchand+pgo_roller@google.com Change-Id: Ia7e51096435bc0fa58e1cb6b324eb522b2941cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408581Reviewed-by:
-
Zakhar Voit authored
This CL makes sure that LaCros windows receive big enough wl_output.scale from exo when display scale is fractional by rounding it up to the closest integer. This is similar to how other compositors (Mutter, Sway) deal with fractional scaling: clients are only aware of integer scaling and the actual contents of windows are scaled down on the compositor side (it's already done in Aura in our case). Bug: 1093021 Change-Id: Ia47dd60dc0cb60396028c1ce108e095ecc84884f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404930Reviewed-by:
Mitsuru Oshima (Slow: gardener) <oshima@chromium.org> Commit-Queue: Zakhar Voit <zvoit@igalia.com> Cr-Commit-Position: refs/heads/master@{#806494}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/186866c46179..b711737c1384 2020-09-13 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update SKP version If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC scroggo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: scroggo@google.com Change-Id: I78c01d1322cd6c7766ac5630e1f095b603867b8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408512Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599939715-1cdee311f4fa1568014da1d1698a21d616ea2c1a.profdata to chrome-win32-master-1599973865-097838253c6e4fc922b30e85389ab39271465d8b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: liaoyuke@google.com,sebmarchand+pgo_roller@google.com,jeffyoon@google.com Change-Id: If99b71bafd7dab99050311965759561aa79dd97c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408477Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I4ae3cfc024974dbf941ec33b56b1ef2f39d06b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408482Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/b702d7936a51..18ef10a679b8 2020-09-13 alexrudenko@chromium.org Check isConstructed instead of isMutable to detect constructed stylesheets If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1125357 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I45a907b2d4e2c603e56ab9ad051040d11158bec3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408475Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/9d6c31c58c9e..b702d7936a51 2020-09-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ia2b74506767f78a7cc033105b0411d583590f279 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408463Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1599932190-c2f10656e04fb41bc155458d35d790533cbbe8a2.profdata to chrome-win32-master-1599939715-1cdee311f4fa1568014da1d1698a21d616ea2c1a.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com,sebmarchand+pgo_roller@google.com Change-Id: I8d21be345dfef87e1c4d348324ce197ad1cde310 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408257Reviewed-by:
-
Yuki Shiino authored
ES 9.1.9.2. OrdinarySetWithOwnDescriptor[1] traverses the prototype chain and finds a property. In case of [LegacyOverrideBuiltIns], V8 doesn't perform the property look-up on the prototype chain, so Blink needs to perform it on its own. This patch checks existence of a property on the prototype chain in case of [LegacyOverrideBuiltIns]. The change is minimized so that it's easy to port the change back to M86. [1] https://tc39.es/ecma262/#sec-ordinarysetwithowndescriptor Bug: 839389, 1126888 Change-Id: I9480661c0de9280b23bc4d598563fd0360242895 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2404988Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#806487}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1599939715-9ce3c73c40524e6ef052deeee02f05ede45d9f44.profdata to chrome-linux-master-1599973865-886522d8a973df66b1ce97a6e2b8a71588d59e84.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com,chrome-brapp-engprod@google.com Change-Id: Ia3a46bec0a729e0b7b1701c1faac5209098e9b72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408467Reviewed-by:
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: I884be51916a841b2505b5103927724b190e41f49 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408393Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#806485}
-
Shakti Sahu authored
This CL removes the content indexing entry point card shown on NTP. Bug: 1108602 Change-Id: I58d6d7148dc7062e48223ca51581cc9cab87cabd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391652 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#806484}
-
Shakti Sahu authored
This CL cleans up the two flags associated with content indexing. The one associated with download home is fully launched, while the changes associated with the NTP will be removed in a followup CL. Change-Id: I0b27c1c0cdf43084196953dcacc9cb88e8071f15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2391733 Commit-Queue: Shakti Sahu <shaktisahu@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang/+log/6a6e311d81dd..759ae5aec02b 2020-09-13 johnkslang@users.noreply.github.com Merge pull request #2394 from ShabbyX/subpassLoad 2020-09-13 johnkslang@users.noreply.github.com Merge pull request #2395 from nihui/patch-4 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/glslang-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Tbr: radial-bots+chrome-roll@google.com,ianelliott@google.com Change-Id: Ib90104f934eb4f52517914fb816478ceedaa87dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408265Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1599932190-cbe0d6728a2d936751f6d8381d667f6a8b82b4d0.profdata to chrome-win64-master-1599939715-39a100f6333ddea3b9df8b436790d57b7eeb20af.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: sebmarchand+pgo_roller@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: I749b9244b2230c44ab18921c7a01fb702542055f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2408256Reviewed-by:
-
