1. 14 Mar, 2011 35 commits
    • pfeldman@chromium.org's avatar
      2011-03-14 Pavel Feldman <pfeldman@chromium.org> · 0645da24
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
              https://bugs.webkit.org/show_bug.cgi?id=56268
      
              * inspector/elements/elements-panel-search.html:
              * inspector/elements/mutate-unknown-node.html:
      2011-03-14  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: make DOMAgent event target, remove dependency from ElementsPanel.
              https://bugs.webkit.org/show_bug.cgi?id=56268
      
              * inspector/Inspector.idl:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::reset):
              (WebCore::InspectorDOMAgent::performSearch):
              (WebCore::InspectorDOMAgent::cancelSearch):
              (WebCore::InspectorDOMAgent::onMatchJobsTimer):
              (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
              * inspector/InspectorDOMAgent.h:
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMAgent.prototype.requestDocument.mycallback):
              (WebInspector.DOMAgent.prototype.requestDocument):
              (WebInspector.DOMAgent.prototype._attributesUpdated):
              (WebInspector.DOMAgent.prototype._characterDataModified):
              (WebInspector.DOMAgent.prototype._documentUpdated):
              (WebInspector.DOMAgent.prototype._setDocument):
              (WebInspector.DOMAgent.prototype._childNodeCountUpdated):
              (WebInspector.DOMAgent.prototype._childNodeInserted):
              (WebInspector.DOMAgent.prototype._childNodeRemoved):
              (WebInspector.DOMAgent.prototype._removeBreakpoints):
              (WebInspector.DOMAgent.prototype.performSearch):
              (WebInspector.DOMAgent.prototype.cancelSearch):
              (WebInspector.DOMDispatcher.prototype.searchResults):
              * inspector/front-end/ElementsPanel.js:
              (WebInspector.ElementsPanel):
              (WebInspector.ElementsPanel.prototype._reset):
              (WebInspector.ElementsPanel.prototype._documentUpdated):
              (WebInspector.ElementsPanel.prototype.searchCanceled):
              (WebInspector.ElementsPanel.prototype.performSearch):
              (WebInspector.ElementsPanel.prototype._addNodesToSearchResult):
              (WebInspector.ElementsPanel.prototype._attributesUpdated):
              (WebInspector.ElementsPanel.prototype._characterDataModified):
              (WebInspector.ElementsPanel.prototype._nodeInserted):
              (WebInspector.ElementsPanel.prototype._nodeRemoved):
              (WebInspector.ElementsPanel.prototype._childNodeCountUpdated):
              (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81010 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0645da24
    • pfeldman@chromium.org's avatar
      2011-03-14 Pavel Feldman <pfeldman@chromium.org> · 8d7de5cd
      pfeldman@chromium.org authored
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add tests for edit dom operations.
              https://bugs.webkit.org/show_bug.cgi?id=56248
      
              * inspector/elements/edit-dom-actions-expected.txt: Added.
              * inspector/elements/edit-dom-actions.html: Added.
      2011-03-14  Pavel Feldman  <pfeldman@chromium.org>
      
              Reviewed by Yury Semikhatsky.
      
              Web Inspector: add tests for edit dom operations.
              https://bugs.webkit.org/show_bug.cgi?id=56248
      
              Test: inspector/elements/edit-dom-actions.html
      
              * inspector/Inspector.idl:
              * inspector/InspectorDOMAgent.cpp:
              (WebCore::InspectorDOMAgent::assertNode):
              (WebCore::InspectorDOMAgent::assertElement):
              (WebCore::InspectorDOMAgent::assertHTMLElement):
              (WebCore::InspectorDOMAgent::nodeToSelectOn):
              (WebCore::InspectorDOMAgent::querySelector):
              (WebCore::InspectorDOMAgent::querySelectorAll):
              (WebCore::InspectorDOMAgent::setAttribute):
              (WebCore::InspectorDOMAgent::removeAttribute):
              (WebCore::InspectorDOMAgent::getOuterHTML):
              (WebCore::InspectorDOMAgent::setOuterHTML):
              * inspector/InspectorDOMAgent.h:
              * inspector/front-end/DOMAgent.js:
              (WebInspector.DOMNode.prototype.setAttribute):
              (WebInspector.DOMNode.prototype.removeAttribute):
              * inspector/front-end/inspector.js:
              (WebInspector.startEditing.defaultFinishHandler):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81009 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8d7de5cd
    • gyuyoung.kim@samsung.com's avatar
      2011-03-14 Gyuyoung Kim <gyuyoung.kim@samsung.com> · c9b547bc
      gyuyoung.kim@samsung.com authored
              Unreviewed. Modify my email address in committers.py.
      
              * Scripts/webkitpy/common/config/committers.py:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81008 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c9b547bc
    • levin@chromium.org's avatar
      Fix typo TEXT vs TEST. · f5153df1
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81007 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      f5153df1
    • levin@chromium.org's avatar
      Rebaseline some test due to r80996. · b4c9b4d5
      levin@chromium.org authored
      Rearrange some expectations (from IMAGE to IMAGE_TEXT) due to r80996
      and add a few bugs which track the other failures.
      
      * platform/chromium-linux/fast/text/capitalize-boundaries-expected.txt:
      * platform/chromium-linux/fast/text/soft-hyphen-4-expected.checksum: Added.
      * platform/chromium-linux/fast/text/soft-hyphen-4-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81006 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b4c9b4d5
    • beidson@apple.com's avatar
      <rdar://problem/8762095> and https://bugs.webkit.org/show_bug.cgi?id=55172 · ef20809b
      beidson@apple.com authored
      Need WK2 API to view/manage origins with LocalStorage
      
      Reviewed by Dan Bernstein.
      
      ../WebCore: 
      
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::initializeTracker): Make sure the TextEncoding map is initialized on the main thread
        before the StorageTracker thread can do it on the background thread.
      
      ../WebKit2: 
      
      Hookup the existing API stubs to the WebCore implementations:
      * WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp:
      (WebKit::WebKeyValueStorageManager::getKeyValueStorageOrigins):
      (WebKit::WebKeyValueStorageManager::deleteEntriesForOrigin):
      (WebKit::WebKeyValueStorageManager::deleteAllEntries):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81005 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ef20809b
    • commit-queue@webkit.org's avatar
      2011-03-14 Ryuan Choi <ryuan.choi@samsung.com> · c205dd9e
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [EFL] Move cache_directory api
              https://bugs.webkit.org/show_bug.cgi?id=52139
      
              Move cache directory related apis from ewk_view to ewk_settings because
              those are not related to ewk_view.
      
              * ewk/ewk_main.cpp:
              (_ewk_init_body):
              * ewk/ewk_settings.cpp:
              (ewk_settings_cache_directory_path_set):
              (ewk_settings_cache_directory_path_get):
              * ewk/ewk_settings.h:
              * ewk/ewk_view.cpp:
              (_ewk_view_priv_new):
              (_ewk_view_priv_del):
              * ewk/ewk_view.h:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81004 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c205dd9e
    • beidson@apple.com's avatar
      Fixed lock-taking order to prevent deadlock, added lock for m_client, · 97a1b2ad
      beidson@apple.com authored
      removed premature return in syncImportOriginIdentifiers when tracker
      db does not exist because that prevented syncFileSystemAndTrackerDatabase()
      from running until next LocalStorage db creation, cleaned up
      StorageTracker::scheduleTask() code for readability.
              
      Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
      Reviewed by Brady Eidson and David Levin, landed by Brady Eidson.
      
      https://bugs.webkit.org/show_bug.cgi?id=56285
              
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::trackerDatabasePath):
      (WebCore::StorageTracker::syncImportOriginIdentifiers): If tracker db isn't
      optionally opened (as in the case when it doesn't exist on disk), don't
      exit early and call syncFileSystemAndTrackerDatabase(), which will create
      a tracker db if localstorage db files are found on disk by calling setOriginDetails.
      (WebCore::StorageTracker::syncFileSystemAndTrackerDatabase):
      (WebCore::StorageTracker::setOriginDetails):
      (WebCore::StorageTracker::scheduleTask): readability changes.
      (WebCore::StorageTracker::syncSetOriginDetails):
      (WebCore::StorageTracker::syncDeleteAllOrigins):
      (WebCore::StorageTracker::syncDeleteOrigin):
      (WebCore::StorageTracker::cancelDeletingOrigin): order lock-taking consistently to avoid deadlock.
      (WebCore::StorageTracker::setClient):
      * storage/StorageTracker.h:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81003 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      97a1b2ad
    • beidson@apple.com's avatar
      Reviewed and landed by Brady Eidson. · 6be996ee
      beidson@apple.com authored
      Patch by Anton D'Auria <adauria@apple.com> on 2011-03-13
      Invalid assertion in StorageTracker - PageGroup::numberOfPageGroups() == 1
      https://bugs.webkit.org/show_bug.cgi?id=56240
      
      This assertion is invalid until LocalStorage is either global or is isolated by PageGroup.
      
      * storage/StorageTracker.cpp:
      (WebCore::StorageTracker::origins):
      (WebCore::StorageTracker::deleteAllOrigins):
      (WebCore::StorageTracker::deleteOrigin):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81002 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6be996ee
    • psolanki@apple.com's avatar
      Make adjustMIMETypeIfNecessary use CFNetwork directly · e0e67015
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=55912
      
      Reviewed by Dan Bernstein.
      
      Follow up fix for Layout Test failure. Fix typo - it should be text/plain, not test/plain.
      
      * platform/network/mac/WebCoreURLResponse.mm:
      (WebCore::adjustMIMETypeIfNecessary):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81001 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e0e67015
    • beidson@apple.com's avatar
      <rdar://problem/9127270> and https://bugs.webkit.org/show_bug.cgi?id=56282 · 5b8b52f3
      beidson@apple.com authored
      Reviewed by Sam Weinig.
      
      Pass the path along with creation parameters:
      * Shared/WebProcessCreationParameters.cpp:
      (WebKit::WebProcessCreationParameters::encode):
      (WebKit::WebProcessCreationParameters::decode):
      * Shared/WebProcessCreationParameters.h:
      
      Add SPI to set the path:
      * UIProcess/API/C/WKContext.cpp:
      (WKContextSetLocalStorageDirectory):
      * UIProcess/API/C/WKContextPrivate.h:
      
      Pass the path along in the process creation parameters:
      * UIProcess/WebContext.cpp:
      (WebKit::WebContext::ensureWebProcess):
      (WebKit::WebContext::localStorageDirectory):
      * UIProcess/WebContext.h:
      (WebKit::WebContext::setLocalStorageDirectory):
      
      * UIProcess/gtk/WebContextGtk.cpp:
      (WebKit::WebContext::platformDefaultLocalStorageDirectory):
      * UIProcess/mac/WebContextMac.mm:
      (WebKit::WebContext::platformDefaultLocalStorageDirectory):
      * UIProcess/qt/WebContextQt.cpp:
      (WebKit::WebContext::platformDefaultLocalStorageDirectory):
      * UIProcess/win/WebContextWin.cpp:
      (WebKit::WebContext::platformDefaultLocalStorageDirectory):
      
      Include the path with settings updates, because WebCore needs it set on the Settings object:
      * WebProcess/WebPage/WebPage.cpp:
      (WebKit::WebPage::updatePreferences):
      
      * WebProcess/WebProcess.cpp:
      (WebKit::WebProcess::initializeWebProcess):
      * WebProcess/WebProcess.h:
      (WebKit::WebProcess::localStorageDirectory):
      
      Sandboxing stuff:
      * WebProcess/com.apple.WebProcess.sb:
      * WebProcess/mac/WebProcessMac.mm:
      (WebKit::initializeSandbox):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@81000 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5b8b52f3
    • jer.noble@apple.com's avatar
      2011-03-12 Jer Noble <jer.noble@apple.com> · cf63119d
      jer.noble@apple.com authored
              Reviewed by Mark Rowe.
      
              WebKit2: Build WKFullScreenWindowController cleanly in 32-bit.
              https://bugs.webkit.org/show_bug.cgi?id=56260
      
              Include <Carbon/Carbon.h> instead of <HIToolbox/MacApplication.h>.
      
              * UIProcess/mac/WKFullScreenWindowController.mm:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80999 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cf63119d
    • levin@chromium.org's avatar
      Improve my hasitly added build fix and added a bug https://bugs.webkit.org/show_bug.cgi?id=56288 · 2b2bd66f
      levin@chromium.org authored
      above addressing this FIXME.
      
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80998 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2b2bd66f
    • levin@chromium.org's avatar
      Clean up overlapping test_expectation which I mistakenly added in my haste. · b50ecf7f
      levin@chromium.org authored
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80997 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      b50ecf7f
    • mitz@apple.com's avatar
      Include hyphenation information in text representation of render tree · 341752a2
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56287
      
      Reviewed by Sam Weinig.
      
      Source/WebCore: 
      
      (WebCore::writeTextRun): If the text box is hyphenated, output the hyphenation
      string.
      
      LayoutTests: 
      
      * fast/text/soft-hyphen-4-expected.txt:
      * platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
      * platform/mac-snowleopard/fast/text/hyphenate-locale-expected.txt:
      * platform/mac/fast/text/basic/014-expected.txt:
      * platform/mac/fast/text/capitalize-boundaries-expected.txt:
      * platform/mac/fast/text/hyphenate-character-expected.txt:
      * platform/mac/fast/text/hyphenate-first-word-expected.txt:
      * platform/mac/fast/text/hyphens-expected.txt:
      * platform/mac/fast/text/midword-break-after-breakable-char-expected.txt:
      * platform/mac/fast/text/soft-hyphen-2-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80996 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      341752a2
    • ggaren@apple.com's avatar
      A few Heap-related renames (sans file moves, which should come next) · 2318c7e7
      ggaren@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56283
              
      Reviewed by Sam Weinig.
      
      ConservativeSet => ConservativeRoots. "Set" was misleading, since items
      are not uniqued. Also, "Roots" is more specific about what's in the set.
              
      MachineStackMarker => MachineThreads. "Threads" is more descriptive of
      the fact that this class maintains a set of all threads using JSC.
      "Stack" was misleading, since this class traverses stacks and registers.
      "Mark" was misleading, since this class doesn't mark anything anymore.
              
      registerThread => addCurrentThread. "Current" is more specific.
      unregisterThread => removeCurrentThread. "Current" is more specific.
              
      "currentThreadRegistrar" => threadSpecific. The only point of this data
      structure is to register a thread-specific destructor with a pointer to
      this.
              
      "mark...Conservatively" => "gather". "Mark" is not true, since these
      functions don't mark anything. "Conservatively" is redundant, since they
      take "ConservativeRoots" as an argument.
      
      * API/APIShims.h:
      (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
      * JavaScriptCore.exp:
      * runtime/ConservativeSet.cpp:
      (JSC::ConservativeRoots::grow):
      (JSC::ConservativeRoots::add):
      * runtime/ConservativeSet.h:
      (JSC::ConservativeRoots::ConservativeRoots):
      (JSC::ConservativeRoots::~ConservativeRoots):
      (JSC::ConservativeRoots::size):
      (JSC::ConservativeRoots::roots):
      * runtime/Heap.cpp:
      (JSC::Heap::Heap):
      (JSC::Heap::markRoots):
      * runtime/Heap.h:
      (JSC::Heap::machineThreads):
      * runtime/JSGlobalData.h:
      (JSC::JSGlobalData::makeUsableFromMultipleThreads):
      * runtime/MachineStackMarker.cpp:
      (JSC::MachineThreads::MachineThreads):
      (JSC::MachineThreads::~MachineThreads):
      (JSC::MachineThreads::makeUsableFromMultipleThreads):
      (JSC::MachineThreads::addCurrentThread):
      (JSC::MachineThreads::removeThread):
      (JSC::MachineThreads::removeCurrentThread):
      (JSC::MachineThreads::gatherFromCurrentThreadInternal):
      (JSC::MachineThreads::gatherFromCurrentThread):
      (JSC::MachineThreads::gatherFromOtherThread):
      (JSC::MachineThreads::gatherConservativeRoots):
      * runtime/MachineStackMarker.h:
      * runtime/MarkStack.h:
      (JSC::MarkStack::append):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80995 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2318c7e7
    • ddkilzer@apple.com's avatar
      BUILD FIX for armv7 after r80969 · 2b164fe1
      ddkilzer@apple.com authored
      Bug 56270 - The JIT 'friend's many classes in JSC; start unwinding this.
      <https://bugs.webkit.org/show_bug.cgi?id=56270>
      
      * assembler/MacroAssemblerARMv7.h:
      (JSC::MacroAssemblerARMv7::load32): Made void* address argument
      const.
      (JSC::MacroAssemblerARMv7::store32): Ditto.
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80994 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2b164fe1
    • levin@chromium.org's avatar
      Build fix adding remaining enum values to switch statement. · 5672bd50
      levin@chromium.org authored
      * css/CSSStyleSelector.cpp:
      (WebCore::CSSStyleSelector::applyProperty):
      
      Add more crashing tests to an existing bug about the same issue
      for Chromium Linux Debug. :(
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80993 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      5672bd50
    • levin@chromium.org's avatar
      Add some test failures that I need to investigate further. · 4e02976d
      levin@chromium.org authored
      Clean up a duplicate test expectation (default-timing-function.html ).
      Add a missing test expection for linux debug which was there for linux release (border-image-vertical-lr.html).
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80992 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      4e02976d
    • levin@chromium.org's avatar
      Add more crashing tests to an existing bug about the same issue · 8b5a703d
      levin@chromium.org authored
      for Chromium Linux Debug.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80991 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      8b5a703d
    • mrowe@apple.com's avatar
      Versioning. · ebd6d552
      mrowe@apple.com authored
      git-svn-id: svn://svn.chromium.org/blink/trunk@80990 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      ebd6d552
    • mitz@apple.com's avatar
      Updated expected results after r80982. · 6e79f0a5
      mitz@apple.com authored
      * platform/mac-snowleopard/fast/text/hyphenate-limit-before-after-expected.txt:
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80988 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6e79f0a5
    • ggaren@apple.com's avatar
      Not reviewed. · a5d3ff84
      ggaren@apple.com authored
      Try to fix the Mac build.
      
      * JavaScriptCore.xcodeproj/project.pbxproj: Make sure to forward
      ConervativeSet.h, since it's now visible when compiling other projects.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80987 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      a5d3ff84
    • weinig@apple.com's avatar
      Fix windows build. · 2842ff06
      weinig@apple.com authored
      * platform/network/cf/ResourceErrorCF.cpp:
      (WebCore::ResourceError::ResourceError):
      Add missing constructor.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80986 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      2842ff06
    • ggaren@apple.com's avatar
      2011-03-13 Geoffrey Garen <ggaren@apple.com> · 798d7ace
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Removed another case of DeprecatedPtr (ConservativeSet)
              https://bugs.webkit.org/show_bug.cgi?id=56281
              
              The ConservativeSet is an internal data structure used during marking,
              so direct pointers are fine.
      
              * runtime/ConservativeSet.cpp:
              (JSC::ConservativeSet::grow):
              * runtime/ConservativeSet.h: Added some accessors, for use by MarkStack::append.
              (JSC::ConservativeSet::~ConservativeSet): Fixed a typo where we calculated
              the size of the set based on sizeof(DeprecatedPtr<T>*) instead of
              sizeof(DeprecatedPtr<T>). I'm not sure if this had real-world implications or not.
              (JSC::ConservativeSet::size):
              (JSC::ConservativeSet::set): Use direct pointers, as stated above. 
      
              * runtime/Heap.cpp:
              (JSC::Heap::markRoots):
              * runtime/MarkStack.h:
              (JSC::MarkStack::append): Created a special case of append for
              ConservativeSet. I didn't want to add back a generic "append JSCell*"
              function, since other class might start using that wrong. (In the end,
              this function might go away, since the Heap will want to do something
              slightly more interesting with the conservative set, but this is OK for
              now.)
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80985 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      798d7ace
    • mitz@apple.com's avatar
      Source/WebCore: REGRESSION: Soft hyphen is not always rendered · dad83b38
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56017
              
      Patch by David Sosby <dsosby@rim.com> on 2011-03-13
      Reviewed by Dan Bernstein.
      
      The check to flag a text block as hyphenated was only
      occurring at break points in the line. If no break points
      were found after the soft hyphen then the line would not
      be flagged hyphenated. Adding a check for soft hyphen at
      the end of the text run resolves the issue.
      
      Test: fast/text/soft-hyphen-4.html
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::RenderBlock::findNextLineBreak):
      
      LayoutTests: Reviewed and tweaked by Dan Bernstein.
      
      Patch by David Sosby <dsosby@rim.com> on 2011-03-13
      REGRESSION: Soft hyphen is not always rendered
      https://bugs.webkit.org/show_bug.cgi?id=56017
              
      Adding new test that verifies soft hyphen is rendered
      when it is the last breakable point in a line.
      
      * fast/text/soft-hyphen-4-expected.checksum: Added.
      * fast/text/soft-hyphen-4-expected.png: Added.
      * fast/text/soft-hyphen-4-expected.txt: Added.
      * fast/text/soft-hyphen-4.html: Added.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80984 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dad83b38
    • levin@chromium.org's avatar
      Update some baselines due to r80868. · 7c696820
      levin@chromium.org authored
      Also, add MAC to a failure line where I should have put it previously.
      
      * platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.checksum: Added.
      * platform/chromium-mac/fast/backgrounds/animated-svg-as-background-expected.png: Added.
      * platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.checksum: Added.
      * platform/chromium-mac/fast/backgrounds/animated-svg-as-mask-expected.png: Added.
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80983 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      7c696820
    • mitz@apple.com's avatar
      REGRESSION (r80438): fast/text/hyphenate-character failing in pixel mode · e2d0f4a5
      mitz@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=56280
      
      Reviewed by Mark Rowe.
      
      * rendering/RenderBlockLineLayout.cpp:
      (WebCore::tryHyphenating): Avoid subtracting 1 from an unsigned 0.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80982 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      e2d0f4a5
    • weinig@apple.com's avatar
      Add ability to create a WKErrorRef · 3afaa3c4
      weinig@apple.com authored
      <rdar://problem/9115768>
      https://bugs.webkit.org/show_bug.cgi?id=56279
      
      Reviewed by Anders Carlsson.
      
      Source/WebCore: 
      
      * WebCore.exp.in:
      Add new exports.
      
      * platform/network/cf/ResourceError.h:
      * platform/network/cf/ResourceErrorCF.cpp:
      (WebCore::ResourceError::platformCompare):
      (WebCore::ResourceError::cfError):
      (WebCore::ResourceError::operator CFErrorRef):
      (WebCore::ResourceError::ResourceError):
      (WebCore::ResourceError::cfStreamError):
      (WebCore::ResourceError::operator CFStreamError):
      * platform/network/mac/ResourceErrorMac.mm:
      (WebCore::ResourceError::ResourceError):
      (WebCore::ResourceError::platformCompare):
      (WebCore::ResourceError::nsError):
      (WebCore::ResourceError::operator NSError *):
      (WebCore::ResourceError::cfError):
      (WebCore::ResourceError::operator CFErrorRef):
      Clean up ResourceError a bit and add ability to create a ResourceError from a CFErrorRef
      regardless of whether CFNetwork is being used.
      
      Source/WebKit2: 
      
      * Shared/API/c/cf/WKErrorCF.cpp: Added.
      (WKErrorCreateWithCFError):
      (WKErrorCopyCFError):
      * Shared/API/c/cf/WKErrorCF.h: Added.
      Add new API to create a WKErrorRef from a CFErrorRef
      and vice-versa.
      
      * WebKit2.xcodeproj/project.pbxproj:
      * win/WebKit2.vcproj:
      * win/WebKit2Generated.make:
      Add new files.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80981 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      3afaa3c4
    • ggaren@apple.com's avatar
      2011-03-13 Geoffrey Garen <ggaren@apple.com> · c512a2c3
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Removed another case of DeprecatedPtr (PutPropertySlot)
              https://bugs.webkit.org/show_bug.cgi?id=56278
      
              * runtime/PutPropertySlot.h:
              (JSC::PutPropertySlot::setExistingProperty):
              (JSC::PutPropertySlot::setNewProperty):
              (JSC::PutPropertySlot::base): Direct pointer is fine for PutPropertySlot,
              since it's a stack-allocated temporary.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80980 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      c512a2c3
    • levin@chromium.org's avatar
      Add one more failure which is related to change in this range: · dd32eb6e
      levin@chromium.org authored
        http://trac.webkit.org/log/?verbose=on&rev=80866&stop_rev=80860
      that I haven't been able to narrow down yet.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80979 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      dd32eb6e
    • levin@chromium.org's avatar
      Add more crashing tests to an existing bug about the same issue · 0e5680bb
      levin@chromium.org authored
      for Chromium Linux Debug.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80978 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      0e5680bb
    • commit-queue@webkit.org's avatar
      2011-03-13 Joe Wild <joseph.wild@nokia.com> · 812143d4
      commit-queue@webkit.org authored
              Reviewed by Kenneth Rohde Christiansen.
      
              [Qt] QtLauncher does not load the same set of fonts as the DRT
              https://bugs.webkit.org/show_bug.cgi?id=34959
      
              This patch adds the option "-use-test-fonts" to the QtTestBrowser.
              When this option is used the webkit fonts are loaded the same
              as they are in DumpRenderTree.  This option can be used on
              QtTestBrowser and run-launcher.  It can only be used
              on Linux systems with FcInit and is configured as such.
      
              * QtTestBrowser/launcherwindow.h:
              (WindowOptions::WindowOptions):
              * QtTestBrowser/main.cpp:
              (initWebKitTestFonts):
              (launcherMain):
              (LauncherApplication::handleUserOptions):
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80977 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      812143d4
    • ggaren@apple.com's avatar
      2011-03-13 Geoffrey Garen <ggaren@apple.com> · 51f40272
      ggaren@apple.com authored
              Reviewed by Oliver Hunt.
      
              Removed one case of DeprecatedPtr (ScopeChainIterator)
              https://bugs.webkit.org/show_bug.cgi?id=56277
      
              * runtime/ScopeChain.h: Direct pointer is fine for ScopeChainIterator,
              since it's a stack-allocated temporary.
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80976 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      51f40272
    • psolanki@apple.com's avatar
      Make adjustMIMETypeIfNecessary use CFNetwork directly · 9e30b009
      psolanki@apple.com authored
      https://bugs.webkit.org/show_bug.cgi?id=55912
      
      Reviewed by Brady Eidson.
      
      Source/WebCore:
      
      Convert category method [NSURLResponse adjustMIMETypeIfNecessary] to C function
      WebCore::adjustMIMETypeIfNecessary() that takes a CFURLResponseRef and is functionally
      identical.
      
      Testing is covered by existing LayoutTests.
      
      * WebCore.exp.in:
      * platform/mac/WebCoreSystemInterface.h:
      * platform/mac/WebCoreSystemInterface.mm:
      * platform/network/mac/ResourceHandleMac.mm:
      (-[WebCoreResourceHandleAsDelegate connection:didReceiveResponse:]):
      * platform/network/mac/WebCoreURLResponse.h:
      * platform/network/mac/WebCoreURLResponse.mm:
      (WebCore::createBinaryExtensionsSet):
      (WebCore::createExtensionToMIMETypeMap):
      (WebCore::mimeTypeFromUTITree):
      (WebCore::adjustMIMETypeIfNecessary):
      
      Source/WebKit/mac:
      
      * WebCoreSupport/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Support for new WKSI functions.
      
      Source/WebKit2:
      
      * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
      (InitWebCoreSystemInterface): Support for new WKSI functions.
      
      WebKitLibraries:
      
      Add new WKSI functions needed to implement adjustMIMETypeIfNecessary.
      
      * WebKitSystemInterface.h:
      * libWebKitSystemInterfaceLeopard.a:
      * libWebKitSystemInterfaceSnowLeopard.a:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80975 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      9e30b009
  2. 13 Mar, 2011 5 commits
    • levin@chromium.org's avatar
      Fix the expectation to refer to transitions/default-timing-function.html · eccae5c6
      levin@chromium.org authored
      instead of bug1318. My change log description also made the same mistake.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80974 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      eccae5c6
    • levin@chromium.org's avatar
      Sort some test expectations into a better place. Move a linux debug · 6bac980b
      levin@chromium.org authored
      crash to be near the other instances of it.
      
      Remove fast/text/font-size-zero.html as it appears to be passing consistently.
      
      Add the expectation for bug1318.html due to r80806 changing its output in a way
      that looks less optimal than it did before.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80973 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6bac980b
    • barraclough@apple.com's avatar
      Bug 56273 - Add three operand forms to MacroAssember operations. · d8b90842
      barraclough@apple.com authored
      Reviewed by Sam Weinig.
      
      Adding for X86(_64) for now, should be rolled out to other backends as necessary.
      These may allow more efficient code generation in some cases, avoiding the need
      for unnecessary register-register move instructions.
      
      * assembler/AbstractMacroAssembler.h:
      (JSC::AbstractMacroAssembler::Jump::link):
      (JSC::AbstractMacroAssembler::Jump::linkTo):
          - marked these methods const.
      (JSC::AbstractMacroAssembler::Jump::isSet):
          - add a method to check whether a Jump object has been set to
            reference an instruction, or is in a null, unset state. 
      * assembler/MacroAssemblerCodeRef.h:
      (JSC::FunctionPtr::FunctionPtr):
          - add non-explicit constructor, for FunctionPtr's to C/C++ functions.
      * assembler/MacroAssemblerX86Common.h:
      (JSC::MacroAssemblerX86Common::and32):
      (JSC::MacroAssemblerX86Common::lshift32):
      (JSC::MacroAssemblerX86Common::or32):
      (JSC::MacroAssemblerX86Common::rshift32):
      (JSC::MacroAssemblerX86Common::urshift32):
      (JSC::MacroAssemblerX86Common::xor32):
      (JSC::MacroAssemblerX86Common::moveDouble):
      (JSC::MacroAssemblerX86Common::addDouble):
      (JSC::MacroAssemblerX86Common::divDouble):
      (JSC::MacroAssemblerX86Common::subDouble):
      (JSC::MacroAssemblerX86Common::mulDouble):
      (JSC::MacroAssemblerX86Common::branchTruncateDoubleToInt32):
      (JSC::MacroAssemblerX86Common::branchTest32):
      (JSC::MacroAssemblerX86Common::branchTest8):
      (JSC::MacroAssemblerX86Common::branchAdd32):
      (JSC::MacroAssemblerX86Common::branchMul32):
      (JSC::MacroAssemblerX86Common::branchSub32):
          - add three operand forms of these instructions.
      * assembler/MacroAssemblerX86_64.h:
      (JSC::MacroAssemblerX86_64::addDouble):
      (JSC::MacroAssemblerX86_64::convertInt32ToDouble):
      (JSC::MacroAssemblerX86_64::loadPtr):
      (JSC::MacroAssemblerX86_64::branchTestPtr):
      * assembler/X86Assembler.h:
      (JSC::X86Assembler::JmpSrc::isSet):
          - add a method to check whether a JmpSrc object has been set to
            reference an instruction, or is in a null, unset state. 
      (JSC::X86Assembler::movsd_rr):
          - added FP register-register move.
      (JSC::X86Assembler::linkJump):
          - Add an assert to check jumps aren't linked more than once.
      * jit/JITInlineMethods.h:
      (JSC::JIT::emitLoadInt32ToDouble):
          - load integers to the FPU via regsiters on x86-64.
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80972 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      d8b90842
    • levin@chromium.org's avatar
      Add some more crashing tests to an existing bug about the same issue · cdf56833
      levin@chromium.org authored
      for Chromium Linux Debug.
      
      * platform/chromium/test_expectations.txt:
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80971 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      cdf56833
    • barraclough@apple.com's avatar
      ARM build fix. · 6d3d7353
      barraclough@apple.com authored
      * assembler/MacroAssemblerARM.h:
      (JSC::MacroAssemblerARM::load32):
      
      
      
      git-svn-id: svn://svn.chromium.org/blink/trunk@80970 bbb929c8-8fbe-4397-9dbb-9b2b20218538
      6d3d7353