- 09 Nov, 2018 40 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/d864aa84bdd0..27fe62b3b2f9 Created with: gclient setdep -r src-internal@27fe62b3b2f9 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ide3feafba203193666bf297a61a2bb73768a55c5 Reviewed-on: https://chromium-review.googlesource.com/c/1328522Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606761}
-
Marc Treib authored
Some const correctness, some control flow simplification, etc. Also contains one actual fix: Handling errors from |pending_customer_data_query_|. Bug: none Change-Id: I0300b04cc4c32dc9e52dde4a115031390f417e5c Reviewed-on: https://chromium-review.googlesource.com/c/1326483Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#606760}
-
Hiroshige Hayashizaki authored
As preparation for plumbing FetchClientSettingsObject via FetchContext rather than as an argument, this CL exposes GetFetchClientSettingsObject() in FetchContext. NullFetchContext is added just to make FetchContext::GetFetchClientSettingsObject() abstract and FetchContext::NullInstance()'s GetFetchClientSettingsObject() non-null. This CL doesn't change the behavior. Bug: 880027 Change-Id: I02a428d77d202ab88cffd22a3fdf3cd34eff4aca Reviewed-on: https://chromium-review.googlesource.com/c/1200042Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#606759}
-
Christopher Lam authored
System PWAs should not show the Hosted App Button Container UI. This CL hides it on all platforms for System Web Apps. Bug: 836128 Change-Id: I2dc87dea17aa77699f6d6639759645a1c184a2bd Reviewed-on: https://chromium-review.googlesource.com/c/1293294 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Trent Apted <tapted@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#606758}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a1b4306966a4..22b0ec4f83aa git log a1b4306966a4..22b0ec4f83aa --date=short --no-merges --format='%ad %ae %s' 2018-11-09 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 8aa74a426521..635c9b33fe7c (1 commits) Created with: gclient setdep -r src/third_party/skia@22b0ec4f83aa The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I9a4f337eeea51798accf1ef663f111d9524156fb Reviewed-on: https://chromium-review.googlesource.com/c/1328501Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606757}
-
Mitsuru Oshima authored
Bug: 901538 Test: manually tested with squid. Change-Id: I06cf91e0bbcc5281f2f4caf65dc84b0f1833087c Reviewed-on: https://chromium-review.googlesource.com/c/1328161Reviewed-by:
Dominik Laskowski <domlaskowski@chromium.org> Commit-Queue: Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#606756}
-
Hiroshige Hayashizaki authored
Already fixed by https://chromium-review.googlesource.com/1287208. Bug: 655458, 685303, 835717 Change-Id: Id6df7f593db95846375c77918ede9ffcff6316e6 Reviewed-on: https://chromium-review.googlesource.com/c/1328705Reviewed-by:
-
Roberto Carrillo authored
R=jbudorick,stgao,liaoyuke Change-Id: I5ce2f9c8aa14fe5114220ee2438ea48acec4f8a1 Reviewed-on: https://chromium-review.googlesource.com/c/1327165 Commit-Queue: Roberto Carrillo <robertocn@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#606754}
-
Cathy Li authored
Fix homepage IPH auto-disappearing by making it wait until overview mode has finished hiding before showing. Bug: 897600 Change-Id: I99e156e1477d4055333b8e10069959d7e9fefd12 Reviewed-on: https://chromium-review.googlesource.com/c/1318574Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Cathy Li <chili@chromium.org> Cr-Commit-Position: refs/heads/master@{#606753}
-
Yuta Kitamura authored
FakeRendererScheduler is a fake for WebThreadScheduler (formerly known as RendererScheduler), which is public to //content and other files outside Blink. This CL renames its now-obsolete class name. Bug: 826203 Tbr: sky@chromium.org Change-Id: I371bdccd22dc57536193486d72da1cced0d752c0 Reviewed-on: https://chromium-review.googlesource.com/c/1319228 Commit-Queue: Yuta Kitamura <yutak@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#606752}
-
Keishi Hattori authored
Convert bindings code allocations from new to MakeGarbageCollected Bug: 757708 Change-Id: Idb87bbbbd1628dc813140df3bf84608e0d103f46 Reviewed-on: https://chromium-review.googlesource.com/c/1326202Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/d856ca48f425..5d2dfa46c05c git log d856ca48f425..5d2dfa46c05c --date=short --no-merges --format='%ad %ae %s' 2018-11-09 jiajia.qin@intel.com ES31: Add array of arrays support in SSBO 2018-11-09 yizhou.jiang@intel.com Enable texture multisample extension on ES3 D3D Created with: gclient setdep -r src/third_party/angle@5d2dfa46c05c The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=syoussefi@chromium.org Change-Id: I0a5e0f4df77ae8710ae103b8346f78ad4f3c61cc Reviewed-on: https://chromium-review.googlesource.com/c/1328521Reviewed-by:
-
Yutaka Hirano authored
Introduce blink::ReadableStream which is a ScriptWrappable. This CL doesn't change the behavior because the interface is not (yet) exposed. Bug: 894357, 888165, 902633 Change-Id: Ie0f14e0efcc7d48034fff8317ba7f70f3f8ecd3b Reviewed-on: https://chromium-review.googlesource.com/c/1319222Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#606749}
-
Xiaocheng Hu authored
Currently, InlineContents creation and previous/next movement are done by different implementations: - When creating from a position, it traverses the flat tree until finding a node in a usable block flow; - When moving previous/next, it traverses the layout tree until finding a useable block flow. Since these operations are very similar, this patch change the latter to also traverse on flat tree and share the traversal algorithm to reduce duplicated logic. This also makes it easier to change TextOffsetMapping not to cross text control boundaries (*). (*) crrev.com/c/1327962 Bug: 901492 Change-Id: If7c3dd262903c1a0f81166f729614a8d810f5d27 Reviewed-on: https://chromium-review.googlesource.com/c/1327531Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Yoichi Osato <yoichio@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#606748}
-
Sergei Datsenko authored
This allows proper unittests for this code and simplifies further caching of results. BUG=chromium:902600 Change-Id: Ife150c93225e54f6defab814ad5d9c12c8508106 Reviewed-on: https://chromium-review.googlesource.com/c/1327941 Commit-Queue: Sergei Datsenko <dats@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#606747}
-
yiyix authored
When SetNeedsBeginFrame is set to false or it is not scrolling, update the SkippedFrameTracker to idle state. So that the skipped frame tracker only measures the skip frame count during scrolling. Design doc: https://docs.google.com/document/d/1SqqdQsdh9CA5SRHCvkI_FDcc-vBW-saEj1kh4-qTBwg/ Bug: 894149 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: Ifcc23fba56abb6213dcf593f8d272aeab322372a Reviewed-on: https://chromium-review.googlesource.com/c/1284432 Commit-Queue: Yi Xu <yiyix@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606746}
-
Robbie McElrath authored
This reverts commit 7b0677dd. Reason for revert: findit says this broke something. I'll revert and see if it's right tomorrow. Original change's description: > Get NetworkChangeNotifier working on ChromeOS with network service. > > The current NetworkChangeNotifierChromeOS implementation won't work > with the network service enabled because it listens for network changes > from Shill, which only supports a single client. The browser process > has other dependencies on Shill, so it has to be the client for the time > being, meaning the network service can't directly listen for network > changes and has to be notified of them from the browser process. > > This CL splits the NetworkChangeNotifierChromeOS into two parts; > the first will live in the browser process and listen to Shill, while > the second is the actual NetworkChangeNotifierChromeOS implementation > which will have an instance in both the browser and network processes. > Since NetworkChangeNotifierChromeOS can't actually listen for network > changes itself, it just gets notified of changes from part 1 via a new > method in NetworkChangeManager. When the thing listening to Shill sees > a network change, it notifies its local NetworkChangeNotifierChromeOS > instance, and calls the new NetworkChangeManager method, the > implementation of which then notifies the network service's > NetworkChangeNotifierChromeOS instance. > > Bug: 882610 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: Ib220575fbe42f026b1e5cb90d3bb6be9d0345414 > Reviewed-on: https://chromium-review.googlesource.com/c/1274445 > Reviewed-by: Paul Jensen <pauljensen@chromium.org> > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> > Cr-Commit-Position: refs/heads/master@{#606665} TBR=stevenjb@chromium.org,jam@chromium.org,pauljensen@chromium.org,wfh@chromium.org,rmcelrath@chromium.org Change-Id: I1fa2bcabe73082e02e59f7c613d08aec4ac94e57 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 882610 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/c/1328701Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#606745}
-
Sebastien Marchand authored
This feature is already enabled on Stable, see https://cs.chromium.org/chromium/src/third_party/blink/renderer/platform/runtime_enabled_features.json5?l=901&rcl=ba0d48f8b3e768e554f6b30d7ab04e3f0e907e61 Change-Id: I070350276f861f717bcb1cf51e45cb7dc8963c1b Reviewed-on: https://chromium-review.googlesource.com/c/1327445Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#606744}
-
Jia authored
All jobs will run on the main UI thread except the blocking ones that will run on a blocking task runner (created by the relevant object). The following tasks will run on a blocking task runner: 1. AlsReaderImpl (i). Running cmd to - Check if Als is enabled. - Get Als config. - Get path to Als file from which we'll read Als values. (ii). Reading Als values. 2. ModellerImpl (i). Load curve from disk and save curve to disk. (ii). Call trainer to - Set its initial curves. - Train a model. Hence trainer needs to be associated with the blocking task runner via base::OnTaskRunnerDeleter. Bug: 881215 Change-Id: Iecb5805304c5aa6e0a1b194e136b81ed97534d7b Reviewed-on: https://chromium-review.googlesource.com/c/1321655Reviewed-by:
Andrew Moylan <amoylan@chromium.org> Commit-Queue: Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#606743}
-
Trent Apted authored
Instead, load it lazily the first time a testing extension connects and wants to use the remote call APIs. This avoids having to parse the testing code every time any of the ui/file_manager apps start up (in release, or in tests). Note that current tests (e.g. gallery) may start up a background page with this test code up to *four times* for each test. After this change, only the app under test will load the testing code. There may still be some added latency. To help balance that, this CL caches the result of RemoteCall.isStepByStepEnabled(). That makes it consistent with the newly added function anyway. This still distributes the testing code in release, which is not ideal. Loading from a filesystem:// URL might avoid that in future. This should probably also use an ES6 module.. Baby steps. Bug: 903669 Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I7acf6b55b10fa775d40bae48b81b0cfd1859df56 Reviewed-on: https://chromium-review.googlesource.com/c/1322340 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606742}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/93cd73d98000..98c0fdb927c4 git log 93cd73d98000..98c0fdb927c4 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 yyanagisawa@chromium.org Add autoninja* to .gitattributes. Created with: gclient setdep -r src/third_party/depot_tools@98c0fdb927c4 The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:b/77176746 TBR=agable@chromium.org Change-Id: I16257307b8e92d5b93736666ee2d76ce8e02e83a Reviewed-on: https://chromium-review.googlesource.com/c/1328101Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/1146fdaf9e34..d864aa84bdd0 Created with: gclient setdep -r src-internal@d864aa84bdd0 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ic4a67812b9b22953ac3f8b6efa1f8d1d625319fa Reviewed-on: https://chromium-review.googlesource.com/c/1328245Reviewed-by:
-
Yoichi Osato authored
This patch introduces DCHECK in FrameSelection::SetSelectionDeprecated so that user's selection start/end should have same editability for code sanity. Bug: 789870 Change-Id: Ia01192e61a9f27e2ddeef24e385b23a62a572174 Reviewed-on: https://chromium-review.googlesource.com/c/1325286Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
-
Yusuke Sato authored
Since we no longer ship 23, |is_M| is always false. BUG=None TEST=try Change-Id: Ia2e05b6d8c8c92c9dfa617644b861fff29695bbb Reviewed-on: https://chromium-review.googlesource.com/c/1327610Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Commit-Queue: Yusuke Sato <yusukes@chromium.org> Cr-Commit-Position: refs/heads/master@{#606738}
-
Zhuoyu Qian authored
This patch makes file_error::ErrorCode to be an enum class for better type safety and improving code health. Using forward declaration in other header files instead of including |file_error.h|. Change-Id: I53eae14c2972bb792b474d36e4b8c4bc52c09b0f Reviewed-on: https://chromium-review.googlesource.com/c/1314083Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Zhuoyu Qian <zhuoyu.qian@samsung.com> Cr-Commit-Position: refs/heads/master@{#606737}
-
Jay Harris authored
Previously, we would always display the current page's title in the window title. This updates the logic so we display the app name when off scope (the page title will be displayed in the custom tab bar). Bug: 853593 Change-Id: Id24d3104386a5334c331599480f0b1ce269ba9e1 Reviewed-on: https://chromium-review.googlesource.com/c/1319214Reviewed-by:
Matt Giuca <mgiuca@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#606736}
-
Fergus Dall authored
Currently, if crostini installation fails for any reason, including because the user canceled it, we abort and leave behind any downloaded files, disk images etc. and only delete these if the user explicitly uninstalls crostini. This is both confusing to the user (why does crostini show up in the app launcher if the install failed/was canceled?) and leaves a bunch of files on disk that they don't want. This CL changes the behavior of the cancel button on the install dialogue to invoke the existing CrostiniRemover logic. As a protection against accidental destruction of user data, this CL also checks if a VM disk already existed when the CreateDiskImage step was run, and if so skips the uninstall logic. This requires passing the result status from concierge back up to the installer view. Bug: 898739 Change-Id: Id6a8a36dfcb59feec4da6d11efa453e1f15e07b5 Reviewed-on: https://chromium-review.googlesource.com/c/1316980Reviewed-by:
Renée Wright <rjwright@chromium.org> Reviewed-by:
Nicholas Verne <nverne@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#606735}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/df3a6eee1315..a1b4306966a4 git log df3a6eee1315..a1b4306966a4 --date=short --no-merges --format='%ad %ae %s' 2018-11-09 benjaminwagner@google.com Update Win10 in Skolo. 2018-11-09 caryclark@skia.org fix doc paint hinting examples 2018-11-08 skia-bookmaker@skia-swarming-bots.iam.gserviceaccount.com Update markdown files 2018-11-08 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 825d344daa31..8aa74a426521 (1 commits) 2018-11-08 recipe-roller@chromium.org Roll recipe dependencies (trivial). Created with: gclient setdep -r src/third_party/skia@a1b4306966a4 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=allanmac@chromium.org Change-Id: I1011f2ccb3e180612b286c6cfdf6ccbd5ca96a0c Reviewed-on: https://chromium-review.googlesource.com/c/1328441Reviewed-by:
-
John Chen authored
Per W3C spec, unrecognized capabilities should trigger invalid argument error, instead of being silently ignored. Bug: chromedriver:1997 Change-Id: I84b2a888ad97d709737368b9394c8efdd475bf3a Reviewed-on: https://chromium-review.googlesource.com/c/1325562Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#606733}
-
Darren Shen authored
The KeyboardController state machine is quite complicated (e.g. transient blurs, background loading) and could be prone to change. We should not be breaking encapsulation by exposing this implementation detail to external classes. We remove KeyboardControllerObserver::OnStateChanged. The only observers of this event are observing when the keyboard is shown or hidden. This can be done with the OnKeyboardVisibilityStateChanged event instead. TBR=edcourtney@chromium.org Bug: 845780 Change-Id: I19fe82dc97495d8df05c1155a42cea06d3de10c5 Reviewed-on: https://chromium-review.googlesource.com/c/1128661 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#606732}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=abdulsyed@chromiue.org Change-Id: I44b3f762637beeed55ee3552dcd32c6dc79e8ccd Reviewed-on: https://chromium-review.googlesource.com/c/1328186Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#606731}
-
Kent Tamura authored
type-change-state.html assumed sanitized value for " foo\rbar " was fixed per a input type, and it was specified by 'sanitizedValue' field. However, it depends on the previous type. For example, the new input types of the following A and B are same, initial value setter arguments are same, but sanitized values of A and B should be different due to the sanitizer difference between 'hidden' and 'url': A) input.type = "hidden"; input.value = " foo\rbar "; // input.value is " foo\rbar " input.type = "text"; // input.value is " foobar ". B) input.type = "url"; input.value = " foo\rbar "; // input.value is "foobar" input.type = "text"; // input.value is "foobar". This CL fixes this issue by replacing 'sanitizedValue' field with 'sanitizer' field, which specifies a simple sanitizer implementation. This fixes five test cases, which have failed with all major browsers. Change-Id: I1b5f75e610138b1d117e93723471427ee655c300 Reviewed-on: https://chromium-review.googlesource.com/c/1326203 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/af8c416e43c0..1146fdaf9e34 Created with: gclient setdep -r src-internal@1146fdaf9e34 The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie60b9e14d6976854e96079d2085bdc2ad2e12104 Reviewed-on: https://chromium-review.googlesource.com/c/1327982Reviewed-by:
-
Noel Gordon authored
The TODO has no associateed bug: created one & point the TODO at it. No change in behavior, comment only change. Bug: 903637, 903587 Change-Id: I087759922064ec3ce6278757542b14c3dc4c5df3 Reviewed-on: https://chromium-review.googlesource.com/c/1327942Reviewed-by:
Anand Mistry <amistry@chromium.org> Commit-Queue: Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#606728}
-
Tatsuhisa Yamaguchi authored
Test: Manually verified on device, and with ChromeVox Bug: 888072 Change-Id: I770d7bc1ec207a2052c3f7e5956e212930719e12 Reviewed-on: https://chromium-review.googlesource.com/c/1317112 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#606727}
-
Antonio Gomes authored
network::mojom::URLLoaderFactory has stricter threading restrictions than its predecessor (URLRequestContextGetter) - see [1]. This CL adapts an existing subset of chromedriver unittests (namely FetchUrlTest), that deals with url fetching, to this threading restrictions. Basically, the CL allows the test to inject the TaskRunner that the URLLoaderFactory handle was created on, and use it afterwards. A similar approach to this one (of injecting a test-specific TaskRunner instance) was also used in [2]. [1] https://crrev.com/c/1292933 [2] https://crrev.com/c/1174655/14/components/sync/engine/net/http_bridge.cc#148 BUG=902618 Change-Id: If37bfee8cc891c1a95491cfeb3febf5fe673f52e Reviewed-on: https://chromium-review.googlesource.com/c/1327443Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#606726}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 3b5865d0. With Chromium commits locally applied on WPT: 270d4abd "ServiceWorker: Add new WPT tests to make sure to update a registration with different script type and identical script content." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hongchan@chromium.org, rtoy@chromium.org: external/wpt/webaudio NOAUTOREVERT=true TBR=robertma No-Export: true Change-Id: I6d491458a3b1d9ba02bd260ce31e5ce28890f75a Reviewed-on: https://chromium-review.googlesource.com/c/1328167 Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#606725}
-
Hayato Ito authored
See bug 902661 for the context. Several tests in perf_test/DOM should be in perf_tests/Editing. Bug: 902661 Change-Id: I9e668181f4642f989c62bf2511af6ca71dd523fe Reviewed-on: https://chromium-review.googlesource.com/c/1325271Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Hayato Ito <hayato@chromium.org> Cr-Commit-Position: refs/heads/master@{#606724}
-
Andrey Lushnikov authored
This patch introduces a new 'Copy js path' option to the context menu that allows to get a JavaScript reference to the object in the DOM Tree. This comes handy when dealing with Shadow DOM trees. R=dgozman Change-Id: I07a77597f88b6cc500baed8ae9ee097b35d79b4f Reviewed-on: https://chromium-review.googlesource.com/c/1300756 Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org> Reviewed-by:
Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#606723}
-
Jay Harris authored
Bug: 902615 Change-Id: I3efabd8d9446d4340a8c7aac47858f92716c8ea5 Reviewed-on: https://chromium-review.googlesource.com/c/1322011Reviewed-by:
Ben Wells <benwells@chromium.org> Commit-Queue: Jay Harris <harrisjay@chromium.org> Cr-Commit-Position: refs/heads/master@{#606722}
-
